feat: add support for className to FormControl.Validation #5984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 125f4b9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for a custom className prop to FormControl.Validation.
- Updates the InputValidation component to accept and pass through a className prop using clsx.
- Propagates the className prop in the internal FormControlValidation component.
- Adds a test ensuring the className prop is correctly applied.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/react/src/internal/components/InputValidation.tsx | Allows a custom className by augmenting the component's props and using clsx to merge classes. |
| packages/react/src/FormControl/_FormControlValidation.tsx | Passes the className prop to the InputValidation component. |
| packages/react/src/FormControl/tests/FormControl.Validation.test.tsx | Adds a test to validate that the custom className is applied correctly. |
| .changeset/fine-bugs-shine.md | Documents the minor release change for adding className support. |
jonrohan
approved these changes
Apr 29, 2025
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
Merged
hectahertz
pushed a commit
that referenced
this pull request
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for
classNametoFormControl.ValidationChangelog
New
classNametoFormControl.ValidationChanged
Removed
Rollout strategy