Skip to content

cacheprovider: --lf file-skipping feature doesn't work for non-python files #11068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bluetech opened this issue Jun 2, 2023 · 0 comments · Fixed by #11069
Closed

cacheprovider: --lf file-skipping feature doesn't work for non-python files #11068

bluetech opened this issue Jun 2, 2023 · 0 comments · Fixed by #11069
Assignees
@bluetech
Labels
plugin: cache related to the cache builtin plugin topic: collection related to the collection phase type: bug problem that needs to be addressed

Comments

@bluetech
Copy link
Member

bluetech commented Jun 2, 2023

For non-python files (as in https://docs.pytest.org/en/latest/example/nonpython.html), the whole-file-skipping feature ("skipped N files") doesn't work. This is because the codes checks for Modules when it should check for File.
@bluetech bluetech self-assigned this Jun 2, 2023
@bluetech bluetech added type: bug problem that needs to be addressed plugin: cache related to the cache builtin plugin topic: collection related to the collection phase labels Jun 2, 2023
bluetech added a commit to bluetech/pytest that referenced this issue Jun 2, 2023
@bluetech
cacheprovider: make file-skipping work with any File, not just Modules
391cd2c 
No reason for `--lf`'s whole-file-skipping feature to not for for
non-Python files.

Fix pytest-dev#11068.
@bluetech bluetech mentioned this issue Jun 2, 2023
Merged
bluetech added a commit to bluetech/pytest that referenced this issue Jun 3, 2023
@bluetech
cacheprovider: make file-skipping work with any File, not just Modules
fda8024 
No reason for `--lf`'s whole-file-skipping feature to not for for
non-Python files.

Fix pytest-dev#11068.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bluetech bluetech

Labels
plugin: cache related to the cache builtin plugin topic: collection related to the collection phase type: bug problem that needs to be addressed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cacheprovider: make file-skipping work with any File, not just Modules bluetech/pytest
1 participant
@bluetech