Skip to content

Commit f0e67d8

Browse files
feat: support for Table ACLs (#653)
* feat: bigquery table acls * incremental updates * syntax * cleanup warnings * add policy conversion tests * add BigQueryImpl testing * cleanup tests * address mock issue * plumb in testIamPermissions and impl test * add integration test * drop empty check * allow more permissive policy conversions for (empty bindings) * more null fun * add clirr-ignored-differences.xml for new methods added to interfaces Co-authored-by: stephwang <[email protected]>
1 parent f08becc commit f0e67d8

File tree

13 files changed

+980
-403
lines changed

13 files changed

+980
-403
lines changed
Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,35 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<!-- see http://www.mojohaus.org/clirr-maven-plugin/examples/ignored-differences.html -->
3+
<differences>
4+
<!--TODO: To be removed-->
5+
<difference>
6+
<differenceType>7012</differenceType>
7+
<className>com/google/cloud/bigquery/BigQuery</className>
8+
<method>com.google.cloud.Policy getIamPolicy(com.google.cloud.bigquery.TableId, com.google.cloud.bigquery.BigQuery$IAMOption[])</method>
9+
</difference>
10+
<difference>
11+
<differenceType>7012</differenceType>
12+
<className>com/google/cloud/bigquery/BigQuery</className>
13+
<method>com.google.cloud.Policy setIamPolicy(com.google.cloud.bigquery.TableId, com.google.cloud.Policy, com.google.cloud.bigquery.BigQuery$IAMOption[])</method>
14+
</difference>
15+
<difference>
16+
<differenceType>7012</differenceType>
17+
<className>com/google/cloud/bigquery/BigQuery</className>
18+
<method>java.util.List testIamPermissions(com.google.cloud.bigquery.TableId, java.util.List, com.google.cloud.bigquery.BigQuery$IAMOption[])</method>
19+
</difference>
20+
<difference>
21+
<differenceType>7012</differenceType>
22+
<className>com/google/cloud/bigquery/spi/v2/BigQueryRpc</className>
23+
<method>com.google.api.services.bigquery.model.Policy getIamPolicy(java.lang.String, java.util.Map)</method>
24+
</difference>
25+
<difference>
26+
<differenceType>7012</differenceType>
27+
<className>com/google/cloud/bigquery/spi/v2/BigQueryRpc</className>
28+
<method>com.google.api.services.bigquery.model.Policy setIamPolicy(java.lang.String, com.google.api.services.bigquery.model.Policy, java.util.Map)</method>
29+
</difference>
30+
<difference>
31+
<differenceType>7012</differenceType>
32+
<className>com/google/cloud/bigquery/spi/v2/BigQueryRpc</className>
33+
<method>com.google.api.services.bigquery.model.TestIamPermissionsResponse testIamPermissions(java.lang.String, java.util.List, java.util.Map)</method>
34+
</difference>
35+
</differences>

google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/Acl.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -393,6 +393,7 @@ Access toPb() {
393393
*/
394394
public static final class IamMember extends Entity {
395395

396+
private static final long serialVersionUID = 3562909264454016939L;
396397
private final String iamMember;
397398

398399
/** Creates a iamMember entity given the iamMember. */

0 commit comments

Comments
 (0)