Skip to content

Commit 18576f5

Browse files
fix: fix maven test configs to make sure admin tests don't clobber data tests (#47)
* fix: fix maven test configs to make sure admin tests don't clobber data tests * Update include patterns
1 parent a16cb88 commit 18576f5

File tree

1 file changed

+10
-6
lines changed

1 file changed

+10
-6
lines changed

google-cloud-bigtable/pom.xml

+10-6
Original file line numberDiff line numberDiff line change
@@ -206,8 +206,9 @@
206206
<systemPropertyVariables>
207207
<bigtable.env>emulator</bigtable.env>
208208
</systemPropertyVariables>
209-
<test>com.google.cloud.bigtable.data.v2.it.**</test>
210-
<test>com.google.cloud.bigtable.admin.v2.it.**</test>
209+
<includes>
210+
<include>com.google.cloud.bigtable.**.it.*IT</include>
211+
</includes>
211212
<summaryFile>${project.build.directory}/failsafe-reports/failsafe-summary-emulator-it.xml</summaryFile>
212213
</configuration>
213214
</execution>
@@ -234,8 +235,9 @@
234235
<systemPropertyVariables>
235236
<bigtable.env>prod</bigtable.env>
236237
</systemPropertyVariables>
237-
<test>com.google.cloud.bigtable.data.v2.it.**</test>
238-
<test>com.google.cloud.bigtable.admin.v2.it.**</test>
238+
<includes>
239+
<include>com.google.cloud.bigtable.**.it.*IT</include>
240+
</includes>
239241
<summaryFile>${project.build.directory}/failsafe-reports/failsafe-summary-prod-it.xml</summaryFile>
240242
</configuration>
241243
</execution>
@@ -268,8 +270,10 @@
268270
<environmentVariables>
269271
<GOOGLE_CLOUD_ENABLE_DIRECT_PATH>bigtable</GOOGLE_CLOUD_ENABLE_DIRECT_PATH>
270272
</environmentVariables>
271-
<!-- TODO(igorbernstein): Once the control plane is accessible via directpath, add admin tests -->
272-
<test>com.google.cloud.bigtable.data.v2.it.**</test>
273+
<includes>
274+
<!-- TODO(igorbernstein): Once the control plane is accessible via directpath, add admin tests -->
275+
<include>com.google.cloud.bigtable.data.v2.it.*IT</include>
276+
</includes>
273277
<summaryFile>${project.build.directory}/failsafe-reports/failsafe-summary-directpath-it.xml</summaryFile>
274278
</configuration>
275279
</execution>

0 commit comments

Comments
 (0)