-
Notifications
You must be signed in to change notification settings - Fork 97
feat: Add Experimental DirectPath support #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c0a77ef
to
27fa823
Compare
Codecov Report
@@ Coverage Diff @@
## master #8 +/- ##
============================================
- Coverage 81.1% 80.99% -0.12%
Complexity 914 914
============================================
Files 93 93
Lines 5701 5714 +13
Branches 302 307 +5
============================================
+ Hits 4624 4628 +4
- Misses 919 925 +6
- Partials 158 161 +3
Continue to review full report at Codecov.
|
kolea2
approved these changes
Oct 23, 2019
lgtm after code format |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously DirectPath support was enabled only in a test profile. Now the support is being pulled into the actually client. This functionality is currently in private alpha testing and will only be available to some customers. A lot of the changes in this PR are temporary, and will be removed once DirectPath goes public using the default endpoint.
The endpoint hasn't rolled out yet, but I was able to confirm that this works with the old test endpoint. The new endpoint should be live tomorrow