Skip to content

Commit db358c8

Browse files
authored
fix: prevent NPE in RemoteStorageHelper.cleanBuckets (#492)
The method getEventBasedHold and getTemporaryHold return Boolean objects which are either true, false or null. In case of a null value, this produced a NPE.
1 parent 0e4f70f commit db358c8

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

google-cloud-storage/src/main/java/com/google/cloud/storage/testing/RemoteStorageHelper.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,8 @@ public void run() {
8888
Storage.BlobField.EVENT_BASED_HOLD,
8989
Storage.BlobField.TEMPORARY_HOLD))
9090
.iterateAll()) {
91-
if (blob.getEventBasedHold() == true || blob.getTemporaryHold() == true) {
91+
if (Boolean.TRUE.equals(blob.getEventBasedHold())
92+
|| Boolean.TRUE.equals(blob.getTemporaryHold())) {
9293
storage.update(
9394
blob.toBuilder().setTemporaryHold(false).setEventBasedHold(false).build(),
9495
Storage.BlobTargetOption.userProject(

0 commit comments

Comments
 (0)