This repository was archived by the owner on Sep 16, 2023. It is now read-only.
docs: clarify that project number is used as the canonical project identifier for job and job template names #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entifier for job and job template names docs: fix broken link and code formatting feat: add support for allow_missing param on DELETE request fix!: remove Encryption settings that were published due to a sync issue BREAKING CHANGE: requests specifying Encryption settings are rejected by the server PiperOrigin-RevId: 401033248 Source-Link: googleapis/googleapis@ef9130f Source-Link: https://github.com/googleapis/googleapis-gen/commit/9ebec3346a64690c063eb72f1b1c1d6d279177ce Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOWViZWMzMzQ2YTY0NjkwYzA2M2ViNzJmMWIxYzFkNmQyNzkxNzdjZSJ9
|
verify the breaking change before merging. |
Looks like the clirr errors are all about Encryption. The PR description says
So I think it was an accident that these were published, and this PR is correcting them. |
|
@Neenu1995 does the above make sense? |
|
Looking at the discussion in the CL, looks like this doesn't break any customers. Also, java is pre GA for this library. So we can take on the change as a minor version bump. |
chanseokoh
approved these changes
Oct 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs: fix broken link and code formatting
feat: add support for allow_missing param on DELETE request
fix!: remove Encryption settings that were published due to a sync issue
BREAKING CHANGE: requests specifying Encryption settings are rejected by the server
PiperOrigin-RevId: 401033248
Source-Link: googleapis/googleapis@ef9130f
Source-Link: https://github.com/googleapis/googleapis-gen/commit/9ebec3346a64690c063eb72f1b1c1d6d279177ce
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOWViZWMzMzQ2YTY0NjkwYzA2M2ViNzJmMWIxYzFkNmQyNzkxNzdjZSJ9