feat: enable reduction server #741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
da33a28 to
99312e6
Compare
ivanmkc
reviewed
Oct 1, 2021
ivanmkc
reviewed
Oct 1, 2021
ivanmkc
reviewed
Oct 1, 2021
ivanmkc
reviewed
Oct 1, 2021
ivanmkc
reviewed
Oct 1, 2021
ivanmkc
reviewed
Oct 1, 2021
ivanmkc
reviewed
Oct 1, 2021
ivanmkc
reviewed
Oct 1, 2021
| reduction_server_machine_type=reduction_server_machine_type, | ||
| ) | ||
|
|
||
| worker_pool_specs = worker_pool_specs.pool_specs |
There was a problem hiding this comment.
This changes the type of the variable. Although allowable in Python, prefer not to do that for readability purposes.
sasha-gitg
requested changes
Oct 6, 2021
| @@ -86,6 +91,10 @@ def spec_dict(self) -> Dict[str, Union[int, str, Dict[str, Union[int, str]]]]: | |||
| spec["machine_spec"]["accelerator_type"] = accelerator_type | |||
| spec["machine_spec"]["accelerator_count"] = self.accelerator_count | |||
|
|
|||
| if self.container_uri == REDUCTION_SERVER_CONTAINER_URI: | |||
There was a problem hiding this comment.
For now, I think it may be more extendable to add container_spec whenever self.container_uri is populated.
99312e6 to
a51daae
Compare
sasha-gitg
requested changes
Oct 15, 2021
7fe79b0 to
d473d24
Compare
d473d24 to
9dac2a9
Compare
sasha-gitg
approved these changes
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #<b/197889114> 🦕