Skip to content
This repository was archived by the owner on Dec 31, 2023. It is now read-only.

fix: fix extra_require typo #202

Merged
merged 1 commit into from
Oct 28, 2021
Merged

Conversation

major
Copy link
Contributor

@major major commented Oct 28, 2021

This allows someone to install the module with the [libcst] extra.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #203 🦕

@major major requested review from a team as code owners October 28, 2021 11:39
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 28, 2021
@product-auto-label product-auto-label bot added the api: containeranalysis Issues related to the googleapis/python-containeranalysis API. label Oct 28, 2021
This allows someone to install the module with the `[libcst]` extra.

Signed-off-by: Major Hayden <[email protected]>
@major major changed the title setup.py: Fix extra_require typo fix: fix extra_require typo Oct 28, 2021
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding and fixing this!

@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Oct 28, 2021
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Oct 28, 2021
@parthea parthea added the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Oct 28, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 2948965 into googleapis:main Oct 28, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Oct 28, 2021
@major major deleted the patch-1 branch October 28, 2021 18:21
@major
Copy link
Contributor Author

major commented Oct 28, 2021

Thanks for finding and fixing this!

You're welcome! 🤗

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: containeranalysis Issues related to the googleapis/python-containeranalysis API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot install libcst extra package
3 participants