Skip to content

Commit d4a86ce

Browse files
authored
fix: remove trailing commas from error message constants (#505)
The _DOWNLOAD_AS_STRING_DEPRECATED constant includes a dangling comma which makes it a tuple and not a string. This causes a TypeError as reported in #501. Fixes #501
1 parent b62b727 commit d4a86ce

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

google/cloud/storage/blob.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@
119119
_COMPOSE_IF_GENERATION_LIST_DEPRECATED = (
120120
"'if_generation_match: type list' is deprecated and supported for "
121121
"backwards-compatability reasons only. Use 'if_source_generation_match' "
122-
"instead' to match source objects' generations.",
122+
"instead' to match source objects' generations."
123123
)
124124
_COMPOSE_IF_GENERATION_LIST_AND_IF_SOURCE_GENERATION_ERROR = (
125125
"Use 'if_generation_match' to match the generation of the destination "
@@ -130,14 +130,14 @@
130130
"'if_metageneration_match: type list' is deprecated and supported for "
131131
"backwards-compatability reasons only. Note that the metageneration to "
132132
"be matched is that of the destination blob. Please pass in a single "
133-
"value (type long).",
133+
"value (type long)."
134134
)
135135
_COMPOSE_IF_SOURCE_GENERATION_MISMATCH_ERROR = (
136136
"'if_source_generation_match' length must be the same as 'sources' length"
137137
)
138138
_DOWNLOAD_AS_STRING_DEPRECATED = (
139139
"Blob.download_as_string() is deprecated and will be removed in future. "
140-
"Use Blob.download_as_bytes() instead.",
140+
"Use Blob.download_as_bytes() instead."
141141
)
142142

143143

0 commit comments

Comments
 (0)