Scribd
Upload
33 views

Task 1 - Software Engineering Task: Code Changes

This document provides instructions for setting up a development environment and making code changes to correct inaccuracies in a stock price program. It outlines prerequisites like having the server and client apps running successfully. It describes objectives to fix ratios always being 1 and prices matching bid prices. It explains how to open relevant files in an editor and make changes to the client.py file, specifically in the getDataPoint, getRatio, and main methods to compute the correct stock price as the average of bid and ask prices and return the proper ratio of stock prices.

Uploaded by

abhi goyal
Copyright
© © All Rights Reserved
Available Formats
Download as PDF, TXT or read online on Scribd
33 views

Task 1 - Software Engineering Task: Code Changes

This document provides instructions for setting up a development environment and making code changes to correct inaccuracies in a stock price program. It outlines prerequisites like having the server and client apps running successfully. It describes objectives to fix ratios always being 1 and prices matching bid prices. It explains how to open relevant files in an editor and make changes to the client.py file, specifically in the getDataPoint, getRatio, and main methods to compute the correct stock price as the average of bid and ask prices and return the proper ratio of stock prices.

Uploaded by

abhi goyal
Copyright
© © All Rights Reserved
Available Formats
Download as PDF, TXT or read online on Scribd
You are on page 1/ 15

JPMorgan Chase Software Engineering Virtual Experience

Task 1 - software engineering


task : code changes
Module 1 - Interface with a stock price data feed and
create tests for it
Setting up your dev environment for the program!

Disclaimer
● This guide is only for those who did the setup locally on their machines.
● For those using REPL, see the REPL guide in the Instructions file of your
REPL environment
Setting up your dev environment for the program!

Prerequisite
● Set up should have been done. This means,your server and client
applications should have been running with no problems without introducing
any changes to the code yet. You can verify this if you get a similar result to
any of the following slides that include a picture of the server and client app
running together
Setting up your dev environment for the program!

Prerequisite
Mac OS (left side server, right side client)
Setting up your dev environment for the program!

Prerequisite
Windows OS (left side server, right side client)
Setting up your dev environment for the program!

Prerequisite
Linux OS (left side server, right side client)
Setting up your dev environment for the program!

Objectives
● If you closely inspect the output of the client applications in the previous
slides, there are two incorrect things…

○ (1) Ratio is always 1


○ (2) The price of each stock is always the same as its bid_price.

● These are obviously wrong so you job is to fix those things…

● Don’t worry we’ll walk you through how to get these things done
Setting up your dev environment for the program!

How to make changes to code


● You’ll be making changes to the code in the some of the files within the
repository you cloned or downloaded to achieve the objectives the task.

● To do this, you can use any text editor your machine has and just open the
files in the repository that must be changed (the guide will instruct you in the
following slides which files these will be)

● Our recommendation of editors you can use would be VSCode or


SublimeText as these are the most commonly used code editors out there.
Setting up your dev environment for the program!

Making changes in `client.py` (client3.py for python3)


● All the changes you have make to get the right output will be in the client.py
file inside the repository (client3.py if you’re in python3 REPL)

● The changes you need to make will be in the following methods of the file
○ getDataPoint
○ getRatio
○ Main

● The changes for each method will be dissected for each method on the next
slide
Setting up your dev environment for the program!

Making changes in `client.py` (client3.py for python3)


getDataPoint
getDataPoint. In this method, you'll have to make the modifications to compute
for the right stock price. This means you have to change how `price` is computed
for. The formula is (bid_price+ask_price) / 2.

YOU DO NOT NEED TO CHANGE the return value as that is representational of


the entire data point. You should end up with something like:
Setting up your dev environment for the program!

Making changes in `client.py` (client3.py for python3)


getRatio
getRatio. In the original case, this method just returns 1 all the time. To correct
this, you must change the return value to the ratio of stock price_a to stock
price_b

note: that we’ve also added the condition of the case where in price_b could be zero, i.e. division by zero,
in the rare chance that it might happen...
Setting up your dev environment for the program!

Making changes in `client.py` (client3.py for python3)


main
main method. Now that you've fixed the two other methods, it's just a matter of
printing the correct values. For every iteration in the main method, you need to
store the datapoints you get from getDataPoint method so that you can properly
call getRatio and print the right ratio out. (the below image is for python 2.7.x version)
Setting up your dev environment for the program!

Making changes in `client.py` (client3.py for python3)


main
main method. (the image here is now for python 3.x version)

There’s also a slight difference in the urllib that’s used


for python3 but you don’t have to bother with this
Setting up your dev environment for the program!

Making changes in `client.py` (client3.py for python3)


main
● To review the changes in main (whether it was in python2 or python3), what we did
was create a prices dictionary to store the stock prices. Think of a dictionary
as a key-value store wherein you can specify a key and be able to retrieve a
value. In our case, they key was the stock name and the value was the price.

● We then used this prices dictionary at the end to pass in the right values in
the getRatio function.
Setting up your dev environment for the program!

Next step
● You’re done with the main task. You can either create your patch file now by
following this guide, or try and do the bonus task first

You might also like