Fix Your Broken Windows With Code Reviews - phpist14

May 4, 2014136 likes12,859 views

The slides are from my latest talk in phpist14, one of the biggest php conference of Istanbul being organized by phpist.org community. It's about Code Review processes, types, reasons, best practices, tips & tricks, how to establish in software development flows and the way we do in my company for years.

Fix Your Broken Windows With Code Reviews - phpist14

The document discusses how to motivate developers by creating an environment that improves passion, discipline and motivation. It suggests building human-centric practices like Lean, Craftsmanship and Agility that foster collaboration, continuous learning, trust and empowerment. Mindset is more important than tools, and managers must provide safe environments for trial and error to encourage innovation.

Java Exception Handling Best Practices - Improved Second VersionLemi Orhan Ergin

Git and Git Workflow Models as Catalysts of Software DevelopmentLemi Orhan Ergin

Unleashed Power Behind The Myths: Pair Programming (CraftSummit15)Lemi Orhan Ergin

Code Your Agility - Tips for Boosting Technical Agility in Your OrganizationLemi Orhan Ergin

How Do You Build Software? Software Engineering Practices of an Agile DeveloperLemi Orhan Ergin

Global Day of Coderetreat'14 - Istanbul EventLemi Orhan Ergin

Let The Elephants Leave The Room - Remove Waste in Software Development - Bos...Lemi Orhan Ergin

Lost in Motivation in an Agile WorldLemi Orhan Ergin

This document discusses how to improve motivation in agile work environments. It argues that money does not lead to engagement and that practices focusing on human relationships and professionalism are more effective. These include building trust, collaboration, mentorship, positive feedback, and ensuring teams have purpose and fun. Adopting a mindset of servant leadership and allowing people to invest in themselves can help foster motivation.

Software Craftsmanship - Building A Culture For The Future (GDG DevFest Istan...Lemi Orhan Ergin

Trespassing The Forgotten and Abandoned: Ethics in Software DevelopmentLemi Orhan Ergin

Let me guess what you think. You think you are smart, you think you do a good job and you think you really love software development. You think you can program 24 hours a day if you are able to do so. You also think that software development is a profession and you are a member of such a huge great community. You feel proud of what you are belonging to. At this point I am sure that only a very few of you do your profession under the lights of ethics in software development. As in every professions, software development has a common set of ethical values, behaviors and rules. That might be the most forgotten and abandoned area in our profession and my main goal is to trespass it with this presentation. I presented the slides at Voxxed Days Istanbul 2015 Conference on 9th of May, 2015.

TDD - Inevitable Challenge for Software Developers (phpkonf15 keynote)Lemi Orhan Ergin

Test Driven Design - GDG DevFest Istanbul 2016Lemi Orhan Ergin

Scaling your code reviewSander Bol

WordCamp US 2016 - Ryan Markel: Code Reviewthemarkel

This document discusses the importance and process of code review. It begins by introducing the speaker and their experience with WordPress.com VIP. Code review is described as important for finding issues, improving quality, and learning. The WordPress.com VIP code review process is then outlined, including automatic and manual reviews of commits. Tools for personal and team code reviews are also suggested, like GitHub pull requests and diff reviews. The presentation emphasizes that code review should be a regular part of the development process.

Would Static Analysis Tools Help Developers with Code Reviews?Sebastiano Panichella

Code reviews have been conducted since decades in software projects, with the aim of improving code quality from many different points of view. During code reviews, developers are supported by checklists, coding standards and, possibly, by various kinds of static analysis tools. This paper investigates whether warnings highlighted by static analysis tools are taken care of during code reviews and, whether there are kinds of warnings that tend to be removed more than others. Results of a study conducted by mining the Gerrit repository of six Java open source projects indicate that the density of warnings only slightly vary after each review. The overall percentage of warnings removed during reviews is slightly higher than what previous studies found for the overall project evolution history. However, when looking (quantitatively and qualitatively) at specific categories of warnings, we found that during code reviews developers focus on certain kinds of problems. For such categories of warnings the removal percentage tend to be very high—often above 50% and sometimes 100%. Examples of those are warnings in the imports, regular expression, and type resolution categories. In conclusion, while a broad warning detection might produce way too many false positives, enforcing the removal of certain warnings prior to the patch submission could reduce the amount of effort provided during the code review process.

Code reviewsJuan Maiz

Peer Code Review An Agile Processgsporar

Peer code review is one of the most effective ways to find defects – but is it agile? Because agile teams loathe heavy process, code review practices can easily fail. However, lightweight peer code review aligns well with the central tenets of agile—keeping feedback close to the point of creation, increasing team velocity by finding defects faster, and improving collective code ownership through frequent collaboration. Gregg Sporar shares recent research on code review practices and describes an agile code review approach—how much time to spend, which code to review, how much code to review at a time, how to set goals, the value of annotation, and more. After comparing four styles of code review—pair programming, over-the-shoulder, email, and tool-assisted—Gregg gives specific advice for creating review checklists and dealing with the social effects of code review in an agile environment.

Yam PhysiologyInternational Institute of Tropical Agriculture

The document discusses the growth cycle of yams. There are five distinct phases: 1) tuber germination, 2) foliage development, 3) rapid tuber bulking, 4) foliage senescence and tuber maturation, and 5) dormancy. The growth cycle and timing of phases can vary by growing conditions, species, and genotype. In particular, early mature varieties stop tuber growth and senesce aerial parts earlier than late mature varieties. A new protocol to non-destructively evaluate tuber earliness uses a senescence index measured from aerial senescence levels. This protocol identified the start of senescence as a parameter for earliness. A diversity research set is being used to select

A Detailed Look At cassandra.yaml (Edward Capriolo, The Last Pickle) | Cassan...DataStax

Successfully running Apache Cassandra in production often means knowing what configuration settings to change and which ones to leave as default. Over the years the cassandra.yaml file has grown to provide a number of settings that can improve stability and performance. While the file contains plenty of helpful comments, there is more to be said about the settings and when to change them. In this talk Edward Capriolo, Consultant at The Last Pickle, will break down the parameters in the configuration files. Looking at those that are essential to getting started, those that impact performance, those that improve availability, the exotic ones, and the ones that should not be played with. This talk is ideal for someone someone setting up Cassandra for the first time up to people with deployments in productions and wondering what the more exotic configuration options do. About the Speaker Edward Capriolo Consultant, The Last Pickle Long time Apache Cassandra user, big data enthusiast.

そのyaml放っておくと大変なことになりますよAkira Ohta

The document discusses using a setting.yml file to manage configuration settings for a Rails application called Eight that is built at Sansan. It describes storing sensitive data like API keys or database passwords in the setting.yml file or external services like AWS DynamoDB, S3, and SQS. Managing configuration data through a single setting.yml file allows for easier deployment to multiple staging environments.

YAML is the new Evalarnebrasseur

This document summarizes several vulnerabilities that affected Ruby on Rails applications in early 2013. It describes 4 SQL injection vulnerabilities in January, an unsafe query generation issue in January, and an XML deserialization of YAML vulnerability in January that could allow remote code execution. It warns that YAML can be deserialized to objects and discusses eval usage. It provides recommendations to stay up-to-date on Rails security updates, sign up for security mailing lists, use strong parameters, and sanitize inputs to applications.

Code ReviewMikalai Alimenkou

Effective code reviewsSebastian Marek

Code reviews are a powerful tool in ensuring and maintaining quality in your application, but they can be very difficult to get right. When they're misunderstood or poorly executed, they can even make a bad situation worse. In this session I'll use my professional experience to give you some tactics for getting great benefit from code reviews. We'll talk about tools, about process and most importantly about attitude! Whether you're a developer or a technical lead, come along and find out how to perform a genuinely useful code review and provide constructive feedback in the quickest time possible.

TOSCA in Practice with ARIACloudify Community

Best Practices in Exception HandlingLemi Orhan Ergin

Clean Software Design: The Practices to Make The Design SimpleLemi Orhan Ergin

The document discusses principles for clean software design. It outlines 5 principles: 1) Tests should always pass to prove the system works as required; 2) Code should express intent through clear naming and avoiding generic names; 3) Keep methods and classes small in size; 4) Find and remove duplications in code and knowledge; 5) Align abstraction levels and avoid leaky abstractions that expose implementation details. It provides examples for each principle and cautions against anti-patterns like singletons and premature optimization. The document advocates code practices like refactoring, pair programming, and code reviews to achieve clean design.

Unwritten Manual for Pair ProgrammingLemi Orhan Ergin

This document discusses pair programming and provides guidance on how to effectively implement it. It begins by explaining the purpose of pair programming is to produce high quality software. It then discusses various pairing techniques like ping-pong pairing and mob programming. The document also identifies benefits like higher quality code and faster defect removal, as well as challenges like being tiring. Finally, it provides tips for making pairing work well such as starting with a defined task, switching roles frequently, and not forcing people who strongly dislike pairing.

More Related Content

Viewers also liked (20)

Global Day of Coderetreat'14 - Istanbul EventLemi Orhan Ergin

Let The Elephants Leave The Room - Remove Waste in Software Development - Bos...Lemi Orhan Ergin

Lost in Motivation in an Agile WorldLemi Orhan Ergin

Software Craftsmanship - Building A Culture For The Future (GDG DevFest Istan...Lemi Orhan Ergin

Trespassing The Forgotten and Abandoned: Ethics in Software DevelopmentLemi Orhan Ergin

TDD - Inevitable Challenge for Software Developers (phpkonf15 keynote)Lemi Orhan Ergin

Test Driven Design - GDG DevFest Istanbul 2016Lemi Orhan Ergin

Scaling your code reviewSander Bol

WordCamp US 2016 - Ryan Markel: Code Reviewthemarkel

Would Static Analysis Tools Help Developers with Code Reviews?Sebastiano Panichella

Code reviewsJuan Maiz

Peer Code Review An Agile Processgsporar

Yam PhysiologyInternational Institute of Tropical Agriculture

A Detailed Look At cassandra.yaml (Edward Capriolo, The Last Pickle) | Cassan...DataStax

そのyaml放っておくと大変なことになりますよAkira Ohta

YAML is the new Evalarnebrasseur

Code ReviewMikalai Alimenkou

Effective code reviewsSebastian Marek

TOSCA in Practice with ARIACloudify Community

Best Practices in Exception HandlingLemi Orhan Ergin

Global Day of Coderetreat'14 - Istanbul EventLemi Orhan Ergin

Let The Elephants Leave The Room - Remove Waste in Software Development - Bos...Lemi Orhan Ergin

Lost in Motivation in an Agile WorldLemi Orhan Ergin

Software Craftsmanship - Building A Culture For The Future (GDG DevFest Istan...Lemi Orhan Ergin

Trespassing The Forgotten and Abandoned: Ethics in Software DevelopmentLemi Orhan Ergin

TDD - Inevitable Challenge for Software Developers (phpkonf15 keynote)Lemi Orhan Ergin

Test Driven Design - GDG DevFest Istanbul 2016Lemi Orhan Ergin

Scaling your code reviewSander Bol

WordCamp US 2016 - Ryan Markel: Code Reviewthemarkel

Would Static Analysis Tools Help Developers with Code Reviews?Sebastiano Panichella

Code reviewsJuan Maiz

Peer Code Review An Agile Processgsporar

Yam PhysiologyInternational Institute of Tropical Agriculture

A Detailed Look At cassandra.yaml (Edward Capriolo, The Last Pickle) | Cassan...DataStax

そのyaml放っておくと大変なことになりますよAkira Ohta

YAML is the new Evalarnebrasseur

Code ReviewMikalai Alimenkou

Effective code reviewsSebastian Marek

TOSCA in Practice with ARIACloudify Community

Best Practices in Exception HandlingLemi Orhan Ergin

More from Lemi Orhan Ergin (18)

Clean Software Design: The Practices to Make The Design SimpleLemi Orhan Ergin

Unwritten Manual for Pair ProgrammingLemi Orhan Ergin

10 Faulty Behaviors of Code Review - Developer Summit Istanbul 2018Lemi Orhan Ergin

The document outlines 10 faulty behaviors that can occur during the code review process and provides recommendations to address each one. The behaviors include having no standards for code reviews in the team, providing ambiguous content for review, selecting the wrong reviewers, requesting feedback too late in the process, not understanding what the code change is doing, treating the code as solely the author's work, trying to prove others are wrong instead of having constructive discussions, not being able to convince others with review comments, reviewers not providing feedback on pull requests, and prematurely merging pull requests before the review is finished. For each behavior, the document recommends actions like establishing review standards and processes, providing better context for reviews, selecting appropriate reviewers, reviewing code earlier, adding tests

Yeni Nesil Yazılım Kültürü: Daha İyi Profesyoneller, Daha Kaliteli Yazılım, D...Lemi Orhan Ergin

Irresponsible Disclosure: Short Handbook of an Ethical DeveloperLemi Orhan Ergin

Ethics... It could be the most important and underrated topic in software industry. It is directly related with professionalism, craftsmanship and professional discipline. From time to time we have to jump into the discussions, however we never discuss it deeper. I have found himself in a huge blast of discussions when he tweeted about a **HUGE** security issue at the most popular operating system. Then I had deep thoughts about ethics and the behaviours of ethical developers. In this session I talk about the followings: * I refer to real-life stories of many good practices for professional ethics that are critical in the software development world. * I mention technical and non-technical aspects of being an ethical developer. * I deep dive into the arguments against the ethical controversies and the debate over the sharing of a major error in MacOS via Twitter.

Scrum Events and Artifacts in ActionLemi Orhan Ergin

DevOps & Technical Agility: From Theory to PracticeLemi Orhan Ergin

Fighting with Waste Driven Development - XP Days Ukraine 2017Lemi Orhan Ergin

This document discusses lean thinking for software developers. It begins by outlining some common mindsets in software development that lead to waste, such as being overconfident and not having enough time for testing and refactoring. It then discusses various types of waste found in software development processes. The document advocates adopting a lean mindset to maximize value for customers by removing waste through practices like test-driven development, refactoring continuously, and making codebases clean through frequent short releases. It concludes by discussing the need for changes in culture and mindset to fully embrace lean software development.

Git Anti Patterns - XP Days Ukraine 2017Lemi Orhan Ergin

1. The document discusses various good and bad practices for using Git, including committing early and often, squashing commits before merging, and avoiding long-lived topic branches. 2. It recommends splitting large features into small shippable tasks, committing changes early and often without worrying about compilation or CI, and rebasing regularly to integrate changes from the main branch. 3. Changes should be "perfected" later by squashing commits and making the history a single commit before merging back to the main branch when tests pass and code is reviewed.

Waste Driven Development - Agile Coaching Serbia MeetupLemi Orhan Ergin

This document discusses lean thinking and waste-driven development for software developers. It argues that traditional software development practices lead to a lot of waste, including defects, rework, slow development cycles, and lack of value delivery to customers. It promotes applying lean principles from manufacturing to software development, such as focusing on value delivery, eliminating waste, keeping codebases small and modular, automating everything, having high transparency, and challenging common paradigms. Documentation is identified as a particular type of waste.

Git Anti-Patterns - Extended Version With 28 Common Anti-Patterns) - SCTurkey...Lemi Orhan Ergin

This document discusses common Git anti-patterns and provides recommendations to avoid them. It begins by explaining how Git works under the hood in terms of files, folders, references, and objects. It then covers 15 specific anti-patterns to avoid, such as treating Git like Dropbox, having long-living topic branches, merging too late without validation, and being afraid to delete branches. For each anti-pattern, it provides alternatives and recommendations, such as splitting work into small tasks, committing early and often, rebasing rather than merging, and deleting merged branches. The overall message is how to use Git properly and cure common issues by following best practices.

Git Anti-Patterns: How To Mess Up With Git and Love it Again - DevoxxPL 2017Lemi Orhan Ergin

This document contains the slides from a presentation on best practices for using Git and avoiding common antipatterns. It discusses how Git works internally and the different objects it uses to store files, references, and commits. It then covers strategies for committing code early and often in small batches, rebasing regularly to integrate changes, squashing commits before merging back to the main branch, and using feature flags to disable unreleased features. The overall message is to leverage Git's power effectively while avoiding long-lived topic branches, loose commit histories, and other issues that can arise from not understanding Git's model.

Yazılım Geliştirme Kültürünün Kodları: Motivasyon, Teknik Mükemmellik ve İnov...Lemi Orhan Ergin

Bugünün acımasız rekabet ortamında hayatta kalabilmek için her şirketin bir yazılım şirketi olması gerekir. Bu çok büyük bir mücadele demek. Kaliteli yazlımcılar işe alınmalı, projeler doğru yönetilmeli ve proje teslim tarihleri belirlenmelidir. Ancak, gerçekte çok farklı bir tabloyla karşılaşıyoruz. Yüzlerce geliştiriciyle iş görüşmesi yapılıyor ancak bulunamıyor. Geliştiricilerden oluşan bir ekip oluşturulsa bile, motivasyonel sorunlar, sürekli artan teknik problemler, iletişim sorunları, inovasyon eksikliği ve işten ayrılmalar ile ediyoruz. Müşteriler, kaçırılan tarihler ve çıktının düşük kalitesi nedeniyle hayal kırıklığına uğruyor. Her yazılım geliştirme ekibi kendi dinamiklerini yaratır. Çalışanların davranışlarıyla ekiplerin gizli dinamiklerini toplandığımızda şirketteki yazılım geliştirme kültürünü oluşturuyoruz. Bu, bir yazılım geliştirme takımının ne kadar başarılı olabileceğini tanımlayan, en önemli faktörlerden biridir. Bu oturumda, motivasyon, teknik mükemmellik, işbirliği, yardımlaşma, yenilikçilik ve başarı sağlayan bir yazılım geliştirme kültürünün nasıl kurulacağından bahsedeceğim. Yazılım dünyasına girmiş ve ilgilenen herkes katılabilir. Bu sunum Dinamikler 2017 Kongresinde kullanılmıştır.

Git Anti-Patterns: How To Mess Up With Git and Love it AgainLemi Orhan Ergin

Git is one of the most powerful tool in developers' toolbox. If you use it correctly, it dramatically increases productivity of developers and eliminates the waste products continuously. Developers cultivate a development culture on top Git most of the time. It's powerful but its power is untamed. Many teams fall into several traps of misusing commands and therefore feel uncomfortable while using Git. We mess up Git history, the codebase and the whole preferred branching strategy in seconds. We use branches, merge/rebase strategies, creating commits in wrong ways. Even we never take committing paradigms into account while using Git. As a software craftsman, I've been using Git for years and I've already educated Git to hundreds of developers in all levels. I'm so lucky; I had a chance to experience huge amount of anti-patterns in time. In this talk, I will talk about what those anti-patterns are and what should we do in order not to fall into them.

Clean Software Design - DevNot Summit Istanbul 2017Lemi Orhan Ergin

Let The Elephants Leave The Room - Tips For Making Your Development Life LeanerLemi Orhan Ergin

A Gentle Introduction to Micro Services - From Theory into PracticeLemi Orhan Ergin

Coderetreat - Practice to Master Your CraftsLemi Orhan Ergin