| commit | 834e018f2979f4a1ab73c70c226ff72039f4fbc9 | [log] [tgz] |
|---|---|---|
| author | Arthur Sonzogni <[email protected]> | Sat Apr 22 10:20:02 2023 |
| committer | Chromium LUCI CQ <[email protected]> | Sat Apr 22 10:20:02 2023 |
| tree | 2a90f908810a34a08b712c7379235fa2ba603f83 | |
| parent | 424369c2bc20251ff36676f12a2631a0fdf21b2b [diff] |
MiraclePtr: Rewrite chromeos-ash [5/N] This was automated. It rewrites chromeos-ash and annotate the dangling pointers. This part was split out of the root CL: https://chromium-review.googlesource.com/c/chromium/src/+/4459392 number file selected ------ ----------- -------- 1700 chrome/ 1407 ash/ x 626 chromeos/ 147 components/ 53 ui/ 16 extensions/ 14 media/ 9 remoting/ 8 services/ 5 content/ 3 cc/ 1 gpu/ 1 crypto/ Steps: 1. Execute the rewriter: ./tools/clang/rewrite_raw_ptr_fields/rewrite-multiple-platforms.sh chromeos-ash 2. Execute all the tests. Print the dangling pointers using https://godbolt.org/z/o8adYnc7a idea. Then apply the edits using: https://github.com/ArthurSonzogni/chrome-dangling-ptr-apply-edit 3. Apply `git cl format` 4. Add `ExperimentalAsh`. This happened using a vim macro on the root patch. Overall there are exactly 7461 new pointers, and 183 dangling pointers. 5. Apply `git cl format` Cq-Include-Trybots:luci.chromium.try:android-pie-arm64-dbg,android-x64-Cq-Include-Trybots: luci.chromium.try:android-pie-arm64-dbg,android-x64-cast,android_compile_dbg,android_compile_x64_dbg,android_compile_x86_dbg,android_cronet,chromeos-amd64-generic-dbg,chromeos-arm-generic-rel,dawn-android-arm-deps-rel,dawn-mac-x64-deps-rel,fuchsia-arm64-rel,fuchsia-x64-cast-receiver-rel,ios-simulator,lacros-amd64-generic-rel,lacros-arm-generic-rel,linux-chromeos-compile-dbg,linux-libfuzzer-asan-rel,linux_chromium_asan_rel_ng,linux_chromium_compile_dbg_ng,linux_chromium_tsan_rel_ng,linux_vr,mac_chromium_compile_dbg_ng,win-libfuzzer-asan-rel,win_chromium_compile_dbg_ng,android-arm64-rel,android-nougat-x86-rel,android_optional_gpu_tests_rel,chromeos-amd64-generic-rel,dawn-linux-x64-deps-rel,dawn-win10-x64-deps-rel,dawn-win10-x86-deps-rel,linux-chromeos-rel,linux-lacros-rel,linux-rel,linux-wayland-rel,linux-x64-castos,linux_optional_gpu_tests_rel,mac_optional_gpu_tests_rel,win_optional_gpu_tests_rel Include-Ci-Only-Tests: true Bug:1430482 Change-Id: Ie1e24f40a0688c1148b27455d05aae73803c10da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4456581 Commit-Queue: Arthur Sonzogni <[email protected]> Reviewed-by: Bartek Nowierski <[email protected]> Owners-Override: Bartek Nowierski <[email protected]> Cr-Commit-Position: refs/heads/main@{#1134206}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.