blob: 44d1a90222f5da8d7e7a595f1b1161f90ca7d82d [file] [log] [blame] [view]
Elly Fong-Jonesbbc92062019-05-29 15:38:031# Chromium Sheriffing
2
3Author: ellyjones@
4
Elly Fong-Jonesbbc92062019-05-29 15:38:035## Sheriffing Philosophy
6
7Sheriffs have one overarching role: to ensure that the Chromium build
8infrastructure is doing its job of helping developers deliver good software.
9Every other sheriff responsibility flows from that one. In priority order,
10sheriffs need to ensure that:
11
121. **The tree is open**, because when the tree is closed nobody can make
13 progress;
142. **New test failures are not introduced**, because they weaken our assurance
15 that we're shipping good code;
163. **Existing test failures are repaired**, for the same reason
17
18As the sheriff, you not only have those responsibilities, but you have any
19necessary authority to fulfill them. In particular, you have the authority to:
20
21* Revert changes that you know or suspect are causing breakages
22* Disable or otherwise mark misbehaving tests
Jason Clinton0daf7b02021-02-09 20:36:2223* Use Owners-Override label to override OWNERS checks freely as part of your
24 sheriffing duties
Elly Fong-Jonesbbc92062019-05-29 15:38:0325* Pull in any other engineer or team you need to help you do these duties
Jason Clinton0daf7b02021-02-09 20:36:2226* For clean reverts and cherry-picks, add the
27 [Rubber Stamper bot](code_reviews.md#automated-code_review). All other
28 changes require a +1 from another committer.
29
30TBRs were removed in Q1 2021.
Elly Fong-Jonesbbc92062019-05-29 15:38:0331
Joey Scarr9ded41f2020-07-01 04:23:2932## How to be a Sheriff
Elly Fong-Jonesbbc92062019-05-29 15:38:0333
Joey Scarr9ded41f2020-07-01 04:23:2934To be a sheriff, you must be both a Chromium committer and a Google employee.
35For more detailed sheriffing instructions, please see the internal documentation
36at
37[go/chrome-sheriffing-how-to](https://goto.google.com/chrome-sheriffing-how-to).
Joey Scarr223c9dc2020-07-09 16:39:2438
39## Contacting the Sheriffs
40
41The currently oncall sheriffs can be viewed in the top-left corner of the
42[Chromium Main Console](https://ci.chromium.org/p/chromium/g/main/console). You
43can also get in touch with sheriffs using the
44[#sheriffing Slack channel](https://chromium.slack.com/messages/CGJ5WKRUH/).