mmenke | cbc2b71 | 2014-10-09 20:29:07 | [diff] [blame] | 1 | // Copyright 2014 The Chromium Authors. All rights reserved. |
| 2 | // Use of this source code is governed by a BSD-style license that can be |
| 3 | // found in the LICENSE file. |
| 4 | |
| 5 | #include "net/base/chunked_upload_data_stream.h" |
| 6 | |
danakj | 7f767e6 | 2016-04-16 23:20:23 | [diff] [blame] | 7 | #include <memory> |
mmenke | cbc2b71 | 2014-10-09 20:29:07 | [diff] [blame] | 8 | #include <string> |
| 9 | |
mmenke | cbc2b71 | 2014-10-09 20:29:07 | [diff] [blame] | 10 | #include "net/base/io_buffer.h" |
| 11 | #include "net/base/net_errors.h" |
| 12 | #include "net/base/test_completion_callback.h" |
| 13 | #include "net/base/upload_data_stream.h" |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 14 | #include "net/test/gtest_util.h" |
| 15 | #include "testing/gmock/include/gmock/gmock.h" |
mmenke | cbc2b71 | 2014-10-09 20:29:07 | [diff] [blame] | 16 | #include "testing/gtest/include/gtest/gtest.h" |
| 17 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 18 | using net::test::IsError; |
| 19 | using net::test::IsOk; |
| 20 | |
mmenke | cbc2b71 | 2014-10-09 20:29:07 | [diff] [blame] | 21 | namespace net { |
| 22 | |
| 23 | namespace { |
| 24 | |
| 25 | const char kTestData[] = "0123456789"; |
| 26 | const size_t kTestDataSize = arraysize(kTestData) - 1; |
| 27 | const size_t kTestBufferSize = 1 << 14; // 16KB. |
| 28 | |
| 29 | } // namespace |
| 30 | |
| 31 | // Reads data once from the upload data stream, and returns the data as string. |
| 32 | // Expects the read to succeed synchronously. |
| 33 | std::string ReadSync(UploadDataStream* stream, int buffer_size) { |
| 34 | scoped_refptr<IOBuffer> buf = new IOBuffer(buffer_size); |
| 35 | int result = stream->Read(buf.get(), |
| 36 | buffer_size, |
| 37 | TestCompletionCallback().callback()); |
| 38 | EXPECT_GE(result, 0); |
| 39 | return std::string(buf->data(), result); |
| 40 | } |
| 41 | |
| 42 | // Check the case data is added after the first read attempt. |
| 43 | TEST(ChunkedUploadDataStreamTest, AppendOnce) { |
| 44 | ChunkedUploadDataStream stream(0); |
| 45 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 46 | ASSERT_THAT(stream.Init(TestCompletionCallback().callback()), IsOk()); |
mmenke | cbc2b71 | 2014-10-09 20:29:07 | [diff] [blame] | 47 | EXPECT_FALSE(stream.IsInMemory()); |
| 48 | EXPECT_EQ(0u, stream.size()); // Content-Length is 0 for chunked data. |
| 49 | EXPECT_EQ(0u, stream.position()); |
| 50 | EXPECT_FALSE(stream.IsEOF()); |
| 51 | |
| 52 | TestCompletionCallback callback; |
| 53 | scoped_refptr<IOBuffer> buf = new IOBuffer(kTestBufferSize); |
| 54 | int result = stream.Read(buf.get(), kTestBufferSize, callback.callback()); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 55 | ASSERT_THAT(result, IsError(ERR_IO_PENDING)); |
mmenke | cbc2b71 | 2014-10-09 20:29:07 | [diff] [blame] | 56 | |
| 57 | stream.AppendData(kTestData, kTestDataSize, true); |
| 58 | int read = callback.WaitForResult(); |
| 59 | ASSERT_GE(read, 0); |
| 60 | EXPECT_EQ(kTestData, std::string(buf->data(), read)); |
| 61 | EXPECT_EQ(0u, stream.size()); // Content-Length is 0 for chunked data. |
| 62 | EXPECT_EQ(kTestDataSize, stream.position()); |
| 63 | EXPECT_TRUE(stream.IsEOF()); |
| 64 | } |
| 65 | |
| 66 | TEST(ChunkedUploadDataStreamTest, AppendOnceBeforeRead) { |
| 67 | ChunkedUploadDataStream stream(0); |
| 68 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 69 | ASSERT_THAT(stream.Init(TestCompletionCallback().callback()), IsOk()); |
mmenke | cbc2b71 | 2014-10-09 20:29:07 | [diff] [blame] | 70 | EXPECT_FALSE(stream.IsInMemory()); |
| 71 | EXPECT_EQ(0u, stream.size()); // Content-Length is 0 for chunked data. |
| 72 | EXPECT_EQ(0u, stream.position()); |
| 73 | EXPECT_FALSE(stream.IsEOF()); |
| 74 | |
| 75 | stream.AppendData(kTestData, kTestDataSize, true); |
| 76 | EXPECT_EQ(0u, stream.size()); // Content-Length is 0 for chunked data. |
| 77 | EXPECT_EQ(0u, stream.position()); |
| 78 | EXPECT_FALSE(stream.IsEOF()); |
| 79 | |
| 80 | std::string data = ReadSync(&stream, kTestBufferSize); |
| 81 | EXPECT_EQ(kTestData, data); |
| 82 | EXPECT_EQ(0u, stream.size()); // Content-Length is 0 for chunked data. |
| 83 | EXPECT_EQ(kTestDataSize, stream.position()); |
| 84 | EXPECT_TRUE(stream.IsEOF()); |
| 85 | } |
| 86 | |
| 87 | TEST(ChunkedUploadDataStreamTest, AppendOnceBeforeInit) { |
| 88 | ChunkedUploadDataStream stream(0); |
| 89 | |
| 90 | stream.AppendData(kTestData, kTestDataSize, true); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 91 | ASSERT_THAT(stream.Init(TestCompletionCallback().callback()), IsOk()); |
mmenke | cbc2b71 | 2014-10-09 20:29:07 | [diff] [blame] | 92 | EXPECT_FALSE(stream.IsInMemory()); |
| 93 | EXPECT_EQ(0u, stream.size()); // Content-Length is 0 for chunked data. |
| 94 | EXPECT_EQ(0u, stream.position()); |
| 95 | EXPECT_FALSE(stream.IsEOF()); |
| 96 | |
| 97 | std::string data = ReadSync(&stream, kTestBufferSize); |
| 98 | EXPECT_EQ(kTestData, data); |
| 99 | EXPECT_EQ(0u, stream.size()); // Content-Length is 0 for chunked data. |
| 100 | EXPECT_EQ(kTestDataSize, stream.position()); |
| 101 | EXPECT_TRUE(stream.IsEOF()); |
| 102 | } |
| 103 | |
| 104 | TEST(ChunkedUploadDataStreamTest, MultipleAppends) { |
| 105 | ChunkedUploadDataStream stream(0); |
| 106 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 107 | ASSERT_THAT(stream.Init(TestCompletionCallback().callback()), IsOk()); |
mmenke | cbc2b71 | 2014-10-09 20:29:07 | [diff] [blame] | 108 | EXPECT_FALSE(stream.IsInMemory()); |
| 109 | EXPECT_EQ(0u, stream.size()); |
| 110 | EXPECT_EQ(0u, stream.position()); |
| 111 | EXPECT_FALSE(stream.IsEOF()); |
| 112 | |
| 113 | TestCompletionCallback callback; |
| 114 | scoped_refptr<IOBuffer> buf = new IOBuffer(kTestBufferSize); |
| 115 | for (size_t i = 0; i < kTestDataSize; ++i) { |
| 116 | EXPECT_EQ(0u, stream.size()); // Content-Length is 0 for chunked data. |
| 117 | EXPECT_EQ(i, stream.position()); |
| 118 | ASSERT_FALSE(stream.IsEOF()); |
| 119 | int bytes_read = stream.Read(buf.get(), |
| 120 | kTestBufferSize, |
| 121 | callback.callback()); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 122 | ASSERT_THAT(bytes_read, IsError(ERR_IO_PENDING)); |
mmenke | cbc2b71 | 2014-10-09 20:29:07 | [diff] [blame] | 123 | stream.AppendData(&kTestData[i], 1, i == kTestDataSize - 1); |
| 124 | ASSERT_EQ(1, callback.WaitForResult()); |
| 125 | EXPECT_EQ(kTestData[i], buf->data()[0]); |
| 126 | } |
| 127 | |
| 128 | EXPECT_EQ(0u, stream.size()); // Content-Length is 0 for chunked data. |
| 129 | EXPECT_EQ(kTestDataSize, stream.position()); |
| 130 | ASSERT_TRUE(stream.IsEOF()); |
| 131 | } |
| 132 | |
| 133 | TEST(ChunkedUploadDataStreamTest, MultipleAppendsBetweenReads) { |
| 134 | ChunkedUploadDataStream stream(0); |
| 135 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 136 | ASSERT_THAT(stream.Init(TestCompletionCallback().callback()), IsOk()); |
mmenke | cbc2b71 | 2014-10-09 20:29:07 | [diff] [blame] | 137 | EXPECT_FALSE(stream.IsInMemory()); |
| 138 | EXPECT_EQ(0u, stream.size()); // Content-Length is 0 for chunked data. |
| 139 | EXPECT_EQ(0u, stream.position()); |
| 140 | EXPECT_FALSE(stream.IsEOF()); |
| 141 | |
| 142 | scoped_refptr<IOBuffer> buf = new IOBuffer(kTestBufferSize); |
| 143 | for (size_t i = 0; i < kTestDataSize; ++i) { |
| 144 | EXPECT_EQ(i, stream.position()); |
| 145 | ASSERT_FALSE(stream.IsEOF()); |
| 146 | stream.AppendData(&kTestData[i], 1, i == kTestDataSize - 1); |
| 147 | int bytes_read = stream.Read(buf.get(), |
| 148 | kTestBufferSize, |
| 149 | TestCompletionCallback().callback()); |
| 150 | ASSERT_EQ(1, bytes_read); |
| 151 | EXPECT_EQ(kTestData[i], buf->data()[0]); |
| 152 | } |
| 153 | |
| 154 | EXPECT_EQ(kTestDataSize, stream.position()); |
| 155 | ASSERT_TRUE(stream.IsEOF()); |
| 156 | } |
| 157 | |
| 158 | // Checks that multiple reads can be merged. |
| 159 | TEST(ChunkedUploadDataStreamTest, MultipleAppendsBeforeInit) { |
| 160 | ChunkedUploadDataStream stream(0); |
| 161 | stream.AppendData(kTestData, 1, false); |
| 162 | stream.AppendData(kTestData + 1, 1, false); |
| 163 | stream.AppendData(kTestData + 2, kTestDataSize - 2, true); |
| 164 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 165 | ASSERT_THAT(stream.Init(TestCompletionCallback().callback()), IsOk()); |
mmenke | cbc2b71 | 2014-10-09 20:29:07 | [diff] [blame] | 166 | EXPECT_FALSE(stream.IsInMemory()); |
| 167 | EXPECT_EQ(0u, stream.size()); // Content-Length is 0 for chunked data. |
| 168 | EXPECT_EQ(0u, stream.position()); |
| 169 | EXPECT_FALSE(stream.IsEOF()); |
| 170 | |
| 171 | std::string data = ReadSync(&stream, kTestBufferSize); |
| 172 | EXPECT_EQ(kTestData, data); |
| 173 | EXPECT_EQ(kTestDataSize, stream.position()); |
| 174 | ASSERT_TRUE(stream.IsEOF()); |
| 175 | } |
| 176 | |
| 177 | TEST(ChunkedUploadDataStreamTest, MultipleReads) { |
| 178 | // Use a read size different from the write size to test bounds checking. |
| 179 | const size_t kReadSize = kTestDataSize + 3; |
| 180 | |
| 181 | ChunkedUploadDataStream stream(0); |
| 182 | stream.AppendData(kTestData, kTestDataSize, false); |
| 183 | stream.AppendData(kTestData, kTestDataSize, false); |
| 184 | stream.AppendData(kTestData, kTestDataSize, false); |
| 185 | stream.AppendData(kTestData, kTestDataSize, true); |
| 186 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 187 | ASSERT_THAT(stream.Init(TestCompletionCallback().callback()), IsOk()); |
mmenke | cbc2b71 | 2014-10-09 20:29:07 | [diff] [blame] | 188 | EXPECT_FALSE(stream.IsInMemory()); |
| 189 | EXPECT_EQ(0u, stream.size()); // Content-Length is 0 for chunked data. |
| 190 | EXPECT_EQ(0u, stream.position()); |
| 191 | EXPECT_FALSE(stream.IsEOF()); |
| 192 | |
| 193 | std::string data = ReadSync(&stream, kReadSize); |
| 194 | EXPECT_EQ("0123456789012", data); |
| 195 | EXPECT_EQ(kReadSize, stream.position()); |
| 196 | EXPECT_FALSE(stream.IsEOF()); |
| 197 | |
| 198 | data = ReadSync(&stream, kReadSize); |
| 199 | EXPECT_EQ("3456789012345", data); |
| 200 | EXPECT_EQ(2 * kReadSize, stream.position()); |
| 201 | EXPECT_FALSE(stream.IsEOF()); |
| 202 | |
| 203 | data = ReadSync(&stream, kReadSize); |
| 204 | EXPECT_EQ("6789012345678", data); |
| 205 | EXPECT_EQ(3 * kReadSize, stream.position()); |
| 206 | EXPECT_FALSE(stream.IsEOF()); |
| 207 | |
| 208 | data = ReadSync(&stream, kReadSize); |
| 209 | EXPECT_EQ("9", data); |
| 210 | EXPECT_EQ(4 * kTestDataSize, stream.position()); |
| 211 | EXPECT_TRUE(stream.IsEOF()); |
| 212 | } |
| 213 | |
| 214 | TEST(ChunkedUploadDataStreamTest, EmptyUpload) { |
| 215 | ChunkedUploadDataStream stream(0); |
| 216 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 217 | ASSERT_THAT(stream.Init(TestCompletionCallback().callback()), IsOk()); |
mmenke | cbc2b71 | 2014-10-09 20:29:07 | [diff] [blame] | 218 | EXPECT_FALSE(stream.IsInMemory()); |
| 219 | EXPECT_EQ(0u, stream.size()); // Content-Length is 0 for chunked data. |
| 220 | EXPECT_EQ(0u, stream.position()); |
| 221 | EXPECT_FALSE(stream.IsEOF()); |
| 222 | |
| 223 | TestCompletionCallback callback; |
| 224 | scoped_refptr<IOBuffer> buf = new IOBuffer(kTestBufferSize); |
| 225 | int result = stream.Read(buf.get(), kTestBufferSize, callback.callback()); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 226 | ASSERT_THAT(result, IsError(ERR_IO_PENDING)); |
mmenke | cbc2b71 | 2014-10-09 20:29:07 | [diff] [blame] | 227 | |
| 228 | stream.AppendData(NULL, 0, true); |
| 229 | int read = callback.WaitForResult(); |
| 230 | EXPECT_EQ(0, read); |
| 231 | EXPECT_EQ(0u, stream.position()); |
| 232 | EXPECT_TRUE(stream.IsEOF()); |
| 233 | } |
| 234 | |
| 235 | TEST(ChunkedUploadDataStreamTest, EmptyUploadEndedBeforeInit) { |
| 236 | ChunkedUploadDataStream stream(0); |
| 237 | stream.AppendData(NULL, 0, true); |
| 238 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 239 | ASSERT_THAT(stream.Init(TestCompletionCallback().callback()), IsOk()); |
mmenke | cbc2b71 | 2014-10-09 20:29:07 | [diff] [blame] | 240 | EXPECT_FALSE(stream.IsInMemory()); |
| 241 | EXPECT_EQ(0u, stream.size()); // Content-Length is 0 for chunked data. |
| 242 | EXPECT_EQ(0u, stream.position()); |
| 243 | EXPECT_FALSE(stream.IsEOF()); |
| 244 | |
| 245 | std::string data = ReadSync(&stream, kTestBufferSize); |
| 246 | ASSERT_EQ("", data); |
| 247 | EXPECT_EQ(0u, stream.position()); |
| 248 | EXPECT_TRUE(stream.IsEOF()); |
| 249 | } |
| 250 | |
| 251 | TEST(ChunkedUploadDataStreamTest, RewindAfterComplete) { |
| 252 | ChunkedUploadDataStream stream(0); |
| 253 | stream.AppendData(kTestData, 1, false); |
| 254 | stream.AppendData(kTestData + 1, kTestDataSize - 1, true); |
| 255 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 256 | ASSERT_THAT(stream.Init(TestCompletionCallback().callback()), IsOk()); |
mmenke | cbc2b71 | 2014-10-09 20:29:07 | [diff] [blame] | 257 | EXPECT_FALSE(stream.IsInMemory()); |
| 258 | EXPECT_EQ(0u, stream.size()); // Content-Length is 0 for chunked data. |
| 259 | EXPECT_EQ(0u, stream.position()); |
| 260 | EXPECT_FALSE(stream.IsEOF()); |
| 261 | |
| 262 | std::string data = ReadSync(&stream, kTestBufferSize); |
| 263 | EXPECT_EQ(kTestData, data); |
| 264 | EXPECT_EQ(kTestDataSize, stream.position()); |
| 265 | ASSERT_TRUE(stream.IsEOF()); |
| 266 | |
| 267 | // Rewind stream and repeat. |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 268 | ASSERT_THAT(stream.Init(TestCompletionCallback().callback()), IsOk()); |
mmenke | cbc2b71 | 2014-10-09 20:29:07 | [diff] [blame] | 269 | EXPECT_FALSE(stream.IsInMemory()); |
| 270 | EXPECT_EQ(0u, stream.size()); // Content-Length is 0 for chunked data. |
| 271 | EXPECT_EQ(0u, stream.position()); |
| 272 | EXPECT_FALSE(stream.IsEOF()); |
| 273 | |
| 274 | data = ReadSync(&stream, kTestBufferSize); |
| 275 | EXPECT_EQ(kTestData, data); |
| 276 | EXPECT_EQ(kTestDataSize, stream.position()); |
| 277 | ASSERT_TRUE(stream.IsEOF()); |
| 278 | } |
| 279 | |
| 280 | TEST(ChunkedUploadDataStreamTest, RewindWhileReading) { |
| 281 | ChunkedUploadDataStream stream(0); |
| 282 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 283 | ASSERT_THAT(stream.Init(TestCompletionCallback().callback()), IsOk()); |
mmenke | cbc2b71 | 2014-10-09 20:29:07 | [diff] [blame] | 284 | EXPECT_FALSE(stream.IsInMemory()); |
| 285 | EXPECT_EQ(0u, stream.size()); // Content-Length is 0 for chunked data. |
| 286 | EXPECT_EQ(0u, stream.position()); |
| 287 | EXPECT_FALSE(stream.IsEOF()); |
| 288 | |
| 289 | TestCompletionCallback callback; |
| 290 | scoped_refptr<IOBuffer> buf = new IOBuffer(kTestBufferSize); |
| 291 | int result = stream.Read(buf.get(), kTestBufferSize, callback.callback()); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 292 | ASSERT_THAT(result, IsError(ERR_IO_PENDING)); |
mmenke | cbc2b71 | 2014-10-09 20:29:07 | [diff] [blame] | 293 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 294 | ASSERT_THAT(stream.Init(TestCompletionCallback().callback()), IsOk()); |
mmenke | cbc2b71 | 2014-10-09 20:29:07 | [diff] [blame] | 295 | EXPECT_FALSE(stream.IsInMemory()); |
| 296 | EXPECT_EQ(0u, stream.size()); // Content-Length is 0 for chunked data. |
| 297 | EXPECT_EQ(0u, stream.position()); |
| 298 | EXPECT_FALSE(stream.IsEOF()); |
| 299 | |
| 300 | // Adding data now should not result in calling the original read callback, |
| 301 | // since the stream was re-initialized for reuse, which cancels all pending |
| 302 | // reads. |
| 303 | stream.AppendData(kTestData, kTestDataSize, true); |
| 304 | EXPECT_FALSE(callback.have_result()); |
| 305 | |
| 306 | std::string data = ReadSync(&stream, kTestBufferSize); |
| 307 | EXPECT_EQ(kTestData, data); |
| 308 | EXPECT_EQ(kTestDataSize, stream.position()); |
| 309 | ASSERT_TRUE(stream.IsEOF()); |
| 310 | EXPECT_FALSE(callback.have_result()); |
| 311 | } |
| 312 | |
mmenke | 56b0cbb91 | 2016-03-28 21:34:53 | [diff] [blame] | 313 | // Check the behavior of ChunkedUploadDataStream::Writer. |
| 314 | TEST(ChunkedUploadDataStreamTest, ChunkedUploadDataStreamWriter) { |
danakj | 7f767e6 | 2016-04-16 23:20:23 | [diff] [blame] | 315 | std::unique_ptr<ChunkedUploadDataStream> stream( |
| 316 | new ChunkedUploadDataStream(0)); |
| 317 | std::unique_ptr<ChunkedUploadDataStream::Writer> writer( |
| 318 | stream->CreateWriter()); |
mmenke | 56b0cbb91 | 2016-03-28 21:34:53 | [diff] [blame] | 319 | |
| 320 | // Write before Init. |
| 321 | ASSERT_TRUE(writer->AppendData(kTestData, 1, false)); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 322 | ASSERT_THAT(stream->Init(TestCompletionCallback().callback()), IsOk()); |
mmenke | 56b0cbb91 | 2016-03-28 21:34:53 | [diff] [blame] | 323 | |
| 324 | // Write after Init. |
| 325 | ASSERT_TRUE(writer->AppendData(kTestData + 1, kTestDataSize - 1, false)); |
| 326 | |
| 327 | TestCompletionCallback callback; |
| 328 | std::string data = ReadSync(stream.get(), kTestBufferSize); |
| 329 | EXPECT_EQ(kTestData, data); |
| 330 | |
| 331 | // Writing data should gracefully fail if the stream is deleted while still |
| 332 | // appending data to it. |
| 333 | stream.reset(); |
| 334 | EXPECT_FALSE(writer->AppendData(kTestData, kTestDataSize, true)); |
| 335 | } |
| 336 | |
mmenke | cbc2b71 | 2014-10-09 20:29:07 | [diff] [blame] | 337 | } // namespace net |