[email protected] | a33347c | 2012-01-09 18:27:01 | [diff] [blame] | 1 | // Copyright (c) 2012 The Chromium Authors. All rights reserved. |
[email protected] | 212d149 | 2008-09-05 19:38:54 | [diff] [blame] | 2 | // Use of this source code is governed by a BSD-style license that can be |
| 3 | // found in the LICENSE file. |
| 4 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 5 | #include "net/dns/host_resolver_manager.h" |
[email protected] | 212d149 | 2008-09-05 19:38:54 | [diff] [blame] | 6 | |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 7 | #include <algorithm> |
Eric Roman | 21b3923 | 2019-06-28 21:28:21 | [diff] [blame] | 8 | #include <limits> |
[email protected] | 471822ca | 2009-01-29 11:32:26 | [diff] [blame] | 9 | #include <string> |
jsbell | cea42a5 | 2015-11-30 23:50:25 | [diff] [blame] | 10 | #include <tuple> |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 11 | #include <utility> |
olli.raula | 9cdf9d7 | 2015-12-10 14:24:29 | [diff] [blame] | 12 | #include <vector> |
[email protected] | 471822ca | 2009-01-29 11:32:26 | [diff] [blame] | 13 | |
Wez | a03bae0 | 2018-07-13 17:17:33 | [diff] [blame] | 14 | #include "base/auto_reset.h" |
[email protected] | aa22b24 | 2011-11-16 18:58:29 | [diff] [blame] | 15 | #include "base/bind.h" |
| 16 | #include "base/bind_helpers.h" |
skyostil | 4891b25b | 2015-06-11 11:43:45 | [diff] [blame] | 17 | #include "base/location.h" |
Avi Drissman | 13fc893 | 2015-12-20 04:40:46 | [diff] [blame] | 18 | #include "base/macros.h" |
[email protected] | 3b63f8f4 | 2011-03-28 01:54:15 | [diff] [blame] | 19 | #include "base/memory/ref_counted.h" |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 20 | #include "base/run_loop.h" |
skyostil | 4891b25b | 2015-06-11 11:43:45 | [diff] [blame] | 21 | #include "base/single_thread_task_runner.h" |
tripta.g | dda7202 | 2017-06-19 05:16:23 | [diff] [blame] | 22 | #include "base/stl_util.h" |
[email protected] | be528af | 2013-06-11 07:39:48 | [diff] [blame] | 23 | #include "base/strings/string_util.h" |
| 24 | #include "base/strings/stringprintf.h" |
[email protected] | 189163e | 2011-05-11 01:48:54 | [diff] [blame] | 25 | #include "base/synchronization/condition_variable.h" |
| 26 | #include "base/synchronization/lock.h" |
Eric Roman | 21b3923 | 2019-06-28 21:28:21 | [diff] [blame] | 27 | #include "base/task/thread_pool/thread_pool.h" |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 28 | #include "base/test/bind_test_util.h" |
Eric Orth | 026776a | 2019-01-18 00:13:28 | [diff] [blame] | 29 | #include "base/test/simple_test_clock.h" |
Eric Orth | 9a03756 | 2018-07-03 21:24:38 | [diff] [blame] | 30 | #include "base/test/test_mock_time_task_runner.h" |
[email protected] | 57a48d3 | 2012-03-03 00:04:55 | [diff] [blame] | 31 | #include "base/test/test_timeouts.h" |
Francois Doray | a2d01ba | 2017-09-25 19:17:40 | [diff] [blame] | 32 | #include "base/threading/thread_restrictions.h" |
gab | f767595f | 2016-05-11 18:50:35 | [diff] [blame] | 33 | #include "base/threading/thread_task_runner_handle.h" |
[email protected] | 66e96c4 | 2013-06-28 15:20:31 | [diff] [blame] | 34 | #include "base/time/time.h" |
Eric Orth | 026776a | 2019-01-18 00:13:28 | [diff] [blame] | 35 | #include "base/timer/mock_timer.h" |
Miriam Gershenson | 48857a35 | 2018-03-22 21:14:03 | [diff] [blame] | 36 | #include "base/values.h" |
jdoerrie | dfede5ad | 2019-02-11 13:06:57 | [diff] [blame] | 37 | #include "build/build_config.h" |
[email protected] | ecfa71c | 2008-09-09 13:28:36 | [diff] [blame] | 38 | #include "net/base/address_list.h" |
Eric Orth | 026776a | 2019-01-18 00:13:28 | [diff] [blame] | 39 | #include "net/base/host_port_pair.h" |
martijn | a23c896 | 2016-03-04 18:18:51 | [diff] [blame] | 40 | #include "net/base/ip_address.h" |
Eric Orth | 026776a | 2019-01-18 00:13:28 | [diff] [blame] | 41 | #include "net/base/ip_endpoint.h" |
mgersh | af9a923 | 2017-04-13 20:19:03 | [diff] [blame] | 42 | #include "net/base/mock_network_change_notifier.h" |
[email protected] | 471822ca | 2009-01-29 11:32:26 | [diff] [blame] | 43 | #include "net/base/net_errors.h" |
[email protected] | 78eac2a | 2012-03-14 19:09:27 | [diff] [blame] | 44 | #include "net/dns/dns_client.h" |
Eric Orth | c1eb129 | 2018-10-09 22:07:07 | [diff] [blame] | 45 | #include "net/dns/dns_config.h" |
[email protected] | 78eac2a | 2012-03-14 19:09:27 | [diff] [blame] | 46 | #include "net/dns/dns_test_util.h" |
Eric Orth | 192e3bb | 2018-11-14 19:30:32 | [diff] [blame] | 47 | #include "net/dns/dns_util.h" |
[email protected] | f2cb3cf | 2013-03-21 01:40:53 | [diff] [blame] | 48 | #include "net/dns/mock_host_resolver.h" |
Eric Orth | 9871aafa | 2018-10-02 19:59:18 | [diff] [blame] | 49 | #include "net/dns/mock_mdns_client.h" |
| 50 | #include "net/dns/mock_mdns_socket_factory.h" |
mikecirone | 8b85c43 | 2016-09-08 19:11:00 | [diff] [blame] | 51 | #include "net/log/net_log_event_type.h" |
| 52 | #include "net/log/net_log_source_type.h" |
mikecirone | f22f981 | 2016-10-04 03:40:19 | [diff] [blame] | 53 | #include "net/log/net_log_with_source.h" |
sergeyu | b8cdc21 | 2015-05-14 18:50:37 | [diff] [blame] | 54 | #include "net/log/test_net_log.h" |
Eric Roman | 79cc755 | 2019-07-19 02:17:54 | [diff] [blame] | 55 | #include "net/log/test_net_log_util.h" |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 56 | #include "net/test/gtest_util.h" |
Bence Béky | 98447b1 | 2018-05-08 03:14:01 | [diff] [blame] | 57 | #include "net/test/test_with_scoped_task_environment.h" |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 58 | #include "net/url_request/url_request_context.h" |
| 59 | #include "net/url_request/url_request_test_util.h" |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 60 | #include "testing/gmock/include/gmock/gmock.h" |
[email protected] | ecfa71c | 2008-09-09 13:28:36 | [diff] [blame] | 61 | #include "testing/gtest/include/gtest/gtest.h" |
[email protected] | 212d149 | 2008-09-05 19:38:54 | [diff] [blame] | 62 | |
Eric Orth | 026776a | 2019-01-18 00:13:28 | [diff] [blame] | 63 | #if BUILDFLAG(ENABLE_MDNS) |
| 64 | #include "net/dns/mdns_client_impl.h" |
| 65 | #endif // BUILDFLAG(ENABLE_MDNS) |
| 66 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 67 | using net::test::IsError; |
| 68 | using net::test::IsOk; |
Eric Orth | 9871aafa | 2018-10-02 19:59:18 | [diff] [blame] | 69 | using ::testing::_; |
| 70 | using ::testing::Between; |
| 71 | using ::testing::ByMove; |
Rob Percival | 94f21ad | 2017-11-14 10:20:24 | [diff] [blame] | 72 | using ::testing::NotNull; |
Eric Orth | 9871aafa | 2018-10-02 19:59:18 | [diff] [blame] | 73 | using ::testing::Return; |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 74 | |
[email protected] | 259aefa | 2009-08-20 22:45:00 | [diff] [blame] | 75 | namespace net { |
[email protected] | 68ad3ee | 2010-01-30 03:45:39 | [diff] [blame] | 76 | |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 77 | namespace { |
[email protected] | 112bd46 | 2009-12-10 07:23:40 | [diff] [blame] | 78 | |
[email protected] | 78eac2a | 2012-03-14 19:09:27 | [diff] [blame] | 79 | const size_t kMaxJobs = 10u; |
| 80 | const size_t kMaxRetryAttempts = 4u; |
[email protected] | 68ad3ee | 2010-01-30 03:45:39 | [diff] [blame] | 81 | |
Eric Orth | 5906622 | 2019-03-07 23:52:27 | [diff] [blame] | 82 | ProcTaskParams DefaultParams(HostResolverProc* resolver_proc) { |
| 83 | return ProcTaskParams(resolver_proc, kMaxRetryAttempts); |
[email protected] | 0f292de0 | 2012-02-01 22:28:20 | [diff] [blame] | 84 | } |
| 85 | |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 86 | // A HostResolverProc that pushes each host mapped into a list and allows |
| 87 | // waiting for a specific number of requests. Unlike RuleBasedHostResolverProc |
[email protected] | 1ee9afa1 | 2013-04-16 14:18:06 | [diff] [blame] | 88 | // it never calls SystemHostResolverCall. By default resolves all hostnames to |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 89 | // "127.0.0.1". After AddRule(), it resolves only names explicitly specified. |
| 90 | class MockHostResolverProc : public HostResolverProc { |
[email protected] | 57a48d3 | 2012-03-03 00:04:55 | [diff] [blame] | 91 | public: |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 92 | struct ResolveKey { |
Eric Orth | 322af3e4 | 2018-08-20 18:12:59 | [diff] [blame] | 93 | ResolveKey(const std::string& hostname, |
| 94 | AddressFamily address_family, |
| 95 | HostResolverFlags flags) |
| 96 | : hostname(hostname), address_family(address_family), flags(flags) {} |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 97 | bool operator<(const ResolveKey& other) const { |
Eric Orth | 322af3e4 | 2018-08-20 18:12:59 | [diff] [blame] | 98 | return std::tie(address_family, hostname, flags) < |
| 99 | std::tie(other.address_family, other.hostname, other.flags); |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 100 | } |
[email protected] | 137af62 | 2010-02-05 02:14:35 | [diff] [blame] | 101 | std::string hostname; |
| 102 | AddressFamily address_family; |
Eric Orth | 322af3e4 | 2018-08-20 18:12:59 | [diff] [blame] | 103 | HostResolverFlags flags; |
[email protected] | 137af62 | 2010-02-05 02:14:35 | [diff] [blame] | 104 | }; |
| 105 | |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 106 | typedef std::vector<ResolveKey> CaptureList; |
[email protected] | 137af62 | 2010-02-05 02:14:35 | [diff] [blame] | 107 | |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 108 | MockHostResolverProc() |
Raul Tambre | 94493c65 | 2019-03-11 17:18:35 | [diff] [blame] | 109 | : HostResolverProc(nullptr), |
[email protected] | 57a48d3 | 2012-03-03 00:04:55 | [diff] [blame] | 110 | num_requests_waiting_(0), |
| 111 | num_slots_available_(0), |
| 112 | requests_waiting_(&lock_), |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 113 | slots_available_(&lock_) {} |
[email protected] | 57a48d3 | 2012-03-03 00:04:55 | [diff] [blame] | 114 | |
| 115 | // Waits until |count| calls to |Resolve| are blocked. Returns false when |
| 116 | // timed out. |
| 117 | bool WaitFor(unsigned count) { |
| 118 | base::AutoLock lock(lock_); |
| 119 | base::Time start_time = base::Time::Now(); |
| 120 | while (num_requests_waiting_ < count) { |
| 121 | requests_waiting_.TimedWait(TestTimeouts::action_timeout()); |
| 122 | if (base::Time::Now() > start_time + TestTimeouts::action_timeout()) |
| 123 | return false; |
| 124 | } |
| 125 | return true; |
| 126 | } |
| 127 | |
| 128 | // Signals |count| waiting calls to |Resolve|. First come first served. |
| 129 | void SignalMultiple(unsigned count) { |
| 130 | base::AutoLock lock(lock_); |
| 131 | num_slots_available_ += count; |
| 132 | slots_available_.Broadcast(); |
| 133 | } |
| 134 | |
| 135 | // Signals all waiting calls to |Resolve|. Beware of races. |
| 136 | void SignalAll() { |
| 137 | base::AutoLock lock(lock_); |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 138 | num_slots_available_ = num_requests_waiting_; |
[email protected] | 57a48d3 | 2012-03-03 00:04:55 | [diff] [blame] | 139 | slots_available_.Broadcast(); |
| 140 | } |
| 141 | |
Eric Orth | 322af3e4 | 2018-08-20 18:12:59 | [diff] [blame] | 142 | void AddRule(const std::string& hostname, |
| 143 | AddressFamily family, |
| 144 | const AddressList& result, |
| 145 | HostResolverFlags flags = 0) { |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 146 | base::AutoLock lock(lock_); |
Eric Orth | 322af3e4 | 2018-08-20 18:12:59 | [diff] [blame] | 147 | rules_[ResolveKey(hostname, family, flags)] = result; |
[email protected] | 57a48d3 | 2012-03-03 00:04:55 | [diff] [blame] | 148 | } |
| 149 | |
Eric Orth | 322af3e4 | 2018-08-20 18:12:59 | [diff] [blame] | 150 | void AddRule(const std::string& hostname, |
| 151 | AddressFamily family, |
| 152 | const std::string& ip_list, |
| 153 | HostResolverFlags flags = 0, |
| 154 | const std::string& canonical_name = "") { |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 155 | AddressList result; |
Eric Orth | 322af3e4 | 2018-08-20 18:12:59 | [diff] [blame] | 156 | int rv = ParseAddressList(ip_list, canonical_name, &result); |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 157 | DCHECK_EQ(OK, rv); |
Eric Orth | 322af3e4 | 2018-08-20 18:12:59 | [diff] [blame] | 158 | AddRule(hostname, family, result, flags); |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 159 | } |
[email protected] | 57a48d3 | 2012-03-03 00:04:55 | [diff] [blame] | 160 | |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 161 | void AddRuleForAllFamilies(const std::string& hostname, |
Eric Orth | 322af3e4 | 2018-08-20 18:12:59 | [diff] [blame] | 162 | const std::string& ip_list, |
| 163 | HostResolverFlags flags = 0, |
| 164 | const std::string& canonical_name = "") { |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 165 | AddressList result; |
Eric Orth | 322af3e4 | 2018-08-20 18:12:59 | [diff] [blame] | 166 | int rv = ParseAddressList(ip_list, canonical_name, &result); |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 167 | DCHECK_EQ(OK, rv); |
Eric Orth | 322af3e4 | 2018-08-20 18:12:59 | [diff] [blame] | 168 | AddRule(hostname, ADDRESS_FAMILY_UNSPECIFIED, result, flags); |
| 169 | AddRule(hostname, ADDRESS_FAMILY_IPV4, result, flags); |
| 170 | AddRule(hostname, ADDRESS_FAMILY_IPV6, result, flags); |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 171 | } |
[email protected] | 137af62 | 2010-02-05 02:14:35 | [diff] [blame] | 172 | |
dcheng | b03027d | 2014-10-21 12:00:20 | [diff] [blame] | 173 | int Resolve(const std::string& hostname, |
| 174 | AddressFamily address_family, |
| 175 | HostResolverFlags host_resolver_flags, |
| 176 | AddressList* addrlist, |
| 177 | int* os_error) override { |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 178 | base::AutoLock lock(lock_); |
Eric Orth | 322af3e4 | 2018-08-20 18:12:59 | [diff] [blame] | 179 | capture_list_.push_back( |
| 180 | ResolveKey(hostname, address_family, host_resolver_flags)); |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 181 | ++num_requests_waiting_; |
| 182 | requests_waiting_.Broadcast(); |
Francois Doray | a2d01ba | 2017-09-25 19:17:40 | [diff] [blame] | 183 | { |
| 184 | base::ScopedAllowBaseSyncPrimitivesForTesting |
| 185 | scoped_allow_base_sync_primitives; |
| 186 | while (!num_slots_available_) |
| 187 | slots_available_.Wait(); |
| 188 | } |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 189 | DCHECK_GT(num_requests_waiting_, 0u); |
| 190 | --num_slots_available_; |
| 191 | --num_requests_waiting_; |
| 192 | if (rules_.empty()) { |
[email protected] | 007b3f8 | 2013-04-09 08:46:45 | [diff] [blame] | 193 | int rv = ParseAddressList("127.0.0.1", std::string(), addrlist); |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 194 | DCHECK_EQ(OK, rv); |
| 195 | return OK; |
| 196 | } |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 197 | // Ignore HOST_RESOLVER_SYSTEM_ONLY, since it should have no impact on |
| 198 | // whether a rule matches. It should only affect cache lookups. |
| 199 | ResolveKey key(hostname, address_family, |
| 200 | host_resolver_flags & ~HOST_RESOLVER_SYSTEM_ONLY); |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 201 | if (rules_.count(key) == 0) |
| 202 | return ERR_NAME_NOT_RESOLVED; |
| 203 | *addrlist = rules_[key]; |
| 204 | return OK; |
[email protected] | 137af62 | 2010-02-05 02:14:35 | [diff] [blame] | 205 | } |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 206 | |
| 207 | CaptureList GetCaptureList() const { |
| 208 | CaptureList copy; |
| 209 | { |
| 210 | base::AutoLock lock(lock_); |
| 211 | copy = capture_list_; |
| 212 | } |
| 213 | return copy; |
| 214 | } |
| 215 | |
| 216 | bool HasBlockedRequests() const { |
| 217 | base::AutoLock lock(lock_); |
| 218 | return num_requests_waiting_ > num_slots_available_; |
| 219 | } |
| 220 | |
[email protected] | a981330 | 2012-04-28 09:29:28 | [diff] [blame] | 221 | protected: |
Chris Watkins | 68b1503 | 2017-12-01 03:07:13 | [diff] [blame] | 222 | ~MockHostResolverProc() override = default; |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 223 | |
[email protected] | a981330 | 2012-04-28 09:29:28 | [diff] [blame] | 224 | private: |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 225 | mutable base::Lock lock_; |
| 226 | std::map<ResolveKey, AddressList> rules_; |
| 227 | CaptureList capture_list_; |
| 228 | unsigned num_requests_waiting_; |
| 229 | unsigned num_slots_available_; |
| 230 | base::ConditionVariable requests_waiting_; |
| 231 | base::ConditionVariable slots_available_; |
| 232 | |
| 233 | DISALLOW_COPY_AND_ASSIGN(MockHostResolverProc); |
| 234 | }; |
| 235 | |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 236 | class ResolveHostResponseHelper { |
| 237 | public: |
| 238 | using Callback = |
| 239 | base::OnceCallback<void(CompletionOnceCallback completion_callback, |
| 240 | int error)>; |
| 241 | |
| 242 | ResolveHostResponseHelper() {} |
| 243 | explicit ResolveHostResponseHelper( |
Eric Orth | 5233c3a | 2019-04-08 17:01:14 | [diff] [blame] | 244 | std::unique_ptr<HostResolverManager::CancellableRequest> request) |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 245 | : request_(std::move(request)) { |
| 246 | result_error_ = request_->Start(base::BindOnce( |
| 247 | &ResolveHostResponseHelper::OnComplete, base::Unretained(this))); |
| 248 | } |
| 249 | ResolveHostResponseHelper( |
Eric Orth | 5233c3a | 2019-04-08 17:01:14 | [diff] [blame] | 250 | std::unique_ptr<HostResolverManager::CancellableRequest> request, |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 251 | Callback custom_callback) |
| 252 | : request_(std::move(request)) { |
| 253 | result_error_ = request_->Start( |
| 254 | base::BindOnce(std::move(custom_callback), |
| 255 | base::BindOnce(&ResolveHostResponseHelper::OnComplete, |
| 256 | base::Unretained(this)))); |
| 257 | } |
| 258 | |
| 259 | bool complete() const { return result_error_ != ERR_IO_PENDING; } |
| 260 | int result_error() { |
| 261 | WaitForCompletion(); |
| 262 | return result_error_; |
| 263 | } |
| 264 | |
Eric Orth | 5233c3a | 2019-04-08 17:01:14 | [diff] [blame] | 265 | HostResolverManager::CancellableRequest* request() { return request_.get(); } |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 266 | |
| 267 | void CancelRequest() { |
| 268 | DCHECK(request_); |
| 269 | DCHECK(!complete()); |
| 270 | |
| 271 | request_ = nullptr; |
| 272 | } |
| 273 | |
| 274 | void OnComplete(int error) { |
| 275 | DCHECK(!complete()); |
| 276 | result_error_ = error; |
| 277 | |
| 278 | run_loop_.Quit(); |
| 279 | } |
| 280 | |
| 281 | private: |
| 282 | void WaitForCompletion() { |
| 283 | DCHECK(request_); |
| 284 | if (complete()) { |
| 285 | return; |
| 286 | } |
| 287 | run_loop_.Run(); |
| 288 | DCHECK(complete()); |
| 289 | } |
| 290 | |
Eric Orth | 5233c3a | 2019-04-08 17:01:14 | [diff] [blame] | 291 | std::unique_ptr<HostResolverManager::CancellableRequest> request_; |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 292 | int result_error_ = ERR_IO_PENDING; |
| 293 | base::RunLoop run_loop_; |
| 294 | |
| 295 | DISALLOW_COPY_AND_ASSIGN(ResolveHostResponseHelper); |
| 296 | }; |
| 297 | |
[email protected] | 189163e | 2011-05-11 01:48:54 | [diff] [blame] | 298 | // Using LookupAttemptHostResolverProc simulate very long lookups, and control |
| 299 | // which attempt resolves the host. |
| 300 | class LookupAttemptHostResolverProc : public HostResolverProc { |
| 301 | public: |
| 302 | LookupAttemptHostResolverProc(HostResolverProc* previous, |
| 303 | int attempt_number_to_resolve, |
| 304 | int total_attempts) |
| 305 | : HostResolverProc(previous), |
| 306 | attempt_number_to_resolve_(attempt_number_to_resolve), |
| 307 | current_attempt_number_(0), |
| 308 | total_attempts_(total_attempts), |
| 309 | total_attempts_resolved_(0), |
| 310 | resolved_attempt_number_(0), |
Eric Orth | 9a03756 | 2018-07-03 21:24:38 | [diff] [blame] | 311 | num_attempts_waiting_(0), |
| 312 | all_done_(&lock_), |
| 313 | blocked_attempt_signal_(&lock_) {} |
[email protected] | 189163e | 2011-05-11 01:48:54 | [diff] [blame] | 314 | |
| 315 | // Test harness will wait for all attempts to finish before checking the |
| 316 | // results. |
Eric Orth | 9a03756 | 2018-07-03 21:24:38 | [diff] [blame] | 317 | void WaitForAllAttemptsToFinish() { |
| 318 | base::AutoLock auto_lock(lock_); |
| 319 | while (total_attempts_resolved_ != total_attempts_) { |
| 320 | all_done_.Wait(); |
| 321 | } |
| 322 | } |
| 323 | |
| 324 | void WaitForNAttemptsToBeBlocked(int n) { |
| 325 | base::AutoLock auto_lock(lock_); |
| 326 | while (num_attempts_waiting_ < n) { |
| 327 | blocked_attempt_signal_.Wait(); |
[email protected] | 189163e | 2011-05-11 01:48:54 | [diff] [blame] | 328 | } |
| 329 | } |
| 330 | |
| 331 | // All attempts will wait for an attempt to resolve the host. |
| 332 | void WaitForAnAttemptToComplete() { |
[email protected] | 189163e | 2011-05-11 01:48:54 | [diff] [blame] | 333 | { |
| 334 | base::AutoLock auto_lock(lock_); |
Francois Doray | a2d01ba | 2017-09-25 19:17:40 | [diff] [blame] | 335 | base::ScopedAllowBaseSyncPrimitivesForTesting |
| 336 | scoped_allow_base_sync_primitives; |
Eric Orth | 9a03756 | 2018-07-03 21:24:38 | [diff] [blame] | 337 | while (resolved_attempt_number_ == 0) |
| 338 | all_done_.Wait(); |
[email protected] | 189163e | 2011-05-11 01:48:54 | [diff] [blame] | 339 | } |
| 340 | all_done_.Broadcast(); // Tell all waiting attempts to proceed. |
| 341 | } |
| 342 | |
| 343 | // Returns the number of attempts that have finished the Resolve() method. |
Eric Roman | 21b3923 | 2019-06-28 21:28:21 | [diff] [blame] | 344 | int GetTotalAttemptsResolved() { |
| 345 | base::AutoLock auto_lock(lock_); |
| 346 | return total_attempts_resolved_; |
| 347 | } |
[email protected] | 189163e | 2011-05-11 01:48:54 | [diff] [blame] | 348 | |
Eric Roman | 21b3923 | 2019-06-28 21:28:21 | [diff] [blame] | 349 | // Sets the resolved attempt number and unblocks waiting |
| 350 | // attempts. |
| 351 | void SetResolvedAttemptNumber(int n) { |
| 352 | base::AutoLock auto_lock(lock_); |
| 353 | EXPECT_EQ(0, resolved_attempt_number_); |
| 354 | resolved_attempt_number_ = n; |
| 355 | all_done_.Broadcast(); |
| 356 | } |
Eric Orth | 9a03756 | 2018-07-03 21:24:38 | [diff] [blame] | 357 | |
[email protected] | 189163e | 2011-05-11 01:48:54 | [diff] [blame] | 358 | // HostResolverProc methods. |
dcheng | b03027d | 2014-10-21 12:00:20 | [diff] [blame] | 359 | int Resolve(const std::string& host, |
| 360 | AddressFamily address_family, |
| 361 | HostResolverFlags host_resolver_flags, |
| 362 | AddressList* addrlist, |
| 363 | int* os_error) override { |
[email protected] | 189163e | 2011-05-11 01:48:54 | [diff] [blame] | 364 | bool wait_for_right_attempt_to_complete = true; |
| 365 | { |
| 366 | base::AutoLock auto_lock(lock_); |
| 367 | ++current_attempt_number_; |
Eric Orth | 9a03756 | 2018-07-03 21:24:38 | [diff] [blame] | 368 | ++num_attempts_waiting_; |
[email protected] | 189163e | 2011-05-11 01:48:54 | [diff] [blame] | 369 | if (current_attempt_number_ == attempt_number_to_resolve_) { |
| 370 | resolved_attempt_number_ = current_attempt_number_; |
| 371 | wait_for_right_attempt_to_complete = false; |
| 372 | } |
| 373 | } |
| 374 | |
Eric Orth | 9a03756 | 2018-07-03 21:24:38 | [diff] [blame] | 375 | blocked_attempt_signal_.Broadcast(); |
| 376 | |
[email protected] | 189163e | 2011-05-11 01:48:54 | [diff] [blame] | 377 | if (wait_for_right_attempt_to_complete) |
| 378 | // Wait for the attempt_number_to_resolve_ attempt to resolve. |
| 379 | WaitForAnAttemptToComplete(); |
| 380 | |
| 381 | int result = ResolveUsingPrevious(host, address_family, host_resolver_flags, |
| 382 | addrlist, os_error); |
| 383 | |
| 384 | { |
| 385 | base::AutoLock auto_lock(lock_); |
| 386 | ++total_attempts_resolved_; |
Eric Orth | 9a03756 | 2018-07-03 21:24:38 | [diff] [blame] | 387 | --num_attempts_waiting_; |
[email protected] | 189163e | 2011-05-11 01:48:54 | [diff] [blame] | 388 | } |
| 389 | |
| 390 | all_done_.Broadcast(); // Tell all attempts to proceed. |
| 391 | |
| 392 | // Since any negative number is considered a network error, with -1 having |
| 393 | // special meaning (ERR_IO_PENDING). We could return the attempt that has |
| 394 | // resolved the host as a negative number. For example, if attempt number 3 |
| 395 | // resolves the host, then this method returns -4. |
| 396 | if (result == OK) |
| 397 | return -1 - resolved_attempt_number_; |
| 398 | else |
| 399 | return result; |
| 400 | } |
| 401 | |
[email protected] | a981330 | 2012-04-28 09:29:28 | [diff] [blame] | 402 | protected: |
Chris Watkins | 68b1503 | 2017-12-01 03:07:13 | [diff] [blame] | 403 | ~LookupAttemptHostResolverProc() override = default; |
[email protected] | 189163e | 2011-05-11 01:48:54 | [diff] [blame] | 404 | |
[email protected] | a981330 | 2012-04-28 09:29:28 | [diff] [blame] | 405 | private: |
[email protected] | 189163e | 2011-05-11 01:48:54 | [diff] [blame] | 406 | int attempt_number_to_resolve_; |
| 407 | int current_attempt_number_; // Incremented whenever Resolve is called. |
| 408 | int total_attempts_; |
| 409 | int total_attempts_resolved_; |
| 410 | int resolved_attempt_number_; |
Eric Orth | 9a03756 | 2018-07-03 21:24:38 | [diff] [blame] | 411 | int num_attempts_waiting_; |
[email protected] | 189163e | 2011-05-11 01:48:54 | [diff] [blame] | 412 | |
| 413 | // All attempts wait for right attempt to be resolve. |
| 414 | base::Lock lock_; |
| 415 | base::ConditionVariable all_done_; |
Eric Orth | 9a03756 | 2018-07-03 21:24:38 | [diff] [blame] | 416 | base::ConditionVariable blocked_attempt_signal_; |
[email protected] | 189163e | 2011-05-11 01:48:54 | [diff] [blame] | 417 | }; |
| 418 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 419 | // TestHostResolverManager's sole purpose is to mock the IPv6 reachability test. |
cbentzel | 1906f87 | 2015-06-05 16:25:25 | [diff] [blame] | 420 | // By default, this pretends that IPv6 is globally reachable. |
| 421 | // This class is necessary so unit tests run the same on dual-stack machines as |
| 422 | // well as IPv4 only machines. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 423 | class TestHostResolverManager : public HostResolverManager { |
cbentzel | 1906f87 | 2015-06-05 16:25:25 | [diff] [blame] | 424 | public: |
Eric Orth | 4d635c1 | 2019-04-24 22:53:04 | [diff] [blame] | 425 | TestHostResolverManager(const HostResolver::ManagerOptions& options, |
| 426 | NetLog* net_log) |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 427 | : TestHostResolverManager(options, net_log, true) {} |
cbentzel | 1906f87 | 2015-06-05 16:25:25 | [diff] [blame] | 428 | |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 429 | TestHostResolverManager(const HostResolver::ManagerOptions& options, |
| 430 | NetLog* net_log, |
| 431 | bool ipv6_reachable) |
| 432 | : HostResolverManager(options, net_log), |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 433 | ipv6_reachable_(ipv6_reachable) {} |
cbentzel | 1906f87 | 2015-06-05 16:25:25 | [diff] [blame] | 434 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 435 | ~TestHostResolverManager() override = default; |
cbentzel | 1906f87 | 2015-06-05 16:25:25 | [diff] [blame] | 436 | |
| 437 | private: |
| 438 | const bool ipv6_reachable_; |
| 439 | |
mgersh | af9a923 | 2017-04-13 20:19:03 | [diff] [blame] | 440 | bool IsGloballyReachable(const IPAddress& dest, |
| 441 | const NetLogWithSource& net_log) override { |
cbentzel | 1906f87 | 2015-06-05 16:25:25 | [diff] [blame] | 442 | return ipv6_reachable_; |
| 443 | } |
| 444 | }; |
| 445 | |
Matt Menke | c35d163 | 2018-11-29 12:43:49 | [diff] [blame] | 446 | bool HasAddress(const IPAddress& search_address, const AddressList& addresses) { |
tfarina | 9ed7f8c5 | 2016-02-19 17:50:18 | [diff] [blame] | 447 | for (const auto& address : addresses) { |
Matt Menke | c35d163 | 2018-11-29 12:43:49 | [diff] [blame] | 448 | if (search_address == address.address()) |
tfarina | 9ed7f8c5 | 2016-02-19 17:50:18 | [diff] [blame] | 449 | return true; |
| 450 | } |
| 451 | return false; |
| 452 | } |
| 453 | |
| 454 | void TestBothLoopbackIPs(const std::string& host) { |
tfarina | 9ed7f8c5 | 2016-02-19 17:50:18 | [diff] [blame] | 455 | AddressList addresses; |
Matt Menke | c35d163 | 2018-11-29 12:43:49 | [diff] [blame] | 456 | EXPECT_TRUE(ResolveLocalHostname(host, &addresses)); |
tfarina | 9ed7f8c5 | 2016-02-19 17:50:18 | [diff] [blame] | 457 | EXPECT_EQ(2u, addresses.size()); |
Matt Menke | c35d163 | 2018-11-29 12:43:49 | [diff] [blame] | 458 | EXPECT_TRUE(HasAddress(IPAddress::IPv4Localhost(), addresses)); |
| 459 | EXPECT_TRUE(HasAddress(IPAddress::IPv6Localhost(), addresses)); |
tfarina | 9ed7f8c5 | 2016-02-19 17:50:18 | [diff] [blame] | 460 | } |
| 461 | |
| 462 | void TestIPv6LoopbackOnly(const std::string& host) { |
tfarina | 9ed7f8c5 | 2016-02-19 17:50:18 | [diff] [blame] | 463 | AddressList addresses; |
Matt Menke | c35d163 | 2018-11-29 12:43:49 | [diff] [blame] | 464 | EXPECT_TRUE(ResolveLocalHostname(host, &addresses)); |
tfarina | 9ed7f8c5 | 2016-02-19 17:50:18 | [diff] [blame] | 465 | EXPECT_EQ(1u, addresses.size()); |
Matt Menke | c35d163 | 2018-11-29 12:43:49 | [diff] [blame] | 466 | EXPECT_TRUE(HasAddress(IPAddress::IPv6Localhost(), addresses)); |
tfarina | 9ed7f8c5 | 2016-02-19 17:50:18 | [diff] [blame] | 467 | } |
| 468 | |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 469 | } // namespace |
[email protected] | 8a00f00a | 2009-06-12 00:49:38 | [diff] [blame] | 470 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 471 | class HostResolverManagerTest : public TestWithScopedTaskEnvironment { |
[email protected] | 471822ca | 2009-01-29 11:32:26 | [diff] [blame] | 472 | public: |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 473 | static const int kDefaultPort = 80; |
| 474 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 475 | HostResolverManagerTest() : proc_(new MockHostResolverProc()) {} |
[email protected] | 471822ca | 2009-01-29 11:32:26 | [diff] [blame] | 476 | |
Eric Orth | 607b6d8 | 2019-05-08 16:43:32 | [diff] [blame] | 477 | void CreateResolver(bool check_ipv6_on_wifi = true) { |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 478 | CreateResolverWithLimitsAndParams(kMaxJobs, DefaultParams(proc_.get()), |
Eric Orth | 607b6d8 | 2019-05-08 16:43:32 | [diff] [blame] | 479 | true /* ipv6_reachable */, |
| 480 | check_ipv6_on_wifi); |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 481 | } |
| 482 | |
Eric Orth | 37b1819 | 2019-04-22 19:09:28 | [diff] [blame] | 483 | void DestroyResolver() { |
| 484 | if (!resolver_) |
| 485 | return; |
| 486 | |
| 487 | if (host_cache_) |
| 488 | resolver_->RemoveHostCacheInvalidator(host_cache_->invalidator()); |
| 489 | resolver_ = nullptr; |
| 490 | } |
| 491 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 492 | // This HostResolverManager will only allow 1 outstanding resolve at a time |
| 493 | // and perform no retries. |
Eric Orth | 607b6d8 | 2019-05-08 16:43:32 | [diff] [blame] | 494 | void CreateSerialResolver(bool check_ipv6_on_wifi = true) { |
Eric Orth | 5906622 | 2019-03-07 23:52:27 | [diff] [blame] | 495 | ProcTaskParams params = DefaultParams(proc_.get()); |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 496 | params.max_retry_attempts = 0u; |
Eric Orth | 607b6d8 | 2019-05-08 16:43:32 | [diff] [blame] | 497 | CreateResolverWithLimitsAndParams(1u, params, true /* ipv6_reachable */, |
| 498 | check_ipv6_on_wifi); |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 499 | } |
| 500 | |
[email protected] | 471822ca | 2009-01-29 11:32:26 | [diff] [blame] | 501 | protected: |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 502 | // testing::Test implementation: |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 503 | void SetUp() override { |
Eric Orth | 37b1819 | 2019-04-22 19:09:28 | [diff] [blame] | 504 | host_cache_ = HostCache::CreateDefaultCache(); |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 505 | CreateResolver(); |
| 506 | request_context_ = std::make_unique<TestURLRequestContext>(); |
| 507 | } |
[email protected] | 70c04ab | 2013-08-22 16:05:12 | [diff] [blame] | 508 | |
dcheng | 67be2b1f | 2014-10-27 21:47:29 | [diff] [blame] | 509 | void TearDown() override { |
Eric Orth | 37b1819 | 2019-04-22 19:09:28 | [diff] [blame] | 510 | if (resolver_) { |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 511 | EXPECT_EQ(0u, resolver_->num_running_dispatcher_jobs_for_tests()); |
Eric Orth | 37b1819 | 2019-04-22 19:09:28 | [diff] [blame] | 512 | if (host_cache_) |
| 513 | resolver_->RemoveHostCacheInvalidator(host_cache_->invalidator()); |
| 514 | } |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 515 | EXPECT_FALSE(proc_->HasBlockedRequests()); |
| 516 | } |
| 517 | |
Eric Orth | 4e55b36 | 2019-05-07 22:00:03 | [diff] [blame] | 518 | void CreateResolverWithLimitsAndParams(size_t max_concurrent_resolves, |
| 519 | const ProcTaskParams& params, |
Eric Orth | 607b6d8 | 2019-05-08 16:43:32 | [diff] [blame] | 520 | bool ipv6_reachable, |
| 521 | bool check_ipv6_on_wifi) { |
Eric Orth | 4d635c1 | 2019-04-24 22:53:04 | [diff] [blame] | 522 | HostResolver::ManagerOptions options = DefaultOptions(); |
[email protected] | 106ccd2c | 2014-06-17 09:21:00 | [diff] [blame] | 523 | options.max_concurrent_resolves = max_concurrent_resolves; |
Eric Orth | 607b6d8 | 2019-05-08 16:43:32 | [diff] [blame] | 524 | options.check_ipv6_on_wifi = check_ipv6_on_wifi; |
Eric Orth | 4e55b36 | 2019-05-07 22:00:03 | [diff] [blame] | 525 | |
| 526 | CreateResolverWithOptionsAndParams(std::move(options), params, |
| 527 | ipv6_reachable); |
| 528 | } |
| 529 | |
| 530 | virtual HostResolver::ManagerOptions DefaultOptions() { |
| 531 | HostResolver::ManagerOptions options; |
| 532 | options.max_concurrent_resolves = kMaxJobs; |
| 533 | options.max_system_retry_attempts = kMaxRetryAttempts; |
| 534 | return options; |
| 535 | } |
| 536 | |
| 537 | virtual void CreateResolverWithOptionsAndParams( |
| 538 | HostResolver::ManagerOptions options, |
| 539 | const ProcTaskParams& params, |
| 540 | bool ipv6_reachable) { |
| 541 | // Use HostResolverManagerDnsTest if enabling DNS client. |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 542 | DCHECK(!options.insecure_dns_client_enabled); |
Eric Orth | 4e55b36 | 2019-05-07 22:00:03 | [diff] [blame] | 543 | |
| 544 | DestroyResolver(); |
| 545 | |
| 546 | resolver_ = std::make_unique<TestHostResolverManager>( |
| 547 | options, nullptr /* net_log */, ipv6_reachable); |
[email protected] | 106ccd2c | 2014-06-17 09:21:00 | [diff] [blame] | 548 | resolver_->set_proc_params_for_test(params); |
Eric Orth | 37b1819 | 2019-04-22 19:09:28 | [diff] [blame] | 549 | |
| 550 | if (host_cache_) |
| 551 | resolver_->AddHostCacheInvalidator(host_cache_->invalidator()); |
[email protected] | 471822ca | 2009-01-29 11:32:26 | [diff] [blame] | 552 | } |
[email protected] | aa22b24 | 2011-11-16 18:58:29 | [diff] [blame] | 553 | |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 554 | // Friendship is not inherited, so use proxies to access those. |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 555 | size_t num_running_dispatcher_jobs() const { |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 556 | DCHECK(resolver_.get()); |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 557 | return resolver_->num_running_dispatcher_jobs_for_tests(); |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 558 | } |
| 559 | |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 560 | void set_allow_fallback_to_proctask(bool allow_fallback_to_proctask) { |
[email protected] | 16c2bd7 | 2013-06-28 01:19:22 | [diff] [blame] | 561 | DCHECK(resolver_.get()); |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 562 | resolver_->allow_fallback_to_proctask_ = allow_fallback_to_proctask; |
[email protected] | 16c2bd7 | 2013-06-28 01:19:22 | [diff] [blame] | 563 | } |
| 564 | |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 565 | static unsigned maximum_insecure_dns_task_failures() { |
| 566 | return HostResolverManager::kMaximumInsecureDnsTaskFailures; |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 567 | } |
| 568 | |
tfarina | 4283411 | 2016-09-22 13:38:20 | [diff] [blame] | 569 | bool IsIPv6Reachable(const NetLogWithSource& net_log) { |
sergeyu | b8cdc21 | 2015-05-14 18:50:37 | [diff] [blame] | 570 | return resolver_->IsIPv6Reachable(net_log); |
| 571 | } |
| 572 | |
dalyk | e966a183 | 2019-06-05 20:53:13 | [diff] [blame] | 573 | void PopulateCache(HostCache::Key& key, IPEndPoint endpoint) { |
| 574 | resolver_->CacheResult(host_cache_.get(), key, |
| 575 | HostCache::Entry(OK, AddressList(endpoint), |
| 576 | HostCache::Entry::SOURCE_UNKNOWN), |
| 577 | base::TimeDelta::FromSeconds(1)); |
| 578 | } |
| 579 | |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 580 | const std::pair<const HostCache::Key, HostCache::Entry>* GetCacheHit( |
| 581 | const HostCache::Key& key) { |
Eric Orth | 37b1819 | 2019-04-22 19:09:28 | [diff] [blame] | 582 | DCHECK(host_cache_); |
| 583 | return host_cache_->LookupStale(key, base::TimeTicks(), nullptr, |
| 584 | false /* ignore_secure */); |
Rob Percival | 94f21ad | 2017-11-14 10:20:24 | [diff] [blame] | 585 | } |
| 586 | |
juliatuttle | 9fb7aeb | 2016-06-06 20:16:33 | [diff] [blame] | 587 | void MakeCacheStale() { |
Eric Orth | 37b1819 | 2019-04-22 19:09:28 | [diff] [blame] | 588 | DCHECK(host_cache_); |
| 589 | host_cache_->Invalidate(); |
juliatuttle | 9fb7aeb | 2016-06-06 20:16:33 | [diff] [blame] | 590 | } |
| 591 | |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 592 | IPEndPoint CreateExpected(const std::string& ip_literal, uint16_t port) { |
| 593 | IPAddress ip; |
| 594 | bool result = ip.AssignFromIPLiteral(ip_literal); |
| 595 | DCHECK(result); |
| 596 | return IPEndPoint(ip, port); |
| 597 | } |
| 598 | |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 599 | scoped_refptr<MockHostResolverProc> proc_; |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 600 | std::unique_ptr<HostResolverManager> resolver_; |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 601 | std::unique_ptr<URLRequestContext> request_context_; |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 602 | std::unique_ptr<HostCache> host_cache_; |
[email protected] | 471822ca | 2009-01-29 11:32:26 | [diff] [blame] | 603 | }; |
| 604 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 605 | TEST_F(HostResolverManagerTest, AsynchronousLookup) { |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 606 | proc_->AddRuleForAllFamilies("just.testing", "192.168.1.42"); |
| 607 | proc_->SignalMultiple(1u); |
[email protected] | 471822ca | 2009-01-29 11:32:26 | [diff] [blame] | 608 | |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 609 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 610 | HostPortPair("just.testing", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 611 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 612 | |
| 613 | EXPECT_THAT(response.result_error(), IsOk()); |
| 614 | EXPECT_THAT(response.request()->GetAddressResults().value().endpoints(), |
| 615 | testing::ElementsAre(CreateExpected("192.168.1.42", 80))); |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 616 | EXPECT_FALSE(response.request()->GetStaleInfo()); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 617 | |
| 618 | EXPECT_EQ("just.testing", proc_->GetCaptureList()[0].hostname); |
Eric Orth | 26fa08e | 2019-02-22 01:28:37 | [diff] [blame] | 619 | |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 620 | const std::pair<const HostCache::Key, HostCache::Entry>* cache_result = |
| 621 | GetCacheHit(HostCache::Key("just.testing", DnsQueryType::UNSPECIFIED, |
| 622 | 0 /* host_resolver_flags */, |
| 623 | HostResolverSource::ANY)); |
| 624 | EXPECT_TRUE(cache_result); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 625 | } |
| 626 | |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 627 | TEST_F(HostResolverManagerTest, JobsClearedOnCompletion) { |
| 628 | proc_->AddRuleForAllFamilies("just.testing", "192.168.1.42"); |
| 629 | proc_->SignalMultiple(1u); |
| 630 | |
| 631 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 632 | HostPortPair("just.testing", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 633 | request_context_.get(), host_cache_.get())); |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 634 | EXPECT_EQ(1u, resolver_->num_jobs_for_testing()); |
| 635 | |
| 636 | EXPECT_THAT(response.result_error(), IsOk()); |
| 637 | EXPECT_EQ(0u, resolver_->num_jobs_for_testing()); |
| 638 | } |
| 639 | |
| 640 | TEST_F(HostResolverManagerTest, JobsClearedOnCompletion_MultipleRequests) { |
| 641 | proc_->AddRuleForAllFamilies("just.testing", "192.168.1.42"); |
| 642 | proc_->SignalMultiple(1u); |
| 643 | |
| 644 | ResolveHostResponseHelper response1(resolver_->CreateRequest( |
| 645 | HostPortPair("just.testing", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 646 | request_context_.get(), host_cache_.get())); |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 647 | ResolveHostResponseHelper response2(resolver_->CreateRequest( |
| 648 | HostPortPair("just.testing", 85), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 649 | request_context_.get(), host_cache_.get())); |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 650 | EXPECT_EQ(1u, resolver_->num_jobs_for_testing()); |
| 651 | |
| 652 | EXPECT_THAT(response1.result_error(), IsOk()); |
| 653 | EXPECT_THAT(response2.result_error(), IsOk()); |
| 654 | EXPECT_EQ(0u, resolver_->num_jobs_for_testing()); |
| 655 | } |
| 656 | |
| 657 | TEST_F(HostResolverManagerTest, JobsClearedOnCompletion_Failure) { |
| 658 | proc_->AddRuleForAllFamilies(std::string(), |
| 659 | "0.0.0.0"); // Default to failures. |
| 660 | proc_->SignalMultiple(1u); |
| 661 | |
| 662 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 663 | HostPortPair("just.testing", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 664 | request_context_.get(), host_cache_.get())); |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 665 | EXPECT_EQ(1u, resolver_->num_jobs_for_testing()); |
| 666 | |
| 667 | EXPECT_THAT(response.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 668 | EXPECT_EQ(0u, resolver_->num_jobs_for_testing()); |
| 669 | } |
| 670 | |
| 671 | TEST_F(HostResolverManagerTest, JobsClearedOnCompletion_Abort) { |
| 672 | proc_->AddRuleForAllFamilies("just.testing", "192.168.1.42"); |
| 673 | |
| 674 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 675 | HostPortPair("just.testing", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 676 | request_context_.get(), host_cache_.get())); |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 677 | EXPECT_EQ(1u, resolver_->num_jobs_for_testing()); |
| 678 | |
| 679 | NetworkChangeNotifier::NotifyObserversOfIPAddressChangeForTests(); |
| 680 | proc_->SignalMultiple(1u); |
| 681 | |
| 682 | EXPECT_THAT(response.result_error(), IsError(ERR_NETWORK_CHANGED)); |
| 683 | EXPECT_EQ(0u, resolver_->num_jobs_for_testing()); |
| 684 | } |
| 685 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 686 | TEST_F(HostResolverManagerTest, DnsQueryType) { |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 687 | proc_->AddRule("host", ADDRESS_FAMILY_IPV4, "192.168.1.20"); |
| 688 | proc_->AddRule("host", ADDRESS_FAMILY_IPV6, "::5"); |
| 689 | |
| 690 | HostResolver::ResolveHostParameters parameters; |
| 691 | |
Eric Orth | 192e3bb | 2018-11-14 19:30:32 | [diff] [blame] | 692 | parameters.dns_query_type = DnsQueryType::A; |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 693 | ResolveHostResponseHelper v4_response(resolver_->CreateRequest( |
| 694 | HostPortPair("host", 80), NetLogWithSource(), parameters, |
| 695 | request_context_.get(), host_cache_.get())); |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 696 | |
Eric Orth | 192e3bb | 2018-11-14 19:30:32 | [diff] [blame] | 697 | parameters.dns_query_type = DnsQueryType::AAAA; |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 698 | ResolveHostResponseHelper v6_response(resolver_->CreateRequest( |
| 699 | HostPortPair("host", 80), NetLogWithSource(), parameters, |
| 700 | request_context_.get(), host_cache_.get())); |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 701 | |
| 702 | proc_->SignalMultiple(2u); |
| 703 | |
| 704 | EXPECT_THAT(v4_response.result_error(), IsOk()); |
| 705 | EXPECT_THAT(v4_response.request()->GetAddressResults().value().endpoints(), |
| 706 | testing::ElementsAre(CreateExpected("192.168.1.20", 80))); |
| 707 | |
| 708 | EXPECT_THAT(v6_response.result_error(), IsOk()); |
| 709 | EXPECT_THAT(v6_response.request()->GetAddressResults().value().endpoints(), |
| 710 | testing::ElementsAre(CreateExpected("::5", 80))); |
| 711 | } |
| 712 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 713 | TEST_F(HostResolverManagerTest, LocalhostIPV4IPV6Lookup) { |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 714 | HostResolver::ResolveHostParameters parameters; |
| 715 | |
Eric Orth | 192e3bb | 2018-11-14 19:30:32 | [diff] [blame] | 716 | parameters.dns_query_type = DnsQueryType::A; |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 717 | ResolveHostResponseHelper v6_v4_response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 718 | HostPortPair("localhost6", 80), NetLogWithSource(), parameters, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 719 | request_context_.get(), host_cache_.get())); |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 720 | EXPECT_THAT(v6_v4_response.result_error(), IsOk()); |
| 721 | EXPECT_THAT(v6_v4_response.request()->GetAddressResults().value().endpoints(), |
| 722 | testing::IsEmpty()); |
| 723 | |
Eric Orth | 192e3bb | 2018-11-14 19:30:32 | [diff] [blame] | 724 | parameters.dns_query_type = DnsQueryType::AAAA; |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 725 | ResolveHostResponseHelper v6_v6_response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 726 | HostPortPair("localhost6", 80), NetLogWithSource(), parameters, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 727 | request_context_.get(), host_cache_.get())); |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 728 | EXPECT_THAT(v6_v6_response.result_error(), IsOk()); |
| 729 | EXPECT_THAT(v6_v6_response.request()->GetAddressResults().value().endpoints(), |
| 730 | testing::ElementsAre(CreateExpected("::1", 80))); |
| 731 | |
| 732 | ResolveHostResponseHelper v6_unsp_response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 733 | HostPortPair("localhost6", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 734 | request_context_.get(), host_cache_.get())); |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 735 | EXPECT_THAT(v6_unsp_response.result_error(), IsOk()); |
| 736 | EXPECT_THAT( |
| 737 | v6_unsp_response.request()->GetAddressResults().value().endpoints(), |
| 738 | testing::ElementsAre(CreateExpected("::1", 80))); |
| 739 | |
Eric Orth | 192e3bb | 2018-11-14 19:30:32 | [diff] [blame] | 740 | parameters.dns_query_type = DnsQueryType::A; |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 741 | ResolveHostResponseHelper v4_v4_response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 742 | HostPortPair("localhost", 80), NetLogWithSource(), parameters, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 743 | request_context_.get(), host_cache_.get())); |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 744 | EXPECT_THAT(v4_v4_response.result_error(), IsOk()); |
| 745 | EXPECT_THAT(v4_v4_response.request()->GetAddressResults().value().endpoints(), |
| 746 | testing::ElementsAre(CreateExpected("127.0.0.1", 80))); |
| 747 | |
Eric Orth | 192e3bb | 2018-11-14 19:30:32 | [diff] [blame] | 748 | parameters.dns_query_type = DnsQueryType::AAAA; |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 749 | ResolveHostResponseHelper v4_v6_response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 750 | HostPortPair("localhost", 80), NetLogWithSource(), parameters, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 751 | request_context_.get(), host_cache_.get())); |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 752 | EXPECT_THAT(v4_v6_response.result_error(), IsOk()); |
| 753 | EXPECT_THAT(v4_v6_response.request()->GetAddressResults().value().endpoints(), |
| 754 | testing::ElementsAre(CreateExpected("::1", 80))); |
| 755 | |
| 756 | ResolveHostResponseHelper v4_unsp_response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 757 | HostPortPair("localhost", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 758 | request_context_.get(), host_cache_.get())); |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 759 | EXPECT_THAT(v4_unsp_response.result_error(), IsOk()); |
| 760 | EXPECT_THAT( |
| 761 | v4_unsp_response.request()->GetAddressResults().value().endpoints(), |
| 762 | testing::UnorderedElementsAre(CreateExpected("127.0.0.1", 80), |
| 763 | CreateExpected("::1", 80))); |
| 764 | } |
| 765 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 766 | TEST_F(HostResolverManagerTest, ResolveIPLiteralWithHostResolverSystemOnly) { |
eroman | 368a100 | 2016-03-04 21:52:55 | [diff] [blame] | 767 | const char kIpLiteral[] = "178.78.32.1"; |
| 768 | // Add a mapping to tell if the resolver proc was called (if it was called, |
| 769 | // then the result will be the remapped value. Otherwise it will be the IP |
| 770 | // literal). |
| 771 | proc_->AddRuleForAllFamilies(kIpLiteral, "183.45.32.1"); |
| 772 | |
Eric Orth | dc35748e | 2018-08-23 22:41:48 | [diff] [blame] | 773 | HostResolver::ResolveHostParameters parameters; |
| 774 | parameters.source = HostResolverSource::SYSTEM; |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 775 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 776 | HostPortPair(kIpLiteral, 80), NetLogWithSource(), parameters, |
| 777 | request_context_.get(), host_cache_.get())); |
Eric Orth | dc35748e | 2018-08-23 22:41:48 | [diff] [blame] | 778 | |
| 779 | // IP literal resolution is expected to take precedence over source, so the |
| 780 | // result is expected to be the input IP, not the result IP from the proc rule |
| 781 | EXPECT_THAT(response.result_error(), IsOk()); |
| 782 | EXPECT_THAT(response.request()->GetAddressResults().value().endpoints(), |
| 783 | testing::ElementsAre(CreateExpected(kIpLiteral, 80))); |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 784 | EXPECT_FALSE(response.request()->GetStaleInfo()); |
Eric Orth | dc35748e | 2018-08-23 22:41:48 | [diff] [blame] | 785 | } |
| 786 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 787 | TEST_F(HostResolverManagerTest, EmptyListMeansNameNotResolved) { |
[email protected] | 49b70b22 | 2013-05-07 21:24:23 | [diff] [blame] | 788 | proc_->AddRuleForAllFamilies("just.testing", ""); |
| 789 | proc_->SignalMultiple(1u); |
| 790 | |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 791 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 792 | HostPortPair("just.testing", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 793 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 794 | |
| 795 | EXPECT_THAT(response.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 796 | EXPECT_FALSE(response.request()->GetAddressResults()); |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 797 | EXPECT_FALSE(response.request()->GetStaleInfo()); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 798 | |
| 799 | EXPECT_EQ("just.testing", proc_->GetCaptureList()[0].hostname); |
| 800 | } |
| 801 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 802 | TEST_F(HostResolverManagerTest, FailedAsynchronousLookup) { |
[email protected] | 007b3f8 | 2013-04-09 08:46:45 | [diff] [blame] | 803 | proc_->AddRuleForAllFamilies(std::string(), |
| 804 | "0.0.0.0"); // Default to failures. |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 805 | proc_->SignalMultiple(1u); |
[email protected] | a33347c | 2012-01-09 18:27:01 | [diff] [blame] | 806 | |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 807 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 808 | HostPortPair("just.testing", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 809 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 810 | EXPECT_THAT(response.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 811 | EXPECT_FALSE(response.request()->GetAddressResults()); |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 812 | EXPECT_FALSE(response.request()->GetStaleInfo()); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 813 | |
| 814 | EXPECT_EQ("just.testing", proc_->GetCaptureList()[0].hostname); |
| 815 | |
| 816 | // Also test that the error is not cached. |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 817 | const std::pair<const HostCache::Key, HostCache::Entry>* cache_result = |
| 818 | GetCacheHit(HostCache::Key("just.testing", DnsQueryType::UNSPECIFIED, |
| 819 | 0 /* host_resolver_flags */, |
| 820 | HostResolverSource::ANY)); |
| 821 | EXPECT_FALSE(cache_result); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 822 | } |
| 823 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 824 | TEST_F(HostResolverManagerTest, AbortedAsynchronousLookup) { |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 825 | ResolveHostResponseHelper response0(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 826 | HostPortPair("just.testing", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 827 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 828 | ASSERT_FALSE(response0.complete()); |
| 829 | ASSERT_TRUE(proc_->WaitFor(1u)); |
| 830 | |
| 831 | // Resolver is destroyed while job is running on WorkerPool. |
Eric Orth | 37b1819 | 2019-04-22 19:09:28 | [diff] [blame] | 832 | DestroyResolver(); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 833 | |
| 834 | proc_->SignalAll(); |
| 835 | |
| 836 | // To ensure there was no spurious callback, complete with a new resolver. |
| 837 | CreateResolver(); |
| 838 | ResolveHostResponseHelper response1(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 839 | HostPortPair("just.testing", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 840 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 841 | |
| 842 | proc_->SignalMultiple(2u); |
| 843 | |
| 844 | EXPECT_THAT(response1.result_error(), IsOk()); |
| 845 | |
| 846 | // This request was canceled. |
| 847 | EXPECT_FALSE(response0.complete()); |
| 848 | } |
| 849 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 850 | TEST_F(HostResolverManagerTest, NumericIPv4Address) { |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 851 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 852 | HostPortPair("127.1.2.3", 5555), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 853 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 854 | |
| 855 | EXPECT_THAT(response.result_error(), IsOk()); |
| 856 | EXPECT_THAT(response.request()->GetAddressResults().value().endpoints(), |
| 857 | testing::ElementsAre(CreateExpected("127.1.2.3", 5555))); |
| 858 | } |
| 859 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 860 | TEST_F(HostResolverManagerTest, NumericIPv6Address) { |
[email protected] | dbcff9627 | 2009-05-07 00:23:44 | [diff] [blame] | 861 | // Resolve a plain IPv6 address. Don't worry about [brackets], because |
| 862 | // the caller should have removed them. |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 863 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 864 | HostPortPair("2001:db8::1", 5555), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 865 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 866 | |
| 867 | EXPECT_THAT(response.result_error(), IsOk()); |
| 868 | EXPECT_THAT(response.request()->GetAddressResults().value().endpoints(), |
| 869 | testing::ElementsAre(CreateExpected("2001:db8::1", 5555))); |
| 870 | } |
| 871 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 872 | TEST_F(HostResolverManagerTest, EmptyHost) { |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 873 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 874 | HostPortPair(std::string(), 5555), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 875 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 876 | |
| 877 | EXPECT_THAT(response.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 878 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 879 | } |
| 880 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 881 | TEST_F(HostResolverManagerTest, EmptyDotsHost) { |
[email protected] | e806cd7 | 2013-05-17 02:08:43 | [diff] [blame] | 882 | for (int i = 0; i < 16; ++i) { |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 883 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 884 | HostPortPair(std::string(i, '.'), 5555), NetLogWithSource(), |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 885 | base::nullopt, request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 886 | |
| 887 | EXPECT_THAT(response.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 888 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 889 | } |
| 890 | } |
| 891 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 892 | TEST_F(HostResolverManagerTest, LongHost) { |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 893 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 894 | HostPortPair(std::string(4097, 'a'), 5555), NetLogWithSource(), |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 895 | base::nullopt, request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 896 | |
| 897 | EXPECT_THAT(response.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 898 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 899 | } |
| 900 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 901 | TEST_F(HostResolverManagerTest, DeDupeRequests) { |
[email protected] | b59ff37 | 2009-07-15 22:04:32 | [diff] [blame] | 902 | // Start 5 requests, duplicating hosts "a" and "b". Since the resolver_proc is |
[email protected] | 8a00f00a | 2009-06-12 00:49:38 | [diff] [blame] | 903 | // blocked, these should all pile up until we signal it. |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 904 | std::vector<std::unique_ptr<ResolveHostResponseHelper>> responses; |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 905 | responses.emplace_back( |
| 906 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 907 | HostPortPair("a", 80), NetLogWithSource(), base::nullopt, |
| 908 | request_context_.get(), host_cache_.get()))); |
| 909 | responses.emplace_back( |
| 910 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 911 | HostPortPair("b", 80), NetLogWithSource(), base::nullopt, |
| 912 | request_context_.get(), host_cache_.get()))); |
| 913 | responses.emplace_back( |
| 914 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 915 | HostPortPair("b", 81), NetLogWithSource(), base::nullopt, |
| 916 | request_context_.get(), host_cache_.get()))); |
| 917 | responses.emplace_back( |
| 918 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 919 | HostPortPair("a", 82), NetLogWithSource(), base::nullopt, |
| 920 | request_context_.get(), host_cache_.get()))); |
| 921 | responses.emplace_back( |
| 922 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 923 | HostPortPair("b", 83), NetLogWithSource(), base::nullopt, |
| 924 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 925 | |
| 926 | for (auto& response : responses) { |
| 927 | ASSERT_FALSE(response->complete()); |
| 928 | } |
| 929 | |
| 930 | proc_->SignalMultiple(2u); // One for "a", one for "b". |
| 931 | |
| 932 | for (auto& response : responses) { |
| 933 | EXPECT_THAT(response->result_error(), IsOk()); |
| 934 | } |
| 935 | } |
| 936 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 937 | TEST_F(HostResolverManagerTest, CancelMultipleRequests) { |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 938 | std::vector<std::unique_ptr<ResolveHostResponseHelper>> responses; |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 939 | responses.emplace_back( |
| 940 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 941 | HostPortPair("a", 80), NetLogWithSource(), base::nullopt, |
| 942 | request_context_.get(), host_cache_.get()))); |
| 943 | responses.emplace_back( |
| 944 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 945 | HostPortPair("b", 80), NetLogWithSource(), base::nullopt, |
| 946 | request_context_.get(), host_cache_.get()))); |
| 947 | responses.emplace_back( |
| 948 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 949 | HostPortPair("b", 81), NetLogWithSource(), base::nullopt, |
| 950 | request_context_.get(), host_cache_.get()))); |
| 951 | responses.emplace_back( |
| 952 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 953 | HostPortPair("a", 82), NetLogWithSource(), base::nullopt, |
| 954 | request_context_.get(), host_cache_.get()))); |
| 955 | responses.emplace_back( |
| 956 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 957 | HostPortPair("b", 83), NetLogWithSource(), base::nullopt, |
| 958 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 959 | |
| 960 | for (auto& response : responses) { |
| 961 | ASSERT_FALSE(response->complete()); |
| 962 | } |
| 963 | |
| 964 | // Cancel everything except request for requests[3] ("a", 82). |
| 965 | responses[0]->CancelRequest(); |
| 966 | responses[1]->CancelRequest(); |
| 967 | responses[2]->CancelRequest(); |
| 968 | responses[4]->CancelRequest(); |
| 969 | |
| 970 | proc_->SignalMultiple(2u); // One for "a", one for "b". |
| 971 | |
| 972 | EXPECT_THAT(responses[3]->result_error(), IsOk()); |
| 973 | |
| 974 | EXPECT_FALSE(responses[0]->complete()); |
| 975 | EXPECT_FALSE(responses[1]->complete()); |
| 976 | EXPECT_FALSE(responses[2]->complete()); |
| 977 | EXPECT_FALSE(responses[4]->complete()); |
| 978 | } |
| 979 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 980 | TEST_F(HostResolverManagerTest, CanceledRequestsReleaseJobSlots) { |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 981 | std::vector<std::unique_ptr<ResolveHostResponseHelper>> responses; |
| 982 | |
| 983 | // Fill up the dispatcher and queue. |
| 984 | for (unsigned i = 0; i < kMaxJobs + 1; ++i) { |
| 985 | std::string hostname = "a_"; |
| 986 | hostname[1] = 'a' + i; |
| 987 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 988 | responses.emplace_back( |
| 989 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 990 | HostPortPair(hostname, 80), NetLogWithSource(), base::nullopt, |
| 991 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 992 | ASSERT_FALSE(responses.back()->complete()); |
| 993 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 994 | responses.emplace_back( |
| 995 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 996 | HostPortPair(hostname, 81), NetLogWithSource(), base::nullopt, |
| 997 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 998 | ASSERT_FALSE(responses.back()->complete()); |
| 999 | } |
| 1000 | |
| 1001 | ASSERT_TRUE(proc_->WaitFor(kMaxJobs)); |
| 1002 | |
| 1003 | // Cancel all but last two. |
| 1004 | for (unsigned i = 0; i < responses.size() - 2; ++i) { |
| 1005 | responses[i]->CancelRequest(); |
| 1006 | } |
| 1007 | |
| 1008 | ASSERT_TRUE(proc_->WaitFor(kMaxJobs + 1)); |
| 1009 | |
| 1010 | proc_->SignalAll(); |
| 1011 | |
| 1012 | size_t num_requests = responses.size(); |
| 1013 | EXPECT_THAT(responses[num_requests - 1]->result_error(), IsOk()); |
| 1014 | EXPECT_THAT(responses[num_requests - 2]->result_error(), IsOk()); |
| 1015 | for (unsigned i = 0; i < num_requests - 2; ++i) { |
| 1016 | EXPECT_FALSE(responses[i]->complete()); |
| 1017 | } |
| 1018 | } |
| 1019 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 1020 | TEST_F(HostResolverManagerTest, CancelWithinCallback) { |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1021 | std::vector<std::unique_ptr<ResolveHostResponseHelper>> responses; |
| 1022 | auto custom_callback = base::BindLambdaForTesting( |
| 1023 | [&](CompletionOnceCallback completion_callback, int error) { |
| 1024 | for (auto& response : responses) { |
| 1025 | // Cancelling request is required to complete first, so that it can |
| 1026 | // attempt to cancel the others. This test assumes all jobs are |
| 1027 | // completed in order. |
| 1028 | DCHECK(!response->complete()); |
| 1029 | |
| 1030 | response->CancelRequest(); |
| 1031 | } |
| 1032 | std::move(completion_callback).Run(error); |
| 1033 | }); |
| 1034 | |
| 1035 | ResolveHostResponseHelper cancelling_response( |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 1036 | resolver_->CreateRequest(HostPortPair("a", 80), NetLogWithSource(), |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1037 | base::nullopt, request_context_.get(), |
| 1038 | host_cache_.get()), |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1039 | std::move(custom_callback)); |
| 1040 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1041 | responses.emplace_back( |
| 1042 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1043 | HostPortPair("a", 81), NetLogWithSource(), base::nullopt, |
| 1044 | request_context_.get(), host_cache_.get()))); |
| 1045 | responses.emplace_back( |
| 1046 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1047 | HostPortPair("a", 82), NetLogWithSource(), base::nullopt, |
| 1048 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1049 | |
| 1050 | proc_->SignalMultiple(2u); // One for "a". One for "finalrequest". |
| 1051 | |
| 1052 | EXPECT_THAT(cancelling_response.result_error(), IsOk()); |
| 1053 | |
| 1054 | ResolveHostResponseHelper final_response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 1055 | HostPortPair("finalrequest", 70), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1056 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1057 | EXPECT_THAT(final_response.result_error(), IsOk()); |
| 1058 | |
| 1059 | for (auto& response : responses) { |
| 1060 | EXPECT_FALSE(response->complete()); |
| 1061 | } |
| 1062 | } |
| 1063 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 1064 | TEST_F(HostResolverManagerTest, DeleteWithinCallback) { |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1065 | std::vector<std::unique_ptr<ResolveHostResponseHelper>> responses; |
| 1066 | auto custom_callback = base::BindLambdaForTesting( |
| 1067 | [&](CompletionOnceCallback completion_callback, int error) { |
| 1068 | for (auto& response : responses) { |
| 1069 | // Deleting request is required to be first, so the other requests |
| 1070 | // will still be running to be deleted. This test assumes that the |
| 1071 | // Jobs will be Aborted in order and the requests in order within the |
| 1072 | // jobs. |
| 1073 | DCHECK(!response->complete()); |
| 1074 | } |
| 1075 | |
Eric Orth | 37b1819 | 2019-04-22 19:09:28 | [diff] [blame] | 1076 | DestroyResolver(); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1077 | std::move(completion_callback).Run(error); |
| 1078 | }); |
| 1079 | |
| 1080 | ResolveHostResponseHelper deleting_response( |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 1081 | resolver_->CreateRequest(HostPortPair("a", 80), NetLogWithSource(), |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1082 | base::nullopt, request_context_.get(), |
| 1083 | host_cache_.get()), |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1084 | std::move(custom_callback)); |
| 1085 | |
| 1086 | // Start additional requests to be cancelled as part of the first's deletion. |
| 1087 | // Assumes all requests for a job are handled in order so that the deleting |
| 1088 | // request will run first and cancel the rest. |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1089 | responses.emplace_back( |
| 1090 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1091 | HostPortPair("a", 81), NetLogWithSource(), base::nullopt, |
| 1092 | request_context_.get(), host_cache_.get()))); |
| 1093 | responses.emplace_back( |
| 1094 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1095 | HostPortPair("a", 82), NetLogWithSource(), base::nullopt, |
| 1096 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1097 | |
| 1098 | proc_->SignalMultiple(3u); |
| 1099 | |
| 1100 | EXPECT_THAT(deleting_response.result_error(), IsOk()); |
| 1101 | |
| 1102 | base::RunLoop().RunUntilIdle(); |
| 1103 | for (auto& response : responses) { |
| 1104 | EXPECT_FALSE(response->complete()); |
| 1105 | } |
| 1106 | } |
| 1107 | |
jdoerrie | dfede5ad | 2019-02-11 13:06:57 | [diff] [blame] | 1108 | // Flaky on Fuchsia and Linux ASAN. crbug.com/930483 |
| 1109 | #if defined(OS_FUCHSIA) || defined(OS_LINUX) |
Eric Orth | 26fa08e | 2019-02-22 01:28:37 | [diff] [blame] | 1110 | #define MAYBE_DeleteWithinAbortedCallback DISABLED_DeleteWithinAbortedCallback |
jdoerrie | dfede5ad | 2019-02-11 13:06:57 | [diff] [blame] | 1111 | #else |
Eric Orth | 26fa08e | 2019-02-22 01:28:37 | [diff] [blame] | 1112 | #define MAYBE_DeleteWithinAbortedCallback DeleteWithinAbortedCallback |
jdoerrie | dfede5ad | 2019-02-11 13:06:57 | [diff] [blame] | 1113 | #endif |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 1114 | TEST_F(HostResolverManagerTest, MAYBE_DeleteWithinAbortedCallback) { |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1115 | std::vector<std::unique_ptr<ResolveHostResponseHelper>> responses; |
| 1116 | ResolveHostResponseHelper::Callback custom_callback = |
| 1117 | base::BindLambdaForTesting( |
| 1118 | [&](CompletionOnceCallback completion_callback, int error) { |
| 1119 | for (auto& response : responses) { |
| 1120 | // Deleting request is required to be first, so the other requests |
| 1121 | // will still be running to be deleted. This test assumes that the |
| 1122 | // Jobs will be Aborted in order and the requests in order within |
| 1123 | // the jobs. |
| 1124 | DCHECK(!response->complete()); |
| 1125 | } |
Eric Orth | 37b1819 | 2019-04-22 19:09:28 | [diff] [blame] | 1126 | DestroyResolver(); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1127 | std::move(completion_callback).Run(error); |
| 1128 | }); |
| 1129 | |
| 1130 | ResolveHostResponseHelper deleting_response( |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 1131 | resolver_->CreateRequest(HostPortPair("a", 80), NetLogWithSource(), |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1132 | base::nullopt, request_context_.get(), |
| 1133 | host_cache_.get()), |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1134 | std::move(custom_callback)); |
| 1135 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1136 | responses.emplace_back( |
| 1137 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1138 | HostPortPair("a", 81), NetLogWithSource(), base::nullopt, |
| 1139 | request_context_.get(), host_cache_.get()))); |
| 1140 | responses.emplace_back( |
| 1141 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1142 | HostPortPair("b", 82), NetLogWithSource(), base::nullopt, |
| 1143 | request_context_.get(), host_cache_.get()))); |
| 1144 | responses.emplace_back( |
| 1145 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1146 | HostPortPair("b", 83), NetLogWithSource(), base::nullopt, |
| 1147 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1148 | |
| 1149 | // Wait for all calls to queue up, trigger abort via IP address change, then |
| 1150 | // signal all the queued requests to let them all try to finish. |
| 1151 | EXPECT_TRUE(proc_->WaitFor(2u)); |
Paul Jensen | f47bbab | 2018-09-14 16:34:04 | [diff] [blame] | 1152 | NetworkChangeNotifier::NotifyObserversOfIPAddressChangeForTests(); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1153 | proc_->SignalAll(); |
| 1154 | |
| 1155 | EXPECT_THAT(deleting_response.result_error(), IsError(ERR_NETWORK_CHANGED)); |
| 1156 | base::RunLoop().RunUntilIdle(); |
| 1157 | for (auto& response : responses) { |
| 1158 | EXPECT_FALSE(response->complete()); |
| 1159 | } |
| 1160 | } |
| 1161 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 1162 | TEST_F(HostResolverManagerTest, StartWithinCallback) { |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1163 | std::unique_ptr<ResolveHostResponseHelper> new_response; |
| 1164 | auto custom_callback = base::BindLambdaForTesting( |
| 1165 | [&](CompletionOnceCallback completion_callback, int error) { |
| 1166 | new_response = std::make_unique<ResolveHostResponseHelper>( |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1167 | resolver_->CreateRequest( |
| 1168 | HostPortPair("new", 70), NetLogWithSource(), base::nullopt, |
| 1169 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1170 | std::move(completion_callback).Run(error); |
| 1171 | }); |
| 1172 | |
| 1173 | ResolveHostResponseHelper starting_response( |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 1174 | resolver_->CreateRequest(HostPortPair("a", 80), NetLogWithSource(), |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1175 | base::nullopt, request_context_.get(), |
| 1176 | host_cache_.get()), |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1177 | std::move(custom_callback)); |
| 1178 | |
| 1179 | proc_->SignalMultiple(2u); // One for "a". One for "new". |
| 1180 | |
| 1181 | EXPECT_THAT(starting_response.result_error(), IsOk()); |
| 1182 | EXPECT_THAT(new_response->result_error(), IsOk()); |
| 1183 | } |
| 1184 | |
Eric Orth | 3bd9e51 | 2019-03-29 15:33:35 | [diff] [blame] | 1185 | TEST_F(HostResolverManagerTest, StartWithinEvictionCallback) { |
| 1186 | CreateSerialResolver(); |
| 1187 | resolver_->SetMaxQueuedJobsForTesting(2); |
| 1188 | |
| 1189 | std::unique_ptr<ResolveHostResponseHelper> new_response; |
| 1190 | auto custom_callback = base::BindLambdaForTesting( |
| 1191 | [&](CompletionOnceCallback completion_callback, int error) { |
| 1192 | new_response = std::make_unique<ResolveHostResponseHelper>( |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1193 | resolver_->CreateRequest( |
| 1194 | HostPortPair("new", 70), NetLogWithSource(), base::nullopt, |
| 1195 | request_context_.get(), host_cache_.get())); |
Eric Orth | 3bd9e51 | 2019-03-29 15:33:35 | [diff] [blame] | 1196 | std::move(completion_callback).Run(error); |
| 1197 | }); |
| 1198 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1199 | ResolveHostResponseHelper initial_response(resolver_->CreateRequest( |
| 1200 | HostPortPair("initial", 80), NetLogWithSource(), base::nullopt, |
| 1201 | request_context_.get(), host_cache_.get())); |
Eric Orth | 3bd9e51 | 2019-03-29 15:33:35 | [diff] [blame] | 1202 | ResolveHostResponseHelper evictee1_response( |
| 1203 | resolver_->CreateRequest(HostPortPair("evictee1", 80), NetLogWithSource(), |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1204 | base::nullopt, request_context_.get(), |
| 1205 | host_cache_.get()), |
Eric Orth | 3bd9e51 | 2019-03-29 15:33:35 | [diff] [blame] | 1206 | std::move(custom_callback)); |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1207 | ResolveHostResponseHelper evictee2_response(resolver_->CreateRequest( |
| 1208 | HostPortPair("evictee2", 80), NetLogWithSource(), base::nullopt, |
| 1209 | request_context_.get(), host_cache_.get())); |
Eric Orth | 3bd9e51 | 2019-03-29 15:33:35 | [diff] [blame] | 1210 | |
| 1211 | // Now one running request ("initial") and two queued requests ("evictee1" and |
| 1212 | // "evictee2"). Any further requests will cause evictions. |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1213 | ResolveHostResponseHelper evictor_response(resolver_->CreateRequest( |
| 1214 | HostPortPair("evictor", 80), NetLogWithSource(), base::nullopt, |
| 1215 | request_context_.get(), host_cache_.get())); |
Eric Orth | 3bd9e51 | 2019-03-29 15:33:35 | [diff] [blame] | 1216 | EXPECT_THAT(evictee1_response.result_error(), |
| 1217 | IsError(ERR_HOST_RESOLVER_QUEUE_TOO_LARGE)); |
| 1218 | |
| 1219 | // "new" should evict "evictee2" |
| 1220 | EXPECT_THAT(evictee2_response.result_error(), |
| 1221 | IsError(ERR_HOST_RESOLVER_QUEUE_TOO_LARGE)); |
| 1222 | |
| 1223 | proc_->SignalMultiple(3u); |
| 1224 | |
| 1225 | EXPECT_THAT(initial_response.result_error(), IsOk()); |
| 1226 | EXPECT_THAT(evictor_response.result_error(), IsOk()); |
| 1227 | EXPECT_THAT(new_response->result_error(), IsOk()); |
| 1228 | } |
| 1229 | |
| 1230 | // Test where we start a new request within an eviction callback that itself |
| 1231 | // evicts the first evictor. |
| 1232 | TEST_F(HostResolverManagerTest, StartWithinEvictionCallback_DoubleEviction) { |
| 1233 | CreateSerialResolver(); |
| 1234 | resolver_->SetMaxQueuedJobsForTesting(1); |
| 1235 | |
| 1236 | std::unique_ptr<ResolveHostResponseHelper> new_response; |
| 1237 | auto custom_callback = base::BindLambdaForTesting( |
| 1238 | [&](CompletionOnceCallback completion_callback, int error) { |
| 1239 | new_response = std::make_unique<ResolveHostResponseHelper>( |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1240 | resolver_->CreateRequest( |
| 1241 | HostPortPair("new", 70), NetLogWithSource(), base::nullopt, |
| 1242 | request_context_.get(), host_cache_.get())); |
Eric Orth | 3bd9e51 | 2019-03-29 15:33:35 | [diff] [blame] | 1243 | std::move(completion_callback).Run(error); |
| 1244 | }); |
| 1245 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1246 | ResolveHostResponseHelper initial_response(resolver_->CreateRequest( |
| 1247 | HostPortPair("initial", 80), NetLogWithSource(), base::nullopt, |
| 1248 | request_context_.get(), host_cache_.get())); |
Eric Orth | 3bd9e51 | 2019-03-29 15:33:35 | [diff] [blame] | 1249 | ResolveHostResponseHelper evictee_response( |
| 1250 | resolver_->CreateRequest(HostPortPair("evictee", 80), NetLogWithSource(), |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1251 | base::nullopt, request_context_.get(), |
| 1252 | host_cache_.get()), |
Eric Orth | 3bd9e51 | 2019-03-29 15:33:35 | [diff] [blame] | 1253 | std::move(custom_callback)); |
| 1254 | |
| 1255 | // Now one running request ("initial") and one queued requests ("evictee"). |
| 1256 | // Any further requests will cause evictions. |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1257 | ResolveHostResponseHelper evictor_response(resolver_->CreateRequest( |
| 1258 | HostPortPair("evictor", 80), NetLogWithSource(), base::nullopt, |
| 1259 | request_context_.get(), host_cache_.get())); |
Eric Orth | 3bd9e51 | 2019-03-29 15:33:35 | [diff] [blame] | 1260 | EXPECT_THAT(evictee_response.result_error(), |
| 1261 | IsError(ERR_HOST_RESOLVER_QUEUE_TOO_LARGE)); |
| 1262 | |
| 1263 | // "new" should evict "evictor" |
| 1264 | EXPECT_THAT(evictor_response.result_error(), |
| 1265 | IsError(ERR_HOST_RESOLVER_QUEUE_TOO_LARGE)); |
| 1266 | |
| 1267 | proc_->SignalMultiple(2u); |
| 1268 | |
| 1269 | EXPECT_THAT(initial_response.result_error(), IsOk()); |
| 1270 | EXPECT_THAT(new_response->result_error(), IsOk()); |
| 1271 | } |
| 1272 | |
| 1273 | TEST_F(HostResolverManagerTest, StartWithinEvictionCallback_SameRequest) { |
| 1274 | CreateSerialResolver(); |
| 1275 | resolver_->SetMaxQueuedJobsForTesting(2); |
| 1276 | |
| 1277 | std::unique_ptr<ResolveHostResponseHelper> new_response; |
| 1278 | auto custom_callback = base::BindLambdaForTesting( |
| 1279 | [&](CompletionOnceCallback completion_callback, int error) { |
| 1280 | new_response = std::make_unique<ResolveHostResponseHelper>( |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1281 | resolver_->CreateRequest( |
| 1282 | HostPortPair("evictor", 70), NetLogWithSource(), base::nullopt, |
| 1283 | request_context_.get(), host_cache_.get())); |
Eric Orth | 3bd9e51 | 2019-03-29 15:33:35 | [diff] [blame] | 1284 | std::move(completion_callback).Run(error); |
| 1285 | }); |
| 1286 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1287 | ResolveHostResponseHelper initial_response(resolver_->CreateRequest( |
| 1288 | HostPortPair("initial", 80), NetLogWithSource(), base::nullopt, |
| 1289 | request_context_.get(), host_cache_.get())); |
Eric Orth | 3bd9e51 | 2019-03-29 15:33:35 | [diff] [blame] | 1290 | ResolveHostResponseHelper evictee_response( |
| 1291 | resolver_->CreateRequest(HostPortPair("evictee", 80), NetLogWithSource(), |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1292 | base::nullopt, request_context_.get(), |
| 1293 | host_cache_.get()), |
Eric Orth | 3bd9e51 | 2019-03-29 15:33:35 | [diff] [blame] | 1294 | std::move(custom_callback)); |
| 1295 | ResolveHostResponseHelper additional_response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 1296 | HostPortPair("additional", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1297 | request_context_.get(), host_cache_.get())); |
Eric Orth | 3bd9e51 | 2019-03-29 15:33:35 | [diff] [blame] | 1298 | |
| 1299 | // Now one running request ("initial") and two queued requests ("evictee" and |
| 1300 | // "additional"). Any further requests will cause evictions. |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1301 | ResolveHostResponseHelper evictor_response(resolver_->CreateRequest( |
| 1302 | HostPortPair("evictor", 80), NetLogWithSource(), base::nullopt, |
| 1303 | request_context_.get(), host_cache_.get())); |
Eric Orth | 3bd9e51 | 2019-03-29 15:33:35 | [diff] [blame] | 1304 | EXPECT_THAT(evictee_response.result_error(), |
| 1305 | IsError(ERR_HOST_RESOLVER_QUEUE_TOO_LARGE)); |
| 1306 | |
| 1307 | // Second "evictor" should be joined with the first and not evict "additional" |
| 1308 | |
| 1309 | // Only 3 proc requests because both "evictor" requests are combined. |
| 1310 | proc_->SignalMultiple(3u); |
| 1311 | |
| 1312 | EXPECT_THAT(initial_response.result_error(), IsOk()); |
| 1313 | EXPECT_THAT(additional_response.result_error(), IsOk()); |
| 1314 | EXPECT_THAT(evictor_response.result_error(), IsOk()); |
| 1315 | EXPECT_THAT(new_response->result_error(), IsOk()); |
| 1316 | } |
| 1317 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 1318 | TEST_F(HostResolverManagerTest, BypassCache) { |
Eric Orth | dc35748e | 2018-08-23 22:41:48 | [diff] [blame] | 1319 | proc_->SignalMultiple(2u); |
| 1320 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1321 | ResolveHostResponseHelper initial_response(resolver_->CreateRequest( |
| 1322 | HostPortPair("a", 80), NetLogWithSource(), base::nullopt, |
| 1323 | request_context_.get(), host_cache_.get())); |
Eric Orth | dc35748e | 2018-08-23 22:41:48 | [diff] [blame] | 1324 | EXPECT_THAT(initial_response.result_error(), IsOk()); |
| 1325 | EXPECT_EQ(1u, proc_->GetCaptureList().size()); |
| 1326 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1327 | ResolveHostResponseHelper cached_response(resolver_->CreateRequest( |
| 1328 | HostPortPair("a", 80), NetLogWithSource(), base::nullopt, |
| 1329 | request_context_.get(), host_cache_.get())); |
Eric Orth | dc35748e | 2018-08-23 22:41:48 | [diff] [blame] | 1330 | EXPECT_THAT(cached_response.result_error(), IsOk()); |
| 1331 | // Expect no increase to calls to |proc_| because result was cached. |
| 1332 | EXPECT_EQ(1u, proc_->GetCaptureList().size()); |
| 1333 | |
| 1334 | HostResolver::ResolveHostParameters parameters; |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 1335 | parameters.cache_usage = |
| 1336 | HostResolver::ResolveHostParameters::CacheUsage::DISALLOWED; |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1337 | ResolveHostResponseHelper cache_bypassed_response(resolver_->CreateRequest( |
| 1338 | HostPortPair("a", 80), NetLogWithSource(), parameters, |
| 1339 | request_context_.get(), host_cache_.get())); |
Eric Orth | dc35748e | 2018-08-23 22:41:48 | [diff] [blame] | 1340 | EXPECT_THAT(cache_bypassed_response.result_error(), IsOk()); |
| 1341 | // Expect call to |proc_| because cache was bypassed. |
| 1342 | EXPECT_EQ(2u, proc_->GetCaptureList().size()); |
| 1343 | } |
| 1344 | |
Paul Jensen | f47bbab | 2018-09-14 16:34:04 | [diff] [blame] | 1345 | // Test that IP address changes flush the cache but initial DNS config reads |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1346 | // do not. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 1347 | TEST_F(HostResolverManagerTest, FlushCacheOnIPAddressChange) { |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1348 | proc_->SignalMultiple(2u); // One before the flush, one after. |
| 1349 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1350 | ResolveHostResponseHelper initial_response(resolver_->CreateRequest( |
| 1351 | HostPortPair("host1", 70), NetLogWithSource(), base::nullopt, |
| 1352 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1353 | EXPECT_THAT(initial_response.result_error(), IsOk()); |
| 1354 | EXPECT_EQ(1u, proc_->GetCaptureList().size()); |
| 1355 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1356 | ResolveHostResponseHelper cached_response(resolver_->CreateRequest( |
| 1357 | HostPortPair("host1", 75), NetLogWithSource(), base::nullopt, |
| 1358 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1359 | EXPECT_THAT(cached_response.result_error(), IsOk()); |
| 1360 | EXPECT_EQ(1u, proc_->GetCaptureList().size()); // No expected increase. |
| 1361 | |
| 1362 | // Verify initial DNS config read does not flush cache. |
| 1363 | NetworkChangeNotifier::NotifyObserversOfInitialDNSConfigReadForTests(); |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1364 | ResolveHostResponseHelper unflushed_response(resolver_->CreateRequest( |
| 1365 | HostPortPair("host1", 75), NetLogWithSource(), base::nullopt, |
| 1366 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1367 | EXPECT_THAT(unflushed_response.result_error(), IsOk()); |
| 1368 | EXPECT_EQ(1u, proc_->GetCaptureList().size()); // No expected increase. |
| 1369 | |
Paul Jensen | f47bbab | 2018-09-14 16:34:04 | [diff] [blame] | 1370 | // Flush cache by triggering an IP address change. |
| 1371 | NetworkChangeNotifier::NotifyObserversOfIPAddressChangeForTests(); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1372 | base::RunLoop().RunUntilIdle(); // Notification happens async. |
| 1373 | |
| 1374 | // Resolve "host1" again -- this time it won't be served from cache, so it |
| 1375 | // will complete asynchronously. |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1376 | ResolveHostResponseHelper flushed_response(resolver_->CreateRequest( |
| 1377 | HostPortPair("host1", 80), NetLogWithSource(), base::nullopt, |
| 1378 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1379 | EXPECT_THAT(flushed_response.result_error(), IsOk()); |
| 1380 | EXPECT_EQ(2u, proc_->GetCaptureList().size()); // Expected increase. |
| 1381 | } |
| 1382 | |
Eric Orth | 37b1819 | 2019-04-22 19:09:28 | [diff] [blame] | 1383 | TEST_F(HostResolverManagerTest, FlushCacheOnDnsConfigChange) { |
| 1384 | proc_->SignalMultiple(2u); // One before the flush, one after. |
| 1385 | |
| 1386 | // Resolve to load cache. |
| 1387 | ResolveHostResponseHelper initial_response(resolver_->CreateRequest( |
| 1388 | HostPortPair("host1", 70), NetLogWithSource(), base::nullopt, |
| 1389 | request_context_.get(), host_cache_.get())); |
| 1390 | EXPECT_THAT(initial_response.result_error(), IsOk()); |
| 1391 | EXPECT_EQ(1u, proc_->GetCaptureList().size()); |
| 1392 | |
| 1393 | // Result expected to come from the cache. |
| 1394 | ResolveHostResponseHelper cached_response(resolver_->CreateRequest( |
| 1395 | HostPortPair("host1", 75), NetLogWithSource(), base::nullopt, |
| 1396 | request_context_.get(), host_cache_.get())); |
| 1397 | EXPECT_THAT(cached_response.result_error(), IsOk()); |
| 1398 | EXPECT_EQ(1u, proc_->GetCaptureList().size()); // No expected increase. |
| 1399 | |
| 1400 | // Flush cache by triggering a DNS config change. |
| 1401 | NetworkChangeNotifier::NotifyObserversOfDNSChangeForTests(); |
| 1402 | base::RunLoop().RunUntilIdle(); // Notification happens async. |
| 1403 | |
| 1404 | // Expect flushed from cache and therefore served from |proc_|. |
| 1405 | ResolveHostResponseHelper flushed_response(resolver_->CreateRequest( |
| 1406 | HostPortPair("host1", 80), NetLogWithSource(), base::nullopt, |
| 1407 | request_context_.get(), host_cache_.get())); |
| 1408 | EXPECT_THAT(flushed_response.result_error(), IsOk()); |
| 1409 | EXPECT_EQ(2u, proc_->GetCaptureList().size()); // Expected increase. |
| 1410 | } |
| 1411 | |
Paul Jensen | f47bbab | 2018-09-14 16:34:04 | [diff] [blame] | 1412 | // Test that IP address changes send ERR_NETWORK_CHANGED to pending requests. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 1413 | TEST_F(HostResolverManagerTest, AbortOnIPAddressChanged) { |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1414 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 1415 | HostPortPair("host1", 70), NetLogWithSource(), base::nullopt, |
| 1416 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1417 | |
| 1418 | ASSERT_FALSE(response.complete()); |
| 1419 | ASSERT_TRUE(proc_->WaitFor(1u)); |
| 1420 | |
Paul Jensen | f47bbab | 2018-09-14 16:34:04 | [diff] [blame] | 1421 | // Triggering an IP address change. |
| 1422 | NetworkChangeNotifier::NotifyObserversOfIPAddressChangeForTests(); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1423 | base::RunLoop().RunUntilIdle(); // Notification happens async. |
| 1424 | proc_->SignalAll(); |
| 1425 | |
| 1426 | EXPECT_THAT(response.result_error(), IsError(ERR_NETWORK_CHANGED)); |
| 1427 | EXPECT_FALSE(response.request()->GetAddressResults()); |
Eric Orth | 37b1819 | 2019-04-22 19:09:28 | [diff] [blame] | 1428 | EXPECT_EQ(0u, host_cache_->size()); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1429 | } |
| 1430 | |
pauljensen | 101ed37 | 2015-04-17 00:11:42 | [diff] [blame] | 1431 | // Test that initial DNS config read signals do not abort pending requests. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 1432 | TEST_F(HostResolverManagerTest, DontAbortOnInitialDNSConfigRead) { |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1433 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 1434 | HostPortPair("host1", 70), NetLogWithSource(), base::nullopt, |
| 1435 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1436 | |
| 1437 | ASSERT_FALSE(response.complete()); |
| 1438 | ASSERT_TRUE(proc_->WaitFor(1u)); |
| 1439 | |
| 1440 | // Triggering initial DNS config read signal. |
| 1441 | NetworkChangeNotifier::NotifyObserversOfInitialDNSConfigReadForTests(); |
| 1442 | base::RunLoop().RunUntilIdle(); // Notification happens async. |
| 1443 | proc_->SignalAll(); |
| 1444 | |
| 1445 | EXPECT_THAT(response.result_error(), IsOk()); |
| 1446 | EXPECT_TRUE(response.request()->GetAddressResults()); |
| 1447 | } |
| 1448 | |
Paul Jensen | f47bbab | 2018-09-14 16:34:04 | [diff] [blame] | 1449 | // Obey pool constraints after IP address has changed. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 1450 | TEST_F(HostResolverManagerTest, ObeyPoolConstraintsAfterIPAddressChange) { |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 1451 | // Runs at most one job at a time. |
| 1452 | CreateSerialResolver(); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1453 | |
| 1454 | std::vector<std::unique_ptr<ResolveHostResponseHelper>> responses; |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1455 | responses.emplace_back( |
| 1456 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1457 | HostPortPair("a", 80), NetLogWithSource(), base::nullopt, |
| 1458 | request_context_.get(), host_cache_.get()))); |
| 1459 | responses.emplace_back( |
| 1460 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1461 | HostPortPair("b", 80), NetLogWithSource(), base::nullopt, |
| 1462 | request_context_.get(), host_cache_.get()))); |
| 1463 | responses.emplace_back( |
| 1464 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1465 | HostPortPair("c", 80), NetLogWithSource(), base::nullopt, |
| 1466 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1467 | |
| 1468 | for (auto& response : responses) { |
| 1469 | ASSERT_FALSE(response->complete()); |
| 1470 | } |
| 1471 | ASSERT_TRUE(proc_->WaitFor(1u)); |
| 1472 | |
Paul Jensen | f47bbab | 2018-09-14 16:34:04 | [diff] [blame] | 1473 | // Triggering an IP address change. |
| 1474 | NetworkChangeNotifier::NotifyObserversOfIPAddressChangeForTests(); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1475 | base::RunLoop().RunUntilIdle(); // Notification happens async. |
| 1476 | proc_->SignalMultiple(3u); // Let the false-start go so that we can catch it. |
| 1477 | |
| 1478 | // Requests should complete one at a time, with the first failing. |
| 1479 | EXPECT_THAT(responses[0]->result_error(), IsError(ERR_NETWORK_CHANGED)); |
| 1480 | EXPECT_EQ(1u, num_running_dispatcher_jobs()); |
| 1481 | EXPECT_FALSE(responses[1]->complete()); |
| 1482 | EXPECT_FALSE(responses[2]->complete()); |
| 1483 | |
| 1484 | EXPECT_THAT(responses[1]->result_error(), IsOk()); |
| 1485 | EXPECT_EQ(1u, num_running_dispatcher_jobs()); |
| 1486 | EXPECT_FALSE(responses[2]->complete()); |
| 1487 | |
| 1488 | EXPECT_THAT(responses[2]->result_error(), IsOk()); |
| 1489 | } |
| 1490 | |
[email protected] | b3601bc2 | 2012-02-21 21:23:20 | [diff] [blame] | 1491 | // Tests that a new Request made from the callback of a previously aborted one |
| 1492 | // will not be aborted. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 1493 | TEST_F(HostResolverManagerTest, AbortOnlyExistingRequestsOnIPAddressChange) { |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1494 | auto custom_callback_template = base::BindLambdaForTesting( |
| 1495 | [&](const HostPortPair& next_host, |
| 1496 | std::unique_ptr<ResolveHostResponseHelper>* next_response, |
| 1497 | CompletionOnceCallback completion_callback, int error) { |
| 1498 | *next_response = std::make_unique<ResolveHostResponseHelper>( |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 1499 | resolver_->CreateRequest(next_host, NetLogWithSource(), |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1500 | base::nullopt, request_context_.get(), |
| 1501 | host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1502 | std::move(completion_callback).Run(error); |
| 1503 | }); |
| 1504 | |
| 1505 | std::vector<std::unique_ptr<ResolveHostResponseHelper>> next_responses(3); |
| 1506 | |
| 1507 | ResolveHostResponseHelper response0( |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 1508 | resolver_->CreateRequest(HostPortPair("bbb", 80), NetLogWithSource(), |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1509 | base::nullopt, request_context_.get(), |
| 1510 | host_cache_.get()), |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1511 | base::BindOnce(custom_callback_template, HostPortPair("zzz", 80), |
| 1512 | &next_responses[0])); |
| 1513 | |
| 1514 | ResolveHostResponseHelper response1( |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 1515 | resolver_->CreateRequest(HostPortPair("eee", 80), NetLogWithSource(), |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1516 | base::nullopt, request_context_.get(), |
| 1517 | host_cache_.get()), |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1518 | base::BindOnce(custom_callback_template, HostPortPair("aaa", 80), |
| 1519 | &next_responses[1])); |
| 1520 | |
| 1521 | ResolveHostResponseHelper response2( |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 1522 | resolver_->CreateRequest(HostPortPair("ccc", 80), NetLogWithSource(), |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1523 | base::nullopt, request_context_.get(), |
| 1524 | host_cache_.get()), |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1525 | base::BindOnce(custom_callback_template, HostPortPair("eee", 80), |
| 1526 | &next_responses[2])); |
| 1527 | |
| 1528 | // Wait until all are blocked; |
| 1529 | ASSERT_TRUE(proc_->WaitFor(3u)); |
Paul Jensen | f47bbab | 2018-09-14 16:34:04 | [diff] [blame] | 1530 | // Trigger an IP address change. |
| 1531 | NetworkChangeNotifier::NotifyObserversOfIPAddressChangeForTests(); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1532 | // This should abort all running jobs. |
| 1533 | base::RunLoop().RunUntilIdle(); |
| 1534 | |
| 1535 | EXPECT_THAT(response0.result_error(), IsError(ERR_NETWORK_CHANGED)); |
| 1536 | EXPECT_THAT(response1.result_error(), IsError(ERR_NETWORK_CHANGED)); |
| 1537 | EXPECT_THAT(response2.result_error(), IsError(ERR_NETWORK_CHANGED)); |
| 1538 | |
| 1539 | EXPECT_FALSE(next_responses[0]->complete()); |
| 1540 | EXPECT_FALSE(next_responses[1]->complete()); |
| 1541 | EXPECT_FALSE(next_responses[2]->complete()); |
| 1542 | |
| 1543 | // Unblock all calls to proc. |
| 1544 | proc_->SignalMultiple(6u); |
| 1545 | |
| 1546 | // Run until the re-started requests finish. |
| 1547 | EXPECT_THAT(next_responses[0]->result_error(), IsOk()); |
| 1548 | EXPECT_THAT(next_responses[1]->result_error(), IsOk()); |
| 1549 | EXPECT_THAT(next_responses[2]->result_error(), IsOk()); |
| 1550 | |
| 1551 | // Verify that results of aborted Jobs were not cached. |
| 1552 | EXPECT_EQ(6u, proc_->GetCaptureList().size()); |
Eric Orth | 37b1819 | 2019-04-22 19:09:28 | [diff] [blame] | 1553 | EXPECT_EQ(3u, host_cache_->size()); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1554 | } |
| 1555 | |
[email protected] | 68ad3ee | 2010-01-30 03:45:39 | [diff] [blame] | 1556 | // Tests that when the maximum threads is set to 1, requests are dequeued |
| 1557 | // in order of priority. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 1558 | TEST_F(HostResolverManagerTest, HigherPriorityRequestsStartedFirst) { |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 1559 | CreateSerialResolver(); |
[email protected] | 68ad3ee | 2010-01-30 03:45:39 | [diff] [blame] | 1560 | |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 1561 | HostResolver::ResolveHostParameters low_priority; |
| 1562 | low_priority.initial_priority = LOW; |
| 1563 | HostResolver::ResolveHostParameters medium_priority; |
| 1564 | medium_priority.initial_priority = MEDIUM; |
| 1565 | HostResolver::ResolveHostParameters highest_priority; |
| 1566 | highest_priority.initial_priority = HIGHEST; |
| 1567 | |
| 1568 | // Note that at this point the MockHostResolverProc is blocked, so any |
| 1569 | // requests we make will not complete. |
| 1570 | |
| 1571 | std::vector<std::unique_ptr<ResolveHostResponseHelper>> responses; |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1572 | responses.emplace_back( |
| 1573 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1574 | HostPortPair("req0", 80), NetLogWithSource(), low_priority, |
| 1575 | request_context_.get(), host_cache_.get()))); |
| 1576 | responses.emplace_back( |
| 1577 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1578 | HostPortPair("req1", 80), NetLogWithSource(), medium_priority, |
| 1579 | request_context_.get(), host_cache_.get()))); |
| 1580 | responses.emplace_back( |
| 1581 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1582 | HostPortPair("req2", 80), NetLogWithSource(), medium_priority, |
| 1583 | request_context_.get(), host_cache_.get()))); |
| 1584 | responses.emplace_back( |
| 1585 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1586 | HostPortPair("req3", 80), NetLogWithSource(), low_priority, |
| 1587 | request_context_.get(), host_cache_.get()))); |
| 1588 | responses.emplace_back( |
| 1589 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1590 | HostPortPair("req4", 80), NetLogWithSource(), highest_priority, |
| 1591 | request_context_.get(), host_cache_.get()))); |
| 1592 | responses.emplace_back( |
| 1593 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1594 | HostPortPair("req5", 80), NetLogWithSource(), low_priority, |
| 1595 | request_context_.get(), host_cache_.get()))); |
| 1596 | responses.emplace_back( |
| 1597 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1598 | HostPortPair("req6", 80), NetLogWithSource(), low_priority, |
| 1599 | request_context_.get(), host_cache_.get()))); |
| 1600 | responses.emplace_back( |
| 1601 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1602 | HostPortPair("req5", 80), NetLogWithSource(), highest_priority, |
| 1603 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 1604 | |
| 1605 | for (const auto& response : responses) { |
| 1606 | ASSERT_FALSE(response->complete()); |
| 1607 | } |
| 1608 | |
| 1609 | // Unblock the resolver thread so the requests can run. |
| 1610 | proc_->SignalMultiple(responses.size()); // More than needed. |
| 1611 | |
| 1612 | // Wait for all the requests to complete successfully. |
| 1613 | for (auto& response : responses) { |
| 1614 | EXPECT_THAT(response->result_error(), IsOk()); |
| 1615 | } |
| 1616 | |
| 1617 | // Since we have restricted to a single concurrent thread in the jobpool, |
| 1618 | // the requests should complete in order of priority (with the exception |
| 1619 | // of the first request, which gets started right away, since there is |
| 1620 | // nothing outstanding). |
| 1621 | MockHostResolverProc::CaptureList capture_list = proc_->GetCaptureList(); |
| 1622 | ASSERT_EQ(7u, capture_list.size()); |
| 1623 | |
| 1624 | EXPECT_EQ("req0", capture_list[0].hostname); |
| 1625 | EXPECT_EQ("req4", capture_list[1].hostname); |
| 1626 | EXPECT_EQ("req5", capture_list[2].hostname); |
| 1627 | EXPECT_EQ("req1", capture_list[3].hostname); |
| 1628 | EXPECT_EQ("req2", capture_list[4].hostname); |
| 1629 | EXPECT_EQ("req3", capture_list[5].hostname); |
| 1630 | EXPECT_EQ("req6", capture_list[6].hostname); |
| 1631 | } |
| 1632 | |
juliatuttle | c53b19a7 | 2016-05-05 13:51:31 | [diff] [blame] | 1633 | // Test that changing a job's priority affects the dequeueing order. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 1634 | TEST_F(HostResolverManagerTest, ChangePriority) { |
juliatuttle | c53b19a7 | 2016-05-05 13:51:31 | [diff] [blame] | 1635 | CreateSerialResolver(); |
| 1636 | |
Eric Orth | 26fa08e | 2019-02-22 01:28:37 | [diff] [blame] | 1637 | HostResolver::ResolveHostParameters lowest_priority; |
| 1638 | lowest_priority.initial_priority = LOWEST; |
| 1639 | HostResolver::ResolveHostParameters low_priority; |
| 1640 | low_priority.initial_priority = LOW; |
| 1641 | HostResolver::ResolveHostParameters medium_priority; |
| 1642 | medium_priority.initial_priority = MEDIUM; |
juliatuttle | c53b19a7 | 2016-05-05 13:51:31 | [diff] [blame] | 1643 | |
Eric Orth | 26fa08e | 2019-02-22 01:28:37 | [diff] [blame] | 1644 | std::vector<std::unique_ptr<ResolveHostResponseHelper>> responses; |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1645 | responses.emplace_back( |
| 1646 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1647 | HostPortPair("req0", 80), NetLogWithSource(), medium_priority, |
| 1648 | request_context_.get(), host_cache_.get()))); |
| 1649 | responses.emplace_back( |
| 1650 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1651 | HostPortPair("req1", 80), NetLogWithSource(), low_priority, |
| 1652 | request_context_.get(), host_cache_.get()))); |
| 1653 | responses.emplace_back( |
| 1654 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1655 | HostPortPair("req2", 80), NetLogWithSource(), lowest_priority, |
| 1656 | request_context_.get(), host_cache_.get()))); |
juliatuttle | c53b19a7 | 2016-05-05 13:51:31 | [diff] [blame] | 1657 | |
| 1658 | // req0 starts immediately; without ChangePriority, req1 and then req2 should |
| 1659 | // run. |
Eric Orth | 26fa08e | 2019-02-22 01:28:37 | [diff] [blame] | 1660 | for (const auto& response : responses) { |
| 1661 | ASSERT_FALSE(response->complete()); |
| 1662 | } |
juliatuttle | c53b19a7 | 2016-05-05 13:51:31 | [diff] [blame] | 1663 | |
Eric Orth | 26fa08e | 2019-02-22 01:28:37 | [diff] [blame] | 1664 | // Changing req2 to HIGHEST should make it run before req1. |
juliatuttle | c53b19a7 | 2016-05-05 13:51:31 | [diff] [blame] | 1665 | // (It can't run before req0, since req0 started immediately.) |
Eric Orth | 26fa08e | 2019-02-22 01:28:37 | [diff] [blame] | 1666 | responses[2]->request()->ChangeRequestPriority(HIGHEST); |
juliatuttle | c53b19a7 | 2016-05-05 13:51:31 | [diff] [blame] | 1667 | |
| 1668 | // Let all 3 requests finish. |
| 1669 | proc_->SignalMultiple(3u); |
| 1670 | |
Eric Orth | 26fa08e | 2019-02-22 01:28:37 | [diff] [blame] | 1671 | for (auto& response : responses) { |
| 1672 | EXPECT_THAT(response->result_error(), IsOk()); |
| 1673 | } |
juliatuttle | c53b19a7 | 2016-05-05 13:51:31 | [diff] [blame] | 1674 | |
| 1675 | MockHostResolverProc::CaptureList capture_list = proc_->GetCaptureList(); |
| 1676 | ASSERT_EQ(3u, capture_list.size()); |
| 1677 | |
| 1678 | EXPECT_EQ("req0", capture_list[0].hostname); |
| 1679 | EXPECT_EQ("req2", capture_list[1].hostname); |
| 1680 | EXPECT_EQ("req1", capture_list[2].hostname); |
| 1681 | } |
| 1682 | |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 1683 | // Try cancelling a job which has not started yet. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 1684 | TEST_F(HostResolverManagerTest, CancelPendingRequest) { |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 1685 | CreateSerialResolver(); |
[email protected] | 68ad3ee | 2010-01-30 03:45:39 | [diff] [blame] | 1686 | |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 1687 | HostResolver::ResolveHostParameters lowest_priority; |
| 1688 | lowest_priority.initial_priority = LOWEST; |
| 1689 | HostResolver::ResolveHostParameters low_priority; |
| 1690 | low_priority.initial_priority = LOW; |
| 1691 | HostResolver::ResolveHostParameters medium_priority; |
| 1692 | medium_priority.initial_priority = MEDIUM; |
| 1693 | HostResolver::ResolveHostParameters highest_priority; |
| 1694 | highest_priority.initial_priority = HIGHEST; |
| 1695 | |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1696 | std::vector<std::unique_ptr<ResolveHostResponseHelper>> responses; |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1697 | responses.emplace_back( |
| 1698 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1699 | HostPortPair("req0", 80), NetLogWithSource(), lowest_priority, |
| 1700 | request_context_.get(), host_cache_.get()))); |
| 1701 | responses.emplace_back( |
| 1702 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1703 | HostPortPair("req1", 80), NetLogWithSource(), highest_priority, |
| 1704 | request_context_.get(), host_cache_.get()))); |
| 1705 | responses.emplace_back( |
| 1706 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1707 | HostPortPair("req2", 80), NetLogWithSource(), medium_priority, |
| 1708 | request_context_.get(), host_cache_.get()))); |
| 1709 | responses.emplace_back( |
| 1710 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1711 | HostPortPair("req3", 80), NetLogWithSource(), low_priority, |
| 1712 | request_context_.get(), host_cache_.get()))); |
| 1713 | responses.emplace_back( |
| 1714 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1715 | HostPortPair("req4", 80), NetLogWithSource(), highest_priority, |
| 1716 | request_context_.get(), host_cache_.get()))); |
| 1717 | responses.emplace_back( |
| 1718 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1719 | HostPortPair("req5", 80), NetLogWithSource(), lowest_priority, |
| 1720 | request_context_.get(), host_cache_.get()))); |
| 1721 | responses.emplace_back( |
| 1722 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1723 | HostPortPair("req6", 80), NetLogWithSource(), medium_priority, |
| 1724 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1725 | |
| 1726 | // Cancel some requests |
| 1727 | responses[1]->CancelRequest(); |
| 1728 | responses[4]->CancelRequest(); |
| 1729 | responses[5]->CancelRequest(); |
| 1730 | |
| 1731 | // Unblock the resolver thread so the requests can run. |
| 1732 | proc_->SignalMultiple(responses.size()); // More than needed. |
| 1733 | |
| 1734 | // Let everything try to finish. |
| 1735 | base::RunLoop().RunUntilIdle(); |
| 1736 | |
| 1737 | // Wait for all the requests to complete succesfully. |
| 1738 | EXPECT_THAT(responses[0]->result_error(), IsOk()); |
| 1739 | EXPECT_THAT(responses[2]->result_error(), IsOk()); |
| 1740 | EXPECT_THAT(responses[3]->result_error(), IsOk()); |
| 1741 | EXPECT_THAT(responses[6]->result_error(), IsOk()); |
| 1742 | |
| 1743 | // Cancelled requests shouldn't complete. |
| 1744 | EXPECT_FALSE(responses[1]->complete()); |
| 1745 | EXPECT_FALSE(responses[4]->complete()); |
| 1746 | EXPECT_FALSE(responses[5]->complete()); |
| 1747 | |
| 1748 | // Verify that they called out the the resolver proc (which runs on the |
| 1749 | // resolver thread) in the expected order. |
| 1750 | MockHostResolverProc::CaptureList capture_list = proc_->GetCaptureList(); |
| 1751 | ASSERT_EQ(4u, capture_list.size()); |
| 1752 | |
| 1753 | EXPECT_EQ("req0", capture_list[0].hostname); |
| 1754 | EXPECT_EQ("req2", capture_list[1].hostname); |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 1755 | EXPECT_EQ("req6", capture_list[2].hostname); |
| 1756 | EXPECT_EQ("req3", capture_list[3].hostname); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1757 | } |
| 1758 | |
[email protected] | 68ad3ee | 2010-01-30 03:45:39 | [diff] [blame] | 1759 | // Test that when too many requests are enqueued, old ones start to be aborted. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 1760 | TEST_F(HostResolverManagerTest, QueueOverflow) { |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 1761 | CreateSerialResolver(); |
[email protected] | 68ad3ee | 2010-01-30 03:45:39 | [diff] [blame] | 1762 | |
[email protected] | 0f292de0 | 2012-02-01 22:28:20 | [diff] [blame] | 1763 | // Allow only 3 queued jobs. |
| 1764 | const size_t kMaxPendingJobs = 3u; |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1765 | resolver_->SetMaxQueuedJobsForTesting(kMaxPendingJobs); |
[email protected] | 68ad3ee | 2010-01-30 03:45:39 | [diff] [blame] | 1766 | |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 1767 | HostResolver::ResolveHostParameters lowest_priority; |
| 1768 | lowest_priority.initial_priority = LOWEST; |
| 1769 | HostResolver::ResolveHostParameters low_priority; |
| 1770 | low_priority.initial_priority = LOW; |
| 1771 | HostResolver::ResolveHostParameters medium_priority; |
| 1772 | medium_priority.initial_priority = MEDIUM; |
| 1773 | HostResolver::ResolveHostParameters highest_priority; |
| 1774 | highest_priority.initial_priority = HIGHEST; |
| 1775 | |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1776 | // Note that at this point the MockHostResolverProc is blocked, so any |
| 1777 | // requests we make will not complete. |
| 1778 | |
| 1779 | std::vector<std::unique_ptr<ResolveHostResponseHelper>> responses; |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1780 | responses.emplace_back( |
| 1781 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1782 | HostPortPair("req0", 80), NetLogWithSource(), lowest_priority, |
| 1783 | request_context_.get(), host_cache_.get()))); |
| 1784 | responses.emplace_back( |
| 1785 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1786 | HostPortPair("req1", 80), NetLogWithSource(), highest_priority, |
| 1787 | request_context_.get(), host_cache_.get()))); |
| 1788 | responses.emplace_back( |
| 1789 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1790 | HostPortPair("req2", 80), NetLogWithSource(), medium_priority, |
| 1791 | request_context_.get(), host_cache_.get()))); |
| 1792 | responses.emplace_back( |
| 1793 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1794 | HostPortPair("req3", 80), NetLogWithSource(), medium_priority, |
| 1795 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1796 | |
| 1797 | // At this point, there are 3 enqueued jobs (and one "running" job). |
| 1798 | // Insertion of subsequent requests will cause evictions. |
| 1799 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1800 | responses.emplace_back( |
| 1801 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1802 | HostPortPair("req4", 80), NetLogWithSource(), low_priority, |
| 1803 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 1804 | EXPECT_THAT(responses[4]->result_error(), |
| 1805 | IsError(ERR_HOST_RESOLVER_QUEUE_TOO_LARGE)); // Evicts self. |
| 1806 | EXPECT_FALSE(responses[4]->request()->GetAddressResults()); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1807 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1808 | responses.emplace_back( |
| 1809 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1810 | HostPortPair("req5", 80), NetLogWithSource(), medium_priority, |
| 1811 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1812 | EXPECT_THAT(responses[2]->result_error(), |
| 1813 | IsError(ERR_HOST_RESOLVER_QUEUE_TOO_LARGE)); |
| 1814 | EXPECT_FALSE(responses[2]->request()->GetAddressResults()); |
| 1815 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1816 | responses.emplace_back( |
| 1817 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1818 | HostPortPair("req6", 80), NetLogWithSource(), highest_priority, |
| 1819 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1820 | EXPECT_THAT(responses[3]->result_error(), |
| 1821 | IsError(ERR_HOST_RESOLVER_QUEUE_TOO_LARGE)); |
| 1822 | EXPECT_FALSE(responses[3]->request()->GetAddressResults()); |
| 1823 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1824 | responses.emplace_back( |
| 1825 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1826 | HostPortPair("req7", 80), NetLogWithSource(), medium_priority, |
| 1827 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 1828 | EXPECT_THAT(responses[5]->result_error(), |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1829 | IsError(ERR_HOST_RESOLVER_QUEUE_TOO_LARGE)); |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 1830 | EXPECT_FALSE(responses[5]->request()->GetAddressResults()); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1831 | |
| 1832 | // Unblock the resolver thread so the requests can run. |
| 1833 | proc_->SignalMultiple(4u); |
| 1834 | |
| 1835 | // The rest should succeed. |
| 1836 | EXPECT_THAT(responses[0]->result_error(), IsOk()); |
| 1837 | EXPECT_TRUE(responses[0]->request()->GetAddressResults()); |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 1838 | EXPECT_THAT(responses[1]->result_error(), IsOk()); |
| 1839 | EXPECT_TRUE(responses[1]->request()->GetAddressResults()); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1840 | EXPECT_THAT(responses[6]->result_error(), IsOk()); |
| 1841 | EXPECT_TRUE(responses[6]->request()->GetAddressResults()); |
| 1842 | EXPECT_THAT(responses[7]->result_error(), IsOk()); |
| 1843 | EXPECT_TRUE(responses[7]->request()->GetAddressResults()); |
| 1844 | |
| 1845 | // Verify that they called out the the resolver proc (which runs on the |
| 1846 | // resolver thread) in the expected order. |
| 1847 | MockHostResolverProc::CaptureList capture_list = proc_->GetCaptureList(); |
| 1848 | ASSERT_EQ(4u, capture_list.size()); |
| 1849 | |
| 1850 | EXPECT_EQ("req0", capture_list[0].hostname); |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 1851 | EXPECT_EQ("req1", capture_list[1].hostname); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1852 | EXPECT_EQ("req6", capture_list[2].hostname); |
| 1853 | EXPECT_EQ("req7", capture_list[3].hostname); |
| 1854 | |
| 1855 | // Verify that the evicted (incomplete) requests were not cached. |
Eric Orth | 37b1819 | 2019-04-22 19:09:28 | [diff] [blame] | 1856 | EXPECT_EQ(4u, host_cache_->size()); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1857 | |
| 1858 | for (size_t i = 0; i < responses.size(); ++i) { |
| 1859 | EXPECT_TRUE(responses[i]->complete()) << i; |
| 1860 | } |
| 1861 | } |
| 1862 | |
| 1863 | // Tests that jobs can self-evict by setting the max queue to 0. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 1864 | TEST_F(HostResolverManagerTest, QueueOverflow_SelfEvict) { |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1865 | CreateSerialResolver(); |
| 1866 | resolver_->SetMaxQueuedJobsForTesting(0); |
| 1867 | |
| 1868 | // Note that at this point the MockHostResolverProc is blocked, so any |
| 1869 | // requests we make will not complete. |
| 1870 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1871 | ResolveHostResponseHelper run_response(resolver_->CreateRequest( |
| 1872 | HostPortPair("run", 80), NetLogWithSource(), base::nullopt, |
| 1873 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1874 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1875 | ResolveHostResponseHelper evict_response(resolver_->CreateRequest( |
| 1876 | HostPortPair("req1", 80), NetLogWithSource(), base::nullopt, |
| 1877 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1878 | EXPECT_THAT(evict_response.result_error(), |
| 1879 | IsError(ERR_HOST_RESOLVER_QUEUE_TOO_LARGE)); |
| 1880 | EXPECT_FALSE(evict_response.request()->GetAddressResults()); |
| 1881 | |
| 1882 | proc_->SignalMultiple(1u); |
| 1883 | |
| 1884 | EXPECT_THAT(run_response.result_error(), IsOk()); |
| 1885 | EXPECT_TRUE(run_response.request()->GetAddressResults()); |
| 1886 | } |
| 1887 | |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 1888 | // Make sure that the dns query type parameter is respected when raw IPs are |
| 1889 | // passed in. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 1890 | TEST_F(HostResolverManagerTest, AddressFamilyWithRawIPs) { |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 1891 | HostResolver::ResolveHostParameters v4_parameters; |
Eric Orth | 192e3bb | 2018-11-14 19:30:32 | [diff] [blame] | 1892 | v4_parameters.dns_query_type = DnsQueryType::A; |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 1893 | |
| 1894 | HostResolver::ResolveHostParameters v6_parameters; |
Eric Orth | 192e3bb | 2018-11-14 19:30:32 | [diff] [blame] | 1895 | v6_parameters.dns_query_type = DnsQueryType::AAAA; |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 1896 | |
| 1897 | ResolveHostResponseHelper v4_v4_request(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 1898 | HostPortPair("127.0.0.1", 80), NetLogWithSource(), v4_parameters, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1899 | request_context_.get(), host_cache_.get())); |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 1900 | EXPECT_THAT(v4_v4_request.result_error(), IsOk()); |
| 1901 | EXPECT_THAT(v4_v4_request.request()->GetAddressResults().value().endpoints(), |
| 1902 | testing::ElementsAre(CreateExpected("127.0.0.1", 80))); |
| 1903 | |
| 1904 | ResolveHostResponseHelper v4_v6_request(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 1905 | HostPortPair("127.0.0.1", 80), NetLogWithSource(), v6_parameters, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1906 | request_context_.get(), host_cache_.get())); |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 1907 | EXPECT_THAT(v4_v6_request.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 1908 | |
| 1909 | ResolveHostResponseHelper v4_unsp_request(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 1910 | HostPortPair("127.0.0.1", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1911 | request_context_.get(), host_cache_.get())); |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 1912 | EXPECT_THAT(v4_unsp_request.result_error(), IsOk()); |
| 1913 | EXPECT_THAT( |
| 1914 | v4_unsp_request.request()->GetAddressResults().value().endpoints(), |
| 1915 | testing::ElementsAre(CreateExpected("127.0.0.1", 80))); |
| 1916 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1917 | ResolveHostResponseHelper v6_v4_request(resolver_->CreateRequest( |
| 1918 | HostPortPair("::1", 80), NetLogWithSource(), v4_parameters, |
| 1919 | request_context_.get(), host_cache_.get())); |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 1920 | EXPECT_THAT(v6_v4_request.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 1921 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1922 | ResolveHostResponseHelper v6_v6_request(resolver_->CreateRequest( |
| 1923 | HostPortPair("::1", 80), NetLogWithSource(), v6_parameters, |
| 1924 | request_context_.get(), host_cache_.get())); |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 1925 | EXPECT_THAT(v6_v6_request.result_error(), IsOk()); |
| 1926 | EXPECT_THAT(v6_v6_request.request()->GetAddressResults().value().endpoints(), |
| 1927 | testing::ElementsAre(CreateExpected("::1", 80))); |
| 1928 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1929 | ResolveHostResponseHelper v6_unsp_request(resolver_->CreateRequest( |
| 1930 | HostPortPair("::1", 80), NetLogWithSource(), base::nullopt, |
| 1931 | request_context_.get(), host_cache_.get())); |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 1932 | EXPECT_THAT(v6_unsp_request.result_error(), IsOk()); |
| 1933 | EXPECT_THAT( |
| 1934 | v6_unsp_request.request()->GetAddressResults().value().endpoints(), |
| 1935 | testing::ElementsAre(CreateExpected("::1", 80))); |
| 1936 | } |
| 1937 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 1938 | TEST_F(HostResolverManagerTest, LocalOnly_FromCache) { |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 1939 | proc_->AddRuleForAllFamilies("just.testing", "192.168.1.42"); |
| 1940 | proc_->SignalMultiple(1u); // Need only one. |
| 1941 | |
| 1942 | HostResolver::ResolveHostParameters source_none_parameters; |
| 1943 | source_none_parameters.source = HostResolverSource::LOCAL_ONLY; |
| 1944 | |
| 1945 | // First NONE query expected to complete synchronously with a cache miss. |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 1946 | ResolveHostResponseHelper cache_miss_request(resolver_->CreateRequest( |
| 1947 | HostPortPair("just.testing", 80), NetLogWithSource(), |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1948 | source_none_parameters, request_context_.get(), host_cache_.get())); |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 1949 | EXPECT_TRUE(cache_miss_request.complete()); |
| 1950 | EXPECT_THAT(cache_miss_request.result_error(), IsError(ERR_DNS_CACHE_MISS)); |
| 1951 | EXPECT_FALSE(cache_miss_request.request()->GetAddressResults()); |
| 1952 | EXPECT_FALSE(cache_miss_request.request()->GetStaleInfo()); |
| 1953 | |
| 1954 | // Normal query to populate the cache. |
| 1955 | ResolveHostResponseHelper normal_request(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 1956 | HostPortPair("just.testing", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1957 | request_context_.get(), host_cache_.get())); |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 1958 | EXPECT_THAT(normal_request.result_error(), IsOk()); |
| 1959 | EXPECT_FALSE(normal_request.request()->GetStaleInfo()); |
| 1960 | |
| 1961 | // Second NONE query expected to complete synchronously with cache hit. |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 1962 | ResolveHostResponseHelper cache_hit_request(resolver_->CreateRequest( |
| 1963 | HostPortPair("just.testing", 80), NetLogWithSource(), |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1964 | source_none_parameters, request_context_.get(), host_cache_.get())); |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 1965 | EXPECT_TRUE(cache_hit_request.complete()); |
| 1966 | EXPECT_THAT(cache_hit_request.result_error(), IsOk()); |
| 1967 | EXPECT_THAT( |
| 1968 | cache_hit_request.request()->GetAddressResults().value().endpoints(), |
| 1969 | testing::ElementsAre(CreateExpected("192.168.1.42", 80))); |
| 1970 | EXPECT_FALSE(cache_hit_request.request()->GetStaleInfo().value().is_stale()); |
| 1971 | } |
| 1972 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 1973 | TEST_F(HostResolverManagerTest, LocalOnly_StaleEntry) { |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 1974 | proc_->AddRuleForAllFamilies("just.testing", "192.168.1.42"); |
| 1975 | proc_->SignalMultiple(1u); // Need only one. |
| 1976 | |
| 1977 | HostResolver::ResolveHostParameters source_none_parameters; |
| 1978 | source_none_parameters.source = HostResolverSource::LOCAL_ONLY; |
| 1979 | |
| 1980 | // First NONE query expected to complete synchronously with a cache miss. |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 1981 | ResolveHostResponseHelper cache_miss_request(resolver_->CreateRequest( |
| 1982 | HostPortPair("just.testing", 80), NetLogWithSource(), |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1983 | source_none_parameters, request_context_.get(), host_cache_.get())); |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 1984 | EXPECT_TRUE(cache_miss_request.complete()); |
| 1985 | EXPECT_THAT(cache_miss_request.result_error(), IsError(ERR_DNS_CACHE_MISS)); |
| 1986 | EXPECT_FALSE(cache_miss_request.request()->GetAddressResults()); |
| 1987 | EXPECT_FALSE(cache_miss_request.request()->GetStaleInfo()); |
| 1988 | |
| 1989 | // Normal query to populate the cache. |
| 1990 | ResolveHostResponseHelper normal_request(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 1991 | HostPortPair("just.testing", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1992 | request_context_.get(), host_cache_.get())); |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 1993 | EXPECT_THAT(normal_request.result_error(), IsOk()); |
| 1994 | EXPECT_FALSE(normal_request.request()->GetStaleInfo()); |
| 1995 | |
| 1996 | MakeCacheStale(); |
| 1997 | |
| 1998 | // Second NONE query still expected to complete synchronously with cache miss. |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 1999 | ResolveHostResponseHelper stale_request(resolver_->CreateRequest( |
| 2000 | HostPortPair("just.testing", 80), NetLogWithSource(), |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2001 | source_none_parameters, request_context_.get(), host_cache_.get())); |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 2002 | EXPECT_TRUE(stale_request.complete()); |
| 2003 | EXPECT_THAT(stale_request.result_error(), IsError(ERR_DNS_CACHE_MISS)); |
| 2004 | EXPECT_FALSE(stale_request.request()->GetAddressResults()); |
| 2005 | EXPECT_FALSE(stale_request.request()->GetStaleInfo()); |
| 2006 | } |
| 2007 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 2008 | TEST_F(HostResolverManagerTest, LocalOnly_FromIp) { |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 2009 | HostResolver::ResolveHostParameters source_none_parameters; |
| 2010 | source_none_parameters.source = HostResolverSource::LOCAL_ONLY; |
| 2011 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2012 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 2013 | HostPortPair("1.2.3.4", 56), NetLogWithSource(), source_none_parameters, |
| 2014 | request_context_.get(), host_cache_.get())); |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 2015 | |
| 2016 | // Expected to resolve synchronously. |
| 2017 | EXPECT_TRUE(response.complete()); |
| 2018 | EXPECT_THAT(response.result_error(), IsOk()); |
| 2019 | EXPECT_THAT(response.request()->GetAddressResults().value().endpoints(), |
| 2020 | testing::ElementsAre(CreateExpected("1.2.3.4", 56))); |
| 2021 | EXPECT_FALSE(response.request()->GetStaleInfo()); |
| 2022 | } |
| 2023 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 2024 | TEST_F(HostResolverManagerTest, LocalOnly_InvalidName) { |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 2025 | proc_->AddRuleForAllFamilies("foo,bar.com", "192.168.1.42"); |
| 2026 | |
| 2027 | HostResolver::ResolveHostParameters source_none_parameters; |
| 2028 | source_none_parameters.source = HostResolverSource::LOCAL_ONLY; |
| 2029 | |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 2030 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 2031 | HostPortPair("foo,bar.com", 57), NetLogWithSource(), |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2032 | source_none_parameters, request_context_.get(), host_cache_.get())); |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 2033 | |
| 2034 | // Expected to fail synchronously. |
| 2035 | EXPECT_TRUE(response.complete()); |
| 2036 | EXPECT_THAT(response.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 2037 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 2038 | EXPECT_FALSE(response.request()->GetStaleInfo()); |
| 2039 | } |
| 2040 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 2041 | TEST_F(HostResolverManagerTest, LocalOnly_InvalidLocalhost) { |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 2042 | HostResolver::ResolveHostParameters source_none_parameters; |
| 2043 | source_none_parameters.source = HostResolverSource::LOCAL_ONLY; |
| 2044 | |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 2045 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 2046 | HostPortPair("foo,bar.localhost", 58), NetLogWithSource(), |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2047 | source_none_parameters, request_context_.get(), host_cache_.get())); |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 2048 | |
| 2049 | // Expected to fail synchronously. |
| 2050 | EXPECT_TRUE(response.complete()); |
| 2051 | EXPECT_THAT(response.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 2052 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 2053 | EXPECT_FALSE(response.request()->GetStaleInfo()); |
| 2054 | } |
| 2055 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 2056 | TEST_F(HostResolverManagerTest, StaleAllowed) { |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 2057 | proc_->AddRuleForAllFamilies("just.testing", "192.168.1.42"); |
| 2058 | proc_->SignalMultiple(1u); // Need only one. |
| 2059 | |
| 2060 | HostResolver::ResolveHostParameters stale_allowed_parameters; |
| 2061 | stale_allowed_parameters.source = HostResolverSource::LOCAL_ONLY; |
| 2062 | stale_allowed_parameters.cache_usage = |
| 2063 | HostResolver::ResolveHostParameters::CacheUsage::STALE_ALLOWED; |
| 2064 | |
| 2065 | // First query expected to complete synchronously as a cache miss. |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 2066 | ResolveHostResponseHelper cache_miss_request(resolver_->CreateRequest( |
| 2067 | HostPortPair("just.testing", 80), NetLogWithSource(), |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2068 | stale_allowed_parameters, request_context_.get(), host_cache_.get())); |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 2069 | EXPECT_TRUE(cache_miss_request.complete()); |
| 2070 | EXPECT_THAT(cache_miss_request.result_error(), IsError(ERR_DNS_CACHE_MISS)); |
| 2071 | EXPECT_FALSE(cache_miss_request.request()->GetAddressResults()); |
| 2072 | EXPECT_FALSE(cache_miss_request.request()->GetStaleInfo()); |
| 2073 | |
| 2074 | // Normal query to populate cache |
| 2075 | ResolveHostResponseHelper normal_request(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 2076 | HostPortPair("just.testing", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2077 | request_context_.get(), host_cache_.get())); |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 2078 | EXPECT_THAT(normal_request.result_error(), IsOk()); |
| 2079 | EXPECT_FALSE(normal_request.request()->GetStaleInfo()); |
| 2080 | |
| 2081 | MakeCacheStale(); |
| 2082 | |
| 2083 | // Second NONE query expected to get a stale cache hit. |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 2084 | ResolveHostResponseHelper stale_request(resolver_->CreateRequest( |
| 2085 | HostPortPair("just.testing", 84), NetLogWithSource(), |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2086 | stale_allowed_parameters, request_context_.get(), host_cache_.get())); |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 2087 | EXPECT_TRUE(stale_request.complete()); |
| 2088 | EXPECT_THAT(stale_request.result_error(), IsOk()); |
| 2089 | EXPECT_THAT(stale_request.request()->GetAddressResults().value().endpoints(), |
| 2090 | testing::ElementsAre(CreateExpected("192.168.1.42", 84))); |
| 2091 | EXPECT_TRUE(stale_request.request()->GetStaleInfo().value().is_stale()); |
| 2092 | } |
| 2093 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 2094 | TEST_F(HostResolverManagerTest, StaleAllowed_NonLocal) { |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 2095 | proc_->AddRuleForAllFamilies("just.testing", "192.168.2.42"); |
| 2096 | proc_->SignalMultiple(1u); // Need only one. |
| 2097 | |
| 2098 | HostResolver::ResolveHostParameters stale_allowed_parameters; |
| 2099 | stale_allowed_parameters.cache_usage = |
| 2100 | HostResolver::ResolveHostParameters::CacheUsage::STALE_ALLOWED; |
| 2101 | |
| 2102 | // Normal non-local resolves should still work normally with the STALE_ALLOWED |
| 2103 | // parameter, and there should be no stale info. |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 2104 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 2105 | HostPortPair("just.testing", 85), NetLogWithSource(), |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2106 | stale_allowed_parameters, request_context_.get(), host_cache_.get())); |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 2107 | EXPECT_THAT(response.result_error(), IsOk()); |
| 2108 | EXPECT_THAT(response.request()->GetAddressResults().value().endpoints(), |
| 2109 | testing::ElementsAre(CreateExpected("192.168.2.42", 85))); |
| 2110 | EXPECT_FALSE(response.request()->GetStaleInfo()); |
| 2111 | } |
| 2112 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 2113 | TEST_F(HostResolverManagerTest, StaleAllowed_FromIp) { |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 2114 | HostResolver::ResolveHostParameters stale_allowed_parameters; |
| 2115 | stale_allowed_parameters.cache_usage = |
| 2116 | HostResolver::ResolveHostParameters::CacheUsage::STALE_ALLOWED; |
| 2117 | |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 2118 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 2119 | HostPortPair("1.2.3.4", 57), NetLogWithSource(), stale_allowed_parameters, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2120 | request_context_.get(), host_cache_.get())); |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 2121 | |
| 2122 | // Expected to resolve synchronously without stale info. |
| 2123 | EXPECT_TRUE(response.complete()); |
| 2124 | EXPECT_THAT(response.result_error(), IsOk()); |
| 2125 | EXPECT_THAT(response.request()->GetAddressResults().value().endpoints(), |
| 2126 | testing::ElementsAre(CreateExpected("1.2.3.4", 57))); |
| 2127 | EXPECT_FALSE(response.request()->GetStaleInfo()); |
| 2128 | } |
| 2129 | |
Miriam Gershenson | e3bc6302 | 2017-10-09 19:57:05 | [diff] [blame] | 2130 | // TODO(mgersh): add a test case for errors with positive TTL after |
| 2131 | // https://crbug.com/115051 is fixed. |
| 2132 | |
[email protected] | 189163e | 2011-05-11 01:48:54 | [diff] [blame] | 2133 | // Test the retry attempts simulating host resolver proc that takes too long. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 2134 | TEST_F(HostResolverManagerTest, MultipleAttempts) { |
[email protected] | 189163e | 2011-05-11 01:48:54 | [diff] [blame] | 2135 | // Total number of attempts would be 3 and we want the 3rd attempt to resolve |
Eric Orth | 9a03756 | 2018-07-03 21:24:38 | [diff] [blame] | 2136 | // the host. First and second attempt will be forced to wait until they get |
[email protected] | 189163e | 2011-05-11 01:48:54 | [diff] [blame] | 2137 | // word that a resolution has completed. The 3rd resolution attempt will try |
Eric Orth | 9a03756 | 2018-07-03 21:24:38 | [diff] [blame] | 2138 | // to get done ASAP, and won't wait. |
[email protected] | 189163e | 2011-05-11 01:48:54 | [diff] [blame] | 2139 | int kAttemptNumberToResolve = 3; |
| 2140 | int kTotalAttempts = 3; |
| 2141 | |
Eric Orth | 9a03756 | 2018-07-03 21:24:38 | [diff] [blame] | 2142 | // Add a little bit of extra fudge to the delay to allow reasonable |
| 2143 | // flexibility for time > vs >= etc. We don't need to fail the test if we |
| 2144 | // retry at t=6001 instead of t=6000. |
| 2145 | base::TimeDelta kSleepFudgeFactor = base::TimeDelta::FromMilliseconds(1); |
| 2146 | |
[email protected] | 189163e | 2011-05-11 01:48:54 | [diff] [blame] | 2147 | scoped_refptr<LookupAttemptHostResolverProc> resolver_proc( |
Raul Tambre | 94493c65 | 2019-03-11 17:18:35 | [diff] [blame] | 2148 | new LookupAttemptHostResolverProc(nullptr, kAttemptNumberToResolve, |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 2149 | kTotalAttempts)); |
| 2150 | |
Eric Orth | 5906622 | 2019-03-07 23:52:27 | [diff] [blame] | 2151 | ProcTaskParams params = DefaultParams(resolver_proc.get()); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 2152 | base::TimeDelta unresponsive_delay = params.unresponsive_delay; |
| 2153 | int retry_factor = params.retry_factor; |
| 2154 | |
Eric Orth | 607b6d8 | 2019-05-08 16:43:32 | [diff] [blame] | 2155 | CreateResolverWithLimitsAndParams(kMaxJobs, params, true /* ipv6_reachable */, |
| 2156 | true /* check_ipv6_on_wifi */); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 2157 | |
| 2158 | // Override the current thread task runner, so we can simulate the passage of |
| 2159 | // time and avoid any actual sleeps. |
| 2160 | auto test_task_runner = base::MakeRefCounted<base::TestMockTimeTaskRunner>(); |
| 2161 | base::ScopedClosureRunner task_runner_override_scoped_cleanup = |
| 2162 | base::ThreadTaskRunnerHandle::OverrideForTesting(test_task_runner); |
| 2163 | |
| 2164 | // Resolve "host1". |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2165 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 2166 | HostPortPair("host1", 70), NetLogWithSource(), base::nullopt, |
| 2167 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 2168 | EXPECT_FALSE(response.complete()); |
| 2169 | |
| 2170 | resolver_proc->WaitForNAttemptsToBeBlocked(1); |
| 2171 | EXPECT_FALSE(response.complete()); |
| 2172 | |
| 2173 | test_task_runner->FastForwardBy(unresponsive_delay + kSleepFudgeFactor); |
| 2174 | resolver_proc->WaitForNAttemptsToBeBlocked(2); |
| 2175 | EXPECT_FALSE(response.complete()); |
| 2176 | |
| 2177 | test_task_runner->FastForwardBy(unresponsive_delay * retry_factor + |
| 2178 | kSleepFudgeFactor); |
| 2179 | |
| 2180 | resolver_proc->WaitForAllAttemptsToFinish(); |
| 2181 | test_task_runner->RunUntilIdle(); |
| 2182 | |
| 2183 | // Resolve returns -4 to indicate that 3rd attempt has resolved the host. |
| 2184 | // Since we're using a TestMockTimeTaskRunner, the RunLoop stuff in |
| 2185 | // result_error() will fail if it actually has to wait, but unless there's an |
| 2186 | // error, the result should be immediately ready by this point. |
| 2187 | EXPECT_EQ(-4, response.result_error()); |
| 2188 | |
| 2189 | // We should be done with retries, but make sure none erroneously happen. |
| 2190 | test_task_runner->FastForwardUntilNoTasksRemain(); |
| 2191 | |
Eric Roman | 21b3923 | 2019-06-28 21:28:21 | [diff] [blame] | 2192 | EXPECT_EQ(resolver_proc->GetTotalAttemptsResolved(), kTotalAttempts); |
| 2193 | } |
| 2194 | |
| 2195 | // Regression test for https://crbug.com/976948. |
| 2196 | // |
| 2197 | // Tests that when the maximum number of retries is set to |
| 2198 | // |HostResolver::ManagerOptions::kDefaultRetryAttempts| the |
| 2199 | // number of retries used is 4 rather than something higher. |
| 2200 | TEST_F(HostResolverManagerTest, DefaultMaxRetryAttempts) { |
| 2201 | auto test_task_runner = base::MakeRefCounted<base::TestMockTimeTaskRunner>(); |
| 2202 | base::ScopedClosureRunner task_runner_override_scoped_cleanup = |
| 2203 | base::ThreadTaskRunnerHandle::OverrideForTesting(test_task_runner); |
| 2204 | |
| 2205 | // Instantiate a ResolverProc that will block all incoming requests. |
| 2206 | auto resolver_proc = base::MakeRefCounted<LookupAttemptHostResolverProc>( |
| 2207 | nullptr, std::numeric_limits<size_t>::max(), |
| 2208 | std::numeric_limits<size_t>::max()); |
| 2209 | |
| 2210 | // This corresponds to kDefaultMaxRetryAttempts in |
| 2211 | // ProcTaskParams::ProcTaskParams(). The correspondence is verified below, |
| 2212 | // since that symbol is not exported. |
| 2213 | const size_t expected_max_retries = 4; |
| 2214 | |
| 2215 | // Use the special value |ManagerOptions::kDefaultRetryAttempts|, which is |
| 2216 | // expected to translate into |expected_num_retries|. |
| 2217 | ASSERT_NE(HostResolver::ManagerOptions::kDefaultRetryAttempts, |
| 2218 | expected_max_retries); |
| 2219 | ProcTaskParams params(resolver_proc.get(), |
| 2220 | HostResolver::ManagerOptions::kDefaultRetryAttempts); |
| 2221 | ASSERT_EQ(params.max_retry_attempts, expected_max_retries); |
| 2222 | |
| 2223 | CreateResolverWithLimitsAndParams(kMaxJobs, params, |
| 2224 | false /* ipv6_reachable */, |
| 2225 | false /* check_ipv6_on_wifi */); |
| 2226 | |
| 2227 | // Resolve "host1". The resolver proc will hang all requests so this |
| 2228 | // resolution should remain stalled until calling SetResolvedAttemptNumber(). |
| 2229 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 2230 | HostPortPair("host1", 70), NetLogWithSource(), base::nullopt, |
| 2231 | request_context_.get(), host_cache_.get())); |
| 2232 | EXPECT_FALSE(response.complete()); |
| 2233 | |
| 2234 | // Simulate running the main thread (network task runner) for a long |
| 2235 | // time. Because none of the attempts posted to worker pool can complete, this |
| 2236 | // should cause all of the retry attempts to get posted, according to the |
| 2237 | // exponential backoff schedule. |
| 2238 | test_task_runner->FastForwardBy(base::TimeDelta::FromMinutes(20)); |
| 2239 | |
| 2240 | // Unblock the resolver proc, then wait for all the worker pool and main |
| 2241 | // thread tasks to complete. Note that the call to SetResolvedAttemptNumber(1) |
| 2242 | // will cause all the blocked resolver procs tasks fail with -2. |
| 2243 | resolver_proc->SetResolvedAttemptNumber(1); |
| 2244 | const int kExpectedError = -2; |
| 2245 | base::ThreadPoolInstance::Get()->FlushForTesting(); |
| 2246 | test_task_runner->RunUntilIdle(); |
| 2247 | |
| 2248 | ASSERT_TRUE(response.complete()); |
| 2249 | EXPECT_EQ(kExpectedError, response.result_error()); |
| 2250 | |
| 2251 | // Ensure that the original attempt was executed on the worker pool, as well |
| 2252 | // as the maximum number of allowed retries, and no more. |
| 2253 | EXPECT_EQ(static_cast<int>(expected_max_retries + 1), |
| 2254 | resolver_proc->GetTotalAttemptsResolved()); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 2255 | } |
| 2256 | |
eroman | 91dd360 | 2015-03-26 03:46:33 | [diff] [blame] | 2257 | // If a host resolves to a list that includes 127.0.53.53, this is treated as |
| 2258 | // an error. 127.0.53.53 is a localhost address, however it has been given a |
eroman | 1efc237c | 2016-12-14 00:00:45 | [diff] [blame] | 2259 | // special significance by ICANN to help surface name collision resulting from |
eroman | 91dd360 | 2015-03-26 03:46:33 | [diff] [blame] | 2260 | // the new gTLDs. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 2261 | TEST_F(HostResolverManagerTest, NameCollisionIcann) { |
eroman | 91dd360 | 2015-03-26 03:46:33 | [diff] [blame] | 2262 | proc_->AddRuleForAllFamilies("single", "127.0.53.53"); |
| 2263 | proc_->AddRuleForAllFamilies("multiple", "127.0.0.1,127.0.53.53"); |
| 2264 | proc_->AddRuleForAllFamilies("ipv6", "::127.0.53.53"); |
| 2265 | proc_->AddRuleForAllFamilies("not_reserved1", "53.53.0.127"); |
| 2266 | proc_->AddRuleForAllFamilies("not_reserved2", "127.0.53.54"); |
| 2267 | proc_->AddRuleForAllFamilies("not_reserved3", "10.0.53.53"); |
| 2268 | proc_->SignalMultiple(6u); |
| 2269 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2270 | ResolveHostResponseHelper single_response(resolver_->CreateRequest( |
| 2271 | HostPortPair("single", 80), NetLogWithSource(), base::nullopt, |
| 2272 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 2273 | EXPECT_THAT(single_response.result_error(), |
| 2274 | IsError(ERR_ICANN_NAME_COLLISION)); |
| 2275 | EXPECT_FALSE(single_response.request()->GetAddressResults()); |
| 2276 | |
| 2277 | // ERR_ICANN_NAME_COLLISION is cached like any other error, using a fixed TTL |
| 2278 | // for failed entries from proc-based resolver. That said, the fixed TTL is 0, |
| 2279 | // so it should never be cached. |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 2280 | const std::pair<const HostCache::Key, HostCache::Entry>* cache_result = |
| 2281 | GetCacheHit(HostCache::Key("single", DnsQueryType::UNSPECIFIED, |
| 2282 | 0 /* host_resolver_flags */, |
| 2283 | HostResolverSource::ANY)); |
| 2284 | EXPECT_FALSE(cache_result); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 2285 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2286 | ResolveHostResponseHelper multiple_response(resolver_->CreateRequest( |
| 2287 | HostPortPair("multiple", 80), NetLogWithSource(), base::nullopt, |
| 2288 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 2289 | EXPECT_THAT(multiple_response.result_error(), |
| 2290 | IsError(ERR_ICANN_NAME_COLLISION)); |
| 2291 | |
| 2292 | // Resolving an IP literal of 127.0.53.53 however is allowed. |
| 2293 | ResolveHostResponseHelper literal_response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 2294 | HostPortPair("127.0.53.53", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2295 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 2296 | EXPECT_THAT(literal_response.result_error(), IsOk()); |
| 2297 | |
| 2298 | // Moreover the address should not be recognized when embedded in an IPv6 |
| 2299 | // address. |
| 2300 | ResolveHostResponseHelper ipv6_response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 2301 | HostPortPair("127.0.53.53", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2302 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 2303 | EXPECT_THAT(ipv6_response.result_error(), IsOk()); |
| 2304 | |
| 2305 | // Try some other IPs which are similar, but NOT an exact match on |
| 2306 | // 127.0.53.53. |
| 2307 | ResolveHostResponseHelper similar_response1(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 2308 | HostPortPair("not_reserved1", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2309 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 2310 | EXPECT_THAT(similar_response1.result_error(), IsOk()); |
| 2311 | |
| 2312 | ResolveHostResponseHelper similar_response2(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 2313 | HostPortPair("not_reserved2", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2314 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 2315 | EXPECT_THAT(similar_response2.result_error(), IsOk()); |
| 2316 | |
| 2317 | ResolveHostResponseHelper similar_response3(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 2318 | HostPortPair("not_reserved3", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2319 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 2320 | EXPECT_THAT(similar_response3.result_error(), IsOk()); |
| 2321 | } |
| 2322 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 2323 | TEST_F(HostResolverManagerTest, IsIPv6Reachable) { |
| 2324 | // The real HostResolverManager is needed since TestHostResolverManager will |
cbentzel | 1906f87 | 2015-06-05 16:25:25 | [diff] [blame] | 2325 | // bypass the IPv6 reachability tests. |
Eric Orth | 37b1819 | 2019-04-22 19:09:28 | [diff] [blame] | 2326 | DestroyResolver(); |
| 2327 | host_cache_ = nullptr; |
| 2328 | resolver_ = std::make_unique<HostResolverManager>(DefaultOptions(), nullptr); |
cbentzel | 1906f87 | 2015-06-05 16:25:25 | [diff] [blame] | 2329 | |
sergeyu | b8cdc21 | 2015-05-14 18:50:37 | [diff] [blame] | 2330 | // Verify that two consecutive calls return the same value. |
tfarina | 4283411 | 2016-09-22 13:38:20 | [diff] [blame] | 2331 | TestNetLog test_net_log; |
| 2332 | NetLogWithSource net_log = |
| 2333 | NetLogWithSource::Make(&test_net_log, NetLogSourceType::NONE); |
| 2334 | bool result1 = IsIPv6Reachable(net_log); |
| 2335 | bool result2 = IsIPv6Reachable(net_log); |
sergeyu | b8cdc21 | 2015-05-14 18:50:37 | [diff] [blame] | 2336 | EXPECT_EQ(result1, result2); |
| 2337 | |
| 2338 | // Filter reachability check events and verify that there are two of them. |
Eric Roman | 79cc755 | 2019-07-19 02:17:54 | [diff] [blame] | 2339 | auto probe_event_list = test_net_log.GetEntriesWithType( |
| 2340 | NetLogEventType::HOST_RESOLVER_IMPL_IPV6_REACHABILITY_CHECK); |
sergeyu | b8cdc21 | 2015-05-14 18:50:37 | [diff] [blame] | 2341 | ASSERT_EQ(2U, probe_event_list.size()); |
| 2342 | |
| 2343 | // Verify that the first request was not cached and the second one was. |
Eric Roman | 79cc755 | 2019-07-19 02:17:54 | [diff] [blame] | 2344 | EXPECT_FALSE(GetBooleanValueFromParams(probe_event_list[0], "cached")); |
| 2345 | EXPECT_TRUE(GetBooleanValueFromParams(probe_event_list[1], "cached")); |
sergeyu | b8cdc21 | 2015-05-14 18:50:37 | [diff] [blame] | 2346 | } |
| 2347 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 2348 | TEST_F(HostResolverManagerTest, IncludeCanonicalName) { |
Eric Orth | 322af3e4 | 2018-08-20 18:12:59 | [diff] [blame] | 2349 | proc_->AddRuleForAllFamilies("just.testing", "192.168.1.42", |
| 2350 | HOST_RESOLVER_CANONNAME, "canon.name"); |
| 2351 | proc_->SignalMultiple(2u); |
| 2352 | |
| 2353 | HostResolver::ResolveHostParameters parameters; |
| 2354 | parameters.include_canonical_name = true; |
| 2355 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 2356 | HostPortPair("just.testing", 80), NetLogWithSource(), parameters, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2357 | request_context_.get(), host_cache_.get())); |
Eric Orth | 322af3e4 | 2018-08-20 18:12:59 | [diff] [blame] | 2358 | ResolveHostResponseHelper response_no_flag(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 2359 | HostPortPair("just.testing", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2360 | request_context_.get(), host_cache_.get())); |
Eric Orth | 322af3e4 | 2018-08-20 18:12:59 | [diff] [blame] | 2361 | |
| 2362 | EXPECT_THAT(response.result_error(), IsOk()); |
| 2363 | EXPECT_THAT(response.request()->GetAddressResults().value().endpoints(), |
| 2364 | testing::ElementsAre(CreateExpected("192.168.1.42", 80))); |
| 2365 | EXPECT_EQ("canon.name", |
| 2366 | response.request()->GetAddressResults().value().canonical_name()); |
| 2367 | |
| 2368 | EXPECT_THAT(response_no_flag.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 2369 | } |
| 2370 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 2371 | TEST_F(HostResolverManagerTest, LoopbackOnly) { |
Eric Orth | 322af3e4 | 2018-08-20 18:12:59 | [diff] [blame] | 2372 | proc_->AddRuleForAllFamilies("otherlocal", "127.0.0.1", |
| 2373 | HOST_RESOLVER_LOOPBACK_ONLY); |
| 2374 | proc_->SignalMultiple(2u); |
| 2375 | |
| 2376 | HostResolver::ResolveHostParameters parameters; |
| 2377 | parameters.loopback_only = true; |
| 2378 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 2379 | HostPortPair("otherlocal", 80), NetLogWithSource(), parameters, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2380 | request_context_.get(), host_cache_.get())); |
Eric Orth | 322af3e4 | 2018-08-20 18:12:59 | [diff] [blame] | 2381 | ResolveHostResponseHelper response_no_flag(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 2382 | HostPortPair("otherlocal", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2383 | request_context_.get(), host_cache_.get())); |
Eric Orth | 322af3e4 | 2018-08-20 18:12:59 | [diff] [blame] | 2384 | |
| 2385 | EXPECT_THAT(response.result_error(), IsOk()); |
| 2386 | EXPECT_THAT(response.request()->GetAddressResults().value().endpoints(), |
| 2387 | testing::ElementsAre(CreateExpected("127.0.0.1", 80))); |
| 2388 | |
| 2389 | EXPECT_THAT(response_no_flag.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 2390 | } |
| 2391 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 2392 | TEST_F(HostResolverManagerTest, IsSpeculative) { |
Eric Orth | b30bc17 | 2018-08-17 21:09:57 | [diff] [blame] | 2393 | proc_->AddRuleForAllFamilies("just.testing", "192.168.1.42"); |
| 2394 | proc_->SignalMultiple(1u); |
| 2395 | |
| 2396 | HostResolver::ResolveHostParameters parameters; |
| 2397 | parameters.is_speculative = true; |
| 2398 | |
| 2399 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 2400 | HostPortPair("just.testing", 80), NetLogWithSource(), parameters, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2401 | request_context_.get(), host_cache_.get())); |
Eric Orth | b30bc17 | 2018-08-17 21:09:57 | [diff] [blame] | 2402 | |
| 2403 | EXPECT_THAT(response.result_error(), IsOk()); |
| 2404 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 2405 | |
| 2406 | ASSERT_EQ(1u, proc_->GetCaptureList().size()); |
| 2407 | EXPECT_EQ("just.testing", proc_->GetCaptureList()[0].hostname); |
| 2408 | |
| 2409 | // Reresolve without the |is_speculative| flag should immediately return from |
| 2410 | // cache. |
| 2411 | ResolveHostResponseHelper response2(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 2412 | HostPortPair("just.testing", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2413 | request_context_.get(), host_cache_.get())); |
Eric Orth | b30bc17 | 2018-08-17 21:09:57 | [diff] [blame] | 2414 | |
| 2415 | EXPECT_THAT(response2.result_error(), IsOk()); |
| 2416 | EXPECT_THAT(response2.request()->GetAddressResults().value().endpoints(), |
| 2417 | testing::ElementsAre(CreateExpected("192.168.1.42", 80))); |
| 2418 | |
| 2419 | EXPECT_EQ("just.testing", proc_->GetCaptureList()[0].hostname); |
| 2420 | EXPECT_EQ(1u, proc_->GetCaptureList().size()); // No increase. |
| 2421 | } |
| 2422 | |
Eric Orth | 9871aafa | 2018-10-02 19:59:18 | [diff] [blame] | 2423 | #if BUILDFLAG(ENABLE_MDNS) |
| 2424 | const uint8_t kMdnsResponseA[] = { |
| 2425 | // Header |
| 2426 | 0x00, 0x00, // ID is zeroed out |
| 2427 | 0x81, 0x80, // Standard query response, RA, no error |
| 2428 | 0x00, 0x00, // No questions (for simplicity) |
| 2429 | 0x00, 0x01, // 1 RR (answers) |
| 2430 | 0x00, 0x00, // 0 authority RRs |
| 2431 | 0x00, 0x00, // 0 additional RRs |
| 2432 | |
| 2433 | // "myhello.local." |
| 2434 | 0x07, 'm', 'y', 'h', 'e', 'l', 'l', 'o', 0x05, 'l', 'o', 'c', 'a', 'l', |
| 2435 | 0x00, |
| 2436 | |
| 2437 | 0x00, 0x01, // TYPE is A. |
| 2438 | 0x00, 0x01, // CLASS is IN. |
| 2439 | 0x00, 0x00, 0x00, 0x10, // TTL is 16 (seconds) |
| 2440 | 0x00, 0x04, // RDLENGTH is 4 bytes. |
| 2441 | 0x01, 0x02, 0x03, 0x04, // 1.2.3.4 |
| 2442 | }; |
| 2443 | |
Eric Orth | 026776a | 2019-01-18 00:13:28 | [diff] [blame] | 2444 | const uint8_t kMdnsResponseA2[] = { |
| 2445 | // Header |
| 2446 | 0x00, 0x00, // ID is zeroed out |
| 2447 | 0x81, 0x80, // Standard query response, RA, no error |
| 2448 | 0x00, 0x00, // No questions (for simplicity) |
| 2449 | 0x00, 0x01, // 1 RR (answers) |
| 2450 | 0x00, 0x00, // 0 authority RRs |
| 2451 | 0x00, 0x00, // 0 additional RRs |
| 2452 | |
| 2453 | // "myhello.local." |
| 2454 | 0x07, 'm', 'y', 'h', 'e', 'l', 'l', 'o', 0x05, 'l', 'o', 'c', 'a', 'l', |
| 2455 | 0x00, |
| 2456 | |
| 2457 | 0x00, 0x01, // TYPE is A. |
| 2458 | 0x00, 0x01, // CLASS is IN. |
| 2459 | 0x00, 0x00, 0x00, 0x10, // TTL is 16 (seconds) |
| 2460 | 0x00, 0x04, // RDLENGTH is 4 bytes. |
| 2461 | 0x05, 0x06, 0x07, 0x08, // 5.6.7.8 |
| 2462 | }; |
| 2463 | |
| 2464 | const uint8_t kMdnsResponseA2Goodbye[] = { |
| 2465 | // Header |
| 2466 | 0x00, 0x00, // ID is zeroed out |
| 2467 | 0x81, 0x80, // Standard query response, RA, no error |
| 2468 | 0x00, 0x00, // No questions (for simplicity) |
| 2469 | 0x00, 0x01, // 1 RR (answers) |
| 2470 | 0x00, 0x00, // 0 authority RRs |
| 2471 | 0x00, 0x00, // 0 additional RRs |
| 2472 | |
| 2473 | // "myhello.local." |
| 2474 | 0x07, 'm', 'y', 'h', 'e', 'l', 'l', 'o', 0x05, 'l', 'o', 'c', 'a', 'l', |
| 2475 | 0x00, |
| 2476 | |
| 2477 | 0x00, 0x01, // TYPE is A. |
| 2478 | 0x00, 0x01, // CLASS is IN. |
| 2479 | 0x00, 0x00, 0x00, 0x00, // TTL is 0 (signaling "goodbye" removal of result) |
| 2480 | 0x00, 0x04, // RDLENGTH is 4 bytes. |
| 2481 | 0x05, 0x06, 0x07, 0x08, // 5.6.7.8 |
| 2482 | }; |
| 2483 | |
Eric Orth | 9871aafa | 2018-10-02 19:59:18 | [diff] [blame] | 2484 | const uint8_t kMdnsResponseAAAA[] = { |
| 2485 | // Header |
| 2486 | 0x00, 0x00, // ID is zeroed out |
| 2487 | 0x81, 0x80, // Standard query response, RA, no error |
| 2488 | 0x00, 0x00, // No questions (for simplicity) |
| 2489 | 0x00, 0x01, // 1 RR (answers) |
| 2490 | 0x00, 0x00, // 0 authority RRs |
| 2491 | 0x00, 0x00, // 0 additional RRs |
| 2492 | |
| 2493 | // "myhello.local." |
| 2494 | 0x07, 'm', 'y', 'h', 'e', 'l', 'l', 'o', 0x05, 'l', 'o', 'c', 'a', 'l', |
| 2495 | 0x00, |
| 2496 | |
| 2497 | 0x00, 0x1C, // TYPE is AAAA. |
| 2498 | 0x00, 0x01, // CLASS is IN. |
| 2499 | 0x00, 0x00, 0x00, 0x10, // TTL is 16 (seconds) |
| 2500 | 0x00, 0x10, // RDLENGTH is 16 bytes. |
| 2501 | |
| 2502 | // 000a:0000:0000:0000:0001:0002:0003:0004 |
| 2503 | 0x00, 0x0A, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x01, 0x00, 0x02, |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 2504 | 0x00, 0x03, 0x00, 0x04}; |
Eric Orth | 9871aafa | 2018-10-02 19:59:18 | [diff] [blame] | 2505 | |
| 2506 | // An MDNS response indicating that the responder owns the hostname, but the |
| 2507 | // specific requested type (AAAA) does not exist because the responder only has |
| 2508 | // A addresses. |
| 2509 | const uint8_t kMdnsResponseNsec[] = { |
| 2510 | // Header |
| 2511 | 0x00, 0x00, // ID is zeroed out |
| 2512 | 0x81, 0x80, // Standard query response, RA, no error |
| 2513 | 0x00, 0x00, // No questions (for simplicity) |
| 2514 | 0x00, 0x01, // 1 RR (answers) |
| 2515 | 0x00, 0x00, // 0 authority RRs |
| 2516 | 0x00, 0x00, // 0 additional RRs |
| 2517 | |
| 2518 | // "myhello.local." |
| 2519 | 0x07, 'm', 'y', 'h', 'e', 'l', 'l', 'o', 0x05, 'l', 'o', 'c', 'a', 'l', |
| 2520 | 0x00, |
| 2521 | |
| 2522 | 0x00, 0x2f, // TYPE is NSEC. |
| 2523 | 0x00, 0x01, // CLASS is IN. |
| 2524 | 0x00, 0x00, 0x00, 0x10, // TTL is 16 (seconds) |
| 2525 | 0x00, 0x06, // RDLENGTH is 6 bytes. |
| 2526 | 0xc0, 0x0c, // Next Domain Name (always pointer back to name in MDNS) |
| 2527 | 0x00, // Bitmap block number (always 0 in MDNS) |
| 2528 | 0x02, // Bitmap length is 2 |
| 2529 | 0x00, 0x08 // A type only |
| 2530 | }; |
| 2531 | |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 2532 | const uint8_t kMdnsResponseTxt[] = { |
| 2533 | // Header |
| 2534 | 0x00, 0x00, // ID is zeroed out |
| 2535 | 0x81, 0x80, // Standard query response, RA, no error |
| 2536 | 0x00, 0x00, // No questions (for simplicity) |
| 2537 | 0x00, 0x01, // 1 RR (answers) |
| 2538 | 0x00, 0x00, // 0 authority RRs |
| 2539 | 0x00, 0x00, // 0 additional RRs |
| 2540 | |
| 2541 | // "myhello.local." |
| 2542 | 0x07, 'm', 'y', 'h', 'e', 'l', 'l', 'o', 0x05, 'l', 'o', 'c', 'a', 'l', |
| 2543 | 0x00, |
| 2544 | |
| 2545 | 0x00, 0x10, // TYPE is TXT. |
| 2546 | 0x00, 0x01, // CLASS is IN. |
| 2547 | 0x00, 0x00, 0x00, 0x11, // TTL is 17 (seconds) |
| 2548 | 0x00, 0x08, // RDLENGTH is 8 bytes. |
| 2549 | |
| 2550 | // "foo" |
| 2551 | 0x03, 0x66, 0x6f, 0x6f, |
| 2552 | // "bar" |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 2553 | 0x03, 0x62, 0x61, 0x72}; |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 2554 | |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 2555 | const uint8_t kMdnsResponsePtr[] = { |
| 2556 | // Header |
| 2557 | 0x00, 0x00, // ID is zeroed out |
| 2558 | 0x81, 0x80, // Standard query response, RA, no error |
| 2559 | 0x00, 0x00, // No questions (for simplicity) |
| 2560 | 0x00, 0x01, // 1 RR (answers) |
| 2561 | 0x00, 0x00, // 0 authority RRs |
| 2562 | 0x00, 0x00, // 0 additional RRs |
| 2563 | |
| 2564 | // "myhello.local." |
| 2565 | 0x07, 'm', 'y', 'h', 'e', 'l', 'l', 'o', 0x05, 'l', 'o', 'c', 'a', 'l', |
| 2566 | 0x00, |
| 2567 | |
| 2568 | 0x00, 0x0c, // TYPE is PTR. |
| 2569 | 0x00, 0x01, // CLASS is IN. |
| 2570 | 0x00, 0x00, 0x00, 0x12, // TTL is 18 (seconds) |
| 2571 | 0x00, 0x09, // RDLENGTH is 9 bytes. |
| 2572 | |
| 2573 | // "foo.com." |
| 2574 | 0x03, 'f', 'o', 'o', 0x03, 'c', 'o', 'm', 0x00}; |
| 2575 | |
Eric Orth | 026776a | 2019-01-18 00:13:28 | [diff] [blame] | 2576 | const uint8_t kMdnsResponsePtrRoot[] = { |
| 2577 | // Header |
| 2578 | 0x00, 0x00, // ID is zeroed out |
| 2579 | 0x81, 0x80, // Standard query response, RA, no error |
| 2580 | 0x00, 0x00, // No questions (for simplicity) |
| 2581 | 0x00, 0x01, // 1 RR (answers) |
| 2582 | 0x00, 0x00, // 0 authority RRs |
| 2583 | 0x00, 0x00, // 0 additional RRs |
| 2584 | |
| 2585 | // "myhello.local." |
| 2586 | 0x07, 'm', 'y', 'h', 'e', 'l', 'l', 'o', 0x05, 'l', 'o', 'c', 'a', 'l', |
| 2587 | 0x00, |
| 2588 | |
| 2589 | 0x00, 0x0c, // TYPE is PTR. |
| 2590 | 0x00, 0x01, // CLASS is IN. |
| 2591 | 0x00, 0x00, 0x00, 0x13, // TTL is 19 (seconds) |
| 2592 | 0x00, 0x01, // RDLENGTH is 1 byte. |
| 2593 | |
| 2594 | // "." (the root domain) |
| 2595 | 0x00}; |
| 2596 | |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 2597 | const uint8_t kMdnsResponseSrv[] = { |
| 2598 | // Header |
| 2599 | 0x00, 0x00, // ID is zeroed out |
| 2600 | 0x81, 0x80, // Standard query response, RA, no error |
| 2601 | 0x00, 0x00, // No questions (for simplicity) |
| 2602 | 0x00, 0x01, // 1 RR (answers) |
| 2603 | 0x00, 0x00, // 0 authority RRs |
| 2604 | 0x00, 0x00, // 0 additional RRs |
| 2605 | |
| 2606 | // "myhello.local." |
| 2607 | 0x07, 'm', 'y', 'h', 'e', 'l', 'l', 'o', 0x05, 'l', 'o', 'c', 'a', 'l', |
| 2608 | 0x00, |
| 2609 | |
| 2610 | 0x00, 0x21, // TYPE is SRV. |
| 2611 | 0x00, 0x01, // CLASS is IN. |
| 2612 | 0x00, 0x00, 0x00, 0x13, // TTL is 19 (seconds) |
| 2613 | 0x00, 0x0f, // RDLENGTH is 15 bytes. |
| 2614 | |
| 2615 | 0x00, 0x05, // Priority 5 |
| 2616 | 0x00, 0x01, // Weight 1 |
| 2617 | 0x20, 0x49, // Port 8265 |
| 2618 | |
| 2619 | // "foo.com." |
| 2620 | 0x03, 'f', 'o', 'o', 0x03, 'c', 'o', 'm', 0x00}; |
| 2621 | |
Bailey Berro | e70f06c | 2019-03-11 22:22:46 | [diff] [blame] | 2622 | const uint8_t kMdnsResponseSrvUnrestricted[] = { |
| 2623 | // Header |
| 2624 | 0x00, 0x00, // ID is zeroed out |
| 2625 | 0x81, 0x80, // Standard query response, RA, no error |
| 2626 | 0x00, 0x00, // No questions (for simplicity) |
| 2627 | 0x00, 0x01, // 1 RR (answers) |
| 2628 | 0x00, 0x00, // 0 authority RRs |
| 2629 | 0x00, 0x00, // 0 additional RRs |
| 2630 | |
| 2631 | // "foo bar(A1B2)._ipps._tcp.local" |
| 2632 | 0x0d, 'f', 'o', 'o', ' ', 'b', 'a', 'r', '(', 'A', '1', 'B', '2', ')', 0x05, |
| 2633 | '_', 'i', 'p', 'p', 's', 0x04, '_', 't', 'c', 'p', 0x05, 'l', 'o', 'c', 'a', |
| 2634 | 'l', 0x00, |
| 2635 | |
| 2636 | 0x00, 0x21, // TYPE is SRV. |
| 2637 | 0x00, 0x01, // CLASS is IN. |
| 2638 | 0x00, 0x00, 0x00, 0x13, // TTL is 19 (seconds) |
| 2639 | 0x00, 0x0f, // RDLENGTH is 15 bytes. |
| 2640 | |
| 2641 | 0x00, 0x05, // Priority 5 |
| 2642 | 0x00, 0x01, // Weight 1 |
| 2643 | 0x20, 0x49, // Port 8265 |
| 2644 | |
| 2645 | // "foo.com." |
| 2646 | 0x03, 'f', 'o', 'o', 0x03, 'c', 'o', 'm', 0x00}; |
| 2647 | |
| 2648 | const uint8_t kMdnsResponseSrvUnrestrictedResult[] = { |
| 2649 | // Header |
| 2650 | 0x00, 0x00, // ID is zeroed out |
| 2651 | 0x81, 0x80, // Standard query response, RA, no error |
| 2652 | 0x00, 0x00, // No questions (for simplicity) |
| 2653 | 0x00, 0x01, // 1 RR (answers) |
| 2654 | 0x00, 0x00, // 0 authority RRs |
| 2655 | 0x00, 0x00, // 0 additional RRs |
| 2656 | |
| 2657 | // "myhello.local." |
| 2658 | 0x07, 'm', 'y', 'h', 'e', 'l', 'l', 'o', 0x05, 'l', 'o', 'c', 'a', 'l', |
| 2659 | 0x00, |
| 2660 | |
| 2661 | 0x00, 0x21, // TYPE is SRV. |
| 2662 | 0x00, 0x01, // CLASS is IN. |
| 2663 | 0x00, 0x00, 0x00, 0x13, // TTL is 19 (seconds) |
| 2664 | 0x00, 0x15, // RDLENGTH is 21 bytes. |
| 2665 | |
| 2666 | 0x00, 0x05, // Priority 5 |
| 2667 | 0x00, 0x01, // Weight 1 |
| 2668 | 0x20, 0x49, // Port 8265 |
| 2669 | |
| 2670 | // "foo bar.local" |
| 2671 | 0x07, 'f', 'o', 'o', ' ', 'b', 'a', 'r', 0x05, 'l', 'o', 'c', 'a', 'l', |
| 2672 | 0x00}; |
| 2673 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 2674 | TEST_F(HostResolverManagerTest, Mdns) { |
Eric Orth | 9871aafa | 2018-10-02 19:59:18 | [diff] [blame] | 2675 | auto socket_factory = std::make_unique<MockMDnsSocketFactory>(); |
| 2676 | MockMDnsSocketFactory* socket_factory_ptr = socket_factory.get(); |
| 2677 | resolver_->SetMdnsSocketFactoryForTesting(std::move(socket_factory)); |
| 2678 | // 2 socket creations for every transaction. |
| 2679 | EXPECT_CALL(*socket_factory_ptr, OnSendTo(_)).Times(4); |
| 2680 | |
| 2681 | HostResolver::ResolveHostParameters parameters; |
| 2682 | parameters.source = HostResolverSource::MULTICAST_DNS; |
| 2683 | |
| 2684 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 2685 | HostPortPair("myhello.local", 80), NetLogWithSource(), parameters, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2686 | request_context_.get(), host_cache_.get())); |
Eric Orth | 9871aafa | 2018-10-02 19:59:18 | [diff] [blame] | 2687 | |
| 2688 | socket_factory_ptr->SimulateReceive(kMdnsResponseA, sizeof(kMdnsResponseA)); |
| 2689 | socket_factory_ptr->SimulateReceive(kMdnsResponseAAAA, |
| 2690 | sizeof(kMdnsResponseAAAA)); |
| 2691 | |
| 2692 | EXPECT_THAT(response.result_error(), IsOk()); |
| 2693 | EXPECT_THAT( |
| 2694 | response.request()->GetAddressResults().value().endpoints(), |
| 2695 | testing::UnorderedElementsAre( |
| 2696 | CreateExpected("1.2.3.4", 80), |
| 2697 | CreateExpected("000a:0000:0000:0000:0001:0002:0003:0004", 80))); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 2698 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 2699 | EXPECT_FALSE(response.request()->GetHostnameResults()); |
Eric Orth | 9871aafa | 2018-10-02 19:59:18 | [diff] [blame] | 2700 | } |
| 2701 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 2702 | TEST_F(HostResolverManagerTest, Mdns_AaaaOnly) { |
Eric Orth | 9871aafa | 2018-10-02 19:59:18 | [diff] [blame] | 2703 | auto socket_factory = std::make_unique<MockMDnsSocketFactory>(); |
| 2704 | MockMDnsSocketFactory* socket_factory_ptr = socket_factory.get(); |
| 2705 | resolver_->SetMdnsSocketFactoryForTesting(std::move(socket_factory)); |
| 2706 | // 2 socket creations for every transaction. |
| 2707 | EXPECT_CALL(*socket_factory_ptr, OnSendTo(_)).Times(2); |
| 2708 | |
| 2709 | HostResolver::ResolveHostParameters parameters; |
Eric Orth | 192e3bb | 2018-11-14 19:30:32 | [diff] [blame] | 2710 | parameters.dns_query_type = DnsQueryType::AAAA; |
Eric Orth | 9871aafa | 2018-10-02 19:59:18 | [diff] [blame] | 2711 | parameters.source = HostResolverSource::MULTICAST_DNS; |
| 2712 | |
| 2713 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 2714 | HostPortPair("myhello.local", 80), NetLogWithSource(), parameters, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2715 | request_context_.get(), host_cache_.get())); |
Eric Orth | 9871aafa | 2018-10-02 19:59:18 | [diff] [blame] | 2716 | |
| 2717 | socket_factory_ptr->SimulateReceive(kMdnsResponseAAAA, |
| 2718 | sizeof(kMdnsResponseAAAA)); |
| 2719 | |
| 2720 | EXPECT_THAT(response.result_error(), IsOk()); |
| 2721 | EXPECT_THAT(response.request()->GetAddressResults().value().endpoints(), |
| 2722 | testing::ElementsAre(CreateExpected( |
| 2723 | "000a:0000:0000:0000:0001:0002:0003:0004", 80))); |
| 2724 | } |
| 2725 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 2726 | TEST_F(HostResolverManagerTest, Mdns_Txt) { |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 2727 | auto socket_factory = std::make_unique<MockMDnsSocketFactory>(); |
| 2728 | MockMDnsSocketFactory* socket_factory_ptr = socket_factory.get(); |
| 2729 | resolver_->SetMdnsSocketFactoryForTesting(std::move(socket_factory)); |
| 2730 | // 2 socket creations for every transaction. |
| 2731 | EXPECT_CALL(*socket_factory_ptr, OnSendTo(_)).Times(2); |
| 2732 | |
| 2733 | HostResolver::ResolveHostParameters parameters; |
| 2734 | parameters.dns_query_type = DnsQueryType::TXT; |
| 2735 | parameters.source = HostResolverSource::MULTICAST_DNS; |
| 2736 | |
| 2737 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 2738 | HostPortPair("myhello.local", 80), NetLogWithSource(), parameters, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2739 | request_context_.get(), host_cache_.get())); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 2740 | |
| 2741 | socket_factory_ptr->SimulateReceive(kMdnsResponseTxt, |
| 2742 | sizeof(kMdnsResponseTxt)); |
| 2743 | |
| 2744 | EXPECT_THAT(response.result_error(), IsOk()); |
| 2745 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 2746 | EXPECT_THAT(response.request()->GetTextResults(), |
| 2747 | testing::Optional(testing::ElementsAre("foo", "bar"))); |
| 2748 | EXPECT_FALSE(response.request()->GetHostnameResults()); |
| 2749 | } |
| 2750 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 2751 | TEST_F(HostResolverManagerTest, Mdns_Ptr) { |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 2752 | auto socket_factory = std::make_unique<MockMDnsSocketFactory>(); |
| 2753 | MockMDnsSocketFactory* socket_factory_ptr = socket_factory.get(); |
| 2754 | resolver_->SetMdnsSocketFactoryForTesting(std::move(socket_factory)); |
| 2755 | // 2 socket creations for every transaction. |
| 2756 | EXPECT_CALL(*socket_factory_ptr, OnSendTo(_)).Times(2); |
| 2757 | |
| 2758 | HostResolver::ResolveHostParameters parameters; |
| 2759 | parameters.dns_query_type = DnsQueryType::PTR; |
| 2760 | parameters.source = HostResolverSource::MULTICAST_DNS; |
| 2761 | |
| 2762 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 2763 | HostPortPair("myhello.local", 83), NetLogWithSource(), parameters, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2764 | request_context_.get(), host_cache_.get())); |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 2765 | |
| 2766 | socket_factory_ptr->SimulateReceive(kMdnsResponsePtr, |
| 2767 | sizeof(kMdnsResponsePtr)); |
| 2768 | |
| 2769 | EXPECT_THAT(response.result_error(), IsOk()); |
| 2770 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 2771 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 2772 | EXPECT_THAT( |
| 2773 | response.request()->GetHostnameResults(), |
| 2774 | testing::Optional(testing::ElementsAre(HostPortPair("foo.com", 83)))); |
| 2775 | } |
| 2776 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 2777 | TEST_F(HostResolverManagerTest, Mdns_Srv) { |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 2778 | auto socket_factory = std::make_unique<MockMDnsSocketFactory>(); |
| 2779 | MockMDnsSocketFactory* socket_factory_ptr = socket_factory.get(); |
| 2780 | resolver_->SetMdnsSocketFactoryForTesting(std::move(socket_factory)); |
| 2781 | // 2 socket creations for every transaction. |
| 2782 | EXPECT_CALL(*socket_factory_ptr, OnSendTo(_)).Times(2); |
| 2783 | |
| 2784 | HostResolver::ResolveHostParameters parameters; |
| 2785 | parameters.dns_query_type = DnsQueryType::SRV; |
| 2786 | parameters.source = HostResolverSource::MULTICAST_DNS; |
| 2787 | |
| 2788 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 2789 | HostPortPair("myhello.local", 83), NetLogWithSource(), parameters, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2790 | request_context_.get(), host_cache_.get())); |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 2791 | |
| 2792 | socket_factory_ptr->SimulateReceive(kMdnsResponseSrv, |
| 2793 | sizeof(kMdnsResponseSrv)); |
| 2794 | |
| 2795 | EXPECT_THAT(response.result_error(), IsOk()); |
| 2796 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 2797 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 2798 | EXPECT_THAT( |
| 2799 | response.request()->GetHostnameResults(), |
| 2800 | testing::Optional(testing::ElementsAre(HostPortPair("foo.com", 8265)))); |
| 2801 | } |
| 2802 | |
Bailey Berro | e70f06c | 2019-03-11 22:22:46 | [diff] [blame] | 2803 | // Test that we are able to create multicast DNS requests that contain |
| 2804 | // characters not permitted in the DNS spec such as spaces and parenthesis. |
| 2805 | TEST_F(HostResolverManagerTest, Mdns_Srv_Unrestricted) { |
| 2806 | auto socket_factory = std::make_unique<MockMDnsSocketFactory>(); |
| 2807 | MockMDnsSocketFactory* socket_factory_ptr = socket_factory.get(); |
| 2808 | resolver_->SetMdnsSocketFactoryForTesting(std::move(socket_factory)); |
| 2809 | |
| 2810 | HostResolver::ResolveHostParameters parameters; |
| 2811 | parameters.dns_query_type = DnsQueryType::SRV; |
| 2812 | parameters.source = HostResolverSource::MULTICAST_DNS; |
| 2813 | |
| 2814 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 2815 | HostPortPair("foo bar(A1B2)._ipps._tcp.local", 83), NetLogWithSource(), |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2816 | parameters, request_context_.get(), host_cache_.get())); |
Bailey Berro | e70f06c | 2019-03-11 22:22:46 | [diff] [blame] | 2817 | |
| 2818 | socket_factory_ptr->SimulateReceive(kMdnsResponseSrvUnrestricted, |
| 2819 | sizeof(kMdnsResponseSrvUnrestricted)); |
| 2820 | |
| 2821 | EXPECT_THAT(response.result_error(), IsOk()); |
| 2822 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 2823 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 2824 | EXPECT_THAT( |
| 2825 | response.request()->GetHostnameResults(), |
| 2826 | testing::Optional(testing::ElementsAre(HostPortPair("foo.com", 8265)))); |
| 2827 | } |
| 2828 | |
| 2829 | // Test that we are able to create multicast DNS requests that contain |
| 2830 | // characters not permitted in the DNS spec such as spaces and parenthesis. |
| 2831 | TEST_F(HostResolverManagerTest, Mdns_Srv_Result_Unrestricted) { |
| 2832 | auto socket_factory = std::make_unique<MockMDnsSocketFactory>(); |
| 2833 | MockMDnsSocketFactory* socket_factory_ptr = socket_factory.get(); |
| 2834 | resolver_->SetMdnsSocketFactoryForTesting(std::move(socket_factory)); |
| 2835 | |
| 2836 | HostResolver::ResolveHostParameters parameters; |
| 2837 | parameters.dns_query_type = DnsQueryType::SRV; |
| 2838 | parameters.source = HostResolverSource::MULTICAST_DNS; |
| 2839 | |
| 2840 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 2841 | HostPortPair("myhello.local", 83), NetLogWithSource(), parameters, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2842 | request_context_.get(), host_cache_.get())); |
Bailey Berro | e70f06c | 2019-03-11 22:22:46 | [diff] [blame] | 2843 | |
| 2844 | socket_factory_ptr->SimulateReceive( |
| 2845 | kMdnsResponseSrvUnrestrictedResult, |
| 2846 | sizeof(kMdnsResponseSrvUnrestrictedResult)); |
| 2847 | |
| 2848 | EXPECT_THAT(response.result_error(), IsOk()); |
| 2849 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 2850 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 2851 | EXPECT_THAT(response.request()->GetHostnameResults(), |
| 2852 | testing::Optional( |
| 2853 | testing::ElementsAre(HostPortPair("foo bar.local", 8265)))); |
| 2854 | } |
| 2855 | |
Eric Orth | 9871aafa | 2018-10-02 19:59:18 | [diff] [blame] | 2856 | // Test multicast DNS handling of NSEC responses (used for explicit negative |
| 2857 | // response). |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 2858 | TEST_F(HostResolverManagerTest, Mdns_Nsec) { |
Eric Orth | 9871aafa | 2018-10-02 19:59:18 | [diff] [blame] | 2859 | auto socket_factory = std::make_unique<MockMDnsSocketFactory>(); |
| 2860 | MockMDnsSocketFactory* socket_factory_ptr = socket_factory.get(); |
| 2861 | resolver_->SetMdnsSocketFactoryForTesting(std::move(socket_factory)); |
| 2862 | // 2 socket creations for every transaction. |
| 2863 | EXPECT_CALL(*socket_factory_ptr, OnSendTo(_)).Times(2); |
| 2864 | |
| 2865 | HostResolver::ResolveHostParameters parameters; |
Eric Orth | 192e3bb | 2018-11-14 19:30:32 | [diff] [blame] | 2866 | parameters.dns_query_type = DnsQueryType::AAAA; |
Eric Orth | 9871aafa | 2018-10-02 19:59:18 | [diff] [blame] | 2867 | parameters.source = HostResolverSource::MULTICAST_DNS; |
| 2868 | |
| 2869 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 2870 | HostPortPair("myhello.local", 80), NetLogWithSource(), parameters, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2871 | request_context_.get(), host_cache_.get())); |
Eric Orth | 9871aafa | 2018-10-02 19:59:18 | [diff] [blame] | 2872 | |
| 2873 | socket_factory_ptr->SimulateReceive(kMdnsResponseNsec, |
| 2874 | sizeof(kMdnsResponseNsec)); |
| 2875 | |
| 2876 | EXPECT_THAT(response.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 2877 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 2878 | } |
| 2879 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 2880 | TEST_F(HostResolverManagerTest, Mdns_NoResponse) { |
Eric Orth | 9871aafa | 2018-10-02 19:59:18 | [diff] [blame] | 2881 | auto socket_factory = std::make_unique<MockMDnsSocketFactory>(); |
| 2882 | MockMDnsSocketFactory* socket_factory_ptr = socket_factory.get(); |
| 2883 | resolver_->SetMdnsSocketFactoryForTesting(std::move(socket_factory)); |
| 2884 | // 2 socket creations for every transaction. |
| 2885 | EXPECT_CALL(*socket_factory_ptr, OnSendTo(_)).Times(4); |
| 2886 | |
| 2887 | // Add a little bit of extra fudge to the delay to allow reasonable |
| 2888 | // flexibility for time > vs >= etc. We don't need to fail the test if we |
| 2889 | // timeout at t=6001 instead of t=6000. |
| 2890 | base::TimeDelta kSleepFudgeFactor = base::TimeDelta::FromMilliseconds(1); |
| 2891 | |
| 2892 | // Override the current thread task runner, so we can simulate the passage of |
| 2893 | // time to trigger the timeout. |
| 2894 | auto test_task_runner = base::MakeRefCounted<base::TestMockTimeTaskRunner>(); |
| 2895 | base::ScopedClosureRunner task_runner_override_scoped_cleanup = |
| 2896 | base::ThreadTaskRunnerHandle::OverrideForTesting(test_task_runner); |
| 2897 | |
| 2898 | HostResolver::ResolveHostParameters parameters; |
| 2899 | parameters.source = HostResolverSource::MULTICAST_DNS; |
| 2900 | |
| 2901 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 2902 | HostPortPair("myhello.local", 80), NetLogWithSource(), parameters, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2903 | request_context_.get(), host_cache_.get())); |
Eric Orth | 9871aafa | 2018-10-02 19:59:18 | [diff] [blame] | 2904 | |
| 2905 | ASSERT_TRUE(test_task_runner->HasPendingTask()); |
| 2906 | test_task_runner->FastForwardBy(MDnsTransaction::kTransactionTimeout + |
| 2907 | kSleepFudgeFactor); |
| 2908 | |
| 2909 | EXPECT_THAT(response.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 2910 | EXPECT_FALSE(response.request()->GetAddressResults()); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 2911 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 2912 | EXPECT_FALSE(response.request()->GetHostnameResults()); |
| 2913 | |
| 2914 | test_task_runner->FastForwardUntilNoTasksRemain(); |
| 2915 | } |
| 2916 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 2917 | TEST_F(HostResolverManagerTest, Mdns_WrongType) { |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 2918 | auto socket_factory = std::make_unique<MockMDnsSocketFactory>(); |
| 2919 | MockMDnsSocketFactory* socket_factory_ptr = socket_factory.get(); |
| 2920 | resolver_->SetMdnsSocketFactoryForTesting(std::move(socket_factory)); |
| 2921 | // 2 socket creations for every transaction. |
| 2922 | EXPECT_CALL(*socket_factory_ptr, OnSendTo(_)).Times(2); |
| 2923 | |
| 2924 | // Add a little bit of extra fudge to the delay to allow reasonable |
| 2925 | // flexibility for time > vs >= etc. We don't need to fail the test if we |
| 2926 | // timeout at t=6001 instead of t=6000. |
| 2927 | base::TimeDelta kSleepFudgeFactor = base::TimeDelta::FromMilliseconds(1); |
| 2928 | |
| 2929 | // Override the current thread task runner, so we can simulate the passage of |
| 2930 | // time to trigger the timeout. |
| 2931 | auto test_task_runner = base::MakeRefCounted<base::TestMockTimeTaskRunner>(); |
| 2932 | base::ScopedClosureRunner task_runner_override_scoped_cleanup = |
| 2933 | base::ThreadTaskRunnerHandle::OverrideForTesting(test_task_runner); |
| 2934 | |
| 2935 | HostResolver::ResolveHostParameters parameters; |
| 2936 | parameters.dns_query_type = DnsQueryType::A; |
| 2937 | parameters.source = HostResolverSource::MULTICAST_DNS; |
| 2938 | |
| 2939 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 2940 | HostPortPair("myhello.local", 80), NetLogWithSource(), parameters, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2941 | request_context_.get(), host_cache_.get())); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 2942 | |
| 2943 | // Not the requested type. Should be ignored. |
| 2944 | socket_factory_ptr->SimulateReceive(kMdnsResponseTxt, |
| 2945 | sizeof(kMdnsResponseTxt)); |
| 2946 | |
| 2947 | ASSERT_TRUE(test_task_runner->HasPendingTask()); |
| 2948 | test_task_runner->FastForwardBy(MDnsTransaction::kTransactionTimeout + |
| 2949 | kSleepFudgeFactor); |
| 2950 | |
| 2951 | EXPECT_THAT(response.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 2952 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 2953 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 2954 | EXPECT_FALSE(response.request()->GetHostnameResults()); |
Eric Orth | 9871aafa | 2018-10-02 19:59:18 | [diff] [blame] | 2955 | |
| 2956 | test_task_runner->FastForwardUntilNoTasksRemain(); |
| 2957 | } |
| 2958 | |
| 2959 | // Test for a request for both A and AAAA results where results only exist for |
| 2960 | // one type. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 2961 | TEST_F(HostResolverManagerTest, Mdns_PartialResults) { |
Eric Orth | 9871aafa | 2018-10-02 19:59:18 | [diff] [blame] | 2962 | auto socket_factory = std::make_unique<MockMDnsSocketFactory>(); |
| 2963 | MockMDnsSocketFactory* socket_factory_ptr = socket_factory.get(); |
| 2964 | resolver_->SetMdnsSocketFactoryForTesting(std::move(socket_factory)); |
| 2965 | // 2 socket creations for every transaction. |
| 2966 | EXPECT_CALL(*socket_factory_ptr, OnSendTo(_)).Times(4); |
| 2967 | |
| 2968 | // Add a little bit of extra fudge to the delay to allow reasonable |
| 2969 | // flexibility for time > vs >= etc. We don't need to fail the test if we |
| 2970 | // timeout at t=6001 instead of t=6000. |
| 2971 | base::TimeDelta kSleepFudgeFactor = base::TimeDelta::FromMilliseconds(1); |
| 2972 | |
| 2973 | // Override the current thread task runner, so we can simulate the passage of |
| 2974 | // time to trigger the timeout. |
| 2975 | auto test_task_runner = base::MakeRefCounted<base::TestMockTimeTaskRunner>(); |
| 2976 | base::ScopedClosureRunner task_runner_override_scoped_cleanup = |
| 2977 | base::ThreadTaskRunnerHandle::OverrideForTesting(test_task_runner); |
| 2978 | |
| 2979 | HostResolver::ResolveHostParameters parameters; |
| 2980 | parameters.source = HostResolverSource::MULTICAST_DNS; |
| 2981 | |
| 2982 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 2983 | HostPortPair("myhello.local", 80), NetLogWithSource(), parameters, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2984 | request_context_.get(), host_cache_.get())); |
Eric Orth | 9871aafa | 2018-10-02 19:59:18 | [diff] [blame] | 2985 | |
| 2986 | ASSERT_TRUE(test_task_runner->HasPendingTask()); |
| 2987 | |
| 2988 | socket_factory_ptr->SimulateReceive(kMdnsResponseA, sizeof(kMdnsResponseA)); |
| 2989 | test_task_runner->FastForwardBy(MDnsTransaction::kTransactionTimeout + |
| 2990 | kSleepFudgeFactor); |
| 2991 | |
| 2992 | EXPECT_THAT(response.result_error(), IsOk()); |
| 2993 | EXPECT_THAT(response.request()->GetAddressResults().value().endpoints(), |
| 2994 | testing::ElementsAre(CreateExpected("1.2.3.4", 80))); |
| 2995 | |
| 2996 | test_task_runner->FastForwardUntilNoTasksRemain(); |
| 2997 | } |
| 2998 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 2999 | TEST_F(HostResolverManagerTest, Mdns_Cancel) { |
Eric Orth | 9871aafa | 2018-10-02 19:59:18 | [diff] [blame] | 3000 | auto socket_factory = std::make_unique<MockMDnsSocketFactory>(); |
| 3001 | MockMDnsSocketFactory* socket_factory_ptr = socket_factory.get(); |
| 3002 | resolver_->SetMdnsSocketFactoryForTesting(std::move(socket_factory)); |
| 3003 | // 2 socket creations for every transaction. |
| 3004 | EXPECT_CALL(*socket_factory_ptr, OnSendTo(_)).Times(4); |
| 3005 | |
| 3006 | HostResolver::ResolveHostParameters parameters; |
| 3007 | parameters.source = HostResolverSource::MULTICAST_DNS; |
| 3008 | |
| 3009 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 3010 | HostPortPair("myhello.local", 80), NetLogWithSource(), parameters, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 3011 | request_context_.get(), host_cache_.get())); |
Eric Orth | 9871aafa | 2018-10-02 19:59:18 | [diff] [blame] | 3012 | |
| 3013 | response.CancelRequest(); |
| 3014 | |
| 3015 | socket_factory_ptr->SimulateReceive(kMdnsResponseA, sizeof(kMdnsResponseA)); |
| 3016 | socket_factory_ptr->SimulateReceive(kMdnsResponseAAAA, |
| 3017 | sizeof(kMdnsResponseAAAA)); |
| 3018 | |
| 3019 | base::RunLoop().RunUntilIdle(); |
| 3020 | EXPECT_FALSE(response.complete()); |
| 3021 | } |
| 3022 | |
| 3023 | // Test for a two-transaction query where the first fails to start. The second |
| 3024 | // should be cancelled. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 3025 | TEST_F(HostResolverManagerTest, Mdns_PartialFailure) { |
Eric Orth | 9871aafa | 2018-10-02 19:59:18 | [diff] [blame] | 3026 | // Setup a mock MDnsClient where the first transaction will always return |
| 3027 | // |false| immediately on Start(). Second transaction may or may not be |
| 3028 | // created, but if it is, Start() not expected to be called because the |
| 3029 | // overall request should immediately fail. |
| 3030 | auto transaction1 = std::make_unique<MockMDnsTransaction>(); |
| 3031 | EXPECT_CALL(*transaction1, Start()).WillOnce(Return(false)); |
| 3032 | auto transaction2 = std::make_unique<MockMDnsTransaction>(); |
| 3033 | EXPECT_CALL(*transaction2, Start()).Times(0); |
| 3034 | |
| 3035 | auto client = std::make_unique<MockMDnsClient>(); |
| 3036 | EXPECT_CALL(*client, CreateTransaction(_, _, _, _)) |
| 3037 | .Times(Between(1, 2)) // Second transaction optionally created. |
| 3038 | .WillOnce(Return(ByMove(std::move(transaction1)))) |
| 3039 | .WillOnce(Return(ByMove(std::move(transaction2)))); |
| 3040 | EXPECT_CALL(*client, IsListening()).WillRepeatedly(Return(true)); |
| 3041 | resolver_->SetMdnsClientForTesting(std::move(client)); |
| 3042 | |
| 3043 | HostResolver::ResolveHostParameters parameters; |
| 3044 | parameters.source = HostResolverSource::MULTICAST_DNS; |
| 3045 | |
| 3046 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 3047 | HostPortPair("myhello.local", 80), NetLogWithSource(), parameters, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 3048 | request_context_.get(), host_cache_.get())); |
Eric Orth | 9871aafa | 2018-10-02 19:59:18 | [diff] [blame] | 3049 | |
| 3050 | EXPECT_THAT(response.result_error(), IsError(ERR_FAILED)); |
| 3051 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 3052 | } |
Eric Orth | 026776a | 2019-01-18 00:13:28 | [diff] [blame] | 3053 | |
Eric Orth | e857ebb | 2019-03-13 23:02:07 | [diff] [blame] | 3054 | TEST_F(HostResolverManagerTest, Mdns_ListenFailure) { |
| 3055 | // Inject an MdnsClient mock that will always fail to start listening. |
| 3056 | auto client = std::make_unique<MockMDnsClient>(); |
| 3057 | EXPECT_CALL(*client, StartListening(_)).WillOnce(Return(ERR_FAILED)); |
| 3058 | EXPECT_CALL(*client, IsListening()).WillRepeatedly(Return(false)); |
| 3059 | resolver_->SetMdnsClientForTesting(std::move(client)); |
| 3060 | |
| 3061 | HostResolver::ResolveHostParameters parameters; |
| 3062 | parameters.source = HostResolverSource::MULTICAST_DNS; |
| 3063 | |
| 3064 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 3065 | HostPortPair("myhello.local", 80), NetLogWithSource(), parameters, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 3066 | request_context_.get(), host_cache_.get())); |
Eric Orth | e857ebb | 2019-03-13 23:02:07 | [diff] [blame] | 3067 | |
| 3068 | EXPECT_THAT(response.result_error(), IsError(ERR_FAILED)); |
| 3069 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 3070 | } |
| 3071 | |
Eric Orth | 026776a | 2019-01-18 00:13:28 | [diff] [blame] | 3072 | // Implementation of HostResolver::MdnsListenerDelegate that records all |
| 3073 | // received results in maps. |
| 3074 | class TestMdnsListenerDelegate : public HostResolver::MdnsListener::Delegate { |
| 3075 | public: |
| 3076 | using UpdateKey = |
| 3077 | std::pair<HostResolver::MdnsListener::Delegate::UpdateType, DnsQueryType>; |
| 3078 | |
| 3079 | void OnAddressResult( |
| 3080 | HostResolver::MdnsListener::Delegate::UpdateType update_type, |
| 3081 | DnsQueryType result_type, |
| 3082 | IPEndPoint address) override { |
| 3083 | address_results_.insert({{update_type, result_type}, std::move(address)}); |
| 3084 | } |
| 3085 | |
| 3086 | void OnTextResult( |
| 3087 | HostResolver::MdnsListener::Delegate::UpdateType update_type, |
| 3088 | DnsQueryType result_type, |
| 3089 | std::vector<std::string> text_records) override { |
| 3090 | for (auto& text_record : text_records) { |
| 3091 | text_results_.insert( |
| 3092 | {{update_type, result_type}, std::move(text_record)}); |
| 3093 | } |
| 3094 | } |
| 3095 | |
| 3096 | void OnHostnameResult( |
| 3097 | HostResolver::MdnsListener::Delegate::UpdateType update_type, |
| 3098 | DnsQueryType result_type, |
| 3099 | HostPortPair host) override { |
| 3100 | hostname_results_.insert({{update_type, result_type}, std::move(host)}); |
| 3101 | } |
| 3102 | |
| 3103 | void OnUnhandledResult( |
| 3104 | HostResolver::MdnsListener::Delegate::UpdateType update_type, |
| 3105 | DnsQueryType result_type) override { |
| 3106 | unhandled_results_.insert({update_type, result_type}); |
| 3107 | } |
| 3108 | |
| 3109 | const std::multimap<UpdateKey, IPEndPoint>& address_results() { |
| 3110 | return address_results_; |
| 3111 | } |
| 3112 | |
| 3113 | const std::multimap<UpdateKey, std::string>& text_results() { |
| 3114 | return text_results_; |
| 3115 | } |
| 3116 | |
| 3117 | const std::multimap<UpdateKey, HostPortPair>& hostname_results() { |
| 3118 | return hostname_results_; |
| 3119 | } |
| 3120 | |
| 3121 | const std::multiset<UpdateKey>& unhandled_results() { |
| 3122 | return unhandled_results_; |
| 3123 | } |
| 3124 | |
| 3125 | template <typename T> |
| 3126 | static std::pair<UpdateKey, T> CreateExpectedResult( |
| 3127 | HostResolver::MdnsListener::Delegate::UpdateType update_type, |
| 3128 | DnsQueryType query_type, |
| 3129 | T result) { |
| 3130 | return std::make_pair(std::make_pair(update_type, query_type), result); |
| 3131 | } |
| 3132 | |
| 3133 | private: |
| 3134 | std::multimap<UpdateKey, IPEndPoint> address_results_; |
| 3135 | std::multimap<UpdateKey, std::string> text_results_; |
| 3136 | std::multimap<UpdateKey, HostPortPair> hostname_results_; |
| 3137 | std::multiset<UpdateKey> unhandled_results_; |
| 3138 | }; |
| 3139 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 3140 | TEST_F(HostResolverManagerTest, MdnsListener) { |
Eric Orth | 026776a | 2019-01-18 00:13:28 | [diff] [blame] | 3141 | auto socket_factory = std::make_unique<MockMDnsSocketFactory>(); |
| 3142 | base::SimpleTestClock clock; |
| 3143 | clock.SetNow(base::Time::Now()); |
| 3144 | auto cache_cleanup_timer = std::make_unique<base::MockOneShotTimer>(); |
| 3145 | auto* cache_cleanup_timer_ptr = cache_cleanup_timer.get(); |
| 3146 | auto mdns_client = |
| 3147 | std::make_unique<MDnsClientImpl>(&clock, std::move(cache_cleanup_timer)); |
Eric Orth | e857ebb | 2019-03-13 23:02:07 | [diff] [blame] | 3148 | ASSERT_THAT(mdns_client->StartListening(socket_factory.get()), IsOk()); |
Eric Orth | 026776a | 2019-01-18 00:13:28 | [diff] [blame] | 3149 | resolver_->SetMdnsClientForTesting(std::move(mdns_client)); |
| 3150 | |
| 3151 | std::unique_ptr<HostResolver::MdnsListener> listener = |
| 3152 | resolver_->CreateMdnsListener(HostPortPair("myhello.local", 80), |
| 3153 | DnsQueryType::A); |
| 3154 | |
| 3155 | TestMdnsListenerDelegate delegate; |
| 3156 | ASSERT_THAT(listener->Start(&delegate), IsOk()); |
| 3157 | ASSERT_THAT(delegate.address_results(), testing::IsEmpty()); |
| 3158 | |
| 3159 | socket_factory->SimulateReceive(kMdnsResponseA, sizeof(kMdnsResponseA)); |
| 3160 | socket_factory->SimulateReceive(kMdnsResponseA2, sizeof(kMdnsResponseA2)); |
| 3161 | socket_factory->SimulateReceive(kMdnsResponseA2Goodbye, |
| 3162 | sizeof(kMdnsResponseA2Goodbye)); |
| 3163 | |
| 3164 | // Per RFC6762 section 10.1, removals take effect 1 second after receiving the |
| 3165 | // goodbye message. |
| 3166 | clock.Advance(base::TimeDelta::FromSeconds(1)); |
| 3167 | cache_cleanup_timer_ptr->Fire(); |
| 3168 | |
| 3169 | // Expect 1 record adding "1.2.3.4", another changing to "5.6.7.8", and a |
| 3170 | // final removing "5.6.7.8". |
| 3171 | EXPECT_THAT(delegate.address_results(), |
| 3172 | testing::ElementsAre( |
| 3173 | TestMdnsListenerDelegate::CreateExpectedResult( |
| 3174 | HostResolver::MdnsListener::Delegate::UpdateType::ADDED, |
| 3175 | DnsQueryType::A, CreateExpected("1.2.3.4", 80)), |
| 3176 | TestMdnsListenerDelegate::CreateExpectedResult( |
| 3177 | HostResolver::MdnsListener::Delegate::UpdateType::CHANGED, |
| 3178 | DnsQueryType::A, CreateExpected("5.6.7.8", 80)), |
| 3179 | TestMdnsListenerDelegate::CreateExpectedResult( |
| 3180 | HostResolver::MdnsListener::Delegate::UpdateType::REMOVED, |
| 3181 | DnsQueryType::A, CreateExpected("5.6.7.8", 80)))); |
| 3182 | |
| 3183 | EXPECT_THAT(delegate.text_results(), testing::IsEmpty()); |
| 3184 | EXPECT_THAT(delegate.hostname_results(), testing::IsEmpty()); |
| 3185 | EXPECT_THAT(delegate.unhandled_results(), testing::IsEmpty()); |
| 3186 | } |
| 3187 | |
Eric Orth | e857ebb | 2019-03-13 23:02:07 | [diff] [blame] | 3188 | TEST_F(HostResolverManagerTest, MdnsListener_StartListenFailure) { |
| 3189 | // Inject an MdnsClient mock that will always fail to start listening. |
| 3190 | auto client = std::make_unique<MockMDnsClient>(); |
| 3191 | EXPECT_CALL(*client, StartListening(_)).WillOnce(Return(ERR_TIMED_OUT)); |
| 3192 | EXPECT_CALL(*client, IsListening()).WillRepeatedly(Return(false)); |
| 3193 | resolver_->SetMdnsClientForTesting(std::move(client)); |
| 3194 | |
| 3195 | std::unique_ptr<HostResolver::MdnsListener> listener = |
| 3196 | resolver_->CreateMdnsListener(HostPortPair("myhello.local", 80), |
| 3197 | DnsQueryType::A); |
| 3198 | TestMdnsListenerDelegate delegate; |
| 3199 | EXPECT_THAT(listener->Start(&delegate), IsError(ERR_TIMED_OUT)); |
| 3200 | EXPECT_THAT(delegate.address_results(), testing::IsEmpty()); |
| 3201 | } |
| 3202 | |
Eric Orth | 026776a | 2019-01-18 00:13:28 | [diff] [blame] | 3203 | // Test that removal notifications are sent on natural expiration of MDNS |
| 3204 | // records. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 3205 | TEST_F(HostResolverManagerTest, MdnsListener_Expiration) { |
Eric Orth | 026776a | 2019-01-18 00:13:28 | [diff] [blame] | 3206 | auto socket_factory = std::make_unique<MockMDnsSocketFactory>(); |
| 3207 | base::SimpleTestClock clock; |
| 3208 | clock.SetNow(base::Time::Now()); |
| 3209 | auto cache_cleanup_timer = std::make_unique<base::MockOneShotTimer>(); |
| 3210 | auto* cache_cleanup_timer_ptr = cache_cleanup_timer.get(); |
| 3211 | auto mdns_client = |
| 3212 | std::make_unique<MDnsClientImpl>(&clock, std::move(cache_cleanup_timer)); |
Eric Orth | e857ebb | 2019-03-13 23:02:07 | [diff] [blame] | 3213 | ASSERT_THAT(mdns_client->StartListening(socket_factory.get()), IsOk()); |
Eric Orth | 026776a | 2019-01-18 00:13:28 | [diff] [blame] | 3214 | resolver_->SetMdnsClientForTesting(std::move(mdns_client)); |
| 3215 | |
| 3216 | std::unique_ptr<HostResolver::MdnsListener> listener = |
| 3217 | resolver_->CreateMdnsListener(HostPortPair("myhello.local", 100), |
| 3218 | DnsQueryType::A); |
| 3219 | |
| 3220 | TestMdnsListenerDelegate delegate; |
| 3221 | ASSERT_THAT(listener->Start(&delegate), IsOk()); |
| 3222 | ASSERT_THAT(delegate.address_results(), testing::IsEmpty()); |
| 3223 | |
| 3224 | socket_factory->SimulateReceive(kMdnsResponseA, sizeof(kMdnsResponseA)); |
| 3225 | |
| 3226 | EXPECT_THAT( |
| 3227 | delegate.address_results(), |
| 3228 | testing::ElementsAre(TestMdnsListenerDelegate::CreateExpectedResult( |
| 3229 | HostResolver::MdnsListener::Delegate::UpdateType::ADDED, |
| 3230 | DnsQueryType::A, CreateExpected("1.2.3.4", 100)))); |
| 3231 | |
| 3232 | clock.Advance(base::TimeDelta::FromSeconds(16)); |
| 3233 | cache_cleanup_timer_ptr->Fire(); |
| 3234 | |
| 3235 | EXPECT_THAT(delegate.address_results(), |
| 3236 | testing::ElementsAre( |
| 3237 | TestMdnsListenerDelegate::CreateExpectedResult( |
| 3238 | HostResolver::MdnsListener::Delegate::UpdateType::ADDED, |
| 3239 | DnsQueryType::A, CreateExpected("1.2.3.4", 100)), |
| 3240 | TestMdnsListenerDelegate::CreateExpectedResult( |
| 3241 | HostResolver::MdnsListener::Delegate::UpdateType::REMOVED, |
| 3242 | DnsQueryType::A, CreateExpected("1.2.3.4", 100)))); |
| 3243 | |
| 3244 | EXPECT_THAT(delegate.text_results(), testing::IsEmpty()); |
| 3245 | EXPECT_THAT(delegate.hostname_results(), testing::IsEmpty()); |
| 3246 | EXPECT_THAT(delegate.unhandled_results(), testing::IsEmpty()); |
| 3247 | } |
| 3248 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 3249 | TEST_F(HostResolverManagerTest, MdnsListener_Txt) { |
Eric Orth | 026776a | 2019-01-18 00:13:28 | [diff] [blame] | 3250 | auto socket_factory = std::make_unique<MockMDnsSocketFactory>(); |
| 3251 | MockMDnsSocketFactory* socket_factory_ptr = socket_factory.get(); |
| 3252 | resolver_->SetMdnsSocketFactoryForTesting(std::move(socket_factory)); |
| 3253 | |
| 3254 | std::unique_ptr<HostResolver::MdnsListener> listener = |
| 3255 | resolver_->CreateMdnsListener(HostPortPair("myhello.local", 12), |
| 3256 | DnsQueryType::TXT); |
| 3257 | |
| 3258 | TestMdnsListenerDelegate delegate; |
| 3259 | ASSERT_THAT(listener->Start(&delegate), IsOk()); |
| 3260 | ASSERT_THAT(delegate.text_results(), testing::IsEmpty()); |
| 3261 | |
| 3262 | socket_factory_ptr->SimulateReceive(kMdnsResponseTxt, |
| 3263 | sizeof(kMdnsResponseTxt)); |
| 3264 | |
| 3265 | EXPECT_THAT(delegate.text_results(), |
| 3266 | testing::ElementsAre( |
| 3267 | TestMdnsListenerDelegate::CreateExpectedResult( |
| 3268 | HostResolver::MdnsListener::Delegate::UpdateType::ADDED, |
| 3269 | DnsQueryType::TXT, "foo"), |
| 3270 | TestMdnsListenerDelegate::CreateExpectedResult( |
| 3271 | HostResolver::MdnsListener::Delegate::UpdateType::ADDED, |
| 3272 | DnsQueryType::TXT, "bar"))); |
| 3273 | |
| 3274 | EXPECT_THAT(delegate.address_results(), testing::IsEmpty()); |
| 3275 | EXPECT_THAT(delegate.hostname_results(), testing::IsEmpty()); |
| 3276 | EXPECT_THAT(delegate.unhandled_results(), testing::IsEmpty()); |
| 3277 | } |
| 3278 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 3279 | TEST_F(HostResolverManagerTest, MdnsListener_Ptr) { |
Eric Orth | 026776a | 2019-01-18 00:13:28 | [diff] [blame] | 3280 | auto socket_factory = std::make_unique<MockMDnsSocketFactory>(); |
| 3281 | MockMDnsSocketFactory* socket_factory_ptr = socket_factory.get(); |
| 3282 | resolver_->SetMdnsSocketFactoryForTesting(std::move(socket_factory)); |
| 3283 | |
| 3284 | std::unique_ptr<HostResolver::MdnsListener> listener = |
| 3285 | resolver_->CreateMdnsListener(HostPortPair("myhello.local", 13), |
| 3286 | DnsQueryType::PTR); |
| 3287 | |
| 3288 | TestMdnsListenerDelegate delegate; |
| 3289 | ASSERT_THAT(listener->Start(&delegate), IsOk()); |
| 3290 | ASSERT_THAT(delegate.text_results(), testing::IsEmpty()); |
| 3291 | |
| 3292 | socket_factory_ptr->SimulateReceive(kMdnsResponsePtr, |
| 3293 | sizeof(kMdnsResponsePtr)); |
| 3294 | |
| 3295 | EXPECT_THAT( |
| 3296 | delegate.hostname_results(), |
| 3297 | testing::ElementsAre(TestMdnsListenerDelegate::CreateExpectedResult( |
| 3298 | HostResolver::MdnsListener::Delegate::UpdateType::ADDED, |
| 3299 | DnsQueryType::PTR, HostPortPair("foo.com", 13)))); |
| 3300 | |
| 3301 | EXPECT_THAT(delegate.address_results(), testing::IsEmpty()); |
| 3302 | EXPECT_THAT(delegate.text_results(), testing::IsEmpty()); |
| 3303 | EXPECT_THAT(delegate.unhandled_results(), testing::IsEmpty()); |
| 3304 | } |
| 3305 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 3306 | TEST_F(HostResolverManagerTest, MdnsListener_Srv) { |
Eric Orth | 026776a | 2019-01-18 00:13:28 | [diff] [blame] | 3307 | auto socket_factory = std::make_unique<MockMDnsSocketFactory>(); |
| 3308 | MockMDnsSocketFactory* socket_factory_ptr = socket_factory.get(); |
| 3309 | resolver_->SetMdnsSocketFactoryForTesting(std::move(socket_factory)); |
| 3310 | |
| 3311 | std::unique_ptr<HostResolver::MdnsListener> listener = |
| 3312 | resolver_->CreateMdnsListener(HostPortPair("myhello.local", 14), |
| 3313 | DnsQueryType::SRV); |
| 3314 | |
| 3315 | TestMdnsListenerDelegate delegate; |
| 3316 | ASSERT_THAT(listener->Start(&delegate), IsOk()); |
| 3317 | ASSERT_THAT(delegate.text_results(), testing::IsEmpty()); |
| 3318 | |
| 3319 | socket_factory_ptr->SimulateReceive(kMdnsResponseSrv, |
| 3320 | sizeof(kMdnsResponseSrv)); |
| 3321 | |
| 3322 | EXPECT_THAT( |
| 3323 | delegate.hostname_results(), |
| 3324 | testing::ElementsAre(TestMdnsListenerDelegate::CreateExpectedResult( |
| 3325 | HostResolver::MdnsListener::Delegate::UpdateType::ADDED, |
| 3326 | DnsQueryType::SRV, HostPortPair("foo.com", 8265)))); |
| 3327 | |
| 3328 | EXPECT_THAT(delegate.address_results(), testing::IsEmpty()); |
| 3329 | EXPECT_THAT(delegate.text_results(), testing::IsEmpty()); |
| 3330 | EXPECT_THAT(delegate.unhandled_results(), testing::IsEmpty()); |
| 3331 | } |
| 3332 | |
| 3333 | // Ensure query types we are not listening for do not affect MdnsListener. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 3334 | TEST_F(HostResolverManagerTest, MdnsListener_NonListeningTypes) { |
Eric Orth | 026776a | 2019-01-18 00:13:28 | [diff] [blame] | 3335 | auto socket_factory = std::make_unique<MockMDnsSocketFactory>(); |
| 3336 | MockMDnsSocketFactory* socket_factory_ptr = socket_factory.get(); |
| 3337 | resolver_->SetMdnsSocketFactoryForTesting(std::move(socket_factory)); |
| 3338 | |
| 3339 | std::unique_ptr<HostResolver::MdnsListener> listener = |
| 3340 | resolver_->CreateMdnsListener(HostPortPair("myhello.local", 41), |
| 3341 | DnsQueryType::A); |
| 3342 | |
| 3343 | TestMdnsListenerDelegate delegate; |
| 3344 | ASSERT_THAT(listener->Start(&delegate), IsOk()); |
| 3345 | |
| 3346 | socket_factory_ptr->SimulateReceive(kMdnsResponseAAAA, |
| 3347 | sizeof(kMdnsResponseAAAA)); |
| 3348 | |
| 3349 | EXPECT_THAT(delegate.address_results(), testing::IsEmpty()); |
| 3350 | EXPECT_THAT(delegate.text_results(), testing::IsEmpty()); |
| 3351 | EXPECT_THAT(delegate.hostname_results(), testing::IsEmpty()); |
| 3352 | EXPECT_THAT(delegate.unhandled_results(), testing::IsEmpty()); |
| 3353 | } |
| 3354 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 3355 | TEST_F(HostResolverManagerTest, MdnsListener_RootDomain) { |
Eric Orth | 026776a | 2019-01-18 00:13:28 | [diff] [blame] | 3356 | auto socket_factory = std::make_unique<MockMDnsSocketFactory>(); |
| 3357 | MockMDnsSocketFactory* socket_factory_ptr = socket_factory.get(); |
| 3358 | resolver_->SetMdnsSocketFactoryForTesting(std::move(socket_factory)); |
| 3359 | |
| 3360 | std::unique_ptr<HostResolver::MdnsListener> listener = |
| 3361 | resolver_->CreateMdnsListener(HostPortPair("myhello.local", 5), |
| 3362 | DnsQueryType::PTR); |
| 3363 | |
| 3364 | TestMdnsListenerDelegate delegate; |
| 3365 | ASSERT_THAT(listener->Start(&delegate), IsOk()); |
| 3366 | |
| 3367 | socket_factory_ptr->SimulateReceive(kMdnsResponsePtrRoot, |
| 3368 | sizeof(kMdnsResponsePtrRoot)); |
| 3369 | |
| 3370 | EXPECT_THAT(delegate.unhandled_results(), |
| 3371 | testing::ElementsAre(std::make_pair( |
| 3372 | HostResolver::MdnsListener::Delegate::UpdateType::ADDED, |
| 3373 | DnsQueryType::PTR))); |
| 3374 | |
| 3375 | EXPECT_THAT(delegate.address_results(), testing::IsEmpty()); |
| 3376 | EXPECT_THAT(delegate.text_results(), testing::IsEmpty()); |
| 3377 | EXPECT_THAT(delegate.hostname_results(), testing::IsEmpty()); |
| 3378 | } |
Eric Orth | 9871aafa | 2018-10-02 19:59:18 | [diff] [blame] | 3379 | #endif // BUILDFLAG(ENABLE_MDNS) |
| 3380 | |
[email protected] | 78eac2a | 2012-03-14 19:09:27 | [diff] [blame] | 3381 | DnsConfig CreateValidDnsConfig() { |
martijn | a23c896 | 2016-03-04 18:18:51 | [diff] [blame] | 3382 | IPAddress dns_ip(192, 168, 1, 0); |
[email protected] | 78eac2a | 2012-03-14 19:09:27 | [diff] [blame] | 3383 | DnsConfig config; |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 3384 | config.nameservers.push_back(IPEndPoint(dns_ip, dns_protocol::kDefaultPort)); |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 3385 | config.dns_over_https_servers.push_back({DnsConfig::DnsOverHttpsServerConfig( |
| 3386 | "https://dns.example.com/", true /* use_post */)}); |
| 3387 | config.secure_dns_mode = DnsConfig::SecureDnsMode::OFF; |
[email protected] | 78eac2a | 2012-03-14 19:09:27 | [diff] [blame] | 3388 | EXPECT_TRUE(config.IsValid()); |
| 3389 | return config; |
| 3390 | } |
| 3391 | |
[email protected] | 1d93285 | 2012-06-19 19:40:33 | [diff] [blame] | 3392 | // Specialized fixture for tests of DnsTask. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 3393 | class HostResolverManagerDnsTest : public HostResolverManagerTest { |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 3394 | public: |
Raul Tambre | 94493c65 | 2019-03-11 17:18:35 | [diff] [blame] | 3395 | HostResolverManagerDnsTest() : dns_client_(nullptr) {} |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 3396 | |
[email protected] | 1d93285 | 2012-06-19 19:40:33 | [diff] [blame] | 3397 | protected: |
Miriam Gershenson | 17acdf09 | 2017-08-23 19:43:08 | [diff] [blame] | 3398 | void TearDown() override { |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 3399 | HostResolverManagerTest::TearDown(); |
Miriam Gershenson | 17acdf09 | 2017-08-23 19:43:08 | [diff] [blame] | 3400 | ChangeDnsConfig(DnsConfig()); |
| 3401 | } |
| 3402 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 3403 | // HostResolverManagerTest implementation: |
Eric Orth | 4e55b36 | 2019-05-07 22:00:03 | [diff] [blame] | 3404 | HostResolver::ManagerOptions DefaultOptions() override { |
| 3405 | HostResolver::ManagerOptions options = |
| 3406 | HostResolverManagerTest::DefaultOptions(); |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 3407 | options.insecure_dns_client_enabled = true; |
Eric Orth | 4e55b36 | 2019-05-07 22:00:03 | [diff] [blame] | 3408 | return options; |
| 3409 | } |
| 3410 | |
Eric Orth | 4e55b36 | 2019-05-07 22:00:03 | [diff] [blame] | 3411 | void CreateResolverWithOptionsAndParams(HostResolver::ManagerOptions options, |
| 3412 | const ProcTaskParams& params, |
| 3413 | bool ipv6_reachable) override { |
Eric Orth | 37b1819 | 2019-04-22 19:09:28 | [diff] [blame] | 3414 | DestroyResolver(); |
| 3415 | |
Eric Orth | 4e55b36 | 2019-05-07 22:00:03 | [diff] [blame] | 3416 | resolver_ = std::make_unique<TestHostResolverManager>( |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 3417 | options, nullptr /* net_log */, ipv6_reachable); |
| 3418 | auto dns_client = |
| 3419 | std::make_unique<MockDnsClient>(DnsConfig(), CreateDefaultDnsRules()); |
| 3420 | dns_client_ = dns_client.get(); |
| 3421 | resolver_->SetDnsClientForTesting(std::move(dns_client)); |
[email protected] | 106ccd2c | 2014-06-17 09:21:00 | [diff] [blame] | 3422 | resolver_->set_proc_params_for_test(params); |
Eric Orth | 37b1819 | 2019-04-22 19:09:28 | [diff] [blame] | 3423 | |
| 3424 | if (host_cache_) |
| 3425 | resolver_->AddHostCacheInvalidator(host_cache_->invalidator()); |
[email protected] | 1d93285 | 2012-06-19 19:40:33 | [diff] [blame] | 3426 | } |
| 3427 | |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3428 | // Call after CreateResolver() to update the resolver with a new MockDnsClient |
| 3429 | // using |config| and |rules|. |
| 3430 | void UseMockDnsClient(const DnsConfig& config, MockDnsClientRuleList rules) { |
| 3431 | // HostResolver expects DnsConfig to get set after setting DnsClient, so |
| 3432 | // create first with an empty config and then update the config. |
| 3433 | auto dns_client = |
| 3434 | std::make_unique<MockDnsClient>(DnsConfig(), std::move(rules)); |
| 3435 | dns_client_ = dns_client.get(); |
Eric Orth | 4e55b36 | 2019-05-07 22:00:03 | [diff] [blame] | 3436 | resolver_->SetDnsClientForTesting(std::move(dns_client)); |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 3437 | resolver_->SetInsecureDnsClientEnabled(true); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3438 | if (!config.Equals(DnsConfig())) |
| 3439 | ChangeDnsConfig(config); |
eroman | 1efc237c | 2016-12-14 00:00:45 | [diff] [blame] | 3440 | } |
| 3441 | |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3442 | static MockDnsClientRuleList CreateDefaultDnsRules() { |
| 3443 | MockDnsClientRuleList rules; |
| 3444 | |
| 3445 | AddDnsRule(&rules, "nodomain", dns_protocol::kTypeA, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3446 | MockDnsClientRule::NODOMAIN, false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3447 | AddDnsRule(&rules, "nodomain", dns_protocol::kTypeAAAA, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3448 | MockDnsClientRule::NODOMAIN, false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3449 | AddDnsRule(&rules, "nx", dns_protocol::kTypeA, MockDnsClientRule::FAIL, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3450 | false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3451 | AddDnsRule(&rules, "nx", dns_protocol::kTypeAAAA, MockDnsClientRule::FAIL, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3452 | false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3453 | AddDnsRule(&rules, "ok", dns_protocol::kTypeA, MockDnsClientRule::OK, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3454 | false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3455 | AddDnsRule(&rules, "ok", dns_protocol::kTypeAAAA, MockDnsClientRule::OK, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3456 | false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3457 | AddDnsRule(&rules, "4ok", dns_protocol::kTypeA, MockDnsClientRule::OK, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3458 | false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3459 | AddDnsRule(&rules, "4ok", dns_protocol::kTypeAAAA, MockDnsClientRule::EMPTY, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3460 | false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3461 | AddDnsRule(&rules, "6ok", dns_protocol::kTypeA, MockDnsClientRule::EMPTY, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3462 | false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3463 | AddDnsRule(&rules, "6ok", dns_protocol::kTypeAAAA, MockDnsClientRule::OK, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3464 | false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3465 | AddDnsRule(&rules, "4nx", dns_protocol::kTypeA, MockDnsClientRule::OK, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3466 | false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3467 | AddDnsRule(&rules, "4nx", dns_protocol::kTypeAAAA, MockDnsClientRule::FAIL, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3468 | false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3469 | AddDnsRule(&rules, "empty", dns_protocol::kTypeA, MockDnsClientRule::EMPTY, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3470 | false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3471 | AddDnsRule(&rules, "empty", dns_protocol::kTypeAAAA, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3472 | MockDnsClientRule::EMPTY, false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3473 | |
| 3474 | AddDnsRule(&rules, "slow_nx", dns_protocol::kTypeA, MockDnsClientRule::FAIL, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3475 | true /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3476 | AddDnsRule(&rules, "slow_nx", dns_protocol::kTypeAAAA, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3477 | MockDnsClientRule::FAIL, true /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3478 | |
| 3479 | AddDnsRule(&rules, "4slow_ok", dns_protocol::kTypeA, MockDnsClientRule::OK, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3480 | true /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3481 | AddDnsRule(&rules, "4slow_ok", dns_protocol::kTypeAAAA, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3482 | MockDnsClientRule::OK, false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3483 | AddDnsRule(&rules, "6slow_ok", dns_protocol::kTypeA, MockDnsClientRule::OK, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3484 | false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3485 | AddDnsRule(&rules, "6slow_ok", dns_protocol::kTypeAAAA, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3486 | MockDnsClientRule::OK, true /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3487 | AddDnsRule(&rules, "4slow_4ok", dns_protocol::kTypeA, MockDnsClientRule::OK, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3488 | true /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3489 | AddDnsRule(&rules, "4slow_4ok", dns_protocol::kTypeAAAA, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3490 | MockDnsClientRule::EMPTY, false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3491 | AddDnsRule(&rules, "4slow_4timeout", dns_protocol::kTypeA, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3492 | MockDnsClientRule::TIMEOUT, true /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3493 | AddDnsRule(&rules, "4slow_4timeout", dns_protocol::kTypeAAAA, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3494 | MockDnsClientRule::OK, false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3495 | AddDnsRule(&rules, "4slow_6timeout", dns_protocol::kTypeA, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3496 | MockDnsClientRule::OK, true /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3497 | AddDnsRule(&rules, "4slow_6timeout", dns_protocol::kTypeAAAA, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3498 | MockDnsClientRule::TIMEOUT, false /* delay */); |
| 3499 | |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3500 | AddDnsRule(&rules, "4collision", dns_protocol::kTypeA, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3501 | IPAddress(127, 0, 53, 53), false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3502 | AddDnsRule(&rules, "4collision", dns_protocol::kTypeAAAA, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3503 | MockDnsClientRule::EMPTY, false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3504 | AddDnsRule(&rules, "6collision", dns_protocol::kTypeA, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3505 | MockDnsClientRule::EMPTY, false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3506 | // This isn't the expected IP for collisions (but looks close to it). |
| 3507 | AddDnsRule(&rules, "6collision", dns_protocol::kTypeAAAA, |
| 3508 | IPAddress(0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 127, 0, 53, 53), |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3509 | false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3510 | |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 3511 | AddSecureDnsRule(&rules, "automatic_nodomain", dns_protocol::kTypeA, |
| 3512 | MockDnsClientRule::NODOMAIN, false /* delay */); |
| 3513 | AddSecureDnsRule(&rules, "automatic_nodomain", dns_protocol::kTypeAAAA, |
| 3514 | MockDnsClientRule::NODOMAIN, false /* delay */); |
| 3515 | AddDnsRule(&rules, "automatic_nodomain", dns_protocol::kTypeA, |
| 3516 | MockDnsClientRule::NODOMAIN, false /* delay */); |
| 3517 | AddDnsRule(&rules, "automatic_nodomain", dns_protocol::kTypeAAAA, |
| 3518 | MockDnsClientRule::NODOMAIN, false /* delay */); |
| 3519 | AddSecureDnsRule(&rules, "automatic", dns_protocol::kTypeA, |
| 3520 | MockDnsClientRule::OK, false /* delay */); |
| 3521 | AddSecureDnsRule(&rules, "automatic", dns_protocol::kTypeAAAA, |
| 3522 | MockDnsClientRule::OK, false /* delay */); |
| 3523 | AddDnsRule(&rules, "automatic", dns_protocol::kTypeA, MockDnsClientRule::OK, |
| 3524 | false /* delay */); |
| 3525 | AddDnsRule(&rules, "automatic", dns_protocol::kTypeAAAA, |
| 3526 | MockDnsClientRule::OK, false /* delay */); |
| 3527 | AddDnsRule(&rules, "insecure_automatic", dns_protocol::kTypeA, |
| 3528 | MockDnsClientRule::OK, false /* delay */); |
| 3529 | AddDnsRule(&rules, "insecure_automatic", dns_protocol::kTypeAAAA, |
| 3530 | MockDnsClientRule::OK, false /* delay */); |
| 3531 | |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 3532 | AddSecureDnsRule(&rules, "secure", dns_protocol::kTypeA, |
| 3533 | MockDnsClientRule::OK, false /* delay */); |
| 3534 | AddSecureDnsRule(&rules, "secure", dns_protocol::kTypeAAAA, |
| 3535 | MockDnsClientRule::OK, false /* delay */); |
| 3536 | |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3537 | return rules; |
eroman | 1efc237c | 2016-12-14 00:00:45 | [diff] [blame] | 3538 | } |
| 3539 | |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3540 | // Adds a rule to |rules|. |
| 3541 | static void AddDnsRule(MockDnsClientRuleList* rules, |
| 3542 | const std::string& prefix, |
| 3543 | uint16_t qtype, |
| 3544 | MockDnsClientRule::ResultType result_type, |
| 3545 | bool delay) { |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 3546 | rules->emplace_back(prefix, qtype, false /* secure */, |
dalyk | ad3f6c3 | 2019-03-06 13:38:33 | [diff] [blame] | 3547 | MockDnsClientRule::Result(result_type), delay); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3548 | } |
| 3549 | |
| 3550 | static void AddDnsRule(MockDnsClientRuleList* rules, |
| 3551 | const std::string& prefix, |
| 3552 | uint16_t qtype, |
| 3553 | const IPAddress& result_ip, |
| 3554 | bool delay) { |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 3555 | rules->emplace_back(prefix, qtype, false /* secure */, |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3556 | MockDnsClientRule::Result( |
| 3557 | BuildTestDnsResponse(prefix, std::move(result_ip))), |
| 3558 | delay); |
| 3559 | } |
| 3560 | |
| 3561 | static void AddDnsRule(MockDnsClientRuleList* rules, |
| 3562 | const std::string& prefix, |
| 3563 | uint16_t qtype, |
| 3564 | IPAddress result_ip, |
| 3565 | std::string cannonname, |
| 3566 | bool delay) { |
| 3567 | rules->emplace_back( |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 3568 | prefix, qtype, false /* secure */, |
dalyk | c0ab072 | 2019-03-14 17:00:58 | [diff] [blame] | 3569 | MockDnsClientRule::Result(BuildTestDnsResponseWithCname( |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3570 | prefix, std::move(result_ip), std::move(cannonname))), |
| 3571 | delay); |
[email protected] | 0adcb2b | 2012-08-15 21:30:46 | [diff] [blame] | 3572 | } |
| 3573 | |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3574 | static void AddSecureDnsRule(MockDnsClientRuleList* rules, |
| 3575 | const std::string& prefix, |
| 3576 | uint16_t qtype, |
| 3577 | MockDnsClientRule::ResultType result_type, |
| 3578 | bool delay) { |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 3579 | rules->emplace_back(prefix, qtype, true /* secure */, |
| 3580 | MockDnsClientRule::Result(result_type), delay); |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3581 | } |
| 3582 | |
[email protected] | 1d93285 | 2012-06-19 19:40:33 | [diff] [blame] | 3583 | void ChangeDnsConfig(const DnsConfig& config) { |
Eric Orth | c398f1e | 2019-07-09 21:54:55 | [diff] [blame] | 3584 | NetworkChangeNotifier::SetDnsConfigForTesting(config); |
[email protected] | bb0e3454 | 2012-08-31 19:52:40 | [diff] [blame] | 3585 | // Notification is delivered asynchronously. |
fdoray | 5eeb764 | 2016-06-22 16:11:28 | [diff] [blame] | 3586 | base::RunLoop().RunUntilIdle(); |
[email protected] | 1d93285 | 2012-06-19 19:40:33 | [diff] [blame] | 3587 | } |
| 3588 | |
Miriam Gershenson | 44aafc12 | 2017-10-18 19:29:25 | [diff] [blame] | 3589 | void SetInitialDnsConfig(const DnsConfig& config) { |
John Abd-El-Malek | 1842b8c | 2018-05-16 14:53:22 | [diff] [blame] | 3590 | NetworkChangeNotifier::ClearDnsConfigForTesting(); |
Eric Orth | c398f1e | 2019-07-09 21:54:55 | [diff] [blame] | 3591 | NetworkChangeNotifier::SetDnsConfigForTesting(config); |
Miriam Gershenson | 44aafc12 | 2017-10-18 19:29:25 | [diff] [blame] | 3592 | // Notification is delivered asynchronously. |
| 3593 | base::RunLoop().RunUntilIdle(); |
| 3594 | } |
| 3595 | |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 3596 | // Owned by |resolver_|. |
| 3597 | MockDnsClient* dns_client_; |
[email protected] | 1d93285 | 2012-06-19 19:40:33 | [diff] [blame] | 3598 | }; |
| 3599 | |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 3600 | TEST_F(HostResolverManagerDnsTest, DisableAndEnableInsecureDnsClient) { |
Eric Orth | 4e55b36 | 2019-05-07 22:00:03 | [diff] [blame] | 3601 | // Disable fallback to allow testing how requests are initially handled. |
| 3602 | set_allow_fallback_to_proctask(false); |
| 3603 | |
| 3604 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 3605 | proc_->AddRuleForAllFamilies("nx_succeed", "192.168.2.47"); |
| 3606 | proc_->SignalMultiple(1u); |
| 3607 | |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 3608 | resolver_->SetInsecureDnsClientEnabled(false); |
Eric Orth | 4e55b36 | 2019-05-07 22:00:03 | [diff] [blame] | 3609 | ResolveHostResponseHelper response_proc(resolver_->CreateRequest( |
| 3610 | HostPortPair("nx_succeed", 1212), NetLogWithSource(), base::nullopt, |
| 3611 | request_context_.get(), host_cache_.get())); |
| 3612 | EXPECT_THAT(response_proc.result_error(), IsOk()); |
| 3613 | EXPECT_THAT(response_proc.request()->GetAddressResults().value().endpoints(), |
| 3614 | testing::ElementsAre(CreateExpected("192.168.2.47", 1212))); |
| 3615 | |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 3616 | resolver_->SetInsecureDnsClientEnabled(true); |
Eric Orth | 4e55b36 | 2019-05-07 22:00:03 | [diff] [blame] | 3617 | ResolveHostResponseHelper response_dns_client(resolver_->CreateRequest( |
| 3618 | HostPortPair("ok_fail", 1212), NetLogWithSource(), base::nullopt, |
| 3619 | request_context_.get(), host_cache_.get())); |
| 3620 | EXPECT_THAT(response_dns_client.result_error(), IsOk()); |
| 3621 | EXPECT_THAT( |
| 3622 | response_dns_client.request()->GetAddressResults().value().endpoints(), |
| 3623 | testing::UnorderedElementsAre(CreateExpected("::1", 1212), |
| 3624 | CreateExpected("127.0.0.1", 1212))); |
| 3625 | } |
| 3626 | |
dalyk | 6d7d8ead | 2019-08-15 03:30:08 | [diff] [blame^] | 3627 | TEST_F(HostResolverManagerDnsTest, UseProcTaskWhenPrivateDnsActive) { |
| 3628 | // Disable fallback to allow testing how requests are initially handled. |
| 3629 | set_allow_fallback_to_proctask(false); |
| 3630 | proc_->AddRuleForAllFamilies("nx_succeed", "192.168.2.47"); |
| 3631 | proc_->SignalMultiple(1u); |
| 3632 | |
| 3633 | DnsConfig config = CreateValidDnsConfig(); |
| 3634 | config.dns_over_tls_active = true; |
| 3635 | ChangeDnsConfig(config); |
| 3636 | ResolveHostResponseHelper response_proc(resolver_->CreateRequest( |
| 3637 | HostPortPair("nx_succeed", 1212), NetLogWithSource(), base::nullopt, |
| 3638 | request_context_.get(), host_cache_.get())); |
| 3639 | EXPECT_THAT(response_proc.result_error(), IsOk()); |
| 3640 | EXPECT_THAT(response_proc.request()->GetAddressResults().value().endpoints(), |
| 3641 | testing::ElementsAre(CreateExpected("192.168.2.47", 1212))); |
| 3642 | } |
| 3643 | |
Mike West | da1c690e | 2017-08-12 05:57:16 | [diff] [blame] | 3644 | // RFC 6761 localhost names should always resolve to loopback. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 3645 | TEST_F(HostResolverManagerDnsTest, LocalhostLookup) { |
Mike West | da1c690e | 2017-08-12 05:57:16 | [diff] [blame] | 3646 | // Add a rule resolving localhost names to a non-loopback IP and test |
| 3647 | // that they still resolves to loopback. |
| 3648 | proc_->AddRuleForAllFamilies("foo.localhost", "192.168.1.42"); |
| 3649 | proc_->AddRuleForAllFamilies("localhost", "192.168.1.42"); |
| 3650 | proc_->AddRuleForAllFamilies("localhost.", "192.168.1.42"); |
| 3651 | |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 3652 | ResolveHostResponseHelper response0(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 3653 | HostPortPair("foo.localhost", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 3654 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 3655 | EXPECT_THAT(response0.result_error(), IsOk()); |
| 3656 | EXPECT_THAT(response0.request()->GetAddressResults().value().endpoints(), |
| 3657 | testing::UnorderedElementsAre(CreateExpected("127.0.0.1", 80), |
| 3658 | CreateExpected("::1", 80))); |
| 3659 | |
| 3660 | ResolveHostResponseHelper response1(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 3661 | HostPortPair("localhost", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 3662 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 3663 | EXPECT_THAT(response1.result_error(), IsOk()); |
| 3664 | EXPECT_THAT(response1.request()->GetAddressResults().value().endpoints(), |
| 3665 | testing::UnorderedElementsAre(CreateExpected("127.0.0.1", 80), |
| 3666 | CreateExpected("::1", 80))); |
| 3667 | |
| 3668 | ResolveHostResponseHelper response2(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 3669 | HostPortPair("localhost.", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 3670 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 3671 | EXPECT_THAT(response2.result_error(), IsOk()); |
| 3672 | EXPECT_THAT(response2.request()->GetAddressResults().value().endpoints(), |
| 3673 | testing::UnorderedElementsAre(CreateExpected("127.0.0.1", 80), |
| 3674 | CreateExpected("::1", 80))); |
| 3675 | } |
| 3676 | |
Mike West | da1c690e | 2017-08-12 05:57:16 | [diff] [blame] | 3677 | // RFC 6761 localhost names should always resolve to loopback, even if a HOSTS |
| 3678 | // file is active. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 3679 | TEST_F(HostResolverManagerDnsTest, LocalhostLookupWithHosts) { |
Mike West | da1c690e | 2017-08-12 05:57:16 | [diff] [blame] | 3680 | DnsHosts hosts; |
| 3681 | hosts[DnsHostsKey("localhost", ADDRESS_FAMILY_IPV4)] = |
| 3682 | IPAddress({192, 168, 1, 1}); |
| 3683 | hosts[DnsHostsKey("foo.localhost", ADDRESS_FAMILY_IPV4)] = |
| 3684 | IPAddress({192, 168, 1, 2}); |
| 3685 | |
| 3686 | DnsConfig config = CreateValidDnsConfig(); |
| 3687 | config.hosts = hosts; |
| 3688 | ChangeDnsConfig(config); |
| 3689 | |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 3690 | ResolveHostResponseHelper response0(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 3691 | HostPortPair("localhost", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 3692 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 3693 | EXPECT_THAT(response0.result_error(), IsOk()); |
| 3694 | EXPECT_THAT(response0.request()->GetAddressResults().value().endpoints(), |
| 3695 | testing::UnorderedElementsAre(CreateExpected("127.0.0.1", 80), |
| 3696 | CreateExpected("::1", 80))); |
| 3697 | |
| 3698 | ResolveHostResponseHelper response1(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 3699 | HostPortPair("foo.localhost", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 3700 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 3701 | EXPECT_THAT(response1.result_error(), IsOk()); |
| 3702 | EXPECT_THAT(response1.request()->GetAddressResults().value().endpoints(), |
| 3703 | testing::UnorderedElementsAre(CreateExpected("127.0.0.1", 80), |
| 3704 | CreateExpected("::1", 80))); |
| 3705 | } |
| 3706 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 3707 | // Test successful and fallback resolutions in HostResolverManager::DnsTask. |
| 3708 | TEST_F(HostResolverManagerDnsTest, DnsTask) { |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 3709 | proc_->AddRuleForAllFamilies("nx_succeed", "192.168.1.102"); |
| 3710 | // All other hostnames will fail in proc_. |
[email protected] | 78eac2a | 2012-03-14 19:09:27 | [diff] [blame] | 3711 | |
| 3712 | // Initially there is no config, so client should not be invoked. |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 3713 | ResolveHostResponseHelper initial_response(resolver_->CreateRequest( |
| 3714 | HostPortPair("ok_fail", 80), NetLogWithSource(), base::nullopt, |
| 3715 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 3716 | EXPECT_FALSE(initial_response.complete()); |
| 3717 | |
| 3718 | proc_->SignalMultiple(1u); |
| 3719 | |
| 3720 | EXPECT_THAT(initial_response.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 3721 | |
| 3722 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 3723 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 3724 | ResolveHostResponseHelper response0(resolver_->CreateRequest( |
| 3725 | HostPortPair("ok_fail", 80), NetLogWithSource(), base::nullopt, |
| 3726 | request_context_.get(), host_cache_.get())); |
| 3727 | ResolveHostResponseHelper response1(resolver_->CreateRequest( |
| 3728 | HostPortPair("nx_fail", 80), NetLogWithSource(), base::nullopt, |
| 3729 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 3730 | ResolveHostResponseHelper response2(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 3731 | HostPortPair("nx_succeed", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 3732 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 3733 | |
| 3734 | proc_->SignalMultiple(4u); |
| 3735 | |
| 3736 | // Resolved by MockDnsClient. |
| 3737 | EXPECT_THAT(response0.result_error(), IsOk()); |
| 3738 | EXPECT_THAT(response0.request()->GetAddressResults().value().endpoints(), |
| 3739 | testing::UnorderedElementsAre(CreateExpected("127.0.0.1", 80), |
| 3740 | CreateExpected("::1", 80))); |
| 3741 | |
| 3742 | // Fallback to ProcTask. |
| 3743 | EXPECT_THAT(response1.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 3744 | EXPECT_THAT(response2.result_error(), IsOk()); |
| 3745 | EXPECT_THAT(response2.request()->GetAddressResults().value().endpoints(), |
| 3746 | testing::ElementsAre(CreateExpected("192.168.1.102", 80))); |
| 3747 | } |
| 3748 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 3749 | // Test successful and failing resolutions in HostResolverManager::DnsTask when |
[email protected] | 16c2bd7 | 2013-06-28 01:19:22 | [diff] [blame] | 3750 | // fallback to ProcTask is disabled. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 3751 | TEST_F(HostResolverManagerDnsTest, NoFallbackToProcTask) { |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 3752 | set_allow_fallback_to_proctask(false); |
[email protected] | 16c2bd7 | 2013-06-28 01:19:22 | [diff] [blame] | 3753 | |
[email protected] | 16c2bd7 | 2013-06-28 01:19:22 | [diff] [blame] | 3754 | proc_->AddRuleForAllFamilies("nx_succeed", "192.168.1.102"); |
| 3755 | // All other hostnames will fail in proc_. |
| 3756 | |
| 3757 | // Set empty DnsConfig. |
| 3758 | ChangeDnsConfig(DnsConfig()); |
| 3759 | // Initially there is no config, so client should not be invoked. |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 3760 | ResolveHostResponseHelper initial_response0(resolver_->CreateRequest( |
| 3761 | HostPortPair("ok_fail", 80), NetLogWithSource(), base::nullopt, |
| 3762 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 3763 | ResolveHostResponseHelper initial_response1(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 3764 | HostPortPair("nx_succeed", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 3765 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 3766 | proc_->SignalMultiple(2u); |
| 3767 | |
| 3768 | EXPECT_THAT(initial_response0.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 3769 | EXPECT_THAT(initial_response1.result_error(), IsOk()); |
| 3770 | EXPECT_THAT( |
| 3771 | initial_response1.request()->GetAddressResults().value().endpoints(), |
| 3772 | testing::ElementsAre(CreateExpected("192.168.1.102", 80))); |
| 3773 | |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 3774 | // Switch to a valid config. |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 3775 | ChangeDnsConfig(CreateValidDnsConfig()); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 3776 | // First request is resolved by MockDnsClient, others should fail due to |
| 3777 | // disabled fallback to ProcTask. |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 3778 | ResolveHostResponseHelper response0(resolver_->CreateRequest( |
| 3779 | HostPortPair("ok_fail", 80), NetLogWithSource(), base::nullopt, |
| 3780 | request_context_.get(), host_cache_.get())); |
| 3781 | ResolveHostResponseHelper response1(resolver_->CreateRequest( |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 3782 | HostPortPair("nx_succeed", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 3783 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 3784 | proc_->SignalMultiple(6u); |
| 3785 | |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 3786 | // Resolved by MockDnsClient. |
| 3787 | EXPECT_THAT(response0.result_error(), IsOk()); |
| 3788 | EXPECT_THAT(response0.request()->GetAddressResults().value().endpoints(), |
| 3789 | testing::UnorderedElementsAre(CreateExpected("127.0.0.1", 80), |
| 3790 | CreateExpected("::1", 80))); |
| 3791 | // Fallback to ProcTask is disabled. |
| 3792 | EXPECT_THAT(response1.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 3793 | } |
| 3794 | |
[email protected] | 16c2bd7 | 2013-06-28 01:19:22 | [diff] [blame] | 3795 | // Test behavior of OnDnsTaskFailure when Job is aborted. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 3796 | TEST_F(HostResolverManagerDnsTest, OnDnsTaskFailureAbortedJob) { |
[email protected] | 16c2bd7 | 2013-06-28 01:19:22 | [diff] [blame] | 3797 | ChangeDnsConfig(CreateValidDnsConfig()); |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 3798 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 3799 | HostPortPair("nx_abort", 80), NetLogWithSource(), base::nullopt, |
| 3800 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 3801 | // Abort all jobs here. |
| 3802 | CreateResolver(); |
| 3803 | proc_->SignalMultiple(1u); |
| 3804 | // Run to completion. |
| 3805 | base::RunLoop().RunUntilIdle(); // Notification happens async. |
| 3806 | // It shouldn't crash during OnDnsTaskFailure callbacks. |
| 3807 | EXPECT_FALSE(response.complete()); |
| 3808 | |
| 3809 | // Repeat test with Fallback to ProcTask disabled |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 3810 | set_allow_fallback_to_proctask(false); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 3811 | ChangeDnsConfig(CreateValidDnsConfig()); |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 3812 | ResolveHostResponseHelper no_fallback_response(resolver_->CreateRequest( |
| 3813 | HostPortPair("nx_abort", 80), NetLogWithSource(), base::nullopt, |
| 3814 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 3815 | // Abort all jobs here. |
| 3816 | CreateResolver(); |
| 3817 | proc_->SignalMultiple(2u); |
| 3818 | // Run to completion. |
| 3819 | base::RunLoop().RunUntilIdle(); // Notification happens async. |
| 3820 | // It shouldn't crash during OnDnsTaskFailure callbacks. |
| 3821 | EXPECT_FALSE(no_fallback_response.complete()); |
| 3822 | } |
| 3823 | |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 3824 | // Fallback to proc allowed with ANY source. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 3825 | TEST_F(HostResolverManagerDnsTest, FallbackBySource_Any) { |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 3826 | // Ensure fallback is otherwise allowed by resolver settings. |
| 3827 | set_allow_fallback_to_proctask(true); |
| 3828 | |
| 3829 | proc_->AddRuleForAllFamilies("nx_succeed", "192.168.1.102"); |
| 3830 | // All other hostnames will fail in proc_. |
| 3831 | |
| 3832 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 3833 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 3834 | ResolveHostResponseHelper response0(resolver_->CreateRequest( |
| 3835 | HostPortPair("nx_fail", 80), NetLogWithSource(), base::nullopt, |
| 3836 | request_context_.get(), host_cache_.get())); |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 3837 | ResolveHostResponseHelper response1(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 3838 | HostPortPair("nx_succeed", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 3839 | request_context_.get(), host_cache_.get())); |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 3840 | proc_->SignalMultiple(2u); |
| 3841 | |
| 3842 | EXPECT_THAT(response0.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 3843 | EXPECT_THAT(response1.result_error(), IsOk()); |
| 3844 | EXPECT_THAT(response1.request()->GetAddressResults().value().endpoints(), |
| 3845 | testing::ElementsAre(CreateExpected("192.168.1.102", 80))); |
| 3846 | } |
| 3847 | |
| 3848 | // Fallback to proc not allowed with DNS source. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 3849 | TEST_F(HostResolverManagerDnsTest, FallbackBySource_Dns) { |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 3850 | // Ensure fallback is otherwise allowed by resolver settings. |
| 3851 | set_allow_fallback_to_proctask(true); |
| 3852 | |
| 3853 | proc_->AddRuleForAllFamilies("nx_succeed", "192.168.1.102"); |
| 3854 | // All other hostnames will fail in proc_. |
| 3855 | |
| 3856 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 3857 | |
| 3858 | HostResolver::ResolveHostParameters parameters; |
| 3859 | parameters.source = HostResolverSource::DNS; |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 3860 | ResolveHostResponseHelper response0(resolver_->CreateRequest( |
| 3861 | HostPortPair("nx_fail", 80), NetLogWithSource(), parameters, |
| 3862 | request_context_.get(), host_cache_.get())); |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 3863 | ResolveHostResponseHelper response1(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 3864 | HostPortPair("nx_succeed", 80), NetLogWithSource(), parameters, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 3865 | request_context_.get(), host_cache_.get())); |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 3866 | // Nothing should reach |proc_| on success, but let failures through to fail |
| 3867 | // instead of hanging. |
| 3868 | proc_->SignalMultiple(2u); |
| 3869 | |
| 3870 | EXPECT_THAT(response0.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 3871 | EXPECT_THAT(response1.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 3872 | } |
| 3873 | |
| 3874 | // Fallback to proc on DnsClient change allowed with ANY source. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 3875 | TEST_F(HostResolverManagerDnsTest, FallbackOnAbortBySource_Any) { |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 3876 | // Ensure fallback is otherwise allowed by resolver settings. |
| 3877 | set_allow_fallback_to_proctask(true); |
| 3878 | |
| 3879 | proc_->AddRuleForAllFamilies("nx_succeed", "192.168.1.102"); |
| 3880 | // All other hostnames will fail in proc_. |
| 3881 | |
| 3882 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 3883 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 3884 | ResolveHostResponseHelper response0(resolver_->CreateRequest( |
| 3885 | HostPortPair("ok_fail", 80), NetLogWithSource(), base::nullopt, |
| 3886 | request_context_.get(), host_cache_.get())); |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 3887 | ResolveHostResponseHelper response1(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 3888 | HostPortPair("nx_succeed", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 3889 | request_context_.get(), host_cache_.get())); |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 3890 | proc_->SignalMultiple(2u); |
| 3891 | |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 3892 | // Simulate the case when the preference or policy has disabled the insecure |
| 3893 | // DNS client causing AbortInsecureDnsTasks. |
| 3894 | resolver_->SetInsecureDnsClientEnabled(false); |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 3895 | |
| 3896 | // All requests should fallback to proc resolver. |
| 3897 | EXPECT_THAT(response0.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 3898 | EXPECT_THAT(response1.result_error(), IsOk()); |
| 3899 | EXPECT_THAT(response1.request()->GetAddressResults().value().endpoints(), |
| 3900 | testing::ElementsAre(CreateExpected("192.168.1.102", 80))); |
| 3901 | } |
| 3902 | |
| 3903 | // Fallback to proc on DnsClient change not allowed with DNS source. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 3904 | TEST_F(HostResolverManagerDnsTest, FallbackOnAbortBySource_Dns) { |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 3905 | // Ensure fallback is otherwise allowed by resolver settings. |
| 3906 | set_allow_fallback_to_proctask(true); |
| 3907 | |
| 3908 | proc_->AddRuleForAllFamilies("nx_succeed", "192.168.1.102"); |
| 3909 | // All other hostnames will fail in proc_. |
| 3910 | |
| 3911 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 3912 | |
| 3913 | HostResolver::ResolveHostParameters parameters; |
| 3914 | parameters.source = HostResolverSource::DNS; |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 3915 | ResolveHostResponseHelper response0(resolver_->CreateRequest( |
| 3916 | HostPortPair("ok_fail", 80), NetLogWithSource(), parameters, |
| 3917 | request_context_.get(), host_cache_.get())); |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 3918 | ResolveHostResponseHelper response1(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 3919 | HostPortPair("nx_succeed", 80), NetLogWithSource(), parameters, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 3920 | request_context_.get(), host_cache_.get())); |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 3921 | // Nothing should reach |proc_| on success, but let failures through to fail |
| 3922 | // instead of hanging. |
| 3923 | proc_->SignalMultiple(2u); |
| 3924 | |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 3925 | // Simulate the case when the preference or policy has disabled the insecure |
| 3926 | // DNS client causing AbortInsecureDnsTasks. |
| 3927 | resolver_->SetInsecureDnsClientEnabled(false); |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 3928 | |
| 3929 | // No fallback expected. All requests should fail. |
| 3930 | EXPECT_THAT(response0.result_error(), IsError(ERR_NETWORK_CHANGED)); |
| 3931 | EXPECT_THAT(response1.result_error(), IsError(ERR_NETWORK_CHANGED)); |
| 3932 | } |
| 3933 | |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 3934 | // Insecure DnsClient change shouldn't affect secure DnsTasks. |
| 3935 | TEST_F(HostResolverManagerDnsTest, |
| 3936 | DisableInsecureDnsClient_SecureDnsTasksUnaffected) { |
| 3937 | // Ensure fallback is otherwise allowed by resolver settings. |
| 3938 | set_allow_fallback_to_proctask(true); |
| 3939 | |
| 3940 | proc_->AddRuleForAllFamilies("automatic", "192.168.1.102"); |
| 3941 | // All other hostnames will fail in proc_. |
| 3942 | |
| 3943 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 3944 | |
| 3945 | HostResolver::ResolveHostParameters secure_parameters; |
| 3946 | secure_parameters.secure_dns_mode_override = |
| 3947 | DnsConfig::SecureDnsMode::AUTOMATIC; |
| 3948 | ResolveHostResponseHelper response_secure(resolver_->CreateRequest( |
| 3949 | HostPortPair("automatic", 80), NetLogWithSource(), secure_parameters, |
| 3950 | request_context_.get(), host_cache_.get())); |
| 3951 | EXPECT_FALSE(response_secure.complete()); |
| 3952 | |
| 3953 | // Simulate the case when the preference or policy has disabled the insecure |
| 3954 | // DNS client causing AbortInsecureDnsTasks. |
| 3955 | resolver_->SetInsecureDnsClientEnabled(false); |
| 3956 | |
| 3957 | EXPECT_THAT(response_secure.result_error(), IsOk()); |
| 3958 | EXPECT_THAT( |
| 3959 | response_secure.request()->GetAddressResults().value().endpoints(), |
| 3960 | testing::UnorderedElementsAre(CreateExpected("127.0.0.1", 80), |
| 3961 | CreateExpected("::1", 80))); |
| 3962 | } |
| 3963 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 3964 | TEST_F(HostResolverManagerDnsTest, DnsTaskUnspec) { |
[email protected] | 0adcb2b | 2012-08-15 21:30:46 | [diff] [blame] | 3965 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 3966 | |
| 3967 | proc_->AddRuleForAllFamilies("4nx", "192.168.1.101"); |
| 3968 | // All other hostnames will fail in proc_. |
| 3969 | |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 3970 | std::vector<std::unique_ptr<ResolveHostResponseHelper>> responses; |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 3971 | responses.emplace_back( |
| 3972 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 3973 | HostPortPair("ok", 80), NetLogWithSource(), base::nullopt, |
| 3974 | request_context_.get(), host_cache_.get()))); |
| 3975 | responses.emplace_back( |
| 3976 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 3977 | HostPortPair("4ok", 80), NetLogWithSource(), base::nullopt, |
| 3978 | request_context_.get(), host_cache_.get()))); |
| 3979 | responses.emplace_back( |
| 3980 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 3981 | HostPortPair("6ok", 80), NetLogWithSource(), base::nullopt, |
| 3982 | request_context_.get(), host_cache_.get()))); |
| 3983 | responses.emplace_back( |
| 3984 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 3985 | HostPortPair("4nx", 80), NetLogWithSource(), base::nullopt, |
| 3986 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 3987 | |
| 3988 | proc_->SignalMultiple(4u); |
| 3989 | |
| 3990 | for (auto& response : responses) { |
| 3991 | EXPECT_THAT(response->result_error(), IsOk()); |
| 3992 | } |
| 3993 | |
| 3994 | EXPECT_THAT(responses[0]->request()->GetAddressResults().value().endpoints(), |
| 3995 | testing::UnorderedElementsAre(CreateExpected("127.0.0.1", 80), |
| 3996 | CreateExpected("::1", 80))); |
| 3997 | EXPECT_THAT(responses[1]->request()->GetAddressResults().value().endpoints(), |
| 3998 | testing::ElementsAre(CreateExpected("127.0.0.1", 80))); |
| 3999 | EXPECT_THAT(responses[2]->request()->GetAddressResults().value().endpoints(), |
| 4000 | testing::ElementsAre(CreateExpected("::1", 80))); |
| 4001 | EXPECT_THAT(responses[3]->request()->GetAddressResults().value().endpoints(), |
| 4002 | testing::ElementsAre(CreateExpected("192.168.1.101", 80))); |
| 4003 | } |
| 4004 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 4005 | TEST_F(HostResolverManagerDnsTest, NameCollisionIcann) { |
eroman | 1efc237c | 2016-12-14 00:00:45 | [diff] [blame] | 4006 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 4007 | |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4008 | // When the resolver returns an A record with 127.0.53.53 it should be |
| 4009 | // mapped to a special error. |
| 4010 | ResolveHostResponseHelper response_ipv4(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 4011 | HostPortPair("4collision", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4012 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4013 | EXPECT_THAT(response_ipv4.result_error(), IsError(ERR_ICANN_NAME_COLLISION)); |
| 4014 | EXPECT_FALSE(response_ipv4.request()->GetAddressResults()); |
| 4015 | |
| 4016 | // When the resolver returns an AAAA record with ::127.0.53.53 it should |
| 4017 | // work just like any other IP. (Despite having the same suffix, it is not |
| 4018 | // considered special) |
| 4019 | ResolveHostResponseHelper response_ipv6(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 4020 | HostPortPair("6collision", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4021 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4022 | EXPECT_THAT(response_ipv6.result_error(), IsOk()); |
| 4023 | EXPECT_THAT(response_ipv6.request()->GetAddressResults().value().endpoints(), |
| 4024 | testing::ElementsAre(CreateExpected("::127.0.53.53", 80))); |
| 4025 | } |
| 4026 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 4027 | TEST_F(HostResolverManagerDnsTest, ServeFromHosts) { |
[email protected] | d7b9a2b | 2012-05-31 22:31:19 | [diff] [blame] | 4028 | // Initially, use empty HOSTS file. |
[email protected] | bb0e3454 | 2012-08-31 19:52:40 | [diff] [blame] | 4029 | DnsConfig config = CreateValidDnsConfig(); |
| 4030 | ChangeDnsConfig(config); |
[email protected] | d7b9a2b | 2012-05-31 22:31:19 | [diff] [blame] | 4031 | |
[email protected] | 007b3f8 | 2013-04-09 08:46:45 | [diff] [blame] | 4032 | proc_->AddRuleForAllFamilies(std::string(), |
| 4033 | std::string()); // Default to failures. |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 4034 | proc_->SignalMultiple(1u); // For the first request which misses. |
[email protected] | 78eac2a | 2012-03-14 19:09:27 | [diff] [blame] | 4035 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4036 | ResolveHostResponseHelper initial_response(resolver_->CreateRequest( |
| 4037 | HostPortPair("nx_ipv4", 80), NetLogWithSource(), base::nullopt, |
| 4038 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4039 | EXPECT_THAT(initial_response.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 4040 | |
| 4041 | IPAddress local_ipv4 = IPAddress::IPv4Localhost(); |
| 4042 | IPAddress local_ipv6 = IPAddress::IPv6Localhost(); |
| 4043 | |
| 4044 | DnsHosts hosts; |
| 4045 | hosts[DnsHostsKey("nx_ipv4", ADDRESS_FAMILY_IPV4)] = local_ipv4; |
| 4046 | hosts[DnsHostsKey("nx_ipv6", ADDRESS_FAMILY_IPV6)] = local_ipv6; |
| 4047 | hosts[DnsHostsKey("nx_both", ADDRESS_FAMILY_IPV4)] = local_ipv4; |
| 4048 | hosts[DnsHostsKey("nx_both", ADDRESS_FAMILY_IPV6)] = local_ipv6; |
| 4049 | |
| 4050 | // Update HOSTS file. |
| 4051 | config.hosts = hosts; |
| 4052 | ChangeDnsConfig(config); |
| 4053 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4054 | ResolveHostResponseHelper response_ipv4(resolver_->CreateRequest( |
| 4055 | HostPortPair("nx_ipv4", 80), NetLogWithSource(), base::nullopt, |
| 4056 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4057 | EXPECT_THAT(response_ipv4.result_error(), IsOk()); |
| 4058 | EXPECT_THAT(response_ipv4.request()->GetAddressResults().value().endpoints(), |
| 4059 | testing::ElementsAre(CreateExpected("127.0.0.1", 80))); |
| 4060 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4061 | ResolveHostResponseHelper response_ipv6(resolver_->CreateRequest( |
| 4062 | HostPortPair("nx_ipv6", 80), NetLogWithSource(), base::nullopt, |
| 4063 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4064 | EXPECT_THAT(response_ipv6.result_error(), IsOk()); |
| 4065 | EXPECT_THAT(response_ipv6.request()->GetAddressResults().value().endpoints(), |
| 4066 | testing::ElementsAre(CreateExpected("::1", 80))); |
| 4067 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4068 | ResolveHostResponseHelper response_both(resolver_->CreateRequest( |
| 4069 | HostPortPair("nx_both", 80), NetLogWithSource(), base::nullopt, |
| 4070 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4071 | EXPECT_THAT(response_both.result_error(), IsOk()); |
| 4072 | EXPECT_THAT(response_both.request()->GetAddressResults().value().endpoints(), |
| 4073 | testing::UnorderedElementsAre(CreateExpected("127.0.0.1", 80), |
| 4074 | CreateExpected("::1", 80))); |
| 4075 | |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 4076 | // Requests with specified DNS query type. |
| 4077 | HostResolver::ResolveHostParameters parameters; |
| 4078 | |
Eric Orth | 192e3bb | 2018-11-14 19:30:32 | [diff] [blame] | 4079 | parameters.dns_query_type = DnsQueryType::A; |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4080 | ResolveHostResponseHelper response_specified_ipv4(resolver_->CreateRequest( |
| 4081 | HostPortPair("nx_ipv4", 80), NetLogWithSource(), parameters, |
| 4082 | request_context_.get(), host_cache_.get())); |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 4083 | EXPECT_THAT(response_specified_ipv4.result_error(), IsOk()); |
| 4084 | EXPECT_THAT(response_specified_ipv4.request() |
| 4085 | ->GetAddressResults() |
| 4086 | .value() |
| 4087 | .endpoints(), |
| 4088 | testing::ElementsAre(CreateExpected("127.0.0.1", 80))); |
| 4089 | |
Eric Orth | 192e3bb | 2018-11-14 19:30:32 | [diff] [blame] | 4090 | parameters.dns_query_type = DnsQueryType::AAAA; |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4091 | ResolveHostResponseHelper response_specified_ipv6(resolver_->CreateRequest( |
| 4092 | HostPortPair("nx_ipv6", 80), NetLogWithSource(), parameters, |
| 4093 | request_context_.get(), host_cache_.get())); |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 4094 | EXPECT_THAT(response_specified_ipv6.result_error(), IsOk()); |
| 4095 | EXPECT_THAT(response_specified_ipv6.request() |
| 4096 | ->GetAddressResults() |
| 4097 | .value() |
| 4098 | .endpoints(), |
| 4099 | testing::ElementsAre(CreateExpected("::1", 80))); |
| 4100 | |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4101 | // Request with upper case. |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4102 | ResolveHostResponseHelper response_upper(resolver_->CreateRequest( |
| 4103 | HostPortPair("nx_IPV4", 80), NetLogWithSource(), base::nullopt, |
| 4104 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4105 | EXPECT_THAT(response_upper.result_error(), IsOk()); |
| 4106 | EXPECT_THAT(response_upper.request()->GetAddressResults().value().endpoints(), |
| 4107 | testing::ElementsAre(CreateExpected("127.0.0.1", 80))); |
| 4108 | } |
| 4109 | |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 4110 | TEST_F(HostResolverManagerDnsTest, SkipHostsWithUpcomingProcTask) { |
| 4111 | // Disable the DnsClient. |
| 4112 | resolver_->SetInsecureDnsClientEnabled(false); |
| 4113 | |
| 4114 | proc_->AddRuleForAllFamilies(std::string(), |
| 4115 | std::string()); // Default to failures. |
| 4116 | proc_->SignalMultiple(1u); // For the first request which misses. |
| 4117 | |
| 4118 | DnsConfig config = CreateValidDnsConfig(); |
| 4119 | DnsHosts hosts; |
| 4120 | hosts[DnsHostsKey("hosts", ADDRESS_FAMILY_IPV4)] = IPAddress::IPv4Localhost(); |
| 4121 | |
| 4122 | // Update HOSTS file. |
| 4123 | config.hosts = hosts; |
| 4124 | ChangeDnsConfig(config); |
| 4125 | |
| 4126 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 4127 | HostPortPair("hosts", 80), NetLogWithSource(), base::nullopt, |
| 4128 | request_context_.get(), host_cache_.get())); |
| 4129 | EXPECT_THAT(response.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 4130 | } |
| 4131 | |
Eric Orth | dc35748e | 2018-08-23 22:41:48 | [diff] [blame] | 4132 | // Test that hosts ending in ".local" or ".local." are resolved using the system |
| 4133 | // resolver. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 4134 | TEST_F(HostResolverManagerDnsTest, BypassDnsTask) { |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4135 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 4136 | |
| 4137 | proc_->AddRuleForAllFamilies(std::string(), |
| 4138 | std::string()); // Default to failures. |
| 4139 | |
| 4140 | std::vector<std::unique_ptr<ResolveHostResponseHelper>> responses; |
| 4141 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4142 | responses.emplace_back( |
| 4143 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 4144 | HostPortPair("ok.local", 80), NetLogWithSource(), base::nullopt, |
| 4145 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4146 | responses.emplace_back( |
| 4147 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 4148 | HostPortPair("ok.local.", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4149 | request_context_.get(), host_cache_.get()))); |
| 4150 | responses.emplace_back( |
| 4151 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 4152 | HostPortPair("oklocal", 80), NetLogWithSource(), base::nullopt, |
| 4153 | request_context_.get(), host_cache_.get()))); |
| 4154 | responses.emplace_back( |
| 4155 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 4156 | HostPortPair("oklocal.", 80), NetLogWithSource(), base::nullopt, |
| 4157 | request_context_.get(), host_cache_.get()))); |
| 4158 | responses.emplace_back( |
| 4159 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 4160 | HostPortPair("ok", 80), NetLogWithSource(), base::nullopt, |
| 4161 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4162 | |
| 4163 | proc_->SignalMultiple(5u); |
| 4164 | |
| 4165 | for (size_t i = 0; i < 2; ++i) |
| 4166 | EXPECT_THAT(responses[i]->result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 4167 | |
| 4168 | for (size_t i = 2; i < responses.size(); ++i) |
| 4169 | EXPECT_THAT(responses[i]->result_error(), IsOk()); |
| 4170 | } |
| 4171 | |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 4172 | #if BUILDFLAG(ENABLE_MDNS) |
| 4173 | // Test that non-address queries for hosts ending in ".local" are resolved using |
| 4174 | // the MDNS resolver. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 4175 | TEST_F(HostResolverManagerDnsTest, BypassDnsToMdnsWithNonAddress) { |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 4176 | // Ensure DNS task and system (proc) requests will fail. |
| 4177 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 4178 | rules.emplace_back( |
| 4179 | "myhello.local", dns_protocol::kTypeTXT, false /* secure */, |
| 4180 | MockDnsClientRule::Result(MockDnsClientRule::FAIL), false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 4181 | CreateResolver(); |
| 4182 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 4183 | proc_->AddRuleForAllFamilies(std::string(), std::string()); |
| 4184 | |
| 4185 | auto socket_factory = std::make_unique<MockMDnsSocketFactory>(); |
| 4186 | MockMDnsSocketFactory* socket_factory_ptr = socket_factory.get(); |
| 4187 | resolver_->SetMdnsSocketFactoryForTesting(std::move(socket_factory)); |
| 4188 | // 2 socket creations for every transaction. |
| 4189 | EXPECT_CALL(*socket_factory_ptr, OnSendTo(_)).Times(2); |
| 4190 | |
| 4191 | HostResolver::ResolveHostParameters dns_parameters; |
| 4192 | dns_parameters.dns_query_type = DnsQueryType::TXT; |
| 4193 | |
| 4194 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 4195 | HostPortPair("myhello.local", 80), NetLogWithSource(), dns_parameters, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4196 | request_context_.get(), host_cache_.get())); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 4197 | |
| 4198 | socket_factory_ptr->SimulateReceive(kMdnsResponseTxt, |
| 4199 | sizeof(kMdnsResponseTxt)); |
| 4200 | proc_->SignalMultiple(1u); |
| 4201 | |
| 4202 | EXPECT_THAT(response.result_error(), IsOk()); |
| 4203 | EXPECT_THAT(response.request()->GetTextResults(), |
| 4204 | testing::Optional(testing::ElementsAre("foo", "bar"))); |
| 4205 | } |
| 4206 | #endif // BUILDFLAG(ENABLE_MDNS) |
| 4207 | |
Eric Orth | dc35748e | 2018-08-23 22:41:48 | [diff] [blame] | 4208 | // Test that DNS task is always used when explicitly requested as the source, |
| 4209 | // even with a case that would normally bypass it eg hosts ending in ".local". |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 4210 | TEST_F(HostResolverManagerDnsTest, DnsNotBypassedWhenDnsSource) { |
Eric Orth | dc35748e | 2018-08-23 22:41:48 | [diff] [blame] | 4211 | // Ensure DNS task requests will succeed and system (proc) requests will fail. |
| 4212 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 4213 | proc_->AddRuleForAllFamilies(std::string(), std::string()); |
| 4214 | |
| 4215 | HostResolver::ResolveHostParameters dns_parameters; |
| 4216 | dns_parameters.source = HostResolverSource::DNS; |
| 4217 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4218 | ResolveHostResponseHelper dns_response(resolver_->CreateRequest( |
| 4219 | HostPortPair("ok", 80), NetLogWithSource(), dns_parameters, |
| 4220 | request_context_.get(), host_cache_.get())); |
| 4221 | ResolveHostResponseHelper dns_local_response(resolver_->CreateRequest( |
| 4222 | HostPortPair("ok.local", 80), NetLogWithSource(), dns_parameters, |
| 4223 | request_context_.get(), host_cache_.get())); |
| 4224 | ResolveHostResponseHelper normal_local_response(resolver_->CreateRequest( |
| 4225 | HostPortPair("ok.local", 80), NetLogWithSource(), base::nullopt, |
| 4226 | request_context_.get(), host_cache_.get())); |
Eric Orth | dc35748e | 2018-08-23 22:41:48 | [diff] [blame] | 4227 | |
| 4228 | proc_->SignalMultiple(3u); |
| 4229 | |
| 4230 | EXPECT_THAT(dns_response.result_error(), IsOk()); |
| 4231 | EXPECT_THAT(dns_local_response.result_error(), IsOk()); |
| 4232 | EXPECT_THAT(normal_local_response.result_error(), |
| 4233 | IsError(ERR_NAME_NOT_RESOLVED)); |
| 4234 | } |
| 4235 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 4236 | TEST_F(HostResolverManagerDnsTest, SystemOnlyBypassesDnsTask) { |
Eric Orth | dc35748e | 2018-08-23 22:41:48 | [diff] [blame] | 4237 | // Ensure DNS task requests will succeed and system (proc) requests will fail. |
| 4238 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 4239 | proc_->AddRuleForAllFamilies(std::string(), std::string()); |
| 4240 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4241 | ResolveHostResponseHelper dns_response(resolver_->CreateRequest( |
| 4242 | HostPortPair("ok", 80), NetLogWithSource(), base::nullopt, |
| 4243 | request_context_.get(), host_cache_.get())); |
Eric Orth | dc35748e | 2018-08-23 22:41:48 | [diff] [blame] | 4244 | |
| 4245 | HostResolver::ResolveHostParameters parameters; |
| 4246 | parameters.source = HostResolverSource::SYSTEM; |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4247 | ResolveHostResponseHelper system_response(resolver_->CreateRequest( |
| 4248 | HostPortPair("ok", 80), NetLogWithSource(), parameters, |
| 4249 | request_context_.get(), host_cache_.get())); |
Eric Orth | dc35748e | 2018-08-23 22:41:48 | [diff] [blame] | 4250 | |
| 4251 | proc_->SignalMultiple(2u); |
| 4252 | |
| 4253 | EXPECT_THAT(dns_response.result_error(), IsOk()); |
| 4254 | EXPECT_THAT(system_response.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 4255 | } |
| 4256 | |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 4257 | TEST_F(HostResolverManagerDnsTest, |
| 4258 | DisableInsecureDnsClientOnPersistentFailure) { |
[email protected] | f0f602bd | 2012-11-15 18:01:02 | [diff] [blame] | 4259 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 4260 | |
[email protected] | 007b3f8 | 2013-04-09 08:46:45 | [diff] [blame] | 4261 | proc_->AddRuleForAllFamilies(std::string(), |
| 4262 | std::string()); // Default to failures. |
[email protected] | f0f602bd | 2012-11-15 18:01:02 | [diff] [blame] | 4263 | |
| 4264 | // Check that DnsTask works. |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4265 | ResolveHostResponseHelper initial_response(resolver_->CreateRequest( |
| 4266 | HostPortPair("ok_1", 80), NetLogWithSource(), base::nullopt, |
| 4267 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4268 | EXPECT_THAT(initial_response.result_error(), IsOk()); |
| 4269 | |
| 4270 | std::vector<std::unique_ptr<ResolveHostResponseHelper>> responses; |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 4271 | for (unsigned i = 0; i < maximum_insecure_dns_task_failures(); ++i) { |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4272 | // Use custom names to require separate Jobs. |
| 4273 | std::string hostname = base::StringPrintf("nx_%u", i); |
| 4274 | // Ensure fallback to ProcTask succeeds. |
| 4275 | proc_->AddRuleForAllFamilies(hostname, "192.168.1.101"); |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4276 | responses.emplace_back( |
| 4277 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 4278 | HostPortPair(hostname, 80), NetLogWithSource(), base::nullopt, |
| 4279 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4280 | } |
| 4281 | |
| 4282 | proc_->SignalMultiple(responses.size()); |
| 4283 | |
| 4284 | for (size_t i = 0; i < responses.size(); ++i) |
| 4285 | EXPECT_THAT(responses[i]->result_error(), IsOk()); |
| 4286 | |
| 4287 | ASSERT_FALSE(proc_->HasBlockedRequests()); |
| 4288 | |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 4289 | // Insecure DnsTasks should be disabled by now unless explicitly requested via |
| 4290 | // |source|. |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4291 | ResolveHostResponseHelper fail_response(resolver_->CreateRequest( |
| 4292 | HostPortPair("ok_2", 80), NetLogWithSource(), base::nullopt, |
| 4293 | request_context_.get(), host_cache_.get())); |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 4294 | HostResolver::ResolveHostParameters parameters; |
| 4295 | parameters.source = HostResolverSource::DNS; |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4296 | ResolveHostResponseHelper dns_response(resolver_->CreateRequest( |
| 4297 | HostPortPair("ok_2", 80), NetLogWithSource(), parameters, |
| 4298 | request_context_.get(), host_cache_.get())); |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 4299 | proc_->SignalMultiple(2u); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4300 | EXPECT_THAT(fail_response.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 4301 | EXPECT_THAT(dns_response.result_error(), IsOk()); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4302 | |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 4303 | // Secure DnsTasks should not be affected. |
| 4304 | HostResolver::ResolveHostParameters secure_parameters; |
| 4305 | secure_parameters.secure_dns_mode_override = |
| 4306 | DnsConfig::SecureDnsMode::AUTOMATIC; |
| 4307 | ResolveHostResponseHelper secure_response(resolver_->CreateRequest( |
| 4308 | HostPortPair("automatic", 80), NetLogWithSource(), secure_parameters, |
| 4309 | request_context_.get(), host_cache_.get())); |
| 4310 | EXPECT_THAT(secure_response.result_error(), IsOk()); |
| 4311 | |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4312 | // Check that it is re-enabled after DNS change. |
| 4313 | ChangeDnsConfig(CreateValidDnsConfig()); |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4314 | ResolveHostResponseHelper reenabled_response(resolver_->CreateRequest( |
| 4315 | HostPortPair("ok_3", 80), NetLogWithSource(), base::nullopt, |
| 4316 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4317 | EXPECT_THAT(reenabled_response.result_error(), IsOk()); |
| 4318 | } |
| 4319 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 4320 | TEST_F(HostResolverManagerDnsTest, DontDisableDnsClientOnSporadicFailure) { |
[email protected] | f0f602bd | 2012-11-15 18:01:02 | [diff] [blame] | 4321 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 4322 | |
| 4323 | // |proc_| defaults to successes. |
| 4324 | |
| 4325 | // 20 failures interleaved with 20 successes. |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4326 | std::vector<std::unique_ptr<ResolveHostResponseHelper>> responses; |
| 4327 | for (unsigned i = 0; i < 40; ++i) { |
| 4328 | // Use custom names to require separate Jobs. |
| 4329 | std::string hostname = (i % 2) == 0 ? base::StringPrintf("nx_%u", i) |
| 4330 | : base::StringPrintf("ok_%u", i); |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4331 | responses.emplace_back( |
| 4332 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 4333 | HostPortPair(hostname, 80), NetLogWithSource(), base::nullopt, |
| 4334 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4335 | } |
| 4336 | |
| 4337 | proc_->SignalMultiple(40u); |
| 4338 | |
Eric Orth | 26fa08e | 2019-02-22 01:28:37 | [diff] [blame] | 4339 | for (const auto& response : responses) |
| 4340 | EXPECT_THAT(response->result_error(), IsOk()); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4341 | |
| 4342 | // Make |proc_| default to failures. |
| 4343 | proc_->AddRuleForAllFamilies(std::string(), std::string()); |
| 4344 | |
| 4345 | // DnsTask should still be enabled. |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4346 | ResolveHostResponseHelper final_response(resolver_->CreateRequest( |
| 4347 | HostPortPair("ok_last", 80), NetLogWithSource(), base::nullopt, |
| 4348 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4349 | EXPECT_THAT(final_response.result_error(), IsOk()); |
| 4350 | } |
| 4351 | |
[email protected] | ec666ab2 | 2013-04-17 20:05:59 | [diff] [blame] | 4352 | // Confirm that resolving "localhost" is unrestricted even if there are no |
| 4353 | // global IPv6 address. See SystemHostResolverCall for rationale. |
| 4354 | // Test both the DnsClient and system host resolver paths. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 4355 | TEST_F(HostResolverManagerDnsTest, DualFamilyLocalhost) { |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4356 | CreateResolverWithLimitsAndParams(kMaxJobs, DefaultParams(proc_.get()), |
Eric Orth | 607b6d8 | 2019-05-08 16:43:32 | [diff] [blame] | 4357 | false /* ipv6_reachable */, |
| 4358 | true /* check_ipv6_on_wifi */); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4359 | |
| 4360 | // Make request fail if we actually get to the system resolver. |
| 4361 | proc_->AddRuleForAllFamilies(std::string(), std::string()); |
| 4362 | |
| 4363 | // Try without DnsClient. |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 4364 | resolver_->SetInsecureDnsClientEnabled(false); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4365 | ResolveHostResponseHelper system_response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 4366 | HostPortPair("localhost", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4367 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4368 | EXPECT_THAT(system_response.result_error(), IsOk()); |
| 4369 | EXPECT_THAT( |
| 4370 | system_response.request()->GetAddressResults().value().endpoints(), |
| 4371 | testing::UnorderedElementsAre(CreateExpected("127.0.0.1", 80), |
| 4372 | CreateExpected("::1", 80))); |
| 4373 | |
| 4374 | // With DnsClient |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 4375 | UseMockDnsClient(CreateValidDnsConfig(), CreateDefaultDnsRules()); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4376 | ResolveHostResponseHelper builtin_response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 4377 | HostPortPair("localhost", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4378 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4379 | EXPECT_THAT(builtin_response.result_error(), IsOk()); |
| 4380 | EXPECT_THAT( |
| 4381 | builtin_response.request()->GetAddressResults().value().endpoints(), |
| 4382 | testing::UnorderedElementsAre(CreateExpected("127.0.0.1", 80), |
| 4383 | CreateExpected("::1", 80))); |
| 4384 | |
| 4385 | // DnsClient configured without ipv6 (but ipv6 should still work for |
| 4386 | // localhost). |
| 4387 | DnsConfig config = CreateValidDnsConfig(); |
| 4388 | config.use_local_ipv6 = false; |
| 4389 | ChangeDnsConfig(config); |
| 4390 | ResolveHostResponseHelper ipv6_disabled_response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 4391 | HostPortPair("localhost", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4392 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4393 | EXPECT_THAT(ipv6_disabled_response.result_error(), IsOk()); |
| 4394 | EXPECT_THAT( |
| 4395 | ipv6_disabled_response.request()->GetAddressResults().value().endpoints(), |
| 4396 | testing::UnorderedElementsAre(CreateExpected("127.0.0.1", 80), |
| 4397 | CreateExpected("::1", 80))); |
| 4398 | } |
| 4399 | |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 4400 | TEST_F(HostResolverManagerDnsTest, SeparateJobsBySecureDnsMode) { |
| 4401 | MockDnsClientRuleList rules; |
| 4402 | rules.emplace_back("a", dns_protocol::kTypeA, true /* secure */, |
| 4403 | MockDnsClientRule::Result(MockDnsClientRule::FAIL), |
| 4404 | true /* delay */); |
| 4405 | rules.emplace_back("a", dns_protocol::kTypeAAAA, true /* secure */, |
| 4406 | MockDnsClientRule::Result(MockDnsClientRule::FAIL), |
| 4407 | true /* delay */); |
| 4408 | rules.emplace_back("a", dns_protocol::kTypeA, false /* secure */, |
| 4409 | MockDnsClientRule::Result(MockDnsClientRule::OK), |
| 4410 | false /* delay */); |
| 4411 | rules.emplace_back("a", dns_protocol::kTypeAAAA, false /* secure */, |
| 4412 | MockDnsClientRule::Result(MockDnsClientRule::OK), |
| 4413 | false /* delay */); |
| 4414 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 4415 | DnsConfigOverrides overrides; |
| 4416 | overrides.secure_dns_mode = DnsConfig::SecureDnsMode::AUTOMATIC; |
| 4417 | resolver_->SetDnsConfigOverrides(overrides); |
| 4418 | |
| 4419 | // Create three requests. One with a SECURE mode override, one with no |
| 4420 | // mode override, and one with an AUTOMATIC mode override (which is a no-op |
| 4421 | // since the DnsConfig uses AUTOMATIC). |
| 4422 | HostResolver::ResolveHostParameters parameters_secure_override; |
| 4423 | parameters_secure_override.secure_dns_mode_override = |
| 4424 | DnsConfig::SecureDnsMode::SECURE; |
| 4425 | ResolveHostResponseHelper secure_response(resolver_->CreateRequest( |
| 4426 | HostPortPair("a", 80), NetLogWithSource(), parameters_secure_override, |
| 4427 | request_context_.get(), host_cache_.get())); |
| 4428 | EXPECT_EQ(1u, resolver_->num_jobs_for_testing()); |
| 4429 | |
| 4430 | ResolveHostResponseHelper automatic_response0(resolver_->CreateRequest( |
| 4431 | HostPortPair("a", 80), NetLogWithSource(), base::nullopt, |
| 4432 | request_context_.get(), host_cache_.get())); |
| 4433 | EXPECT_EQ(2u, resolver_->num_jobs_for_testing()); |
| 4434 | |
| 4435 | HostResolver::ResolveHostParameters parameters_automatic_override; |
| 4436 | parameters_automatic_override.secure_dns_mode_override = |
| 4437 | DnsConfig::SecureDnsMode::AUTOMATIC; |
| 4438 | ResolveHostResponseHelper automatic_response1(resolver_->CreateRequest( |
| 4439 | HostPortPair("a", 80), NetLogWithSource(), parameters_automatic_override, |
| 4440 | request_context_.get(), host_cache_.get())); |
| 4441 | // The AUTOMATIC mode requests should be joined into the same job. |
| 4442 | EXPECT_EQ(2u, resolver_->num_jobs_for_testing()); |
| 4443 | |
| 4444 | // All requests should be blocked on the secure transactions. |
| 4445 | base::RunLoop().RunUntilIdle(); |
| 4446 | EXPECT_FALSE(secure_response.complete()); |
| 4447 | EXPECT_FALSE(automatic_response0.complete()); |
| 4448 | EXPECT_FALSE(automatic_response1.complete()); |
| 4449 | |
| 4450 | // Complete secure transactions. |
| 4451 | dns_client_->CompleteDelayedTransactions(); |
| 4452 | EXPECT_THAT(secure_response.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 4453 | EXPECT_THAT(automatic_response0.result_error(), IsOk()); |
| 4454 | EXPECT_THAT(automatic_response1.result_error(), IsOk()); |
| 4455 | } |
| 4456 | |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 4457 | // Cancel a request with a single DNS transaction active. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 4458 | TEST_F(HostResolverManagerDnsTest, CancelWithOneTransactionActive) { |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4459 | // Disable ipv6 to ensure we'll only try a single transaction for the host. |
| 4460 | CreateResolverWithLimitsAndParams(kMaxJobs, DefaultParams(proc_.get()), |
Eric Orth | 607b6d8 | 2019-05-08 16:43:32 | [diff] [blame] | 4461 | false /* ipv6_reachable */, |
| 4462 | true /* check_ipv6_on_wifi */); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4463 | DnsConfig config = CreateValidDnsConfig(); |
| 4464 | config.use_local_ipv6 = false; |
| 4465 | ChangeDnsConfig(config); |
| 4466 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4467 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 4468 | HostPortPair("ok", 80), NetLogWithSource(), base::nullopt, |
| 4469 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4470 | ASSERT_FALSE(response.complete()); |
| 4471 | ASSERT_EQ(1u, num_running_dispatcher_jobs()); |
| 4472 | |
| 4473 | response.CancelRequest(); |
| 4474 | base::RunLoop().RunUntilIdle(); |
| 4475 | EXPECT_FALSE(response.complete()); |
| 4476 | |
| 4477 | // Dispatcher state checked in TearDown. |
| 4478 | } |
| 4479 | |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 4480 | // Cancel a request with a single DNS transaction active and another pending. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 4481 | TEST_F(HostResolverManagerDnsTest, CancelWithOneTransactionActiveOnePending) { |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 4482 | CreateSerialResolver(); |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 4483 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 4484 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4485 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 4486 | HostPortPair("ok", 80), NetLogWithSource(), base::nullopt, |
| 4487 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4488 | EXPECT_EQ(1u, num_running_dispatcher_jobs()); |
| 4489 | |
| 4490 | response.CancelRequest(); |
| 4491 | base::RunLoop().RunUntilIdle(); |
| 4492 | EXPECT_FALSE(response.complete()); |
| 4493 | |
| 4494 | // Dispatcher state checked in TearDown. |
| 4495 | } |
| 4496 | |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 4497 | // Cancel a request with two DNS transactions active. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 4498 | TEST_F(HostResolverManagerDnsTest, CancelWithTwoTransactionsActive) { |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 4499 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 4500 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4501 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 4502 | HostPortPair("ok", 80), NetLogWithSource(), base::nullopt, |
| 4503 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4504 | EXPECT_EQ(2u, num_running_dispatcher_jobs()); |
| 4505 | |
| 4506 | response.CancelRequest(); |
| 4507 | base::RunLoop().RunUntilIdle(); |
| 4508 | EXPECT_FALSE(response.complete()); |
| 4509 | |
| 4510 | // Dispatcher state checked in TearDown. |
| 4511 | } |
| 4512 | |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 4513 | // Delete a resolver with some active requests and some queued requests. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 4514 | TEST_F(HostResolverManagerDnsTest, DeleteWithActiveTransactions) { |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 4515 | // At most 10 Jobs active at once. |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4516 | CreateResolverWithLimitsAndParams(10u, DefaultParams(proc_.get()), |
Eric Orth | 607b6d8 | 2019-05-08 16:43:32 | [diff] [blame] | 4517 | true /* ipv6_reachable */, |
| 4518 | true /* check_ipv6_on_wifi */); |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 4519 | |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 4520 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 4521 | |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4522 | // Add 12 DNS lookups (creating well more than 10 transaction). |
| 4523 | std::vector<std::unique_ptr<ResolveHostResponseHelper>> responses; |
| 4524 | for (int i = 0; i < 12; ++i) { |
| 4525 | std::string hostname = base::StringPrintf("ok%i", i); |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4526 | responses.emplace_back( |
| 4527 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 4528 | HostPortPair(hostname, 80), NetLogWithSource(), base::nullopt, |
| 4529 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4530 | } |
| 4531 | EXPECT_EQ(10u, num_running_dispatcher_jobs()); |
| 4532 | |
Eric Orth | 37b1819 | 2019-04-22 19:09:28 | [diff] [blame] | 4533 | DestroyResolver(); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4534 | |
| 4535 | base::RunLoop().RunUntilIdle(); |
| 4536 | for (auto& response : responses) { |
| 4537 | EXPECT_FALSE(response->complete()); |
| 4538 | } |
| 4539 | } |
| 4540 | |
Eric Orth | 5233c3a | 2019-04-08 17:01:14 | [diff] [blame] | 4541 | TEST_F(HostResolverManagerDnsTest, DeleteWithCompletedRequests) { |
| 4542 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 4543 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4544 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 4545 | HostPortPair("ok", 80), NetLogWithSource(), base::nullopt, |
| 4546 | request_context_.get(), host_cache_.get())); |
Eric Orth | 5233c3a | 2019-04-08 17:01:14 | [diff] [blame] | 4547 | |
| 4548 | EXPECT_THAT(response.result_error(), IsOk()); |
| 4549 | EXPECT_THAT(response.request()->GetAddressResults().value().endpoints(), |
| 4550 | testing::UnorderedElementsAre(CreateExpected("127.0.0.1", 80), |
| 4551 | CreateExpected("::1", 80))); |
| 4552 | |
Eric Orth | 37b1819 | 2019-04-22 19:09:28 | [diff] [blame] | 4553 | DestroyResolver(); |
Eric Orth | 5233c3a | 2019-04-08 17:01:14 | [diff] [blame] | 4554 | |
| 4555 | // Completed requests should be unaffected by manager destruction. |
| 4556 | EXPECT_THAT(response.request()->GetAddressResults().value().endpoints(), |
| 4557 | testing::UnorderedElementsAre(CreateExpected("127.0.0.1", 80), |
| 4558 | CreateExpected("::1", 80))); |
| 4559 | } |
| 4560 | |
| 4561 | TEST_F(HostResolverManagerDnsTest, ExplicitCancel) { |
| 4562 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 4563 | |
| 4564 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 4565 | HostPortPair("4slow_4ok", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4566 | request_context_.get(), host_cache_.get())); |
Eric Orth | 5233c3a | 2019-04-08 17:01:14 | [diff] [blame] | 4567 | |
| 4568 | response.request()->Cancel(); |
| 4569 | dns_client_->CompleteDelayedTransactions(); |
| 4570 | |
| 4571 | base::RunLoop().RunUntilIdle(); |
| 4572 | EXPECT_FALSE(response.complete()); |
| 4573 | } |
| 4574 | |
| 4575 | TEST_F(HostResolverManagerDnsTest, ExplicitCancel_Completed) { |
| 4576 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 4577 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4578 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 4579 | HostPortPair("ok", 80), NetLogWithSource(), base::nullopt, |
| 4580 | request_context_.get(), host_cache_.get())); |
Eric Orth | 5233c3a | 2019-04-08 17:01:14 | [diff] [blame] | 4581 | |
| 4582 | EXPECT_THAT(response.result_error(), IsOk()); |
| 4583 | EXPECT_THAT(response.request()->GetAddressResults().value().endpoints(), |
| 4584 | testing::UnorderedElementsAre(CreateExpected("127.0.0.1", 80), |
| 4585 | CreateExpected("::1", 80))); |
| 4586 | |
| 4587 | response.request()->Cancel(); |
| 4588 | |
| 4589 | // Completed requests should be unaffected by cancellation. |
| 4590 | EXPECT_THAT(response.request()->GetAddressResults().value().endpoints(), |
| 4591 | testing::UnorderedElementsAre(CreateExpected("127.0.0.1", 80), |
| 4592 | CreateExpected("::1", 80))); |
| 4593 | } |
| 4594 | |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 4595 | // Cancel a request with only the IPv6 transaction active. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 4596 | TEST_F(HostResolverManagerDnsTest, CancelWithIPv6TransactionActive) { |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 4597 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 4598 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4599 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 4600 | HostPortPair("6slow_ok", 80), NetLogWithSource(), base::nullopt, |
| 4601 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4602 | EXPECT_EQ(2u, num_running_dispatcher_jobs()); |
| 4603 | |
| 4604 | // The IPv4 request should complete, the IPv6 request is still pending. |
| 4605 | base::RunLoop().RunUntilIdle(); |
| 4606 | EXPECT_EQ(1u, num_running_dispatcher_jobs()); |
| 4607 | |
| 4608 | response.CancelRequest(); |
| 4609 | base::RunLoop().RunUntilIdle(); |
| 4610 | EXPECT_FALSE(response.complete()); |
| 4611 | |
| 4612 | // Dispatcher state checked in TearDown. |
| 4613 | } |
| 4614 | |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 4615 | // Cancel a request with only the IPv4 transaction pending. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 4616 | TEST_F(HostResolverManagerDnsTest, CancelWithIPv4TransactionPending) { |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 4617 | set_allow_fallback_to_proctask(false); |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 4618 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 4619 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4620 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 4621 | HostPortPair("4slow_ok", 80), NetLogWithSource(), base::nullopt, |
| 4622 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4623 | EXPECT_EQ(2u, num_running_dispatcher_jobs()); |
| 4624 | |
| 4625 | // The IPv6 request should complete, the IPv4 request is still pending. |
| 4626 | base::RunLoop().RunUntilIdle(); |
| 4627 | EXPECT_EQ(1u, num_running_dispatcher_jobs()); |
| 4628 | |
| 4629 | response.CancelRequest(); |
| 4630 | base::RunLoop().RunUntilIdle(); |
| 4631 | EXPECT_FALSE(response.complete()); |
| 4632 | } |
| 4633 | |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 4634 | TEST_F(HostResolverManagerDnsTest, CancelWithAutomaticModeTransactionPending) { |
| 4635 | MockDnsClientRuleList rules; |
| 4636 | rules.emplace_back("secure_6slow_6nx_insecure_6slow_ok", dns_protocol::kTypeA, |
| 4637 | true /* secure */, |
| 4638 | MockDnsClientRule::Result(MockDnsClientRule::OK), |
| 4639 | false /* delay */); |
| 4640 | rules.emplace_back("secure_6slow_6nx_insecure_6slow_ok", |
| 4641 | dns_protocol::kTypeAAAA, true /* secure */, |
| 4642 | MockDnsClientRule::Result(MockDnsClientRule::FAIL), |
| 4643 | true /* delay */); |
| 4644 | rules.emplace_back("secure_6slow_6nx_insecure_6slow_ok", dns_protocol::kTypeA, |
| 4645 | false /* secure */, |
| 4646 | MockDnsClientRule::Result(MockDnsClientRule::OK), |
| 4647 | false /* delay */); |
| 4648 | rules.emplace_back("secure_6slow_6nx_insecure_6slow_ok", |
| 4649 | dns_protocol::kTypeAAAA, false /* secure */, |
| 4650 | MockDnsClientRule::Result(MockDnsClientRule::OK), |
| 4651 | true /* delay */); |
| 4652 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 4653 | |
| 4654 | DnsConfigOverrides overrides; |
| 4655 | overrides.secure_dns_mode = DnsConfig::SecureDnsMode::AUTOMATIC; |
| 4656 | resolver_->SetDnsConfigOverrides(overrides); |
| 4657 | |
| 4658 | ResolveHostResponseHelper response0(resolver_->CreateRequest( |
| 4659 | HostPortPair("secure_6slow_6nx_insecure_6slow_ok", 80), |
| 4660 | NetLogWithSource(), base::nullopt, request_context_.get(), |
| 4661 | host_cache_.get())); |
| 4662 | EXPECT_EQ(2u, num_running_dispatcher_jobs()); |
| 4663 | |
| 4664 | // The secure IPv4 request should complete, the secure IPv6 request is still |
| 4665 | // pending. |
| 4666 | base::RunLoop().RunUntilIdle(); |
| 4667 | EXPECT_EQ(1u, num_running_dispatcher_jobs()); |
| 4668 | |
| 4669 | response0.CancelRequest(); |
| 4670 | base::RunLoop().RunUntilIdle(); |
| 4671 | EXPECT_FALSE(response0.complete()); |
| 4672 | EXPECT_EQ(0u, num_running_dispatcher_jobs()); |
| 4673 | |
| 4674 | ResolveHostResponseHelper response1(resolver_->CreateRequest( |
| 4675 | HostPortPair("secure_6slow_6nx_insecure_6slow_ok", 80), |
| 4676 | NetLogWithSource(), base::nullopt, request_context_.get(), |
| 4677 | host_cache_.get())); |
| 4678 | EXPECT_EQ(2u, num_running_dispatcher_jobs()); |
| 4679 | |
| 4680 | // The secure IPv4 request should complete, the secure IPv6 request is still |
| 4681 | // pending. |
| 4682 | base::RunLoop().RunUntilIdle(); |
| 4683 | EXPECT_EQ(1u, num_running_dispatcher_jobs()); |
| 4684 | |
| 4685 | // Let the secure IPv6 request complete and start the insecure requests. |
| 4686 | dns_client_->CompleteDelayedTransactions(); |
| 4687 | EXPECT_EQ(2u, num_running_dispatcher_jobs()); |
| 4688 | |
| 4689 | // The insecure IPv4 request should complete, the insecure IPv6 request is |
| 4690 | // still pending. |
| 4691 | base::RunLoop().RunUntilIdle(); |
| 4692 | EXPECT_EQ(1u, num_running_dispatcher_jobs()); |
| 4693 | |
| 4694 | response1.CancelRequest(); |
| 4695 | base::RunLoop().RunUntilIdle(); |
| 4696 | EXPECT_FALSE(response1.complete()); |
| 4697 | |
| 4698 | // Dispatcher state checked in TearDown. |
| 4699 | } |
| 4700 | |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 4701 | // Test cases where AAAA completes first. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 4702 | TEST_F(HostResolverManagerDnsTest, AAAACompletesFirst) { |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 4703 | set_allow_fallback_to_proctask(false); |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 4704 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 4705 | |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4706 | std::vector<std::unique_ptr<ResolveHostResponseHelper>> responses; |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4707 | responses.emplace_back( |
| 4708 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 4709 | HostPortPair("4slow_ok", 80), NetLogWithSource(), base::nullopt, |
| 4710 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4711 | responses.emplace_back( |
| 4712 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 4713 | HostPortPair("4slow_4ok", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4714 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4715 | responses.emplace_back( |
| 4716 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 4717 | HostPortPair("4slow_4timeout", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4718 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 4719 | responses.emplace_back( |
| 4720 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 4721 | HostPortPair("4slow_6timeout", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4722 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4723 | |
| 4724 | base::RunLoop().RunUntilIdle(); |
| 4725 | EXPECT_FALSE(responses[0]->complete()); |
| 4726 | EXPECT_FALSE(responses[1]->complete()); |
| 4727 | EXPECT_FALSE(responses[2]->complete()); |
| 4728 | // The IPv6 of request 3 should have failed and resulted in cancelling the |
| 4729 | // IPv4 request. |
| 4730 | EXPECT_THAT(responses[3]->result_error(), IsError(ERR_DNS_TIMED_OUT)); |
| 4731 | EXPECT_EQ(3u, num_running_dispatcher_jobs()); |
| 4732 | |
| 4733 | dns_client_->CompleteDelayedTransactions(); |
| 4734 | EXPECT_THAT(responses[0]->result_error(), IsOk()); |
| 4735 | EXPECT_THAT(responses[0]->request()->GetAddressResults().value().endpoints(), |
| 4736 | testing::UnorderedElementsAre(CreateExpected("127.0.0.1", 80), |
| 4737 | CreateExpected("::1", 80))); |
| 4738 | |
| 4739 | EXPECT_THAT(responses[1]->result_error(), IsOk()); |
| 4740 | EXPECT_THAT(responses[1]->request()->GetAddressResults().value().endpoints(), |
| 4741 | testing::ElementsAre(CreateExpected("127.0.0.1", 80))); |
| 4742 | |
| 4743 | EXPECT_THAT(responses[2]->result_error(), IsError(ERR_DNS_TIMED_OUT)); |
| 4744 | } |
| 4745 | |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 4746 | TEST_F(HostResolverManagerDnsTest, AAAACompletesFirst_AutomaticMode) { |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 4747 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 4748 | rules.emplace_back("secure_slow_nx_insecure_4slow_ok", dns_protocol::kTypeA, |
| 4749 | true /* secure */, |
| 4750 | MockDnsClientRule::Result(MockDnsClientRule::FAIL), |
| 4751 | true /* delay */); |
| 4752 | rules.emplace_back("secure_slow_nx_insecure_4slow_ok", |
| 4753 | dns_protocol::kTypeAAAA, true /* secure */, |
| 4754 | MockDnsClientRule::Result(MockDnsClientRule::FAIL), |
| 4755 | true /* delay */); |
| 4756 | rules.emplace_back("secure_slow_nx_insecure_4slow_ok", dns_protocol::kTypeA, |
| 4757 | false /* secure */, |
| 4758 | MockDnsClientRule::Result(MockDnsClientRule::OK), |
| 4759 | true /* delay */); |
| 4760 | rules.emplace_back("secure_slow_nx_insecure_4slow_ok", |
| 4761 | dns_protocol::kTypeAAAA, false /* secure */, |
| 4762 | MockDnsClientRule::Result(MockDnsClientRule::EMPTY), |
| 4763 | false /* delay */); |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 4764 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 4765 | DnsConfigOverrides overrides; |
| 4766 | overrides.secure_dns_mode = DnsConfig::SecureDnsMode::AUTOMATIC; |
| 4767 | resolver_->SetDnsConfigOverrides(overrides); |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 4768 | |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 4769 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 4770 | HostPortPair("secure_slow_nx_insecure_4slow_ok", 80), NetLogWithSource(), |
| 4771 | base::nullopt, request_context_.get(), host_cache_.get())); |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 4772 | base::RunLoop().RunUntilIdle(); |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 4773 | EXPECT_FALSE(response.complete()); |
| 4774 | // Complete the secure transactions. |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 4775 | dns_client_->CompleteDelayedTransactions(); |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 4776 | base::RunLoop().RunUntilIdle(); |
| 4777 | EXPECT_FALSE(response.complete()); |
| 4778 | // Complete the insecure transactions. |
| 4779 | dns_client_->CompleteDelayedTransactions(); |
| 4780 | ASSERT_THAT(response.result_error(), IsOk()); |
| 4781 | EXPECT_THAT(response.request()->GetAddressResults().value().endpoints(), |
| 4782 | testing::ElementsAre(CreateExpected("127.0.0.1", 80))); |
| 4783 | HostCache::Key insecure_key = HostCache::Key( |
| 4784 | "secure_slow_nx_insecure_4slow_ok", DnsQueryType::UNSPECIFIED, |
| 4785 | 0 /* host_resolver_flags */, HostResolverSource::ANY); |
| 4786 | const std::pair<const HostCache::Key, HostCache::Entry>* cache_result = |
| 4787 | GetCacheHit(insecure_key); |
| 4788 | EXPECT_TRUE(!!cache_result); |
| 4789 | } |
| 4790 | |
| 4791 | TEST_F(HostResolverManagerDnsTest, SecureDnsMode_Automatic) { |
| 4792 | proc_->AddRuleForAllFamilies("nx_succeed", "192.168.1.100"); |
| 4793 | set_allow_fallback_to_proctask(true); |
| 4794 | |
| 4795 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 4796 | DnsConfigOverrides overrides; |
| 4797 | overrides.secure_dns_mode = DnsConfig::SecureDnsMode::AUTOMATIC; |
| 4798 | resolver_->SetDnsConfigOverrides(overrides); |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 4799 | const std::pair<const HostCache::Key, HostCache::Entry>* cache_result; |
| 4800 | |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 4801 | // A successful DoH request should result in a secure cache entry. |
| 4802 | ResolveHostResponseHelper response_secure(resolver_->CreateRequest( |
| 4803 | HostPortPair("automatic", 80), NetLogWithSource(), base::nullopt, |
| 4804 | request_context_.get(), host_cache_.get())); |
| 4805 | ASSERT_THAT(response_secure.result_error(), IsOk()); |
| 4806 | EXPECT_THAT( |
| 4807 | response_secure.request()->GetAddressResults().value().endpoints(), |
| 4808 | testing::UnorderedElementsAre(CreateExpected("127.0.0.1", 80), |
| 4809 | CreateExpected("::1", 80))); |
| 4810 | HostCache::Key secure_key = |
| 4811 | HostCache::Key("automatic", DnsQueryType::UNSPECIFIED, |
| 4812 | 0 /* host_resolver_flags */, HostResolverSource::ANY); |
| 4813 | secure_key.secure = true; |
| 4814 | cache_result = GetCacheHit(secure_key); |
| 4815 | EXPECT_TRUE(!!cache_result); |
| 4816 | |
| 4817 | // A successful plaintext DNS request should result in an insecure cache |
| 4818 | // entry. |
| 4819 | ResolveHostResponseHelper response_insecure(resolver_->CreateRequest( |
| 4820 | HostPortPair("insecure_automatic", 80), NetLogWithSource(), base::nullopt, |
| 4821 | request_context_.get(), host_cache_.get())); |
| 4822 | ASSERT_THAT(response_insecure.result_error(), IsOk()); |
| 4823 | EXPECT_THAT( |
| 4824 | response_insecure.request()->GetAddressResults().value().endpoints(), |
| 4825 | testing::UnorderedElementsAre(CreateExpected("127.0.0.1", 80), |
| 4826 | CreateExpected("::1", 80))); |
| 4827 | HostCache::Key insecure_key = |
| 4828 | HostCache::Key("insecure_automatic", DnsQueryType::UNSPECIFIED, |
| 4829 | 0 /* host_resolver_flags */, HostResolverSource::ANY); |
| 4830 | cache_result = GetCacheHit(insecure_key); |
| 4831 | EXPECT_TRUE(!!cache_result); |
| 4832 | |
| 4833 | // Fallback to ProcTask allowed in AUTOMATIC mode. |
| 4834 | ResolveHostResponseHelper response_proc(resolver_->CreateRequest( |
| 4835 | HostPortPair("nx_succeed", 80), NetLogWithSource(), base::nullopt, |
| 4836 | request_context_.get(), host_cache_.get())); |
| 4837 | proc_->SignalMultiple(1u); |
| 4838 | EXPECT_THAT(response_proc.result_error(), IsOk()); |
| 4839 | EXPECT_THAT(response_proc.request()->GetAddressResults().value().endpoints(), |
| 4840 | testing::ElementsAre(CreateExpected("192.168.1.100", 80))); |
| 4841 | } |
| 4842 | |
dalyk | e966a183 | 2019-06-05 20:53:13 | [diff] [blame] | 4843 | TEST_F(HostResolverManagerDnsTest, SecureDnsMode_Automatic_SecureCache) { |
| 4844 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 4845 | DnsConfigOverrides overrides; |
| 4846 | overrides.secure_dns_mode = DnsConfig::SecureDnsMode::AUTOMATIC; |
| 4847 | resolver_->SetDnsConfigOverrides(overrides); |
| 4848 | |
| 4849 | // Populate cache with a secure entry. |
| 4850 | HostCache::Key cached_secure_key = |
| 4851 | HostCache::Key("automatic_cached", DnsQueryType::UNSPECIFIED, |
| 4852 | 0 /* host_resolver_flags */, HostResolverSource::ANY); |
| 4853 | cached_secure_key.secure = true; |
| 4854 | IPEndPoint kExpectedSecureIP = CreateExpected("192.168.1.102", 80); |
| 4855 | PopulateCache(cached_secure_key, kExpectedSecureIP); |
| 4856 | |
| 4857 | // The secure cache should be checked prior to any DoH request being sent. |
| 4858 | ResolveHostResponseHelper response_secure_cached(resolver_->CreateRequest( |
| 4859 | HostPortPair("automatic_cached", 80), NetLogWithSource(), base::nullopt, |
| 4860 | request_context_.get(), host_cache_.get())); |
| 4861 | EXPECT_THAT(response_secure_cached.result_error(), IsOk()); |
| 4862 | EXPECT_THAT( |
| 4863 | response_secure_cached.request()->GetAddressResults().value().endpoints(), |
| 4864 | testing::ElementsAre(kExpectedSecureIP)); |
| 4865 | EXPECT_FALSE( |
| 4866 | response_secure_cached.request()->GetStaleInfo().value().is_stale()); |
| 4867 | } |
| 4868 | |
| 4869 | TEST_F(HostResolverManagerDnsTest, SecureDnsMode_Automatic_InsecureCache) { |
| 4870 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 4871 | DnsConfigOverrides overrides; |
| 4872 | overrides.secure_dns_mode = DnsConfig::SecureDnsMode::AUTOMATIC; |
| 4873 | resolver_->SetDnsConfigOverrides(overrides); |
| 4874 | |
| 4875 | // Populate cache with an insecure entry. |
| 4876 | HostCache::Key cached_insecure_key = |
| 4877 | HostCache::Key("insecure_automatic_cached", DnsQueryType::UNSPECIFIED, |
| 4878 | 0 /* host_resolver_flags */, HostResolverSource::ANY); |
| 4879 | IPEndPoint kExpectedInsecureIP = CreateExpected("192.168.1.103", 80); |
| 4880 | PopulateCache(cached_insecure_key, kExpectedInsecureIP); |
| 4881 | |
| 4882 | // The insecure cache should be checked after DoH requests fail. |
| 4883 | ResolveHostResponseHelper response_insecure_cached(resolver_->CreateRequest( |
| 4884 | HostPortPair("insecure_automatic_cached", 80), NetLogWithSource(), |
| 4885 | base::nullopt, request_context_.get(), host_cache_.get())); |
| 4886 | EXPECT_THAT(response_insecure_cached.result_error(), IsOk()); |
| 4887 | EXPECT_THAT(response_insecure_cached.request() |
| 4888 | ->GetAddressResults() |
| 4889 | .value() |
| 4890 | .endpoints(), |
| 4891 | testing::ElementsAre(kExpectedInsecureIP)); |
| 4892 | EXPECT_FALSE( |
| 4893 | response_insecure_cached.request()->GetStaleInfo().value().is_stale()); |
| 4894 | } |
| 4895 | |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 4896 | TEST_F(HostResolverManagerDnsTest, SecureDnsMode_Automatic_Downgrade) { |
| 4897 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 4898 | // Remove all DoH servers from the config so there is no DoH server available. |
| 4899 | DnsConfigOverrides overrides; |
| 4900 | std::vector<DnsConfig::DnsOverHttpsServerConfig> doh_servers; |
| 4901 | overrides.dns_over_https_servers = doh_servers; |
| 4902 | overrides.secure_dns_mode = DnsConfig::SecureDnsMode::AUTOMATIC; |
| 4903 | resolver_->SetDnsConfigOverrides(overrides); |
| 4904 | const std::pair<const HostCache::Key, HostCache::Entry>* cache_result; |
| 4905 | |
dalyk | e966a183 | 2019-06-05 20:53:13 | [diff] [blame] | 4906 | // Populate cache with both secure and insecure entries. |
| 4907 | HostCache::Key cached_secure_key = |
| 4908 | HostCache::Key("automatic_cached", DnsQueryType::UNSPECIFIED, |
| 4909 | 0 /* host_resolver_flags */, HostResolverSource::ANY); |
| 4910 | cached_secure_key.secure = true; |
| 4911 | IPEndPoint kExpectedSecureIP = CreateExpected("192.168.1.102", 80); |
| 4912 | PopulateCache(cached_secure_key, kExpectedSecureIP); |
| 4913 | HostCache::Key cached_insecure_key = |
| 4914 | HostCache::Key("insecure_automatic_cached", DnsQueryType::UNSPECIFIED, |
| 4915 | 0 /* host_resolver_flags */, HostResolverSource::ANY); |
| 4916 | IPEndPoint kExpectedInsecureIP = CreateExpected("192.168.1.103", 80); |
| 4917 | PopulateCache(cached_insecure_key, kExpectedInsecureIP); |
| 4918 | |
| 4919 | // The secure cache should still be checked first. |
| 4920 | ResolveHostResponseHelper response_cached(resolver_->CreateRequest( |
| 4921 | HostPortPair("automatic_cached", 80), NetLogWithSource(), base::nullopt, |
| 4922 | request_context_.get(), host_cache_.get())); |
| 4923 | EXPECT_THAT(response_cached.result_error(), IsOk()); |
| 4924 | EXPECT_THAT( |
| 4925 | response_cached.request()->GetAddressResults().value().endpoints(), |
| 4926 | testing::ElementsAre(kExpectedSecureIP)); |
| 4927 | |
| 4928 | // The insecure cache should be checked before any insecure requests are sent. |
| 4929 | ResolveHostResponseHelper insecure_response_cached(resolver_->CreateRequest( |
| 4930 | HostPortPair("insecure_automatic_cached", 80), NetLogWithSource(), |
| 4931 | base::nullopt, request_context_.get(), host_cache_.get())); |
| 4932 | EXPECT_THAT(insecure_response_cached.result_error(), IsOk()); |
| 4933 | EXPECT_THAT(insecure_response_cached.request() |
| 4934 | ->GetAddressResults() |
| 4935 | .value() |
| 4936 | .endpoints(), |
| 4937 | testing::ElementsAre(kExpectedInsecureIP)); |
| 4938 | |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 4939 | // The DnsConfig doesn't contain DoH servers so AUTOMATIC mode will be |
| 4940 | // downgraded to OFF. A successful plaintext DNS request should result in an |
| 4941 | // insecure cache entry. |
| 4942 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 4943 | HostPortPair("automatic", 80), NetLogWithSource(), base::nullopt, |
| 4944 | request_context_.get(), host_cache_.get())); |
| 4945 | ASSERT_THAT(response.result_error(), IsOk()); |
| 4946 | EXPECT_THAT(response.request()->GetAddressResults().value().endpoints(), |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 4947 | testing::UnorderedElementsAre(CreateExpected("127.0.0.1", 80), |
| 4948 | CreateExpected("::1", 80))); |
| 4949 | HostCache::Key key = |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 4950 | HostCache::Key("automatic", DnsQueryType::UNSPECIFIED, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 4951 | 0 /* host_resolver_flags */, HostResolverSource::ANY); |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 4952 | cache_result = GetCacheHit(key); |
| 4953 | EXPECT_TRUE(!!cache_result); |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 4954 | } |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 4955 | |
dalyk | e966a183 | 2019-06-05 20:53:13 | [diff] [blame] | 4956 | TEST_F(HostResolverManagerDnsTest, SecureDnsMode_Automatic_Stale) { |
| 4957 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 4958 | DnsConfigOverrides overrides; |
| 4959 | overrides.secure_dns_mode = DnsConfig::SecureDnsMode::AUTOMATIC; |
| 4960 | resolver_->SetDnsConfigOverrides(overrides); |
| 4961 | |
| 4962 | // Populate cache with insecure entry. |
| 4963 | HostCache::Key cached_stale_key = |
| 4964 | HostCache::Key("automatic_stale", DnsQueryType::UNSPECIFIED, |
| 4965 | 0 /* host_resolver_flags */, HostResolverSource::ANY); |
| 4966 | IPEndPoint kExpectedStaleIP = CreateExpected("192.168.1.102", 80); |
| 4967 | PopulateCache(cached_stale_key, kExpectedStaleIP); |
| 4968 | MakeCacheStale(); |
| 4969 | |
| 4970 | HostResolver::ResolveHostParameters stale_allowed_parameters; |
| 4971 | stale_allowed_parameters.cache_usage = |
| 4972 | HostResolver::ResolveHostParameters::CacheUsage::STALE_ALLOWED; |
| 4973 | |
| 4974 | // The insecure cache should be checked before secure requests are made since |
| 4975 | // stale results are allowed. |
| 4976 | ResolveHostResponseHelper response_stale(resolver_->CreateRequest( |
| 4977 | HostPortPair("automatic_stale", 80), NetLogWithSource(), |
| 4978 | stale_allowed_parameters, request_context_.get(), host_cache_.get())); |
| 4979 | EXPECT_THAT(response_stale.result_error(), IsOk()); |
| 4980 | EXPECT_THAT(response_stale.request()->GetAddressResults().value().endpoints(), |
| 4981 | testing::ElementsAre(kExpectedStaleIP)); |
| 4982 | EXPECT_TRUE(response_stale.request()->GetStaleInfo()->is_stale()); |
| 4983 | } |
| 4984 | |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 4985 | TEST_F(HostResolverManagerDnsTest, |
| 4986 | SecureDnsMode_Automatic_InsecureAsyncDisabled) { |
| 4987 | proc_->AddRuleForAllFamilies("insecure_automatic", "192.168.1.100"); |
| 4988 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 4989 | resolver_->SetInsecureDnsClientEnabled(false); |
| 4990 | DnsConfigOverrides overrides; |
| 4991 | overrides.secure_dns_mode = DnsConfig::SecureDnsMode::AUTOMATIC; |
| 4992 | resolver_->SetDnsConfigOverrides(overrides); |
| 4993 | |
| 4994 | const std::pair<const HostCache::Key, HostCache::Entry>* cache_result; |
| 4995 | |
| 4996 | // The secure part of the dns client should be enabled. |
| 4997 | ResolveHostResponseHelper response_secure(resolver_->CreateRequest( |
| 4998 | HostPortPair("automatic", 80), NetLogWithSource(), base::nullopt, |
| 4999 | request_context_.get(), host_cache_.get())); |
| 5000 | ASSERT_THAT(response_secure.result_error(), IsOk()); |
| 5001 | EXPECT_THAT( |
| 5002 | response_secure.request()->GetAddressResults().value().endpoints(), |
| 5003 | testing::UnorderedElementsAre(CreateExpected("127.0.0.1", 80), |
| 5004 | CreateExpected("::1", 80))); |
| 5005 | HostCache::Key secure_key = |
| 5006 | HostCache::Key("automatic", DnsQueryType::UNSPECIFIED, |
| 5007 | 0 /* host_resolver_flags */, HostResolverSource::ANY); |
| 5008 | secure_key.secure = true; |
| 5009 | cache_result = GetCacheHit(secure_key); |
| 5010 | EXPECT_TRUE(!!cache_result); |
| 5011 | |
| 5012 | // The insecure part of the dns client is disabled so insecure requests |
| 5013 | // should be skipped. |
| 5014 | ResolveHostResponseHelper response_insecure(resolver_->CreateRequest( |
| 5015 | HostPortPair("insecure_automatic", 80), NetLogWithSource(), base::nullopt, |
| 5016 | request_context_.get(), host_cache_.get())); |
| 5017 | proc_->SignalMultiple(1u); |
| 5018 | ASSERT_THAT(response_insecure.result_error(), IsOk()); |
| 5019 | EXPECT_THAT( |
| 5020 | response_insecure.request()->GetAddressResults().value().endpoints(), |
| 5021 | testing::ElementsAre(CreateExpected("192.168.1.100", 80))); |
| 5022 | HostCache::Key insecure_key = |
| 5023 | HostCache::Key("insecure_automatic", DnsQueryType::UNSPECIFIED, |
| 5024 | 0 /* host_resolver_flags */, HostResolverSource::ANY); |
| 5025 | cache_result = GetCacheHit(insecure_key); |
| 5026 | EXPECT_TRUE(!!cache_result); |
| 5027 | |
| 5028 | HostCache::Key cached_insecure_key = |
| 5029 | HostCache::Key("insecure_automatic_cached", DnsQueryType::UNSPECIFIED, |
| 5030 | 0 /* host_resolver_flags */, HostResolverSource::ANY); |
| 5031 | IPEndPoint kExpectedInsecureIP = CreateExpected("192.168.1.101", 80); |
| 5032 | PopulateCache(cached_insecure_key, kExpectedInsecureIP); |
| 5033 | |
| 5034 | // The insecure cache should still be checked even if the insecure part of |
| 5035 | // the dns client is disabled. |
| 5036 | ResolveHostResponseHelper response_insecure_cached(resolver_->CreateRequest( |
| 5037 | HostPortPair("insecure_automatic_cached", 80), NetLogWithSource(), |
| 5038 | base::nullopt, request_context_.get(), host_cache_.get())); |
| 5039 | EXPECT_THAT(response_insecure_cached.result_error(), IsOk()); |
| 5040 | EXPECT_THAT(response_insecure_cached.request() |
| 5041 | ->GetAddressResults() |
| 5042 | .value() |
| 5043 | .endpoints(), |
| 5044 | testing::ElementsAre(kExpectedInsecureIP)); |
| 5045 | } |
| 5046 | |
dalyk | 6d7d8ead | 2019-08-15 03:30:08 | [diff] [blame^] | 5047 | TEST_F(HostResolverManagerDnsTest, SecureDnsMode_Automatic_DotActive) { |
| 5048 | proc_->AddRuleForAllFamilies("insecure_automatic", "192.168.1.100"); |
| 5049 | DnsConfig config = CreateValidDnsConfig(); |
| 5050 | config.dns_over_tls_active = true; |
| 5051 | ChangeDnsConfig(config); |
| 5052 | DnsConfigOverrides overrides; |
| 5053 | overrides.secure_dns_mode = DnsConfig::SecureDnsMode::AUTOMATIC; |
| 5054 | resolver_->SetDnsConfigOverrides(overrides); |
| 5055 | |
| 5056 | const std::pair<const HostCache::Key, HostCache::Entry>* cache_result; |
| 5057 | |
| 5058 | // The secure part of the dns client should be enabled. |
| 5059 | ResolveHostResponseHelper response_secure(resolver_->CreateRequest( |
| 5060 | HostPortPair("automatic", 80), NetLogWithSource(), base::nullopt, |
| 5061 | request_context_.get(), host_cache_.get())); |
| 5062 | ASSERT_THAT(response_secure.result_error(), IsOk()); |
| 5063 | EXPECT_THAT( |
| 5064 | response_secure.request()->GetAddressResults().value().endpoints(), |
| 5065 | testing::UnorderedElementsAre(CreateExpected("127.0.0.1", 80), |
| 5066 | CreateExpected("::1", 80))); |
| 5067 | HostCache::Key secure_key = |
| 5068 | HostCache::Key("automatic", DnsQueryType::UNSPECIFIED, |
| 5069 | 0 /* host_resolver_flags */, HostResolverSource::ANY); |
| 5070 | secure_key.secure = true; |
| 5071 | cache_result = GetCacheHit(secure_key); |
| 5072 | EXPECT_TRUE(!!cache_result); |
| 5073 | |
| 5074 | // Insecure async requests should be skipped since the system resolver |
| 5075 | // requests will be secure. |
| 5076 | ResolveHostResponseHelper response_insecure(resolver_->CreateRequest( |
| 5077 | HostPortPair("insecure_automatic", 80), NetLogWithSource(), base::nullopt, |
| 5078 | request_context_.get(), host_cache_.get())); |
| 5079 | proc_->SignalMultiple(1u); |
| 5080 | ASSERT_THAT(response_insecure.result_error(), IsOk()); |
| 5081 | EXPECT_THAT( |
| 5082 | response_insecure.request()->GetAddressResults().value().endpoints(), |
| 5083 | testing::ElementsAre(CreateExpected("192.168.1.100", 80))); |
| 5084 | HostCache::Key insecure_key = |
| 5085 | HostCache::Key("insecure_automatic", DnsQueryType::UNSPECIFIED, |
| 5086 | 0 /* host_resolver_flags */, HostResolverSource::ANY); |
| 5087 | cache_result = GetCacheHit(insecure_key); |
| 5088 | EXPECT_TRUE(!!cache_result); |
| 5089 | |
| 5090 | HostCache::Key cached_insecure_key = |
| 5091 | HostCache::Key("insecure_automatic_cached", DnsQueryType::UNSPECIFIED, |
| 5092 | 0 /* host_resolver_flags */, HostResolverSource::ANY); |
| 5093 | IPEndPoint kExpectedInsecureIP = CreateExpected("192.168.1.101", 80); |
| 5094 | PopulateCache(cached_insecure_key, kExpectedInsecureIP); |
| 5095 | |
| 5096 | // The insecure cache should still be checked. |
| 5097 | ResolveHostResponseHelper response_insecure_cached(resolver_->CreateRequest( |
| 5098 | HostPortPair("insecure_automatic_cached", 80), NetLogWithSource(), |
| 5099 | base::nullopt, request_context_.get(), host_cache_.get())); |
| 5100 | EXPECT_THAT(response_insecure_cached.result_error(), IsOk()); |
| 5101 | EXPECT_THAT(response_insecure_cached.request() |
| 5102 | ->GetAddressResults() |
| 5103 | .value() |
| 5104 | .endpoints(), |
| 5105 | testing::ElementsAre(kExpectedInsecureIP)); |
| 5106 | } |
| 5107 | |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 5108 | TEST_F(HostResolverManagerDnsTest, SecureDnsMode_Secure) { |
| 5109 | proc_->AddRuleForAllFamilies("nx_succeed", "192.168.1.100"); |
| 5110 | set_allow_fallback_to_proctask(true); |
| 5111 | |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 5112 | ChangeDnsConfig(CreateValidDnsConfig()); |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 5113 | DnsConfigOverrides overrides; |
| 5114 | overrides.secure_dns_mode = DnsConfig::SecureDnsMode::SECURE; |
| 5115 | resolver_->SetDnsConfigOverrides(overrides); |
| 5116 | const std::pair<const HostCache::Key, HostCache::Entry>* cache_result; |
| 5117 | |
| 5118 | ResolveHostResponseHelper response_secure(resolver_->CreateRequest( |
| 5119 | HostPortPair("secure", 80), NetLogWithSource(), base::nullopt, |
| 5120 | request_context_.get(), host_cache_.get())); |
| 5121 | ASSERT_THAT(response_secure.result_error(), IsOk()); |
| 5122 | HostCache::Key secure_key = |
| 5123 | HostCache::Key("secure", DnsQueryType::UNSPECIFIED, |
| 5124 | 0 /* host_resolver_flags */, HostResolverSource::ANY); |
| 5125 | secure_key.secure = true; |
| 5126 | cache_result = GetCacheHit(secure_key); |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 5127 | EXPECT_TRUE(!!cache_result); |
| 5128 | |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 5129 | ResolveHostResponseHelper response_insecure(resolver_->CreateRequest( |
| 5130 | HostPortPair("ok", 80), NetLogWithSource(), base::nullopt, |
| 5131 | request_context_.get(), host_cache_.get())); |
| 5132 | ASSERT_THAT(response_insecure.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 5133 | HostCache::Key insecure_key = |
| 5134 | HostCache::Key("ok", DnsQueryType::UNSPECIFIED, |
| 5135 | 0 /* host_resolver_flags */, HostResolverSource::ANY); |
| 5136 | cache_result = GetCacheHit(insecure_key); |
| 5137 | EXPECT_FALSE(!!cache_result); |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 5138 | |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 5139 | // Fallback to ProcTask not allowed in SECURE mode. |
| 5140 | ResolveHostResponseHelper response_proc(resolver_->CreateRequest( |
| 5141 | HostPortPair("nx_succeed", 80), NetLogWithSource(), base::nullopt, |
| 5142 | request_context_.get(), host_cache_.get())); |
| 5143 | proc_->SignalMultiple(1u); |
| 5144 | EXPECT_THAT(response_proc.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 5145 | } |
| 5146 | |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 5147 | TEST_F(HostResolverManagerDnsTest, SecureDnsMode_Secure_InsecureAsyncDisabled) { |
| 5148 | proc_->AddRuleForAllFamilies("nx_succeed", "192.168.1.100"); |
| 5149 | set_allow_fallback_to_proctask(true); |
| 5150 | resolver_->SetInsecureDnsClientEnabled(false); |
| 5151 | |
| 5152 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 5153 | DnsConfigOverrides overrides; |
| 5154 | overrides.secure_dns_mode = DnsConfig::SecureDnsMode::SECURE; |
| 5155 | resolver_->SetDnsConfigOverrides(overrides); |
| 5156 | const std::pair<const HostCache::Key, HostCache::Entry>* cache_result; |
| 5157 | |
| 5158 | // The secure part of the dns client should be enabled. |
| 5159 | ResolveHostResponseHelper response_secure(resolver_->CreateRequest( |
| 5160 | HostPortPair("secure", 80), NetLogWithSource(), base::nullopt, |
| 5161 | request_context_.get(), host_cache_.get())); |
| 5162 | ASSERT_THAT(response_secure.result_error(), IsOk()); |
| 5163 | HostCache::Key secure_key = |
| 5164 | HostCache::Key("secure", DnsQueryType::UNSPECIFIED, |
| 5165 | 0 /* host_resolver_flags */, HostResolverSource::ANY); |
| 5166 | secure_key.secure = true; |
| 5167 | cache_result = GetCacheHit(secure_key); |
| 5168 | EXPECT_TRUE(!!cache_result); |
| 5169 | } |
| 5170 | |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 5171 | // Test the case where only a single transaction slot is available. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 5172 | TEST_F(HostResolverManagerDnsTest, SerialResolver) { |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 5173 | CreateSerialResolver(); |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 5174 | set_allow_fallback_to_proctask(false); |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 5175 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 5176 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5177 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 5178 | HostPortPair("ok", 80), NetLogWithSource(), base::nullopt, |
| 5179 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5180 | EXPECT_FALSE(response.complete()); |
| 5181 | EXPECT_EQ(1u, num_running_dispatcher_jobs()); |
| 5182 | |
| 5183 | base::RunLoop().RunUntilIdle(); |
| 5184 | EXPECT_TRUE(response.complete()); |
| 5185 | EXPECT_THAT(response.result_error(), IsOk()); |
| 5186 | EXPECT_THAT(response.request()->GetAddressResults().value().endpoints(), |
| 5187 | testing::UnorderedElementsAre(CreateExpected("127.0.0.1", 80), |
| 5188 | CreateExpected("::1", 80))); |
| 5189 | } |
| 5190 | |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 5191 | TEST_F(HostResolverManagerDnsTest, SerialResolver_AutomaticMode) { |
| 5192 | CreateSerialResolver(); |
| 5193 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 5194 | DnsConfigOverrides overrides; |
| 5195 | overrides.secure_dns_mode = DnsConfig::SecureDnsMode::AUTOMATIC; |
| 5196 | resolver_->SetDnsConfigOverrides(overrides); |
| 5197 | |
| 5198 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 5199 | HostPortPair("insecure_automatic", 80), NetLogWithSource(), base::nullopt, |
| 5200 | request_context_.get(), host_cache_.get())); |
| 5201 | EXPECT_FALSE(response.complete()); |
| 5202 | EXPECT_EQ(1u, num_running_dispatcher_jobs()); |
| 5203 | |
| 5204 | base::RunLoop().RunUntilIdle(); |
| 5205 | EXPECT_TRUE(response.complete()); |
| 5206 | EXPECT_THAT(response.result_error(), IsOk()); |
| 5207 | EXPECT_THAT(response.request()->GetAddressResults().value().endpoints(), |
| 5208 | testing::UnorderedElementsAre(CreateExpected("127.0.0.1", 80), |
| 5209 | CreateExpected("::1", 80))); |
| 5210 | HostCache::Key insecure_key = |
| 5211 | HostCache::Key("insecure_automatic", DnsQueryType::UNSPECIFIED, |
| 5212 | 0 /* host_resolver_flags */, HostResolverSource::ANY); |
| 5213 | const std::pair<const HostCache::Key, HostCache::Entry>* cache_result = |
| 5214 | GetCacheHit(insecure_key); |
| 5215 | EXPECT_TRUE(!!cache_result); |
| 5216 | } |
| 5217 | |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5218 | // Test the case where subsequent transactions are handled on transaction |
| 5219 | // completion when only part of a multi-transaction request could be initially |
| 5220 | // started. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 5221 | TEST_F(HostResolverManagerDnsTest, AAAAStartsAfterOtherJobFinishes) { |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5222 | CreateResolverWithLimitsAndParams(3u, DefaultParams(proc_.get()), |
Eric Orth | 607b6d8 | 2019-05-08 16:43:32 | [diff] [blame] | 5223 | true /* ipv6_reachable */, |
| 5224 | true /* check_ipv6_on_wifi */); |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 5225 | set_allow_fallback_to_proctask(false); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5226 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 5227 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5228 | ResolveHostResponseHelper response0(resolver_->CreateRequest( |
| 5229 | HostPortPair("ok", 80), NetLogWithSource(), base::nullopt, |
| 5230 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5231 | EXPECT_EQ(2u, num_running_dispatcher_jobs()); |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5232 | ResolveHostResponseHelper response1(resolver_->CreateRequest( |
| 5233 | HostPortPair("4slow_ok", 80), NetLogWithSource(), base::nullopt, |
| 5234 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5235 | EXPECT_EQ(3u, num_running_dispatcher_jobs()); |
| 5236 | |
| 5237 | // Request 0's transactions should complete, starting Request 1's second |
| 5238 | // transaction, which should also complete. |
| 5239 | base::RunLoop().RunUntilIdle(); |
| 5240 | EXPECT_EQ(1u, num_running_dispatcher_jobs()); |
| 5241 | EXPECT_TRUE(response0.complete()); |
| 5242 | EXPECT_FALSE(response1.complete()); |
| 5243 | |
| 5244 | dns_client_->CompleteDelayedTransactions(); |
| 5245 | EXPECT_THAT(response1.result_error(), IsOk()); |
| 5246 | EXPECT_THAT(response1.request()->GetAddressResults().value().endpoints(), |
| 5247 | testing::UnorderedElementsAre(CreateExpected("127.0.0.1", 80), |
| 5248 | CreateExpected("::1", 80))); |
| 5249 | } |
| 5250 | |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 5251 | // Tests the case that a Job with a single transaction receives an empty address |
| 5252 | // list, triggering fallback to ProcTask. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 5253 | TEST_F(HostResolverManagerDnsTest, IPv4EmptyFallback) { |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5254 | // Disable ipv6 to ensure we'll only try a single transaction for the host. |
| 5255 | CreateResolverWithLimitsAndParams(kMaxJobs, DefaultParams(proc_.get()), |
Eric Orth | 607b6d8 | 2019-05-08 16:43:32 | [diff] [blame] | 5256 | false /* ipv6_reachable */, |
| 5257 | true /* check_ipv6_on_wifi */); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5258 | DnsConfig config = CreateValidDnsConfig(); |
| 5259 | config.use_local_ipv6 = false; |
| 5260 | ChangeDnsConfig(config); |
| 5261 | |
Eric Orth | 322af3e4 | 2018-08-20 18:12:59 | [diff] [blame] | 5262 | proc_->AddRuleForAllFamilies("empty_fallback", "192.168.0.1", |
| 5263 | HOST_RESOLVER_DEFAULT_FAMILY_SET_DUE_TO_NO_IPV6); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5264 | proc_->SignalMultiple(1u); |
| 5265 | |
| 5266 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 5267 | HostPortPair("empty_fallback", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5268 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5269 | EXPECT_THAT(response.result_error(), IsOk()); |
| 5270 | EXPECT_THAT(response.request()->GetAddressResults().value().endpoints(), |
| 5271 | testing::ElementsAre(CreateExpected("192.168.0.1", 80))); |
| 5272 | } |
| 5273 | |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 5274 | // Tests the case that a Job with two transactions receives two empty address |
| 5275 | // lists, triggering fallback to ProcTask. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 5276 | TEST_F(HostResolverManagerDnsTest, UnspecEmptyFallback) { |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 5277 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 5278 | proc_->AddRuleForAllFamilies("empty_fallback", "192.168.0.1"); |
| 5279 | proc_->SignalMultiple(1u); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5280 | |
| 5281 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 5282 | HostPortPair("empty_fallback", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5283 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5284 | |
| 5285 | EXPECT_THAT(response.result_error(), IsOk()); |
| 5286 | EXPECT_THAT(response.request()->GetAddressResults().value().endpoints(), |
| 5287 | testing::ElementsAre(CreateExpected("192.168.0.1", 80))); |
| 5288 | } |
| 5289 | |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 5290 | // Tests getting a new invalid DnsConfig while there are active DnsTasks. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 5291 | TEST_F(HostResolverManagerDnsTest, InvalidDnsConfigWithPendingRequests) { |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5292 | // At most 3 jobs active at once. This number is important, since we want |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 5293 | // to make sure that aborting the first HostResolverManager::Job does not |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5294 | // trigger another DnsTransaction on the second Job when it releases its |
| 5295 | // second prioritized dispatcher slot. |
| 5296 | CreateResolverWithLimitsAndParams(3u, DefaultParams(proc_.get()), |
Eric Orth | 607b6d8 | 2019-05-08 16:43:32 | [diff] [blame] | 5297 | true /* ipv6_reachable */, |
| 5298 | true /* check_ipv6_on_wifi */); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5299 | |
| 5300 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 5301 | |
| 5302 | proc_->AddRuleForAllFamilies("slow_nx1", "192.168.0.1"); |
| 5303 | proc_->AddRuleForAllFamilies("slow_nx2", "192.168.0.2"); |
| 5304 | proc_->AddRuleForAllFamilies("ok", "192.168.0.3"); |
| 5305 | |
| 5306 | std::vector<std::unique_ptr<ResolveHostResponseHelper>> responses; |
| 5307 | // First active job gets two slots. |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5308 | responses.emplace_back( |
| 5309 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 5310 | HostPortPair("slow_nx1", 80), NetLogWithSource(), base::nullopt, |
| 5311 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5312 | // Next job gets one slot, and waits on another. |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5313 | responses.emplace_back( |
| 5314 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 5315 | HostPortPair("slow_nx2", 80), NetLogWithSource(), base::nullopt, |
| 5316 | request_context_.get(), host_cache_.get()))); |
| 5317 | responses.emplace_back( |
| 5318 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 5319 | HostPortPair("ok", 80), NetLogWithSource(), base::nullopt, |
| 5320 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5321 | |
| 5322 | EXPECT_EQ(3u, num_running_dispatcher_jobs()); |
| 5323 | for (auto& response : responses) { |
| 5324 | EXPECT_FALSE(response->complete()); |
| 5325 | } |
| 5326 | |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 5327 | // Clear DNS config. Fully in-progress, partially in-progress, and queued |
| 5328 | // requests should all be aborted. |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5329 | ChangeDnsConfig(DnsConfig()); |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 5330 | for (auto& response : responses) { |
| 5331 | EXPECT_THAT(response->result_error(), IsError(ERR_NETWORK_CHANGED)); |
| 5332 | } |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5333 | } |
| 5334 | |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5335 | // Test that initial DNS config read signals do not abort pending requests |
| 5336 | // when using DnsClient. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 5337 | TEST_F(HostResolverManagerDnsTest, DontAbortOnInitialDNSConfigRead) { |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5338 | // DnsClient is enabled, but there's no DnsConfig, so the request should start |
| 5339 | // using ProcTask. |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5340 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 5341 | HostPortPair("host1", 70), NetLogWithSource(), base::nullopt, |
| 5342 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5343 | EXPECT_FALSE(response.complete()); |
| 5344 | |
| 5345 | EXPECT_TRUE(proc_->WaitFor(1u)); |
| 5346 | // Send the initial config read signal, with a valid config. |
| 5347 | SetInitialDnsConfig(CreateValidDnsConfig()); |
| 5348 | proc_->SignalAll(); |
| 5349 | |
| 5350 | EXPECT_THAT(response.result_error(), IsOk()); |
| 5351 | } |
| 5352 | |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 5353 | // Tests the case that the insecure part of the DnsClient is automatically |
| 5354 | // disabled due to failures while there are active DnsTasks. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 5355 | TEST_F(HostResolverManagerDnsTest, |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 5356 | AutomaticallyDisableInsecureDnsClientWithPendingRequests) { |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 5357 | // Trying different limits is important for this test: Different limits |
| 5358 | // result in different behavior when aborting in-progress DnsTasks. Having |
| 5359 | // a DnsTask that has one job active and one in the queue when another job |
| 5360 | // occupying two slots has its DnsTask aborted is the case most likely to run |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 5361 | // into problems. Try limits between [1, 2 * # of non failure requests]. |
| 5362 | for (size_t limit = 1u; limit < 10u; ++limit) { |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5363 | CreateResolverWithLimitsAndParams(limit, DefaultParams(proc_.get()), |
Eric Orth | 607b6d8 | 2019-05-08 16:43:32 | [diff] [blame] | 5364 | true /* ipv6_reachable */, |
| 5365 | true /* check_ipv6_on_wifi */); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5366 | |
| 5367 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 5368 | |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 5369 | // Queue up enough failures to disable insecure DnsTasks. These will all |
| 5370 | // fall back to ProcTasks, and succeed there. |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5371 | std::vector<std::unique_ptr<ResolveHostResponseHelper>> failure_responses; |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 5372 | for (unsigned i = 0u; i < maximum_insecure_dns_task_failures(); ++i) { |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5373 | std::string host = base::StringPrintf("nx%u", i); |
| 5374 | proc_->AddRuleForAllFamilies(host, "192.168.0.1"); |
| 5375 | failure_responses.emplace_back( |
| 5376 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 5377 | HostPortPair(host, 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5378 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5379 | EXPECT_FALSE(failure_responses[i]->complete()); |
| 5380 | } |
| 5381 | |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 5382 | // These requests should all bypass insecure DnsTasks, due to the above |
| 5383 | // failures, so should end up using ProcTasks. |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5384 | proc_->AddRuleForAllFamilies("slow_ok1", "192.168.0.2"); |
| 5385 | ResolveHostResponseHelper response0(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 5386 | HostPortPair("slow_ok1", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5387 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5388 | EXPECT_FALSE(response0.complete()); |
| 5389 | proc_->AddRuleForAllFamilies("slow_ok2", "192.168.0.3"); |
| 5390 | ResolveHostResponseHelper response1(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 5391 | HostPortPair("slow_ok2", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5392 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5393 | EXPECT_FALSE(response1.complete()); |
| 5394 | proc_->AddRuleForAllFamilies("slow_ok3", "192.168.0.4"); |
| 5395 | ResolveHostResponseHelper response2(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 5396 | HostPortPair("slow_ok3", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5397 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5398 | EXPECT_FALSE(response2.complete()); |
| 5399 | |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 5400 | // Requests specifying DNS source cannot fallback to ProcTask, so they |
| 5401 | // should be unaffected. |
| 5402 | HostResolver::ResolveHostParameters parameters; |
| 5403 | parameters.source = HostResolverSource::DNS; |
| 5404 | ResolveHostResponseHelper response_dns(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 5405 | HostPortPair("4slow_ok", 80), NetLogWithSource(), parameters, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5406 | request_context_.get(), host_cache_.get())); |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 5407 | EXPECT_FALSE(response_dns.complete()); |
| 5408 | |
| 5409 | // Requests specifying SYSTEM source should be unaffected by disabling |
| 5410 | // DnsClient. |
| 5411 | proc_->AddRuleForAllFamilies("nx_ok", "192.168.0.5"); |
| 5412 | parameters.source = HostResolverSource::SYSTEM; |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5413 | ResolveHostResponseHelper response_system(resolver_->CreateRequest( |
| 5414 | HostPortPair("nx_ok", 80), NetLogWithSource(), parameters, |
| 5415 | request_context_.get(), host_cache_.get())); |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 5416 | EXPECT_FALSE(response_system.complete()); |
| 5417 | |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 5418 | // Secure DnsTasks should not be affected. |
| 5419 | HostResolver::ResolveHostParameters secure_parameters; |
| 5420 | secure_parameters.secure_dns_mode_override = |
| 5421 | DnsConfig::SecureDnsMode::AUTOMATIC; |
| 5422 | ResolveHostResponseHelper response_secure(resolver_->CreateRequest( |
| 5423 | HostPortPair("automatic", 80), NetLogWithSource(), secure_parameters, |
| 5424 | request_context_.get(), host_cache_.get())); |
| 5425 | EXPECT_FALSE(response_secure.complete()); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5426 | |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 5427 | proc_->SignalMultiple(maximum_insecure_dns_task_failures() + 6); |
| 5428 | |
| 5429 | for (size_t i = 0u; i < maximum_insecure_dns_task_failures(); ++i) { |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5430 | EXPECT_THAT(failure_responses[i]->result_error(), IsOk()); |
| 5431 | EXPECT_THAT(failure_responses[i] |
| 5432 | ->request() |
| 5433 | ->GetAddressResults() |
| 5434 | .value() |
| 5435 | .endpoints(), |
| 5436 | testing::ElementsAre(CreateExpected("192.168.0.1", 80))); |
| 5437 | } |
| 5438 | |
| 5439 | EXPECT_THAT(response0.result_error(), IsOk()); |
| 5440 | EXPECT_THAT(response0.request()->GetAddressResults().value().endpoints(), |
| 5441 | testing::ElementsAre(CreateExpected("192.168.0.2", 80))); |
| 5442 | EXPECT_THAT(response1.result_error(), IsOk()); |
| 5443 | EXPECT_THAT(response1.request()->GetAddressResults().value().endpoints(), |
| 5444 | testing::ElementsAre(CreateExpected("192.168.0.3", 80))); |
| 5445 | EXPECT_THAT(response2.result_error(), IsOk()); |
| 5446 | EXPECT_THAT(response2.request()->GetAddressResults().value().endpoints(), |
| 5447 | testing::ElementsAre(CreateExpected("192.168.0.4", 80))); |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 5448 | |
| 5449 | dns_client_->CompleteDelayedTransactions(); |
| 5450 | EXPECT_THAT(response_dns.result_error(), IsOk()); |
| 5451 | |
| 5452 | EXPECT_THAT(response_system.result_error(), IsOk()); |
| 5453 | EXPECT_THAT( |
| 5454 | response_system.request()->GetAddressResults().value().endpoints(), |
| 5455 | testing::ElementsAre(CreateExpected("192.168.0.5", 80))); |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 5456 | |
| 5457 | EXPECT_THAT(response_secure.result_error(), IsOk()); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5458 | } |
| 5459 | } |
| 5460 | |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 5461 | // Tests a call to SetDnsClient while there are active DnsTasks. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 5462 | TEST_F(HostResolverManagerDnsTest, |
| 5463 | ManuallyDisableDnsClientWithPendingRequests) { |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 5464 | // At most 3 jobs active at once. This number is important, since we want to |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 5465 | // make sure that aborting the first HostResolverManager::Job does not trigger |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 5466 | // another DnsTransaction on the second Job when it releases its second |
| 5467 | // prioritized dispatcher slot. |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5468 | CreateResolverWithLimitsAndParams(3u, DefaultParams(proc_.get()), |
Eric Orth | 607b6d8 | 2019-05-08 16:43:32 | [diff] [blame] | 5469 | true /* ipv6_reachable */, |
| 5470 | true /* check_ipv6_on_wifi */); |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 5471 | |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 5472 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 5473 | |
| 5474 | proc_->AddRuleForAllFamilies("slow_ok1", "192.168.0.1"); |
| 5475 | proc_->AddRuleForAllFamilies("slow_ok2", "192.168.0.2"); |
| 5476 | proc_->AddRuleForAllFamilies("ok", "192.168.0.3"); |
| 5477 | |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5478 | std::vector<std::unique_ptr<ResolveHostResponseHelper>> responses; |
| 5479 | // First active job gets two slots. |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5480 | responses.emplace_back( |
| 5481 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 5482 | HostPortPair("slow_ok1", 80), NetLogWithSource(), base::nullopt, |
| 5483 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5484 | EXPECT_FALSE(responses[0]->complete()); |
| 5485 | // Next job gets one slot, and waits on another. |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5486 | responses.emplace_back( |
| 5487 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 5488 | HostPortPair("slow_ok2", 80), NetLogWithSource(), base::nullopt, |
| 5489 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5490 | EXPECT_FALSE(responses[1]->complete()); |
| 5491 | // Next one is queued. |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5492 | responses.emplace_back( |
| 5493 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 5494 | HostPortPair("ok", 80), NetLogWithSource(), base::nullopt, |
| 5495 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5496 | EXPECT_FALSE(responses[2]->complete()); |
| 5497 | |
| 5498 | EXPECT_EQ(3u, num_running_dispatcher_jobs()); |
| 5499 | |
| 5500 | // Clear DnsClient. The two in-progress jobs should fall back to a ProcTask, |
| 5501 | // and the next one should be started with a ProcTask. |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 5502 | resolver_->SetInsecureDnsClientEnabled(false); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5503 | |
| 5504 | // All three in-progress requests should now be running a ProcTask. |
| 5505 | EXPECT_EQ(3u, num_running_dispatcher_jobs()); |
| 5506 | proc_->SignalMultiple(3u); |
| 5507 | |
| 5508 | for (auto& response : responses) { |
| 5509 | EXPECT_THAT(response->result_error(), IsOk()); |
| 5510 | } |
| 5511 | EXPECT_THAT(responses[0]->request()->GetAddressResults().value().endpoints(), |
| 5512 | testing::ElementsAre(CreateExpected("192.168.0.1", 80))); |
| 5513 | EXPECT_THAT(responses[1]->request()->GetAddressResults().value().endpoints(), |
| 5514 | testing::ElementsAre(CreateExpected("192.168.0.2", 80))); |
| 5515 | EXPECT_THAT(responses[2]->request()->GetAddressResults().value().endpoints(), |
| 5516 | testing::ElementsAre(CreateExpected("192.168.0.3", 80))); |
| 5517 | } |
| 5518 | |
Eric Orth | 04aad98 | 2019-05-06 22:41:04 | [diff] [blame] | 5519 | // When explicitly requesting source=DNS, no fallback allowed, so doing so with |
| 5520 | // DnsClient disabled should result in an error. |
| 5521 | TEST_F(HostResolverManagerDnsTest, DnsCallsWithDisabledDnsClient) { |
Eric Orth | 4e55b36 | 2019-05-07 22:00:03 | [diff] [blame] | 5522 | ChangeDnsConfig(CreateValidDnsConfig()); |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 5523 | resolver_->SetInsecureDnsClientEnabled(false); |
Eric Orth | 04aad98 | 2019-05-06 22:41:04 | [diff] [blame] | 5524 | |
| 5525 | HostResolver::ResolveHostParameters params; |
| 5526 | params.source = HostResolverSource::DNS; |
| 5527 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 5528 | HostPortPair("host", 80), NetLogWithSource(), params, |
| 5529 | request_context_.get(), host_cache_.get())); |
| 5530 | |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 5531 | EXPECT_THAT(response.result_error(), IsError(ERR_DNS_CACHE_MISS)); |
Eric Orth | 04aad98 | 2019-05-06 22:41:04 | [diff] [blame] | 5532 | } |
| 5533 | |
Eric Orth | 4e55b36 | 2019-05-07 22:00:03 | [diff] [blame] | 5534 | TEST_F(HostResolverManagerDnsTest, |
| 5535 | DnsCallsWithDisabledDnsClient_DisabledAtConstruction) { |
| 5536 | HostResolver::ManagerOptions options = DefaultOptions(); |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 5537 | options.insecure_dns_client_enabled = false; |
Eric Orth | 4e55b36 | 2019-05-07 22:00:03 | [diff] [blame] | 5538 | CreateResolverWithOptionsAndParams(std::move(options), |
| 5539 | DefaultParams(proc_.get()), |
| 5540 | true /* ipv6_reachable */); |
| 5541 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 5542 | |
| 5543 | HostResolver::ResolveHostParameters params; |
| 5544 | params.source = HostResolverSource::DNS; |
| 5545 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 5546 | HostPortPair("host", 80), NetLogWithSource(), params, |
| 5547 | request_context_.get(), host_cache_.get())); |
| 5548 | |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 5549 | EXPECT_THAT(response.result_error(), IsError(ERR_DNS_CACHE_MISS)); |
Eric Orth | 4e55b36 | 2019-05-07 22:00:03 | [diff] [blame] | 5550 | } |
| 5551 | |
| 5552 | // Same as DnsClient disabled, requests with source=DNS and no usable DnsConfig |
| 5553 | // should result in an error. |
| 5554 | TEST_F(HostResolverManagerDnsTest, DnsCallsWithNoDnsConfig) { |
| 5555 | ChangeDnsConfig(DnsConfig()); |
| 5556 | |
| 5557 | HostResolver::ResolveHostParameters params; |
| 5558 | params.source = HostResolverSource::DNS; |
| 5559 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 5560 | HostPortPair("host", 80), NetLogWithSource(), params, |
| 5561 | request_context_.get(), host_cache_.get())); |
| 5562 | |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 5563 | EXPECT_THAT(response.result_error(), IsError(ERR_DNS_CACHE_MISS)); |
Eric Orth | 4e55b36 | 2019-05-07 22:00:03 | [diff] [blame] | 5564 | } |
| 5565 | |
Eric Orth | 607b6d8 | 2019-05-08 16:43:32 | [diff] [blame] | 5566 | TEST_F(HostResolverManagerDnsTest, NoCheckIpv6OnWifi) { |
rch | ce64e673 | 2017-06-05 17:41:57 | [diff] [blame] | 5567 | // CreateSerialResolver will destroy the current resolver_ which will attempt |
| 5568 | // to remove itself from the NetworkChangeNotifier. If this happens after a |
| 5569 | // new NetworkChangeNotifier is active, then it will not remove itself from |
| 5570 | // the old NetworkChangeNotifier which is a potential use-after-free. |
Eric Orth | 37b1819 | 2019-04-22 19:09:28 | [diff] [blame] | 5571 | DestroyResolver(); |
mgersh | af9a923 | 2017-04-13 20:19:03 | [diff] [blame] | 5572 | test::ScopedMockNetworkChangeNotifier notifier; |
Eric Orth | 607b6d8 | 2019-05-08 16:43:32 | [diff] [blame] | 5573 | // Serial resolver to guarantee order of resolutions. |
| 5574 | CreateSerialResolver(false /* check_ipv6_on_wifi */); |
mgersh | af9a923 | 2017-04-13 20:19:03 | [diff] [blame] | 5575 | |
| 5576 | notifier.mock_network_change_notifier()->SetConnectionType( |
| 5577 | NetworkChangeNotifier::CONNECTION_WIFI); |
| 5578 | // Needed so IPv6 availability check isn't skipped. |
| 5579 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 5580 | |
| 5581 | proc_->AddRule("h1", ADDRESS_FAMILY_UNSPECIFIED, "::3"); |
| 5582 | proc_->AddRule("h1", ADDRESS_FAMILY_IPV4, "1.0.0.1"); |
Eric Orth | 322af3e4 | 2018-08-20 18:12:59 | [diff] [blame] | 5583 | proc_->AddRule("h1", ADDRESS_FAMILY_IPV4, "1.0.0.1", |
| 5584 | HOST_RESOLVER_DEFAULT_FAMILY_SET_DUE_TO_NO_IPV6); |
mgersh | af9a923 | 2017-04-13 20:19:03 | [diff] [blame] | 5585 | proc_->AddRule("h1", ADDRESS_FAMILY_IPV6, "::2"); |
| 5586 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5587 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 5588 | HostPortPair("h1", 80), NetLogWithSource(), base::nullopt, |
| 5589 | request_context_.get(), host_cache_.get())); |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 5590 | HostResolver::ResolveHostParameters parameters; |
Eric Orth | 192e3bb | 2018-11-14 19:30:32 | [diff] [blame] | 5591 | parameters.dns_query_type = DnsQueryType::A; |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5592 | ResolveHostResponseHelper v4_response(resolver_->CreateRequest( |
| 5593 | HostPortPair("h1", 80), NetLogWithSource(), parameters, |
| 5594 | request_context_.get(), host_cache_.get())); |
Eric Orth | 192e3bb | 2018-11-14 19:30:32 | [diff] [blame] | 5595 | parameters.dns_query_type = DnsQueryType::AAAA; |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5596 | ResolveHostResponseHelper v6_response(resolver_->CreateRequest( |
| 5597 | HostPortPair("h1", 80), NetLogWithSource(), parameters, |
| 5598 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5599 | |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 5600 | proc_->SignalMultiple(3u); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5601 | |
| 5602 | // Should revert to only IPV4 request. |
| 5603 | EXPECT_THAT(response.result_error(), IsOk()); |
| 5604 | EXPECT_THAT(response.request()->GetAddressResults().value().endpoints(), |
| 5605 | testing::ElementsAre(CreateExpected("1.0.0.1", 80))); |
| 5606 | |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 5607 | EXPECT_THAT(v4_response.result_error(), IsOk()); |
| 5608 | EXPECT_THAT(v4_response.request()->GetAddressResults().value().endpoints(), |
| 5609 | testing::ElementsAre(CreateExpected("1.0.0.1", 80))); |
| 5610 | EXPECT_THAT(v6_response.result_error(), IsOk()); |
| 5611 | EXPECT_THAT(v6_response.request()->GetAddressResults().value().endpoints(), |
| 5612 | testing::ElementsAre(CreateExpected("::2", 80))); |
| 5613 | |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5614 | // Now repeat the test on non-wifi to check that IPv6 is used as normal |
| 5615 | // after the network changes. |
| 5616 | notifier.mock_network_change_notifier()->SetConnectionType( |
| 5617 | NetworkChangeNotifier::CONNECTION_4G); |
| 5618 | base::RunLoop().RunUntilIdle(); // Wait for NetworkChangeNotifier. |
| 5619 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5620 | ResolveHostResponseHelper no_wifi_response(resolver_->CreateRequest( |
| 5621 | HostPortPair("h1", 80), NetLogWithSource(), base::nullopt, |
| 5622 | request_context_.get(), host_cache_.get())); |
Eric Orth | 192e3bb | 2018-11-14 19:30:32 | [diff] [blame] | 5623 | parameters.dns_query_type = DnsQueryType::A; |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5624 | ResolveHostResponseHelper no_wifi_v4_response(resolver_->CreateRequest( |
| 5625 | HostPortPair("h1", 80), NetLogWithSource(), parameters, |
| 5626 | request_context_.get(), host_cache_.get())); |
Eric Orth | 192e3bb | 2018-11-14 19:30:32 | [diff] [blame] | 5627 | parameters.dns_query_type = DnsQueryType::AAAA; |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5628 | ResolveHostResponseHelper no_wifi_v6_response(resolver_->CreateRequest( |
| 5629 | HostPortPair("h1", 80), NetLogWithSource(), parameters, |
| 5630 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5631 | |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 5632 | proc_->SignalMultiple(3u); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5633 | |
| 5634 | // IPV6 should be available. |
| 5635 | EXPECT_THAT(no_wifi_response.result_error(), IsOk()); |
| 5636 | EXPECT_THAT( |
| 5637 | no_wifi_response.request()->GetAddressResults().value().endpoints(), |
| 5638 | testing::ElementsAre(CreateExpected("::3", 80))); |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 5639 | |
| 5640 | EXPECT_THAT(no_wifi_v4_response.result_error(), IsOk()); |
| 5641 | EXPECT_THAT( |
| 5642 | no_wifi_v4_response.request()->GetAddressResults().value().endpoints(), |
| 5643 | testing::ElementsAre(CreateExpected("1.0.0.1", 80))); |
| 5644 | EXPECT_THAT(no_wifi_v6_response.result_error(), IsOk()); |
| 5645 | EXPECT_THAT( |
| 5646 | no_wifi_v6_response.request()->GetAddressResults().value().endpoints(), |
| 5647 | testing::ElementsAre(CreateExpected("::2", 80))); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5648 | } |
| 5649 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 5650 | TEST_F(HostResolverManagerDnsTest, NotFoundTTL) { |
Brad Lassey | 2e8f185d | 2018-05-21 22:25:21 | [diff] [blame] | 5651 | CreateResolver(); |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 5652 | set_allow_fallback_to_proctask(false); |
Brad Lassey | 2e8f185d | 2018-05-21 22:25:21 | [diff] [blame] | 5653 | ChangeDnsConfig(CreateValidDnsConfig()); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5654 | |
| 5655 | // NODATA |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5656 | ResolveHostResponseHelper no_data_response(resolver_->CreateRequest( |
| 5657 | HostPortPair("empty", 80), NetLogWithSource(), base::nullopt, |
| 5658 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5659 | EXPECT_THAT(no_data_response.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 5660 | EXPECT_FALSE(no_data_response.request()->GetAddressResults()); |
Eric Orth | 192e3bb | 2018-11-14 19:30:32 | [diff] [blame] | 5661 | HostCache::Key key("empty", DnsQueryType::UNSPECIFIED, 0, |
| 5662 | HostResolverSource::ANY); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5663 | HostCache::EntryStaleness staleness; |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 5664 | const std::pair<const HostCache::Key, HostCache::Entry>* cache_result = |
Eric Orth | 37b1819 | 2019-04-22 19:09:28 | [diff] [blame] | 5665 | host_cache_->Lookup(key, base::TimeTicks::Now(), |
| 5666 | false /* ignore_secure */); |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 5667 | EXPECT_TRUE(!!cache_result); |
| 5668 | EXPECT_TRUE(cache_result->second.has_ttl()); |
| 5669 | EXPECT_THAT(cache_result->second.ttl(), base::TimeDelta::FromSeconds(86400)); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5670 | |
| 5671 | // NXDOMAIN |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5672 | ResolveHostResponseHelper no_domain_response(resolver_->CreateRequest( |
| 5673 | HostPortPair("nodomain", 80), NetLogWithSource(), base::nullopt, |
| 5674 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5675 | EXPECT_THAT(no_domain_response.result_error(), |
| 5676 | IsError(ERR_NAME_NOT_RESOLVED)); |
| 5677 | EXPECT_FALSE(no_domain_response.request()->GetAddressResults()); |
Eric Orth | 192e3bb | 2018-11-14 19:30:32 | [diff] [blame] | 5678 | HostCache::Key nxkey("nodomain", DnsQueryType::UNSPECIFIED, 0, |
| 5679 | HostResolverSource::ANY); |
Eric Orth | 37b1819 | 2019-04-22 19:09:28 | [diff] [blame] | 5680 | cache_result = host_cache_->Lookup(nxkey, base::TimeTicks::Now(), |
| 5681 | false /* ignore_secure */); |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 5682 | EXPECT_TRUE(!!cache_result); |
| 5683 | EXPECT_TRUE(cache_result->second.has_ttl()); |
| 5684 | EXPECT_THAT(cache_result->second.ttl(), base::TimeDelta::FromSeconds(86400)); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5685 | } |
| 5686 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 5687 | TEST_F(HostResolverManagerDnsTest, CachedError) { |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 5688 | proc_->AddRuleForAllFamilies(std::string(), |
| 5689 | "0.0.0.0"); // Default to failures. |
| 5690 | proc_->SignalMultiple(1u); |
| 5691 | |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 5692 | CreateResolver(); |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 5693 | set_allow_fallback_to_proctask(true); |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 5694 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 5695 | |
| 5696 | HostResolver::ResolveHostParameters cache_only_parameters; |
| 5697 | cache_only_parameters.source = HostResolverSource::LOCAL_ONLY; |
| 5698 | |
| 5699 | // Expect cache initially empty. |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 5700 | ResolveHostResponseHelper cache_miss_response0(resolver_->CreateRequest( |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5701 | HostPortPair("nodomain", 80), NetLogWithSource(), cache_only_parameters, |
| 5702 | request_context_.get(), host_cache_.get())); |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 5703 | EXPECT_THAT(cache_miss_response0.result_error(), IsError(ERR_DNS_CACHE_MISS)); |
| 5704 | EXPECT_FALSE(cache_miss_response0.request()->GetStaleInfo()); |
| 5705 | |
| 5706 | // The cache should not be populate with an error because fallback to ProcTask |
| 5707 | // was available. |
| 5708 | ResolveHostResponseHelper no_domain_response_with_fallback( |
| 5709 | resolver_->CreateRequest(HostPortPair("nodomain", 80), NetLogWithSource(), |
| 5710 | base::nullopt, request_context_.get(), |
| 5711 | host_cache_.get())); |
| 5712 | EXPECT_THAT(no_domain_response_with_fallback.result_error(), |
| 5713 | IsError(ERR_NAME_NOT_RESOLVED)); |
| 5714 | |
| 5715 | // Expect cache still empty. |
| 5716 | ResolveHostResponseHelper cache_miss_response1(resolver_->CreateRequest( |
| 5717 | HostPortPair("nodomain", 80), NetLogWithSource(), cache_only_parameters, |
| 5718 | request_context_.get(), host_cache_.get())); |
| 5719 | EXPECT_THAT(cache_miss_response1.result_error(), IsError(ERR_DNS_CACHE_MISS)); |
| 5720 | EXPECT_FALSE(cache_miss_response1.request()->GetStaleInfo()); |
| 5721 | |
| 5722 | // Disable fallback to proctask |
| 5723 | set_allow_fallback_to_proctask(false); |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 5724 | |
| 5725 | // Populate cache with an error. |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5726 | ResolveHostResponseHelper no_domain_response(resolver_->CreateRequest( |
| 5727 | HostPortPair("nodomain", 80), NetLogWithSource(), base::nullopt, |
| 5728 | request_context_.get(), host_cache_.get())); |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 5729 | EXPECT_THAT(no_domain_response.result_error(), |
| 5730 | IsError(ERR_NAME_NOT_RESOLVED)); |
| 5731 | |
| 5732 | // Expect the error result can be resolved from the cache. |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5733 | ResolveHostResponseHelper cache_hit_response(resolver_->CreateRequest( |
| 5734 | HostPortPair("nodomain", 80), NetLogWithSource(), cache_only_parameters, |
| 5735 | request_context_.get(), host_cache_.get())); |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 5736 | EXPECT_THAT(cache_hit_response.result_error(), |
| 5737 | IsError(ERR_NAME_NOT_RESOLVED)); |
| 5738 | EXPECT_FALSE(cache_hit_response.request()->GetStaleInfo().value().is_stale()); |
| 5739 | } |
| 5740 | |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 5741 | TEST_F(HostResolverManagerDnsTest, CachedError_AutomaticMode) { |
| 5742 | CreateResolver(); |
| 5743 | set_allow_fallback_to_proctask(false); |
| 5744 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 5745 | |
| 5746 | // Switch to automatic mode. |
| 5747 | DnsConfigOverrides overrides; |
| 5748 | overrides.secure_dns_mode = DnsConfig::SecureDnsMode::AUTOMATIC; |
| 5749 | resolver_->SetDnsConfigOverrides(overrides); |
| 5750 | |
| 5751 | HostCache::Key insecure_key = |
| 5752 | HostCache::Key("automatic_nodomain", DnsQueryType::UNSPECIFIED, |
| 5753 | 0 /* host_resolver_flags */, HostResolverSource::ANY); |
| 5754 | HostCache::Key secure_key = |
| 5755 | HostCache::Key("automatic_nodomain", DnsQueryType::UNSPECIFIED, |
| 5756 | 0 /* host_resolver_flags */, HostResolverSource::ANY); |
| 5757 | secure_key.secure = true; |
| 5758 | |
| 5759 | // Expect cache initially empty. |
| 5760 | const std::pair<const HostCache::Key, HostCache::Entry>* cache_result; |
| 5761 | cache_result = GetCacheHit(secure_key); |
| 5762 | EXPECT_FALSE(!!cache_result); |
| 5763 | cache_result = GetCacheHit(insecure_key); |
| 5764 | EXPECT_FALSE(!!cache_result); |
| 5765 | |
| 5766 | // Populate both secure and insecure caches with an error. |
| 5767 | ResolveHostResponseHelper no_domain_response(resolver_->CreateRequest( |
| 5768 | HostPortPair("automatic_nodomain", 80), NetLogWithSource(), base::nullopt, |
| 5769 | request_context_.get(), host_cache_.get())); |
| 5770 | EXPECT_THAT(no_domain_response.result_error(), |
| 5771 | IsError(ERR_NAME_NOT_RESOLVED)); |
| 5772 | |
| 5773 | // Expect both secure and insecure caches to have the error result. |
| 5774 | cache_result = GetCacheHit(secure_key); |
| 5775 | EXPECT_TRUE(!!cache_result); |
| 5776 | cache_result = GetCacheHit(insecure_key); |
| 5777 | EXPECT_TRUE(!!cache_result); |
| 5778 | } |
| 5779 | |
| 5780 | TEST_F(HostResolverManagerDnsTest, CachedError_SecureMode) { |
| 5781 | CreateResolver(); |
| 5782 | set_allow_fallback_to_proctask(false); |
| 5783 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 5784 | |
| 5785 | // Switch to secure mode. |
| 5786 | DnsConfigOverrides overrides; |
| 5787 | overrides.secure_dns_mode = DnsConfig::SecureDnsMode::SECURE; |
| 5788 | resolver_->SetDnsConfigOverrides(overrides); |
| 5789 | |
| 5790 | HostCache::Key insecure_key = |
| 5791 | HostCache::Key("automatic_nodomain", DnsQueryType::UNSPECIFIED, |
| 5792 | 0 /* host_resolver_flags */, HostResolverSource::ANY); |
| 5793 | HostCache::Key secure_key = |
| 5794 | HostCache::Key("automatic_nodomain", DnsQueryType::UNSPECIFIED, |
| 5795 | 0 /* host_resolver_flags */, HostResolverSource::ANY); |
| 5796 | secure_key.secure = true; |
| 5797 | |
| 5798 | // Expect cache initially empty. |
| 5799 | const std::pair<const HostCache::Key, HostCache::Entry>* cache_result; |
| 5800 | cache_result = GetCacheHit(secure_key); |
| 5801 | EXPECT_FALSE(!!cache_result); |
| 5802 | cache_result = GetCacheHit(insecure_key); |
| 5803 | EXPECT_FALSE(!!cache_result); |
| 5804 | |
| 5805 | // Populate secure cache with an error. |
| 5806 | ResolveHostResponseHelper no_domain_response(resolver_->CreateRequest( |
| 5807 | HostPortPair("automatic_nodomain", 80), NetLogWithSource(), base::nullopt, |
| 5808 | request_context_.get(), host_cache_.get())); |
| 5809 | EXPECT_THAT(no_domain_response.result_error(), |
| 5810 | IsError(ERR_NAME_NOT_RESOLVED)); |
| 5811 | |
| 5812 | // Expect only the secure cache to have the error result. |
| 5813 | cache_result = GetCacheHit(secure_key); |
| 5814 | EXPECT_TRUE(!!cache_result); |
| 5815 | cache_result = GetCacheHit(insecure_key); |
| 5816 | EXPECT_FALSE(!!cache_result); |
| 5817 | } |
| 5818 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 5819 | TEST_F(HostResolverManagerDnsTest, NoCanonicalName) { |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 5820 | MockDnsClientRuleList rules; |
| 5821 | AddDnsRule(&rules, "alias", dns_protocol::kTypeA, IPAddress::IPv4Localhost(), |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 5822 | "canonical", false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 5823 | AddDnsRule(&rules, "alias", dns_protocol::kTypeAAAA, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 5824 | IPAddress::IPv6Localhost(), "canonical", false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 5825 | |
Asanka Herath | 2d0226c | 2018-10-24 14:35:55 | [diff] [blame] | 5826 | CreateResolver(); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 5827 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 5828 | set_allow_fallback_to_proctask(false); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 5829 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5830 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 5831 | HostPortPair("alias", 80), NetLogWithSource(), base::nullopt, |
| 5832 | request_context_.get(), host_cache_.get())); |
Asanka Herath | 2d0226c | 2018-10-24 14:35:55 | [diff] [blame] | 5833 | ASSERT_THAT(response.result_error(), IsOk()); |
| 5834 | |
Matt Menke | c35d163 | 2018-11-29 12:43:49 | [diff] [blame] | 5835 | // HostResolver may still give name, but if so, it must be correct. |
| 5836 | std::string result_name = |
| 5837 | response.request()->GetAddressResults().value().canonical_name(); |
| 5838 | EXPECT_TRUE(result_name.empty() || result_name == "canonical"); |
Asanka Herath | 2d0226c | 2018-10-24 14:35:55 | [diff] [blame] | 5839 | } |
| 5840 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 5841 | TEST_F(HostResolverManagerDnsTest, CanonicalName) { |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 5842 | MockDnsClientRuleList rules; |
| 5843 | AddDnsRule(&rules, "alias", dns_protocol::kTypeA, IPAddress::IPv4Localhost(), |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 5844 | "canonical", false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 5845 | AddDnsRule(&rules, "alias", dns_protocol::kTypeAAAA, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 5846 | IPAddress::IPv6Localhost(), "canonical", false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 5847 | |
Asanka Herath | 2d0226c | 2018-10-24 14:35:55 | [diff] [blame] | 5848 | CreateResolver(); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 5849 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 5850 | set_allow_fallback_to_proctask(false); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 5851 | |
Asanka Herath | 2d0226c | 2018-10-24 14:35:55 | [diff] [blame] | 5852 | HostResolver::ResolveHostParameters params; |
Asanka Herath | 2d0226c | 2018-10-24 14:35:55 | [diff] [blame] | 5853 | params.include_canonical_name = true; |
Eric Orth | 541a90c | 2019-01-17 20:11:46 | [diff] [blame] | 5854 | params.source = HostResolverSource::DNS; |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5855 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 5856 | HostPortPair("alias", 80), NetLogWithSource(), params, |
| 5857 | request_context_.get(), host_cache_.get())); |
Asanka Herath | 2d0226c | 2018-10-24 14:35:55 | [diff] [blame] | 5858 | ASSERT_THAT(response.result_error(), IsOk()); |
| 5859 | |
| 5860 | EXPECT_EQ(response.request()->GetAddressResults().value().canonical_name(), |
| 5861 | "canonical"); |
| 5862 | } |
| 5863 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 5864 | TEST_F(HostResolverManagerDnsTest, CanonicalName_PreferV6) { |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 5865 | MockDnsClientRuleList rules; |
| 5866 | AddDnsRule(&rules, "alias", dns_protocol::kTypeA, IPAddress::IPv4Localhost(), |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 5867 | "wrong", false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 5868 | AddDnsRule(&rules, "alias", dns_protocol::kTypeAAAA, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 5869 | IPAddress::IPv6Localhost(), "correct", true /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 5870 | |
Asanka Herath | 2d0226c | 2018-10-24 14:35:55 | [diff] [blame] | 5871 | CreateResolver(); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 5872 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 5873 | set_allow_fallback_to_proctask(false); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 5874 | |
Asanka Herath | 2d0226c | 2018-10-24 14:35:55 | [diff] [blame] | 5875 | HostResolver::ResolveHostParameters params; |
Asanka Herath | 2d0226c | 2018-10-24 14:35:55 | [diff] [blame] | 5876 | params.include_canonical_name = true; |
Eric Orth | 541a90c | 2019-01-17 20:11:46 | [diff] [blame] | 5877 | params.source = HostResolverSource::DNS; |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5878 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 5879 | HostPortPair("alias", 80), NetLogWithSource(), params, |
| 5880 | request_context_.get(), host_cache_.get())); |
Asanka Herath | 2d0226c | 2018-10-24 14:35:55 | [diff] [blame] | 5881 | ASSERT_FALSE(response.complete()); |
| 5882 | base::RunLoop().RunUntilIdle(); |
| 5883 | dns_client_->CompleteDelayedTransactions(); |
| 5884 | ASSERT_THAT(response.result_error(), IsOk()); |
| 5885 | EXPECT_EQ(response.request()->GetAddressResults().value().canonical_name(), |
| 5886 | "correct"); |
| 5887 | } |
| 5888 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 5889 | TEST_F(HostResolverManagerDnsTest, CanonicalName_V4Only) { |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 5890 | MockDnsClientRuleList rules; |
| 5891 | AddDnsRule(&rules, "alias", dns_protocol::kTypeA, IPAddress::IPv4Localhost(), |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 5892 | "correct", false /* delay */); |
Asanka Herath | 2d0226c | 2018-10-24 14:35:55 | [diff] [blame] | 5893 | CreateResolver(); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 5894 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 5895 | set_allow_fallback_to_proctask(false); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 5896 | |
Asanka Herath | 2d0226c | 2018-10-24 14:35:55 | [diff] [blame] | 5897 | HostResolver::ResolveHostParameters params; |
Eric Orth | 192e3bb | 2018-11-14 19:30:32 | [diff] [blame] | 5898 | params.dns_query_type = DnsQueryType::A; |
Asanka Herath | 2d0226c | 2018-10-24 14:35:55 | [diff] [blame] | 5899 | params.include_canonical_name = true; |
Eric Orth | 541a90c | 2019-01-17 20:11:46 | [diff] [blame] | 5900 | params.source = HostResolverSource::DNS; |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5901 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 5902 | HostPortPair("alias", 80), NetLogWithSource(), params, |
| 5903 | request_context_.get(), host_cache_.get())); |
Asanka Herath | 2d0226c | 2018-10-24 14:35:55 | [diff] [blame] | 5904 | ASSERT_THAT(response.result_error(), IsOk()); |
| 5905 | EXPECT_EQ(response.request()->GetAddressResults().value().canonical_name(), |
| 5906 | "correct"); |
| 5907 | } |
| 5908 | |
Eric Orth | 541a90c | 2019-01-17 20:11:46 | [diff] [blame] | 5909 | // Test that without specifying source, a request that would otherwise be |
| 5910 | // handled by DNS is sent to the system resolver if cannonname is requested. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 5911 | TEST_F(HostResolverManagerDnsTest, CanonicalNameForcesProc) { |
Eric Orth | 541a90c | 2019-01-17 20:11:46 | [diff] [blame] | 5912 | // Disable fallback to ensure system resolver is used directly, not via |
| 5913 | // fallback. |
| 5914 | set_allow_fallback_to_proctask(false); |
| 5915 | |
| 5916 | proc_->AddRuleForAllFamilies("nx_succeed", "192.168.1.102", |
| 5917 | HOST_RESOLVER_CANONNAME, "canonical"); |
| 5918 | proc_->SignalMultiple(1u); |
| 5919 | |
| 5920 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 5921 | |
| 5922 | HostResolver::ResolveHostParameters params; |
| 5923 | params.include_canonical_name = true; |
| 5924 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 5925 | HostPortPair("nx_succeed", 80), NetLogWithSource(), params, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5926 | request_context_.get(), host_cache_.get())); |
Eric Orth | 541a90c | 2019-01-17 20:11:46 | [diff] [blame] | 5927 | ASSERT_THAT(response.result_error(), IsOk()); |
| 5928 | |
| 5929 | EXPECT_EQ(response.request()->GetAddressResults().value().canonical_name(), |
| 5930 | "canonical"); |
| 5931 | } |
| 5932 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 5933 | TEST_F(HostResolverManagerTest, ResolveLocalHostname) { |
tfarina | 9ed7f8c5 | 2016-02-19 17:50:18 | [diff] [blame] | 5934 | AddressList addresses; |
| 5935 | |
| 5936 | TestBothLoopbackIPs("localhost"); |
| 5937 | TestBothLoopbackIPs("localhoST"); |
| 5938 | TestBothLoopbackIPs("localhost."); |
| 5939 | TestBothLoopbackIPs("localhoST."); |
| 5940 | TestBothLoopbackIPs("localhost.localdomain"); |
| 5941 | TestBothLoopbackIPs("localhost.localdomAIn"); |
| 5942 | TestBothLoopbackIPs("localhost.localdomain."); |
| 5943 | TestBothLoopbackIPs("localhost.localdomAIn."); |
| 5944 | TestBothLoopbackIPs("foo.localhost"); |
| 5945 | TestBothLoopbackIPs("foo.localhOSt"); |
| 5946 | TestBothLoopbackIPs("foo.localhost."); |
| 5947 | TestBothLoopbackIPs("foo.localhOSt."); |
| 5948 | |
| 5949 | TestIPv6LoopbackOnly("localhost6"); |
| 5950 | TestIPv6LoopbackOnly("localhoST6"); |
| 5951 | TestIPv6LoopbackOnly("localhost6."); |
| 5952 | TestIPv6LoopbackOnly("localhost6.localdomain6"); |
| 5953 | TestIPv6LoopbackOnly("localhost6.localdomain6."); |
| 5954 | |
Matt Menke | c35d163 | 2018-11-29 12:43:49 | [diff] [blame] | 5955 | EXPECT_FALSE(ResolveLocalHostname("127.0.0.1", &addresses)); |
| 5956 | EXPECT_FALSE(ResolveLocalHostname("::1", &addresses)); |
| 5957 | EXPECT_FALSE(ResolveLocalHostname("0:0:0:0:0:0:0:1", &addresses)); |
| 5958 | EXPECT_FALSE(ResolveLocalHostname("localhostx", &addresses)); |
| 5959 | EXPECT_FALSE(ResolveLocalHostname("localhost.x", &addresses)); |
| 5960 | EXPECT_FALSE(ResolveLocalHostname("foo.localdomain", &addresses)); |
| 5961 | EXPECT_FALSE(ResolveLocalHostname("foo.localdomain.x", &addresses)); |
| 5962 | EXPECT_FALSE(ResolveLocalHostname("localhost6x", &addresses)); |
| 5963 | EXPECT_FALSE(ResolveLocalHostname("localhost.localdomain6", &addresses)); |
| 5964 | EXPECT_FALSE(ResolveLocalHostname("localhost6.localdomain", &addresses)); |
| 5965 | EXPECT_FALSE(ResolveLocalHostname("127.0.0.1.1", &addresses)); |
| 5966 | EXPECT_FALSE(ResolveLocalHostname(".127.0.0.255", &addresses)); |
| 5967 | EXPECT_FALSE(ResolveLocalHostname("::2", &addresses)); |
| 5968 | EXPECT_FALSE(ResolveLocalHostname("::1:1", &addresses)); |
| 5969 | EXPECT_FALSE(ResolveLocalHostname("0:0:0:0:1:0:0:1", &addresses)); |
| 5970 | EXPECT_FALSE(ResolveLocalHostname("::1:1", &addresses)); |
| 5971 | EXPECT_FALSE(ResolveLocalHostname("0:0:0:0:0:0:0:0:1", &addresses)); |
| 5972 | EXPECT_FALSE(ResolveLocalHostname("foo.localhost.com", &addresses)); |
| 5973 | EXPECT_FALSE(ResolveLocalHostname("foo.localhoste", &addresses)); |
tfarina | 9ed7f8c5 | 2016-02-19 17:50:18 | [diff] [blame] | 5974 | } |
| 5975 | |
dalyk | 40dcab15 | 2019-03-15 21:03:15 | [diff] [blame] | 5976 | TEST_F(HostResolverManagerDnsTest, ResolveDnsOverHttpsServerName) { |
| 5977 | MockDnsClientRuleList rules; |
| 5978 | rules.emplace_back( |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 5979 | "dns.example2.com", dns_protocol::kTypeA, false /* secure */, |
dalyk | 40dcab15 | 2019-03-15 21:03:15 | [diff] [blame] | 5980 | MockDnsClientRule::Result(MockDnsClientRule::OK), false /* delay */); |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 5981 | rules.emplace_back( |
| 5982 | "dns.example2.com", dns_protocol::kTypeAAAA, false /* secure */, |
| 5983 | MockDnsClientRule::Result(MockDnsClientRule::OK), false /* delay */); |
dalyk | 40dcab15 | 2019-03-15 21:03:15 | [diff] [blame] | 5984 | CreateResolver(); |
| 5985 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 5986 | |
| 5987 | DnsConfigOverrides overrides; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 5988 | std::vector<DnsConfig::DnsOverHttpsServerConfig> doh_servers = { |
| 5989 | DnsConfig::DnsOverHttpsServerConfig("https://dns.example.com/", |
| 5990 | true /* use_post */), |
| 5991 | DnsConfig::DnsOverHttpsServerConfig( |
| 5992 | "https://dns.example2.com/dns-query{?dns}", false /* use_post */)}; |
| 5993 | overrides.dns_over_https_servers = doh_servers; |
| 5994 | overrides.secure_dns_mode = DnsConfig::SecureDnsMode::SECURE; |
dalyk | 40dcab15 | 2019-03-15 21:03:15 | [diff] [blame] | 5995 | resolver_->SetDnsConfigOverrides(overrides); |
| 5996 | |
| 5997 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 5998 | HostPortPair("dns.example2.com", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5999 | request_context_.get(), host_cache_.get())); |
dalyk | 40dcab15 | 2019-03-15 21:03:15 | [diff] [blame] | 6000 | ASSERT_THAT(response.result_error(), IsOk()); |
| 6001 | } |
| 6002 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6003 | TEST_F(HostResolverManagerDnsTest, AddDnsOverHttpsServerAfterConfig) { |
Eric Orth | 37b1819 | 2019-04-22 19:09:28 | [diff] [blame] | 6004 | DestroyResolver(); |
Brad Lassey | 786929ad | 2018-02-21 20:54:27 | [diff] [blame] | 6005 | test::ScopedMockNetworkChangeNotifier notifier; |
| 6006 | CreateSerialResolver(); // To guarantee order of resolutions. |
| 6007 | notifier.mock_network_change_notifier()->SetConnectionType( |
| 6008 | NetworkChangeNotifier::CONNECTION_WIFI); |
| 6009 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 6010 | |
dalyk | b34631f | 2018-08-24 19:59:48 | [diff] [blame] | 6011 | std::string server("https://dnsserver.example.net/dns-query{?dns}"); |
Eric Orth | c1eb129 | 2018-10-09 22:07:07 | [diff] [blame] | 6012 | DnsConfigOverrides overrides; |
| 6013 | overrides.dns_over_https_servers.emplace( |
| 6014 | {DnsConfig::DnsOverHttpsServerConfig(server, true)}); |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 6015 | overrides.secure_dns_mode = DnsConfig::SecureDnsMode::AUTOMATIC; |
Eric Orth | c1eb129 | 2018-10-09 22:07:07 | [diff] [blame] | 6016 | resolver_->SetDnsConfigOverrides(overrides); |
Brad Lassey | 786929ad | 2018-02-21 20:54:27 | [diff] [blame] | 6017 | base::DictionaryValue* config; |
| 6018 | |
| 6019 | auto value = resolver_->GetDnsConfigAsValue(); |
| 6020 | EXPECT_TRUE(value); |
| 6021 | if (!value) |
| 6022 | return; |
| 6023 | value->GetAsDictionary(&config); |
| 6024 | base::ListValue* doh_servers; |
| 6025 | config->GetListWithoutPathExpansion("doh_servers", &doh_servers); |
| 6026 | EXPECT_TRUE(doh_servers); |
| 6027 | if (!doh_servers) |
| 6028 | return; |
| 6029 | EXPECT_EQ(doh_servers->GetSize(), 1u); |
| 6030 | base::DictionaryValue* server_method; |
| 6031 | EXPECT_TRUE(doh_servers->GetDictionary(0, &server_method)); |
| 6032 | bool use_post; |
| 6033 | EXPECT_TRUE(server_method->GetBoolean("use_post", &use_post)); |
| 6034 | EXPECT_TRUE(use_post); |
dalyk | b34631f | 2018-08-24 19:59:48 | [diff] [blame] | 6035 | std::string server_template; |
| 6036 | EXPECT_TRUE(server_method->GetString("server_template", &server_template)); |
| 6037 | EXPECT_EQ(server_template, server); |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 6038 | EXPECT_EQ(config->FindKey("secure_dns_mode")->GetInt(), |
| 6039 | static_cast<int>(DnsConfig::SecureDnsMode::AUTOMATIC)); |
Brad Lassey | 786929ad | 2018-02-21 20:54:27 | [diff] [blame] | 6040 | } |
| 6041 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6042 | TEST_F(HostResolverManagerDnsTest, AddDnsOverHttpsServerBeforeConfig) { |
Eric Orth | 37b1819 | 2019-04-22 19:09:28 | [diff] [blame] | 6043 | DestroyResolver(); |
Brad Lassey | 786929ad | 2018-02-21 20:54:27 | [diff] [blame] | 6044 | test::ScopedMockNetworkChangeNotifier notifier; |
| 6045 | CreateSerialResolver(); // To guarantee order of resolutions. |
dalyk | b34631f | 2018-08-24 19:59:48 | [diff] [blame] | 6046 | std::string server("https://dnsserver.example.net/dns-query{?dns}"); |
Eric Orth | c1eb129 | 2018-10-09 22:07:07 | [diff] [blame] | 6047 | DnsConfigOverrides overrides; |
| 6048 | overrides.dns_over_https_servers.emplace( |
| 6049 | {DnsConfig::DnsOverHttpsServerConfig(server, true)}); |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 6050 | overrides.secure_dns_mode = DnsConfig::SecureDnsMode::AUTOMATIC; |
Eric Orth | c1eb129 | 2018-10-09 22:07:07 | [diff] [blame] | 6051 | resolver_->SetDnsConfigOverrides(overrides); |
Brad Lassey | 786929ad | 2018-02-21 20:54:27 | [diff] [blame] | 6052 | |
| 6053 | notifier.mock_network_change_notifier()->SetConnectionType( |
| 6054 | NetworkChangeNotifier::CONNECTION_WIFI); |
| 6055 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 6056 | |
| 6057 | base::DictionaryValue* config; |
| 6058 | auto value = resolver_->GetDnsConfigAsValue(); |
| 6059 | EXPECT_TRUE(value); |
| 6060 | if (!value) |
| 6061 | return; |
| 6062 | value->GetAsDictionary(&config); |
| 6063 | base::ListValue* doh_servers; |
| 6064 | config->GetListWithoutPathExpansion("doh_servers", &doh_servers); |
| 6065 | EXPECT_TRUE(doh_servers); |
| 6066 | if (!doh_servers) |
| 6067 | return; |
| 6068 | EXPECT_EQ(doh_servers->GetSize(), 1u); |
| 6069 | base::DictionaryValue* server_method; |
| 6070 | EXPECT_TRUE(doh_servers->GetDictionary(0, &server_method)); |
| 6071 | bool use_post; |
| 6072 | EXPECT_TRUE(server_method->GetBoolean("use_post", &use_post)); |
| 6073 | EXPECT_TRUE(use_post); |
dalyk | b34631f | 2018-08-24 19:59:48 | [diff] [blame] | 6074 | std::string server_template; |
| 6075 | EXPECT_TRUE(server_method->GetString("server_template", &server_template)); |
| 6076 | EXPECT_EQ(server_template, server); |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 6077 | EXPECT_EQ(config->FindKey("secure_dns_mode")->GetInt(), |
| 6078 | static_cast<int>(DnsConfig::SecureDnsMode::AUTOMATIC)); |
Brad Lassey | 786929ad | 2018-02-21 20:54:27 | [diff] [blame] | 6079 | } |
| 6080 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6081 | TEST_F(HostResolverManagerDnsTest, AddDnsOverHttpsServerBeforeClient) { |
Eric Orth | 37b1819 | 2019-04-22 19:09:28 | [diff] [blame] | 6082 | DestroyResolver(); |
Brad Lassey | 786929ad | 2018-02-21 20:54:27 | [diff] [blame] | 6083 | test::ScopedMockNetworkChangeNotifier notifier; |
| 6084 | CreateSerialResolver(); // To guarantee order of resolutions. |
dalyk | b34631f | 2018-08-24 19:59:48 | [diff] [blame] | 6085 | std::string server("https://dnsserver.example.net/dns-query{?dns}"); |
Eric Orth | c1eb129 | 2018-10-09 22:07:07 | [diff] [blame] | 6086 | DnsConfigOverrides overrides; |
| 6087 | overrides.dns_over_https_servers.emplace( |
| 6088 | {DnsConfig::DnsOverHttpsServerConfig(server, true)}); |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 6089 | overrides.secure_dns_mode = DnsConfig::SecureDnsMode::AUTOMATIC; |
Eric Orth | c1eb129 | 2018-10-09 22:07:07 | [diff] [blame] | 6090 | resolver_->SetDnsConfigOverrides(overrides); |
Brad Lassey | 786929ad | 2018-02-21 20:54:27 | [diff] [blame] | 6091 | |
| 6092 | notifier.mock_network_change_notifier()->SetConnectionType( |
| 6093 | NetworkChangeNotifier::CONNECTION_WIFI); |
| 6094 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 6095 | |
Brad Lassey | 786929ad | 2018-02-21 20:54:27 | [diff] [blame] | 6096 | base::DictionaryValue* config; |
| 6097 | auto value = resolver_->GetDnsConfigAsValue(); |
| 6098 | EXPECT_TRUE(value); |
| 6099 | if (!value) |
| 6100 | return; |
| 6101 | value->GetAsDictionary(&config); |
| 6102 | base::ListValue* doh_servers; |
| 6103 | config->GetListWithoutPathExpansion("doh_servers", &doh_servers); |
| 6104 | EXPECT_TRUE(doh_servers); |
| 6105 | if (!doh_servers) |
| 6106 | return; |
| 6107 | EXPECT_EQ(doh_servers->GetSize(), 1u); |
| 6108 | base::DictionaryValue* server_method; |
| 6109 | EXPECT_TRUE(doh_servers->GetDictionary(0, &server_method)); |
| 6110 | bool use_post; |
| 6111 | EXPECT_TRUE(server_method->GetBoolean("use_post", &use_post)); |
| 6112 | EXPECT_TRUE(use_post); |
dalyk | b34631f | 2018-08-24 19:59:48 | [diff] [blame] | 6113 | std::string server_template; |
| 6114 | EXPECT_TRUE(server_method->GetString("server_template", &server_template)); |
| 6115 | EXPECT_EQ(server_template, server); |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 6116 | EXPECT_EQ(config->FindKey("secure_dns_mode")->GetInt(), |
| 6117 | static_cast<int>(DnsConfig::SecureDnsMode::AUTOMATIC)); |
Brad Lassey | 786929ad | 2018-02-21 20:54:27 | [diff] [blame] | 6118 | } |
| 6119 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6120 | TEST_F(HostResolverManagerDnsTest, AddDnsOverHttpsServerAndThenRemove) { |
Eric Orth | 37b1819 | 2019-04-22 19:09:28 | [diff] [blame] | 6121 | DestroyResolver(); |
Brad Lassey | 786929ad | 2018-02-21 20:54:27 | [diff] [blame] | 6122 | test::ScopedMockNetworkChangeNotifier notifier; |
| 6123 | CreateSerialResolver(); // To guarantee order of resolutions. |
dalyk | b34631f | 2018-08-24 19:59:48 | [diff] [blame] | 6124 | std::string server("https://dns.example.com/"); |
Eric Orth | c1eb129 | 2018-10-09 22:07:07 | [diff] [blame] | 6125 | DnsConfigOverrides overrides; |
| 6126 | overrides.dns_over_https_servers.emplace( |
| 6127 | {DnsConfig::DnsOverHttpsServerConfig(server, true)}); |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 6128 | overrides.secure_dns_mode = DnsConfig::SecureDnsMode::AUTOMATIC; |
Eric Orth | c1eb129 | 2018-10-09 22:07:07 | [diff] [blame] | 6129 | resolver_->SetDnsConfigOverrides(overrides); |
Brad Lassey | 786929ad | 2018-02-21 20:54:27 | [diff] [blame] | 6130 | |
| 6131 | notifier.mock_network_change_notifier()->SetConnectionType( |
| 6132 | NetworkChangeNotifier::CONNECTION_WIFI); |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 6133 | DnsConfig network_dns_config = CreateValidDnsConfig(); |
| 6134 | network_dns_config.dns_over_https_servers.clear(); |
| 6135 | ChangeDnsConfig(network_dns_config); |
Brad Lassey | 786929ad | 2018-02-21 20:54:27 | [diff] [blame] | 6136 | |
| 6137 | base::DictionaryValue* config; |
| 6138 | auto value = resolver_->GetDnsConfigAsValue(); |
| 6139 | EXPECT_TRUE(value); |
| 6140 | if (!value) |
| 6141 | return; |
| 6142 | value->GetAsDictionary(&config); |
| 6143 | base::ListValue* doh_servers; |
| 6144 | config->GetListWithoutPathExpansion("doh_servers", &doh_servers); |
| 6145 | EXPECT_TRUE(doh_servers); |
| 6146 | if (!doh_servers) |
| 6147 | return; |
| 6148 | EXPECT_EQ(doh_servers->GetSize(), 1u); |
| 6149 | base::DictionaryValue* server_method; |
| 6150 | EXPECT_TRUE(doh_servers->GetDictionary(0, &server_method)); |
| 6151 | bool use_post; |
| 6152 | EXPECT_TRUE(server_method->GetBoolean("use_post", &use_post)); |
| 6153 | EXPECT_TRUE(use_post); |
dalyk | b34631f | 2018-08-24 19:59:48 | [diff] [blame] | 6154 | std::string server_template; |
| 6155 | EXPECT_TRUE(server_method->GetString("server_template", &server_template)); |
| 6156 | EXPECT_EQ(server_template, server); |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 6157 | EXPECT_EQ(config->FindKey("secure_dns_mode")->GetInt(), |
| 6158 | static_cast<int>(DnsConfig::SecureDnsMode::AUTOMATIC)); |
Brad Lassey | 786929ad | 2018-02-21 20:54:27 | [diff] [blame] | 6159 | |
Eric Orth | c1eb129 | 2018-10-09 22:07:07 | [diff] [blame] | 6160 | resolver_->SetDnsConfigOverrides(DnsConfigOverrides()); |
Brad Lassey | 786929ad | 2018-02-21 20:54:27 | [diff] [blame] | 6161 | value = resolver_->GetDnsConfigAsValue(); |
| 6162 | EXPECT_TRUE(value); |
| 6163 | if (!value) |
| 6164 | return; |
| 6165 | value->GetAsDictionary(&config); |
| 6166 | config->GetListWithoutPathExpansion("doh_servers", &doh_servers); |
| 6167 | EXPECT_TRUE(doh_servers); |
| 6168 | if (!doh_servers) |
| 6169 | return; |
| 6170 | EXPECT_EQ(doh_servers->GetSize(), 0u); |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 6171 | EXPECT_EQ(config->FindKey("secure_dns_mode")->GetInt(), |
| 6172 | static_cast<int>(DnsConfig::SecureDnsMode::OFF)); |
Brad Lassey | 786929ad | 2018-02-21 20:54:27 | [diff] [blame] | 6173 | } |
| 6174 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6175 | TEST_F(HostResolverManagerDnsTest, SetDnsConfigOverrides) { |
Eric Orth | c1eb129 | 2018-10-09 22:07:07 | [diff] [blame] | 6176 | DnsConfig original_config = CreateValidDnsConfig(); |
| 6177 | ChangeDnsConfig(original_config); |
| 6178 | |
| 6179 | // Confirm pre-override state. |
| 6180 | ASSERT_TRUE(original_config.Equals(*dns_client_->GetConfig())); |
| 6181 | |
| 6182 | DnsConfigOverrides overrides; |
| 6183 | const std::vector<IPEndPoint> nameservers = { |
| 6184 | CreateExpected("192.168.0.1", 92)}; |
| 6185 | overrides.nameservers = nameservers; |
| 6186 | const std::vector<std::string> search = {"str"}; |
| 6187 | overrides.search = search; |
| 6188 | const DnsHosts hosts = { |
| 6189 | {DnsHostsKey("host", ADDRESS_FAMILY_IPV4), IPAddress(192, 168, 1, 1)}}; |
| 6190 | overrides.hosts = hosts; |
| 6191 | overrides.append_to_multi_label_name = false; |
| 6192 | overrides.randomize_ports = true; |
| 6193 | const int ndots = 5; |
| 6194 | overrides.ndots = ndots; |
| 6195 | const base::TimeDelta timeout = base::TimeDelta::FromSeconds(10); |
| 6196 | overrides.timeout = timeout; |
| 6197 | const int attempts = 20; |
| 6198 | overrides.attempts = attempts; |
| 6199 | overrides.rotate = true; |
| 6200 | overrides.use_local_ipv6 = true; |
| 6201 | const std::vector<DnsConfig::DnsOverHttpsServerConfig> |
| 6202 | dns_over_https_servers = { |
| 6203 | DnsConfig::DnsOverHttpsServerConfig("dns.example.com", true)}; |
| 6204 | overrides.dns_over_https_servers = dns_over_https_servers; |
dalyk | bd726ee | 2019-05-30 01:44:06 | [diff] [blame] | 6205 | const DnsConfig::SecureDnsMode secure_dns_mode = |
| 6206 | DnsConfig::SecureDnsMode::SECURE; |
| 6207 | overrides.secure_dns_mode = secure_dns_mode; |
Eric Orth | c1eb129 | 2018-10-09 22:07:07 | [diff] [blame] | 6208 | |
Eric Orth | c823a23d | 2018-10-30 22:12:48 | [diff] [blame] | 6209 | // This test is expected to test overriding all fields. |
| 6210 | EXPECT_TRUE(overrides.OverridesEverything()); |
| 6211 | |
Eric Orth | c1eb129 | 2018-10-09 22:07:07 | [diff] [blame] | 6212 | resolver_->SetDnsConfigOverrides(overrides); |
| 6213 | |
| 6214 | const DnsConfig* overridden_config = dns_client_->GetConfig(); |
| 6215 | EXPECT_EQ(nameservers, overridden_config->nameservers); |
| 6216 | EXPECT_EQ(search, overridden_config->search); |
| 6217 | EXPECT_EQ(hosts, overridden_config->hosts); |
| 6218 | EXPECT_FALSE(overridden_config->append_to_multi_label_name); |
| 6219 | EXPECT_TRUE(overridden_config->randomize_ports); |
| 6220 | EXPECT_EQ(ndots, overridden_config->ndots); |
| 6221 | EXPECT_EQ(timeout, overridden_config->timeout); |
| 6222 | EXPECT_EQ(attempts, overridden_config->attempts); |
| 6223 | EXPECT_TRUE(overridden_config->rotate); |
| 6224 | EXPECT_TRUE(overridden_config->use_local_ipv6); |
| 6225 | EXPECT_EQ(dns_over_https_servers, overridden_config->dns_over_https_servers); |
dalyk | bd726ee | 2019-05-30 01:44:06 | [diff] [blame] | 6226 | EXPECT_EQ(secure_dns_mode, overridden_config->secure_dns_mode); |
Eric Orth | c1eb129 | 2018-10-09 22:07:07 | [diff] [blame] | 6227 | } |
| 6228 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6229 | TEST_F(HostResolverManagerDnsTest, |
Eric Orth | c823a23d | 2018-10-30 22:12:48 | [diff] [blame] | 6230 | SetDnsConfigOverrides_OverrideEverythingCreation) { |
| 6231 | DnsConfig original_config = CreateValidDnsConfig(); |
| 6232 | ChangeDnsConfig(original_config); |
| 6233 | |
| 6234 | // Confirm pre-override state. |
| 6235 | ASSERT_TRUE(original_config.Equals(*dns_client_->GetConfig())); |
| 6236 | ASSERT_FALSE(original_config.Equals(DnsConfig())); |
| 6237 | |
| 6238 | DnsConfigOverrides overrides = |
| 6239 | DnsConfigOverrides::CreateOverridingEverythingWithDefaults(); |
| 6240 | EXPECT_TRUE(overrides.OverridesEverything()); |
| 6241 | |
| 6242 | // Ensure config is valid by setting a nameserver. |
| 6243 | std::vector<IPEndPoint> nameservers = {CreateExpected("1.2.3.4", 50)}; |
| 6244 | overrides.nameservers = nameservers; |
| 6245 | EXPECT_TRUE(overrides.OverridesEverything()); |
| 6246 | |
| 6247 | resolver_->SetDnsConfigOverrides(overrides); |
| 6248 | |
| 6249 | DnsConfig expected; |
| 6250 | expected.nameservers = nameservers; |
| 6251 | EXPECT_TRUE(dns_client_->GetConfig()->Equals(DnsConfig(expected))); |
| 6252 | } |
| 6253 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6254 | TEST_F(HostResolverManagerDnsTest, SetDnsConfigOverrides_PartialOverride) { |
Eric Orth | c1eb129 | 2018-10-09 22:07:07 | [diff] [blame] | 6255 | DnsConfig original_config = CreateValidDnsConfig(); |
| 6256 | ChangeDnsConfig(original_config); |
| 6257 | |
| 6258 | // Confirm pre-override state. |
| 6259 | ASSERT_TRUE(original_config.Equals(*dns_client_->GetConfig())); |
| 6260 | |
| 6261 | DnsConfigOverrides overrides; |
| 6262 | const std::vector<IPEndPoint> nameservers = { |
| 6263 | CreateExpected("192.168.0.2", 192)}; |
| 6264 | overrides.nameservers = nameservers; |
| 6265 | overrides.rotate = true; |
Eric Orth | c823a23d | 2018-10-30 22:12:48 | [diff] [blame] | 6266 | EXPECT_FALSE(overrides.OverridesEverything()); |
Eric Orth | c1eb129 | 2018-10-09 22:07:07 | [diff] [blame] | 6267 | |
| 6268 | resolver_->SetDnsConfigOverrides(overrides); |
| 6269 | |
| 6270 | const DnsConfig* overridden_config = dns_client_->GetConfig(); |
| 6271 | EXPECT_EQ(nameservers, overridden_config->nameservers); |
| 6272 | EXPECT_EQ(original_config.search, overridden_config->search); |
| 6273 | EXPECT_EQ(original_config.hosts, overridden_config->hosts); |
| 6274 | EXPECT_TRUE(overridden_config->append_to_multi_label_name); |
| 6275 | EXPECT_FALSE(overridden_config->randomize_ports); |
| 6276 | EXPECT_EQ(original_config.ndots, overridden_config->ndots); |
| 6277 | EXPECT_EQ(original_config.timeout, overridden_config->timeout); |
| 6278 | EXPECT_EQ(original_config.attempts, overridden_config->attempts); |
| 6279 | EXPECT_TRUE(overridden_config->rotate); |
| 6280 | EXPECT_FALSE(overridden_config->use_local_ipv6); |
| 6281 | EXPECT_EQ(original_config.dns_over_https_servers, |
| 6282 | overridden_config->dns_over_https_servers); |
dalyk | bd726ee | 2019-05-30 01:44:06 | [diff] [blame] | 6283 | EXPECT_EQ(original_config.secure_dns_mode, |
| 6284 | overridden_config->secure_dns_mode); |
Eric Orth | c1eb129 | 2018-10-09 22:07:07 | [diff] [blame] | 6285 | } |
| 6286 | |
| 6287 | // Test that overridden configs are reapplied over a changed underlying system |
| 6288 | // config. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6289 | TEST_F(HostResolverManagerDnsTest, SetDnsConfigOverrides_NewConfig) { |
Eric Orth | c1eb129 | 2018-10-09 22:07:07 | [diff] [blame] | 6290 | DnsConfig original_config = CreateValidDnsConfig(); |
| 6291 | ChangeDnsConfig(original_config); |
| 6292 | |
| 6293 | // Confirm pre-override state. |
| 6294 | ASSERT_TRUE(original_config.Equals(*dns_client_->GetConfig())); |
| 6295 | |
| 6296 | DnsConfigOverrides overrides; |
| 6297 | const std::vector<IPEndPoint> nameservers = { |
| 6298 | CreateExpected("192.168.0.2", 192)}; |
| 6299 | overrides.nameservers = nameservers; |
| 6300 | |
| 6301 | resolver_->SetDnsConfigOverrides(overrides); |
| 6302 | ASSERT_EQ(nameservers, dns_client_->GetConfig()->nameservers); |
| 6303 | |
| 6304 | DnsConfig new_config = original_config; |
| 6305 | new_config.attempts = 103; |
| 6306 | ASSERT_NE(nameservers, new_config.nameservers); |
| 6307 | ChangeDnsConfig(new_config); |
| 6308 | |
| 6309 | const DnsConfig* overridden_config = dns_client_->GetConfig(); |
| 6310 | EXPECT_EQ(nameservers, overridden_config->nameservers); |
| 6311 | EXPECT_EQ(new_config.attempts, overridden_config->attempts); |
| 6312 | } |
| 6313 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6314 | TEST_F(HostResolverManagerDnsTest, SetDnsConfigOverrides_ClearOverrides) { |
Eric Orth | c1eb129 | 2018-10-09 22:07:07 | [diff] [blame] | 6315 | DnsConfig original_config = CreateValidDnsConfig(); |
| 6316 | ChangeDnsConfig(original_config); |
| 6317 | |
| 6318 | DnsConfigOverrides overrides; |
| 6319 | overrides.attempts = 245; |
| 6320 | resolver_->SetDnsConfigOverrides(overrides); |
| 6321 | |
| 6322 | ASSERT_FALSE(original_config.Equals(*dns_client_->GetConfig())); |
| 6323 | |
| 6324 | resolver_->SetDnsConfigOverrides(DnsConfigOverrides()); |
| 6325 | EXPECT_TRUE(original_config.Equals(*dns_client_->GetConfig())); |
| 6326 | } |
| 6327 | |
Eric Orth | 37b1819 | 2019-04-22 19:09:28 | [diff] [blame] | 6328 | TEST_F(HostResolverManagerDnsTest, FlushCacheOnDnsConfigOverridesChange) { |
| 6329 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 6330 | |
| 6331 | HostResolver::ResolveHostParameters local_source_parameters; |
| 6332 | local_source_parameters.source = HostResolverSource::LOCAL_ONLY; |
| 6333 | |
| 6334 | // Populate cache. |
| 6335 | ResolveHostResponseHelper initial_response(resolver_->CreateRequest( |
| 6336 | HostPortPair("ok", 70), NetLogWithSource(), base::nullopt, |
| 6337 | request_context_.get(), host_cache_.get())); |
| 6338 | EXPECT_THAT(initial_response.result_error(), IsOk()); |
| 6339 | |
| 6340 | // Confirm result now cached. |
| 6341 | ResolveHostResponseHelper cached_response(resolver_->CreateRequest( |
| 6342 | HostPortPair("ok", 75), NetLogWithSource(), local_source_parameters, |
| 6343 | request_context_.get(), host_cache_.get())); |
| 6344 | ASSERT_THAT(cached_response.result_error(), IsOk()); |
| 6345 | ASSERT_TRUE(cached_response.request()->GetStaleInfo()); |
| 6346 | |
| 6347 | // Flush cache by triggering a DnsConfigOverrides change. |
| 6348 | DnsConfigOverrides overrides; |
| 6349 | overrides.attempts = 4; |
| 6350 | resolver_->SetDnsConfigOverrides(overrides); |
| 6351 | |
| 6352 | // Expect no longer cached |
| 6353 | ResolveHostResponseHelper flushed_response(resolver_->CreateRequest( |
| 6354 | HostPortPair("ok", 80), NetLogWithSource(), local_source_parameters, |
| 6355 | request_context_.get(), host_cache_.get())); |
| 6356 | EXPECT_THAT(flushed_response.result_error(), IsError(ERR_DNS_CACHE_MISS)); |
| 6357 | } |
| 6358 | |
Eric Orth | c823a23d | 2018-10-30 22:12:48 | [diff] [blame] | 6359 | // Test that even when using config overrides, a change to the base system |
| 6360 | // config cancels pending requests. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6361 | TEST_F(HostResolverManagerDnsTest, CancellationOnBaseConfigChange) { |
Eric Orth | c823a23d | 2018-10-30 22:12:48 | [diff] [blame] | 6362 | DnsConfig original_config = CreateValidDnsConfig(); |
| 6363 | ChangeDnsConfig(original_config); |
| 6364 | |
| 6365 | DnsConfigOverrides overrides; |
| 6366 | overrides.nameservers.emplace({CreateExpected("123.123.123.123", 80)}); |
| 6367 | ASSERT_FALSE(overrides.OverridesEverything()); |
| 6368 | resolver_->SetDnsConfigOverrides(overrides); |
| 6369 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 6370 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 6371 | HostPortPair("4slow_ok", 80), NetLogWithSource(), base::nullopt, |
| 6372 | request_context_.get(), host_cache_.get())); |
Eric Orth | c823a23d | 2018-10-30 22:12:48 | [diff] [blame] | 6373 | ASSERT_FALSE(response.complete()); |
| 6374 | |
| 6375 | DnsConfig new_config = original_config; |
| 6376 | new_config.attempts = 103; |
| 6377 | ChangeDnsConfig(new_config); |
| 6378 | |
| 6379 | EXPECT_THAT(response.result_error(), IsError(ERR_NETWORK_CHANGED)); |
| 6380 | } |
| 6381 | |
| 6382 | // Test that when all configuration is overridden, system configuration changes |
| 6383 | // do not cancel requests. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6384 | TEST_F(HostResolverManagerDnsTest, |
Eric Orth | c823a23d | 2018-10-30 22:12:48 | [diff] [blame] | 6385 | CancellationOnBaseConfigChange_OverridesEverything) { |
| 6386 | DnsConfig original_config = CreateValidDnsConfig(); |
| 6387 | ChangeDnsConfig(original_config); |
| 6388 | |
| 6389 | DnsConfigOverrides overrides = |
| 6390 | DnsConfigOverrides::CreateOverridingEverythingWithDefaults(); |
| 6391 | overrides.nameservers.emplace({CreateExpected("123.123.123.123", 80)}); |
| 6392 | ASSERT_TRUE(overrides.OverridesEverything()); |
| 6393 | resolver_->SetDnsConfigOverrides(overrides); |
| 6394 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 6395 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 6396 | HostPortPair("4slow_ok", 80), NetLogWithSource(), base::nullopt, |
| 6397 | request_context_.get(), host_cache_.get())); |
Eric Orth | c823a23d | 2018-10-30 22:12:48 | [diff] [blame] | 6398 | ASSERT_FALSE(response.complete()); |
| 6399 | |
| 6400 | DnsConfig new_config = original_config; |
| 6401 | new_config.attempts = 103; |
| 6402 | ChangeDnsConfig(new_config); |
| 6403 | |
| 6404 | dns_client_->CompleteDelayedTransactions(); |
| 6405 | EXPECT_THAT(response.result_error(), IsOk()); |
| 6406 | } |
| 6407 | |
Eric Orth | c1eb129 | 2018-10-09 22:07:07 | [diff] [blame] | 6408 | // Test that in-progress queries are cancelled on applying new DNS config |
| 6409 | // overrides, same as receiving a new DnsConfig from the system. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6410 | TEST_F(HostResolverManagerDnsTest, CancelQueriesOnSettingOverrides) { |
Eric Orth | c1eb129 | 2018-10-09 22:07:07 | [diff] [blame] | 6411 | ChangeDnsConfig(CreateValidDnsConfig()); |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 6412 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 6413 | HostPortPair("4slow_ok", 80), NetLogWithSource(), base::nullopt, |
| 6414 | request_context_.get(), host_cache_.get())); |
Eric Orth | c1eb129 | 2018-10-09 22:07:07 | [diff] [blame] | 6415 | ASSERT_FALSE(response.complete()); |
| 6416 | |
| 6417 | DnsConfigOverrides overrides; |
| 6418 | overrides.attempts = 123; |
| 6419 | resolver_->SetDnsConfigOverrides(overrides); |
| 6420 | |
| 6421 | EXPECT_THAT(response.result_error(), IsError(ERR_NETWORK_CHANGED)); |
| 6422 | } |
| 6423 | |
| 6424 | // Queries should not be cancelled if equal overrides are set. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6425 | TEST_F(HostResolverManagerDnsTest, |
| 6426 | CancelQueriesOnSettingOverrides_SameOverrides) { |
Eric Orth | c1eb129 | 2018-10-09 22:07:07 | [diff] [blame] | 6427 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 6428 | DnsConfigOverrides overrides; |
| 6429 | overrides.attempts = 123; |
| 6430 | resolver_->SetDnsConfigOverrides(overrides); |
| 6431 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 6432 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 6433 | HostPortPair("4slow_ok", 80), NetLogWithSource(), base::nullopt, |
| 6434 | request_context_.get(), host_cache_.get())); |
Eric Orth | c1eb129 | 2018-10-09 22:07:07 | [diff] [blame] | 6435 | ASSERT_FALSE(response.complete()); |
| 6436 | |
| 6437 | resolver_->SetDnsConfigOverrides(overrides); |
| 6438 | |
Eric Orth | c823a23d | 2018-10-30 22:12:48 | [diff] [blame] | 6439 | dns_client_->CompleteDelayedTransactions(); |
Eric Orth | c1eb129 | 2018-10-09 22:07:07 | [diff] [blame] | 6440 | EXPECT_THAT(response.result_error(), IsOk()); |
| 6441 | } |
| 6442 | |
| 6443 | // Test that in-progress queries are cancelled on clearing DNS config overrides, |
| 6444 | // same as receiving a new DnsConfig from the system. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6445 | TEST_F(HostResolverManagerDnsTest, CancelQueriesOnClearingOverrides) { |
Eric Orth | c1eb129 | 2018-10-09 22:07:07 | [diff] [blame] | 6446 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 6447 | DnsConfigOverrides overrides; |
| 6448 | overrides.attempts = 123; |
| 6449 | resolver_->SetDnsConfigOverrides(overrides); |
| 6450 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 6451 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 6452 | HostPortPair("4slow_ok", 80), NetLogWithSource(), base::nullopt, |
| 6453 | request_context_.get(), host_cache_.get())); |
Eric Orth | c1eb129 | 2018-10-09 22:07:07 | [diff] [blame] | 6454 | ASSERT_FALSE(response.complete()); |
| 6455 | |
| 6456 | resolver_->SetDnsConfigOverrides(DnsConfigOverrides()); |
| 6457 | |
| 6458 | EXPECT_THAT(response.result_error(), IsError(ERR_NETWORK_CHANGED)); |
| 6459 | } |
| 6460 | |
| 6461 | // Queries should not be cancelled on clearing overrides if there were not any |
| 6462 | // overrides. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6463 | TEST_F(HostResolverManagerDnsTest, |
| 6464 | CancelQueriesOnClearingOverrides_NoOverrides) { |
Eric Orth | c1eb129 | 2018-10-09 22:07:07 | [diff] [blame] | 6465 | ChangeDnsConfig(CreateValidDnsConfig()); |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 6466 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 6467 | HostPortPair("4slow_ok", 80), NetLogWithSource(), base::nullopt, |
| 6468 | request_context_.get(), host_cache_.get())); |
Eric Orth | c1eb129 | 2018-10-09 22:07:07 | [diff] [blame] | 6469 | ASSERT_FALSE(response.complete()); |
| 6470 | |
| 6471 | resolver_->SetDnsConfigOverrides(DnsConfigOverrides()); |
| 6472 | |
Eric Orth | c823a23d | 2018-10-30 22:12:48 | [diff] [blame] | 6473 | dns_client_->CompleteDelayedTransactions(); |
Eric Orth | c1eb129 | 2018-10-09 22:07:07 | [diff] [blame] | 6474 | EXPECT_THAT(response.result_error(), IsOk()); |
| 6475 | } |
| 6476 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6477 | // Test HostResolverManager::UpdateModeForHistogram. |
| 6478 | TEST_F(HostResolverManagerDnsTest, ModeForHistogram) { |
Paul Jensen | 41dc3e9f | 2018-11-06 22:10:10 | [diff] [blame] | 6479 | // Test Async resolver is detected. |
| 6480 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 6481 | EXPECT_EQ(resolver_->mode_for_histogram_, |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6482 | HostResolverManager::MODE_FOR_HISTOGRAM_ASYNC_DNS); |
Paul Jensen | 41dc3e9f | 2018-11-06 22:10:10 | [diff] [blame] | 6483 | |
| 6484 | // Test upgradability is detected for async DNS. |
Eric Orth | 192e3bb | 2018-11-14 19:30:32 | [diff] [blame] | 6485 | static const std::vector<const char*> upgradable_servers( |
Paul Jensen | 41dc3e9f | 2018-11-06 22:10:10 | [diff] [blame] | 6486 | {// Google Public DNS |
| 6487 | "8.8.8.8", "8.8.4.4", "2001:4860:4860::8888", "2001:4860:4860::8844", |
| 6488 | // Cloudflare DNS |
| 6489 | "1.1.1.1", "1.0.0.1", "2606:4700:4700::1111", "2606:4700:4700::1001", |
| 6490 | // Quad9 DNS |
| 6491 | "9.9.9.9", "149.112.112.112", "2620:fe::fe", "2620:fe::9"}); |
| 6492 | for (const char* upgradable_server : upgradable_servers) { |
| 6493 | IPAddress ip_address; |
| 6494 | ASSERT_TRUE(ip_address.AssignFromIPLiteral(upgradable_server)); |
| 6495 | DnsConfig dns_config; |
| 6496 | dns_config.nameservers.push_back( |
| 6497 | IPEndPoint(ip_address, dns_protocol::kDefaultPort)); |
| 6498 | ChangeDnsConfig(dns_config); |
| 6499 | EXPECT_EQ( |
| 6500 | resolver_->mode_for_histogram_, |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6501 | HostResolverManager::MODE_FOR_HISTOGRAM_ASYNC_DNS_PRIVATE_SUPPORTS_DOH); |
Paul Jensen | 41dc3e9f | 2018-11-06 22:10:10 | [diff] [blame] | 6502 | } |
| 6503 | |
| 6504 | // Test system resolver is detected. |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 6505 | resolver_->SetInsecureDnsClientEnabled(false); |
Paul Jensen | 41dc3e9f | 2018-11-06 22:10:10 | [diff] [blame] | 6506 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 6507 | EXPECT_EQ(resolver_->mode_for_histogram_, |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6508 | HostResolverManager::MODE_FOR_HISTOGRAM_SYSTEM); |
Paul Jensen | 41dc3e9f | 2018-11-06 22:10:10 | [diff] [blame] | 6509 | |
| 6510 | // Test upgradability is detected for system resolver. |
| 6511 | for (const char* upgradable_server : upgradable_servers) { |
| 6512 | IPAddress ip_address; |
| 6513 | ASSERT_TRUE(ip_address.AssignFromIPLiteral(upgradable_server)); |
| 6514 | DnsConfig dns_config; |
| 6515 | dns_config.nameservers.push_back( |
| 6516 | IPEndPoint(ip_address, dns_protocol::kDefaultPort)); |
| 6517 | ChangeDnsConfig(dns_config); |
| 6518 | EXPECT_EQ(resolver_->mode_for_histogram_, |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6519 | HostResolverManager::MODE_FOR_HISTOGRAM_SYSTEM_SUPPORTS_DOH); |
Paul Jensen | 41dc3e9f | 2018-11-06 22:10:10 | [diff] [blame] | 6520 | } |
dalyk | 6d7d8ead | 2019-08-15 03:30:08 | [diff] [blame^] | 6521 | |
| 6522 | // Test private DNS is detected. |
| 6523 | DnsConfig config = CreateValidDnsConfig(); |
| 6524 | config.dns_over_tls_active = true; |
| 6525 | ChangeDnsConfig(config); |
| 6526 | EXPECT_EQ(resolver_->mode_for_histogram_, |
| 6527 | HostResolverManager::MODE_FOR_HISTOGRAM_SYSTEM_PRIVATE_DNS); |
| 6528 | |
| 6529 | // Test upgradeability from IP addresses when private DNS is active. |
| 6530 | for (const char* upgradable_server : upgradable_servers) { |
| 6531 | IPAddress ip_address; |
| 6532 | ASSERT_TRUE(ip_address.AssignFromIPLiteral(upgradable_server)); |
| 6533 | DnsConfig dns_config; |
| 6534 | dns_config.dns_over_tls_active = true; |
| 6535 | dns_config.nameservers.push_back( |
| 6536 | IPEndPoint(ip_address, dns_protocol::kDefaultPort)); |
| 6537 | ChangeDnsConfig(dns_config); |
| 6538 | EXPECT_EQ(resolver_->mode_for_histogram_, |
| 6539 | HostResolverManager:: |
| 6540 | MODE_FOR_HISTOGRAM_SYSTEM_PRIVATE_DNS_SUPPORTS_DOH); |
| 6541 | } |
| 6542 | |
| 6543 | // Test upgradeability from private DNS hostname. |
| 6544 | static const std::vector<const char*> upgradeable_private_servers( |
| 6545 | {// Google Public DNS |
| 6546 | "dns.google", |
| 6547 | // Cloudflare DNS |
| 6548 | "1dot1dot1dot1.cloudflare-dns.com", "cloudflare-dns.com", |
| 6549 | // Quad9 DNS |
| 6550 | "dns.quad9.net"}); |
| 6551 | for (const char* upgradeable_private_server : upgradeable_private_servers) { |
| 6552 | DnsConfig dns_config; |
| 6553 | dns_config.dns_over_tls_active = true; |
| 6554 | dns_config.dns_over_tls_hostname = upgradeable_private_server; |
| 6555 | dns_config.nameservers.push_back( |
| 6556 | IPEndPoint(IPAddress(1, 2, 3, 4), dns_protocol::kDefaultPort)); |
| 6557 | ChangeDnsConfig(dns_config); |
| 6558 | EXPECT_EQ(resolver_->mode_for_histogram_, |
| 6559 | HostResolverManager:: |
| 6560 | MODE_FOR_HISTOGRAM_SYSTEM_PRIVATE_DNS_SUPPORTS_DOH); |
| 6561 | } |
Paul Jensen | 41dc3e9f | 2018-11-06 22:10:10 | [diff] [blame] | 6562 | } |
| 6563 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6564 | TEST_F(HostResolverManagerDnsTest, TxtQuery) { |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 6565 | // Simulate two separate DNS records, each with multiple strings. |
| 6566 | std::vector<std::string> foo_records = {"foo1", "foo2", "foo3"}; |
| 6567 | std::vector<std::string> bar_records = {"bar1", "bar2"}; |
| 6568 | std::vector<std::vector<std::string>> text_records = {foo_records, |
| 6569 | bar_records}; |
| 6570 | |
| 6571 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 6572 | rules.emplace_back("host", dns_protocol::kTypeTXT, false /* secure */, |
dalyk | c0ab072 | 2019-03-14 17:00:58 | [diff] [blame] | 6573 | MockDnsClientRule::Result(BuildTestDnsTextResponse( |
| 6574 | "host", std::move(text_records))), |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 6575 | false /* delay */); |
| 6576 | |
| 6577 | CreateResolver(); |
| 6578 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 6579 | |
| 6580 | HostResolver::ResolveHostParameters parameters; |
| 6581 | parameters.dns_query_type = DnsQueryType::TXT; |
| 6582 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 6583 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 6584 | HostPortPair("host", 108), NetLogWithSource(), parameters, |
| 6585 | request_context_.get(), host_cache_.get())); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 6586 | EXPECT_THAT(response.result_error(), IsOk()); |
| 6587 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 6588 | EXPECT_FALSE(response.request()->GetHostnameResults()); |
| 6589 | |
| 6590 | // Order between separate DNS records is undefined, but each record should |
| 6591 | // stay in order as that order may be meaningful. |
| 6592 | ASSERT_THAT(response.request()->GetTextResults(), |
| 6593 | testing::Optional(testing::UnorderedElementsAre( |
| 6594 | "foo1", "foo2", "foo3", "bar1", "bar2"))); |
| 6595 | std::vector<std::string> results = |
| 6596 | response.request()->GetTextResults().value(); |
| 6597 | EXPECT_NE(results.end(), std::search(results.begin(), results.end(), |
| 6598 | foo_records.begin(), foo_records.end())); |
| 6599 | EXPECT_NE(results.end(), std::search(results.begin(), results.end(), |
| 6600 | bar_records.begin(), bar_records.end())); |
| 6601 | } |
| 6602 | |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 6603 | TEST_F(HostResolverManagerDnsTest, TxtQuery_InvalidConfig) { |
| 6604 | set_allow_fallback_to_proctask(false); |
| 6605 | // Set empty DnsConfig. |
| 6606 | ChangeDnsConfig(DnsConfig()); |
| 6607 | |
| 6608 | HostResolver::ResolveHostParameters parameters; |
| 6609 | parameters.dns_query_type = DnsQueryType::TXT; |
| 6610 | |
| 6611 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 6612 | HostPortPair("host", 108), NetLogWithSource(), parameters, |
| 6613 | request_context_.get(), host_cache_.get())); |
| 6614 | EXPECT_THAT(response.result_error(), IsError(ERR_DNS_CACHE_MISS)); |
| 6615 | } |
| 6616 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6617 | TEST_F(HostResolverManagerDnsTest, TxtQuery_NonexistentDomain) { |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 6618 | // Setup fallback to confirm it is not used for non-address results. |
| 6619 | set_allow_fallback_to_proctask(true); |
| 6620 | proc_->AddRuleForAllFamilies("host", "192.168.1.102"); |
| 6621 | proc_->SignalMultiple(1u); |
| 6622 | |
| 6623 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 6624 | rules.emplace_back("host", dns_protocol::kTypeTXT, false /* secure */, |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 6625 | MockDnsClientRule::Result(MockDnsClientRule::NODOMAIN), |
| 6626 | false /* delay */); |
| 6627 | |
| 6628 | CreateResolver(); |
| 6629 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 6630 | |
| 6631 | HostResolver::ResolveHostParameters parameters; |
| 6632 | parameters.dns_query_type = DnsQueryType::TXT; |
| 6633 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 6634 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 6635 | HostPortPair("host", 108), NetLogWithSource(), parameters, |
| 6636 | request_context_.get(), host_cache_.get())); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 6637 | EXPECT_THAT(response.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 6638 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 6639 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 6640 | EXPECT_FALSE(response.request()->GetHostnameResults()); |
| 6641 | } |
| 6642 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6643 | TEST_F(HostResolverManagerDnsTest, TxtQuery_Failure) { |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 6644 | // Setup fallback to confirm it is not used for non-address results. |
| 6645 | set_allow_fallback_to_proctask(true); |
| 6646 | proc_->AddRuleForAllFamilies("host", "192.168.1.102"); |
| 6647 | proc_->SignalMultiple(1u); |
| 6648 | |
| 6649 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 6650 | rules.emplace_back("host", dns_protocol::kTypeTXT, false /* secure */, |
| 6651 | MockDnsClientRule::Result(MockDnsClientRule::FAIL), |
| 6652 | false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 6653 | |
| 6654 | CreateResolver(); |
| 6655 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 6656 | |
| 6657 | HostResolver::ResolveHostParameters parameters; |
| 6658 | parameters.dns_query_type = DnsQueryType::TXT; |
| 6659 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 6660 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 6661 | HostPortPair("host", 108), NetLogWithSource(), parameters, |
| 6662 | request_context_.get(), host_cache_.get())); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 6663 | EXPECT_THAT(response.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 6664 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 6665 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 6666 | EXPECT_FALSE(response.request()->GetHostnameResults()); |
| 6667 | } |
| 6668 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6669 | TEST_F(HostResolverManagerDnsTest, TxtQuery_Timeout) { |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 6670 | // Setup fallback to confirm it is not used for non-address results. |
| 6671 | set_allow_fallback_to_proctask(true); |
| 6672 | proc_->AddRuleForAllFamilies("host", "192.168.1.102"); |
| 6673 | proc_->SignalMultiple(1u); |
| 6674 | |
| 6675 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 6676 | rules.emplace_back("host", dns_protocol::kTypeTXT, false /* secure */, |
| 6677 | MockDnsClientRule::Result(MockDnsClientRule::TIMEOUT), |
| 6678 | false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 6679 | |
| 6680 | CreateResolver(); |
| 6681 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 6682 | |
| 6683 | HostResolver::ResolveHostParameters parameters; |
| 6684 | parameters.dns_query_type = DnsQueryType::TXT; |
| 6685 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 6686 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 6687 | HostPortPair("host", 108), NetLogWithSource(), parameters, |
| 6688 | request_context_.get(), host_cache_.get())); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 6689 | EXPECT_THAT(response.result_error(), IsError(ERR_DNS_TIMED_OUT)); |
| 6690 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 6691 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 6692 | EXPECT_FALSE(response.request()->GetHostnameResults()); |
| 6693 | } |
| 6694 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6695 | TEST_F(HostResolverManagerDnsTest, TxtQuery_Empty) { |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 6696 | // Setup fallback to confirm it is not used for non-address results. |
| 6697 | set_allow_fallback_to_proctask(true); |
| 6698 | proc_->AddRuleForAllFamilies("host", "192.168.1.102"); |
| 6699 | proc_->SignalMultiple(1u); |
| 6700 | |
| 6701 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 6702 | rules.emplace_back("host", dns_protocol::kTypeTXT, false /* secure */, |
| 6703 | MockDnsClientRule::Result(MockDnsClientRule::EMPTY), |
| 6704 | false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 6705 | |
| 6706 | CreateResolver(); |
| 6707 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 6708 | |
| 6709 | HostResolver::ResolveHostParameters parameters; |
| 6710 | parameters.dns_query_type = DnsQueryType::TXT; |
| 6711 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 6712 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 6713 | HostPortPair("host", 108), NetLogWithSource(), parameters, |
| 6714 | request_context_.get(), host_cache_.get())); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 6715 | EXPECT_THAT(response.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 6716 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 6717 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 6718 | EXPECT_FALSE(response.request()->GetHostnameResults()); |
| 6719 | } |
| 6720 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6721 | TEST_F(HostResolverManagerDnsTest, TxtQuery_Malformed) { |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 6722 | // Setup fallback to confirm it is not used for non-address results. |
| 6723 | set_allow_fallback_to_proctask(true); |
| 6724 | proc_->AddRuleForAllFamilies("host", "192.168.1.102"); |
| 6725 | proc_->SignalMultiple(1u); |
| 6726 | |
| 6727 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 6728 | rules.emplace_back("host", dns_protocol::kTypeTXT, false /* secure */, |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 6729 | MockDnsClientRule::Result(MockDnsClientRule::MALFORMED), |
| 6730 | false /* delay */); |
| 6731 | |
| 6732 | CreateResolver(); |
| 6733 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 6734 | |
| 6735 | HostResolver::ResolveHostParameters parameters; |
| 6736 | parameters.dns_query_type = DnsQueryType::TXT; |
| 6737 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 6738 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 6739 | HostPortPair("host", 108), NetLogWithSource(), parameters, |
| 6740 | request_context_.get(), host_cache_.get())); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 6741 | EXPECT_THAT(response.result_error(), IsError(ERR_DNS_MALFORMED_RESPONSE)); |
| 6742 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 6743 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 6744 | EXPECT_FALSE(response.request()->GetHostnameResults()); |
| 6745 | } |
| 6746 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6747 | TEST_F(HostResolverManagerDnsTest, TxtQuery_MismatchedName) { |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 6748 | std::vector<std::vector<std::string>> text_records = {{"text"}}; |
| 6749 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 6750 | rules.emplace_back("host", dns_protocol::kTypeTXT, false /* secure */, |
dalyk | c0ab072 | 2019-03-14 17:00:58 | [diff] [blame] | 6751 | MockDnsClientRule::Result(BuildTestDnsTextResponse( |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 6752 | "host", std::move(text_records), "not.host")), |
| 6753 | false /* delay */); |
| 6754 | |
| 6755 | CreateResolver(); |
| 6756 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 6757 | |
| 6758 | HostResolver::ResolveHostParameters parameters; |
| 6759 | parameters.dns_query_type = DnsQueryType::TXT; |
| 6760 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 6761 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 6762 | HostPortPair("host", 108), NetLogWithSource(), parameters, |
| 6763 | request_context_.get(), host_cache_.get())); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 6764 | EXPECT_THAT(response.result_error(), IsError(ERR_DNS_MALFORMED_RESPONSE)); |
| 6765 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 6766 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 6767 | EXPECT_FALSE(response.request()->GetHostnameResults()); |
| 6768 | } |
| 6769 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6770 | TEST_F(HostResolverManagerDnsTest, TxtQuery_WrongType) { |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 6771 | // Respond to a TXT query with an A response. |
| 6772 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 6773 | rules.emplace_back("host", dns_protocol::kTypeTXT, false /* secure */, |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 6774 | MockDnsClientRule::Result( |
| 6775 | BuildTestDnsResponse("host", IPAddress(1, 2, 3, 4))), |
| 6776 | false /* delay */); |
| 6777 | |
| 6778 | CreateResolver(); |
| 6779 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 6780 | |
| 6781 | HostResolver::ResolveHostParameters parameters; |
| 6782 | parameters.dns_query_type = DnsQueryType::TXT; |
| 6783 | |
| 6784 | // Responses for the wrong type should be ignored. |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 6785 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 6786 | HostPortPair("ok", 108), NetLogWithSource(), parameters, |
| 6787 | request_context_.get(), host_cache_.get())); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 6788 | EXPECT_THAT(response.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 6789 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 6790 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 6791 | EXPECT_FALSE(response.request()->GetHostnameResults()); |
| 6792 | } |
| 6793 | |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 6794 | // Same as TxtQuery except we specify DNS HostResolverSource instead of relying |
| 6795 | // on automatic determination. Expect same results since DNS should be what we |
| 6796 | // automatically determine, but some slightly different logic paths are |
| 6797 | // involved. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6798 | TEST_F(HostResolverManagerDnsTest, TxtDnsQuery) { |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 6799 | // Simulate two separate DNS records, each with multiple strings. |
| 6800 | std::vector<std::string> foo_records = {"foo1", "foo2", "foo3"}; |
| 6801 | std::vector<std::string> bar_records = {"bar1", "bar2"}; |
| 6802 | std::vector<std::vector<std::string>> text_records = {foo_records, |
| 6803 | bar_records}; |
| 6804 | |
| 6805 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 6806 | rules.emplace_back("host", dns_protocol::kTypeTXT, false /* secure */, |
dalyk | c0ab072 | 2019-03-14 17:00:58 | [diff] [blame] | 6807 | MockDnsClientRule::Result(BuildTestDnsTextResponse( |
| 6808 | "host", std::move(text_records))), |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 6809 | false /* delay */); |
| 6810 | |
| 6811 | CreateResolver(); |
| 6812 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 6813 | |
| 6814 | HostResolver::ResolveHostParameters parameters; |
| 6815 | parameters.source = HostResolverSource::DNS; |
| 6816 | parameters.dns_query_type = DnsQueryType::TXT; |
| 6817 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 6818 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 6819 | HostPortPair("host", 108), NetLogWithSource(), parameters, |
| 6820 | request_context_.get(), host_cache_.get())); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 6821 | EXPECT_THAT(response.result_error(), IsOk()); |
| 6822 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 6823 | EXPECT_FALSE(response.request()->GetHostnameResults()); |
| 6824 | |
| 6825 | // Order between separate DNS records is undefined, but each record should |
| 6826 | // stay in order as that order may be meaningful. |
| 6827 | ASSERT_THAT(response.request()->GetTextResults(), |
| 6828 | testing::Optional(testing::UnorderedElementsAre( |
| 6829 | "foo1", "foo2", "foo3", "bar1", "bar2"))); |
| 6830 | std::vector<std::string> results = |
| 6831 | response.request()->GetTextResults().value(); |
| 6832 | EXPECT_NE(results.end(), std::search(results.begin(), results.end(), |
| 6833 | foo_records.begin(), foo_records.end())); |
| 6834 | EXPECT_NE(results.end(), std::search(results.begin(), results.end(), |
| 6835 | bar_records.begin(), bar_records.end())); |
| 6836 | } |
| 6837 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6838 | TEST_F(HostResolverManagerDnsTest, PtrQuery) { |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 6839 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 6840 | rules.emplace_back("host", dns_protocol::kTypePTR, false /* secure */, |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 6841 | MockDnsClientRule::Result(BuildTestDnsPointerResponse( |
| 6842 | "host", {"foo.com", "bar.com"})), |
| 6843 | false /* delay */); |
| 6844 | |
| 6845 | CreateResolver(); |
| 6846 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 6847 | |
| 6848 | HostResolver::ResolveHostParameters parameters; |
| 6849 | parameters.dns_query_type = DnsQueryType::PTR; |
| 6850 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 6851 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 6852 | HostPortPair("host", 108), NetLogWithSource(), parameters, |
| 6853 | request_context_.get(), host_cache_.get())); |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 6854 | EXPECT_THAT(response.result_error(), IsOk()); |
| 6855 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 6856 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 6857 | |
| 6858 | // Order between separate records is undefined. |
| 6859 | EXPECT_THAT(response.request()->GetHostnameResults(), |
| 6860 | testing::Optional(testing::UnorderedElementsAre( |
| 6861 | HostPortPair("foo.com", 108), HostPortPair("bar.com", 108)))); |
| 6862 | } |
| 6863 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6864 | TEST_F(HostResolverManagerDnsTest, PtrQuery_Ip) { |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 6865 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 6866 | rules.emplace_back("8.8.8.8", dns_protocol::kTypePTR, false /* secure */, |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 6867 | MockDnsClientRule::Result(BuildTestDnsPointerResponse( |
| 6868 | "8.8.8.8", {"foo.com", "bar.com"})), |
| 6869 | false /* delay */); |
| 6870 | |
| 6871 | CreateResolver(); |
| 6872 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 6873 | |
| 6874 | HostResolver::ResolveHostParameters parameters; |
| 6875 | parameters.dns_query_type = DnsQueryType::PTR; |
| 6876 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 6877 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 6878 | HostPortPair("8.8.8.8", 108), NetLogWithSource(), parameters, |
| 6879 | request_context_.get(), host_cache_.get())); |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 6880 | EXPECT_THAT(response.result_error(), IsOk()); |
| 6881 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 6882 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 6883 | |
| 6884 | // Order between separate records is undefined. |
| 6885 | EXPECT_THAT(response.request()->GetHostnameResults(), |
| 6886 | testing::Optional(testing::UnorderedElementsAre( |
| 6887 | HostPortPair("foo.com", 108), HostPortPair("bar.com", 108)))); |
| 6888 | } |
| 6889 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6890 | TEST_F(HostResolverManagerDnsTest, PtrQuery_NonexistentDomain) { |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 6891 | // Setup fallback to confirm it is not used for non-address results. |
| 6892 | set_allow_fallback_to_proctask(true); |
| 6893 | proc_->AddRuleForAllFamilies("host", "192.168.1.102"); |
| 6894 | proc_->SignalMultiple(1u); |
| 6895 | |
| 6896 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 6897 | rules.emplace_back("host", dns_protocol::kTypePTR, false /* secure */, |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 6898 | MockDnsClientRule::Result(MockDnsClientRule::NODOMAIN), |
| 6899 | false /* delay */); |
| 6900 | |
| 6901 | CreateResolver(); |
| 6902 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 6903 | |
| 6904 | HostResolver::ResolveHostParameters parameters; |
| 6905 | parameters.dns_query_type = DnsQueryType::PTR; |
| 6906 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 6907 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 6908 | HostPortPair("host", 108), NetLogWithSource(), parameters, |
| 6909 | request_context_.get(), host_cache_.get())); |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 6910 | EXPECT_THAT(response.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 6911 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 6912 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 6913 | EXPECT_FALSE(response.request()->GetHostnameResults()); |
| 6914 | } |
| 6915 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6916 | TEST_F(HostResolverManagerDnsTest, PtrQuery_Failure) { |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 6917 | // Setup fallback to confirm it is not used for non-address results. |
| 6918 | set_allow_fallback_to_proctask(true); |
| 6919 | proc_->AddRuleForAllFamilies("host", "192.168.1.102"); |
| 6920 | proc_->SignalMultiple(1u); |
| 6921 | |
| 6922 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 6923 | rules.emplace_back("host", dns_protocol::kTypePTR, false /* secure */, |
| 6924 | MockDnsClientRule::Result(MockDnsClientRule::FAIL), |
| 6925 | false /* delay */); |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 6926 | |
| 6927 | CreateResolver(); |
| 6928 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 6929 | |
| 6930 | HostResolver::ResolveHostParameters parameters; |
| 6931 | parameters.dns_query_type = DnsQueryType::PTR; |
| 6932 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 6933 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 6934 | HostPortPair("host", 108), NetLogWithSource(), parameters, |
| 6935 | request_context_.get(), host_cache_.get())); |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 6936 | EXPECT_THAT(response.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 6937 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 6938 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 6939 | EXPECT_FALSE(response.request()->GetHostnameResults()); |
| 6940 | } |
| 6941 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6942 | TEST_F(HostResolverManagerDnsTest, PtrQuery_Timeout) { |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 6943 | // Setup fallback to confirm it is not used for non-address results. |
| 6944 | set_allow_fallback_to_proctask(true); |
| 6945 | proc_->AddRuleForAllFamilies("host", "192.168.1.102"); |
| 6946 | proc_->SignalMultiple(1u); |
| 6947 | |
| 6948 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 6949 | rules.emplace_back("host", dns_protocol::kTypePTR, false /* secure */, |
| 6950 | MockDnsClientRule::Result(MockDnsClientRule::TIMEOUT), |
| 6951 | false /* delay */); |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 6952 | |
| 6953 | CreateResolver(); |
| 6954 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 6955 | |
| 6956 | HostResolver::ResolveHostParameters parameters; |
| 6957 | parameters.dns_query_type = DnsQueryType::PTR; |
| 6958 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 6959 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 6960 | HostPortPair("host", 108), NetLogWithSource(), parameters, |
| 6961 | request_context_.get(), host_cache_.get())); |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 6962 | EXPECT_THAT(response.result_error(), IsError(ERR_DNS_TIMED_OUT)); |
| 6963 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 6964 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 6965 | EXPECT_FALSE(response.request()->GetHostnameResults()); |
| 6966 | } |
| 6967 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6968 | TEST_F(HostResolverManagerDnsTest, PtrQuery_Empty) { |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 6969 | // Setup fallback to confirm it is not used for non-address results. |
| 6970 | set_allow_fallback_to_proctask(true); |
| 6971 | proc_->AddRuleForAllFamilies("host", "192.168.1.102"); |
| 6972 | proc_->SignalMultiple(1u); |
| 6973 | |
| 6974 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 6975 | rules.emplace_back("host", dns_protocol::kTypePTR, false /* secure */, |
| 6976 | MockDnsClientRule::Result(MockDnsClientRule::EMPTY), |
| 6977 | false /* delay */); |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 6978 | |
| 6979 | CreateResolver(); |
| 6980 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 6981 | |
| 6982 | HostResolver::ResolveHostParameters parameters; |
| 6983 | parameters.dns_query_type = DnsQueryType::PTR; |
| 6984 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 6985 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 6986 | HostPortPair("host", 108), NetLogWithSource(), parameters, |
| 6987 | request_context_.get(), host_cache_.get())); |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 6988 | EXPECT_THAT(response.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 6989 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 6990 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 6991 | EXPECT_FALSE(response.request()->GetHostnameResults()); |
| 6992 | } |
| 6993 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6994 | TEST_F(HostResolverManagerDnsTest, PtrQuery_Malformed) { |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 6995 | // Setup fallback to confirm it is not used for non-address results. |
| 6996 | set_allow_fallback_to_proctask(true); |
| 6997 | proc_->AddRuleForAllFamilies("host", "192.168.1.102"); |
| 6998 | proc_->SignalMultiple(1u); |
| 6999 | |
| 7000 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 7001 | rules.emplace_back("host", dns_protocol::kTypePTR, false /* secure */, |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 7002 | MockDnsClientRule::Result(MockDnsClientRule::MALFORMED), |
| 7003 | false /* delay */); |
| 7004 | |
| 7005 | CreateResolver(); |
| 7006 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 7007 | |
| 7008 | HostResolver::ResolveHostParameters parameters; |
| 7009 | parameters.dns_query_type = DnsQueryType::PTR; |
| 7010 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 7011 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 7012 | HostPortPair("host", 108), NetLogWithSource(), parameters, |
| 7013 | request_context_.get(), host_cache_.get())); |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 7014 | EXPECT_THAT(response.result_error(), IsError(ERR_DNS_MALFORMED_RESPONSE)); |
| 7015 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 7016 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 7017 | EXPECT_FALSE(response.request()->GetHostnameResults()); |
| 7018 | } |
| 7019 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 7020 | TEST_F(HostResolverManagerDnsTest, PtrQuery_MismatchedName) { |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 7021 | std::vector<std::string> ptr_records = {{"foo.com"}}; |
| 7022 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 7023 | rules.emplace_back("host", dns_protocol::kTypePTR, false /* secure */, |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 7024 | MockDnsClientRule::Result(BuildTestDnsPointerResponse( |
| 7025 | "host", std::move(ptr_records), "not.host")), |
| 7026 | false /* delay */); |
| 7027 | |
| 7028 | CreateResolver(); |
| 7029 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 7030 | |
| 7031 | HostResolver::ResolveHostParameters parameters; |
| 7032 | parameters.dns_query_type = DnsQueryType::PTR; |
| 7033 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 7034 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 7035 | HostPortPair("host", 108), NetLogWithSource(), parameters, |
| 7036 | request_context_.get(), host_cache_.get())); |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 7037 | EXPECT_THAT(response.result_error(), IsError(ERR_DNS_MALFORMED_RESPONSE)); |
| 7038 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 7039 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 7040 | EXPECT_FALSE(response.request()->GetHostnameResults()); |
| 7041 | } |
| 7042 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 7043 | TEST_F(HostResolverManagerDnsTest, PtrQuery_WrongType) { |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 7044 | // Respond to a TXT query with an A response. |
| 7045 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 7046 | rules.emplace_back("host", dns_protocol::kTypePTR, false /* secure */, |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 7047 | MockDnsClientRule::Result( |
| 7048 | BuildTestDnsResponse("host", IPAddress(1, 2, 3, 4))), |
| 7049 | false /* delay */); |
| 7050 | |
| 7051 | CreateResolver(); |
| 7052 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 7053 | |
| 7054 | HostResolver::ResolveHostParameters parameters; |
| 7055 | parameters.dns_query_type = DnsQueryType::PTR; |
| 7056 | |
| 7057 | // Responses for the wrong type should be ignored. |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 7058 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 7059 | HostPortPair("ok", 108), NetLogWithSource(), parameters, |
| 7060 | request_context_.get(), host_cache_.get())); |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 7061 | EXPECT_THAT(response.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 7062 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 7063 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 7064 | EXPECT_FALSE(response.request()->GetHostnameResults()); |
| 7065 | } |
| 7066 | |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7067 | // Same as PtrQuery except we specify DNS HostResolverSource instead of relying |
| 7068 | // on automatic determination. Expect same results since DNS should be what we |
| 7069 | // automatically determine, but some slightly different logic paths are |
| 7070 | // involved. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 7071 | TEST_F(HostResolverManagerDnsTest, PtrDnsQuery) { |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 7072 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 7073 | rules.emplace_back("host", dns_protocol::kTypePTR, false /* secure */, |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 7074 | MockDnsClientRule::Result(BuildTestDnsPointerResponse( |
| 7075 | "host", {"foo.com", "bar.com"})), |
| 7076 | false /* delay */); |
| 7077 | |
| 7078 | CreateResolver(); |
| 7079 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 7080 | |
| 7081 | HostResolver::ResolveHostParameters parameters; |
| 7082 | parameters.source = HostResolverSource::DNS; |
| 7083 | parameters.dns_query_type = DnsQueryType::PTR; |
| 7084 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 7085 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 7086 | HostPortPair("host", 108), NetLogWithSource(), parameters, |
| 7087 | request_context_.get(), host_cache_.get())); |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 7088 | EXPECT_THAT(response.result_error(), IsOk()); |
| 7089 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 7090 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 7091 | |
| 7092 | // Order between separate records is undefined. |
| 7093 | EXPECT_THAT(response.request()->GetHostnameResults(), |
| 7094 | testing::Optional(testing::UnorderedElementsAre( |
| 7095 | HostPortPair("foo.com", 108), HostPortPair("bar.com", 108)))); |
| 7096 | } |
| 7097 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 7098 | TEST_F(HostResolverManagerDnsTest, SrvQuery) { |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7099 | const TestServiceRecord kRecord1 = {2, 3, 1223, "foo.com"}; |
| 7100 | const TestServiceRecord kRecord2 = {5, 10, 80, "bar.com"}; |
| 7101 | const TestServiceRecord kRecord3 = {5, 1, 5, "google.com"}; |
| 7102 | const TestServiceRecord kRecord4 = {2, 100, 12345, "chromium.org"}; |
| 7103 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 7104 | rules.emplace_back("host", dns_protocol::kTypeSRV, false /* secure */, |
dalyk | c0ab072 | 2019-03-14 17:00:58 | [diff] [blame] | 7105 | MockDnsClientRule::Result(BuildTestDnsServiceResponse( |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7106 | "host", {kRecord1, kRecord2, kRecord3, kRecord4})), |
| 7107 | false /* delay */); |
| 7108 | |
| 7109 | CreateResolver(); |
| 7110 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 7111 | |
| 7112 | HostResolver::ResolveHostParameters parameters; |
| 7113 | parameters.dns_query_type = DnsQueryType::SRV; |
| 7114 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 7115 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 7116 | HostPortPair("host", 108), NetLogWithSource(), parameters, |
| 7117 | request_context_.get(), host_cache_.get())); |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7118 | EXPECT_THAT(response.result_error(), IsOk()); |
| 7119 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 7120 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 7121 | |
| 7122 | // Expect ordered by priority, and random within a priority. |
| 7123 | base::Optional<std::vector<HostPortPair>> results = |
| 7124 | response.request()->GetHostnameResults(); |
| 7125 | ASSERT_THAT( |
| 7126 | results, |
| 7127 | testing::Optional(testing::UnorderedElementsAre( |
| 7128 | HostPortPair("foo.com", 1223), HostPortPair("bar.com", 80), |
| 7129 | HostPortPair("google.com", 5), HostPortPair("chromium.org", 12345)))); |
| 7130 | auto priority2 = std::vector<HostPortPair>(results.value().begin(), |
| 7131 | results.value().begin() + 2); |
| 7132 | EXPECT_THAT(priority2, testing::UnorderedElementsAre( |
| 7133 | HostPortPair("foo.com", 1223), |
| 7134 | HostPortPair("chromium.org", 12345))); |
| 7135 | auto priority5 = std::vector<HostPortPair>(results.value().begin() + 2, |
| 7136 | results.value().end()); |
| 7137 | EXPECT_THAT(priority5, |
| 7138 | testing::UnorderedElementsAre(HostPortPair("bar.com", 80), |
| 7139 | HostPortPair("google.com", 5))); |
| 7140 | } |
| 7141 | |
| 7142 | // 0-weight services are allowed. Ensure that we can handle such records, |
| 7143 | // especially the case where all entries have weight 0. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 7144 | TEST_F(HostResolverManagerDnsTest, SrvQuery_ZeroWeight) { |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7145 | const TestServiceRecord kRecord1 = {5, 0, 80, "bar.com"}; |
| 7146 | const TestServiceRecord kRecord2 = {5, 0, 5, "google.com"}; |
| 7147 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 7148 | rules.emplace_back("host", dns_protocol::kTypeSRV, false /* secure */, |
dalyk | c0ab072 | 2019-03-14 17:00:58 | [diff] [blame] | 7149 | MockDnsClientRule::Result(BuildTestDnsServiceResponse( |
| 7150 | "host", {kRecord1, kRecord2})), |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7151 | false /* delay */); |
| 7152 | |
| 7153 | CreateResolver(); |
| 7154 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 7155 | |
| 7156 | HostResolver::ResolveHostParameters parameters; |
| 7157 | parameters.dns_query_type = DnsQueryType::SRV; |
| 7158 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 7159 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 7160 | HostPortPair("host", 108), NetLogWithSource(), parameters, |
| 7161 | request_context_.get(), host_cache_.get())); |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7162 | EXPECT_THAT(response.result_error(), IsOk()); |
| 7163 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 7164 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 7165 | |
| 7166 | // Expect ordered by priority, and random within a priority. |
| 7167 | EXPECT_THAT(response.request()->GetHostnameResults(), |
| 7168 | testing::Optional(testing::UnorderedElementsAre( |
| 7169 | HostPortPair("bar.com", 80), HostPortPair("google.com", 5)))); |
| 7170 | } |
| 7171 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 7172 | TEST_F(HostResolverManagerDnsTest, SrvQuery_NonexistentDomain) { |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7173 | // Setup fallback to confirm it is not used for non-address results. |
| 7174 | set_allow_fallback_to_proctask(true); |
| 7175 | proc_->AddRuleForAllFamilies("host", "192.168.1.102"); |
| 7176 | proc_->SignalMultiple(1u); |
| 7177 | |
| 7178 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 7179 | rules.emplace_back("host", dns_protocol::kTypeSRV, false /* secure */, |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7180 | MockDnsClientRule::Result(MockDnsClientRule::NODOMAIN), |
| 7181 | false /* delay */); |
| 7182 | |
| 7183 | CreateResolver(); |
| 7184 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 7185 | |
| 7186 | HostResolver::ResolveHostParameters parameters; |
| 7187 | parameters.dns_query_type = DnsQueryType::SRV; |
| 7188 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 7189 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 7190 | HostPortPair("host", 108), NetLogWithSource(), parameters, |
| 7191 | request_context_.get(), host_cache_.get())); |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7192 | EXPECT_THAT(response.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 7193 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 7194 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 7195 | EXPECT_FALSE(response.request()->GetHostnameResults()); |
| 7196 | } |
| 7197 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 7198 | TEST_F(HostResolverManagerDnsTest, SrvQuery_Failure) { |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7199 | // Setup fallback to confirm it is not used for non-address results. |
| 7200 | set_allow_fallback_to_proctask(true); |
| 7201 | proc_->AddRuleForAllFamilies("host", "192.168.1.102"); |
| 7202 | proc_->SignalMultiple(1u); |
| 7203 | |
| 7204 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 7205 | rules.emplace_back("host", dns_protocol::kTypeSRV, false /* secure */, |
| 7206 | MockDnsClientRule::Result(MockDnsClientRule::FAIL), |
| 7207 | false /* delay */); |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7208 | |
| 7209 | CreateResolver(); |
| 7210 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 7211 | |
| 7212 | HostResolver::ResolveHostParameters parameters; |
| 7213 | parameters.dns_query_type = DnsQueryType::SRV; |
| 7214 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 7215 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 7216 | HostPortPair("host", 108), NetLogWithSource(), parameters, |
| 7217 | request_context_.get(), host_cache_.get())); |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7218 | EXPECT_THAT(response.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 7219 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 7220 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 7221 | EXPECT_FALSE(response.request()->GetHostnameResults()); |
| 7222 | } |
| 7223 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 7224 | TEST_F(HostResolverManagerDnsTest, SrvQuery_Timeout) { |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7225 | // Setup fallback to confirm it is not used for non-address results. |
| 7226 | set_allow_fallback_to_proctask(true); |
| 7227 | proc_->AddRuleForAllFamilies("host", "192.168.1.102"); |
| 7228 | proc_->SignalMultiple(1u); |
| 7229 | |
| 7230 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 7231 | rules.emplace_back("host", dns_protocol::kTypeSRV, false /* secure */, |
| 7232 | MockDnsClientRule::Result(MockDnsClientRule::TIMEOUT), |
| 7233 | false /* delay */); |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7234 | |
| 7235 | CreateResolver(); |
| 7236 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 7237 | |
| 7238 | HostResolver::ResolveHostParameters parameters; |
| 7239 | parameters.dns_query_type = DnsQueryType::SRV; |
| 7240 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 7241 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 7242 | HostPortPair("host", 108), NetLogWithSource(), parameters, |
| 7243 | request_context_.get(), host_cache_.get())); |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7244 | EXPECT_THAT(response.result_error(), IsError(ERR_DNS_TIMED_OUT)); |
| 7245 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 7246 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 7247 | EXPECT_FALSE(response.request()->GetHostnameResults()); |
| 7248 | } |
| 7249 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 7250 | TEST_F(HostResolverManagerDnsTest, SrvQuery_Empty) { |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7251 | // Setup fallback to confirm it is not used for non-address results. |
| 7252 | set_allow_fallback_to_proctask(true); |
| 7253 | proc_->AddRuleForAllFamilies("host", "192.168.1.102"); |
| 7254 | proc_->SignalMultiple(1u); |
| 7255 | |
| 7256 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 7257 | rules.emplace_back("host", dns_protocol::kTypeSRV, false /* secure */, |
| 7258 | MockDnsClientRule::Result(MockDnsClientRule::EMPTY), |
| 7259 | false /* delay */); |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7260 | |
| 7261 | CreateResolver(); |
| 7262 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 7263 | |
| 7264 | HostResolver::ResolveHostParameters parameters; |
| 7265 | parameters.dns_query_type = DnsQueryType::SRV; |
| 7266 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 7267 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 7268 | HostPortPair("host", 108), NetLogWithSource(), parameters, |
| 7269 | request_context_.get(), host_cache_.get())); |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7270 | EXPECT_THAT(response.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 7271 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 7272 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 7273 | EXPECT_FALSE(response.request()->GetHostnameResults()); |
| 7274 | } |
| 7275 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 7276 | TEST_F(HostResolverManagerDnsTest, SrvQuery_Malformed) { |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7277 | // Setup fallback to confirm it is not used for non-address results. |
| 7278 | set_allow_fallback_to_proctask(true); |
| 7279 | proc_->AddRuleForAllFamilies("host", "192.168.1.102"); |
| 7280 | proc_->SignalMultiple(1u); |
| 7281 | |
| 7282 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 7283 | rules.emplace_back("host", dns_protocol::kTypeSRV, false /* secure */, |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7284 | MockDnsClientRule::Result(MockDnsClientRule::MALFORMED), |
| 7285 | false /* delay */); |
| 7286 | |
| 7287 | CreateResolver(); |
| 7288 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 7289 | |
| 7290 | HostResolver::ResolveHostParameters parameters; |
| 7291 | parameters.dns_query_type = DnsQueryType::SRV; |
| 7292 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 7293 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 7294 | HostPortPair("host", 108), NetLogWithSource(), parameters, |
| 7295 | request_context_.get(), host_cache_.get())); |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7296 | EXPECT_THAT(response.result_error(), IsError(ERR_DNS_MALFORMED_RESPONSE)); |
| 7297 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 7298 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 7299 | EXPECT_FALSE(response.request()->GetHostnameResults()); |
| 7300 | } |
| 7301 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 7302 | TEST_F(HostResolverManagerDnsTest, SrvQuery_MismatchedName) { |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7303 | std::vector<TestServiceRecord> srv_records = {{1, 2, 3, "foo.com"}}; |
| 7304 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 7305 | rules.emplace_back("host", dns_protocol::kTypeSRV, false /* secure */, |
dalyk | c0ab072 | 2019-03-14 17:00:58 | [diff] [blame] | 7306 | MockDnsClientRule::Result(BuildTestDnsServiceResponse( |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7307 | "host", std::move(srv_records), "not.host")), |
| 7308 | false /* delay */); |
| 7309 | |
| 7310 | CreateResolver(); |
| 7311 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 7312 | |
| 7313 | HostResolver::ResolveHostParameters parameters; |
| 7314 | parameters.dns_query_type = DnsQueryType::SRV; |
| 7315 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 7316 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 7317 | HostPortPair("host", 108), NetLogWithSource(), parameters, |
| 7318 | request_context_.get(), host_cache_.get())); |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7319 | EXPECT_THAT(response.result_error(), IsError(ERR_DNS_MALFORMED_RESPONSE)); |
| 7320 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 7321 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 7322 | EXPECT_FALSE(response.request()->GetHostnameResults()); |
| 7323 | } |
| 7324 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 7325 | TEST_F(HostResolverManagerDnsTest, SrvQuery_WrongType) { |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7326 | // Respond to a SRV query with an A response. |
| 7327 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 7328 | rules.emplace_back("host", dns_protocol::kTypeSRV, false /* secure */, |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7329 | MockDnsClientRule::Result( |
| 7330 | BuildTestDnsResponse("host", IPAddress(1, 2, 3, 4))), |
| 7331 | false /* delay */); |
| 7332 | |
| 7333 | CreateResolver(); |
| 7334 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 7335 | |
| 7336 | HostResolver::ResolveHostParameters parameters; |
| 7337 | parameters.dns_query_type = DnsQueryType::SRV; |
| 7338 | |
| 7339 | // Responses for the wrong type should be ignored. |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 7340 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 7341 | HostPortPair("ok", 108), NetLogWithSource(), parameters, |
| 7342 | request_context_.get(), host_cache_.get())); |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7343 | EXPECT_THAT(response.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 7344 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 7345 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 7346 | EXPECT_FALSE(response.request()->GetHostnameResults()); |
| 7347 | } |
| 7348 | |
| 7349 | // Same as SrvQuery except we specify DNS HostResolverSource instead of relying |
| 7350 | // on automatic determination. Expect same results since DNS should be what we |
| 7351 | // automatically determine, but some slightly different logic paths are |
| 7352 | // involved. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 7353 | TEST_F(HostResolverManagerDnsTest, SrvDnsQuery) { |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7354 | const TestServiceRecord kRecord1 = {2, 3, 1223, "foo.com"}; |
| 7355 | const TestServiceRecord kRecord2 = {5, 10, 80, "bar.com"}; |
| 7356 | const TestServiceRecord kRecord3 = {5, 1, 5, "google.com"}; |
| 7357 | const TestServiceRecord kRecord4 = {2, 100, 12345, "chromium.org"}; |
| 7358 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 7359 | rules.emplace_back("host", dns_protocol::kTypeSRV, false /* secure */, |
dalyk | c0ab072 | 2019-03-14 17:00:58 | [diff] [blame] | 7360 | MockDnsClientRule::Result(BuildTestDnsServiceResponse( |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7361 | "host", {kRecord1, kRecord2, kRecord3, kRecord4})), |
| 7362 | false /* delay */); |
| 7363 | |
| 7364 | CreateResolver(); |
| 7365 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 7366 | |
| 7367 | HostResolver::ResolveHostParameters parameters; |
| 7368 | parameters.source = HostResolverSource::DNS; |
| 7369 | parameters.dns_query_type = DnsQueryType::SRV; |
| 7370 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 7371 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 7372 | HostPortPair("host", 108), NetLogWithSource(), parameters, |
| 7373 | request_context_.get(), host_cache_.get())); |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7374 | EXPECT_THAT(response.result_error(), IsOk()); |
| 7375 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 7376 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 7377 | |
| 7378 | // Expect ordered by priority, and random within a priority. |
| 7379 | base::Optional<std::vector<HostPortPair>> results = |
| 7380 | response.request()->GetHostnameResults(); |
| 7381 | ASSERT_THAT( |
| 7382 | results, |
| 7383 | testing::Optional(testing::UnorderedElementsAre( |
| 7384 | HostPortPair("foo.com", 1223), HostPortPair("bar.com", 80), |
| 7385 | HostPortPair("google.com", 5), HostPortPair("chromium.org", 12345)))); |
| 7386 | auto priority2 = std::vector<HostPortPair>(results.value().begin(), |
| 7387 | results.value().begin() + 2); |
| 7388 | EXPECT_THAT(priority2, testing::UnorderedElementsAre( |
| 7389 | HostPortPair("foo.com", 1223), |
| 7390 | HostPortPair("chromium.org", 12345))); |
| 7391 | auto priority5 = std::vector<HostPortPair>(results.value().begin() + 2, |
| 7392 | results.value().end()); |
| 7393 | EXPECT_THAT(priority5, |
| 7394 | testing::UnorderedElementsAre(HostPortPair("bar.com", 80), |
| 7395 | HostPortPair("google.com", 5))); |
| 7396 | } |
| 7397 | |
[email protected] | 259aefa | 2009-08-20 22:45:00 | [diff] [blame] | 7398 | } // namespace net |