[email protected] | a159531 | 2012-01-22 03:25:04 | [diff] [blame] | 1 | // Copyright (c) 2012 The Chromium Authors. All rights reserved. |
[email protected] | 5af3c57 | 2010-07-20 14:16:27 | [diff] [blame] | 2 | // Use of this source code is governed by a BSD-style license that can be |
[email protected] | aea8060 | 2009-09-18 00:55:08 | [diff] [blame] | 3 | // found in the LICENSE file. |
| 4 | |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 5 | #include <cmath> |
dcheng | c7eeda42 | 2015-12-26 03:56:48 | [diff] [blame] | 6 | #include <utility> |
[email protected] | a33cad2b6 | 2010-07-30 22:24:39 | [diff] [blame] | 7 | #include <vector> |
| 8 | |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 9 | #include "base/bind.h" |
| 10 | #include "base/bind_helpers.h" |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 11 | #include "base/compiler_specific.h" |
thestig | d8df033 | 2014-09-04 06:33:29 | [diff] [blame] | 12 | #include "base/files/file_util.h" |
[email protected] | ea1a3f6 | 2012-11-16 20:34:23 | [diff] [blame] | 13 | #include "base/files/scoped_temp_dir.h" |
[email protected] | fc9d8847 | 2013-08-14 02:31:17 | [diff] [blame] | 14 | #include "base/run_loop.h" |
Avi Drissman | 4365a478 | 2018-12-28 19:26:24 | [diff] [blame] | 15 | #include "base/stl_util.h" |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 16 | #include "base/strings/string_piece.h" |
Devlin Cronin | e4bcb40e | 2018-06-05 18:02:47 | [diff] [blame] | 17 | #include "base/test/metrics/histogram_tester.h" |
[email protected] | 999dd8c | 2013-11-12 06:45:54 | [diff] [blame] | 18 | #include "base/test/test_file_util.h" |
gab | f767595f | 2016-05-11 18:50:35 | [diff] [blame] | 19 | #include "base/threading/thread_task_runner_handle.h" |
[email protected] | 018aabc | 2010-10-29 16:16:59 | [diff] [blame] | 20 | #include "net/base/auth.h" |
mmenke | cbc2b71 | 2014-10-09 20:29:07 | [diff] [blame] | 21 | #include "net/base/chunked_upload_data_stream.h" |
Bence Béky | 8ddc249 | 2018-06-13 01:02:04 | [diff] [blame] | 22 | #include "net/base/completion_once_callback.h" |
mmenke | cbc2b71 | 2014-10-09 20:29:07 | [diff] [blame] | 23 | #include "net/base/elements_upload_data_stream.h" |
Tsuyoshi Horo | 01faed6 | 2019-02-20 22:11:37 | [diff] [blame] | 24 | #include "net/base/ip_endpoint.h" |
tbansal | 28e68f8 | 2016-02-04 02:56:15 | [diff] [blame] | 25 | #include "net/base/proxy_delegate.h" |
Lily Houghton | 582d462 | 2018-01-22 22:43:40 | [diff] [blame] | 26 | #include "net/base/proxy_server.h" |
[email protected] | 262eec8 | 2013-03-19 21:01:36 | [diff] [blame] | 27 | #include "net/base/request_priority.h" |
tbansal | 28e68f8 | 2016-02-04 02:56:15 | [diff] [blame] | 28 | #include "net/base/test_proxy_delegate.h" |
[email protected] | b2d26cfd | 2012-12-11 10:36:06 | [diff] [blame] | 29 | #include "net/base/upload_bytes_element_reader.h" |
[email protected] | b2d26cfd | 2012-12-11 10:36:06 | [diff] [blame] | 30 | #include "net/base/upload_file_element_reader.h" |
Bence Béky | 1a5d856 | 2018-01-05 17:29:28 | [diff] [blame] | 31 | #include "net/dns/mock_host_resolver.h" |
aberent | bba302d | 2015-12-03 10:20:19 | [diff] [blame] | 32 | #include "net/http/http_auth_scheme.h" |
bnc | 3171a243 | 2016-12-28 18:40:26 | [diff] [blame] | 33 | #include "net/http/http_network_session.h" |
[email protected] | 87bfa3f | 2010-09-30 14:54:56 | [diff] [blame] | 34 | #include "net/http/http_network_session_peer.h" |
[email protected] | 513963e | 2013-06-15 01:53:04 | [diff] [blame] | 35 | #include "net/http/http_network_transaction.h" |
Matt Menke | 6e879bd | 2019-03-18 17:26:04 | [diff] [blame] | 36 | #include "net/http/http_proxy_connect_job.h" |
Bence Béky | 3a0c4853 | 2018-03-02 13:38:51 | [diff] [blame] | 37 | #include "net/http/http_response_info.h" |
[email protected] | 513963e | 2013-06-15 01:53:04 | [diff] [blame] | 38 | #include "net/http/http_server_properties.h" |
[email protected] | c41737d | 2014-05-14 07:47:19 | [diff] [blame] | 39 | #include "net/http/http_transaction_test_util.h" |
mikecirone | 8b85c43 | 2016-09-08 19:11:00 | [diff] [blame] | 40 | #include "net/log/net_log_event_type.h" |
mikecirone | f22f981 | 2016-10-04 03:40:19 | [diff] [blame] | 41 | #include "net/log/net_log_with_source.h" |
mmenke | 16a7cbdd | 2015-04-24 23:00:56 | [diff] [blame] | 42 | #include "net/log/test_net_log.h" |
mmenke | 43758e6 | 2015-05-04 21:09:46 | [diff] [blame] | 43 | #include "net/log/test_net_log_entry.h" |
| 44 | #include "net/log/test_net_log_util.h" |
[email protected] | bb88e1d3 | 2013-05-03 23:11:07 | [diff] [blame] | 45 | #include "net/socket/next_proto.h" |
Paul Jensen | a457017a | 2018-01-19 23:52:04 | [diff] [blame] | 46 | #include "net/socket/socket_tag.h" |
Bence Béky | 94658bf | 2018-05-11 19:22:58 | [diff] [blame] | 47 | #include "net/spdy/buffered_spdy_framer.h" |
| 48 | #include "net/spdy/spdy_http_stream.h" |
| 49 | #include "net/spdy/spdy_http_utils.h" |
| 50 | #include "net/spdy/spdy_session.h" |
| 51 | #include "net/spdy/spdy_session_pool.h" |
| 52 | #include "net/spdy/spdy_test_util_common.h" |
[email protected] | 514aeaf | 2014-05-23 10:31:51 | [diff] [blame] | 53 | #include "net/ssl/ssl_connection_status_flags.h" |
bnc | ce36dca2 | 2015-04-21 22:11:23 | [diff] [blame] | 54 | #include "net/test/cert_test_util.h" |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 55 | #include "net/test/gtest_util.h" |
rsleevi | a69c79a | 2016-06-22 03:28:43 | [diff] [blame] | 56 | #include "net/test/test_data_directory.h" |
Bence Béky | 98447b1 | 2018-05-08 03:14:01 | [diff] [blame] | 57 | #include "net/test/test_with_scoped_task_environment.h" |
Victor Vasiliev | 27cc771 | 2019-01-24 11:50:14 | [diff] [blame] | 58 | #include "net/third_party/quiche/src/spdy/core/spdy_protocol.h" |
| 59 | #include "net/third_party/quiche/src/spdy/core/spdy_test_utils.h" |
rhalavati | 9ebaba7e | 2017-04-27 06:16:29 | [diff] [blame] | 60 | #include "net/traffic_annotation/network_traffic_annotation_test_helper.h" |
[email protected] | d2db029 | 2011-01-26 20:23:44 | [diff] [blame] | 61 | #include "net/url_request/url_request_test_util.h" |
Bence Béky | 0ca719f | 2018-01-31 13:41:19 | [diff] [blame] | 62 | #include "net/websockets/websocket_test_util.h" |
[email protected] | 251029e | 2014-03-19 06:04:40 | [diff] [blame] | 63 | #include "testing/gmock/include/gmock/gmock.h" |
[email protected] | aea8060 | 2009-09-18 00:55:08 | [diff] [blame] | 64 | #include "testing/platform_test.h" |
| 65 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 66 | using net::test::IsError; |
| 67 | using net::test::IsOk; |
| 68 | |
[email protected] | aea8060 | 2009-09-18 00:55:08 | [diff] [blame] | 69 | //----------------------------------------------------------------------------- |
| 70 | |
[email protected] | d1eda93 | 2009-11-04 01:03:10 | [diff] [blame] | 71 | namespace net { |
[email protected] | dae22c5 | 2010-07-30 02:16:35 | [diff] [blame] | 72 | |
[email protected] | cbdd7316 | 2013-03-18 23:27:33 | [diff] [blame] | 73 | namespace { |
[email protected] | 251029e | 2014-03-19 06:04:40 | [diff] [blame] | 74 | |
| 75 | using testing::Each; |
| 76 | using testing::Eq; |
| 77 | |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 78 | const int32_t kBufferSize = SpdyHttpStream::kRequestBodyBufferSize; |
| 79 | |
[email protected] | 513963e | 2013-06-15 01:53:04 | [diff] [blame] | 80 | } // namespace |
| 81 | |
Bence Béky | d2df6c1c8 | 2018-04-20 22:52:01 | [diff] [blame] | 82 | const char kPushedUrl[] = "https://www.example.org/foo.dat"; |
| 83 | |
Bence Béky | 98447b1 | 2018-05-08 03:14:01 | [diff] [blame] | 84 | class SpdyNetworkTransactionTest : public TestWithScopedTaskEnvironment { |
[email protected] | 34437af8 | 2009-11-06 02:28:49 | [diff] [blame] | 85 | protected: |
rdsmith | ebb50aa | 2015-11-12 03:44:38 | [diff] [blame] | 86 | SpdyNetworkTransactionTest() |
bnc | b2602438 | 2016-06-29 02:39:45 | [diff] [blame] | 87 | : default_url_(kDefaultUrl), |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 88 | host_port_pair_(HostPortPair::FromURL(default_url_)) {} |
[email protected] | 2d672869 | 2011-03-12 01:39:55 | [diff] [blame] | 89 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 90 | ~SpdyNetworkTransactionTest() override { |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 91 | // UploadDataStream may post a deletion task back to the message loop on |
[email protected] | fc9d8847 | 2013-08-14 02:31:17 | [diff] [blame] | 92 | // destruction. |
| 93 | upload_data_stream_.reset(); |
| 94 | base::RunLoop().RunUntilIdle(); |
| 95 | } |
| 96 | |
dcheng | 67be2b1f | 2014-10-27 21:47:29 | [diff] [blame] | 97 | void SetUp() override { |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 98 | request_.method = "GET"; |
| 99 | request_.url = GURL(kDefaultUrl); |
Ramin Halavati | b5e433e6 | 2018-02-07 07:41:10 | [diff] [blame] | 100 | request_.traffic_annotation = |
| 101 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
[email protected] | 69e6b4a | 2012-10-18 08:03:01 | [diff] [blame] | 102 | ASSERT_TRUE(temp_dir_.CreateUniqueTempDir()); |
[email protected] | aea8060 | 2009-09-18 00:55:08 | [diff] [blame] | 103 | } |
| 104 | |
[email protected] | 72552f0 | 2009-10-28 15:25:01 | [diff] [blame] | 105 | struct TransactionHelperResult { |
[email protected] | aea8060 | 2009-09-18 00:55:08 | [diff] [blame] | 106 | int rv; |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 107 | std::string status_line; |
| 108 | std::string response_data; |
[email protected] | 8b07037 | 2009-11-16 22:01:25 | [diff] [blame] | 109 | HttpResponseInfo response_info; |
[email protected] | aea8060 | 2009-09-18 00:55:08 | [diff] [blame] | 110 | }; |
| 111 | |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 112 | // A helper class that handles all the initial npn/ssl setup. |
| 113 | class NormalSpdyTransactionHelper { |
| 114 | public: |
rdsmith | 82957ad | 2015-09-16 19:42:03 | [diff] [blame] | 115 | NormalSpdyTransactionHelper( |
| 116 | const HttpRequestInfo& request, |
| 117 | RequestPriority priority, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 118 | const NetLogWithSource& log, |
danakj | aee3e1ec | 2016-04-16 00:23:18 | [diff] [blame] | 119 | std::unique_ptr<SpdySessionDependencies> session_deps) |
[email protected] | 30c942b | 2010-07-21 16:59:59 | [diff] [blame] | 120 | : request_(request), |
[email protected] | 262eec8 | 2013-03-19 21:01:36 | [diff] [blame] | 121 | priority_(priority), |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 122 | session_deps_(session_deps.get() == nullptr |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 123 | ? std::make_unique<SpdySessionDependencies>() |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 124 | : std::move(session_deps)), |
xunjieli | 92551953 | 2017-01-30 15:33:17 | [diff] [blame] | 125 | log_(log) { |
| 126 | session_deps_->net_log = log.net_log(); |
| 127 | session_ = |
| 128 | SpdySessionDependencies::SpdyCreateSession(session_deps_.get()); |
| 129 | } |
[email protected] | 61b4efc | 2012-04-27 18:12:50 | [diff] [blame] | 130 | |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 131 | ~NormalSpdyTransactionHelper() { |
| 132 | // Any test which doesn't close the socket by sending it an EOF will |
| 133 | // have a valid session left open, which leaks the entire session pool. |
| 134 | // This is just fine - in fact, some of our tests intentionally do this |
| 135 | // so that we can check consistency of the SpdySessionPool as the test |
| 136 | // finishes. If we had put an EOF on the socket, the SpdySession would |
| 137 | // have closed and we wouldn't be able to check the consistency. |
| 138 | |
| 139 | // Forcefully close existing sessions here. |
| 140 | session()->spdy_session_pool()->CloseAllSessions(); |
| 141 | } |
| 142 | |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 143 | void RunPreTestSetup() { |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 144 | // We're now ready to use SSL-npn SPDY. |
bnc | 3f6a855 | 2017-05-17 13:40:34 | [diff] [blame] | 145 | trans_ = |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 146 | std::make_unique<HttpNetworkTransaction>(priority_, session_.get()); |
[email protected] | cb54b3b2 | 2010-06-03 16:28:55 | [diff] [blame] | 147 | } |
[email protected] | aea8060 | 2009-09-18 00:55:08 | [diff] [blame] | 148 | |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 149 | // Start the transaction, read some data, finish. |
| 150 | void RunDefaultTest() { |
[email protected] | 34b345f9 | 2013-02-22 03:27:26 | [diff] [blame] | 151 | if (!StartDefaultTest()) |
| 152 | return; |
| 153 | FinishDefaultTest(); |
| 154 | } |
| 155 | |
| 156 | bool StartDefaultTest() { |
[email protected] | 514aeaf | 2014-05-23 10:31:51 | [diff] [blame] | 157 | output_.rv = trans_->Start(&request_, callback_.callback(), log_); |
[email protected] | aea8060 | 2009-09-18 00:55:08 | [diff] [blame] | 158 | |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 159 | // We expect an IO Pending or some sort of error. |
| 160 | EXPECT_LT(output_.rv, 0); |
[email protected] | 34b345f9 | 2013-02-22 03:27:26 | [diff] [blame] | 161 | return output_.rv == ERR_IO_PENDING; |
| 162 | } |
[email protected] | aea8060 | 2009-09-18 00:55:08 | [diff] [blame] | 163 | |
[email protected] | 34b345f9 | 2013-02-22 03:27:26 | [diff] [blame] | 164 | void FinishDefaultTest() { |
[email protected] | 514aeaf | 2014-05-23 10:31:51 | [diff] [blame] | 165 | output_.rv = callback_.WaitForResult(); |
bnc | eb9aa711 | 2017-01-05 01:03:46 | [diff] [blame] | 166 | // Finish async network reads/writes. |
| 167 | base::RunLoop().RunUntilIdle(); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 168 | if (output_.rv != OK) { |
bnc | 301745a | 2015-03-10 03:22:16 | [diff] [blame] | 169 | session_->spdy_session_pool()->CloseCurrentSessions(ERR_ABORTED); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 170 | return; |
| 171 | } |
[email protected] | ff57bb8 | 2009-11-12 06:52:14 | [diff] [blame] | 172 | |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 173 | // Verify responses. |
| 174 | const HttpResponseInfo* response = trans_->GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 175 | ASSERT_TRUE(response); |
| 176 | ASSERT_TRUE(response->headers); |
bnc | 80bb1d4 | 2016-10-26 18:11:34 | [diff] [blame] | 177 | EXPECT_EQ(HttpResponseInfo::CONNECTION_INFO_HTTP2, |
bnc | 927c496 | 2016-07-21 14:45:59 | [diff] [blame] | 178 | response->connection_info); |
| 179 | EXPECT_EQ("HTTP/1.1 200", response->headers->GetStatusLine()); |
| 180 | EXPECT_TRUE(response->was_fetched_via_spdy); |
bnc | 94c9284 | 2016-09-21 15:22:52 | [diff] [blame] | 181 | EXPECT_TRUE(response->was_alpn_negotiated); |
Tsuyoshi Horo | 01faed6 | 2019-02-20 22:11:37 | [diff] [blame] | 182 | EXPECT_EQ("127.0.0.1", response->remote_endpoint.ToStringWithoutPort()); |
| 183 | EXPECT_EQ(443, response->remote_endpoint.port()); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 184 | output_.status_line = response->headers->GetStatusLine(); |
| 185 | output_.response_info = *response; // Make a copy so we can verify. |
| 186 | output_.rv = ReadTransaction(trans_.get(), &output_.response_data); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 187 | } |
| 188 | |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 189 | void FinishDefaultTestWithoutVerification() { |
| 190 | output_.rv = callback_.WaitForResult(); |
bnc | eb9aa711 | 2017-01-05 01:03:46 | [diff] [blame] | 191 | // Finish async network reads/writes. |
| 192 | base::RunLoop().RunUntilIdle(); |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 193 | if (output_.rv != OK) |
bnc | 301745a | 2015-03-10 03:22:16 | [diff] [blame] | 194 | session_->spdy_session_pool()->CloseCurrentSessions(ERR_ABORTED); |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 195 | } |
| 196 | |
maksim.sisov | 8d2df66d | 2016-06-20 07:07:11 | [diff] [blame] | 197 | void WaitForCallbackToComplete() { output_.rv = callback_.WaitForResult(); } |
mmenke | 666a6fea | 2015-12-19 04:16:33 | [diff] [blame] | 198 | |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 199 | // Most tests will want to call this function. In particular, the MockReads |
| 200 | // should end with an empty read, and that read needs to be processed to |
| 201 | // ensure proper deletion of the spdy_session_pool. |
| 202 | void VerifyDataConsumed() { |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 203 | for (const SocketDataProvider* provider : data_vector_) { |
| 204 | EXPECT_TRUE(provider->AllReadDataConsumed()); |
| 205 | EXPECT_TRUE(provider->AllWriteDataConsumed()); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 206 | } |
| 207 | } |
| 208 | |
| 209 | // Occasionally a test will expect to error out before certain reads are |
| 210 | // processed. In that case we want to explicitly ensure that the reads were |
| 211 | // not processed. |
| 212 | void VerifyDataNotConsumed() { |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 213 | for (const SocketDataProvider* provider : data_vector_) { |
| 214 | EXPECT_FALSE(provider->AllReadDataConsumed()); |
| 215 | EXPECT_FALSE(provider->AllWriteDataConsumed()); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 216 | } |
| 217 | } |
| 218 | |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 219 | void RunToCompletion(SocketDataProvider* data) { |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 220 | RunPreTestSetup(); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 221 | AddData(data); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 222 | RunDefaultTest(); |
| 223 | VerifyDataConsumed(); |
| 224 | } |
[email protected] | e6b0686 | 2010-07-20 16:32:58 | [diff] [blame] | 225 | |
[email protected] | 514aeaf | 2014-05-23 10:31:51 | [diff] [blame] | 226 | void RunToCompletionWithSSLData( |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 227 | SocketDataProvider* data, |
danakj | aee3e1ec | 2016-04-16 00:23:18 | [diff] [blame] | 228 | std::unique_ptr<SSLSocketDataProvider> ssl_provider) { |
[email protected] | 514aeaf | 2014-05-23 10:31:51 | [diff] [blame] | 229 | RunPreTestSetup(); |
dcheng | c7eeda42 | 2015-12-26 03:56:48 | [diff] [blame] | 230 | AddDataWithSSLSocketDataProvider(data, std::move(ssl_provider)); |
[email protected] | 514aeaf | 2014-05-23 10:31:51 | [diff] [blame] | 231 | RunDefaultTest(); |
| 232 | VerifyDataConsumed(); |
| 233 | } |
| 234 | |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 235 | void AddData(SocketDataProvider* data) { |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 236 | auto ssl_provider = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
Ryan Sleevi | 4f83209 | 2017-11-21 23:25:49 | [diff] [blame] | 237 | ssl_provider->ssl_info.cert = |
bnc | ce36dca2 | 2015-04-21 22:11:23 | [diff] [blame] | 238 | ImportCertFromFile(GetTestCertsDirectory(), "spdy_pooling.pem"); |
dcheng | c7eeda42 | 2015-12-26 03:56:48 | [diff] [blame] | 239 | AddDataWithSSLSocketDataProvider(data, std::move(ssl_provider)); |
[email protected] | 514aeaf | 2014-05-23 10:31:51 | [diff] [blame] | 240 | } |
| 241 | |
| 242 | void AddDataWithSSLSocketDataProvider( |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 243 | SocketDataProvider* data, |
danakj | aee3e1ec | 2016-04-16 00:23:18 | [diff] [blame] | 244 | std::unique_ptr<SSLSocketDataProvider> ssl_provider) { |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 245 | data_vector_.push_back(data); |
bnc | 3cf2a59 | 2016-08-11 14:48:36 | [diff] [blame] | 246 | if (ssl_provider->next_proto == kProtoUnknown) |
| 247 | ssl_provider->next_proto = kProtoHTTP2; |
rch | ebf1298 | 2015-04-10 01:15:00 | [diff] [blame] | 248 | |
| 249 | session_deps_->socket_factory->AddSSLSocketDataProvider( |
| 250 | ssl_provider.get()); |
olli.raula | ae011c42 | 2015-12-10 07:38:51 | [diff] [blame] | 251 | ssl_vector_.push_back(std::move(ssl_provider)); |
[email protected] | d4f0022 | 2012-07-10 06:24:51 | [diff] [blame] | 252 | |
[email protected] | 3b782843 | 2010-08-18 18:33:27 | [diff] [blame] | 253 | session_deps_->socket_factory->AddSocketDataProvider(data); |
| 254 | } |
| 255 | |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 256 | HttpNetworkTransaction* trans() { return trans_.get(); } |
| 257 | void ResetTrans() { trans_.reset(); } |
bnc | 4d782f49 | 2016-08-18 13:50:00 | [diff] [blame] | 258 | const TransactionHelperResult& output() { return output_; } |
mmenke | e65e7af | 2015-10-13 17:16:42 | [diff] [blame] | 259 | HttpNetworkSession* session() const { return session_.get(); } |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 260 | SpdySessionDependencies* session_deps() { return session_deps_.get(); } |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 261 | |
| 262 | private: |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 263 | typedef std::vector<SocketDataProvider*> DataVector; |
danakj | aee3e1ec | 2016-04-16 00:23:18 | [diff] [blame] | 264 | typedef std::vector<std::unique_ptr<SSLSocketDataProvider>> SSLVector; |
| 265 | typedef std::vector<std::unique_ptr<SocketDataProvider>> AlternateVector; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 266 | const HttpRequestInfo request_; |
| 267 | const RequestPriority priority_; |
danakj | aee3e1ec | 2016-04-16 00:23:18 | [diff] [blame] | 268 | std::unique_ptr<SpdySessionDependencies> session_deps_; |
| 269 | std::unique_ptr<HttpNetworkSession> session_; |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 270 | TransactionHelperResult output_; |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 271 | SSLVector ssl_vector_; |
[email protected] | 514aeaf | 2014-05-23 10:31:51 | [diff] [blame] | 272 | TestCompletionCallback callback_; |
danakj | aee3e1ec | 2016-04-16 00:23:18 | [diff] [blame] | 273 | std::unique_ptr<HttpNetworkTransaction> trans_; |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 274 | DataVector data_vector_; |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 275 | const NetLogWithSource log_; |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 276 | }; |
[email protected] | aea8060 | 2009-09-18 00:55:08 | [diff] [blame] | 277 | |
| 278 | void ConnectStatusHelperWithExpectedStatus(const MockRead& status, |
| 279 | int expected_status); |
| 280 | |
| 281 | void ConnectStatusHelper(const MockRead& status); |
[email protected] | d3cee19d | 2010-06-22 18:42:18 | [diff] [blame] | 282 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 283 | HttpRequestInfo CreateGetPushRequest() const WARN_UNUSED_RESULT { |
| 284 | HttpRequestInfo request; |
| 285 | request.method = "GET"; |
Bence Béky | d2df6c1c8 | 2018-04-20 22:52:01 | [diff] [blame] | 286 | request.url = GURL(kPushedUrl); |
Ramin Halavati | b5e433e6 | 2018-02-07 07:41:10 | [diff] [blame] | 287 | request.traffic_annotation = |
| 288 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 289 | return request; |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 290 | } |
| 291 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 292 | void UsePostRequest() { |
| 293 | ASSERT_FALSE(upload_data_stream_); |
| 294 | std::vector<std::unique_ptr<UploadElementReader>> element_readers; |
| 295 | element_readers.push_back(std::make_unique<UploadBytesElementReader>( |
| 296 | kUploadData, kUploadDataSize)); |
| 297 | upload_data_stream_ = std::make_unique<ElementsUploadDataStream>( |
| 298 | std::move(element_readers), 0); |
| 299 | |
| 300 | request_.method = "POST"; |
| 301 | request_.upload_data_stream = upload_data_stream_.get(); |
[email protected] | d3cee19d | 2010-06-22 18:42:18 | [diff] [blame] | 302 | } |
| 303 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 304 | void UseFilePostRequest() { |
| 305 | ASSERT_FALSE(upload_data_stream_); |
| 306 | base::FilePath file_path; |
| 307 | CHECK(base::CreateTemporaryFileInDir(temp_dir_.GetPath(), &file_path)); |
| 308 | CHECK_EQ(static_cast<int>(kUploadDataSize), |
| 309 | base::WriteFile(file_path, kUploadData, kUploadDataSize)); |
| 310 | |
| 311 | std::vector<std::unique_ptr<UploadElementReader>> element_readers; |
| 312 | element_readers.push_back(std::make_unique<UploadFileElementReader>( |
| 313 | base::ThreadTaskRunnerHandle::Get().get(), file_path, 0, |
| 314 | kUploadDataSize, base::Time())); |
| 315 | upload_data_stream_ = std::make_unique<ElementsUploadDataStream>( |
| 316 | std::move(element_readers), 0); |
| 317 | |
| 318 | request_.method = "POST"; |
| 319 | request_.upload_data_stream = upload_data_stream_.get(); |
Ramin Halavati | b5e433e6 | 2018-02-07 07:41:10 | [diff] [blame] | 320 | request_.traffic_annotation = |
| 321 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
[email protected] | 3deb9a5 | 2010-11-11 00:24:40 | [diff] [blame] | 322 | } |
| 323 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 324 | void UseUnreadableFilePostRequest() { |
| 325 | ASSERT_FALSE(upload_data_stream_); |
[email protected] | 999dd8c | 2013-11-12 06:45:54 | [diff] [blame] | 326 | base::FilePath file_path; |
vabr | b858232 | 2016-09-09 08:05:37 | [diff] [blame] | 327 | CHECK(base::CreateTemporaryFileInDir(temp_dir_.GetPath(), &file_path)); |
[email protected] | 999dd8c | 2013-11-12 06:45:54 | [diff] [blame] | 328 | CHECK_EQ(static_cast<int>(kUploadDataSize), |
[email protected] | e5c2a22e | 2014-03-06 20:42:30 | [diff] [blame] | 329 | base::WriteFile(file_path, kUploadData, kUploadDataSize)); |
[email protected] | 92be8eb | 2014-08-07 22:57:11 | [diff] [blame] | 330 | CHECK(base::MakeFileUnreadable(file_path)); |
[email protected] | 999dd8c | 2013-11-12 06:45:54 | [diff] [blame] | 331 | |
danakj | aee3e1ec | 2016-04-16 00:23:18 | [diff] [blame] | 332 | std::vector<std::unique_ptr<UploadElementReader>> element_readers; |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 333 | element_readers.push_back(std::make_unique<UploadFileElementReader>( |
skyostil | 4891b25b | 2015-06-11 11:43:45 | [diff] [blame] | 334 | base::ThreadTaskRunnerHandle::Get().get(), file_path, 0, |
ricea | 2deef68 | 2016-09-09 08:04:07 | [diff] [blame] | 335 | kUploadDataSize, base::Time())); |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 336 | upload_data_stream_ = std::make_unique<ElementsUploadDataStream>( |
bnc | 3f6a855 | 2017-05-17 13:40:34 | [diff] [blame] | 337 | std::move(element_readers), 0); |
[email protected] | 999dd8c | 2013-11-12 06:45:54 | [diff] [blame] | 338 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 339 | request_.method = "POST"; |
| 340 | request_.upload_data_stream = upload_data_stream_.get(); |
[email protected] | 999dd8c | 2013-11-12 06:45:54 | [diff] [blame] | 341 | } |
| 342 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 343 | void UseComplexPostRequest() { |
| 344 | ASSERT_FALSE(upload_data_stream_); |
| 345 | const int kFileRangeOffset = 1; |
| 346 | const int kFileRangeLength = 3; |
| 347 | CHECK_LT(kFileRangeOffset + kFileRangeLength, kUploadDataSize); |
[email protected] | 69e6b4a | 2012-10-18 08:03:01 | [diff] [blame] | 348 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 349 | base::FilePath file_path; |
| 350 | CHECK(base::CreateTemporaryFileInDir(temp_dir_.GetPath(), &file_path)); |
| 351 | CHECK_EQ(static_cast<int>(kUploadDataSize), |
| 352 | base::WriteFile(file_path, kUploadData, kUploadDataSize)); |
[email protected] | 69e6b4a | 2012-10-18 08:03:01 | [diff] [blame] | 353 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 354 | std::vector<std::unique_ptr<UploadElementReader>> element_readers; |
| 355 | element_readers.push_back(std::make_unique<UploadBytesElementReader>( |
| 356 | kUploadData, kFileRangeOffset)); |
| 357 | element_readers.push_back(std::make_unique<UploadFileElementReader>( |
| 358 | base::ThreadTaskRunnerHandle::Get().get(), file_path, kFileRangeOffset, |
| 359 | kFileRangeLength, base::Time())); |
| 360 | element_readers.push_back(std::make_unique<UploadBytesElementReader>( |
| 361 | kUploadData + kFileRangeOffset + kFileRangeLength, |
| 362 | kUploadDataSize - (kFileRangeOffset + kFileRangeLength))); |
| 363 | upload_data_stream_ = std::make_unique<ElementsUploadDataStream>( |
| 364 | std::move(element_readers), 0); |
[email protected] | 329b68b | 2012-11-14 17:54:27 | [diff] [blame] | 365 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 366 | request_.method = "POST"; |
| 367 | request_.upload_data_stream = upload_data_stream_.get(); |
[email protected] | 69e6b4a | 2012-10-18 08:03:01 | [diff] [blame] | 368 | } |
| 369 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 370 | void UseChunkedPostRequest() { |
| 371 | ASSERT_FALSE(upload_chunked_data_stream_); |
| 372 | upload_chunked_data_stream_ = std::make_unique<ChunkedUploadDataStream>(0); |
| 373 | request_.method = "POST"; |
| 374 | request_.upload_data_stream = upload_chunked_data_stream_.get(); |
[email protected] | 0c9bf87 | 2011-03-04 17:53:22 | [diff] [blame] | 375 | } |
| 376 | |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 377 | // Read the result of a particular transaction, knowing that we've got |
| 378 | // multiple transactions in the read pipeline; so as we read, we may have |
| 379 | // to skip over data destined for other transactions while we consume |
| 380 | // the data for |trans|. |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 381 | int ReadResult(HttpNetworkTransaction* trans, std::string* result) { |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 382 | const int kSize = 3000; |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 383 | |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 384 | int bytes_read = 0; |
Victor Costan | 9c7302b | 2018-08-27 16:39:44 | [diff] [blame] | 385 | scoped_refptr<IOBufferWithSize> buf = |
| 386 | base::MakeRefCounted<IOBufferWithSize>(kSize); |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 387 | TestCompletionCallback callback; |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 388 | while (true) { |
[email protected] | 9049948 | 2013-06-01 00:39:50 | [diff] [blame] | 389 | int rv = trans->Read(buf.get(), kSize, callback.callback()); |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 390 | if (rv == ERR_IO_PENDING) { |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 391 | rv = callback.WaitForResult(); |
| 392 | } else if (rv <= 0) { |
| 393 | break; |
| 394 | } |
| 395 | result->append(buf->data(), rv); |
| 396 | bytes_read += rv; |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 397 | } |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 398 | return bytes_read; |
| 399 | } |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 400 | |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 401 | void VerifyStreamsClosed(const NormalSpdyTransactionHelper& helper) { |
| 402 | // This lengthy block is reaching into the pool to dig out the active |
| 403 | // session. Once we have the session, we verify that the streams are |
| 404 | // all closed and not leaked at this point. |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 405 | SpdySessionKey key(HostPortPair::FromURL(request_.url), |
Paul Jensen | a457017a | 2018-01-19 23:52:04 | [diff] [blame] | 406 | ProxyServer::Direct(), PRIVACY_MODE_DISABLED, |
Matt Menke | 2436b2f | 2018-12-11 18:07:11 | [diff] [blame] | 407 | SpdySessionKey::IsProxySession::kFalse, SocketTag()); |
mmenke | e65e7af | 2015-10-13 17:16:42 | [diff] [blame] | 408 | HttpNetworkSession* session = helper.session(); |
[email protected] | 795cbf8 | 2013-07-22 09:37:27 | [diff] [blame] | 409 | base::WeakPtr<SpdySession> spdy_session = |
bnc | 9ead3ae | 2017-03-16 00:48:15 | [diff] [blame] | 410 | session->spdy_session_pool()->FindAvailableSession( |
Bence Béky | d885b2b | 2018-02-03 00:58:31 | [diff] [blame] | 411 | key, /* enable_ip_based_pooling = */ true, |
| 412 | /* is_websocket = */ false, log_); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 413 | ASSERT_TRUE(spdy_session); |
Bence Béky | 285e7d4 | 2017-12-04 20:22:11 | [diff] [blame] | 414 | EXPECT_EQ(0u, num_active_streams(spdy_session)); |
| 415 | EXPECT_EQ(0u, num_unclaimed_pushed_streams(spdy_session)); |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 416 | } |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 417 | |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 418 | void RunServerPushTest(SequencedSocketData* data, |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 419 | HttpResponseInfo* response, |
[email protected] | a7a265ef | 2010-12-08 18:05:57 | [diff] [blame] | 420 | HttpResponseInfo* push_response, |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 421 | const std::string& expected) { |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 422 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
| 423 | nullptr); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 424 | helper.RunPreTestSetup(); |
[email protected] | d0835850 | 2010-12-03 22:04:03 | [diff] [blame] | 425 | helper.AddData(data); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 426 | |
| 427 | HttpNetworkTransaction* trans = helper.trans(); |
| 428 | |
| 429 | // Start the transaction with basic parameters. |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 430 | TestCompletionCallback callback; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 431 | int rv = trans->Start(&request_, callback.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 432 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 433 | rv = callback.WaitForResult(); |
| 434 | |
bnc | eb9aa711 | 2017-01-05 01:03:46 | [diff] [blame] | 435 | // Finish async network reads/writes. |
| 436 | base::RunLoop().RunUntilIdle(); |
| 437 | |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 438 | // Request the pushed path. |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 439 | HttpNetworkTransaction trans2(DEFAULT_PRIORITY, helper.session()); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 440 | HttpRequestInfo request = CreateGetPushRequest(); |
| 441 | rv = trans2.Start(&request, callback.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 442 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | fc9d8847 | 2013-08-14 02:31:17 | [diff] [blame] | 443 | base::RunLoop().RunUntilIdle(); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 444 | |
[email protected] | 513963e | 2013-06-15 01:53:04 | [diff] [blame] | 445 | // The data for the pushed path may be coming in more than 1 frame. Compile |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 446 | // the results into a single string. |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 447 | |
| 448 | // Read the server push body. |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 449 | std::string result2; |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 450 | ReadResult(&trans2, &result2); |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 451 | // Read the response body. |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 452 | std::string result; |
rch | 0aecfd8 | 2015-05-19 17:22:32 | [diff] [blame] | 453 | ReadResult(trans, &result); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 454 | |
| 455 | // Verify that we consumed all test data. |
rch | 37de576c | 2015-05-17 20:28:17 | [diff] [blame] | 456 | EXPECT_TRUE(data->AllReadDataConsumed()); |
| 457 | EXPECT_TRUE(data->AllWriteDataConsumed()); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 458 | |
caseq | e8340bc9 | 2016-04-20 00:02:57 | [diff] [blame] | 459 | LoadTimingInfo load_timing_info; |
| 460 | EXPECT_TRUE(trans->GetLoadTimingInfo(&load_timing_info)); |
| 461 | EXPECT_TRUE(load_timing_info.push_start.is_null()); |
| 462 | EXPECT_TRUE(load_timing_info.push_end.is_null()); |
| 463 | |
| 464 | LoadTimingInfo load_timing_info2; |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 465 | EXPECT_TRUE(trans2.GetLoadTimingInfo(&load_timing_info2)); |
caseq | e8340bc9 | 2016-04-20 00:02:57 | [diff] [blame] | 466 | EXPECT_FALSE(load_timing_info2.push_start.is_null()); |
| 467 | EXPECT_FALSE(load_timing_info2.push_end.is_null()); |
| 468 | |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 469 | // Verify that the received push data is same as the expected push data. |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 470 | EXPECT_EQ(result2.compare(expected), 0) << "Received data: " |
| 471 | << result2 |
| 472 | << "||||| Expected data: " |
| 473 | << expected; |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 474 | |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 475 | // Verify the response HEADERS. |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 476 | // Copy the response info, because trans goes away. |
| 477 | *response = *trans->GetResponseInfo(); |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 478 | *push_response = *trans2.GetResponseInfo(); |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 479 | |
| 480 | VerifyStreamsClosed(helper); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 481 | } |
| 482 | |
morlovich | ab1d1c1e | 2017-02-07 19:59:28 | [diff] [blame] | 483 | void RunBrokenPushTest(SequencedSocketData* data, int expected_rv) { |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 484 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
| 485 | nullptr); |
morlovich | ab1d1c1e | 2017-02-07 19:59:28 | [diff] [blame] | 486 | helper.RunPreTestSetup(); |
| 487 | helper.AddData(data); |
| 488 | |
| 489 | HttpNetworkTransaction* trans = helper.trans(); |
| 490 | |
| 491 | // Start the transaction with basic parameters. |
| 492 | TestCompletionCallback callback; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 493 | int rv = trans->Start(&request_, callback.callback(), log_); |
morlovich | ab1d1c1e | 2017-02-07 19:59:28 | [diff] [blame] | 494 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 495 | rv = callback.WaitForResult(); |
| 496 | EXPECT_EQ(expected_rv, rv); |
| 497 | |
| 498 | // Finish async network reads/writes. |
| 499 | base::RunLoop().RunUntilIdle(); |
| 500 | |
| 501 | // Verify that we consumed all test data. |
| 502 | EXPECT_TRUE(data->AllReadDataConsumed()); |
| 503 | EXPECT_TRUE(data->AllWriteDataConsumed()); |
| 504 | |
| 505 | if (expected_rv == OK) { |
| 506 | // Expected main request to succeed, even if push failed. |
| 507 | HttpResponseInfo response = *trans->GetResponseInfo(); |
| 508 | EXPECT_TRUE(response.headers); |
| 509 | EXPECT_EQ("HTTP/1.1 200", response.headers->GetStatusLine()); |
| 510 | } |
| 511 | } |
| 512 | |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 513 | static void DeleteSessionCallback(NormalSpdyTransactionHelper* helper, |
| 514 | int result) { |
| 515 | helper->ResetTrans(); |
| 516 | } |
| 517 | |
mmenke | e65e7af | 2015-10-13 17:16:42 | [diff] [blame] | 518 | static void StartTransactionCallback(HttpNetworkSession* session, |
| 519 | GURL url, |
Bence Béky | d3dde83 | 2017-09-19 19:02:31 | [diff] [blame] | 520 | NetLogWithSource log, |
mmenke | e65e7af | 2015-10-13 17:16:42 | [diff] [blame] | 521 | int result) { |
krasin | 0bfeb6b | 2017-01-13 21:48:04 | [diff] [blame] | 522 | HttpRequestInfo request; |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 523 | HttpNetworkTransaction trans(DEFAULT_PRIORITY, session); |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 524 | TestCompletionCallback callback; |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 525 | request.method = "GET"; |
rch | ebf1298 | 2015-04-10 01:15:00 | [diff] [blame] | 526 | request.url = url; |
Ramin Halavati | b5e433e6 | 2018-02-07 07:41:10 | [diff] [blame] | 527 | request.traffic_annotation = |
| 528 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
Bence Béky | d3dde83 | 2017-09-19 19:02:31 | [diff] [blame] | 529 | int rv = trans.Start(&request, callback.callback(), log); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 530 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 531 | callback.WaitForResult(); |
| 532 | } |
| 533 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 534 | ChunkedUploadDataStream* upload_chunked_data_stream() { |
mmenke | cbc2b71 | 2014-10-09 20:29:07 | [diff] [blame] | 535 | return upload_chunked_data_stream_.get(); |
| 536 | } |
| 537 | |
Bence Béky | 285e7d4 | 2017-12-04 20:22:11 | [diff] [blame] | 538 | size_t num_active_streams(base::WeakPtr<SpdySession> session) { |
| 539 | return session->active_streams_.size(); |
| 540 | } |
| 541 | |
Bence Béky | fd2c1fd | 2017-12-15 02:32:03 | [diff] [blame] | 542 | static size_t num_unclaimed_pushed_streams( |
| 543 | base::WeakPtr<SpdySession> session) { |
| 544 | return session->pool_->push_promise_index()->CountStreamsForSession( |
| 545 | session.get()); |
Bence Béky | 285e7d4 | 2017-12-04 20:22:11 | [diff] [blame] | 546 | } |
| 547 | |
Bence Béky | fd2c1fd | 2017-12-15 02:32:03 | [diff] [blame] | 548 | static bool has_unclaimed_pushed_stream_for_url( |
| 549 | base::WeakPtr<SpdySession> session, |
| 550 | const GURL& url) { |
| 551 | return session->pool_->push_promise_index()->FindStream( |
| 552 | url, session.get()) != kNoPushedStreamFound; |
Bence Béky | 285e7d4 | 2017-12-04 20:22:11 | [diff] [blame] | 553 | } |
| 554 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 555 | static spdy::SpdyStreamId spdy_stream_hi_water_mark( |
Yoav Weiss | 9693572f | 2018-01-04 09:37:34 | [diff] [blame] | 556 | base::WeakPtr<SpdySession> session) { |
| 557 | return session->stream_hi_water_mark_; |
| 558 | } |
| 559 | |
bnc | b2602438 | 2016-06-29 02:39:45 | [diff] [blame] | 560 | const GURL default_url_; |
| 561 | const HostPortPair host_port_pair_; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 562 | HttpRequestInfo request_; |
[email protected] | 9ec54f8 | 2013-05-10 02:53:05 | [diff] [blame] | 563 | SpdyTestUtil spdy_util_; |
Bence Béky | d3dde83 | 2017-09-19 19:02:31 | [diff] [blame] | 564 | const NetLogWithSource log_; |
[email protected] | 9ec54f8 | 2013-05-10 02:53:05 | [diff] [blame] | 565 | |
[email protected] | d3cee19d | 2010-06-22 18:42:18 | [diff] [blame] | 566 | private: |
danakj | aee3e1ec | 2016-04-16 00:23:18 | [diff] [blame] | 567 | std::unique_ptr<ChunkedUploadDataStream> upload_chunked_data_stream_; |
| 568 | std::unique_ptr<UploadDataStream> upload_data_stream_; |
[email protected] | ea1a3f6 | 2012-11-16 20:34:23 | [diff] [blame] | 569 | base::ScopedTempDir temp_dir_; |
[email protected] | aea8060 | 2009-09-18 00:55:08 | [diff] [blame] | 570 | }; |
| 571 | |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 572 | // Verify HttpNetworkTransaction constructor. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 573 | TEST_F(SpdyNetworkTransactionTest, Constructor) { |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 574 | auto session_deps = std::make_unique<SpdySessionDependencies>(); |
danakj | aee3e1ec | 2016-04-16 00:23:18 | [diff] [blame] | 575 | std::unique_ptr<HttpNetworkSession> session( |
[email protected] | bb88e1d3 | 2013-05-03 23:11:07 | [diff] [blame] | 576 | SpdySessionDependencies::SpdyCreateSession(session_deps.get())); |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 577 | auto trans = |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 578 | std::make_unique<HttpNetworkTransaction>(DEFAULT_PRIORITY, session.get()); |
[email protected] | aea8060 | 2009-09-18 00:55:08 | [diff] [blame] | 579 | } |
| 580 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 581 | TEST_F(SpdyNetworkTransactionTest, Get) { |
[email protected] | 75f30cc2 | 2010-06-28 21:41:38 | [diff] [blame] | 582 | // Construct the request. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 583 | spdy::SpdySerializedFrame req( |
| 584 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 585 | MockWrite writes[] = {CreateMockWrite(req, 0)}; |
[email protected] | 72552f0 | 2009-10-28 15:25:01 | [diff] [blame] | 586 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 587 | spdy::SpdySerializedFrame resp( |
| 588 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 589 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | 72552f0 | 2009-10-28 15:25:01 | [diff] [blame] | 590 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 591 | CreateMockRead(resp, 1), CreateMockRead(body, 2), |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 592 | MockRead(ASYNC, 0, 3) // EOF |
[email protected] | 72552f0 | 2009-10-28 15:25:01 | [diff] [blame] | 593 | }; |
| 594 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 595 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 596 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 597 | helper.RunToCompletion(&data); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 598 | TransactionHelperResult out = helper.output(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 599 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 600 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | 72552f0 | 2009-10-28 15:25:01 | [diff] [blame] | 601 | EXPECT_EQ("hello!", out.response_data); |
| 602 | } |
| 603 | |
Bence Béky | 2fcf4fa | 2018-04-06 20:06:01 | [diff] [blame] | 604 | TEST_F(SpdyNetworkTransactionTest, SetPriority) { |
| 605 | for (bool set_priority_before_starting_transaction : {true, false}) { |
| 606 | SpdyTestUtil spdy_test_util; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 607 | spdy::SpdySerializedFrame req( |
Bence Béky | 2fcf4fa | 2018-04-06 20:06:01 | [diff] [blame] | 608 | spdy_test_util.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 609 | MockWrite writes[] = {CreateMockWrite(req, 0)}; |
| 610 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 611 | spdy::SpdySerializedFrame resp( |
Bence Béky | 2fcf4fa | 2018-04-06 20:06:01 | [diff] [blame] | 612 | spdy_test_util.ConstructSpdyGetReply(nullptr, 0, 1)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 613 | spdy::SpdySerializedFrame body( |
| 614 | spdy_test_util.ConstructSpdyDataFrame(1, true)); |
Bence Béky | 2fcf4fa | 2018-04-06 20:06:01 | [diff] [blame] | 615 | MockRead reads[] = {CreateMockRead(resp, 1), CreateMockRead(body, 2), |
| 616 | MockRead(ASYNC, 0, 3)}; |
| 617 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 618 | SequencedSocketData data(reads, writes); |
Bence Béky | 2fcf4fa | 2018-04-06 20:06:01 | [diff] [blame] | 619 | NormalSpdyTransactionHelper helper(request_, HIGHEST, log_, nullptr); |
| 620 | helper.RunPreTestSetup(); |
| 621 | helper.AddData(&data); |
| 622 | |
| 623 | if (set_priority_before_starting_transaction) { |
| 624 | helper.trans()->SetPriority(LOWEST); |
| 625 | EXPECT_TRUE(helper.StartDefaultTest()); |
| 626 | } else { |
| 627 | EXPECT_TRUE(helper.StartDefaultTest()); |
| 628 | helper.trans()->SetPriority(LOWEST); |
| 629 | } |
| 630 | |
| 631 | helper.FinishDefaultTest(); |
| 632 | helper.VerifyDataConsumed(); |
| 633 | |
| 634 | TransactionHelperResult out = helper.output(); |
| 635 | EXPECT_THAT(out.rv, IsOk()); |
| 636 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
| 637 | EXPECT_EQ("hello!", out.response_data); |
| 638 | } |
| 639 | } |
| 640 | |
Bence Béky | 7a4836c | 2018-05-08 03:52:48 | [diff] [blame] | 641 | // Test that changing the request priority of an existing stream triggers |
Bence Béky | 73b8529 | 2018-06-14 04:56:43 | [diff] [blame] | 642 | // sending PRIORITY frames in case there are multiple open streams and their |
Bence Béky | 7a4836c | 2018-05-08 03:52:48 | [diff] [blame] | 643 | // relative priorities change. |
Bence Béky | 73b8529 | 2018-06-14 04:56:43 | [diff] [blame] | 644 | TEST_F(SpdyNetworkTransactionTest, SetPriorityOnExistingStream) { |
Bence Béky | 7a4836c | 2018-05-08 03:52:48 | [diff] [blame] | 645 | const char* kUrl2 = "https://www.example.org/bar"; |
| 646 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 647 | spdy::SpdySerializedFrame req1( |
| 648 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, HIGHEST)); |
| 649 | spdy::SpdySerializedFrame req2(spdy_util_.ConstructSpdyGet(kUrl2, 3, MEDIUM)); |
| 650 | spdy::SpdySerializedFrame priority1( |
Bence Béky | 7a4836c | 2018-05-08 03:52:48 | [diff] [blame] | 651 | spdy_util_.ConstructSpdyPriority(3, 0, MEDIUM, true)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 652 | spdy::SpdySerializedFrame priority2( |
Bence Béky | 7a4836c | 2018-05-08 03:52:48 | [diff] [blame] | 653 | spdy_util_.ConstructSpdyPriority(1, 3, LOWEST, true)); |
| 654 | MockWrite writes[] = {CreateMockWrite(req1, 0), CreateMockWrite(req2, 2), |
| 655 | CreateMockWrite(priority1, 4), |
| 656 | CreateMockWrite(priority2, 5)}; |
| 657 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 658 | spdy::SpdySerializedFrame resp1( |
| 659 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 660 | spdy::SpdySerializedFrame resp2( |
| 661 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 3)); |
| 662 | spdy::SpdySerializedFrame body1(spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 663 | spdy::SpdySerializedFrame body2(spdy_util_.ConstructSpdyDataFrame(3, true)); |
Bence Béky | 7a4836c | 2018-05-08 03:52:48 | [diff] [blame] | 664 | MockRead reads[] = {CreateMockRead(resp1, 1), CreateMockRead(resp2, 3), |
| 665 | CreateMockRead(body1, 6), CreateMockRead(body2, 7), |
| 666 | MockRead(ASYNC, 0, 8)}; |
| 667 | |
| 668 | SequencedSocketData data(reads, writes); |
| 669 | NormalSpdyTransactionHelper helper(request_, HIGHEST, log_, nullptr); |
| 670 | helper.RunPreTestSetup(); |
| 671 | helper.AddData(&data); |
| 672 | EXPECT_TRUE(helper.StartDefaultTest()); |
| 673 | |
| 674 | // Open HTTP/2 connection and create first stream. |
| 675 | base::RunLoop().RunUntilIdle(); |
| 676 | |
| 677 | HttpNetworkTransaction trans2(MEDIUM, helper.session()); |
| 678 | HttpRequestInfo request2; |
| 679 | request2.url = GURL(kUrl2); |
| 680 | request2.method = "GET"; |
| 681 | request2.traffic_annotation = |
| 682 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
| 683 | TestCompletionCallback callback2; |
| 684 | int rv = trans2.Start(&request2, callback2.callback(), log_); |
| 685 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 686 | |
| 687 | // Create second stream. |
| 688 | base::RunLoop().RunUntilIdle(); |
| 689 | |
| 690 | // First request has HIGHEST priority, second request has MEDIUM priority. |
| 691 | // Changing the priority of the first request to LOWEST changes their order, |
| 692 | // and therefore triggers sending PRIORITY frames. |
| 693 | helper.trans()->SetPriority(LOWEST); |
| 694 | |
| 695 | helper.FinishDefaultTest(); |
| 696 | helper.VerifyDataConsumed(); |
| 697 | |
| 698 | TransactionHelperResult out = helper.output(); |
| 699 | EXPECT_THAT(out.rv, IsOk()); |
| 700 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
| 701 | EXPECT_EQ("hello!", out.response_data); |
| 702 | |
| 703 | rv = callback2.WaitForResult(); |
| 704 | ASSERT_THAT(rv, IsOk()); |
| 705 | const HttpResponseInfo* response2 = trans2.GetResponseInfo(); |
| 706 | ASSERT_TRUE(response2); |
| 707 | ASSERT_TRUE(response2->headers); |
| 708 | EXPECT_EQ(HttpResponseInfo::CONNECTION_INFO_HTTP2, |
| 709 | response2->connection_info); |
| 710 | EXPECT_EQ("HTTP/1.1 200", response2->headers->GetStatusLine()); |
| 711 | } |
| 712 | |
Bence Béky | 73b8529 | 2018-06-14 04:56:43 | [diff] [blame] | 713 | // Create two requests: a lower priority one first, then a higher priority one. |
| 714 | // Test that the second request gets sent out first. |
| 715 | TEST_F(SpdyNetworkTransactionTest, RequestsOrderedByPriority) { |
| 716 | const char* kUrl2 = "https://www.example.org/foo"; |
| 717 | |
| 718 | // First send second request on stream 1, then first request on stream 3. |
| 719 | spdy::SpdySerializedFrame req2( |
| 720 | spdy_util_.ConstructSpdyGet(kUrl2, 1, HIGHEST)); |
| 721 | spdy::SpdySerializedFrame req1( |
| 722 | spdy_util_.ConstructSpdyGet(nullptr, 0, 3, LOW)); |
| 723 | MockWrite writes[] = {CreateMockWrite(req2, 0), CreateMockWrite(req1, 1)}; |
| 724 | |
| 725 | spdy::SpdySerializedFrame resp2( |
| 726 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 727 | spdy::SpdySerializedFrame resp1( |
| 728 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 3)); |
| 729 | spdy::SpdySerializedFrame body2( |
| 730 | spdy_util_.ConstructSpdyDataFrame(1, "stream 1", true)); |
| 731 | spdy::SpdySerializedFrame body1( |
| 732 | spdy_util_.ConstructSpdyDataFrame(3, "stream 3", true)); |
| 733 | MockRead reads[] = {CreateMockRead(resp2, 2), CreateMockRead(body2, 3), |
| 734 | CreateMockRead(resp1, 4), CreateMockRead(body1, 5), |
| 735 | MockRead(ASYNC, 0, 6)}; |
| 736 | |
| 737 | SequencedSocketData data(reads, writes); |
| 738 | NormalSpdyTransactionHelper helper(request_, LOW, log_, nullptr); |
| 739 | helper.RunPreTestSetup(); |
| 740 | helper.AddData(&data); |
| 741 | |
| 742 | // Create HTTP/2 connection. This is necessary because starting the first |
| 743 | // transaction does not create the connection yet, so the second request |
| 744 | // could not use the same connection, whereas running the message loop after |
| 745 | // starting the first transaction would call Socket::Write() with the first |
| 746 | // HEADERS frame, so the second transaction could not get ahead of it. |
| 747 | SpdySessionKey key(HostPortPair("www.example.org", 443), |
Matt Menke | 2436b2f | 2018-12-11 18:07:11 | [diff] [blame] | 748 | ProxyServer::Direct(), PRIVACY_MODE_DISABLED, |
| 749 | SpdySessionKey::IsProxySession::kFalse, SocketTag()); |
Bence Béky | 73b8529 | 2018-06-14 04:56:43 | [diff] [blame] | 750 | auto spdy_session = CreateSpdySession(helper.session(), key, log_); |
| 751 | EXPECT_TRUE(spdy_session); |
| 752 | |
| 753 | // Start first transaction. |
| 754 | EXPECT_TRUE(helper.StartDefaultTest()); |
| 755 | |
| 756 | // Start second transaction. |
| 757 | HttpNetworkTransaction trans2(HIGHEST, helper.session()); |
| 758 | HttpRequestInfo request2; |
| 759 | request2.url = GURL(kUrl2); |
| 760 | request2.method = "GET"; |
| 761 | request2.traffic_annotation = |
| 762 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
| 763 | TestCompletionCallback callback2; |
| 764 | int rv = trans2.Start(&request2, callback2.callback(), log_); |
| 765 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 766 | |
| 767 | // Complete first transaction and verify results. |
| 768 | helper.FinishDefaultTest(); |
| 769 | helper.VerifyDataConsumed(); |
| 770 | |
| 771 | TransactionHelperResult out = helper.output(); |
| 772 | EXPECT_THAT(out.rv, IsOk()); |
| 773 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
| 774 | EXPECT_EQ("stream 3", out.response_data); |
| 775 | |
| 776 | // Complete second transaction and verify results. |
| 777 | rv = callback2.WaitForResult(); |
| 778 | ASSERT_THAT(rv, IsOk()); |
| 779 | const HttpResponseInfo* response2 = trans2.GetResponseInfo(); |
| 780 | ASSERT_TRUE(response2); |
| 781 | ASSERT_TRUE(response2->headers); |
| 782 | EXPECT_EQ(HttpResponseInfo::CONNECTION_INFO_HTTP2, |
| 783 | response2->connection_info); |
| 784 | EXPECT_EQ("HTTP/1.1 200", response2->headers->GetStatusLine()); |
| 785 | std::string response_data; |
| 786 | ReadTransaction(&trans2, &response_data); |
| 787 | EXPECT_EQ("stream 1", response_data); |
| 788 | } |
| 789 | |
| 790 | // Test that already enqueued HEADERS frames are reordered if their relative |
| 791 | // priority changes. |
| 792 | TEST_F(SpdyNetworkTransactionTest, QueuedFramesReorderedOnPriorityChange) { |
| 793 | const char* kUrl2 = "https://www.example.org/foo"; |
| 794 | const char* kUrl3 = "https://www.example.org/bar"; |
| 795 | |
| 796 | spdy::SpdySerializedFrame req1( |
| 797 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, DEFAULT_PRIORITY)); |
| 798 | spdy::SpdySerializedFrame req3(spdy_util_.ConstructSpdyGet(kUrl3, 3, MEDIUM)); |
| 799 | spdy::SpdySerializedFrame req2(spdy_util_.ConstructSpdyGet(kUrl2, 5, LOWEST)); |
| 800 | MockWrite writes[] = {MockWrite(ASYNC, ERR_IO_PENDING, 0), |
| 801 | CreateMockWrite(req1, 1), CreateMockWrite(req3, 2), |
| 802 | CreateMockWrite(req2, 3)}; |
| 803 | |
| 804 | spdy::SpdySerializedFrame resp1( |
| 805 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 806 | spdy::SpdySerializedFrame resp3( |
| 807 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 3)); |
| 808 | spdy::SpdySerializedFrame resp2( |
| 809 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 5)); |
| 810 | spdy::SpdySerializedFrame body1( |
| 811 | spdy_util_.ConstructSpdyDataFrame(1, "stream 1", true)); |
| 812 | spdy::SpdySerializedFrame body3( |
| 813 | spdy_util_.ConstructSpdyDataFrame(3, "stream 3", true)); |
| 814 | spdy::SpdySerializedFrame body2( |
| 815 | spdy_util_.ConstructSpdyDataFrame(5, "stream 5", true)); |
| 816 | MockRead reads[] = {CreateMockRead(resp1, 4), CreateMockRead(body1, 5), |
| 817 | CreateMockRead(resp3, 6), CreateMockRead(body3, 7), |
| 818 | CreateMockRead(resp2, 8), CreateMockRead(body2, 9), |
| 819 | MockRead(ASYNC, 0, 10)}; |
| 820 | |
| 821 | SequencedSocketData data(reads, writes); |
| 822 | // Priority of first request does not matter, because Socket::Write() will be |
| 823 | // called with its HEADERS frame before the other requests start. |
| 824 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
| 825 | helper.RunPreTestSetup(); |
| 826 | helper.AddData(&data); |
| 827 | EXPECT_TRUE(helper.StartDefaultTest()); |
| 828 | |
| 829 | // Open HTTP/2 connection, create HEADERS frame for first request, and call |
| 830 | // Socket::Write() with that frame. After this, no other request can get |
| 831 | // ahead of the first one. |
| 832 | base::RunLoop().RunUntilIdle(); |
| 833 | |
| 834 | HttpNetworkTransaction trans2(HIGHEST, helper.session()); |
| 835 | HttpRequestInfo request2; |
| 836 | request2.url = GURL(kUrl2); |
| 837 | request2.method = "GET"; |
| 838 | request2.traffic_annotation = |
| 839 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
| 840 | TestCompletionCallback callback2; |
| 841 | int rv = trans2.Start(&request2, callback2.callback(), log_); |
| 842 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 843 | |
| 844 | HttpNetworkTransaction trans3(MEDIUM, helper.session()); |
| 845 | HttpRequestInfo request3; |
| 846 | request3.url = GURL(kUrl3); |
| 847 | request3.method = "GET"; |
| 848 | request3.traffic_annotation = |
| 849 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
| 850 | TestCompletionCallback callback3; |
| 851 | rv = trans3.Start(&request3, callback3.callback(), log_); |
| 852 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 853 | |
| 854 | // Create HEADERS frames for second and third request and enqueue them in |
| 855 | // SpdyWriteQueue with their original priorities. Writing of the first |
| 856 | // HEADERS frame to the socked still has not completed. |
| 857 | base::RunLoop().RunUntilIdle(); |
| 858 | |
| 859 | // Second request is of HIGHEST, third of MEDIUM priority. Changing second |
| 860 | // request to LOWEST changes their relative order. This should result in |
| 861 | // already enqueued frames being reordered within SpdyWriteQueue. |
| 862 | trans2.SetPriority(LOWEST); |
| 863 | |
| 864 | // Complete async write of the first HEADERS frame. |
| 865 | data.Resume(); |
| 866 | |
| 867 | helper.FinishDefaultTest(); |
| 868 | TransactionHelperResult out = helper.output(); |
| 869 | EXPECT_THAT(out.rv, IsOk()); |
| 870 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
| 871 | EXPECT_EQ("stream 1", out.response_data); |
| 872 | |
| 873 | rv = callback2.WaitForResult(); |
| 874 | ASSERT_THAT(rv, IsOk()); |
| 875 | const HttpResponseInfo* response2 = trans2.GetResponseInfo(); |
| 876 | ASSERT_TRUE(response2); |
| 877 | ASSERT_TRUE(response2->headers); |
| 878 | EXPECT_EQ(HttpResponseInfo::CONNECTION_INFO_HTTP2, |
| 879 | response2->connection_info); |
| 880 | EXPECT_EQ("HTTP/1.1 200", response2->headers->GetStatusLine()); |
| 881 | std::string response_data; |
| 882 | ReadTransaction(&trans2, &response_data); |
| 883 | EXPECT_EQ("stream 5", response_data); |
| 884 | |
| 885 | rv = callback3.WaitForResult(); |
| 886 | ASSERT_THAT(rv, IsOk()); |
| 887 | const HttpResponseInfo* response3 = trans3.GetResponseInfo(); |
| 888 | ASSERT_TRUE(response3); |
| 889 | ASSERT_TRUE(response3->headers); |
| 890 | EXPECT_EQ(HttpResponseInfo::CONNECTION_INFO_HTTP2, |
| 891 | response3->connection_info); |
| 892 | EXPECT_EQ("HTTP/1.1 200", response3->headers->GetStatusLine()); |
| 893 | ReadTransaction(&trans3, &response_data); |
| 894 | EXPECT_EQ("stream 3", response_data); |
| 895 | |
| 896 | helper.VerifyDataConsumed(); |
| 897 | } |
| 898 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 899 | TEST_F(SpdyNetworkTransactionTest, GetAtEachPriority) { |
[email protected] | 3d08dd38 | 2013-10-19 00:13:11 | [diff] [blame] | 900 | for (RequestPriority p = MINIMUM_PRIORITY; p <= MAXIMUM_PRIORITY; |
[email protected] | 31ae7ab | 2012-04-24 21:09:05 | [diff] [blame] | 901 | p = RequestPriority(p + 1)) { |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 902 | SpdyTestUtil spdy_test_util; |
bnc | 38dcd39 | 2016-02-09 23:19:49 | [diff] [blame] | 903 | |
[email protected] | c9c6f5c | 2010-07-31 01:30:03 | [diff] [blame] | 904 | // Construct the request. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 905 | spdy::SpdySerializedFrame req( |
| 906 | spdy_test_util.ConstructSpdyGet(nullptr, 0, 1, p)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 907 | MockWrite writes[] = {CreateMockWrite(req, 0)}; |
[email protected] | c9c6f5c | 2010-07-31 01:30:03 | [diff] [blame] | 908 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 909 | spdy::SpdyPriority spdy_prio = 0; |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 910 | EXPECT_TRUE(GetSpdyPriority(req, &spdy_prio)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 911 | // this repeats the RequestPriority-->spdy::SpdyPriority mapping from |
| 912 | // spdy::SpdyFramer::ConvertRequestPriorityToSpdyPriority to make |
[email protected] | c9c6f5c | 2010-07-31 01:30:03 | [diff] [blame] | 913 | // sure it's being done right. |
bnc | 05808ff4 | 2016-01-08 23:48:25 | [diff] [blame] | 914 | switch (p) { |
| 915 | case HIGHEST: |
| 916 | EXPECT_EQ(0, spdy_prio); |
| 917 | break; |
| 918 | case MEDIUM: |
| 919 | EXPECT_EQ(1, spdy_prio); |
| 920 | break; |
| 921 | case LOW: |
| 922 | EXPECT_EQ(2, spdy_prio); |
| 923 | break; |
| 924 | case LOWEST: |
| 925 | EXPECT_EQ(3, spdy_prio); |
| 926 | break; |
| 927 | case IDLE: |
| 928 | EXPECT_EQ(4, spdy_prio); |
| 929 | break; |
rdsmith | 5eb6fbc | 2016-10-21 17:36:08 | [diff] [blame] | 930 | case THROTTLED: |
| 931 | EXPECT_EQ(5, spdy_prio); |
| 932 | break; |
bnc | 05808ff4 | 2016-01-08 23:48:25 | [diff] [blame] | 933 | default: |
| 934 | FAIL(); |
[email protected] | c9c6f5c | 2010-07-31 01:30:03 | [diff] [blame] | 935 | } |
| 936 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 937 | spdy::SpdySerializedFrame resp( |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 938 | spdy_test_util.ConstructSpdyGetReply(nullptr, 0, 1)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 939 | spdy::SpdySerializedFrame body( |
| 940 | spdy_test_util.ConstructSpdyDataFrame(1, true)); |
[email protected] | c9c6f5c | 2010-07-31 01:30:03 | [diff] [blame] | 941 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 942 | CreateMockRead(resp, 1), CreateMockRead(body, 2), |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 943 | MockRead(ASYNC, 0, 3) // EOF |
[email protected] | c9c6f5c | 2010-07-31 01:30:03 | [diff] [blame] | 944 | }; |
| 945 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 946 | SequencedSocketData data(reads, writes); |
[email protected] | c9c6f5c | 2010-07-31 01:30:03 | [diff] [blame] | 947 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 948 | NormalSpdyTransactionHelper helper(request_, p, log_, nullptr); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 949 | helper.RunToCompletion(&data); |
[email protected] | c9c6f5c | 2010-07-31 01:30:03 | [diff] [blame] | 950 | TransactionHelperResult out = helper.output(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 951 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 952 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | c9c6f5c | 2010-07-31 01:30:03 | [diff] [blame] | 953 | EXPECT_EQ("hello!", out.response_data); |
| 954 | } |
| 955 | } |
| 956 | |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 957 | // Start three gets simultaniously; making sure that multiplexed |
| 958 | // streams work properly. |
| 959 | |
| 960 | // This can't use the TransactionHelper method, since it only |
| 961 | // handles a single transaction, and finishes them as soon |
| 962 | // as it launches them. |
| 963 | |
| 964 | // TODO(gavinp): create a working generalized TransactionHelper that |
| 965 | // can allow multiple streams in flight. |
| 966 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 967 | TEST_F(SpdyNetworkTransactionTest, ThreeGets) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 968 | spdy::SpdySerializedFrame req( |
| 969 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 970 | spdy::SpdySerializedFrame resp( |
| 971 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 972 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, false)); |
| 973 | spdy::SpdySerializedFrame fbody(spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 974 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 975 | spdy::SpdySerializedFrame req2( |
| 976 | spdy_util_.ConstructSpdyGet(nullptr, 0, 3, LOWEST)); |
| 977 | spdy::SpdySerializedFrame resp2( |
| 978 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 3)); |
| 979 | spdy::SpdySerializedFrame body2(spdy_util_.ConstructSpdyDataFrame(3, false)); |
| 980 | spdy::SpdySerializedFrame fbody2(spdy_util_.ConstructSpdyDataFrame(3, true)); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 981 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 982 | spdy::SpdySerializedFrame req3( |
| 983 | spdy_util_.ConstructSpdyGet(nullptr, 0, 5, LOWEST)); |
| 984 | spdy::SpdySerializedFrame resp3( |
| 985 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 5)); |
| 986 | spdy::SpdySerializedFrame body3(spdy_util_.ConstructSpdyDataFrame(5, false)); |
| 987 | spdy::SpdySerializedFrame fbody3(spdy_util_.ConstructSpdyDataFrame(5, true)); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 988 | |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 989 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 990 | CreateMockWrite(req, 0), CreateMockWrite(req2, 3), |
| 991 | CreateMockWrite(req3, 6), |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 992 | }; |
| 993 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 994 | CreateMockRead(resp, 1), CreateMockRead(body, 2), |
| 995 | CreateMockRead(resp2, 4), CreateMockRead(body2, 5), |
| 996 | CreateMockRead(resp3, 7), CreateMockRead(body3, 8), |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 997 | |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 998 | CreateMockRead(fbody, 9), CreateMockRead(fbody2, 10), |
| 999 | CreateMockRead(fbody3, 11), |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1000 | |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 1001 | MockRead(ASYNC, 0, 12), // EOF |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1002 | }; |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 1003 | SequencedSocketData data(reads, writes); |
| 1004 | SequencedSocketData data_placeholder1; |
| 1005 | SequencedSocketData data_placeholder2; |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1006 | |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1007 | TransactionHelperResult out; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1008 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | bdebd1b | 2010-08-09 20:18:08 | [diff] [blame] | 1009 | helper.RunPreTestSetup(); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 1010 | helper.AddData(&data); |
rch | aeb3f05 | 2015-04-14 16:02:49 | [diff] [blame] | 1011 | // We require placeholder data because three get requests are sent out at |
| 1012 | // the same time which results in three sockets being connected. The first |
| 1013 | // on will negotiate SPDY and will be used for all requests. |
mmenke | cc2298e | 2015-12-07 18:20:18 | [diff] [blame] | 1014 | helper.AddData(&data_placeholder1); |
| 1015 | helper.AddData(&data_placeholder2); |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 1016 | TestCompletionCallback callback1; |
| 1017 | TestCompletionCallback callback2; |
| 1018 | TestCompletionCallback callback3; |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1019 | |
krasin | 0bfeb6b | 2017-01-13 21:48:04 | [diff] [blame] | 1020 | HttpNetworkTransaction trans1(DEFAULT_PRIORITY, helper.session()); |
| 1021 | HttpNetworkTransaction trans2(DEFAULT_PRIORITY, helper.session()); |
| 1022 | HttpNetworkTransaction trans3(DEFAULT_PRIORITY, helper.session()); |
| 1023 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1024 | out.rv = trans1.Start(&request_, callback1.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1025 | ASSERT_THAT(out.rv, IsError(ERR_IO_PENDING)); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1026 | out.rv = trans2.Start(&request_, callback2.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1027 | ASSERT_THAT(out.rv, IsError(ERR_IO_PENDING)); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1028 | out.rv = trans3.Start(&request_, callback3.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1029 | ASSERT_THAT(out.rv, IsError(ERR_IO_PENDING)); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1030 | |
[email protected] | bdebd1b | 2010-08-09 20:18:08 | [diff] [blame] | 1031 | out.rv = callback1.WaitForResult(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1032 | ASSERT_THAT(out.rv, IsOk()); |
[email protected] | bdebd1b | 2010-08-09 20:18:08 | [diff] [blame] | 1033 | out.rv = callback3.WaitForResult(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1034 | ASSERT_THAT(out.rv, IsOk()); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1035 | |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 1036 | const HttpResponseInfo* response1 = trans1.GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 1037 | EXPECT_TRUE(response1->headers); |
[email protected] | bdebd1b | 2010-08-09 20:18:08 | [diff] [blame] | 1038 | EXPECT_TRUE(response1->was_fetched_via_spdy); |
| 1039 | out.status_line = response1->headers->GetStatusLine(); |
| 1040 | out.response_info = *response1; |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1041 | |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 1042 | trans2.GetResponseInfo(); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1043 | |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 1044 | out.rv = ReadTransaction(&trans1, &out.response_data); |
[email protected] | bdebd1b | 2010-08-09 20:18:08 | [diff] [blame] | 1045 | helper.VerifyDataConsumed(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1046 | EXPECT_THAT(out.rv, IsOk()); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1047 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1048 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 1049 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1050 | EXPECT_EQ("hello!hello!", out.response_data); |
| 1051 | } |
| 1052 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 1053 | TEST_F(SpdyNetworkTransactionTest, TwoGetsLateBinding) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1054 | spdy::SpdySerializedFrame req( |
| 1055 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 1056 | spdy::SpdySerializedFrame resp( |
| 1057 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 1058 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, false)); |
| 1059 | spdy::SpdySerializedFrame fbody(spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1060 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1061 | spdy::SpdySerializedFrame req2( |
| 1062 | spdy_util_.ConstructSpdyGet(nullptr, 0, 3, LOWEST)); |
| 1063 | spdy::SpdySerializedFrame resp2( |
| 1064 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 3)); |
| 1065 | spdy::SpdySerializedFrame body2(spdy_util_.ConstructSpdyDataFrame(3, false)); |
| 1066 | spdy::SpdySerializedFrame fbody2(spdy_util_.ConstructSpdyDataFrame(3, true)); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1067 | |
| 1068 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1069 | CreateMockWrite(req, 0), CreateMockWrite(req2, 3), |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1070 | }; |
| 1071 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1072 | CreateMockRead(resp, 1), CreateMockRead(body, 2), |
| 1073 | CreateMockRead(resp2, 4), CreateMockRead(body2, 5), |
| 1074 | CreateMockRead(fbody, 6), CreateMockRead(fbody2, 7), |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 1075 | MockRead(ASYNC, 0, 8), // EOF |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1076 | }; |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 1077 | SequencedSocketData data(reads, writes); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1078 | |
[email protected] | d973e99a | 2012-02-17 21:02:36 | [diff] [blame] | 1079 | MockConnect never_finishing_connect(SYNCHRONOUS, ERR_IO_PENDING); |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 1080 | SequencedSocketData data_placeholder; |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 1081 | data_placeholder.set_connect_data(never_finishing_connect); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1082 | |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1083 | TransactionHelperResult out; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1084 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1085 | helper.RunPreTestSetup(); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 1086 | helper.AddData(&data); |
rch | aeb3f05 | 2015-04-14 16:02:49 | [diff] [blame] | 1087 | // We require placeholder data because two requests are sent out at |
| 1088 | // the same time which results in two sockets being connected. The first |
| 1089 | // on will negotiate SPDY and will be used for all requests. |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 1090 | helper.AddData(&data_placeholder); |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 1091 | HttpNetworkTransaction trans1(DEFAULT_PRIORITY, helper.session()); |
| 1092 | HttpNetworkTransaction trans2(DEFAULT_PRIORITY, helper.session()); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1093 | |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 1094 | TestCompletionCallback callback1; |
| 1095 | TestCompletionCallback callback2; |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1096 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1097 | out.rv = trans1.Start(&request_, callback1.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1098 | ASSERT_THAT(out.rv, IsError(ERR_IO_PENDING)); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1099 | out.rv = trans2.Start(&request_, callback2.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1100 | ASSERT_THAT(out.rv, IsError(ERR_IO_PENDING)); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1101 | |
| 1102 | out.rv = callback1.WaitForResult(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1103 | ASSERT_THAT(out.rv, IsOk()); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1104 | out.rv = callback2.WaitForResult(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1105 | ASSERT_THAT(out.rv, IsOk()); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1106 | |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 1107 | const HttpResponseInfo* response1 = trans1.GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 1108 | EXPECT_TRUE(response1->headers); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1109 | EXPECT_TRUE(response1->was_fetched_via_spdy); |
| 1110 | out.status_line = response1->headers->GetStatusLine(); |
| 1111 | out.response_info = *response1; |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 1112 | out.rv = ReadTransaction(&trans1, &out.response_data); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1113 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 1114 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1115 | EXPECT_EQ("hello!hello!", out.response_data); |
| 1116 | |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 1117 | const HttpResponseInfo* response2 = trans2.GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 1118 | EXPECT_TRUE(response2->headers); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1119 | EXPECT_TRUE(response2->was_fetched_via_spdy); |
| 1120 | out.status_line = response2->headers->GetStatusLine(); |
| 1121 | out.response_info = *response2; |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 1122 | out.rv = ReadTransaction(&trans2, &out.response_data); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1123 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 1124 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1125 | EXPECT_EQ("hello!hello!", out.response_data); |
| 1126 | |
| 1127 | helper.VerifyDataConsumed(); |
| 1128 | } |
| 1129 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 1130 | TEST_F(SpdyNetworkTransactionTest, TwoGetsLateBindingFromPreconnect) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1131 | spdy::SpdySerializedFrame req( |
| 1132 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 1133 | spdy::SpdySerializedFrame resp( |
| 1134 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 1135 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, false)); |
| 1136 | spdy::SpdySerializedFrame fbody(spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1137 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1138 | spdy::SpdySerializedFrame req2( |
| 1139 | spdy_util_.ConstructSpdyGet(nullptr, 0, 3, LOWEST)); |
| 1140 | spdy::SpdySerializedFrame resp2( |
| 1141 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 3)); |
| 1142 | spdy::SpdySerializedFrame body2(spdy_util_.ConstructSpdyDataFrame(3, false)); |
| 1143 | spdy::SpdySerializedFrame fbody2(spdy_util_.ConstructSpdyDataFrame(3, true)); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1144 | |
| 1145 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1146 | CreateMockWrite(req, 0), CreateMockWrite(req2, 3), |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1147 | }; |
| 1148 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1149 | CreateMockRead(resp, 1), CreateMockRead(body, 2), |
| 1150 | CreateMockRead(resp2, 4), CreateMockRead(body2, 5), |
| 1151 | CreateMockRead(fbody, 6), CreateMockRead(fbody2, 7), |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 1152 | MockRead(ASYNC, 0, 8), // EOF |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1153 | }; |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 1154 | SequencedSocketData preconnect_data(reads, writes); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1155 | |
[email protected] | d973e99a | 2012-02-17 21:02:36 | [diff] [blame] | 1156 | MockConnect never_finishing_connect(ASYNC, ERR_IO_PENDING); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1157 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 1158 | SequencedSocketData data_placeholder; |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 1159 | data_placeholder.set_connect_data(never_finishing_connect); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1160 | |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1161 | TransactionHelperResult out; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1162 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1163 | helper.RunPreTestSetup(); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 1164 | helper.AddData(&preconnect_data); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1165 | // We require placeholder data because 3 connections are attempted (first is |
| 1166 | // the preconnect, 2nd and 3rd are the never finished connections. |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 1167 | helper.AddData(&data_placeholder); |
| 1168 | helper.AddData(&data_placeholder); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1169 | |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 1170 | HttpNetworkTransaction trans1(DEFAULT_PRIORITY, helper.session()); |
| 1171 | HttpNetworkTransaction trans2(DEFAULT_PRIORITY, helper.session()); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1172 | |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 1173 | TestCompletionCallback callback1; |
| 1174 | TestCompletionCallback callback2; |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1175 | |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1176 | // Preconnect the first. |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1177 | HttpStreamFactory* http_stream_factory = |
| 1178 | helper.session()->http_stream_factory(); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1179 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1180 | http_stream_factory->PreconnectStreams(1, request_); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1181 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1182 | out.rv = trans1.Start(&request_, callback1.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1183 | ASSERT_THAT(out.rv, IsError(ERR_IO_PENDING)); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1184 | out.rv = trans2.Start(&request_, callback2.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1185 | ASSERT_THAT(out.rv, IsError(ERR_IO_PENDING)); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1186 | |
| 1187 | out.rv = callback1.WaitForResult(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1188 | ASSERT_THAT(out.rv, IsOk()); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1189 | out.rv = callback2.WaitForResult(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1190 | ASSERT_THAT(out.rv, IsOk()); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1191 | |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 1192 | const HttpResponseInfo* response1 = trans1.GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 1193 | EXPECT_TRUE(response1->headers); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1194 | EXPECT_TRUE(response1->was_fetched_via_spdy); |
| 1195 | out.status_line = response1->headers->GetStatusLine(); |
| 1196 | out.response_info = *response1; |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 1197 | out.rv = ReadTransaction(&trans1, &out.response_data); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1198 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 1199 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1200 | EXPECT_EQ("hello!hello!", out.response_data); |
| 1201 | |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 1202 | const HttpResponseInfo* response2 = trans2.GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 1203 | EXPECT_TRUE(response2->headers); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1204 | EXPECT_TRUE(response2->was_fetched_via_spdy); |
| 1205 | out.status_line = response2->headers->GetStatusLine(); |
| 1206 | out.response_info = *response2; |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 1207 | out.rv = ReadTransaction(&trans2, &out.response_data); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1208 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 1209 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1210 | EXPECT_EQ("hello!hello!", out.response_data); |
| 1211 | |
| 1212 | helper.VerifyDataConsumed(); |
| 1213 | } |
| 1214 | |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1215 | // Similar to ThreeGets above, however this test adds a SETTINGS |
| 1216 | // frame. The SETTINGS frame is read during the IO loop waiting on |
| 1217 | // the first transaction completion, and sets a maximum concurrent |
| 1218 | // stream limit of 1. This means that our IO loop exists after the |
| 1219 | // second transaction completes, so we can assert on read_index(). |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 1220 | TEST_F(SpdyNetworkTransactionTest, ThreeGetsWithMaxConcurrent) { |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1221 | // Construct the request. |
rdsmith | ebb50aa | 2015-11-12 03:44:38 | [diff] [blame] | 1222 | // Each request fully completes before the next starts. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1223 | spdy::SpdySerializedFrame req( |
| 1224 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 1225 | spdy::SpdySerializedFrame resp( |
| 1226 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 1227 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, false)); |
| 1228 | spdy::SpdySerializedFrame fbody(spdy_util_.ConstructSpdyDataFrame(1, true)); |
rdsmith | ebb50aa | 2015-11-12 03:44:38 | [diff] [blame] | 1229 | spdy_util_.UpdateWithStreamDestruction(1); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1230 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1231 | spdy::SpdySerializedFrame req2( |
| 1232 | spdy_util_.ConstructSpdyGet(nullptr, 0, 3, LOWEST)); |
| 1233 | spdy::SpdySerializedFrame resp2( |
| 1234 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 3)); |
| 1235 | spdy::SpdySerializedFrame body2(spdy_util_.ConstructSpdyDataFrame(3, false)); |
| 1236 | spdy::SpdySerializedFrame fbody2(spdy_util_.ConstructSpdyDataFrame(3, true)); |
rdsmith | ebb50aa | 2015-11-12 03:44:38 | [diff] [blame] | 1237 | spdy_util_.UpdateWithStreamDestruction(3); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1238 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1239 | spdy::SpdySerializedFrame req3( |
| 1240 | spdy_util_.ConstructSpdyGet(nullptr, 0, 5, LOWEST)); |
| 1241 | spdy::SpdySerializedFrame resp3( |
| 1242 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 5)); |
| 1243 | spdy::SpdySerializedFrame body3(spdy_util_.ConstructSpdyDataFrame(5, false)); |
| 1244 | spdy::SpdySerializedFrame fbody3(spdy_util_.ConstructSpdyDataFrame(5, true)); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1245 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1246 | spdy::SettingsMap settings; |
Avi Drissman | 13fc893 | 2015-12-20 04:40:46 | [diff] [blame] | 1247 | const uint32_t max_concurrent_streams = 1; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1248 | settings[spdy::SETTINGS_MAX_CONCURRENT_STREAMS] = max_concurrent_streams; |
| 1249 | spdy::SpdySerializedFrame settings_frame( |
[email protected] | c10b2085 | 2013-05-15 21:29:20 | [diff] [blame] | 1250 | spdy_util_.ConstructSpdySettings(settings)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1251 | spdy::SpdySerializedFrame settings_ack(spdy_util_.ConstructSpdySettingsAck()); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1252 | |
[email protected] | 2d672869 | 2011-03-12 01:39:55 | [diff] [blame] | 1253 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1254 | CreateMockWrite(req, 0), CreateMockWrite(settings_ack, 5), |
| 1255 | CreateMockWrite(req2, 6), CreateMockWrite(req3, 10), |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1256 | }; |
[email protected] | 2d672869 | 2011-03-12 01:39:55 | [diff] [blame] | 1257 | |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1258 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1259 | CreateMockRead(settings_frame, 1), |
| 1260 | CreateMockRead(resp, 2), |
| 1261 | CreateMockRead(body, 3), |
| 1262 | CreateMockRead(fbody, 4), |
| 1263 | CreateMockRead(resp2, 7), |
| 1264 | CreateMockRead(body2, 8), |
| 1265 | CreateMockRead(fbody2, 9), |
| 1266 | CreateMockRead(resp3, 11), |
| 1267 | CreateMockRead(body3, 12), |
| 1268 | CreateMockRead(fbody3, 13), |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1269 | |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 1270 | MockRead(ASYNC, 0, 14), // EOF |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1271 | }; |
| 1272 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 1273 | SequencedSocketData data(reads, writes); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1274 | |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1275 | TransactionHelperResult out; |
| 1276 | { |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1277 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
| 1278 | nullptr); |
[email protected] | 2d672869 | 2011-03-12 01:39:55 | [diff] [blame] | 1279 | helper.RunPreTestSetup(); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 1280 | helper.AddData(&data); |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 1281 | HttpNetworkTransaction trans1(DEFAULT_PRIORITY, helper.session()); |
| 1282 | HttpNetworkTransaction trans2(DEFAULT_PRIORITY, helper.session()); |
| 1283 | HttpNetworkTransaction trans3(DEFAULT_PRIORITY, helper.session()); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1284 | |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 1285 | TestCompletionCallback callback1; |
| 1286 | TestCompletionCallback callback2; |
| 1287 | TestCompletionCallback callback3; |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1288 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1289 | out.rv = trans1.Start(&request_, callback1.callback(), log_); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1290 | ASSERT_EQ(out.rv, ERR_IO_PENDING); |
[email protected] | 513963e | 2013-06-15 01:53:04 | [diff] [blame] | 1291 | // Run transaction 1 through quickly to force a read of our SETTINGS |
| 1292 | // frame. |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1293 | out.rv = callback1.WaitForResult(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1294 | ASSERT_THAT(out.rv, IsOk()); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1295 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1296 | out.rv = trans2.Start(&request_, callback2.callback(), log_); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1297 | ASSERT_EQ(out.rv, ERR_IO_PENDING); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1298 | out.rv = trans3.Start(&request_, callback3.callback(), log_); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1299 | ASSERT_EQ(out.rv, ERR_IO_PENDING); |
| 1300 | out.rv = callback2.WaitForResult(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1301 | ASSERT_THAT(out.rv, IsOk()); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1302 | |
| 1303 | out.rv = callback3.WaitForResult(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1304 | ASSERT_THAT(out.rv, IsOk()); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1305 | |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 1306 | const HttpResponseInfo* response1 = trans1.GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 1307 | ASSERT_TRUE(response1); |
| 1308 | EXPECT_TRUE(response1->headers); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1309 | EXPECT_TRUE(response1->was_fetched_via_spdy); |
| 1310 | out.status_line = response1->headers->GetStatusLine(); |
| 1311 | out.response_info = *response1; |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 1312 | out.rv = ReadTransaction(&trans1, &out.response_data); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1313 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 1314 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1315 | EXPECT_EQ("hello!hello!", out.response_data); |
| 1316 | |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 1317 | const HttpResponseInfo* response2 = trans2.GetResponseInfo(); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1318 | out.status_line = response2->headers->GetStatusLine(); |
| 1319 | out.response_info = *response2; |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 1320 | out.rv = ReadTransaction(&trans2, &out.response_data); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1321 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 1322 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1323 | EXPECT_EQ("hello!hello!", out.response_data); |
| 1324 | |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 1325 | const HttpResponseInfo* response3 = trans3.GetResponseInfo(); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1326 | out.status_line = response3->headers->GetStatusLine(); |
| 1327 | out.response_info = *response3; |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 1328 | out.rv = ReadTransaction(&trans3, &out.response_data); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1329 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 1330 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1331 | EXPECT_EQ("hello!hello!", out.response_data); |
[email protected] | 044dcc5 | 2010-09-17 15:44:26 | [diff] [blame] | 1332 | |
| 1333 | helper.VerifyDataConsumed(); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1334 | } |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1335 | EXPECT_THAT(out.rv, IsOk()); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1336 | } |
| 1337 | |
| 1338 | // Similar to ThreeGetsWithMaxConcurrent above, however this test adds |
| 1339 | // a fourth transaction. The third and fourth transactions have |
| 1340 | // different data ("hello!" vs "hello!hello!") and because of the |
| 1341 | // user specified priority, we expect to see them inverted in |
| 1342 | // the response from the server. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 1343 | TEST_F(SpdyNetworkTransactionTest, FourGetsWithMaxConcurrentPriority) { |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1344 | // Construct the request. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1345 | spdy::SpdySerializedFrame req( |
| 1346 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 1347 | spdy::SpdySerializedFrame resp( |
| 1348 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 1349 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, false)); |
| 1350 | spdy::SpdySerializedFrame fbody(spdy_util_.ConstructSpdyDataFrame(1, true)); |
rdsmith | ebb50aa | 2015-11-12 03:44:38 | [diff] [blame] | 1351 | spdy_util_.UpdateWithStreamDestruction(1); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1352 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1353 | spdy::SpdySerializedFrame req2( |
| 1354 | spdy_util_.ConstructSpdyGet(nullptr, 0, 3, LOWEST)); |
| 1355 | spdy::SpdySerializedFrame resp2( |
| 1356 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 3)); |
| 1357 | spdy::SpdySerializedFrame body2(spdy_util_.ConstructSpdyDataFrame(3, false)); |
| 1358 | spdy::SpdySerializedFrame fbody2(spdy_util_.ConstructSpdyDataFrame(3, true)); |
rdsmith | ebb50aa | 2015-11-12 03:44:38 | [diff] [blame] | 1359 | spdy_util_.UpdateWithStreamDestruction(3); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1360 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1361 | spdy::SpdySerializedFrame req4( |
| 1362 | spdy_util_.ConstructSpdyGet(nullptr, 0, 5, HIGHEST)); |
| 1363 | spdy::SpdySerializedFrame resp4( |
| 1364 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 5)); |
| 1365 | spdy::SpdySerializedFrame fbody4(spdy_util_.ConstructSpdyDataFrame(5, true)); |
rdsmith | ebb50aa | 2015-11-12 03:44:38 | [diff] [blame] | 1366 | spdy_util_.UpdateWithStreamDestruction(5); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1367 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1368 | spdy::SpdySerializedFrame req3( |
| 1369 | spdy_util_.ConstructSpdyGet(nullptr, 0, 7, LOWEST)); |
| 1370 | spdy::SpdySerializedFrame resp3( |
| 1371 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 7)); |
| 1372 | spdy::SpdySerializedFrame body3(spdy_util_.ConstructSpdyDataFrame(7, false)); |
| 1373 | spdy::SpdySerializedFrame fbody3(spdy_util_.ConstructSpdyDataFrame(7, true)); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1374 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1375 | spdy::SettingsMap settings; |
Avi Drissman | 13fc893 | 2015-12-20 04:40:46 | [diff] [blame] | 1376 | const uint32_t max_concurrent_streams = 1; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1377 | settings[spdy::SETTINGS_MAX_CONCURRENT_STREAMS] = max_concurrent_streams; |
| 1378 | spdy::SpdySerializedFrame settings_frame( |
[email protected] | c10b2085 | 2013-05-15 21:29:20 | [diff] [blame] | 1379 | spdy_util_.ConstructSpdySettings(settings)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1380 | spdy::SpdySerializedFrame settings_ack(spdy_util_.ConstructSpdySettingsAck()); |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 1381 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1382 | CreateMockWrite(req, 0), CreateMockWrite(settings_ack, 5), |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 1383 | // By making these synchronous, it guarantees that they are not *started* |
| 1384 | // before their sequence number, which in turn verifies that only a single |
| 1385 | // request is in-flight at a time. |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1386 | CreateMockWrite(req2, 6, SYNCHRONOUS), |
| 1387 | CreateMockWrite(req4, 10, SYNCHRONOUS), |
| 1388 | CreateMockWrite(req3, 13, SYNCHRONOUS), |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1389 | }; |
| 1390 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1391 | CreateMockRead(settings_frame, 1), |
| 1392 | CreateMockRead(resp, 2), |
| 1393 | CreateMockRead(body, 3), |
| 1394 | CreateMockRead(fbody, 4), |
| 1395 | CreateMockRead(resp2, 7), |
| 1396 | CreateMockRead(body2, 8), |
| 1397 | CreateMockRead(fbody2, 9), |
| 1398 | CreateMockRead(resp4, 11), |
| 1399 | CreateMockRead(fbody4, 12), |
| 1400 | CreateMockRead(resp3, 14), |
| 1401 | CreateMockRead(body3, 15), |
| 1402 | CreateMockRead(fbody3, 16), |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1403 | |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 1404 | MockRead(ASYNC, 0, 17), // EOF |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1405 | }; |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 1406 | SequencedSocketData data(reads, writes); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1407 | TransactionHelperResult out; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1408 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | bdebd1b | 2010-08-09 20:18:08 | [diff] [blame] | 1409 | helper.RunPreTestSetup(); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 1410 | helper.AddData(&data); |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 1411 | |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 1412 | HttpNetworkTransaction trans1(DEFAULT_PRIORITY, helper.session()); |
| 1413 | HttpNetworkTransaction trans2(DEFAULT_PRIORITY, helper.session()); |
| 1414 | HttpNetworkTransaction trans3(DEFAULT_PRIORITY, helper.session()); |
| 1415 | HttpNetworkTransaction trans4(HIGHEST, helper.session()); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1416 | |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 1417 | TestCompletionCallback callback1; |
| 1418 | TestCompletionCallback callback2; |
| 1419 | TestCompletionCallback callback3; |
| 1420 | TestCompletionCallback callback4; |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1421 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1422 | out.rv = trans1.Start(&request_, callback1.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1423 | ASSERT_THAT(out.rv, IsError(ERR_IO_PENDING)); |
[email protected] | e0935cc | 2012-03-24 14:12:48 | [diff] [blame] | 1424 | // Run transaction 1 through quickly to force a read of our SETTINGS frame. |
[email protected] | bdebd1b | 2010-08-09 20:18:08 | [diff] [blame] | 1425 | out.rv = callback1.WaitForResult(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1426 | ASSERT_THAT(out.rv, IsOk()); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1427 | |
bnc | eb9aa711 | 2017-01-05 01:03:46 | [diff] [blame] | 1428 | // Finish async network reads and writes associated with |trans1|. |
| 1429 | base::RunLoop().RunUntilIdle(); |
| 1430 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1431 | out.rv = trans2.Start(&request_, callback2.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1432 | ASSERT_THAT(out.rv, IsError(ERR_IO_PENDING)); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1433 | out.rv = trans3.Start(&request_, callback3.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1434 | ASSERT_THAT(out.rv, IsError(ERR_IO_PENDING)); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1435 | out.rv = trans4.Start(&request_, callback4.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1436 | ASSERT_THAT(out.rv, IsError(ERR_IO_PENDING)); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1437 | |
[email protected] | bdebd1b | 2010-08-09 20:18:08 | [diff] [blame] | 1438 | out.rv = callback2.WaitForResult(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1439 | ASSERT_THAT(out.rv, IsOk()); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1440 | |
[email protected] | bdebd1b | 2010-08-09 20:18:08 | [diff] [blame] | 1441 | out.rv = callback3.WaitForResult(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1442 | ASSERT_THAT(out.rv, IsOk()); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1443 | |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 1444 | const HttpResponseInfo* response1 = trans1.GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 1445 | EXPECT_TRUE(response1->headers); |
[email protected] | bdebd1b | 2010-08-09 20:18:08 | [diff] [blame] | 1446 | EXPECT_TRUE(response1->was_fetched_via_spdy); |
| 1447 | out.status_line = response1->headers->GetStatusLine(); |
| 1448 | out.response_info = *response1; |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 1449 | out.rv = ReadTransaction(&trans1, &out.response_data); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1450 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 1451 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | bdebd1b | 2010-08-09 20:18:08 | [diff] [blame] | 1452 | EXPECT_EQ("hello!hello!", out.response_data); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1453 | |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 1454 | const HttpResponseInfo* response2 = trans2.GetResponseInfo(); |
[email protected] | bdebd1b | 2010-08-09 20:18:08 | [diff] [blame] | 1455 | out.status_line = response2->headers->GetStatusLine(); |
| 1456 | out.response_info = *response2; |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 1457 | out.rv = ReadTransaction(&trans2, &out.response_data); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1458 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 1459 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | bdebd1b | 2010-08-09 20:18:08 | [diff] [blame] | 1460 | EXPECT_EQ("hello!hello!", out.response_data); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1461 | |
[email protected] | bdebd1b | 2010-08-09 20:18:08 | [diff] [blame] | 1462 | // notice: response3 gets two hellos, response4 gets one |
| 1463 | // hello, so we know dequeuing priority was respected. |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 1464 | const HttpResponseInfo* response3 = trans3.GetResponseInfo(); |
[email protected] | bdebd1b | 2010-08-09 20:18:08 | [diff] [blame] | 1465 | out.status_line = response3->headers->GetStatusLine(); |
| 1466 | out.response_info = *response3; |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 1467 | out.rv = ReadTransaction(&trans3, &out.response_data); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1468 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 1469 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | bdebd1b | 2010-08-09 20:18:08 | [diff] [blame] | 1470 | EXPECT_EQ("hello!hello!", out.response_data); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1471 | |
[email protected] | bdebd1b | 2010-08-09 20:18:08 | [diff] [blame] | 1472 | out.rv = callback4.WaitForResult(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1473 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 1474 | const HttpResponseInfo* response4 = trans4.GetResponseInfo(); |
[email protected] | bdebd1b | 2010-08-09 20:18:08 | [diff] [blame] | 1475 | out.status_line = response4->headers->GetStatusLine(); |
| 1476 | out.response_info = *response4; |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 1477 | out.rv = ReadTransaction(&trans4, &out.response_data); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1478 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 1479 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | bdebd1b | 2010-08-09 20:18:08 | [diff] [blame] | 1480 | EXPECT_EQ("hello!", out.response_data); |
| 1481 | helper.VerifyDataConsumed(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1482 | EXPECT_THAT(out.rv, IsOk()); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1483 | } |
| 1484 | |
| 1485 | // Similar to ThreeGetsMaxConcurrrent above, however, this test |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 1486 | // deletes a session in the middle of the transaction to ensure |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1487 | // that we properly remove pendingcreatestream objects from |
| 1488 | // the spdy_session |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 1489 | TEST_F(SpdyNetworkTransactionTest, ThreeGetsWithMaxConcurrentDelete) { |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1490 | // Construct the request. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1491 | spdy::SpdySerializedFrame req( |
| 1492 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 1493 | spdy::SpdySerializedFrame resp( |
| 1494 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 1495 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, false)); |
| 1496 | spdy::SpdySerializedFrame fbody(spdy_util_.ConstructSpdyDataFrame(1, true)); |
rdsmith | ebb50aa | 2015-11-12 03:44:38 | [diff] [blame] | 1497 | spdy_util_.UpdateWithStreamDestruction(1); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1498 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1499 | spdy::SpdySerializedFrame req2( |
| 1500 | spdy_util_.ConstructSpdyGet(nullptr, 0, 3, LOWEST)); |
| 1501 | spdy::SpdySerializedFrame resp2( |
| 1502 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 3)); |
| 1503 | spdy::SpdySerializedFrame body2(spdy_util_.ConstructSpdyDataFrame(3, false)); |
| 1504 | spdy::SpdySerializedFrame fbody2(spdy_util_.ConstructSpdyDataFrame(3, true)); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1505 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1506 | spdy::SettingsMap settings; |
Avi Drissman | 13fc893 | 2015-12-20 04:40:46 | [diff] [blame] | 1507 | const uint32_t max_concurrent_streams = 1; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1508 | settings[spdy::SETTINGS_MAX_CONCURRENT_STREAMS] = max_concurrent_streams; |
| 1509 | spdy::SpdySerializedFrame settings_frame( |
[email protected] | c10b2085 | 2013-05-15 21:29:20 | [diff] [blame] | 1510 | spdy_util_.ConstructSpdySettings(settings)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1511 | spdy::SpdySerializedFrame settings_ack(spdy_util_.ConstructSpdySettingsAck()); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1512 | |
[email protected] | d4a77c1 | 2014-05-15 20:45:21 | [diff] [blame] | 1513 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1514 | CreateMockWrite(req, 0), CreateMockWrite(settings_ack, 5), |
| 1515 | CreateMockWrite(req2, 6), |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1516 | }; |
| 1517 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1518 | CreateMockRead(settings_frame, 1), CreateMockRead(resp, 2), |
| 1519 | CreateMockRead(body, 3), CreateMockRead(fbody, 4), |
| 1520 | CreateMockRead(resp2, 7), CreateMockRead(body2, 8), |
| 1521 | CreateMockRead(fbody2, 9), MockRead(ASYNC, 0, 10), // EOF |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1522 | }; |
| 1523 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 1524 | SequencedSocketData data(reads, writes); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1525 | |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1526 | TransactionHelperResult out; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1527 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | bdebd1b | 2010-08-09 20:18:08 | [diff] [blame] | 1528 | helper.RunPreTestSetup(); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 1529 | helper.AddData(&data); |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 1530 | auto trans1 = std::make_unique<HttpNetworkTransaction>(DEFAULT_PRIORITY, |
bnc | 3f6a855 | 2017-05-17 13:40:34 | [diff] [blame] | 1531 | helper.session()); |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 1532 | auto trans2 = std::make_unique<HttpNetworkTransaction>(DEFAULT_PRIORITY, |
bnc | 3f6a855 | 2017-05-17 13:40:34 | [diff] [blame] | 1533 | helper.session()); |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 1534 | auto trans3 = std::make_unique<HttpNetworkTransaction>(DEFAULT_PRIORITY, |
bnc | 3f6a855 | 2017-05-17 13:40:34 | [diff] [blame] | 1535 | helper.session()); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1536 | |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 1537 | TestCompletionCallback callback1; |
| 1538 | TestCompletionCallback callback2; |
| 1539 | TestCompletionCallback callback3; |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1540 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1541 | out.rv = trans1->Start(&request_, callback1.callback(), log_); |
[email protected] | bdebd1b | 2010-08-09 20:18:08 | [diff] [blame] | 1542 | ASSERT_EQ(out.rv, ERR_IO_PENDING); |
[email protected] | e0935cc | 2012-03-24 14:12:48 | [diff] [blame] | 1543 | // Run transaction 1 through quickly to force a read of our SETTINGS frame. |
[email protected] | bdebd1b | 2010-08-09 20:18:08 | [diff] [blame] | 1544 | out.rv = callback1.WaitForResult(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1545 | ASSERT_THAT(out.rv, IsOk()); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1546 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1547 | out.rv = trans2->Start(&request_, callback2.callback(), log_); |
[email protected] | bdebd1b | 2010-08-09 20:18:08 | [diff] [blame] | 1548 | ASSERT_EQ(out.rv, ERR_IO_PENDING); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1549 | out.rv = trans3->Start(&request_, callback3.callback(), log_); |
olli.raula | 7ca9cd1d | 2016-01-04 06:50:37 | [diff] [blame] | 1550 | trans3.reset(); |
[email protected] | bdebd1b | 2010-08-09 20:18:08 | [diff] [blame] | 1551 | ASSERT_EQ(out.rv, ERR_IO_PENDING); |
| 1552 | out.rv = callback2.WaitForResult(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1553 | ASSERT_THAT(out.rv, IsOk()); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1554 | |
[email protected] | bdebd1b | 2010-08-09 20:18:08 | [diff] [blame] | 1555 | const HttpResponseInfo* response1 = trans1->GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 1556 | ASSERT_TRUE(response1); |
| 1557 | EXPECT_TRUE(response1->headers); |
[email protected] | bdebd1b | 2010-08-09 20:18:08 | [diff] [blame] | 1558 | EXPECT_TRUE(response1->was_fetched_via_spdy); |
| 1559 | out.status_line = response1->headers->GetStatusLine(); |
| 1560 | out.response_info = *response1; |
| 1561 | out.rv = ReadTransaction(trans1.get(), &out.response_data); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1562 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 1563 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | bdebd1b | 2010-08-09 20:18:08 | [diff] [blame] | 1564 | EXPECT_EQ("hello!hello!", out.response_data); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1565 | |
[email protected] | bdebd1b | 2010-08-09 20:18:08 | [diff] [blame] | 1566 | const HttpResponseInfo* response2 = trans2->GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 1567 | ASSERT_TRUE(response2); |
[email protected] | bdebd1b | 2010-08-09 20:18:08 | [diff] [blame] | 1568 | out.status_line = response2->headers->GetStatusLine(); |
| 1569 | out.response_info = *response2; |
| 1570 | out.rv = ReadTransaction(trans2.get(), &out.response_data); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1571 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 1572 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | bdebd1b | 2010-08-09 20:18:08 | [diff] [blame] | 1573 | EXPECT_EQ("hello!hello!", out.response_data); |
| 1574 | helper.VerifyDataConsumed(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1575 | EXPECT_THAT(out.rv, IsOk()); |
[email protected] | 044dcc5 | 2010-09-17 15:44:26 | [diff] [blame] | 1576 | } |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1577 | |
[email protected] | 448d4ca5 | 2012-03-04 04:12:23 | [diff] [blame] | 1578 | namespace { |
| 1579 | |
Bence Béky | 8ddc249 | 2018-06-13 01:02:04 | [diff] [blame] | 1580 | // A helper class that will delete |transaction| on error when the callback is |
| 1581 | // invoked. |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 1582 | class KillerCallback : public TestCompletionCallbackBase { |
[email protected] | 044dcc5 | 2010-09-17 15:44:26 | [diff] [blame] | 1583 | public: |
| 1584 | explicit KillerCallback(HttpNetworkTransaction* transaction) |
Bence Béky | 8ddc249 | 2018-06-13 01:02:04 | [diff] [blame] | 1585 | : transaction_(transaction) {} |
[email protected] | 044dcc5 | 2010-09-17 15:44:26 | [diff] [blame] | 1586 | |
Chris Watkins | 61914cb | 2017-12-01 19:59:00 | [diff] [blame] | 1587 | ~KillerCallback() override = default; |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 1588 | |
Bence Béky | 8ddc249 | 2018-06-13 01:02:04 | [diff] [blame] | 1589 | CompletionOnceCallback callback() { |
| 1590 | return base::BindOnce(&KillerCallback::OnComplete, base::Unretained(this)); |
| 1591 | } |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 1592 | |
[email protected] | 044dcc5 | 2010-09-17 15:44:26 | [diff] [blame] | 1593 | private: |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 1594 | void OnComplete(int result) { |
| 1595 | if (result < 0) |
| 1596 | delete transaction_; |
| 1597 | |
| 1598 | SetResult(result); |
| 1599 | } |
| 1600 | |
[email protected] | 044dcc5 | 2010-09-17 15:44:26 | [diff] [blame] | 1601 | HttpNetworkTransaction* transaction_; |
| 1602 | }; |
| 1603 | |
[email protected] | 448d4ca5 | 2012-03-04 04:12:23 | [diff] [blame] | 1604 | } // namespace |
| 1605 | |
[email protected] | 044dcc5 | 2010-09-17 15:44:26 | [diff] [blame] | 1606 | // Similar to ThreeGetsMaxConcurrrentDelete above, however, this test |
| 1607 | // closes the socket while we have a pending transaction waiting for |
| 1608 | // a pending stream creation. http://crbug.com/52901 |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 1609 | TEST_F(SpdyNetworkTransactionTest, ThreeGetsWithMaxConcurrentSocketClose) { |
[email protected] | 044dcc5 | 2010-09-17 15:44:26 | [diff] [blame] | 1610 | // Construct the request. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1611 | spdy::SpdySerializedFrame req( |
| 1612 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 1613 | spdy::SpdySerializedFrame resp( |
| 1614 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 1615 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, false)); |
| 1616 | spdy::SpdySerializedFrame fin_body( |
| 1617 | spdy_util_.ConstructSpdyDataFrame(1, true)); |
rdsmith | ebb50aa | 2015-11-12 03:44:38 | [diff] [blame] | 1618 | spdy_util_.UpdateWithStreamDestruction(1); |
[email protected] | 044dcc5 | 2010-09-17 15:44:26 | [diff] [blame] | 1619 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1620 | spdy::SpdySerializedFrame req2( |
| 1621 | spdy_util_.ConstructSpdyGet(nullptr, 0, 3, LOWEST)); |
| 1622 | spdy::SpdySerializedFrame resp2( |
| 1623 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 3)); |
[email protected] | 044dcc5 | 2010-09-17 15:44:26 | [diff] [blame] | 1624 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1625 | spdy::SettingsMap settings; |
Avi Drissman | 13fc893 | 2015-12-20 04:40:46 | [diff] [blame] | 1626 | const uint32_t max_concurrent_streams = 1; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1627 | settings[spdy::SETTINGS_MAX_CONCURRENT_STREAMS] = max_concurrent_streams; |
| 1628 | spdy::SpdySerializedFrame settings_frame( |
[email protected] | c10b2085 | 2013-05-15 21:29:20 | [diff] [blame] | 1629 | spdy_util_.ConstructSpdySettings(settings)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1630 | spdy::SpdySerializedFrame settings_ack(spdy_util_.ConstructSpdySettingsAck()); |
[email protected] | 044dcc5 | 2010-09-17 15:44:26 | [diff] [blame] | 1631 | |
[email protected] | d4a77c1 | 2014-05-15 20:45:21 | [diff] [blame] | 1632 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1633 | CreateMockWrite(req, 0), CreateMockWrite(settings_ack, 5), |
| 1634 | CreateMockWrite(req2, 6), |
[email protected] | 044dcc5 | 2010-09-17 15:44:26 | [diff] [blame] | 1635 | }; |
| 1636 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1637 | CreateMockRead(settings_frame, 1), |
| 1638 | CreateMockRead(resp, 2), |
| 1639 | CreateMockRead(body, 3), |
| 1640 | CreateMockRead(fin_body, 4), |
| 1641 | CreateMockRead(resp2, 7), |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 1642 | MockRead(ASYNC, ERR_CONNECTION_RESET, 8), // Abort! |
[email protected] | 044dcc5 | 2010-09-17 15:44:26 | [diff] [blame] | 1643 | }; |
| 1644 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 1645 | SequencedSocketData data(reads, writes); |
| 1646 | SequencedSocketData data_placeholder; |
[email protected] | 044dcc5 | 2010-09-17 15:44:26 | [diff] [blame] | 1647 | |
[email protected] | 044dcc5 | 2010-09-17 15:44:26 | [diff] [blame] | 1648 | TransactionHelperResult out; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1649 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | 044dcc5 | 2010-09-17 15:44:26 | [diff] [blame] | 1650 | helper.RunPreTestSetup(); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 1651 | helper.AddData(&data); |
[email protected] | 044dcc5 | 2010-09-17 15:44:26 | [diff] [blame] | 1652 | // We require placeholder data because three get requests are sent out, so |
| 1653 | // there needs to be three sets of SSL connection data. |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 1654 | helper.AddData(&data_placeholder); |
| 1655 | helper.AddData(&data_placeholder); |
mmenke | e65e7af | 2015-10-13 17:16:42 | [diff] [blame] | 1656 | HttpNetworkTransaction trans1(DEFAULT_PRIORITY, helper.session()); |
| 1657 | HttpNetworkTransaction trans2(DEFAULT_PRIORITY, helper.session()); |
[email protected] | 262eec8 | 2013-03-19 21:01:36 | [diff] [blame] | 1658 | HttpNetworkTransaction* trans3( |
mmenke | e65e7af | 2015-10-13 17:16:42 | [diff] [blame] | 1659 | new HttpNetworkTransaction(DEFAULT_PRIORITY, helper.session())); |
[email protected] | 044dcc5 | 2010-09-17 15:44:26 | [diff] [blame] | 1660 | |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 1661 | TestCompletionCallback callback1; |
| 1662 | TestCompletionCallback callback2; |
[email protected] | 044dcc5 | 2010-09-17 15:44:26 | [diff] [blame] | 1663 | KillerCallback callback3(trans3); |
| 1664 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1665 | out.rv = trans1.Start(&request_, callback1.callback(), log_); |
[email protected] | 044dcc5 | 2010-09-17 15:44:26 | [diff] [blame] | 1666 | ASSERT_EQ(out.rv, ERR_IO_PENDING); |
[email protected] | e0935cc | 2012-03-24 14:12:48 | [diff] [blame] | 1667 | // Run transaction 1 through quickly to force a read of our SETTINGS frame. |
[email protected] | 044dcc5 | 2010-09-17 15:44:26 | [diff] [blame] | 1668 | out.rv = callback1.WaitForResult(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1669 | ASSERT_THAT(out.rv, IsOk()); |
[email protected] | 044dcc5 | 2010-09-17 15:44:26 | [diff] [blame] | 1670 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1671 | out.rv = trans2.Start(&request_, callback2.callback(), log_); |
[email protected] | 044dcc5 | 2010-09-17 15:44:26 | [diff] [blame] | 1672 | ASSERT_EQ(out.rv, ERR_IO_PENDING); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1673 | out.rv = trans3->Start(&request_, callback3.callback(), log_); |
[email protected] | 044dcc5 | 2010-09-17 15:44:26 | [diff] [blame] | 1674 | ASSERT_EQ(out.rv, ERR_IO_PENDING); |
| 1675 | out.rv = callback3.WaitForResult(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1676 | ASSERT_THAT(out.rv, IsError(ERR_ABORTED)); |
[email protected] | 044dcc5 | 2010-09-17 15:44:26 | [diff] [blame] | 1677 | |
[email protected] | 044dcc5 | 2010-09-17 15:44:26 | [diff] [blame] | 1678 | const HttpResponseInfo* response1 = trans1.GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 1679 | ASSERT_TRUE(response1); |
| 1680 | EXPECT_TRUE(response1->headers); |
[email protected] | 044dcc5 | 2010-09-17 15:44:26 | [diff] [blame] | 1681 | EXPECT_TRUE(response1->was_fetched_via_spdy); |
| 1682 | out.status_line = response1->headers->GetStatusLine(); |
| 1683 | out.response_info = *response1; |
| 1684 | out.rv = ReadTransaction(&trans1, &out.response_data); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1685 | EXPECT_THAT(out.rv, IsOk()); |
[email protected] | 044dcc5 | 2010-09-17 15:44:26 | [diff] [blame] | 1686 | |
| 1687 | const HttpResponseInfo* response2 = trans2.GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 1688 | ASSERT_TRUE(response2); |
[email protected] | 044dcc5 | 2010-09-17 15:44:26 | [diff] [blame] | 1689 | out.status_line = response2->headers->GetStatusLine(); |
| 1690 | out.response_info = *response2; |
| 1691 | out.rv = ReadTransaction(&trans2, &out.response_data); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1692 | EXPECT_THAT(out.rv, IsError(ERR_CONNECTION_RESET)); |
[email protected] | 044dcc5 | 2010-09-17 15:44:26 | [diff] [blame] | 1693 | |
| 1694 | helper.VerifyDataConsumed(); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1695 | } |
| 1696 | |
[email protected] | d8ef27b | 2010-08-06 17:34:39 | [diff] [blame] | 1697 | // Test that a simple PUT request works. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 1698 | TEST_F(SpdyNetworkTransactionTest, Put) { |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1699 | // Setup the request. |
| 1700 | request_.method = "PUT"; |
[email protected] | d8ef27b | 2010-08-06 17:34:39 | [diff] [blame] | 1701 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1702 | spdy::SpdyHeaderBlock put_headers( |
bnc | b2602438 | 2016-06-29 02:39:45 | [diff] [blame] | 1703 | spdy_util_.ConstructPutHeaderBlock(kDefaultUrl, 0)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1704 | spdy::SpdySerializedFrame req( |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 1705 | spdy_util_.ConstructSpdyHeaders(1, std::move(put_headers), LOWEST, true)); |
[email protected] | d8ef27b | 2010-08-06 17:34:39 | [diff] [blame] | 1706 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1707 | CreateMockWrite(req, 0), |
[email protected] | d8ef27b | 2010-08-06 17:34:39 | [diff] [blame] | 1708 | }; |
| 1709 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1710 | spdy::SpdySerializedFrame resp( |
| 1711 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 1712 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | d8ef27b | 2010-08-06 17:34:39 | [diff] [blame] | 1713 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1714 | CreateMockRead(resp, 1), CreateMockRead(body, 2), |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 1715 | MockRead(ASYNC, 0, 3) // EOF |
[email protected] | d8ef27b | 2010-08-06 17:34:39 | [diff] [blame] | 1716 | }; |
| 1717 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 1718 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1719 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 1720 | helper.RunToCompletion(&data); |
[email protected] | d8ef27b | 2010-08-06 17:34:39 | [diff] [blame] | 1721 | TransactionHelperResult out = helper.output(); |
| 1722 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1723 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 1724 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | d8ef27b | 2010-08-06 17:34:39 | [diff] [blame] | 1725 | } |
| 1726 | |
| 1727 | // Test that a simple HEAD request works. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 1728 | TEST_F(SpdyNetworkTransactionTest, Head) { |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1729 | // Setup the request. |
| 1730 | request_.method = "HEAD"; |
[email protected] | d8ef27b | 2010-08-06 17:34:39 | [diff] [blame] | 1731 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1732 | spdy::SpdyHeaderBlock head_headers( |
bnc | b2602438 | 2016-06-29 02:39:45 | [diff] [blame] | 1733 | spdy_util_.ConstructHeadHeaderBlock(kDefaultUrl, 0)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1734 | spdy::SpdySerializedFrame req(spdy_util_.ConstructSpdyHeaders( |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 1735 | 1, std::move(head_headers), LOWEST, true)); |
[email protected] | d8ef27b | 2010-08-06 17:34:39 | [diff] [blame] | 1736 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1737 | CreateMockWrite(req, 0), |
[email protected] | d8ef27b | 2010-08-06 17:34:39 | [diff] [blame] | 1738 | }; |
| 1739 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1740 | spdy::SpdySerializedFrame resp( |
| 1741 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 1742 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | d8ef27b | 2010-08-06 17:34:39 | [diff] [blame] | 1743 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1744 | CreateMockRead(resp, 1), CreateMockRead(body, 2), |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 1745 | MockRead(ASYNC, 0, 3) // EOF |
[email protected] | d8ef27b | 2010-08-06 17:34:39 | [diff] [blame] | 1746 | }; |
| 1747 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 1748 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1749 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 1750 | helper.RunToCompletion(&data); |
[email protected] | d8ef27b | 2010-08-06 17:34:39 | [diff] [blame] | 1751 | TransactionHelperResult out = helper.output(); |
| 1752 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1753 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 1754 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | d8ef27b | 2010-08-06 17:34:39 | [diff] [blame] | 1755 | } |
| 1756 | |
[email protected] | 72552f0 | 2009-10-28 15:25:01 | [diff] [blame] | 1757 | // Test that a simple POST works. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 1758 | TEST_F(SpdyNetworkTransactionTest, Post) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1759 | spdy::SpdySerializedFrame req(spdy_util_.ConstructSpdyPost( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 1760 | kDefaultUrl, 1, kUploadDataSize, LOWEST, nullptr, 0)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1761 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | ff57bb8 | 2009-11-12 06:52:14 | [diff] [blame] | 1762 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1763 | CreateMockWrite(req, 0), CreateMockWrite(body, 1), // POST upload frame |
[email protected] | ff57bb8 | 2009-11-12 06:52:14 | [diff] [blame] | 1764 | }; |
[email protected] | 72552f0 | 2009-10-28 15:25:01 | [diff] [blame] | 1765 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1766 | spdy::SpdySerializedFrame resp(spdy_util_.ConstructSpdyPostReply(nullptr, 0)); |
[email protected] | ff57bb8 | 2009-11-12 06:52:14 | [diff] [blame] | 1767 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1768 | CreateMockRead(resp, 2), CreateMockRead(body, 3), |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 1769 | MockRead(ASYNC, 0, 4) // EOF |
[email protected] | aea8060 | 2009-09-18 00:55:08 | [diff] [blame] | 1770 | }; |
| 1771 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 1772 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1773 | UsePostRequest(); |
| 1774 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 1775 | helper.RunToCompletion(&data); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 1776 | TransactionHelperResult out = helper.output(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1777 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 1778 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | aea8060 | 2009-09-18 00:55:08 | [diff] [blame] | 1779 | EXPECT_EQ("hello!", out.response_data); |
| 1780 | } |
| 1781 | |
[email protected] | 69e6b4a | 2012-10-18 08:03:01 | [diff] [blame] | 1782 | // Test that a POST with a file works. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 1783 | TEST_F(SpdyNetworkTransactionTest, FilePost) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1784 | spdy::SpdySerializedFrame req(spdy_util_.ConstructSpdyPost( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 1785 | kDefaultUrl, 1, kUploadDataSize, LOWEST, nullptr, 0)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1786 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | 69e6b4a | 2012-10-18 08:03:01 | [diff] [blame] | 1787 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1788 | CreateMockWrite(req, 0), CreateMockWrite(body, 1), // POST upload frame |
[email protected] | 69e6b4a | 2012-10-18 08:03:01 | [diff] [blame] | 1789 | }; |
| 1790 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1791 | spdy::SpdySerializedFrame resp(spdy_util_.ConstructSpdyPostReply(nullptr, 0)); |
[email protected] | 69e6b4a | 2012-10-18 08:03:01 | [diff] [blame] | 1792 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1793 | CreateMockRead(resp, 2), CreateMockRead(body, 3), |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 1794 | MockRead(ASYNC, 0, 4) // EOF |
[email protected] | 69e6b4a | 2012-10-18 08:03:01 | [diff] [blame] | 1795 | }; |
| 1796 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 1797 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1798 | UseFilePostRequest(); |
| 1799 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | 69e6b4a | 2012-10-18 08:03:01 | [diff] [blame] | 1800 | helper.RunToCompletion(&data); |
| 1801 | TransactionHelperResult out = helper.output(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1802 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 1803 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | 69e6b4a | 2012-10-18 08:03:01 | [diff] [blame] | 1804 | EXPECT_EQ("hello!", out.response_data); |
| 1805 | } |
| 1806 | |
[email protected] | 999dd8c | 2013-11-12 06:45:54 | [diff] [blame] | 1807 | // Test that a POST with a unreadable file fails. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 1808 | TEST_F(SpdyNetworkTransactionTest, UnreadableFilePost) { |
[email protected] | 999dd8c | 2013-11-12 06:45:54 | [diff] [blame] | 1809 | MockWrite writes[] = { |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 1810 | MockWrite(ASYNC, 0, 0) // EOF |
[email protected] | 999dd8c | 2013-11-12 06:45:54 | [diff] [blame] | 1811 | }; |
| 1812 | MockRead reads[] = { |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 1813 | MockRead(ASYNC, 0, 1) // EOF |
[email protected] | 999dd8c | 2013-11-12 06:45:54 | [diff] [blame] | 1814 | }; |
| 1815 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 1816 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1817 | UseUnreadableFilePostRequest(); |
| 1818 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | 999dd8c | 2013-11-12 06:45:54 | [diff] [blame] | 1819 | helper.RunPreTestSetup(); |
| 1820 | helper.AddData(&data); |
| 1821 | helper.RunDefaultTest(); |
| 1822 | |
| 1823 | base::RunLoop().RunUntilIdle(); |
| 1824 | helper.VerifyDataNotConsumed(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1825 | EXPECT_THAT(helper.output().rv, IsError(ERR_ACCESS_DENIED)); |
[email protected] | 999dd8c | 2013-11-12 06:45:54 | [diff] [blame] | 1826 | } |
| 1827 | |
[email protected] | 69e6b4a | 2012-10-18 08:03:01 | [diff] [blame] | 1828 | // Test that a complex POST works. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 1829 | TEST_F(SpdyNetworkTransactionTest, ComplexPost) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1830 | spdy::SpdySerializedFrame req(spdy_util_.ConstructSpdyPost( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 1831 | kDefaultUrl, 1, kUploadDataSize, LOWEST, nullptr, 0)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1832 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | 69e6b4a | 2012-10-18 08:03:01 | [diff] [blame] | 1833 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1834 | CreateMockWrite(req, 0), CreateMockWrite(body, 1), // POST upload frame |
[email protected] | 69e6b4a | 2012-10-18 08:03:01 | [diff] [blame] | 1835 | }; |
| 1836 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1837 | spdy::SpdySerializedFrame resp(spdy_util_.ConstructSpdyPostReply(nullptr, 0)); |
[email protected] | 69e6b4a | 2012-10-18 08:03:01 | [diff] [blame] | 1838 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1839 | CreateMockRead(resp, 2), CreateMockRead(body, 3), |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 1840 | MockRead(ASYNC, 0, 4) // EOF |
[email protected] | 69e6b4a | 2012-10-18 08:03:01 | [diff] [blame] | 1841 | }; |
| 1842 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 1843 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1844 | UseComplexPostRequest(); |
| 1845 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | 69e6b4a | 2012-10-18 08:03:01 | [diff] [blame] | 1846 | helper.RunToCompletion(&data); |
| 1847 | TransactionHelperResult out = helper.output(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1848 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 1849 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | 69e6b4a | 2012-10-18 08:03:01 | [diff] [blame] | 1850 | EXPECT_EQ("hello!", out.response_data); |
| 1851 | } |
| 1852 | |
[email protected] | 0c9bf87 | 2011-03-04 17:53:22 | [diff] [blame] | 1853 | // Test that a chunked POST works. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 1854 | TEST_F(SpdyNetworkTransactionTest, ChunkedPost) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1855 | spdy::SpdySerializedFrame req( |
| 1856 | spdy_util_.ConstructChunkedSpdyPost(nullptr, 0)); |
| 1857 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | 0c9bf87 | 2011-03-04 17:53:22 | [diff] [blame] | 1858 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1859 | CreateMockWrite(req, 0), CreateMockWrite(body, 1), |
[email protected] | 0c9bf87 | 2011-03-04 17:53:22 | [diff] [blame] | 1860 | }; |
| 1861 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1862 | spdy::SpdySerializedFrame resp(spdy_util_.ConstructSpdyPostReply(nullptr, 0)); |
[email protected] | 0c9bf87 | 2011-03-04 17:53:22 | [diff] [blame] | 1863 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1864 | CreateMockRead(resp, 2), CreateMockRead(body, 3), |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 1865 | MockRead(ASYNC, 0, 4) // EOF |
[email protected] | 0c9bf87 | 2011-03-04 17:53:22 | [diff] [blame] | 1866 | }; |
| 1867 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 1868 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1869 | UseChunkedPostRequest(); |
| 1870 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | 34b345f9 | 2013-02-22 03:27:26 | [diff] [blame] | 1871 | |
| 1872 | // These chunks get merged into a single frame when being sent. |
| 1873 | const int kFirstChunkSize = kUploadDataSize/2; |
mmenke | cbc2b71 | 2014-10-09 20:29:07 | [diff] [blame] | 1874 | upload_chunked_data_stream()->AppendData(kUploadData, kFirstChunkSize, false); |
| 1875 | upload_chunked_data_stream()->AppendData( |
[email protected] | 34b345f9 | 2013-02-22 03:27:26 | [diff] [blame] | 1876 | kUploadData + kFirstChunkSize, kUploadDataSize - kFirstChunkSize, true); |
| 1877 | |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 1878 | helper.RunToCompletion(&data); |
[email protected] | 0c9bf87 | 2011-03-04 17:53:22 | [diff] [blame] | 1879 | TransactionHelperResult out = helper.output(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1880 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 1881 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | 34b345f9 | 2013-02-22 03:27:26 | [diff] [blame] | 1882 | EXPECT_EQ(kUploadData, out.response_data); |
| 1883 | } |
| 1884 | |
| 1885 | // Test that a chunked POST works with chunks appended after transaction starts. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 1886 | TEST_F(SpdyNetworkTransactionTest, DelayedChunkedPost) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1887 | spdy::SpdySerializedFrame req( |
| 1888 | spdy_util_.ConstructChunkedSpdyPost(nullptr, 0)); |
| 1889 | spdy::SpdySerializedFrame chunk1(spdy_util_.ConstructSpdyDataFrame(1, false)); |
| 1890 | spdy::SpdySerializedFrame chunk2(spdy_util_.ConstructSpdyDataFrame(1, false)); |
| 1891 | spdy::SpdySerializedFrame chunk3(spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | 34b345f9 | 2013-02-22 03:27:26 | [diff] [blame] | 1892 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1893 | CreateMockWrite(req, 0), CreateMockWrite(chunk1, 1), |
| 1894 | CreateMockWrite(chunk2, 2), CreateMockWrite(chunk3, 3), |
[email protected] | 34b345f9 | 2013-02-22 03:27:26 | [diff] [blame] | 1895 | }; |
| 1896 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1897 | spdy::SpdySerializedFrame resp(spdy_util_.ConstructSpdyPostReply(nullptr, 0)); |
[email protected] | 34b345f9 | 2013-02-22 03:27:26 | [diff] [blame] | 1898 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1899 | CreateMockRead(resp, 4), CreateMockRead(chunk1, 5), |
| 1900 | CreateMockRead(chunk2, 6), CreateMockRead(chunk3, 7), |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 1901 | MockRead(ASYNC, 0, 8) // EOF |
[email protected] | 34b345f9 | 2013-02-22 03:27:26 | [diff] [blame] | 1902 | }; |
| 1903 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 1904 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1905 | UseChunkedPostRequest(); |
| 1906 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | 34b345f9 | 2013-02-22 03:27:26 | [diff] [blame] | 1907 | |
mmenke | cbc2b71 | 2014-10-09 20:29:07 | [diff] [blame] | 1908 | upload_chunked_data_stream()->AppendData(kUploadData, kUploadDataSize, false); |
[email protected] | 34b345f9 | 2013-02-22 03:27:26 | [diff] [blame] | 1909 | |
| 1910 | helper.RunPreTestSetup(); |
| 1911 | helper.AddData(&data); |
| 1912 | ASSERT_TRUE(helper.StartDefaultTest()); |
| 1913 | |
[email protected] | fc9d8847 | 2013-08-14 02:31:17 | [diff] [blame] | 1914 | base::RunLoop().RunUntilIdle(); |
mmenke | cbc2b71 | 2014-10-09 20:29:07 | [diff] [blame] | 1915 | upload_chunked_data_stream()->AppendData(kUploadData, kUploadDataSize, false); |
[email protected] | fc9d8847 | 2013-08-14 02:31:17 | [diff] [blame] | 1916 | base::RunLoop().RunUntilIdle(); |
mmenke | cbc2b71 | 2014-10-09 20:29:07 | [diff] [blame] | 1917 | upload_chunked_data_stream()->AppendData(kUploadData, kUploadDataSize, true); |
[email protected] | 34b345f9 | 2013-02-22 03:27:26 | [diff] [blame] | 1918 | |
| 1919 | helper.FinishDefaultTest(); |
| 1920 | helper.VerifyDataConsumed(); |
| 1921 | |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 1922 | std::string expected_response; |
[email protected] | 34b345f9 | 2013-02-22 03:27:26 | [diff] [blame] | 1923 | expected_response += kUploadData; |
| 1924 | expected_response += kUploadData; |
| 1925 | expected_response += kUploadData; |
| 1926 | |
| 1927 | TransactionHelperResult out = helper.output(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1928 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 1929 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | 34b345f9 | 2013-02-22 03:27:26 | [diff] [blame] | 1930 | EXPECT_EQ(expected_response, out.response_data); |
[email protected] | 0c9bf87 | 2011-03-04 17:53:22 | [diff] [blame] | 1931 | } |
| 1932 | |
[email protected] | a33cad2b6 | 2010-07-30 22:24:39 | [diff] [blame] | 1933 | // Test that a POST without any post data works. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 1934 | TEST_F(SpdyNetworkTransactionTest, NullPost) { |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1935 | // Setup the request. |
| 1936 | request_.method = "POST"; |
[email protected] | a33cad2b6 | 2010-07-30 22:24:39 | [diff] [blame] | 1937 | // Create an empty UploadData. |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1938 | request_.upload_data_stream = nullptr; |
[email protected] | a33cad2b6 | 2010-07-30 22:24:39 | [diff] [blame] | 1939 | |
[email protected] | 329b68b | 2012-11-14 17:54:27 | [diff] [blame] | 1940 | // When request.upload_data_stream is NULL for post, content-length is |
[email protected] | a33cad2b6 | 2010-07-30 22:24:39 | [diff] [blame] | 1941 | // expected to be 0. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1942 | spdy::SpdyHeaderBlock req_block( |
bnc | b2602438 | 2016-06-29 02:39:45 | [diff] [blame] | 1943 | spdy_util_.ConstructPostHeaderBlock(kDefaultUrl, 0)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1944 | spdy::SpdySerializedFrame req( |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 1945 | spdy_util_.ConstructSpdyHeaders(1, std::move(req_block), LOWEST, true)); |
[email protected] | d2c1a97b | 2014-03-03 19:25:09 | [diff] [blame] | 1946 | |
[email protected] | a33cad2b6 | 2010-07-30 22:24:39 | [diff] [blame] | 1947 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1948 | CreateMockWrite(req, 0), |
[email protected] | a33cad2b6 | 2010-07-30 22:24:39 | [diff] [blame] | 1949 | }; |
| 1950 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1951 | spdy::SpdySerializedFrame resp(spdy_util_.ConstructSpdyPostReply(nullptr, 0)); |
| 1952 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | a33cad2b6 | 2010-07-30 22:24:39 | [diff] [blame] | 1953 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1954 | CreateMockRead(resp, 1), CreateMockRead(body, 2), |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 1955 | MockRead(ASYNC, 0, 3) // EOF |
[email protected] | a33cad2b6 | 2010-07-30 22:24:39 | [diff] [blame] | 1956 | }; |
| 1957 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 1958 | SequencedSocketData data(reads, writes); |
[email protected] | a33cad2b6 | 2010-07-30 22:24:39 | [diff] [blame] | 1959 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1960 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 1961 | helper.RunToCompletion(&data); |
[email protected] | a33cad2b6 | 2010-07-30 22:24:39 | [diff] [blame] | 1962 | TransactionHelperResult out = helper.output(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1963 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 1964 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | a33cad2b6 | 2010-07-30 22:24:39 | [diff] [blame] | 1965 | EXPECT_EQ("hello!", out.response_data); |
| 1966 | } |
| 1967 | |
[email protected] | edd3b0a5 | 2009-11-24 18:56:36 | [diff] [blame] | 1968 | // Test that a simple POST works. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 1969 | TEST_F(SpdyNetworkTransactionTest, EmptyPost) { |
[email protected] | 329b68b | 2012-11-14 17:54:27 | [diff] [blame] | 1970 | // Create an empty UploadDataStream. |
danakj | aee3e1ec | 2016-04-16 00:23:18 | [diff] [blame] | 1971 | std::vector<std::unique_ptr<UploadElementReader>> element_readers; |
olli.raula | 6df48b2a | 2015-11-26 07:40:22 | [diff] [blame] | 1972 | ElementsUploadDataStream stream(std::move(element_readers), 0); |
[email protected] | 329b68b | 2012-11-14 17:54:27 | [diff] [blame] | 1973 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1974 | // Setup the request. |
| 1975 | request_.method = "POST"; |
| 1976 | request_.upload_data_stream = &stream; |
[email protected] | edd3b0a5 | 2009-11-24 18:56:36 | [diff] [blame] | 1977 | |
Avi Drissman | 13fc893 | 2015-12-20 04:40:46 | [diff] [blame] | 1978 | const uint64_t kContentLength = 0; |
[email protected] | d2c1a97b | 2014-03-03 19:25:09 | [diff] [blame] | 1979 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1980 | spdy::SpdyHeaderBlock req_block( |
bnc | b2602438 | 2016-06-29 02:39:45 | [diff] [blame] | 1981 | spdy_util_.ConstructPostHeaderBlock(kDefaultUrl, kContentLength)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1982 | spdy::SpdySerializedFrame req( |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 1983 | spdy_util_.ConstructSpdyHeaders(1, std::move(req_block), LOWEST, true)); |
[email protected] | d2c1a97b | 2014-03-03 19:25:09 | [diff] [blame] | 1984 | |
[email protected] | edd3b0a5 | 2009-11-24 18:56:36 | [diff] [blame] | 1985 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1986 | CreateMockWrite(req, 0), |
[email protected] | edd3b0a5 | 2009-11-24 18:56:36 | [diff] [blame] | 1987 | }; |
| 1988 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1989 | spdy::SpdySerializedFrame resp(spdy_util_.ConstructSpdyPostReply(nullptr, 0)); |
| 1990 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | edd3b0a5 | 2009-11-24 18:56:36 | [diff] [blame] | 1991 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1992 | CreateMockRead(resp, 1), CreateMockRead(body, 2), |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 1993 | MockRead(ASYNC, 0, 3) // EOF |
[email protected] | edd3b0a5 | 2009-11-24 18:56:36 | [diff] [blame] | 1994 | }; |
| 1995 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 1996 | SequencedSocketData data(reads, writes); |
[email protected] | bf2491a9 | 2009-11-29 16:39:48 | [diff] [blame] | 1997 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1998 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 1999 | helper.RunToCompletion(&data); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 2000 | TransactionHelperResult out = helper.output(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2001 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 2002 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | edd3b0a5 | 2009-11-24 18:56:36 | [diff] [blame] | 2003 | EXPECT_EQ("hello!", out.response_data); |
| 2004 | } |
| 2005 | |
[email protected] | 35c3fc73 | 2014-02-15 00:16:07 | [diff] [blame] | 2006 | // While we're doing a post, the server sends the reply before upload completes. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 2007 | TEST_F(SpdyNetworkTransactionTest, ResponseBeforePostCompletes) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2008 | spdy::SpdySerializedFrame req( |
| 2009 | spdy_util_.ConstructChunkedSpdyPost(nullptr, 0)); |
| 2010 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | 35c3fc73 | 2014-02-15 00:16:07 | [diff] [blame] | 2011 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 2012 | CreateMockWrite(req, 0), CreateMockWrite(body, 3), |
[email protected] | 35c3fc73 | 2014-02-15 00:16:07 | [diff] [blame] | 2013 | }; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2014 | spdy::SpdySerializedFrame resp(spdy_util_.ConstructSpdyPostReply(nullptr, 0)); |
[email protected] | a5566f970 | 2010-05-05 22:25:43 | [diff] [blame] | 2015 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 2016 | CreateMockRead(resp, 1), CreateMockRead(body, 2), |
| 2017 | MockRead(ASYNC, 0, 4) // EOF |
[email protected] | a5566f970 | 2010-05-05 22:25:43 | [diff] [blame] | 2018 | }; |
| 2019 | |
[email protected] | 35c3fc73 | 2014-02-15 00:16:07 | [diff] [blame] | 2020 | // Write the request headers, and read the complete response |
| 2021 | // while still waiting for chunked request data. |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 2022 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 2023 | UseChunkedPostRequest(); |
| 2024 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | c92f4b454 | 2012-07-26 23:53:21 | [diff] [blame] | 2025 | helper.RunPreTestSetup(); |
mmenke | 666a6fea | 2015-12-19 04:16:33 | [diff] [blame] | 2026 | helper.AddData(&data); |
[email protected] | c92f4b454 | 2012-07-26 23:53:21 | [diff] [blame] | 2027 | |
[email protected] | 35c3fc73 | 2014-02-15 00:16:07 | [diff] [blame] | 2028 | ASSERT_TRUE(helper.StartDefaultTest()); |
[email protected] | c92f4b454 | 2012-07-26 23:53:21 | [diff] [blame] | 2029 | |
maksim.sisov | 8d2df66d | 2016-06-20 07:07:11 | [diff] [blame] | 2030 | base::RunLoop().RunUntilIdle(); |
mmenke | 666a6fea | 2015-12-19 04:16:33 | [diff] [blame] | 2031 | |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 2032 | // Process the request headers, response headers, and response body. |
[email protected] | 35c3fc73 | 2014-02-15 00:16:07 | [diff] [blame] | 2033 | // The request body is still in flight. |
[email protected] | 35c3fc73 | 2014-02-15 00:16:07 | [diff] [blame] | 2034 | const HttpResponseInfo* response = helper.trans()->GetResponseInfo(); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 2035 | EXPECT_EQ("HTTP/1.1 200", response->headers->GetStatusLine()); |
[email protected] | 35c3fc73 | 2014-02-15 00:16:07 | [diff] [blame] | 2036 | |
| 2037 | // Finish sending the request body. |
mmenke | cbc2b71 | 2014-10-09 20:29:07 | [diff] [blame] | 2038 | upload_chunked_data_stream()->AppendData(kUploadData, kUploadDataSize, true); |
maksim.sisov | 8d2df66d | 2016-06-20 07:07:11 | [diff] [blame] | 2039 | helper.WaitForCallbackToComplete(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2040 | EXPECT_THAT(helper.output().rv, IsOk()); |
[email protected] | 35c3fc73 | 2014-02-15 00:16:07 | [diff] [blame] | 2041 | |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 2042 | std::string response_body; |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2043 | EXPECT_THAT(ReadTransaction(helper.trans(), &response_body), IsOk()); |
[email protected] | 35c3fc73 | 2014-02-15 00:16:07 | [diff] [blame] | 2044 | EXPECT_EQ(kUploadData, response_body); |
bnc | eb9aa711 | 2017-01-05 01:03:46 | [diff] [blame] | 2045 | |
| 2046 | // Finish async network reads/writes. |
| 2047 | base::RunLoop().RunUntilIdle(); |
[email protected] | 35c3fc73 | 2014-02-15 00:16:07 | [diff] [blame] | 2048 | helper.VerifyDataConsumed(); |
[email protected] | a5566f970 | 2010-05-05 22:25:43 | [diff] [blame] | 2049 | } |
| 2050 | |
[email protected] | f9a26d7 | 2010-08-03 18:07:13 | [diff] [blame] | 2051 | // The client upon cancellation tries to send a RST_STREAM frame. The mock |
| 2052 | // socket causes the TCP write to return zero. This test checks that the client |
| 2053 | // tries to queue up the RST_STREAM frame again. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 2054 | TEST_F(SpdyNetworkTransactionTest, SocketWriteReturnsZero) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2055 | spdy::SpdySerializedFrame req( |
| 2056 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 2057 | spdy::SpdySerializedFrame rst( |
| 2058 | spdy_util_.ConstructSpdyRstStream(1, spdy::ERROR_CODE_CANCEL)); |
[email protected] | f9a26d7 | 2010-08-03 18:07:13 | [diff] [blame] | 2059 | MockWrite writes[] = { |
Raul Tambre | 94493c65 | 2019-03-11 17:18:35 | [diff] [blame] | 2060 | CreateMockWrite(req, 0, SYNCHRONOUS), |
| 2061 | MockWrite(SYNCHRONOUS, nullptr, 0, 2), |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 2062 | CreateMockWrite(rst, 3, SYNCHRONOUS), |
[email protected] | f9a26d7 | 2010-08-03 18:07:13 | [diff] [blame] | 2063 | }; |
| 2064 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2065 | spdy::SpdySerializedFrame resp( |
| 2066 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
[email protected] | f9a26d7 | 2010-08-03 18:07:13 | [diff] [blame] | 2067 | MockRead reads[] = { |
Raul Tambre | 94493c65 | 2019-03-11 17:18:35 | [diff] [blame] | 2068 | CreateMockRead(resp, 1, ASYNC), MockRead(ASYNC, nullptr, 0, 4) // EOF |
[email protected] | f9a26d7 | 2010-08-03 18:07:13 | [diff] [blame] | 2069 | }; |
| 2070 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 2071 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 2072 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | f9a26d7 | 2010-08-03 18:07:13 | [diff] [blame] | 2073 | helper.RunPreTestSetup(); |
mmenke | 666a6fea | 2015-12-19 04:16:33 | [diff] [blame] | 2074 | helper.AddData(&data); |
bnc | 4d782f49 | 2016-08-18 13:50:00 | [diff] [blame] | 2075 | helper.StartDefaultTest(); |
| 2076 | EXPECT_THAT(helper.output().rv, IsError(ERR_IO_PENDING)); |
[email protected] | f9a26d7 | 2010-08-03 18:07:13 | [diff] [blame] | 2077 | |
bnc | 4d782f49 | 2016-08-18 13:50:00 | [diff] [blame] | 2078 | helper.WaitForCallbackToComplete(); |
| 2079 | EXPECT_THAT(helper.output().rv, IsOk()); |
[email protected] | 3b782843 | 2010-08-18 18:33:27 | [diff] [blame] | 2080 | |
[email protected] | f9a26d7 | 2010-08-03 18:07:13 | [diff] [blame] | 2081 | helper.ResetTrans(); |
mmenke | 666a6fea | 2015-12-19 04:16:33 | [diff] [blame] | 2082 | base::RunLoop().RunUntilIdle(); |
[email protected] | 3b782843 | 2010-08-18 18:33:27 | [diff] [blame] | 2083 | |
[email protected] | f9a26d7 | 2010-08-03 18:07:13 | [diff] [blame] | 2084 | helper.VerifyDataConsumed(); |
| 2085 | } |
| 2086 | |
[email protected] | 9330067 | 2009-10-24 13:22:51 | [diff] [blame] | 2087 | // Test that the transaction doesn't crash when we don't have a reply. |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 2088 | TEST_F(SpdyNetworkTransactionTest, ResponseWithoutHeaders) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2089 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | ff57bb8 | 2009-11-12 06:52:14 | [diff] [blame] | 2090 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 2091 | CreateMockRead(body, 1), MockRead(ASYNC, 0, 3) // EOF |
[email protected] | 9330067 | 2009-10-24 13:22:51 | [diff] [blame] | 2092 | }; |
| 2093 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2094 | spdy::SpdySerializedFrame req( |
| 2095 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 2096 | spdy::SpdySerializedFrame rst( |
| 2097 | spdy_util_.ConstructSpdyRstStream(1, spdy::ERROR_CODE_PROTOCOL_ERROR)); |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 2098 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 2099 | CreateMockWrite(req, 0), CreateMockWrite(rst, 2), |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 2100 | }; |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 2101 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 2102 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 2103 | helper.RunToCompletion(&data); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 2104 | TransactionHelperResult out = helper.output(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2105 | EXPECT_THAT(out.rv, IsError(ERR_SPDY_PROTOCOL_ERROR)); |
[email protected] | 9330067 | 2009-10-24 13:22:51 | [diff] [blame] | 2106 | } |
| 2107 | |
[email protected] | d3002235 | 2010-06-24 19:17:58 | [diff] [blame] | 2108 | // Test that the transaction doesn't crash when we get two replies on the same |
| 2109 | // stream ID. See http://crbug.com/45639. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 2110 | TEST_F(SpdyNetworkTransactionTest, ResponseWithTwoSynReplies) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2111 | spdy::SpdySerializedFrame req( |
| 2112 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 2113 | spdy::SpdySerializedFrame rst( |
| 2114 | spdy_util_.ConstructSpdyRstStream(1, spdy::ERROR_CODE_PROTOCOL_ERROR)); |
[email protected] | 2aeef78 | 2013-06-21 18:30:56 | [diff] [blame] | 2115 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 2116 | CreateMockWrite(req, 0), CreateMockWrite(rst, 4), |
[email protected] | 2aeef78 | 2013-06-21 18:30:56 | [diff] [blame] | 2117 | }; |
[email protected] | d3002235 | 2010-06-24 19:17:58 | [diff] [blame] | 2118 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2119 | spdy::SpdySerializedFrame resp0( |
| 2120 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 2121 | spdy::SpdySerializedFrame resp1( |
| 2122 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 2123 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | d3002235 | 2010-06-24 19:17:58 | [diff] [blame] | 2124 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 2125 | CreateMockRead(resp0, 1), CreateMockRead(resp1, 2), |
| 2126 | CreateMockRead(body, 3), MockRead(ASYNC, 0, 5) // EOF |
[email protected] | d3002235 | 2010-06-24 19:17:58 | [diff] [blame] | 2127 | }; |
| 2128 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 2129 | SequencedSocketData data(reads, writes); |
[email protected] | d3002235 | 2010-06-24 19:17:58 | [diff] [blame] | 2130 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 2131 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 2132 | helper.RunPreTestSetup(); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 2133 | helper.AddData(&data); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 2134 | |
| 2135 | HttpNetworkTransaction* trans = helper.trans(); |
[email protected] | d3002235 | 2010-06-24 19:17:58 | [diff] [blame] | 2136 | |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 2137 | TestCompletionCallback callback; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 2138 | int rv = trans->Start(&request_, callback.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2139 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | d3002235 | 2010-06-24 19:17:58 | [diff] [blame] | 2140 | rv = callback.WaitForResult(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2141 | EXPECT_THAT(rv, IsOk()); |
[email protected] | d3002235 | 2010-06-24 19:17:58 | [diff] [blame] | 2142 | |
| 2143 | const HttpResponseInfo* response = trans->GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 2144 | ASSERT_TRUE(response); |
| 2145 | EXPECT_TRUE(response->headers); |
[email protected] | d3002235 | 2010-06-24 19:17:58 | [diff] [blame] | 2146 | EXPECT_TRUE(response->was_fetched_via_spdy); |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 2147 | std::string response_data; |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 2148 | rv = ReadTransaction(trans, &response_data); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2149 | EXPECT_THAT(rv, IsError(ERR_SPDY_PROTOCOL_ERROR)); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 2150 | |
| 2151 | helper.VerifyDataConsumed(); |
[email protected] | d3002235 | 2010-06-24 19:17:58 | [diff] [blame] | 2152 | } |
| 2153 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 2154 | TEST_F(SpdyNetworkTransactionTest, ResetReplyWithTransferEncoding) { |
[email protected] | b350300 | 2012-03-27 04:57:25 | [diff] [blame] | 2155 | // Construct the request. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2156 | spdy::SpdySerializedFrame req( |
| 2157 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 2158 | spdy::SpdySerializedFrame rst( |
| 2159 | spdy_util_.ConstructSpdyRstStream(1, spdy::ERROR_CODE_PROTOCOL_ERROR)); |
[email protected] | b350300 | 2012-03-27 04:57:25 | [diff] [blame] | 2160 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 2161 | CreateMockWrite(req, 0), CreateMockWrite(rst, 2), |
[email protected] | b350300 | 2012-03-27 04:57:25 | [diff] [blame] | 2162 | }; |
| 2163 | |
| 2164 | const char* const headers[] = { |
[email protected] | 513963e | 2013-06-15 01:53:04 | [diff] [blame] | 2165 | "transfer-encoding", "chunked" |
[email protected] | b350300 | 2012-03-27 04:57:25 | [diff] [blame] | 2166 | }; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2167 | spdy::SpdySerializedFrame resp( |
| 2168 | spdy_util_.ConstructSpdyGetReply(headers, 1, 1)); |
| 2169 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | b350300 | 2012-03-27 04:57:25 | [diff] [blame] | 2170 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 2171 | CreateMockRead(resp, 1), CreateMockRead(body, 3), |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 2172 | MockRead(ASYNC, 0, 4) // EOF |
[email protected] | b350300 | 2012-03-27 04:57:25 | [diff] [blame] | 2173 | }; |
| 2174 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 2175 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 2176 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 2177 | helper.RunToCompletion(&data); |
[email protected] | b350300 | 2012-03-27 04:57:25 | [diff] [blame] | 2178 | TransactionHelperResult out = helper.output(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2179 | EXPECT_THAT(out.rv, IsError(ERR_SPDY_PROTOCOL_ERROR)); |
[email protected] | b350300 | 2012-03-27 04:57:25 | [diff] [blame] | 2180 | |
| 2181 | helper.session()->spdy_session_pool()->CloseAllSessions(); |
| 2182 | helper.VerifyDataConsumed(); |
| 2183 | } |
| 2184 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 2185 | TEST_F(SpdyNetworkTransactionTest, ResetPushWithTransferEncoding) { |
[email protected] | b350300 | 2012-03-27 04:57:25 | [diff] [blame] | 2186 | // Construct the request. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2187 | spdy::SpdySerializedFrame req( |
| 2188 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 2189 | spdy::SpdySerializedFrame priority( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 2190 | spdy_util_.ConstructSpdyPriority(2, 1, IDLE, true)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2191 | spdy::SpdySerializedFrame rst( |
| 2192 | spdy_util_.ConstructSpdyRstStream(2, spdy::ERROR_CODE_PROTOCOL_ERROR)); |
[email protected] | b350300 | 2012-03-27 04:57:25 | [diff] [blame] | 2193 | MockWrite writes[] = { |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 2194 | CreateMockWrite(req, 0), CreateMockWrite(priority, 3), |
| 2195 | CreateMockWrite(rst, 5), |
[email protected] | b350300 | 2012-03-27 04:57:25 | [diff] [blame] | 2196 | }; |
| 2197 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2198 | spdy::SpdySerializedFrame resp( |
| 2199 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
[email protected] | 513963e | 2013-06-15 01:53:04 | [diff] [blame] | 2200 | const char* const headers[] = { |
| 2201 | "transfer-encoding", "chunked" |
| 2202 | }; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2203 | spdy::SpdySerializedFrame push(spdy_util_.ConstructSpdyPush( |
Avi Drissman | 4365a478 | 2018-12-28 19:26:24 | [diff] [blame] | 2204 | headers, base::size(headers) / 2, 2, 1, "https://www.example.org/1")); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2205 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | b350300 | 2012-03-27 04:57:25 | [diff] [blame] | 2206 | MockRead reads[] = { |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 2207 | CreateMockRead(resp, 1), CreateMockRead(push, 2), CreateMockRead(body, 4), |
| 2208 | MockRead(ASYNC, 0, 6) // EOF |
[email protected] | b350300 | 2012-03-27 04:57:25 | [diff] [blame] | 2209 | }; |
| 2210 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 2211 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 2212 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 2213 | helper.RunToCompletion(&data); |
[email protected] | b350300 | 2012-03-27 04:57:25 | [diff] [blame] | 2214 | TransactionHelperResult out = helper.output(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2215 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 2216 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | b350300 | 2012-03-27 04:57:25 | [diff] [blame] | 2217 | EXPECT_EQ("hello!", out.response_data); |
| 2218 | |
| 2219 | helper.session()->spdy_session_pool()->CloseAllSessions(); |
| 2220 | helper.VerifyDataConsumed(); |
| 2221 | } |
| 2222 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 2223 | TEST_F(SpdyNetworkTransactionTest, CancelledTransaction) { |
[email protected] | 75f30cc2 | 2010-06-28 21:41:38 | [diff] [blame] | 2224 | // Construct the request. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2225 | spdy::SpdySerializedFrame req( |
| 2226 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
[email protected] | 34437af8 | 2009-11-06 02:28:49 | [diff] [blame] | 2227 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 2228 | CreateMockWrite(req), |
[email protected] | 34437af8 | 2009-11-06 02:28:49 | [diff] [blame] | 2229 | }; |
| 2230 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2231 | spdy::SpdySerializedFrame resp( |
| 2232 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
[email protected] | 34437af8 | 2009-11-06 02:28:49 | [diff] [blame] | 2233 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 2234 | CreateMockRead(resp), |
| 2235 | // This following read isn't used by the test, except during the |
| 2236 | // RunUntilIdle() call at the end since the SpdySession survives the |
| 2237 | // HttpNetworkTransaction and still tries to continue Read()'ing. Any |
| 2238 | // MockRead will do here. |
| 2239 | MockRead(ASYNC, 0, 0) // EOF |
[email protected] | 34437af8 | 2009-11-06 02:28:49 | [diff] [blame] | 2240 | }; |
| 2241 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 2242 | StaticSocketDataProvider data(reads, writes); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 2243 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 2244 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 2245 | helper.RunPreTestSetup(); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 2246 | helper.AddData(&data); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 2247 | HttpNetworkTransaction* trans = helper.trans(); |
[email protected] | 34437af8 | 2009-11-06 02:28:49 | [diff] [blame] | 2248 | |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 2249 | TestCompletionCallback callback; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 2250 | int rv = trans->Start(&request_, callback.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2251 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 2252 | helper.ResetTrans(); // Cancel the transaction. |
[email protected] | 34437af8 | 2009-11-06 02:28:49 | [diff] [blame] | 2253 | |
[email protected] | 30c942b | 2010-07-21 16:59:59 | [diff] [blame] | 2254 | // Flush the MessageLoop while the SpdySessionDependencies (in particular, the |
[email protected] | 34437af8 | 2009-11-06 02:28:49 | [diff] [blame] | 2255 | // MockClientSocketFactory) are still alive. |
[email protected] | fc9d8847 | 2013-08-14 02:31:17 | [diff] [blame] | 2256 | base::RunLoop().RunUntilIdle(); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 2257 | helper.VerifyDataNotConsumed(); |
[email protected] | 34437af8 | 2009-11-06 02:28:49 | [diff] [blame] | 2258 | } |
[email protected] | 72552f0 | 2009-10-28 15:25:01 | [diff] [blame] | 2259 | |
[email protected] | 6c6ea17 | 2010-07-27 20:04:03 | [diff] [blame] | 2260 | // Verify that the client sends a Rst Frame upon cancelling the stream. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 2261 | TEST_F(SpdyNetworkTransactionTest, CancelledTransactionSendRst) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2262 | spdy::SpdySerializedFrame req( |
| 2263 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 2264 | spdy::SpdySerializedFrame rst( |
| 2265 | spdy_util_.ConstructSpdyRstStream(1, spdy::ERROR_CODE_CANCEL)); |
[email protected] | 6c6ea17 | 2010-07-27 20:04:03 | [diff] [blame] | 2266 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 2267 | CreateMockWrite(req, 0, SYNCHRONOUS), |
| 2268 | CreateMockWrite(rst, 2, SYNCHRONOUS), |
[email protected] | 6c6ea17 | 2010-07-27 20:04:03 | [diff] [blame] | 2269 | }; |
| 2270 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2271 | spdy::SpdySerializedFrame resp( |
| 2272 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
[email protected] | 6c6ea17 | 2010-07-27 20:04:03 | [diff] [blame] | 2273 | MockRead reads[] = { |
Raul Tambre | 94493c65 | 2019-03-11 17:18:35 | [diff] [blame] | 2274 | CreateMockRead(resp, 1, ASYNC), MockRead(ASYNC, nullptr, 0, 3) // EOF |
[email protected] | 6c6ea17 | 2010-07-27 20:04:03 | [diff] [blame] | 2275 | }; |
| 2276 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 2277 | SequencedSocketData data(reads, writes); |
[email protected] | 6c6ea17 | 2010-07-27 20:04:03 | [diff] [blame] | 2278 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 2279 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | 6c6ea17 | 2010-07-27 20:04:03 | [diff] [blame] | 2280 | helper.RunPreTestSetup(); |
mmenke | 666a6fea | 2015-12-19 04:16:33 | [diff] [blame] | 2281 | helper.AddData(&data); |
[email protected] | 6c6ea17 | 2010-07-27 20:04:03 | [diff] [blame] | 2282 | HttpNetworkTransaction* trans = helper.trans(); |
| 2283 | |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 2284 | TestCompletionCallback callback; |
[email protected] | 6c6ea17 | 2010-07-27 20:04:03 | [diff] [blame] | 2285 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 2286 | int rv = trans->Start(&request_, callback.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2287 | EXPECT_THAT(callback.GetResult(rv), IsOk()); |
[email protected] | 6c6ea17 | 2010-07-27 20:04:03 | [diff] [blame] | 2288 | |
[email protected] | 3b782843 | 2010-08-18 18:33:27 | [diff] [blame] | 2289 | helper.ResetTrans(); |
mmenke | 666a6fea | 2015-12-19 04:16:33 | [diff] [blame] | 2290 | base::RunLoop().RunUntilIdle(); |
[email protected] | 3b782843 | 2010-08-18 18:33:27 | [diff] [blame] | 2291 | |
[email protected] | 6c6ea17 | 2010-07-27 20:04:03 | [diff] [blame] | 2292 | helper.VerifyDataConsumed(); |
| 2293 | } |
| 2294 | |
[email protected] | b278eb7 | 2010-07-09 20:17:00 | [diff] [blame] | 2295 | // Verify that the client can correctly deal with the user callback attempting |
| 2296 | // to start another transaction on a session that is closing down. See |
| 2297 | // http://crbug.com/47455 |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 2298 | TEST_F(SpdyNetworkTransactionTest, StartTransactionOnReadCallback) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2299 | spdy::SpdySerializedFrame req( |
| 2300 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 2301 | MockWrite writes[] = {CreateMockWrite(req)}; |
bnc | eb9aa711 | 2017-01-05 01:03:46 | [diff] [blame] | 2302 | MockWrite writes2[] = {CreateMockWrite(req, 0), |
| 2303 | MockWrite(SYNCHRONOUS, ERR_IO_PENDING, 3)}; |
[email protected] | b278eb7 | 2010-07-09 20:17:00 | [diff] [blame] | 2304 | |
[email protected] | cbdd7316 | 2013-03-18 23:27:33 | [diff] [blame] | 2305 | // The indicated length of this frame is longer than its actual length. When |
| 2306 | // the session receives an empty frame after this one, it shuts down the |
[email protected] | b278eb7 | 2010-07-09 20:17:00 | [diff] [blame] | 2307 | // session, and calls the read callback with the incomplete data. |
Avi Drissman | 13fc893 | 2015-12-20 04:40:46 | [diff] [blame] | 2308 | const uint8_t kGetBodyFrame2[] = { |
| 2309 | 0x00, 0x00, 0x00, 0x01, 0x01, 0x00, 0x00, |
| 2310 | 0x07, 'h', 'e', 'l', 'l', 'o', '!', |
[email protected] | b278eb7 | 2010-07-09 20:17:00 | [diff] [blame] | 2311 | }; |
| 2312 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2313 | spdy::SpdySerializedFrame resp( |
| 2314 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
[email protected] | b278eb7 | 2010-07-09 20:17:00 | [diff] [blame] | 2315 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 2316 | CreateMockRead(resp, 1), |
rch | 3232084 | 2015-05-16 15:57:09 | [diff] [blame] | 2317 | MockRead(ASYNC, ERR_IO_PENDING, 2), // Force a pause |
| 2318 | MockRead(ASYNC, reinterpret_cast<const char*>(kGetBodyFrame2), |
Avi Drissman | 4365a478 | 2018-12-28 19:26:24 | [diff] [blame] | 2319 | base::size(kGetBodyFrame2), 3), |
rch | 3232084 | 2015-05-16 15:57:09 | [diff] [blame] | 2320 | MockRead(ASYNC, ERR_IO_PENDING, 4), // Force a pause |
Raul Tambre | 94493c65 | 2019-03-11 17:18:35 | [diff] [blame] | 2321 | MockRead(ASYNC, nullptr, 0, 5), // EOF |
[email protected] | b278eb7 | 2010-07-09 20:17:00 | [diff] [blame] | 2322 | }; |
| 2323 | MockRead reads2[] = { |
Raul Tambre | 94493c65 | 2019-03-11 17:18:35 | [diff] [blame] | 2324 | CreateMockRead(resp, 1), MockRead(ASYNC, nullptr, 0, 2), // EOF |
[email protected] | b278eb7 | 2010-07-09 20:17:00 | [diff] [blame] | 2325 | }; |
| 2326 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 2327 | SequencedSocketData data(reads, writes); |
| 2328 | SequencedSocketData data2(reads2, writes2); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 2329 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 2330 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 2331 | helper.RunPreTestSetup(); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 2332 | helper.AddData(&data); |
| 2333 | helper.AddData(&data2); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 2334 | HttpNetworkTransaction* trans = helper.trans(); |
[email protected] | b278eb7 | 2010-07-09 20:17:00 | [diff] [blame] | 2335 | |
| 2336 | // Start the transaction with basic parameters. |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 2337 | TestCompletionCallback callback; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 2338 | int rv = trans->Start(&request_, callback.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2339 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | b278eb7 | 2010-07-09 20:17:00 | [diff] [blame] | 2340 | rv = callback.WaitForResult(); |
| 2341 | |
[email protected] | b278eb7 | 2010-07-09 20:17:00 | [diff] [blame] | 2342 | const int kSize = 3000; |
Victor Costan | 9c7302b | 2018-08-27 16:39:44 | [diff] [blame] | 2343 | scoped_refptr<IOBuffer> buf = base::MakeRefCounted<IOBuffer>(kSize); |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 2344 | rv = trans->Read( |
rch | ebf1298 | 2015-04-10 01:15:00 | [diff] [blame] | 2345 | buf.get(), kSize, |
[email protected] | 513963e | 2013-06-15 01:53:04 | [diff] [blame] | 2346 | base::Bind(&SpdyNetworkTransactionTest::StartTransactionCallback, |
Bence Béky | d3dde83 | 2017-09-19 19:02:31 | [diff] [blame] | 2347 | helper.session(), default_url_, log_)); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2348 | ASSERT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 2349 | // This forces an err_IO_pending, which sets the callback. |
mmenke | e2401192 | 2015-12-17 22:12:59 | [diff] [blame] | 2350 | data.Resume(); |
| 2351 | data.RunUntilPaused(); |
| 2352 | |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 2353 | // This finishes the read. |
mmenke | e2401192 | 2015-12-17 22:12:59 | [diff] [blame] | 2354 | data.Resume(); |
| 2355 | base::RunLoop().RunUntilIdle(); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 2356 | helper.VerifyDataConsumed(); |
[email protected] | b278eb7 | 2010-07-09 20:17:00 | [diff] [blame] | 2357 | } |
| 2358 | |
Mostyn Bramley-Moore | 699c531 | 2018-05-01 10:48:09 | [diff] [blame] | 2359 | // Verify that the client can correctly deal with the user callback deleting |
| 2360 | // the transaction. Failures will usually be flagged by thread and/or memory |
| 2361 | // checking tools. See http://crbug.com/46925 |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 2362 | TEST_F(SpdyNetworkTransactionTest, DeleteSessionOnReadCallback) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2363 | spdy::SpdySerializedFrame req( |
| 2364 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 2365 | MockWrite writes[] = {CreateMockWrite(req, 0)}; |
[email protected] | 9be804c8 | 2010-06-24 17:59:46 | [diff] [blame] | 2366 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2367 | spdy::SpdySerializedFrame resp( |
| 2368 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 2369 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | 9be804c8 | 2010-06-24 17:59:46 | [diff] [blame] | 2370 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 2371 | CreateMockRead(resp, 1), |
Raul Tambre | 94493c65 | 2019-03-11 17:18:35 | [diff] [blame] | 2372 | MockRead(ASYNC, ERR_IO_PENDING, 2), // Force a pause |
| 2373 | CreateMockRead(body, 3), MockRead(ASYNC, nullptr, 0, 4), // EOF |
[email protected] | 9be804c8 | 2010-06-24 17:59:46 | [diff] [blame] | 2374 | }; |
| 2375 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 2376 | SequencedSocketData data(reads, writes); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 2377 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 2378 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 2379 | helper.RunPreTestSetup(); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 2380 | helper.AddData(&data); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 2381 | HttpNetworkTransaction* trans = helper.trans(); |
[email protected] | 9be804c8 | 2010-06-24 17:59:46 | [diff] [blame] | 2382 | |
| 2383 | // Start the transaction with basic parameters. |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 2384 | TestCompletionCallback callback; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 2385 | int rv = trans->Start(&request_, callback.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2386 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | 9be804c8 | 2010-06-24 17:59:46 | [diff] [blame] | 2387 | rv = callback.WaitForResult(); |
| 2388 | |
| 2389 | // Setup a user callback which will delete the session, and clear out the |
| 2390 | // memory holding the stream object. Note that the callback deletes trans. |
[email protected] | 9be804c8 | 2010-06-24 17:59:46 | [diff] [blame] | 2391 | const int kSize = 3000; |
Victor Costan | 9c7302b | 2018-08-27 16:39:44 | [diff] [blame] | 2392 | scoped_refptr<IOBuffer> buf = base::MakeRefCounted<IOBuffer>(kSize); |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 2393 | rv = trans->Read( |
[email protected] | 9049948 | 2013-06-01 00:39:50 | [diff] [blame] | 2394 | buf.get(), |
| 2395 | kSize, |
[email protected] | 513963e | 2013-06-15 01:53:04 | [diff] [blame] | 2396 | base::Bind(&SpdyNetworkTransactionTest::DeleteSessionCallback, |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 2397 | base::Unretained(&helper))); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2398 | ASSERT_THAT(rv, IsError(ERR_IO_PENDING)); |
mmenke | e2401192 | 2015-12-17 22:12:59 | [diff] [blame] | 2399 | data.Resume(); |
[email protected] | 9be804c8 | 2010-06-24 17:59:46 | [diff] [blame] | 2400 | |
| 2401 | // Finish running rest of tasks. |
[email protected] | fc9d8847 | 2013-08-14 02:31:17 | [diff] [blame] | 2402 | base::RunLoop().RunUntilIdle(); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 2403 | helper.VerifyDataConsumed(); |
[email protected] | 9be804c8 | 2010-06-24 17:59:46 | [diff] [blame] | 2404 | } |
| 2405 | |
allada | 71b2efb | 2016-09-09 04:57:48 | [diff] [blame] | 2406 | TEST_F(SpdyNetworkTransactionTest, TestRawHeaderSizeSuccessfullRequest) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2407 | spdy::SpdyHeaderBlock headers( |
| 2408 | spdy_util_.ConstructGetHeaderBlock(kDefaultUrl)); |
allada | 71b2efb | 2016-09-09 04:57:48 | [diff] [blame] | 2409 | headers["user-agent"] = ""; |
| 2410 | headers["accept-encoding"] = "gzip, deflate"; |
| 2411 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2412 | spdy::SpdySerializedFrame req( |
allada | 71b2efb | 2016-09-09 04:57:48 | [diff] [blame] | 2413 | spdy_util_.ConstructSpdyHeaders(1, std::move(headers), LOWEST, true)); |
| 2414 | MockWrite writes[] = { |
| 2415 | CreateMockWrite(req, 0), |
| 2416 | }; |
| 2417 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2418 | spdy::SpdySerializedFrame resp( |
| 2419 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
allada | 71b2efb | 2016-09-09 04:57:48 | [diff] [blame] | 2420 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2421 | spdy::SpdySerializedFrame response_body_frame( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 2422 | spdy_util_.ConstructSpdyDataFrame(1, "should not include", true)); |
allada | 71b2efb | 2016-09-09 04:57:48 | [diff] [blame] | 2423 | |
| 2424 | MockRead response_headers(CreateMockRead(resp, 1)); |
| 2425 | MockRead reads[] = { |
| 2426 | response_headers, CreateMockRead(response_body_frame, 2), |
Raul Tambre | 94493c65 | 2019-03-11 17:18:35 | [diff] [blame] | 2427 | MockRead(ASYNC, nullptr, 0, 3) // EOF |
allada | 71b2efb | 2016-09-09 04:57:48 | [diff] [blame] | 2428 | }; |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 2429 | SequencedSocketData data(reads, writes); |
allada | 71b2efb | 2016-09-09 04:57:48 | [diff] [blame] | 2430 | |
| 2431 | TestDelegate delegate; |
| 2432 | SpdyURLRequestContext spdy_url_request_context; |
| 2433 | TestNetworkDelegate network_delegate; |
| 2434 | spdy_url_request_context.set_network_delegate(&network_delegate); |
| 2435 | SSLSocketDataProvider ssl_data(ASYNC, OK); |
| 2436 | ssl_data.next_proto = kProtoHTTP2; |
| 2437 | |
| 2438 | std::unique_ptr<URLRequest> request(spdy_url_request_context.CreateRequest( |
rhalavati | 9ebaba7e | 2017-04-27 06:16:29 | [diff] [blame] | 2439 | GURL(kDefaultUrl), DEFAULT_PRIORITY, &delegate, |
| 2440 | TRAFFIC_ANNOTATION_FOR_TESTS)); |
allada | 71b2efb | 2016-09-09 04:57:48 | [diff] [blame] | 2441 | spdy_url_request_context.socket_factory().AddSSLSocketDataProvider(&ssl_data); |
| 2442 | spdy_url_request_context.socket_factory().AddSocketDataProvider(&data); |
| 2443 | |
| 2444 | request->Start(); |
| 2445 | base::RunLoop().Run(); |
| 2446 | |
| 2447 | EXPECT_LT(0, request->GetTotalSentBytes()); |
| 2448 | EXPECT_LT(0, request->GetTotalReceivedBytes()); |
| 2449 | EXPECT_EQ(network_delegate.total_network_bytes_sent(), |
| 2450 | request->GetTotalSentBytes()); |
| 2451 | EXPECT_EQ(network_delegate.total_network_bytes_received(), |
| 2452 | request->GetTotalReceivedBytes()); |
| 2453 | EXPECT_EQ(response_headers.data_len, request->raw_header_size()); |
| 2454 | EXPECT_TRUE(data.AllReadDataConsumed()); |
| 2455 | EXPECT_TRUE(data.AllWriteDataConsumed()); |
| 2456 | } |
| 2457 | |
| 2458 | TEST_F(SpdyNetworkTransactionTest, |
| 2459 | TestRawHeaderSizeSuccessfullPushHeadersFirst) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2460 | spdy::SpdyHeaderBlock headers( |
| 2461 | spdy_util_.ConstructGetHeaderBlock(kDefaultUrl)); |
allada | 71b2efb | 2016-09-09 04:57:48 | [diff] [blame] | 2462 | headers["user-agent"] = ""; |
| 2463 | headers["accept-encoding"] = "gzip, deflate"; |
| 2464 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2465 | spdy::SpdySerializedFrame req( |
allada | 71b2efb | 2016-09-09 04:57:48 | [diff] [blame] | 2466 | spdy_util_.ConstructSpdyHeaders(1, std::move(headers), LOWEST, true)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2467 | spdy::SpdySerializedFrame priority( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 2468 | spdy_util_.ConstructSpdyPriority(2, 1, IDLE, true)); |
allada | 71b2efb | 2016-09-09 04:57:48 | [diff] [blame] | 2469 | MockWrite writes[] = { |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 2470 | CreateMockWrite(req, 0), CreateMockWrite(priority, 2), |
allada | 71b2efb | 2016-09-09 04:57:48 | [diff] [blame] | 2471 | }; |
| 2472 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2473 | spdy::SpdySerializedFrame resp( |
| 2474 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 2475 | spdy::SpdySerializedFrame response_body_frame( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 2476 | spdy_util_.ConstructSpdyDataFrame(1, "should not include", true)); |
allada | 71b2efb | 2016-09-09 04:57:48 | [diff] [blame] | 2477 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2478 | spdy::SpdyHeaderBlock push_headers; |
bnc | c055fa3 | 2017-06-19 13:44:42 | [diff] [blame] | 2479 | push_headers[":method"] = "GET"; |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 2480 | spdy_util_.AddUrlToHeaderBlock(std::string(kDefaultUrl) + "b.dat", |
allada | 71b2efb | 2016-09-09 04:57:48 | [diff] [blame] | 2481 | &push_headers); |
| 2482 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2483 | spdy::SpdySerializedFrame push_init_frame( |
Bence Béky | f1d7852 | 2018-01-11 01:16:50 | [diff] [blame] | 2484 | spdy_util_.ConstructSpdyPushPromise(1, 2, std::move(push_headers))); |
allada | 71b2efb | 2016-09-09 04:57:48 | [diff] [blame] | 2485 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2486 | spdy::SpdySerializedFrame push_headers_frame( |
allada | 71b2efb | 2016-09-09 04:57:48 | [diff] [blame] | 2487 | spdy_util_.ConstructSpdyPushHeaders(2, nullptr, 0)); |
| 2488 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2489 | spdy::SpdySerializedFrame push_body_frame( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 2490 | spdy_util_.ConstructSpdyDataFrame(2, "should not include either", false)); |
allada | 71b2efb | 2016-09-09 04:57:48 | [diff] [blame] | 2491 | |
| 2492 | MockRead push_init_read(CreateMockRead(push_init_frame, 1)); |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 2493 | MockRead response_headers(CreateMockRead(resp, 5)); |
allada | 71b2efb | 2016-09-09 04:57:48 | [diff] [blame] | 2494 | // raw_header_size() will contain the size of the push promise frame |
| 2495 | // initialization. |
| 2496 | int expected_response_headers_size = |
| 2497 | response_headers.data_len + push_init_read.data_len; |
| 2498 | |
| 2499 | MockRead reads[] = { |
| 2500 | push_init_read, |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 2501 | CreateMockRead(push_headers_frame, 3), |
| 2502 | CreateMockRead(push_body_frame, 4), |
allada | 71b2efb | 2016-09-09 04:57:48 | [diff] [blame] | 2503 | response_headers, |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 2504 | CreateMockRead(response_body_frame, 6), |
| 2505 | MockRead(ASYNC, 0, 7) // EOF |
allada | 71b2efb | 2016-09-09 04:57:48 | [diff] [blame] | 2506 | }; |
| 2507 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 2508 | SequencedSocketData data(reads, writes); |
allada | 71b2efb | 2016-09-09 04:57:48 | [diff] [blame] | 2509 | |
| 2510 | TestDelegate delegate; |
| 2511 | SpdyURLRequestContext spdy_url_request_context; |
| 2512 | TestNetworkDelegate network_delegate; |
| 2513 | spdy_url_request_context.set_network_delegate(&network_delegate); |
| 2514 | SSLSocketDataProvider ssl_data(ASYNC, OK); |
| 2515 | ssl_data.next_proto = kProtoHTTP2; |
| 2516 | |
| 2517 | std::unique_ptr<URLRequest> request(spdy_url_request_context.CreateRequest( |
rhalavati | 9ebaba7e | 2017-04-27 06:16:29 | [diff] [blame] | 2518 | GURL(kDefaultUrl), DEFAULT_PRIORITY, &delegate, |
| 2519 | TRAFFIC_ANNOTATION_FOR_TESTS)); |
allada | 71b2efb | 2016-09-09 04:57:48 | [diff] [blame] | 2520 | spdy_url_request_context.socket_factory().AddSSLSocketDataProvider(&ssl_data); |
| 2521 | spdy_url_request_context.socket_factory().AddSocketDataProvider(&data); |
| 2522 | |
| 2523 | request->Start(); |
| 2524 | base::RunLoop().Run(); |
| 2525 | |
| 2526 | EXPECT_LT(0, request->GetTotalSentBytes()); |
| 2527 | EXPECT_LT(0, request->GetTotalReceivedBytes()); |
| 2528 | EXPECT_EQ(network_delegate.total_network_bytes_sent(), |
| 2529 | request->GetTotalSentBytes()); |
| 2530 | EXPECT_EQ(network_delegate.total_network_bytes_received(), |
| 2531 | request->GetTotalReceivedBytes()); |
| 2532 | EXPECT_EQ(expected_response_headers_size, request->raw_header_size()); |
| 2533 | EXPECT_TRUE(data.AllReadDataConsumed()); |
| 2534 | EXPECT_TRUE(data.AllWriteDataConsumed()); |
| 2535 | } |
| 2536 | |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2537 | TEST_F(SpdyNetworkTransactionTest, RedirectGetRequest) { |
| 2538 | SpdyURLRequestContext spdy_url_request_context; |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 2539 | |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2540 | SSLSocketDataProvider ssl_provider0(ASYNC, OK); |
| 2541 | ssl_provider0.next_proto = kProtoHTTP2; |
| 2542 | spdy_url_request_context.socket_factory().AddSSLSocketDataProvider( |
| 2543 | &ssl_provider0); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 2544 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2545 | spdy::SpdyHeaderBlock headers0( |
| 2546 | spdy_util_.ConstructGetHeaderBlock(kDefaultUrl)); |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2547 | headers0["user-agent"] = ""; |
| 2548 | headers0["accept-encoding"] = "gzip, deflate"; |
bnc | 086b39e1 | 2016-06-24 13:05:26 | [diff] [blame] | 2549 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2550 | spdy::SpdySerializedFrame req0( |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2551 | spdy_util_.ConstructSpdyHeaders(1, std::move(headers0), LOWEST, true)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2552 | spdy::SpdySerializedFrame rst( |
| 2553 | spdy_util_.ConstructSpdyRstStream(1, spdy::ERROR_CODE_CANCEL)); |
Shivani Sharma | c18f976 | 2017-10-23 16:43:23 | [diff] [blame] | 2554 | MockWrite writes0[] = {CreateMockWrite(req0, 0), CreateMockWrite(rst, 2)}; |
bnc | 086b39e1 | 2016-06-24 13:05:26 | [diff] [blame] | 2555 | |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2556 | const char* const kExtraHeaders[] = {"location", |
| 2557 | "https://www.foo.com/index.php"}; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2558 | spdy::SpdySerializedFrame resp0(spdy_util_.ConstructSpdyReplyError( |
Avi Drissman | 4365a478 | 2018-12-28 19:26:24 | [diff] [blame] | 2559 | "301", kExtraHeaders, base::size(kExtraHeaders) / 2, 1)); |
Shivani Sharma | c18f976 | 2017-10-23 16:43:23 | [diff] [blame] | 2560 | MockRead reads0[] = {CreateMockRead(resp0, 1), MockRead(ASYNC, 0, 3)}; |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 2561 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 2562 | SequencedSocketData data0(reads0, writes0); |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2563 | spdy_url_request_context.socket_factory().AddSocketDataProvider(&data0); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 2564 | |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2565 | SSLSocketDataProvider ssl_provider1(ASYNC, OK); |
| 2566 | ssl_provider1.next_proto = kProtoHTTP2; |
| 2567 | spdy_url_request_context.socket_factory().AddSSLSocketDataProvider( |
| 2568 | &ssl_provider1); |
[email protected] | 513963e | 2013-06-15 01:53:04 | [diff] [blame] | 2569 | |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2570 | SpdyTestUtil spdy_util1; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2571 | spdy::SpdyHeaderBlock headers1( |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2572 | spdy_util1.ConstructGetHeaderBlock("https://www.foo.com/index.php")); |
| 2573 | headers1["user-agent"] = ""; |
| 2574 | headers1["accept-encoding"] = "gzip, deflate"; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2575 | spdy::SpdySerializedFrame req1( |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2576 | spdy_util1.ConstructSpdyHeaders(1, std::move(headers1), LOWEST, true)); |
| 2577 | MockWrite writes1[] = {CreateMockWrite(req1, 0)}; |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 2578 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2579 | spdy::SpdySerializedFrame resp1( |
| 2580 | spdy_util1.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 2581 | spdy::SpdySerializedFrame body1(spdy_util1.ConstructSpdyDataFrame(1, true)); |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2582 | MockRead reads1[] = {CreateMockRead(resp1, 1), CreateMockRead(body1, 2), |
| 2583 | MockRead(ASYNC, 0, 3)}; |
| 2584 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 2585 | SequencedSocketData data1(reads1, writes1); |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2586 | spdy_url_request_context.socket_factory().AddSocketDataProvider(&data1); |
| 2587 | |
| 2588 | TestDelegate delegate; |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2589 | |
| 2590 | std::unique_ptr<URLRequest> request = spdy_url_request_context.CreateRequest( |
| 2591 | default_url_, DEFAULT_PRIORITY, &delegate, TRAFFIC_ANNOTATION_FOR_TESTS); |
| 2592 | request->Start(); |
Wez | 0e71711 | 2018-06-18 23:09:22 | [diff] [blame] | 2593 | delegate.RunUntilRedirect(); |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2594 | |
| 2595 | EXPECT_EQ(1, delegate.received_redirect_count()); |
| 2596 | |
Arthur Sonzogni | b8465ff7 | 2019-01-04 18:44:35 | [diff] [blame] | 2597 | request->FollowDeferredRedirect(base::nullopt /* removed_headers */, |
| 2598 | base::nullopt /* modified_headers */); |
Wez | 0e71711 | 2018-06-18 23:09:22 | [diff] [blame] | 2599 | delegate.RunUntilComplete(); |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2600 | |
| 2601 | EXPECT_EQ(1, delegate.response_started_count()); |
| 2602 | EXPECT_FALSE(delegate.received_data_before_response()); |
| 2603 | EXPECT_THAT(delegate.request_status(), IsOk()); |
| 2604 | EXPECT_EQ("hello!", delegate.data_received()); |
| 2605 | |
Wez | 0e71711 | 2018-06-18 23:09:22 | [diff] [blame] | 2606 | // Pump the message loop to allow read data to be consumed. |
| 2607 | base::RunLoop().RunUntilIdle(); |
| 2608 | |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2609 | EXPECT_TRUE(data0.AllReadDataConsumed()); |
| 2610 | EXPECT_TRUE(data0.AllWriteDataConsumed()); |
| 2611 | EXPECT_TRUE(data1.AllReadDataConsumed()); |
| 2612 | EXPECT_TRUE(data1.AllWriteDataConsumed()); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 2613 | } |
| 2614 | |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2615 | TEST_F(SpdyNetworkTransactionTest, RedirectServerPush) { |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2616 | const char redirected_url[] = "https://www.foo.com/index.php"; |
| 2617 | SpdyURLRequestContext spdy_url_request_context; |
[email protected] | 3a8d685 | 2011-03-11 23:43:44 | [diff] [blame] | 2618 | |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2619 | SSLSocketDataProvider ssl_provider0(ASYNC, OK); |
| 2620 | ssl_provider0.next_proto = kProtoHTTP2; |
Ryan Sleevi | 4f83209 | 2017-11-21 23:25:49 | [diff] [blame] | 2621 | ssl_provider0.ssl_info.cert = |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2622 | ImportCertFromFile(GetTestCertsDirectory(), "spdy_pooling.pem"); |
Ryan Sleevi | 4f83209 | 2017-11-21 23:25:49 | [diff] [blame] | 2623 | ASSERT_TRUE(ssl_provider0.ssl_info.cert); |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2624 | spdy_url_request_context.socket_factory().AddSSLSocketDataProvider( |
| 2625 | &ssl_provider0); |
| 2626 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2627 | spdy::SpdyHeaderBlock headers0( |
| 2628 | spdy_util_.ConstructGetHeaderBlock(kDefaultUrl)); |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2629 | headers0["user-agent"] = ""; |
| 2630 | headers0["accept-encoding"] = "gzip, deflate"; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2631 | spdy::SpdySerializedFrame req0( |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2632 | spdy_util_.ConstructSpdyHeaders(1, std::move(headers0), LOWEST, true)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2633 | spdy::SpdySerializedFrame priority( |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2634 | spdy_util_.ConstructSpdyPriority(2, 1, IDLE, true)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2635 | spdy::SpdySerializedFrame rst( |
| 2636 | spdy_util_.ConstructSpdyRstStream(2, spdy::ERROR_CODE_CANCEL)); |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2637 | MockWrite writes[] = {CreateMockWrite(req0, 0), CreateMockWrite(priority, 3), |
| 2638 | CreateMockWrite(rst, 5)}; |
[email protected] | 3a8d685 | 2011-03-11 23:43:44 | [diff] [blame] | 2639 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2640 | spdy::SpdySerializedFrame resp0( |
| 2641 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 2642 | spdy::SpdySerializedFrame push(spdy_util_.ConstructSpdyPush( |
Bence Béky | d2df6c1c8 | 2018-04-20 22:52:01 | [diff] [blame] | 2643 | nullptr, 0, 2, 1, kPushedUrl, "301", redirected_url)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2644 | spdy::SpdySerializedFrame body0(spdy_util_.ConstructSpdyDataFrame(1, true)); |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2645 | MockRead reads[] = {CreateMockRead(resp0, 1), CreateMockRead(push, 2), |
| 2646 | CreateMockRead(body0, 4), MockRead(ASYNC, 0, 6)}; |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 2647 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 2648 | SequencedSocketData data0(reads, writes); |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2649 | spdy_url_request_context.socket_factory().AddSocketDataProvider(&data0); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 2650 | |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2651 | SSLSocketDataProvider ssl_provider1(ASYNC, OK); |
| 2652 | ssl_provider1.next_proto = kProtoHTTP2; |
| 2653 | spdy_url_request_context.socket_factory().AddSSLSocketDataProvider( |
| 2654 | &ssl_provider1); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 2655 | |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2656 | SpdyTestUtil spdy_util1; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2657 | spdy::SpdyHeaderBlock headers1( |
| 2658 | spdy_util1.ConstructGetHeaderBlock(redirected_url)); |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2659 | headers1["user-agent"] = ""; |
| 2660 | headers1["accept-encoding"] = "gzip, deflate"; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2661 | spdy::SpdySerializedFrame req1( |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2662 | spdy_util1.ConstructSpdyHeaders(1, std::move(headers1), LOWEST, true)); |
| 2663 | MockWrite writes1[] = {CreateMockWrite(req1, 0)}; |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 2664 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2665 | spdy::SpdySerializedFrame resp1( |
| 2666 | spdy_util1.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 2667 | spdy::SpdySerializedFrame body1(spdy_util1.ConstructSpdyDataFrame(1, true)); |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2668 | MockRead reads1[] = {CreateMockRead(resp1, 1), CreateMockRead(body1, 2), |
| 2669 | MockRead(ASYNC, 0, 3)}; |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 2670 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 2671 | SequencedSocketData data1(reads1, writes1); |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2672 | spdy_url_request_context.socket_factory().AddSocketDataProvider(&data1); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 2673 | |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2674 | TestDelegate delegate0; |
| 2675 | std::unique_ptr<URLRequest> request = spdy_url_request_context.CreateRequest( |
| 2676 | default_url_, DEFAULT_PRIORITY, &delegate0, TRAFFIC_ANNOTATION_FOR_TESTS); |
| 2677 | |
| 2678 | request->Start(); |
Wez | 0e71711 | 2018-06-18 23:09:22 | [diff] [blame] | 2679 | delegate0.RunUntilComplete(); |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2680 | |
| 2681 | EXPECT_EQ(0, delegate0.received_redirect_count()); |
| 2682 | EXPECT_EQ("hello!", delegate0.data_received()); |
| 2683 | |
| 2684 | TestDelegate delegate1; |
| 2685 | std::unique_ptr<URLRequest> request1 = spdy_url_request_context.CreateRequest( |
Bence Béky | d2df6c1c8 | 2018-04-20 22:52:01 | [diff] [blame] | 2686 | GURL(kPushedUrl), DEFAULT_PRIORITY, &delegate1, |
| 2687 | TRAFFIC_ANNOTATION_FOR_TESTS); |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2688 | |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2689 | request1->Start(); |
Wez | 0e71711 | 2018-06-18 23:09:22 | [diff] [blame] | 2690 | delegate1.RunUntilRedirect(); |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2691 | EXPECT_EQ(1, delegate1.received_redirect_count()); |
| 2692 | |
Arthur Sonzogni | b8465ff7 | 2019-01-04 18:44:35 | [diff] [blame] | 2693 | request1->FollowDeferredRedirect(base::nullopt /* removed_headers */, |
| 2694 | base::nullopt /* modified_headers */); |
Wez | 0e71711 | 2018-06-18 23:09:22 | [diff] [blame] | 2695 | delegate1.RunUntilComplete(); |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2696 | EXPECT_EQ(1, delegate1.response_started_count()); |
| 2697 | EXPECT_FALSE(delegate1.received_data_before_response()); |
| 2698 | EXPECT_EQ(OK, delegate1.request_status()); |
| 2699 | EXPECT_EQ("hello!", delegate1.data_received()); |
| 2700 | |
Wez | 0e71711 | 2018-06-18 23:09:22 | [diff] [blame] | 2701 | // Pump the message loop to allow read data to be consumed. |
| 2702 | base::RunLoop().RunUntilIdle(); |
| 2703 | |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2704 | EXPECT_TRUE(data0.AllReadDataConsumed()); |
| 2705 | EXPECT_TRUE(data0.AllWriteDataConsumed()); |
| 2706 | EXPECT_TRUE(data1.AllReadDataConsumed()); |
| 2707 | EXPECT_TRUE(data1.AllWriteDataConsumed()); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 2708 | } |
| 2709 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 2710 | TEST_F(SpdyNetworkTransactionTest, ServerPushSingleDataFrame) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2711 | spdy::SpdySerializedFrame stream1_syn( |
Bence Béky | 27ad0a1 | 2018-02-08 00:35:48 | [diff] [blame] | 2712 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2713 | spdy::SpdySerializedFrame stream2_priority( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 2714 | spdy_util_.ConstructSpdyPriority(2, 1, IDLE, true)); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 2715 | MockWrite writes[] = { |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 2716 | CreateMockWrite(stream1_syn, 0), CreateMockWrite(stream2_priority, 3), |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 2717 | }; |
| 2718 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2719 | spdy::SpdySerializedFrame stream1_reply( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 2720 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2721 | spdy::SpdySerializedFrame stream2_syn( |
Bence Béky | d2df6c1c8 | 2018-04-20 22:52:01 | [diff] [blame] | 2722 | spdy_util_.ConstructSpdyPush(nullptr, 0, 2, 1, kPushedUrl)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2723 | spdy::SpdySerializedFrame stream1_body( |
| 2724 | spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | 8a0fc82 | 2013-06-27 20:52:43 | [diff] [blame] | 2725 | const char kPushedData[] = "pushed"; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2726 | spdy::SpdySerializedFrame stream2_body( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 2727 | spdy_util_.ConstructSpdyDataFrame(2, kPushedData, true)); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 2728 | MockRead reads[] = { |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 2729 | CreateMockRead(stream1_reply, 1), CreateMockRead(stream2_syn, 2), |
| 2730 | CreateMockRead(stream1_body, 4), CreateMockRead(stream2_body, 5), |
| 2731 | MockRead(SYNCHRONOUS, ERR_IO_PENDING, 6), // Force a pause |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 2732 | }; |
| 2733 | |
| 2734 | HttpResponseInfo response; |
| 2735 | HttpResponseInfo response2; |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 2736 | std::string expected_push_result("pushed"); |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 2737 | SequencedSocketData data(reads, writes); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 2738 | RunServerPushTest(&data, |
[email protected] | d0835850 | 2010-12-03 22:04:03 | [diff] [blame] | 2739 | &response, |
| 2740 | &response2, |
| 2741 | expected_push_result); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 2742 | |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 2743 | // Verify the response headers. |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 2744 | EXPECT_TRUE(response.headers); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 2745 | EXPECT_EQ("HTTP/1.1 200", response.headers->GetStatusLine()); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 2746 | |
| 2747 | // Verify the pushed stream. |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 2748 | EXPECT_TRUE(response2.headers); |
bnc | cdc749f | 2016-01-27 16:39:04 | [diff] [blame] | 2749 | EXPECT_EQ("HTTP/1.1 200", response2.headers->GetStatusLine()); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 2750 | } |
| 2751 | |
Bence Béky | 02b906a | 2018-07-18 21:03:39 | [diff] [blame] | 2752 | // When server push is disabled by |
| 2753 | // HttpNetworkSession::initial_settings[SETTINGS_ENABLE_PUSH] = 0, verify that |
| 2754 | // such a setting is sent out in the initial SETTINGS frame, and if the server |
| 2755 | // creates a pushed stream despite of this, it is immediately reset. |
| 2756 | TEST_F(SpdyNetworkTransactionTest, ServerPushDisabled) { |
Bence Béky | da83e05 | 2018-07-20 01:03:32 | [diff] [blame] | 2757 | base::HistogramTester histogram_tester; |
| 2758 | |
Bence Béky | 02b906a | 2018-07-18 21:03:39 | [diff] [blame] | 2759 | spdy::SpdySerializedFrame preface( |
| 2760 | const_cast<char*>(spdy::kHttp2ConnectionHeaderPrefix), |
| 2761 | spdy::kHttp2ConnectionHeaderPrefixSize, |
| 2762 | /* owns_buffer = */ false); |
| 2763 | |
| 2764 | spdy::SettingsMap initial_settings; |
| 2765 | initial_settings[spdy::SETTINGS_HEADER_TABLE_SIZE] = kSpdyMaxHeaderTableSize; |
| 2766 | initial_settings[spdy::SETTINGS_ENABLE_PUSH] = 0; |
| 2767 | initial_settings[spdy::SETTINGS_MAX_CONCURRENT_STREAMS] = |
| 2768 | kSpdyMaxConcurrentPushedStreams; |
| 2769 | spdy::SpdySerializedFrame initial_settings_frame( |
| 2770 | spdy_util_.ConstructSpdySettings(initial_settings)); |
| 2771 | |
| 2772 | spdy::SpdySerializedFrame req( |
| 2773 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 2774 | spdy::SpdySerializedFrame rst( |
| 2775 | spdy_util_.ConstructSpdyRstStream(2, spdy::ERROR_CODE_REFUSED_STREAM)); |
| 2776 | |
| 2777 | MockWrite writes[] = {CreateMockWrite(preface, 0), |
| 2778 | CreateMockWrite(initial_settings_frame, 1), |
| 2779 | CreateMockWrite(req, 2), CreateMockWrite(rst, 5)}; |
| 2780 | |
| 2781 | spdy::SpdySerializedFrame reply( |
| 2782 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 2783 | spdy::SpdySerializedFrame push( |
| 2784 | spdy_util_.ConstructSpdyPush(nullptr, 0, 2, 1, kPushedUrl)); |
| 2785 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 2786 | MockRead reads[] = {CreateMockRead(reply, 3), CreateMockRead(push, 4), |
| 2787 | CreateMockRead(body, 6), MockRead(ASYNC, OK, 7)}; |
| 2788 | |
| 2789 | SequencedSocketData data(reads, writes); |
| 2790 | |
| 2791 | auto session_deps = std::make_unique<SpdySessionDependencies>(); |
| 2792 | session_deps->http2_settings[spdy::SETTINGS_ENABLE_PUSH] = 0; |
| 2793 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
| 2794 | std::move(session_deps)); |
| 2795 | |
| 2796 | SpdySessionPool* spdy_session_pool = helper.session()->spdy_session_pool(); |
| 2797 | SpdySessionPoolPeer pool_peer(spdy_session_pool); |
| 2798 | pool_peer.SetEnableSendingInitialData(true); |
| 2799 | |
| 2800 | helper.RunToCompletion(&data); |
Bence Béky | da83e05 | 2018-07-20 01:03:32 | [diff] [blame] | 2801 | |
| 2802 | histogram_tester.ExpectBucketCount( |
| 2803 | "Net.SpdyPushedStreamFate", |
| 2804 | static_cast<int>(SpdyPushedStreamFate::kPushDisabled), 1); |
| 2805 | histogram_tester.ExpectTotalCount("Net.SpdyPushedStreamFate", 1); |
Bence Béky | 02b906a | 2018-07-18 21:03:39 | [diff] [blame] | 2806 | } |
| 2807 | |
Bence Béky | 5b1e4ce7 | 2018-01-11 14:55:15 | [diff] [blame] | 2808 | TEST_F(SpdyNetworkTransactionTest, ServerPushHeadMethod) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2809 | spdy::SpdySerializedFrame req( |
| 2810 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 2811 | spdy::SpdySerializedFrame priority( |
Bence Béky | 5b1e4ce7 | 2018-01-11 14:55:15 | [diff] [blame] | 2812 | spdy_util_.ConstructSpdyPriority(2, 1, IDLE, true)); |
| 2813 | MockWrite writes[] = {CreateMockWrite(req, 0), CreateMockWrite(priority, 2)}; |
| 2814 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2815 | spdy::SpdyHeaderBlock push_promise_header_block; |
| 2816 | push_promise_header_block[spdy::kHttp2MethodHeader] = "HEAD"; |
Bence Béky | d2df6c1c8 | 2018-04-20 22:52:01 | [diff] [blame] | 2817 | spdy_util_.AddUrlToHeaderBlock(kPushedUrl, &push_promise_header_block); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2818 | spdy::SpdySerializedFrame push_promise(spdy_util_.ConstructSpdyPushPromise( |
Bence Béky | 5b1e4ce7 | 2018-01-11 14:55:15 | [diff] [blame] | 2819 | 1, 2, std::move(push_promise_header_block))); |
| 2820 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2821 | spdy::SpdyHeaderBlock push_response_headers; |
| 2822 | push_response_headers[spdy::kHttp2StatusHeader] = "200"; |
Bence Béky | 5b1e4ce7 | 2018-01-11 14:55:15 | [diff] [blame] | 2823 | push_response_headers["foo"] = "bar"; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2824 | spdy::SpdyHeadersIR headers_ir(2, std::move(push_response_headers)); |
| 2825 | spdy::SpdySerializedFrame push_headers(spdy_util_.SerializeFrame(headers_ir)); |
Bence Béky | 5b1e4ce7 | 2018-01-11 14:55:15 | [diff] [blame] | 2826 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2827 | spdy::SpdySerializedFrame resp( |
| 2828 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 2829 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
Bence Béky | 5b1e4ce7 | 2018-01-11 14:55:15 | [diff] [blame] | 2830 | MockRead reads[] = { |
| 2831 | CreateMockRead(push_promise, 1), CreateMockRead(push_headers, 3), |
| 2832 | CreateMockRead(resp, 4), CreateMockRead(body, 5), |
| 2833 | // Do not close the connection after first request is done. |
| 2834 | MockRead(SYNCHRONOUS, ERR_IO_PENDING, 6)}; |
| 2835 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 2836 | SequencedSocketData data(reads, writes); |
Bence Béky | 5b1e4ce7 | 2018-01-11 14:55:15 | [diff] [blame] | 2837 | |
| 2838 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
| 2839 | helper.RunPreTestSetup(); |
| 2840 | helper.AddData(&data); |
| 2841 | |
| 2842 | // Run first request. This reads PUSH_PROMISE. |
| 2843 | helper.RunDefaultTest(); |
| 2844 | |
| 2845 | // Request the pushed resource. |
| 2846 | HttpNetworkTransaction trans(DEFAULT_PRIORITY, helper.session()); |
| 2847 | HttpRequestInfo request = CreateGetPushRequest(); |
| 2848 | request.method = "HEAD"; |
Ramin Halavati | b5e433e6 | 2018-02-07 07:41:10 | [diff] [blame] | 2849 | request.traffic_annotation = |
| 2850 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
Bence Béky | 5b1e4ce7 | 2018-01-11 14:55:15 | [diff] [blame] | 2851 | TestCompletionCallback callback; |
| 2852 | int rv = trans.Start(&request, callback.callback(), log_); |
| 2853 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 2854 | rv = callback.WaitForResult(); |
| 2855 | EXPECT_THAT(rv, IsOk()); |
| 2856 | |
| 2857 | const HttpResponseInfo* response = trans.GetResponseInfo(); |
| 2858 | ASSERT_TRUE(response); |
| 2859 | EXPECT_TRUE(response->was_fetched_via_spdy); |
| 2860 | EXPECT_TRUE(response->was_alpn_negotiated); |
| 2861 | ASSERT_TRUE(response->headers); |
| 2862 | EXPECT_EQ("HTTP/1.1 200", response->headers->GetStatusLine()); |
| 2863 | std::string value; |
| 2864 | EXPECT_TRUE(response->headers->GetNormalizedHeader("foo", &value)); |
| 2865 | EXPECT_EQ("bar", value); |
| 2866 | |
| 2867 | helper.VerifyDataConsumed(); |
| 2868 | } |
| 2869 | |
| 2870 | TEST_F(SpdyNetworkTransactionTest, ServerPushHeadDoesNotMatchGetRequest) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2871 | spdy::SpdySerializedFrame req1( |
| 2872 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 2873 | spdy::SpdySerializedFrame priority( |
Bence Béky | 5b1e4ce7 | 2018-01-11 14:55:15 | [diff] [blame] | 2874 | spdy_util_.ConstructSpdyPriority(2, 1, IDLE, true)); |
| 2875 | spdy_util_.UpdateWithStreamDestruction(1); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2876 | spdy::SpdySerializedFrame req2( |
| 2877 | spdy_util_.ConstructSpdyGet(kPushedUrl, 3, LOWEST)); |
Bence Béky | 5b1e4ce7 | 2018-01-11 14:55:15 | [diff] [blame] | 2878 | MockWrite writes[] = {CreateMockWrite(req1, 0), CreateMockWrite(priority, 2), |
| 2879 | CreateMockWrite(req2, 6)}; |
| 2880 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2881 | spdy::SpdyHeaderBlock push_promise_header_block; |
| 2882 | push_promise_header_block[spdy::kHttp2MethodHeader] = "HEAD"; |
Bence Béky | d2df6c1c8 | 2018-04-20 22:52:01 | [diff] [blame] | 2883 | spdy_util_.AddUrlToHeaderBlock(kPushedUrl, &push_promise_header_block); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2884 | spdy::SpdySerializedFrame push_promise(spdy_util_.ConstructSpdyPushPromise( |
Bence Béky | 5b1e4ce7 | 2018-01-11 14:55:15 | [diff] [blame] | 2885 | 1, 2, std::move(push_promise_header_block))); |
| 2886 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2887 | spdy::SpdyHeaderBlock push_response_headers; |
| 2888 | push_response_headers[spdy::kHttp2StatusHeader] = "200"; |
Bence Béky | 5b1e4ce7 | 2018-01-11 14:55:15 | [diff] [blame] | 2889 | push_response_headers["foo"] = "bar"; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2890 | spdy::SpdyHeadersIR headers_ir(2, std::move(push_response_headers)); |
| 2891 | spdy::SpdySerializedFrame push_headers(spdy_util_.SerializeFrame(headers_ir)); |
Bence Béky | 5b1e4ce7 | 2018-01-11 14:55:15 | [diff] [blame] | 2892 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2893 | spdy::SpdySerializedFrame resp1( |
| 2894 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 2895 | spdy::SpdySerializedFrame body1(spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 2896 | spdy::SpdySerializedFrame resp2( |
| 2897 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 3)); |
| 2898 | spdy::SpdySerializedFrame body2(spdy_util_.ConstructSpdyDataFrame(3, true)); |
Bence Béky | 5b1e4ce7 | 2018-01-11 14:55:15 | [diff] [blame] | 2899 | MockRead reads[] = {CreateMockRead(push_promise, 1), |
| 2900 | CreateMockRead(push_headers, 3), |
| 2901 | CreateMockRead(resp1, 4), |
| 2902 | CreateMockRead(body1, 5), |
| 2903 | CreateMockRead(resp2, 7), |
| 2904 | CreateMockRead(body2, 8), |
| 2905 | MockRead(ASYNC, 0, 9)}; |
| 2906 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 2907 | SequencedSocketData data(reads, writes); |
Bence Béky | 5b1e4ce7 | 2018-01-11 14:55:15 | [diff] [blame] | 2908 | |
| 2909 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
| 2910 | helper.RunPreTestSetup(); |
| 2911 | helper.AddData(&data); |
| 2912 | |
| 2913 | // Run first request. This reads PUSH_PROMISE. |
| 2914 | helper.RunDefaultTest(); |
| 2915 | |
| 2916 | // Request the pushed resource. |
| 2917 | HttpNetworkTransaction trans(DEFAULT_PRIORITY, helper.session()); |
| 2918 | HttpRequestInfo request = CreateGetPushRequest(); |
| 2919 | TestCompletionCallback callback; |
| 2920 | int rv = trans.Start(&request, callback.callback(), log_); |
| 2921 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 2922 | rv = callback.WaitForResult(); |
| 2923 | EXPECT_THAT(rv, IsOk()); |
| 2924 | |
| 2925 | const HttpResponseInfo* response = trans.GetResponseInfo(); |
| 2926 | ASSERT_TRUE(response); |
| 2927 | EXPECT_TRUE(response->was_fetched_via_spdy); |
| 2928 | EXPECT_TRUE(response->was_alpn_negotiated); |
| 2929 | ASSERT_TRUE(response->headers); |
| 2930 | EXPECT_EQ("HTTP/1.1 200", response->headers->GetStatusLine()); |
| 2931 | std::string value; |
| 2932 | EXPECT_FALSE(response->headers->GetNormalizedHeader("foo", &value)); |
| 2933 | std::string result; |
| 2934 | ReadResult(&trans, &result); |
| 2935 | EXPECT_EQ("hello!", result); |
| 2936 | |
| 2937 | // Read EOF. |
| 2938 | base::RunLoop().RunUntilIdle(); |
| 2939 | |
| 2940 | helper.VerifyDataConsumed(); |
| 2941 | } |
| 2942 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 2943 | TEST_F(SpdyNetworkTransactionTest, ServerPushSingleDataFrame2) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2944 | spdy::SpdySerializedFrame stream1_syn( |
Bence Béky | 27ad0a1 | 2018-02-08 00:35:48 | [diff] [blame] | 2945 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2946 | spdy::SpdySerializedFrame stream2_priority( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 2947 | spdy_util_.ConstructSpdyPriority(2, 1, IDLE, true)); |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 2948 | MockWrite writes[] = { |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 2949 | CreateMockWrite(stream1_syn, 0), CreateMockWrite(stream2_priority, 3), |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 2950 | }; |
[email protected] | 82918cc | 2010-08-25 17:24:50 | [diff] [blame] | 2951 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2952 | spdy::SpdySerializedFrame stream1_reply( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 2953 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2954 | spdy::SpdySerializedFrame stream2_syn( |
Bence Béky | d2df6c1c8 | 2018-04-20 22:52:01 | [diff] [blame] | 2955 | spdy_util_.ConstructSpdyPush(nullptr, 0, 2, 1, kPushedUrl)); |
[email protected] | 8a0fc82 | 2013-06-27 20:52:43 | [diff] [blame] | 2956 | const char kPushedData[] = "pushed"; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2957 | spdy::SpdySerializedFrame stream2_body( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 2958 | spdy_util_.ConstructSpdyDataFrame(2, kPushedData, true)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2959 | spdy::SpdySerializedFrame stream1_body( |
| 2960 | spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | 82918cc | 2010-08-25 17:24:50 | [diff] [blame] | 2961 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 2962 | CreateMockRead(stream1_reply, 1), |
| 2963 | CreateMockRead(stream2_syn, 2), |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 2964 | CreateMockRead(stream2_body, 4), |
| 2965 | CreateMockRead(stream1_body, 5, SYNCHRONOUS), |
| 2966 | MockRead(SYNCHRONOUS, ERR_IO_PENDING, 6), // Force a pause |
[email protected] | 82918cc | 2010-08-25 17:24:50 | [diff] [blame] | 2967 | }; |
| 2968 | |
| 2969 | HttpResponseInfo response; |
| 2970 | HttpResponseInfo response2; |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 2971 | std::string expected_push_result("pushed"); |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 2972 | SequencedSocketData data(reads, writes); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 2973 | RunServerPushTest(&data, |
[email protected] | d0835850 | 2010-12-03 22:04:03 | [diff] [blame] | 2974 | &response, |
| 2975 | &response2, |
| 2976 | expected_push_result); |
[email protected] | 82918cc | 2010-08-25 17:24:50 | [diff] [blame] | 2977 | |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 2978 | // Verify the response headers. |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 2979 | EXPECT_TRUE(response.headers); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 2980 | EXPECT_EQ("HTTP/1.1 200", response.headers->GetStatusLine()); |
[email protected] | 82918cc | 2010-08-25 17:24:50 | [diff] [blame] | 2981 | |
| 2982 | // Verify the pushed stream. |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 2983 | EXPECT_TRUE(response2.headers); |
bnc | cdc749f | 2016-01-27 16:39:04 | [diff] [blame] | 2984 | EXPECT_EQ("HTTP/1.1 200", response2.headers->GetStatusLine()); |
[email protected] | 82918cc | 2010-08-25 17:24:50 | [diff] [blame] | 2985 | } |
| 2986 | |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 2987 | TEST_F(SpdyNetworkTransactionTest, ServerPushUpdatesPriority) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2988 | spdy::SpdySerializedFrame stream1_headers( |
Bence Béky | 27ad0a1 | 2018-02-08 00:35:48 | [diff] [blame] | 2989 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, HIGHEST)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2990 | spdy::SpdySerializedFrame stream3_headers( |
Bence Béky | 27ad0a1 | 2018-02-08 00:35:48 | [diff] [blame] | 2991 | spdy_util_.ConstructSpdyGet(nullptr, 0, 3, MEDIUM)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2992 | spdy::SpdySerializedFrame stream5_headers( |
Bence Béky | 27ad0a1 | 2018-02-08 00:35:48 | [diff] [blame] | 2993 | spdy_util_.ConstructSpdyGet(nullptr, 0, 5, MEDIUM)); |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 2994 | |
| 2995 | // Stream 1 pushes two streams that are initially prioritized below stream 5. |
| 2996 | // Stream 2 is later prioritized below stream 1 after it matches a request. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2997 | spdy::SpdySerializedFrame stream2_priority( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 2998 | spdy_util_.ConstructSpdyPriority(2, 5, IDLE, true)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2999 | spdy::SpdySerializedFrame stream4_priority( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3000 | spdy_util_.ConstructSpdyPriority(4, 2, IDLE, true)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3001 | spdy::SpdySerializedFrame stream4_priority_update( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3002 | spdy_util_.ConstructSpdyPriority(4, 5, IDLE, true)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3003 | spdy::SpdySerializedFrame stream2_priority_update( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3004 | spdy_util_.ConstructSpdyPriority(2, 1, HIGHEST, true)); |
| 3005 | |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 3006 | MockWrite writes[] = { |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3007 | CreateMockWrite(stream1_headers, 0), |
| 3008 | CreateMockWrite(stream3_headers, 1), |
| 3009 | CreateMockWrite(stream5_headers, 2), |
| 3010 | CreateMockWrite(stream2_priority, 7), |
| 3011 | CreateMockWrite(stream4_priority, 9), |
| 3012 | CreateMockWrite(stream4_priority_update, 11), |
| 3013 | CreateMockWrite(stream2_priority_update, 12), |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 3014 | }; |
| 3015 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3016 | spdy::SpdySerializedFrame stream1_reply( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3017 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3018 | spdy::SpdySerializedFrame stream3_reply( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3019 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 3)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3020 | spdy::SpdySerializedFrame stream5_reply( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3021 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 5)); |
| 3022 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3023 | spdy::SpdySerializedFrame stream2_push( |
Bence Béky | d2df6c1c8 | 2018-04-20 22:52:01 | [diff] [blame] | 3024 | spdy_util_.ConstructSpdyPush(nullptr, 0, 2, 1, kPushedUrl)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3025 | spdy::SpdySerializedFrame stream4_push(spdy_util_.ConstructSpdyPush( |
Bence Béky | 3e01b53 | 2018-02-06 23:04:51 | [diff] [blame] | 3026 | nullptr, 0, 4, 1, "https://www.example.org/bar.dat")); |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3027 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3028 | spdy::SpdySerializedFrame stream1_body( |
| 3029 | spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 3030 | spdy::SpdySerializedFrame stream2_body( |
| 3031 | spdy_util_.ConstructSpdyDataFrame(2, true)); |
| 3032 | spdy::SpdySerializedFrame stream3_body( |
| 3033 | spdy_util_.ConstructSpdyDataFrame(3, true)); |
| 3034 | spdy::SpdySerializedFrame stream5_body( |
| 3035 | spdy_util_.ConstructSpdyDataFrame(5, true)); |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3036 | |
| 3037 | MockRead reads[] = { |
| 3038 | CreateMockRead(stream1_reply, 3), |
| 3039 | CreateMockRead(stream3_reply, 4), |
| 3040 | CreateMockRead(stream5_reply, 5), |
| 3041 | CreateMockRead(stream2_push, 6), |
| 3042 | CreateMockRead(stream4_push, 8), |
| 3043 | MockRead(ASYNC, ERR_IO_PENDING, 10), |
| 3044 | CreateMockRead(stream1_body, 13), |
| 3045 | CreateMockRead(stream2_body, 14), |
| 3046 | CreateMockRead(stream3_body, 15), |
| 3047 | CreateMockRead(stream5_body, 16), |
| 3048 | MockRead(SYNCHRONOUS, ERR_IO_PENDING, 17), // Force a pause |
| 3049 | }; |
| 3050 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 3051 | SequencedSocketData data(reads, writes); |
| 3052 | SequencedSocketData data_placeholder1; |
| 3053 | SequencedSocketData data_placeholder2; |
| 3054 | SequencedSocketData data_placeholder3; |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3055 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 3056 | NormalSpdyTransactionHelper helper(request_, LOWEST, log_, nullptr); |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3057 | helper.RunPreTestSetup(); |
| 3058 | helper.AddData(&data); |
| 3059 | helper.AddData(&data_placeholder1); // other requests reuse the same socket |
| 3060 | helper.AddData(&data_placeholder2); |
| 3061 | helper.AddData(&data_placeholder3); |
| 3062 | HttpNetworkTransaction trans1(HIGHEST, helper.session()); |
| 3063 | HttpNetworkTransaction trans3(MEDIUM, helper.session()); |
| 3064 | HttpNetworkTransaction trans5(MEDIUM, helper.session()); |
| 3065 | |
| 3066 | TestCompletionCallback callback1; |
| 3067 | TestCompletionCallback callback3; |
| 3068 | TestCompletionCallback callback5; |
| 3069 | |
| 3070 | // Start the ordinary requests. |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 3071 | ASSERT_THAT(trans1.Start(&request_, callback1.callback(), log_), |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3072 | IsError(ERR_IO_PENDING)); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 3073 | ASSERT_THAT(trans3.Start(&request_, callback3.callback(), log_), |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3074 | IsError(ERR_IO_PENDING)); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 3075 | ASSERT_THAT(trans5.Start(&request_, callback5.callback(), log_), |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3076 | IsError(ERR_IO_PENDING)); |
| 3077 | data.RunUntilPaused(); |
| 3078 | |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3079 | // Start a request that matches the push. |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 3080 | HttpRequestInfo push_req = CreateGetPushRequest(); |
krasin | 0bfeb6b | 2017-01-13 21:48:04 | [diff] [blame] | 3081 | |
| 3082 | HttpNetworkTransaction trans2(HIGHEST, helper.session()); |
| 3083 | TestCompletionCallback callback2; |
Bence Béky | d3dde83 | 2017-09-19 19:02:31 | [diff] [blame] | 3084 | ASSERT_THAT(trans2.Start(&push_req, callback2.callback(), log_), |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3085 | IsError(ERR_IO_PENDING)); |
| 3086 | data.Resume(); |
| 3087 | |
| 3088 | base::RunLoop().RunUntilIdle(); |
| 3089 | ASSERT_THAT(callback1.WaitForResult(), IsOk()); |
| 3090 | ASSERT_THAT(callback2.WaitForResult(), IsOk()); |
| 3091 | ASSERT_THAT(callback3.WaitForResult(), IsOk()); |
| 3092 | ASSERT_THAT(callback5.WaitForResult(), IsOk()); |
| 3093 | helper.VerifyDataConsumed(); |
| 3094 | } |
| 3095 | |
| 3096 | TEST_F(SpdyNetworkTransactionTest, ServerPushServerAborted) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3097 | spdy::SpdySerializedFrame stream1_syn( |
Bence Béky | 27ad0a1 | 2018-02-08 00:35:48 | [diff] [blame] | 3098 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3099 | spdy::SpdySerializedFrame stream2_priority( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3100 | spdy_util_.ConstructSpdyPriority(2, 1, IDLE, true)); |
| 3101 | MockWrite writes[] = { |
| 3102 | CreateMockWrite(stream1_syn, 0), CreateMockWrite(stream2_priority, 3), |
| 3103 | }; |
| 3104 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3105 | spdy::SpdySerializedFrame stream1_reply( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3106 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3107 | spdy::SpdySerializedFrame stream2_syn( |
Bence Béky | d2df6c1c8 | 2018-04-20 22:52:01 | [diff] [blame] | 3108 | spdy_util_.ConstructSpdyPush(nullptr, 0, 2, 1, kPushedUrl)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3109 | spdy::SpdySerializedFrame stream2_rst( |
| 3110 | spdy_util_.ConstructSpdyRstStream(2, spdy::ERROR_CODE_PROTOCOL_ERROR)); |
| 3111 | spdy::SpdySerializedFrame stream1_body( |
| 3112 | spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 3113 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 3114 | CreateMockRead(stream1_reply, 1), |
bnc | eb9aa711 | 2017-01-05 01:03:46 | [diff] [blame] | 3115 | CreateMockRead(stream2_syn, 2, SYNCHRONOUS), |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3116 | CreateMockRead(stream2_rst, 4), |
| 3117 | CreateMockRead(stream1_body, 5, SYNCHRONOUS), |
| 3118 | MockRead(SYNCHRONOUS, ERR_IO_PENDING, 6), // Force a pause |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 3119 | }; |
| 3120 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 3121 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 3122 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 3123 | |
| 3124 | helper.RunPreTestSetup(); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 3125 | helper.AddData(&data); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 3126 | |
| 3127 | HttpNetworkTransaction* trans = helper.trans(); |
| 3128 | |
| 3129 | // Start the transaction with basic parameters. |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 3130 | TestCompletionCallback callback; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 3131 | int rv = trans->Start(&request_, callback.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 3132 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 3133 | rv = callback.WaitForResult(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 3134 | EXPECT_THAT(rv, IsOk()); |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 3135 | |
| 3136 | // Verify that we consumed all test data. |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3137 | base::RunLoop().RunUntilIdle(); |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 3138 | EXPECT_TRUE(data.AllReadDataConsumed()); |
| 3139 | EXPECT_TRUE(data.AllWriteDataConsumed()); |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 3140 | |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 3141 | // Verify the response headers. |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 3142 | HttpResponseInfo response = *trans->GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 3143 | EXPECT_TRUE(response.headers); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 3144 | EXPECT_EQ("HTTP/1.1 200", response.headers->GetStatusLine()); |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 3145 | } |
| 3146 | |
[email protected] | 8a0fc82 | 2013-06-27 20:52:43 | [diff] [blame] | 3147 | // Verify that we don't leak streams and that we properly send a reset |
| 3148 | // if the server pushes the same stream twice. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 3149 | TEST_F(SpdyNetworkTransactionTest, ServerPushDuplicate) { |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 3150 | base::HistogramTester histogram_tester; |
| 3151 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3152 | spdy::SpdySerializedFrame stream1_syn( |
Bence Béky | 27ad0a1 | 2018-02-08 00:35:48 | [diff] [blame] | 3153 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3154 | spdy::SpdySerializedFrame stream2_priority( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3155 | spdy_util_.ConstructSpdyPriority(2, 1, IDLE, true)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3156 | spdy::SpdySerializedFrame stream3_rst( |
| 3157 | spdy_util_.ConstructSpdyRstStream(4, spdy::ERROR_CODE_REFUSED_STREAM)); |
[email protected] | fdc165a | 2010-09-03 03:51:29 | [diff] [blame] | 3158 | MockWrite writes[] = { |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3159 | CreateMockWrite(stream1_syn, 0), CreateMockWrite(stream2_priority, 3), |
| 3160 | CreateMockWrite(stream3_rst, 5), |
[email protected] | fdc165a | 2010-09-03 03:51:29 | [diff] [blame] | 3161 | }; |
| 3162 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3163 | spdy::SpdySerializedFrame stream1_reply( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3164 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3165 | spdy::SpdySerializedFrame stream2_syn( |
Bence Béky | d2df6c1c8 | 2018-04-20 22:52:01 | [diff] [blame] | 3166 | spdy_util_.ConstructSpdyPush(nullptr, 0, 2, 1, kPushedUrl)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3167 | spdy::SpdySerializedFrame stream3_syn( |
Bence Béky | d2df6c1c8 | 2018-04-20 22:52:01 | [diff] [blame] | 3168 | spdy_util_.ConstructSpdyPush(nullptr, 0, 4, 1, kPushedUrl)); |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3169 | |
[email protected] | 8a0fc82 | 2013-06-27 20:52:43 | [diff] [blame] | 3170 | const char kPushedData[] = "pushed"; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3171 | spdy::SpdySerializedFrame stream1_body( |
| 3172 | spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 3173 | spdy::SpdySerializedFrame stream2_body( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 3174 | spdy_util_.ConstructSpdyDataFrame(2, kPushedData, true)); |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3175 | |
[email protected] | fdc165a | 2010-09-03 03:51:29 | [diff] [blame] | 3176 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 3177 | CreateMockRead(stream1_reply, 1), |
| 3178 | CreateMockRead(stream2_syn, 2), |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3179 | CreateMockRead(stream3_syn, 4), |
| 3180 | CreateMockRead(stream1_body, 6), |
| 3181 | CreateMockRead(stream2_body, 7), |
| 3182 | MockRead(SYNCHRONOUS, ERR_IO_PENDING, 8), // Force a pause |
[email protected] | fdc165a | 2010-09-03 03:51:29 | [diff] [blame] | 3183 | }; |
| 3184 | |
| 3185 | HttpResponseInfo response; |
| 3186 | HttpResponseInfo response2; |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 3187 | std::string expected_push_result("pushed"); |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 3188 | SequencedSocketData data(reads, writes); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 3189 | RunServerPushTest(&data, |
[email protected] | d0835850 | 2010-12-03 22:04:03 | [diff] [blame] | 3190 | &response, |
| 3191 | &response2, |
| 3192 | expected_push_result); |
[email protected] | fdc165a | 2010-09-03 03:51:29 | [diff] [blame] | 3193 | |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 3194 | // Verify the response headers. |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 3195 | EXPECT_TRUE(response.headers); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 3196 | EXPECT_EQ("HTTP/1.1 200", response.headers->GetStatusLine()); |
[email protected] | fdc165a | 2010-09-03 03:51:29 | [diff] [blame] | 3197 | |
| 3198 | // Verify the pushed stream. |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 3199 | EXPECT_TRUE(response2.headers); |
bnc | cdc749f | 2016-01-27 16:39:04 | [diff] [blame] | 3200 | EXPECT_EQ("HTTP/1.1 200", response2.headers->GetStatusLine()); |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 3201 | |
| 3202 | histogram_tester.ExpectBucketCount( |
| 3203 | "Net.SpdyPushedStreamFate", |
| 3204 | static_cast<int>(SpdyPushedStreamFate::kAcceptedNoVary), 1); |
| 3205 | histogram_tester.ExpectBucketCount( |
| 3206 | "Net.SpdyPushedStreamFate", |
| 3207 | static_cast<int>(SpdyPushedStreamFate::kDuplicateUrl), 1); |
| 3208 | histogram_tester.ExpectTotalCount("Net.SpdyPushedStreamFate", 2); |
[email protected] | fdc165a | 2010-09-03 03:51:29 | [diff] [blame] | 3209 | } |
| 3210 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 3211 | TEST_F(SpdyNetworkTransactionTest, ServerPushMultipleDataFrame) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3212 | spdy::SpdySerializedFrame stream1_syn( |
Bence Béky | 27ad0a1 | 2018-02-08 00:35:48 | [diff] [blame] | 3213 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3214 | spdy::SpdySerializedFrame stream2_priority( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3215 | spdy_util_.ConstructSpdyPriority(2, 1, IDLE, true)); |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 3216 | MockWrite writes[] = { |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3217 | CreateMockWrite(stream1_syn, 0), CreateMockWrite(stream2_priority, 3), |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 3218 | }; |
| 3219 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3220 | spdy::SpdySerializedFrame stream1_reply( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3221 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3222 | spdy::SpdySerializedFrame stream2_syn( |
Bence Béky | d2df6c1c8 | 2018-04-20 22:52:01 | [diff] [blame] | 3223 | spdy_util_.ConstructSpdyPush(nullptr, 0, 2, 1, kPushedUrl)); |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 3224 | static const char kPushedData[] = "pushed payload for chunked test"; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3225 | spdy::SpdySerializedFrame stream2_body_base( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 3226 | spdy_util_.ConstructSpdyDataFrame(2, kPushedData, true)); |
[email protected] | 8a0fc82 | 2013-06-27 20:52:43 | [diff] [blame] | 3227 | const size_t kChunkSize = strlen(kPushedData) / 4; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3228 | spdy::SpdySerializedFrame stream2_body1(stream2_body_base.data(), kChunkSize, |
| 3229 | false); |
| 3230 | spdy::SpdySerializedFrame stream2_body2(stream2_body_base.data() + kChunkSize, |
| 3231 | kChunkSize, false); |
| 3232 | spdy::SpdySerializedFrame stream2_body3( |
| 3233 | stream2_body_base.data() + 2 * kChunkSize, kChunkSize, false); |
| 3234 | spdy::SpdySerializedFrame stream2_body4( |
| 3235 | stream2_body_base.data() + 3 * kChunkSize, |
| 3236 | stream2_body_base.size() - 3 * kChunkSize, false); |
| 3237 | spdy::SpdySerializedFrame stream1_body( |
| 3238 | spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 3239 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 3240 | CreateMockRead(stream1_reply, 1), |
| 3241 | CreateMockRead(stream2_syn, 2), |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3242 | CreateMockRead(stream2_body1, 4), |
| 3243 | CreateMockRead(stream2_body2, 5), |
| 3244 | CreateMockRead(stream2_body3, 6), |
| 3245 | CreateMockRead(stream2_body4, 7), |
| 3246 | CreateMockRead(stream1_body, 8, SYNCHRONOUS), |
| 3247 | MockRead(SYNCHRONOUS, ERR_IO_PENDING, 9), // Force a pause |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 3248 | }; |
| 3249 | |
| 3250 | HttpResponseInfo response; |
| 3251 | HttpResponseInfo response2; |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 3252 | std::string expected_push_result(kPushedData); |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 3253 | SequencedSocketData data(reads, writes); |
[email protected] | 8a0fc82 | 2013-06-27 20:52:43 | [diff] [blame] | 3254 | RunServerPushTest(&data, &response, &response2, kPushedData); |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 3255 | |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 3256 | // Verify the response headers. |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 3257 | EXPECT_TRUE(response.headers); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 3258 | EXPECT_EQ("HTTP/1.1 200", response.headers->GetStatusLine()); |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 3259 | |
| 3260 | // Verify the pushed stream. |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 3261 | EXPECT_TRUE(response2.headers); |
bnc | cdc749f | 2016-01-27 16:39:04 | [diff] [blame] | 3262 | EXPECT_EQ("HTTP/1.1 200", response2.headers->GetStatusLine()); |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 3263 | } |
| 3264 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 3265 | TEST_F(SpdyNetworkTransactionTest, ServerPushMultipleDataFrameInterrupted) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3266 | spdy::SpdySerializedFrame stream1_syn( |
Bence Béky | 27ad0a1 | 2018-02-08 00:35:48 | [diff] [blame] | 3267 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3268 | spdy::SpdySerializedFrame stream2_priority( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3269 | spdy_util_.ConstructSpdyPriority(2, 1, IDLE, true)); |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 3270 | MockWrite writes[] = { |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3271 | CreateMockWrite(stream1_syn, 0), CreateMockWrite(stream2_priority, 3), |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 3272 | }; |
| 3273 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3274 | spdy::SpdySerializedFrame stream1_reply( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3275 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3276 | spdy::SpdySerializedFrame stream2_syn( |
Bence Béky | d2df6c1c8 | 2018-04-20 22:52:01 | [diff] [blame] | 3277 | spdy_util_.ConstructSpdyPush(nullptr, 0, 2, 1, kPushedUrl)); |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 3278 | static const char kPushedData[] = "pushed payload for chunked test"; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3279 | spdy::SpdySerializedFrame stream2_body_base( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 3280 | spdy_util_.ConstructSpdyDataFrame(2, kPushedData, true)); |
[email protected] | 8a0fc82 | 2013-06-27 20:52:43 | [diff] [blame] | 3281 | const size_t kChunkSize = strlen(kPushedData) / 4; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3282 | spdy::SpdySerializedFrame stream2_body1(stream2_body_base.data(), kChunkSize, |
| 3283 | false); |
| 3284 | spdy::SpdySerializedFrame stream2_body2(stream2_body_base.data() + kChunkSize, |
| 3285 | kChunkSize, false); |
| 3286 | spdy::SpdySerializedFrame stream2_body3( |
| 3287 | stream2_body_base.data() + 2 * kChunkSize, kChunkSize, false); |
| 3288 | spdy::SpdySerializedFrame stream2_body4( |
| 3289 | stream2_body_base.data() + 3 * kChunkSize, |
| 3290 | stream2_body_base.size() - 3 * kChunkSize, false); |
| 3291 | spdy::SpdySerializedFrame stream1_body( |
| 3292 | spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 3293 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 3294 | CreateMockRead(stream1_reply, 1), |
| 3295 | CreateMockRead(stream2_syn, 2), |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3296 | CreateMockRead(stream2_body1, 4), |
| 3297 | CreateMockRead(stream2_body2, 5), |
| 3298 | CreateMockRead(stream2_body3, 6), |
| 3299 | CreateMockRead(stream2_body4, 7), |
| 3300 | CreateMockRead(stream1_body, 8, SYNCHRONOUS), |
| 3301 | MockRead(SYNCHRONOUS, ERR_IO_PENDING, 9) // Force a pause. |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 3302 | }; |
| 3303 | |
| 3304 | HttpResponseInfo response; |
| 3305 | HttpResponseInfo response2; |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 3306 | SequencedSocketData data(reads, writes); |
[email protected] | 8a0fc82 | 2013-06-27 20:52:43 | [diff] [blame] | 3307 | RunServerPushTest(&data, &response, &response2, kPushedData); |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 3308 | |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 3309 | // Verify the response headers. |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 3310 | EXPECT_TRUE(response.headers); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 3311 | EXPECT_EQ("HTTP/1.1 200", response.headers->GetStatusLine()); |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 3312 | |
| 3313 | // Verify the pushed stream. |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 3314 | EXPECT_TRUE(response2.headers); |
bnc | cdc749f | 2016-01-27 16:39:04 | [diff] [blame] | 3315 | EXPECT_EQ("HTTP/1.1 200", response2.headers->GetStatusLine()); |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 3316 | } |
| 3317 | |
morlovich | ab1d1c1e | 2017-02-07 19:59:28 | [diff] [blame] | 3318 | TEST_F(SpdyNetworkTransactionTest, ServerPushInvalidUrl) { |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 3319 | base::HistogramTester histogram_tester; |
| 3320 | |
morlovich | ab1d1c1e | 2017-02-07 19:59:28 | [diff] [blame] | 3321 | // Coverage on how a non-empty invalid GURL in a PUSH_PROMISE is handled. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3322 | spdy::SpdyHeaderBlock headers( |
| 3323 | spdy_util_.ConstructGetHeaderBlock(kDefaultUrl)); |
| 3324 | spdy::SpdySerializedFrame req( |
morlovich | ab1d1c1e | 2017-02-07 19:59:28 | [diff] [blame] | 3325 | spdy_util_.ConstructSpdyHeaders(1, std::move(headers), LOWEST, true)); |
| 3326 | |
| 3327 | // Can't use ConstructSpdyPush here since it wants to parse a URL and |
| 3328 | // split it into the appropriate :header pieces. So we have to hand-fill |
| 3329 | // those pieces in. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3330 | spdy::SpdyHeaderBlock push_promise_header_block; |
| 3331 | push_promise_header_block[spdy::kHttp2AuthorityHeader] = ""; |
| 3332 | push_promise_header_block[spdy::kHttp2SchemeHeader] = ""; |
| 3333 | push_promise_header_block[spdy::kHttp2PathHeader] = "/index.html"; |
morlovich | ab1d1c1e | 2017-02-07 19:59:28 | [diff] [blame] | 3334 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3335 | spdy::SpdySerializedFrame push_promise(spdy_util_.ConstructSpdyPushPromise( |
Bence Béky | f1d7852 | 2018-01-11 01:16:50 | [diff] [blame] | 3336 | 1, 2, std::move(push_promise_header_block))); |
morlovich | ab1d1c1e | 2017-02-07 19:59:28 | [diff] [blame] | 3337 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3338 | spdy::SpdySerializedFrame stream2_rst( |
| 3339 | spdy_util_.ConstructSpdyRstStream(2, spdy::ERROR_CODE_REFUSED_STREAM)); |
morlovich | ab1d1c1e | 2017-02-07 19:59:28 | [diff] [blame] | 3340 | |
| 3341 | MockWrite writes[] = {CreateMockWrite(req, 0), |
| 3342 | CreateMockWrite(stream2_rst, 2)}; |
| 3343 | MockRead reads[] = { |
Bence Béky | f1d7852 | 2018-01-11 01:16:50 | [diff] [blame] | 3344 | CreateMockRead(push_promise, 1), MockRead(ASYNC, 0, 3) /* EOF */ |
morlovich | ab1d1c1e | 2017-02-07 19:59:28 | [diff] [blame] | 3345 | }; |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 3346 | SequencedSocketData data(reads, writes); |
morlovich | ab1d1c1e | 2017-02-07 19:59:28 | [diff] [blame] | 3347 | RunBrokenPushTest(&data, ERR_CONNECTION_CLOSED); |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 3348 | |
| 3349 | histogram_tester.ExpectBucketCount( |
| 3350 | "Net.SpdyPushedStreamFate", |
| 3351 | static_cast<int>(SpdyPushedStreamFate::kInvalidUrl), 1); |
| 3352 | histogram_tester.ExpectTotalCount("Net.SpdyPushedStreamFate", 1); |
morlovich | ab1d1c1e | 2017-02-07 19:59:28 | [diff] [blame] | 3353 | } |
| 3354 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 3355 | TEST_F(SpdyNetworkTransactionTest, ServerPushInvalidAssociatedStreamID0) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3356 | spdy::SpdySerializedFrame stream1_syn( |
Bence Béky | 27ad0a1 | 2018-02-08 00:35:48 | [diff] [blame] | 3357 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3358 | spdy::SpdySerializedFrame goaway( |
| 3359 | spdy_util_.ConstructSpdyGoAway(0, spdy::ERROR_CODE_PROTOCOL_ERROR, |
| 3360 | "Framer error: 1 (INVALID_STREAM_ID).")); |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 3361 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 3362 | CreateMockWrite(stream1_syn, 0), CreateMockWrite(goaway, 3), |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 3363 | }; |
| 3364 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3365 | spdy::SpdySerializedFrame stream1_reply( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3366 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3367 | spdy::SpdySerializedFrame stream2_syn( |
Bence Béky | d2df6c1c8 | 2018-04-20 22:52:01 | [diff] [blame] | 3368 | spdy_util_.ConstructSpdyPush(nullptr, 0, 2, 0, kPushedUrl)); |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 3369 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 3370 | CreateMockRead(stream1_reply, 1), CreateMockRead(stream2_syn, 2), |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 3371 | }; |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 3372 | SequencedSocketData data(reads, writes); |
morlovich | ab1d1c1e | 2017-02-07 19:59:28 | [diff] [blame] | 3373 | RunBrokenPushTest(&data, OK); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 3374 | } |
| 3375 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 3376 | TEST_F(SpdyNetworkTransactionTest, ServerPushInvalidAssociatedStreamID9) { |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 3377 | base::HistogramTester histogram_tester; |
| 3378 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3379 | spdy::SpdySerializedFrame stream1_syn( |
Bence Béky | 27ad0a1 | 2018-02-08 00:35:48 | [diff] [blame] | 3380 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3381 | spdy::SpdySerializedFrame stream1_body( |
| 3382 | spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 3383 | spdy::SpdySerializedFrame stream2_rst( |
| 3384 | spdy_util_.ConstructSpdyRstStream(2, spdy::ERROR_CODE_STREAM_CLOSED)); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 3385 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 3386 | CreateMockWrite(stream1_syn, 0), CreateMockWrite(stream2_rst, 3), |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 3387 | }; |
| 3388 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3389 | spdy::SpdySerializedFrame stream1_reply( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3390 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3391 | spdy::SpdySerializedFrame stream2_syn( |
Bence Béky | d2df6c1c8 | 2018-04-20 22:52:01 | [diff] [blame] | 3392 | spdy_util_.ConstructSpdyPush(nullptr, 0, 2, 9, kPushedUrl)); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 3393 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 3394 | CreateMockRead(stream1_reply, 1), CreateMockRead(stream2_syn, 2), |
| 3395 | CreateMockRead(stream1_body, 4), |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 3396 | MockRead(SYNCHRONOUS, ERR_IO_PENDING, 5), // Force a pause |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 3397 | }; |
| 3398 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 3399 | SequencedSocketData data(reads, writes); |
morlovich | ab1d1c1e | 2017-02-07 19:59:28 | [diff] [blame] | 3400 | RunBrokenPushTest(&data, OK); |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 3401 | |
| 3402 | histogram_tester.ExpectBucketCount( |
| 3403 | "Net.SpdyPushedStreamFate", |
| 3404 | static_cast<int>(SpdyPushedStreamFate::kInactiveAssociatedStream), 1); |
| 3405 | histogram_tester.ExpectTotalCount("Net.SpdyPushedStreamFate", 1); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 3406 | } |
| 3407 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 3408 | TEST_F(SpdyNetworkTransactionTest, ServerPushNoURL) { |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 3409 | base::HistogramTester histogram_tester; |
| 3410 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3411 | spdy::SpdySerializedFrame stream1_syn( |
Bence Béky | 27ad0a1 | 2018-02-08 00:35:48 | [diff] [blame] | 3412 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3413 | spdy::SpdySerializedFrame stream1_body( |
| 3414 | spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 3415 | spdy::SpdySerializedFrame stream2_rst( |
| 3416 | spdy_util_.ConstructSpdyRstStream(2, spdy::ERROR_CODE_REFUSED_STREAM)); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 3417 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 3418 | CreateMockWrite(stream1_syn, 0), CreateMockWrite(stream2_rst, 3), |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 3419 | }; |
| 3420 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3421 | spdy::SpdySerializedFrame stream1_reply( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3422 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3423 | spdy::SpdyHeaderBlock incomplete_headers; |
| 3424 | incomplete_headers[spdy::kHttp2StatusHeader] = "200 OK"; |
bnc | 086b39e1 | 2016-06-24 13:05:26 | [diff] [blame] | 3425 | incomplete_headers["hello"] = "bye"; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3426 | spdy::SpdySerializedFrame stream2_syn( |
Bence Béky | f1d7852 | 2018-01-11 01:16:50 | [diff] [blame] | 3427 | spdy_util_.ConstructSpdyPushPromise(1, 2, std::move(incomplete_headers))); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 3428 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 3429 | CreateMockRead(stream1_reply, 1), CreateMockRead(stream2_syn, 2), |
| 3430 | CreateMockRead(stream1_body, 4), |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 3431 | MockRead(SYNCHRONOUS, ERR_IO_PENDING, 5) // Force a pause |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 3432 | }; |
| 3433 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 3434 | SequencedSocketData data(reads, writes); |
morlovich | ab1d1c1e | 2017-02-07 19:59:28 | [diff] [blame] | 3435 | RunBrokenPushTest(&data, OK); |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 3436 | |
| 3437 | histogram_tester.ExpectBucketCount( |
| 3438 | "Net.SpdyPushedStreamFate", |
| 3439 | static_cast<int>(SpdyPushedStreamFate::kInvalidUrl), 1); |
| 3440 | histogram_tester.ExpectTotalCount("Net.SpdyPushedStreamFate", 1); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 3441 | } |
| 3442 | |
bnc | 0cb98b2 | 2016-03-04 17:10:52 | [diff] [blame] | 3443 | // PUSH_PROMISE on a server-initiated stream should trigger GOAWAY. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 3444 | TEST_F(SpdyNetworkTransactionTest, ServerPushOnPushedStream) { |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 3445 | base::HistogramTester histogram_tester; |
| 3446 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3447 | spdy::SpdySerializedFrame stream1_syn( |
Bence Béky | 27ad0a1 | 2018-02-08 00:35:48 | [diff] [blame] | 3448 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3449 | spdy::SpdySerializedFrame stream2_priority( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3450 | spdy_util_.ConstructSpdyPriority(2, 1, IDLE, true)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3451 | spdy::SpdySerializedFrame goaway(spdy_util_.ConstructSpdyGoAway( |
| 3452 | 2, spdy::ERROR_CODE_PROTOCOL_ERROR, |
Bence Béky | 602c40c | 2017-07-26 05:22:56 | [diff] [blame] | 3453 | "Received pushed stream id 4 on invalid stream id 2 (must be odd).")); |
bnc | 0cb98b2 | 2016-03-04 17:10:52 | [diff] [blame] | 3454 | MockWrite writes[] = { |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3455 | CreateMockWrite(stream1_syn, 0), CreateMockWrite(stream2_priority, 3), |
| 3456 | CreateMockWrite(goaway, 5), |
bnc | 0cb98b2 | 2016-03-04 17:10:52 | [diff] [blame] | 3457 | }; |
| 3458 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3459 | spdy::SpdySerializedFrame stream1_reply( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3460 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3461 | spdy::SpdySerializedFrame stream2_syn( |
Bence Béky | d2df6c1c8 | 2018-04-20 22:52:01 | [diff] [blame] | 3462 | spdy_util_.ConstructSpdyPush(nullptr, 0, 2, 1, kPushedUrl)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3463 | spdy::SpdySerializedFrame stream3_syn(spdy_util_.ConstructSpdyPush( |
Bence Béky | 3e01b53 | 2018-02-06 23:04:51 | [diff] [blame] | 3464 | nullptr, 0, 4, 2, "https://www.example.org/bar.dat")); |
bnc | 0cb98b2 | 2016-03-04 17:10:52 | [diff] [blame] | 3465 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 3466 | CreateMockRead(stream1_reply, 1), CreateMockRead(stream2_syn, 2), |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3467 | CreateMockRead(stream3_syn, 4), |
bnc | 0cb98b2 | 2016-03-04 17:10:52 | [diff] [blame] | 3468 | }; |
| 3469 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 3470 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 3471 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
bnc | 0cb98b2 | 2016-03-04 17:10:52 | [diff] [blame] | 3472 | helper.RunToCompletion(&data); |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 3473 | |
| 3474 | histogram_tester.ExpectBucketCount( |
| 3475 | "Net.SpdyPushedStreamFate", |
| 3476 | static_cast<int>(SpdyPushedStreamFate::kAssociatedStreamIdParityError), |
| 3477 | 1); |
| 3478 | histogram_tester.ExpectTotalCount("Net.SpdyPushedStreamFate", 1); |
bnc | 0cb98b2 | 2016-03-04 17:10:52 | [diff] [blame] | 3479 | } |
| 3480 | |
| 3481 | // PUSH_PROMISE on a closed client-initiated stream should trigger RST_STREAM. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 3482 | TEST_F(SpdyNetworkTransactionTest, ServerPushOnClosedStream) { |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 3483 | base::HistogramTester histogram_tester; |
| 3484 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3485 | spdy::SpdySerializedFrame stream1_syn( |
Bence Béky | 27ad0a1 | 2018-02-08 00:35:48 | [diff] [blame] | 3486 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3487 | spdy::SpdySerializedFrame rst( |
| 3488 | spdy_util_.ConstructSpdyRstStream(2, spdy::ERROR_CODE_STREAM_CLOSED)); |
bnc | 0cb98b2 | 2016-03-04 17:10:52 | [diff] [blame] | 3489 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 3490 | CreateMockWrite(stream1_syn, 0), CreateMockWrite(rst, 5), |
bnc | 0cb98b2 | 2016-03-04 17:10:52 | [diff] [blame] | 3491 | }; |
| 3492 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3493 | spdy::SpdySerializedFrame stream1_reply( |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 3494 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3495 | spdy::SpdySerializedFrame stream1_body( |
| 3496 | spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 3497 | spdy::SpdySerializedFrame stream2_syn( |
Bence Béky | d2df6c1c8 | 2018-04-20 22:52:01 | [diff] [blame] | 3498 | spdy_util_.ConstructSpdyPush(nullptr, 0, 2, 1, kPushedUrl)); |
bnc | 0cb98b2 | 2016-03-04 17:10:52 | [diff] [blame] | 3499 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 3500 | CreateMockRead(stream1_reply, 1), CreateMockRead(stream1_body, 2), |
| 3501 | CreateMockRead(stream2_syn, 3), MockRead(SYNCHRONOUS, ERR_IO_PENDING, 4), |
bnc | 0cb98b2 | 2016-03-04 17:10:52 | [diff] [blame] | 3502 | }; |
| 3503 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 3504 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 3505 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
bnc | 0cb98b2 | 2016-03-04 17:10:52 | [diff] [blame] | 3506 | helper.RunPreTestSetup(); |
| 3507 | helper.AddData(&data); |
| 3508 | |
| 3509 | HttpNetworkTransaction* trans = helper.trans(); |
| 3510 | |
| 3511 | TestCompletionCallback callback; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 3512 | int rv = trans->Start(&request_, callback.callback(), log_); |
bnc | 0cb98b2 | 2016-03-04 17:10:52 | [diff] [blame] | 3513 | rv = callback.GetResult(rv); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 3514 | EXPECT_THAT(rv, IsOk()); |
bnc | eb9aa711 | 2017-01-05 01:03:46 | [diff] [blame] | 3515 | |
| 3516 | // Finish async network reads/writes. |
| 3517 | base::RunLoop().RunUntilIdle(); |
| 3518 | |
bnc | 0cb98b2 | 2016-03-04 17:10:52 | [diff] [blame] | 3519 | HttpResponseInfo response = *trans->GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 3520 | EXPECT_TRUE(response.headers); |
bnc | 0cb98b2 | 2016-03-04 17:10:52 | [diff] [blame] | 3521 | EXPECT_EQ("HTTP/1.1 200", response.headers->GetStatusLine()); |
| 3522 | |
| 3523 | EXPECT_TRUE(data.AllReadDataConsumed()); |
| 3524 | EXPECT_TRUE(data.AllWriteDataConsumed()); |
| 3525 | VerifyStreamsClosed(helper); |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 3526 | |
| 3527 | histogram_tester.ExpectBucketCount( |
| 3528 | "Net.SpdyPushedStreamFate", |
| 3529 | static_cast<int>(SpdyPushedStreamFate::kInactiveAssociatedStream), 1); |
| 3530 | histogram_tester.ExpectTotalCount("Net.SpdyPushedStreamFate", 1); |
bnc | 0cb98b2 | 2016-03-04 17:10:52 | [diff] [blame] | 3531 | } |
| 3532 | |
| 3533 | // PUSH_PROMISE on a server-initiated stream should trigger GOAWAY even if |
| 3534 | // stream is closed. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 3535 | TEST_F(SpdyNetworkTransactionTest, ServerPushOnClosedPushedStream) { |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 3536 | base::HistogramTester histogram_tester; |
| 3537 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3538 | spdy::SpdySerializedFrame stream1_syn( |
Bence Béky | 27ad0a1 | 2018-02-08 00:35:48 | [diff] [blame] | 3539 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3540 | spdy::SpdySerializedFrame stream2_priority( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3541 | spdy_util_.ConstructSpdyPriority(2, 1, IDLE, true)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3542 | spdy::SpdySerializedFrame goaway(spdy_util_.ConstructSpdyGoAway( |
| 3543 | 2, spdy::ERROR_CODE_PROTOCOL_ERROR, |
Bence Béky | 602c40c | 2017-07-26 05:22:56 | [diff] [blame] | 3544 | "Received pushed stream id 4 on invalid stream id 2 (must be odd).")); |
Bence Béky | 7bf9436 | 2018-01-10 13:19:36 | [diff] [blame] | 3545 | MockWrite writes[] = {CreateMockWrite(stream1_syn, 0), |
| 3546 | CreateMockWrite(stream2_priority, 3), |
| 3547 | CreateMockWrite(goaway, 8)}; |
bnc | 0cb98b2 | 2016-03-04 17:10:52 | [diff] [blame] | 3548 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3549 | spdy::SpdySerializedFrame stream2_syn( |
Bence Béky | d2df6c1c8 | 2018-04-20 22:52:01 | [diff] [blame] | 3550 | spdy_util_.ConstructSpdyPush(nullptr, 0, 2, 1, kPushedUrl)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3551 | spdy::SpdySerializedFrame stream1_reply( |
Bence Béky | 7bf9436 | 2018-01-10 13:19:36 | [diff] [blame] | 3552 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3553 | spdy::SpdySerializedFrame stream1_body( |
| 3554 | spdy_util_.ConstructSpdyDataFrame(1, true)); |
bnc | 0cb98b2 | 2016-03-04 17:10:52 | [diff] [blame] | 3555 | const char kPushedData[] = "pushed"; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3556 | spdy::SpdySerializedFrame stream2_body( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 3557 | spdy_util_.ConstructSpdyDataFrame(2, kPushedData, true)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3558 | spdy::SpdySerializedFrame stream3_syn(spdy_util_.ConstructSpdyPush( |
Bence Béky | 3e01b53 | 2018-02-06 23:04:51 | [diff] [blame] | 3559 | nullptr, 0, 4, 2, "https://www.example.org/bar.dat")); |
bnc | 0cb98b2 | 2016-03-04 17:10:52 | [diff] [blame] | 3560 | |
| 3561 | MockRead reads[] = { |
Bence Béky | 7bf9436 | 2018-01-10 13:19:36 | [diff] [blame] | 3562 | CreateMockRead(stream2_syn, 1), CreateMockRead(stream1_reply, 2), |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3563 | CreateMockRead(stream1_body, 4), CreateMockRead(stream2_body, 5), |
Bence Béky | 7bf9436 | 2018-01-10 13:19:36 | [diff] [blame] | 3564 | MockRead(ASYNC, ERR_IO_PENDING, 6), CreateMockRead(stream3_syn, 7)}; |
bnc | 0cb98b2 | 2016-03-04 17:10:52 | [diff] [blame] | 3565 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 3566 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 3567 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
bnc | 0cb98b2 | 2016-03-04 17:10:52 | [diff] [blame] | 3568 | helper.RunPreTestSetup(); |
| 3569 | helper.AddData(&data); |
| 3570 | |
| 3571 | HttpNetworkTransaction* trans1 = helper.trans(); |
| 3572 | TestCompletionCallback callback1; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 3573 | int rv = trans1->Start(&request_, callback1.callback(), log_); |
bnc | 0cb98b2 | 2016-03-04 17:10:52 | [diff] [blame] | 3574 | rv = callback1.GetResult(rv); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 3575 | EXPECT_THAT(rv, IsOk()); |
bnc | 0cb98b2 | 2016-03-04 17:10:52 | [diff] [blame] | 3576 | HttpResponseInfo response = *trans1->GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 3577 | EXPECT_TRUE(response.headers); |
bnc | 0cb98b2 | 2016-03-04 17:10:52 | [diff] [blame] | 3578 | EXPECT_EQ("HTTP/1.1 200", response.headers->GetStatusLine()); |
| 3579 | |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 3580 | HttpNetworkTransaction trans2(DEFAULT_PRIORITY, helper.session()); |
bnc | 0cb98b2 | 2016-03-04 17:10:52 | [diff] [blame] | 3581 | TestCompletionCallback callback2; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 3582 | HttpRequestInfo request = CreateGetPushRequest(); |
| 3583 | rv = trans2.Start(&request, callback2.callback(), log_); |
bnc | 0cb98b2 | 2016-03-04 17:10:52 | [diff] [blame] | 3584 | rv = callback2.GetResult(rv); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 3585 | EXPECT_THAT(rv, IsOk()); |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 3586 | response = *trans2.GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 3587 | EXPECT_TRUE(response.headers); |
bnc | 0cb98b2 | 2016-03-04 17:10:52 | [diff] [blame] | 3588 | EXPECT_EQ("HTTP/1.1 200", response.headers->GetStatusLine()); |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 3589 | std::string result; |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 3590 | ReadResult(&trans2, &result); |
bnc | 0cb98b2 | 2016-03-04 17:10:52 | [diff] [blame] | 3591 | EXPECT_EQ(kPushedData, result); |
| 3592 | |
| 3593 | data.Resume(); |
| 3594 | base::RunLoop().RunUntilIdle(); |
| 3595 | |
| 3596 | EXPECT_TRUE(data.AllReadDataConsumed()); |
| 3597 | EXPECT_TRUE(data.AllWriteDataConsumed()); |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 3598 | |
| 3599 | histogram_tester.ExpectBucketCount( |
| 3600 | "Net.SpdyPushedStreamFate", |
| 3601 | static_cast<int>(SpdyPushedStreamFate::kAssociatedStreamIdParityError), |
| 3602 | 1); |
| 3603 | histogram_tester.ExpectBucketCount( |
| 3604 | "Net.SpdyPushedStreamFate", |
| 3605 | static_cast<int>(SpdyPushedStreamFate::kAcceptedNoVary), 1); |
| 3606 | histogram_tester.ExpectTotalCount("Net.SpdyPushedStreamFate", 2); |
bnc | 0cb98b2 | 2016-03-04 17:10:52 | [diff] [blame] | 3607 | } |
| 3608 | |
Bence Béky | e8955cf2 | 2018-01-02 17:31:29 | [diff] [blame] | 3609 | TEST_F(SpdyNetworkTransactionTest, ServerCancelsPush) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3610 | spdy::SpdySerializedFrame req1( |
| 3611 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 3612 | spdy::SpdySerializedFrame priority( |
Bence Béky | e8955cf2 | 2018-01-02 17:31:29 | [diff] [blame] | 3613 | spdy_util_.ConstructSpdyPriority(2, 1, IDLE, true)); |
Bence Béky | 1a5d856 | 2018-01-05 17:29:28 | [diff] [blame] | 3614 | spdy_util_.UpdateWithStreamDestruction(1); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3615 | spdy::SpdySerializedFrame req2( |
| 3616 | spdy_util_.ConstructSpdyGet(kPushedUrl, 3, LOWEST)); |
Bence Béky | 1a5d856 | 2018-01-05 17:29:28 | [diff] [blame] | 3617 | MockWrite writes1[] = {CreateMockWrite(req1, 0), CreateMockWrite(priority, 3), |
| 3618 | CreateMockWrite(req2, 6)}; |
Bence Béky | e8955cf2 | 2018-01-02 17:31:29 | [diff] [blame] | 3619 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3620 | spdy::SpdySerializedFrame reply1( |
| 3621 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 3622 | spdy::SpdySerializedFrame push( |
Bence Béky | d2df6c1c8 | 2018-04-20 22:52:01 | [diff] [blame] | 3623 | spdy_util_.ConstructSpdyPush(nullptr, 0, 2, 1, kPushedUrl)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3624 | spdy::SpdySerializedFrame body1(spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 3625 | spdy::SpdySerializedFrame rst( |
| 3626 | spdy_util_.ConstructSpdyRstStream(2, spdy::ERROR_CODE_INTERNAL_ERROR)); |
| 3627 | spdy::SpdySerializedFrame reply2( |
| 3628 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 3)); |
| 3629 | spdy::SpdySerializedFrame body2(spdy_util_.ConstructSpdyDataFrame(3, true)); |
Bence Béky | 1a5d856 | 2018-01-05 17:29:28 | [diff] [blame] | 3630 | MockRead reads1[] = {CreateMockRead(reply1, 1), CreateMockRead(push, 2), |
| 3631 | CreateMockRead(body1, 4), CreateMockRead(rst, 5), |
| 3632 | CreateMockRead(reply2, 7), CreateMockRead(body2, 8), |
| 3633 | MockRead(ASYNC, 0, 9)}; |
Bence Béky | e8955cf2 | 2018-01-02 17:31:29 | [diff] [blame] | 3634 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 3635 | SequencedSocketData data(reads1, writes1); |
Bence Béky | e8955cf2 | 2018-01-02 17:31:29 | [diff] [blame] | 3636 | |
| 3637 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
| 3638 | helper.RunPreTestSetup(); |
| 3639 | helper.AddData(&data); |
| 3640 | |
Bence Béky | 1a5d856 | 2018-01-05 17:29:28 | [diff] [blame] | 3641 | // First request opens up connection. |
Bence Béky | e8955cf2 | 2018-01-02 17:31:29 | [diff] [blame] | 3642 | HttpNetworkTransaction* trans1 = helper.trans(); |
| 3643 | TestCompletionCallback callback1; |
| 3644 | int rv = trans1->Start(&request_, callback1.callback(), log_); |
| 3645 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 3646 | |
| 3647 | // Read until response body arrives. PUSH_PROMISE comes earlier. |
| 3648 | rv = callback1.WaitForResult(); |
| 3649 | EXPECT_THAT(rv, IsOk()); |
Bence Béky | 1a5d856 | 2018-01-05 17:29:28 | [diff] [blame] | 3650 | const HttpResponseInfo* response = trans1->GetResponseInfo(); |
| 3651 | EXPECT_TRUE(response->headers); |
| 3652 | EXPECT_EQ("HTTP/1.1 200", response->headers->GetStatusLine()); |
| 3653 | std::string result1; |
| 3654 | ReadResult(trans1, &result1); |
| 3655 | EXPECT_EQ("hello!", result1); |
| 3656 | |
| 3657 | SpdySessionPool* spdy_session_pool = helper.session()->spdy_session_pool(); |
| 3658 | SpdySessionKey key(host_port_pair_, ProxyServer::Direct(), |
Matt Menke | 2436b2f | 2018-12-11 18:07:11 | [diff] [blame] | 3659 | PRIVACY_MODE_DISABLED, |
| 3660 | SpdySessionKey::IsProxySession::kFalse, SocketTag()); |
Bence Béky | 1a5d856 | 2018-01-05 17:29:28 | [diff] [blame] | 3661 | base::WeakPtr<SpdySession> spdy_session = |
| 3662 | spdy_session_pool->FindAvailableSession( |
Bence Béky | d885b2b | 2018-02-03 00:58:31 | [diff] [blame] | 3663 | key, /* enable_ip_based_pooling = */ true, |
| 3664 | /* is_websocket = */ false, log_); |
Bence Béky | 1a5d856 | 2018-01-05 17:29:28 | [diff] [blame] | 3665 | EXPECT_EQ(1u, num_unclaimed_pushed_streams(spdy_session)); |
Bence Béky | e8955cf2 | 2018-01-02 17:31:29 | [diff] [blame] | 3666 | |
| 3667 | // Create request matching pushed stream. |
Bence Béky | e8955cf2 | 2018-01-02 17:31:29 | [diff] [blame] | 3668 | HttpNetworkTransaction trans2(DEFAULT_PRIORITY, helper.session()); |
Bence Béky | 1a5d856 | 2018-01-05 17:29:28 | [diff] [blame] | 3669 | HttpRequestInfo request2 = CreateGetPushRequest(); |
Bence Béky | e8955cf2 | 2018-01-02 17:31:29 | [diff] [blame] | 3670 | TestCompletionCallback callback2; |
Bence Béky | 1a5d856 | 2018-01-05 17:29:28 | [diff] [blame] | 3671 | rv = trans2.Start(&request2, callback2.callback(), log_); |
Bence Béky | e8955cf2 | 2018-01-02 17:31:29 | [diff] [blame] | 3672 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 3673 | |
Bence Béky | 1a5d856 | 2018-01-05 17:29:28 | [diff] [blame] | 3674 | // Pushed stream is now claimed by second request. |
| 3675 | EXPECT_EQ(0u, num_unclaimed_pushed_streams(spdy_session)); |
| 3676 | |
| 3677 | // Second request receives RST_STREAM and is retried on the same connection. |
Bence Béky | e8955cf2 | 2018-01-02 17:31:29 | [diff] [blame] | 3678 | rv = callback2.WaitForResult(); |
Bence Béky | 1a5d856 | 2018-01-05 17:29:28 | [diff] [blame] | 3679 | EXPECT_THAT(rv, IsOk()); |
| 3680 | response = trans2.GetResponseInfo(); |
| 3681 | EXPECT_TRUE(response->headers); |
| 3682 | EXPECT_EQ("HTTP/1.1 200", response->headers->GetStatusLine()); |
| 3683 | std::string result2; |
| 3684 | ReadResult(&trans2, &result2); |
| 3685 | EXPECT_EQ("hello!", result2); |
Bence Béky | e8955cf2 | 2018-01-02 17:31:29 | [diff] [blame] | 3686 | |
| 3687 | // Read EOF. |
| 3688 | base::RunLoop().RunUntilIdle(); |
| 3689 | |
Bence Béky | 1a5d856 | 2018-01-05 17:29:28 | [diff] [blame] | 3690 | helper.VerifyDataConsumed(); |
| 3691 | } |
| 3692 | |
| 3693 | // Regression test for https://crbug.com/776415. |
| 3694 | // A client-initiated request can only pool to an existing HTTP/2 connection if |
| 3695 | // the IP address matches. However, a resource can be pushed by the server on a |
| 3696 | // connection even if the IP address does not match. This test verifies that if |
| 3697 | // the request binds to such a pushed stream, and after that the server resets |
| 3698 | // the stream before SpdySession::GetPushedStream() is called, then the retry |
| 3699 | // (using a client-initiated stream) does not pool to this connection. |
| 3700 | TEST_F(SpdyNetworkTransactionTest, ServerCancelsCrossOriginPush) { |
| 3701 | const char* kUrl1 = "https://www.example.org"; |
| 3702 | const char* kUrl2 = "https://mail.example.org"; |
| 3703 | |
| 3704 | auto resolver = std::make_unique<MockHostResolver>(); |
| 3705 | resolver->rules()->ClearRules(); |
| 3706 | resolver->rules()->AddRule("www.example.org", "127.0.0.1"); |
| 3707 | resolver->rules()->AddRule("mail.example.org", "127.0.0.2"); |
| 3708 | |
| 3709 | auto session_deps = std::make_unique<SpdySessionDependencies>(); |
| 3710 | session_deps->host_resolver = std::move(resolver); |
| 3711 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
| 3712 | std::move(session_deps)); |
| 3713 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3714 | spdy::SpdySerializedFrame req1(spdy_util_.ConstructSpdyGet(kUrl1, 1, LOWEST)); |
| 3715 | spdy::SpdySerializedFrame priority( |
Bence Béky | 1a5d856 | 2018-01-05 17:29:28 | [diff] [blame] | 3716 | spdy_util_.ConstructSpdyPriority(2, 1, IDLE, true)); |
| 3717 | MockWrite writes1[] = {CreateMockWrite(req1, 0), |
| 3718 | CreateMockWrite(priority, 3)}; |
| 3719 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3720 | spdy::SpdySerializedFrame reply1( |
| 3721 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 3722 | spdy::SpdySerializedFrame push( |
Bence Béky | 1a5d856 | 2018-01-05 17:29:28 | [diff] [blame] | 3723 | spdy_util_.ConstructSpdyPush(nullptr, 0, 2, 1, kUrl2)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3724 | spdy::SpdySerializedFrame body1(spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 3725 | spdy::SpdySerializedFrame rst( |
| 3726 | spdy_util_.ConstructSpdyRstStream(2, spdy::ERROR_CODE_INTERNAL_ERROR)); |
Bence Béky | 1a5d856 | 2018-01-05 17:29:28 | [diff] [blame] | 3727 | MockRead reads1[] = { |
| 3728 | CreateMockRead(reply1, 1), CreateMockRead(push, 2), |
| 3729 | CreateMockRead(body1, 4), CreateMockRead(rst, 5), |
| 3730 | MockRead(ASYNC, ERR_IO_PENDING, 6), MockRead(ASYNC, 0, 7)}; |
| 3731 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 3732 | SequencedSocketData data1(reads1, writes1); |
Bence Béky | 1a5d856 | 2018-01-05 17:29:28 | [diff] [blame] | 3733 | |
| 3734 | SpdyTestUtil spdy_util2; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3735 | spdy::SpdySerializedFrame req2(spdy_util2.ConstructSpdyGet(kUrl2, 1, LOWEST)); |
Bence Béky | 1a5d856 | 2018-01-05 17:29:28 | [diff] [blame] | 3736 | MockWrite writes2[] = {CreateMockWrite(req2, 0)}; |
| 3737 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3738 | spdy::SpdySerializedFrame reply2( |
| 3739 | spdy_util2.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 3740 | spdy::SpdySerializedFrame body2(spdy_util2.ConstructSpdyDataFrame( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 3741 | 1, "Response on the second connection.", true)); |
Bence Béky | 1a5d856 | 2018-01-05 17:29:28 | [diff] [blame] | 3742 | MockRead reads2[] = {CreateMockRead(reply2, 1), CreateMockRead(body2, 2), |
| 3743 | MockRead(ASYNC, 0, 3)}; |
| 3744 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 3745 | SequencedSocketData data2(reads2, writes2); |
Bence Béky | 1a5d856 | 2018-01-05 17:29:28 | [diff] [blame] | 3746 | |
| 3747 | helper.RunPreTestSetup(); |
| 3748 | helper.AddData(&data1); |
| 3749 | helper.AddData(&data2); |
| 3750 | |
| 3751 | // First request opens up connection to www.example.org. |
| 3752 | HttpNetworkTransaction* trans1 = helper.trans(); |
| 3753 | HttpRequestInfo request1; |
| 3754 | request1.method = "GET"; |
| 3755 | request1.url = GURL(kUrl1); |
Ramin Halavati | b5e433e6 | 2018-02-07 07:41:10 | [diff] [blame] | 3756 | request1.traffic_annotation = |
| 3757 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
Bence Béky | 1a5d856 | 2018-01-05 17:29:28 | [diff] [blame] | 3758 | TestCompletionCallback callback1; |
| 3759 | int rv = trans1->Start(&request1, callback1.callback(), log_); |
| 3760 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 3761 | |
| 3762 | // Read until response body arrives. PUSH_PROMISE comes earlier. |
| 3763 | rv = callback1.WaitForResult(); |
| 3764 | EXPECT_THAT(rv, IsOk()); |
| 3765 | const HttpResponseInfo* response = trans1->GetResponseInfo(); |
| 3766 | EXPECT_TRUE(response->headers); |
| 3767 | EXPECT_EQ("HTTP/1.1 200", response->headers->GetStatusLine()); |
| 3768 | std::string result1; |
| 3769 | ReadResult(trans1, &result1); |
| 3770 | EXPECT_EQ("hello!", result1); |
| 3771 | |
| 3772 | SpdySessionPool* spdy_session_pool = helper.session()->spdy_session_pool(); |
| 3773 | SpdySessionKey key1(HostPortPair::FromURL(GURL(kUrl1)), ProxyServer::Direct(), |
Matt Menke | 2436b2f | 2018-12-11 18:07:11 | [diff] [blame] | 3774 | PRIVACY_MODE_DISABLED, |
| 3775 | SpdySessionKey::IsProxySession::kFalse, SocketTag()); |
Bence Béky | 1a5d856 | 2018-01-05 17:29:28 | [diff] [blame] | 3776 | base::WeakPtr<SpdySession> spdy_session1 = |
| 3777 | spdy_session_pool->FindAvailableSession( |
Bence Béky | d885b2b | 2018-02-03 00:58:31 | [diff] [blame] | 3778 | key1, /* enable_ip_based_pooling = */ true, |
| 3779 | /* is_websocket = */ false, log_); |
Bence Béky | 1a5d856 | 2018-01-05 17:29:28 | [diff] [blame] | 3780 | EXPECT_EQ(1u, num_unclaimed_pushed_streams(spdy_session1)); |
| 3781 | |
| 3782 | // While cross-origin push for kUrl2 is allowed on spdy_session1, |
| 3783 | // a client-initiated request would not pool to this connection, |
| 3784 | // because the IP address does not match. |
| 3785 | SpdySessionKey key2(HostPortPair::FromURL(GURL(kUrl2)), ProxyServer::Direct(), |
Matt Menke | 2436b2f | 2018-12-11 18:07:11 | [diff] [blame] | 3786 | PRIVACY_MODE_DISABLED, |
| 3787 | SpdySessionKey::IsProxySession::kFalse, SocketTag()); |
Bence Béky | 1a5d856 | 2018-01-05 17:29:28 | [diff] [blame] | 3788 | EXPECT_FALSE(spdy_session_pool->FindAvailableSession( |
Bence Béky | d885b2b | 2018-02-03 00:58:31 | [diff] [blame] | 3789 | key2, /* enable_ip_based_pooling = */ true, |
| 3790 | /* is_websocket = */ false, log_)); |
Bence Béky | 1a5d856 | 2018-01-05 17:29:28 | [diff] [blame] | 3791 | |
| 3792 | // Create request matching pushed stream. |
| 3793 | HttpNetworkTransaction trans2(DEFAULT_PRIORITY, helper.session()); |
| 3794 | HttpRequestInfo request2; |
| 3795 | request2.method = "GET"; |
| 3796 | request2.url = GURL(kUrl2); |
Ramin Halavati | b5e433e6 | 2018-02-07 07:41:10 | [diff] [blame] | 3797 | request2.traffic_annotation = |
| 3798 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
Bence Béky | 1a5d856 | 2018-01-05 17:29:28 | [diff] [blame] | 3799 | TestCompletionCallback callback2; |
| 3800 | rv = trans2.Start(&request2, callback2.callback(), log_); |
| 3801 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 3802 | |
| 3803 | // Pushed stream is now claimed by second request. |
| 3804 | EXPECT_EQ(0u, num_unclaimed_pushed_streams(spdy_session1)); |
| 3805 | |
| 3806 | // Second request receives RST_STREAM and is retried on a new connection. |
| 3807 | rv = callback2.WaitForResult(); |
| 3808 | EXPECT_THAT(rv, IsOk()); |
| 3809 | response = trans2.GetResponseInfo(); |
| 3810 | EXPECT_TRUE(response->headers); |
| 3811 | EXPECT_EQ("HTTP/1.1 200", response->headers->GetStatusLine()); |
| 3812 | std::string result2; |
| 3813 | ReadResult(&trans2, &result2); |
| 3814 | EXPECT_EQ("Response on the second connection.", result2); |
| 3815 | |
| 3816 | // Make sure that the first connection is still open. This is important in |
| 3817 | // order to test that the retry created its own connection (because the IP |
| 3818 | // address does not match), instead of using the connection of the cancelled |
| 3819 | // pushed stream. |
| 3820 | EXPECT_TRUE(spdy_session1); |
| 3821 | |
| 3822 | // Read EOF. |
| 3823 | data1.Resume(); |
| 3824 | base::RunLoop().RunUntilIdle(); |
| 3825 | |
| 3826 | helper.VerifyDataConsumed(); |
Bence Béky | e8955cf2 | 2018-01-02 17:31:29 | [diff] [blame] | 3827 | } |
| 3828 | |
bnc | c055fa3 | 2017-06-19 13:44:42 | [diff] [blame] | 3829 | // Regression test for https://crbug.com/727653. |
| 3830 | TEST_F(SpdyNetworkTransactionTest, RejectServerPushWithNoMethod) { |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 3831 | base::HistogramTester histogram_tester; |
| 3832 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3833 | spdy::SpdySerializedFrame req( |
| 3834 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 3835 | spdy::SpdySerializedFrame rst( |
| 3836 | spdy_util_.ConstructSpdyRstStream(2, spdy::ERROR_CODE_REFUSED_STREAM)); |
bnc | c055fa3 | 2017-06-19 13:44:42 | [diff] [blame] | 3837 | MockWrite writes[] = {CreateMockWrite(req, 0), CreateMockWrite(rst, 3)}; |
| 3838 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3839 | spdy::SpdySerializedFrame reply( |
| 3840 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
bnc | c055fa3 | 2017-06-19 13:44:42 | [diff] [blame] | 3841 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3842 | spdy::SpdyHeaderBlock push_promise_header_block; |
Bence Béky | d2df6c1c8 | 2018-04-20 22:52:01 | [diff] [blame] | 3843 | spdy_util_.AddUrlToHeaderBlock(kPushedUrl, &push_promise_header_block); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3844 | spdy::SpdySerializedFrame push_promise(spdy_util_.ConstructSpdyPushPromise( |
Bence Béky | f1d7852 | 2018-01-11 01:16:50 | [diff] [blame] | 3845 | 1, 2, std::move(push_promise_header_block))); |
bnc | c055fa3 | 2017-06-19 13:44:42 | [diff] [blame] | 3846 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3847 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
Bence Béky | f1d7852 | 2018-01-11 01:16:50 | [diff] [blame] | 3848 | MockRead reads[] = {CreateMockRead(reply, 1), CreateMockRead(push_promise, 2), |
| 3849 | CreateMockRead(body, 4), |
| 3850 | MockRead(SYNCHRONOUS, ERR_IO_PENDING, 5)}; |
bnc | c055fa3 | 2017-06-19 13:44:42 | [diff] [blame] | 3851 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 3852 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 3853 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
bnc | c055fa3 | 2017-06-19 13:44:42 | [diff] [blame] | 3854 | helper.RunToCompletion(&data); |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 3855 | |
| 3856 | histogram_tester.ExpectBucketCount( |
| 3857 | "Net.SpdyPushedStreamFate", |
| 3858 | static_cast<int>(SpdyPushedStreamFate::kInvalidUrl), 1); |
| 3859 | histogram_tester.ExpectTotalCount("Net.SpdyPushedStreamFate", 1); |
bnc | c055fa3 | 2017-06-19 13:44:42 | [diff] [blame] | 3860 | } |
| 3861 | |
| 3862 | // Regression test for https://crbug.com/727653. |
| 3863 | TEST_F(SpdyNetworkTransactionTest, RejectServerPushWithInvalidMethod) { |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 3864 | base::HistogramTester histogram_tester; |
| 3865 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3866 | spdy::SpdySerializedFrame req( |
| 3867 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 3868 | spdy::SpdySerializedFrame rst( |
| 3869 | spdy_util_.ConstructSpdyRstStream(2, spdy::ERROR_CODE_REFUSED_STREAM)); |
bnc | c055fa3 | 2017-06-19 13:44:42 | [diff] [blame] | 3870 | MockWrite writes[] = {CreateMockWrite(req, 0), CreateMockWrite(rst, 3)}; |
| 3871 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3872 | spdy::SpdySerializedFrame reply( |
| 3873 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
bnc | c055fa3 | 2017-06-19 13:44:42 | [diff] [blame] | 3874 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3875 | spdy::SpdyHeaderBlock push_promise_header_block; |
bnc | c055fa3 | 2017-06-19 13:44:42 | [diff] [blame] | 3876 | push_promise_header_block[":method"] = "POST"; |
Bence Béky | d2df6c1c8 | 2018-04-20 22:52:01 | [diff] [blame] | 3877 | spdy_util_.AddUrlToHeaderBlock(kPushedUrl, &push_promise_header_block); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3878 | spdy::SpdySerializedFrame push_promise(spdy_util_.ConstructSpdyPushPromise( |
Bence Béky | f1d7852 | 2018-01-11 01:16:50 | [diff] [blame] | 3879 | 1, 2, std::move(push_promise_header_block))); |
bnc | c055fa3 | 2017-06-19 13:44:42 | [diff] [blame] | 3880 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3881 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
Bence Béky | f1d7852 | 2018-01-11 01:16:50 | [diff] [blame] | 3882 | MockRead reads[] = {CreateMockRead(reply, 1), CreateMockRead(push_promise, 2), |
| 3883 | CreateMockRead(body, 4), |
| 3884 | MockRead(SYNCHRONOUS, ERR_IO_PENDING, 5)}; |
bnc | c055fa3 | 2017-06-19 13:44:42 | [diff] [blame] | 3885 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 3886 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 3887 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
bnc | c055fa3 | 2017-06-19 13:44:42 | [diff] [blame] | 3888 | helper.RunToCompletion(&data); |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 3889 | |
| 3890 | histogram_tester.ExpectBucketCount( |
| 3891 | "Net.SpdyPushedStreamFate", |
| 3892 | static_cast<int>(SpdyPushedStreamFate::kInvalidUrl), 1); |
| 3893 | histogram_tester.ExpectTotalCount("Net.SpdyPushedStreamFate", 1); |
bnc | c055fa3 | 2017-06-19 13:44:42 | [diff] [blame] | 3894 | } |
| 3895 | |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 3896 | // Verify that various response headers parse correctly through the HTTP layer. |
| 3897 | TEST_F(SpdyNetworkTransactionTest, ResponseHeaders) { |
| 3898 | struct ResponseHeadersTests { |
Bence Béky | e543851 | 2017-11-22 23:07:42 | [diff] [blame] | 3899 | int extra_header_count; |
| 3900 | const char* extra_headers[4]; |
| 3901 | size_t expected_header_count; |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 3902 | base::StringPiece expected_headers[8]; |
Bence Béky | e543851 | 2017-11-22 23:07:42 | [diff] [blame] | 3903 | } test_cases[] = { |
| 3904 | // No extra headers. |
| 3905 | {0, {}, 2, {"status", "200", "hello", "bye"}}, |
| 3906 | // Comma-separated header value. |
| 3907 | {1, |
| 3908 | {"cookie", "val1, val2"}, |
| 3909 | 3, |
| 3910 | {"status", "200", "hello", "bye", "cookie", "val1, val2"}}, |
| 3911 | // Multiple headers are preserved: they are joined with \0 separator in |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3912 | // spdy::SpdyHeaderBlock.AppendValueOrAddHeader(), then split up in |
Bence Béky | e543851 | 2017-11-22 23:07:42 | [diff] [blame] | 3913 | // HpackEncoder, then joined with \0 separator when |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3914 | // spdy::HpackDecoderAdapter::ListenerAdapter::OnHeader() calls |
| 3915 | // spdy::SpdyHeaderBlock.AppendValueOrAddHeader(), then split up again in |
Bence Béky | e543851 | 2017-11-22 23:07:42 | [diff] [blame] | 3916 | // HttpResponseHeaders. |
| 3917 | {2, |
| 3918 | {"content-encoding", "val1", "content-encoding", "val2"}, |
| 3919 | 4, |
| 3920 | {"status", "200", "hello", "bye", "content-encoding", "val1", |
| 3921 | "content-encoding", "val2"}}, |
| 3922 | // Cookie header is not split up by HttpResponseHeaders. |
| 3923 | {2, |
| 3924 | {"cookie", "val1", "cookie", "val2"}, |
| 3925 | 3, |
| 3926 | {"status", "200", "hello", "bye", "cookie", "val1; val2"}}}; |
bnc | 7ecc112 | 2015-09-28 13:22:49 | [diff] [blame] | 3927 | |
Avi Drissman | 4365a478 | 2018-12-28 19:26:24 | [diff] [blame] | 3928 | for (size_t i = 0; i < base::size(test_cases); ++i) { |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 3929 | SpdyTestUtil spdy_test_util; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3930 | spdy::SpdySerializedFrame req( |
Bence Béky | 27ad0a1 | 2018-02-08 00:35:48 | [diff] [blame] | 3931 | spdy_test_util.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 3932 | MockWrite writes[] = {CreateMockWrite(req, 0)}; |
[email protected] | 8b07037 | 2009-11-16 22:01:25 | [diff] [blame] | 3933 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3934 | spdy::SpdySerializedFrame resp(spdy_test_util.ConstructSpdyGetReply( |
Bence Béky | e543851 | 2017-11-22 23:07:42 | [diff] [blame] | 3935 | test_cases[i].extra_headers, test_cases[i].extra_header_count, 1)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3936 | spdy::SpdySerializedFrame body( |
| 3937 | spdy_test_util.ConstructSpdyDataFrame(1, true)); |
[email protected] | 8b07037 | 2009-11-16 22:01:25 | [diff] [blame] | 3938 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 3939 | CreateMockRead(resp, 1), CreateMockRead(body, 2), |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 3940 | MockRead(ASYNC, 0, 3) // EOF |
[email protected] | 8b07037 | 2009-11-16 22:01:25 | [diff] [blame] | 3941 | }; |
| 3942 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 3943 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 3944 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
| 3945 | nullptr); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 3946 | helper.RunToCompletion(&data); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 3947 | TransactionHelperResult out = helper.output(); |
| 3948 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 3949 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 3950 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | 8b07037 | 2009-11-16 22:01:25 | [diff] [blame] | 3951 | EXPECT_EQ("hello!", out.response_data); |
| 3952 | |
| 3953 | scoped_refptr<HttpResponseHeaders> headers = out.response_info.headers; |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 3954 | EXPECT_TRUE(headers); |
olli.raula | 33c282f | 2016-01-21 12:12:49 | [diff] [blame] | 3955 | size_t iter = 0; |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 3956 | std::string name, value; |
Bence Béky | e543851 | 2017-11-22 23:07:42 | [diff] [blame] | 3957 | size_t expected_header_index = 0; |
[email protected] | 8b07037 | 2009-11-16 22:01:25 | [diff] [blame] | 3958 | while (headers->EnumerateHeaderLines(&iter, &name, &value)) { |
Bence Béky | e543851 | 2017-11-22 23:07:42 | [diff] [blame] | 3959 | ASSERT_LT(expected_header_index, test_cases[i].expected_header_count) |
| 3960 | << i; |
| 3961 | EXPECT_EQ(name, test_cases[i].expected_headers[2 * expected_header_index]) |
| 3962 | << i; |
| 3963 | EXPECT_EQ(value, |
| 3964 | test_cases[i].expected_headers[2 * expected_header_index + 1]) |
| 3965 | << i; |
| 3966 | ++expected_header_index; |
[email protected] | 8b07037 | 2009-11-16 22:01:25 | [diff] [blame] | 3967 | } |
Bence Béky | e543851 | 2017-11-22 23:07:42 | [diff] [blame] | 3968 | EXPECT_EQ(expected_header_index, test_cases[i].expected_header_count) << i; |
[email protected] | 8b07037 | 2009-11-16 22:01:25 | [diff] [blame] | 3969 | } |
| 3970 | } |
| 3971 | |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 3972 | // Verify that various response headers parse vary fields correctly through the |
| 3973 | // HTTP layer, and the response matches the request. |
| 3974 | TEST_F(SpdyNetworkTransactionTest, ResponseHeadersVary) { |
[email protected] | 3f662f1 | 2010-03-25 19:56:12 | [diff] [blame] | 3975 | // Modify the following data to change/add test cases: |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 3976 | struct ResponseTests { |
[email protected] | 3f662f1 | 2010-03-25 19:56:12 | [diff] [blame] | 3977 | bool vary_matches; |
| 3978 | int num_headers[2]; |
| 3979 | const char* extra_headers[2][16]; |
| 3980 | } test_cases[] = { |
bnc | 7ecc112 | 2015-09-28 13:22:49 | [diff] [blame] | 3981 | // Test the case of a multi-valued cookie. When the value is delimited |
| 3982 | // with NUL characters, it needs to be unfolded into multiple headers. |
| 3983 | {true, |
bnc | a9b9e22 | 2016-07-11 20:10:40 | [diff] [blame] | 3984 | {1, 3}, |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3985 | {{"cookie", "val1,val2", nullptr}, |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3986 | {spdy::kHttp2StatusHeader, "200", spdy::kHttp2PathHeader, "/index.php", |
| 3987 | "vary", "cookie", nullptr}}}, |
bnc | 7ecc112 | 2015-09-28 13:22:49 | [diff] [blame] | 3988 | {// Multiple vary fields. |
| 3989 | true, |
bnc | 7ecc112 | 2015-09-28 13:22:49 | [diff] [blame] | 3990 | {2, 4}, |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3991 | {{"friend", "barney", "enemy", "snaggletooth", nullptr}, |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3992 | {spdy::kHttp2StatusHeader, "200", spdy::kHttp2PathHeader, "/index.php", |
| 3993 | "vary", "friend", "vary", "enemy", nullptr}}}, |
bnc | a9b9e22 | 2016-07-11 20:10:40 | [diff] [blame] | 3994 | {// Test a '*' vary field. |
Maks Orlovich | 722dc11 | 2017-11-10 00:29:30 | [diff] [blame] | 3995 | true, |
bnc | a9b9e22 | 2016-07-11 20:10:40 | [diff] [blame] | 3996 | {1, 3}, |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3997 | {{"cookie", "val1,val2", nullptr}, |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3998 | {spdy::kHttp2StatusHeader, "200", spdy::kHttp2PathHeader, "/index.php", |
| 3999 | "vary", "*", nullptr}}}, |
Maks Orlovich | 722dc11 | 2017-11-10 00:29:30 | [diff] [blame] | 4000 | {// Test w/o a vary field. |
| 4001 | false, |
| 4002 | {1, 2}, |
| 4003 | {{"cookie", "val1,val2", nullptr}, |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4004 | {spdy::kHttp2StatusHeader, "200", spdy::kHttp2PathHeader, "/index.php", |
| 4005 | nullptr}}}, |
Maks Orlovich | 722dc11 | 2017-11-10 00:29:30 | [diff] [blame] | 4006 | |
bnc | a9b9e22 | 2016-07-11 20:10:40 | [diff] [blame] | 4007 | {// Multiple comma-separated vary fields. |
| 4008 | true, |
| 4009 | {2, 3}, |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 4010 | {{"friend", "barney", "enemy", "snaggletooth", nullptr}, |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4011 | {spdy::kHttp2StatusHeader, "200", spdy::kHttp2PathHeader, "/index.php", |
| 4012 | "vary", "friend,enemy", nullptr}}}}; |
[email protected] | 3f662f1 | 2010-03-25 19:56:12 | [diff] [blame] | 4013 | |
Avi Drissman | 4365a478 | 2018-12-28 19:26:24 | [diff] [blame] | 4014 | for (size_t i = 0; i < base::size(test_cases); ++i) { |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 4015 | SpdyTestUtil spdy_test_util; |
bnc | 38dcd39 | 2016-02-09 23:19:49 | [diff] [blame] | 4016 | |
[email protected] | 3f662f1 | 2010-03-25 19:56:12 | [diff] [blame] | 4017 | // Construct the request. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4018 | spdy::SpdySerializedFrame frame_req(spdy_test_util.ConstructSpdyGet( |
Bence Béky | 27ad0a1 | 2018-02-08 00:35:48 | [diff] [blame] | 4019 | test_cases[i].extra_headers[0], test_cases[i].num_headers[0], 1, |
| 4020 | LOWEST)); |
[email protected] | 3f662f1 | 2010-03-25 19:56:12 | [diff] [blame] | 4021 | |
| 4022 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 4023 | CreateMockWrite(frame_req, 0), |
[email protected] | 3f662f1 | 2010-03-25 19:56:12 | [diff] [blame] | 4024 | }; |
| 4025 | |
| 4026 | // Construct the reply. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4027 | spdy::SpdyHeaderBlock reply_headers; |
[email protected] | 745aa9c | 2014-06-27 02:21:29 | [diff] [blame] | 4028 | AppendToHeaderBlock(test_cases[i].extra_headers[1], |
| 4029 | test_cases[i].num_headers[1], |
| 4030 | &reply_headers); |
bnc | 086b39e1 | 2016-06-24 13:05:26 | [diff] [blame] | 4031 | // Construct the expected header reply string before moving |reply_headers|. |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 4032 | std::string expected_reply = |
bnc | 086b39e1 | 2016-06-24 13:05:26 | [diff] [blame] | 4033 | spdy_test_util.ConstructSpdyReplyString(reply_headers); |
| 4034 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4035 | spdy::SpdySerializedFrame frame_reply( |
bnc | 086b39e1 | 2016-06-24 13:05:26 | [diff] [blame] | 4036 | spdy_test_util.ConstructSpdyReply(1, std::move(reply_headers))); |
[email protected] | 3f662f1 | 2010-03-25 19:56:12 | [diff] [blame] | 4037 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4038 | spdy::SpdySerializedFrame body( |
| 4039 | spdy_test_util.ConstructSpdyDataFrame(1, true)); |
[email protected] | 3f662f1 | 2010-03-25 19:56:12 | [diff] [blame] | 4040 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 4041 | CreateMockRead(frame_reply, 1), CreateMockRead(body, 2), |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 4042 | MockRead(ASYNC, 0, 3) // EOF |
[email protected] | 3f662f1 | 2010-03-25 19:56:12 | [diff] [blame] | 4043 | }; |
| 4044 | |
[email protected] | 3f662f1 | 2010-03-25 19:56:12 | [diff] [blame] | 4045 | // Attach the headers to the request. |
[email protected] | 8c76ae2 | 2010-04-20 22:15:43 | [diff] [blame] | 4046 | int header_count = test_cases[i].num_headers[0]; |
[email protected] | 3f662f1 | 2010-03-25 19:56:12 | [diff] [blame] | 4047 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 4048 | HttpRequestInfo request; |
| 4049 | request.method = "GET"; |
| 4050 | request.url = GURL(kDefaultUrl); |
Ramin Halavati | b5e433e6 | 2018-02-07 07:41:10 | [diff] [blame] | 4051 | request.traffic_annotation = |
| 4052 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
[email protected] | 8c76ae2 | 2010-04-20 22:15:43 | [diff] [blame] | 4053 | for (int ct = 0; ct < header_count; ct++) { |
| 4054 | const char* header_key = test_cases[i].extra_headers[0][ct * 2]; |
| 4055 | const char* header_value = test_cases[i].extra_headers[0][ct * 2 + 1]; |
| 4056 | request.extra_headers.SetHeader(header_key, header_value); |
[email protected] | 3f662f1 | 2010-03-25 19:56:12 | [diff] [blame] | 4057 | } |
| 4058 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 4059 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 4060 | |
Bence Béky | d3dde83 | 2017-09-19 19:02:31 | [diff] [blame] | 4061 | NormalSpdyTransactionHelper helper(request, DEFAULT_PRIORITY, log_, |
| 4062 | nullptr); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 4063 | |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 4064 | helper.RunToCompletion(&data); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 4065 | TransactionHelperResult out = helper.output(); |
| 4066 | |
[email protected] | 3f662f1 | 2010-03-25 19:56:12 | [diff] [blame] | 4067 | EXPECT_EQ(OK, out.rv) << i; |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 4068 | EXPECT_EQ("HTTP/1.1 200", out.status_line) << i; |
[email protected] | 3f662f1 | 2010-03-25 19:56:12 | [diff] [blame] | 4069 | EXPECT_EQ("hello!", out.response_data) << i; |
| 4070 | |
| 4071 | // Test the response information. |
[email protected] | 3f662f1 | 2010-03-25 19:56:12 | [diff] [blame] | 4072 | EXPECT_EQ(out.response_info.vary_data.is_valid(), |
| 4073 | test_cases[i].vary_matches) << i; |
| 4074 | |
| 4075 | // Check the headers. |
| 4076 | scoped_refptr<HttpResponseHeaders> headers = out.response_info.headers; |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 4077 | ASSERT_TRUE(headers) << i; |
olli.raula | 33c282f | 2016-01-21 12:12:49 | [diff] [blame] | 4078 | size_t iter = 0; |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 4079 | std::string name, value, lines; |
[email protected] | 3f662f1 | 2010-03-25 19:56:12 | [diff] [blame] | 4080 | while (headers->EnumerateHeaderLines(&iter, &name, &value)) { |
| 4081 | lines.append(name); |
| 4082 | lines.append(": "); |
| 4083 | lines.append(value); |
| 4084 | lines.append("\n"); |
| 4085 | } |
| 4086 | |
[email protected] | 9aa32319 | 2013-05-31 21:38:40 | [diff] [blame] | 4087 | EXPECT_EQ(expected_reply, lines) << i; |
[email protected] | 3f662f1 | 2010-03-25 19:56:12 | [diff] [blame] | 4088 | } |
| 4089 | } |
| 4090 | |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 4091 | // Verify that we don't crash on invalid response headers. |
| 4092 | TEST_F(SpdyNetworkTransactionTest, InvalidResponseHeaders) { |
| 4093 | struct InvalidResponseHeadersTests { |
[email protected] | e7f7509 | 2010-07-01 22:39:13 | [diff] [blame] | 4094 | int num_headers; |
| 4095 | const char* headers[10]; |
[email protected] | dd11b93 | 2009-11-30 19:39:48 | [diff] [blame] | 4096 | } test_cases[] = { |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 4097 | // Response headers missing status header |
bnc | 7ecc112 | 2015-09-28 13:22:49 | [diff] [blame] | 4098 | { |
bnc | a9b9e22 | 2016-07-11 20:10:40 | [diff] [blame] | 4099 | 3, |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4100 | {spdy::kHttp2PathHeader, "/index.php", "cookie", "val1", "cookie", |
| 4101 | "val2", nullptr}, |
[email protected] | e7f7509 | 2010-07-01 22:39:13 | [diff] [blame] | 4102 | }, |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 4103 | // Response headers missing version header |
bnc | 7ecc112 | 2015-09-28 13:22:49 | [diff] [blame] | 4104 | { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4105 | 1, {spdy::kHttp2PathHeader, "/index.php", "status", "200", nullptr}, |
[email protected] | e7f7509 | 2010-07-01 22:39:13 | [diff] [blame] | 4106 | }, |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 4107 | // Response headers with no headers |
bnc | 7ecc112 | 2015-09-28 13:22:49 | [diff] [blame] | 4108 | { |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 4109 | 0, {nullptr}, |
bnc | 7ecc112 | 2015-09-28 13:22:49 | [diff] [blame] | 4110 | }, |
[email protected] | dd11b93 | 2009-11-30 19:39:48 | [diff] [blame] | 4111 | }; |
| 4112 | |
Avi Drissman | 4365a478 | 2018-12-28 19:26:24 | [diff] [blame] | 4113 | for (size_t i = 0; i < base::size(test_cases); ++i) { |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 4114 | SpdyTestUtil spdy_test_util; |
bnc | 38dcd39 | 2016-02-09 23:19:49 | [diff] [blame] | 4115 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4116 | spdy::SpdySerializedFrame req( |
Bence Béky | 27ad0a1 | 2018-02-08 00:35:48 | [diff] [blame] | 4117 | spdy_test_util.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4118 | spdy::SpdySerializedFrame rst(spdy_test_util.ConstructSpdyRstStream( |
| 4119 | 1, spdy::ERROR_CODE_PROTOCOL_ERROR)); |
[email protected] | dd11b93 | 2009-11-30 19:39:48 | [diff] [blame] | 4120 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 4121 | CreateMockWrite(req, 0), CreateMockWrite(rst, 2), |
[email protected] | dd11b93 | 2009-11-30 19:39:48 | [diff] [blame] | 4122 | }; |
| 4123 | |
[email protected] | 745aa9c | 2014-06-27 02:21:29 | [diff] [blame] | 4124 | // Construct the reply. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4125 | spdy::SpdyHeaderBlock reply_headers; |
[email protected] | 745aa9c | 2014-06-27 02:21:29 | [diff] [blame] | 4126 | AppendToHeaderBlock( |
| 4127 | test_cases[i].headers, test_cases[i].num_headers, &reply_headers); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4128 | spdy::SpdySerializedFrame resp( |
bnc | 086b39e1 | 2016-06-24 13:05:26 | [diff] [blame] | 4129 | spdy_test_util.ConstructSpdyReply(1, std::move(reply_headers))); |
[email protected] | dd11b93 | 2009-11-30 19:39:48 | [diff] [blame] | 4130 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 4131 | CreateMockRead(resp, 1), MockRead(ASYNC, 0, 3) // EOF |
[email protected] | dd11b93 | 2009-11-30 19:39:48 | [diff] [blame] | 4132 | }; |
| 4133 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 4134 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 4135 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
| 4136 | nullptr); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 4137 | helper.RunToCompletion(&data); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 4138 | TransactionHelperResult out = helper.output(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 4139 | EXPECT_THAT(out.rv, IsError(ERR_SPDY_PROTOCOL_ERROR)); |
[email protected] | dd11b93 | 2009-11-30 19:39:48 | [diff] [blame] | 4140 | } |
| 4141 | } |
| 4142 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 4143 | TEST_F(SpdyNetworkTransactionTest, CorruptFrameSessionError) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4144 | spdy::SpdySerializedFrame req( |
| 4145 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 4146 | spdy::SpdySerializedFrame goaway( |
| 4147 | spdy_util_.ConstructSpdyGoAway(0, spdy::ERROR_CODE_COMPRESSION_ERROR, |
diannahu | 9904e27 | 2017-02-03 14:40:08 | [diff] [blame] | 4148 | "Framer error: 6 (DECOMPRESS_FAILURE).")); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 4149 | MockWrite writes[] = {CreateMockWrite(req, 0), CreateMockWrite(goaway, 2)}; |
[email protected] | e3352df | 2014-03-19 05:55:42 | [diff] [blame] | 4150 | |
bnc | 38dcd39 | 2016-02-09 23:19:49 | [diff] [blame] | 4151 | // This is the length field that's too short. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4152 | spdy::SpdySerializedFrame reply_wrong_length( |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 4153 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4154 | size_t right_size = reply_wrong_length.size() - spdy::kFrameHeaderSize; |
bnc | 38dcd39 | 2016-02-09 23:19:49 | [diff] [blame] | 4155 | size_t wrong_size = right_size - 4; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4156 | spdy::test::SetFrameLength(&reply_wrong_length, wrong_size); |
bnc | 38dcd39 | 2016-02-09 23:19:49 | [diff] [blame] | 4157 | |
[email protected] | e3352df | 2014-03-19 05:55:42 | [diff] [blame] | 4158 | MockRead reads[] = { |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 4159 | MockRead(ASYNC, reply_wrong_length.data(), reply_wrong_length.size() - 4, |
| 4160 | 1), |
[email protected] | e3352df | 2014-03-19 05:55:42 | [diff] [blame] | 4161 | }; |
| 4162 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 4163 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 4164 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | e3352df | 2014-03-19 05:55:42 | [diff] [blame] | 4165 | helper.RunToCompletion(&data); |
| 4166 | TransactionHelperResult out = helper.output(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 4167 | EXPECT_THAT(out.rv, IsError(ERR_SPDY_COMPRESSION_ERROR)); |
[email protected] | bdd1b22 | 2014-06-10 11:08:39 | [diff] [blame] | 4168 | } |
| 4169 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 4170 | TEST_F(SpdyNetworkTransactionTest, GoAwayOnDecompressionFailure) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4171 | spdy::SpdySerializedFrame req( |
| 4172 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 4173 | spdy::SpdySerializedFrame goaway( |
| 4174 | spdy_util_.ConstructSpdyGoAway(0, spdy::ERROR_CODE_COMPRESSION_ERROR, |
diannahu | 9904e27 | 2017-02-03 14:40:08 | [diff] [blame] | 4175 | "Framer error: 6 (DECOMPRESS_FAILURE).")); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 4176 | MockWrite writes[] = {CreateMockWrite(req, 0), CreateMockWrite(goaway, 2)}; |
[email protected] | bdd1b22 | 2014-06-10 11:08:39 | [diff] [blame] | 4177 | |
| 4178 | // Read HEADERS with corrupted payload. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4179 | spdy::SpdySerializedFrame resp( |
| 4180 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 4181 | memset(resp.data() + 12, 0xcf, resp.size() - 12); |
| 4182 | MockRead reads[] = {CreateMockRead(resp, 1)}; |
[email protected] | bdd1b22 | 2014-06-10 11:08:39 | [diff] [blame] | 4183 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 4184 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 4185 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | bdd1b22 | 2014-06-10 11:08:39 | [diff] [blame] | 4186 | helper.RunToCompletion(&data); |
| 4187 | TransactionHelperResult out = helper.output(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 4188 | EXPECT_THAT(out.rv, IsError(ERR_SPDY_COMPRESSION_ERROR)); |
[email protected] | bdd1b22 | 2014-06-10 11:08:39 | [diff] [blame] | 4189 | } |
| 4190 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 4191 | TEST_F(SpdyNetworkTransactionTest, GoAwayOnFrameSizeError) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4192 | spdy::SpdySerializedFrame req( |
| 4193 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 4194 | spdy::SpdySerializedFrame goaway(spdy_util_.ConstructSpdyGoAway( |
| 4195 | 0, spdy::ERROR_CODE_FRAME_SIZE_ERROR, |
dahollings | af379649 | 2016-05-25 19:21:35 | [diff] [blame] | 4196 | "Framer error: 15 (INVALID_CONTROL_FRAME_SIZE).")); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 4197 | MockWrite writes[] = {CreateMockWrite(req, 0), CreateMockWrite(goaway, 2)}; |
[email protected] | bdd1b22 | 2014-06-10 11:08:39 | [diff] [blame] | 4198 | |
| 4199 | // Read WINDOW_UPDATE with incorrectly-sized payload. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4200 | spdy::SpdySerializedFrame bad_window_update( |
[email protected] | bdd1b22 | 2014-06-10 11:08:39 | [diff] [blame] | 4201 | spdy_util_.ConstructSpdyWindowUpdate(1, 1)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4202 | spdy::test::SetFrameLength(&bad_window_update, bad_window_update.size() - 1); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 4203 | MockRead reads[] = {CreateMockRead(bad_window_update, 1)}; |
[email protected] | bdd1b22 | 2014-06-10 11:08:39 | [diff] [blame] | 4204 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 4205 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 4206 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | bdd1b22 | 2014-06-10 11:08:39 | [diff] [blame] | 4207 | helper.RunToCompletion(&data); |
| 4208 | TransactionHelperResult out = helper.output(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 4209 | EXPECT_THAT(out.rv, IsError(ERR_SPDY_FRAME_SIZE_ERROR)); |
[email protected] | e3352df | 2014-03-19 05:55:42 | [diff] [blame] | 4210 | } |
| 4211 | |
[email protected] | bf2491a9 | 2009-11-29 16:39:48 | [diff] [blame] | 4212 | // Test that we shutdown correctly on write errors. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 4213 | TEST_F(SpdyNetworkTransactionTest, WriteError) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4214 | spdy::SpdySerializedFrame req( |
| 4215 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
[email protected] | bf2491a9 | 2009-11-29 16:39:48 | [diff] [blame] | 4216 | MockWrite writes[] = { |
[email protected] | bdd1b22 | 2014-06-10 11:08:39 | [diff] [blame] | 4217 | // We'll write 10 bytes successfully |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 4218 | MockWrite(ASYNC, req.data(), 10, 1), |
[email protected] | bdd1b22 | 2014-06-10 11:08:39 | [diff] [blame] | 4219 | // Followed by ERROR! |
[email protected] | bdd1b22 | 2014-06-10 11:08:39 | [diff] [blame] | 4220 | MockWrite(ASYNC, ERR_FAILED, 2), |
mmenke | 666a6fea | 2015-12-19 04:16:33 | [diff] [blame] | 4221 | // Session drains and attempts to write a GOAWAY: Another ERROR! |
| 4222 | MockWrite(ASYNC, ERR_FAILED, 3), |
[email protected] | bf2491a9 | 2009-11-29 16:39:48 | [diff] [blame] | 4223 | }; |
| 4224 | |
mmenke | 666a6fea | 2015-12-19 04:16:33 | [diff] [blame] | 4225 | MockRead reads[] = {MockRead(SYNCHRONOUS, ERR_IO_PENDING, 0)}; |
[email protected] | 238002d | 2013-10-17 02:01:40 | [diff] [blame] | 4226 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 4227 | SequencedSocketData data(reads, writes); |
[email protected] | 238002d | 2013-10-17 02:01:40 | [diff] [blame] | 4228 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 4229 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | 238002d | 2013-10-17 02:01:40 | [diff] [blame] | 4230 | helper.RunPreTestSetup(); |
mmenke | 666a6fea | 2015-12-19 04:16:33 | [diff] [blame] | 4231 | helper.AddData(&data); |
[email protected] | 238002d | 2013-10-17 02:01:40 | [diff] [blame] | 4232 | EXPECT_TRUE(helper.StartDefaultTest()); |
[email protected] | 238002d | 2013-10-17 02:01:40 | [diff] [blame] | 4233 | helper.FinishDefaultTest(); |
rch | 37de576c | 2015-05-17 20:28:17 | [diff] [blame] | 4234 | EXPECT_TRUE(data.AllWriteDataConsumed()); |
mmenke | 666a6fea | 2015-12-19 04:16:33 | [diff] [blame] | 4235 | EXPECT_TRUE(data.AllReadDataConsumed()); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 4236 | TransactionHelperResult out = helper.output(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 4237 | EXPECT_THAT(out.rv, IsError(ERR_FAILED)); |
[email protected] | bf2491a9 | 2009-11-29 16:39:48 | [diff] [blame] | 4238 | } |
| 4239 | |
| 4240 | // Test that partial writes work. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 4241 | TEST_F(SpdyNetworkTransactionTest, PartialWrite) { |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 4242 | // Chop the HEADERS frame into 5 chunks. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4243 | spdy::SpdySerializedFrame req( |
| 4244 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
[email protected] | bf2491a9 | 2009-11-29 16:39:48 | [diff] [blame] | 4245 | const int kChunks = 5; |
bnc | 3f6a855 | 2017-05-17 13:40:34 | [diff] [blame] | 4246 | std::unique_ptr<MockWrite[]> writes = ChopWriteFrame(req, kChunks); |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 4247 | for (int i = 0; i < kChunks; ++i) { |
| 4248 | writes[i].sequence_number = i; |
| 4249 | } |
[email protected] | bf2491a9 | 2009-11-29 16:39:48 | [diff] [blame] | 4250 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4251 | spdy::SpdySerializedFrame resp( |
| 4252 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 4253 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | bf2491a9 | 2009-11-29 16:39:48 | [diff] [blame] | 4254 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 4255 | CreateMockRead(resp, kChunks), CreateMockRead(body, kChunks + 1), |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 4256 | MockRead(ASYNC, 0, kChunks + 2) // EOF |
[email protected] | bf2491a9 | 2009-11-29 16:39:48 | [diff] [blame] | 4257 | }; |
| 4258 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 4259 | SequencedSocketData data(reads, base::make_span(writes.get(), kChunks)); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 4260 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 4261 | helper.RunToCompletion(&data); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 4262 | TransactionHelperResult out = helper.output(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 4263 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 4264 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | bf2491a9 | 2009-11-29 16:39:48 | [diff] [blame] | 4265 | EXPECT_EQ("hello!", out.response_data); |
| 4266 | } |
| 4267 | |
[email protected] | 9e743cd | 2010-03-16 07:03:53 | [diff] [blame] | 4268 | // Test that the NetLog contains good data for a simple GET request. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 4269 | TEST_F(SpdyNetworkTransactionTest, NetLog) { |
[email protected] | 3deb9a5 | 2010-11-11 00:24:40 | [diff] [blame] | 4270 | static const char* const kExtraHeaders[] = { |
| 4271 | "user-agent", "Chrome", |
| 4272 | }; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4273 | spdy::SpdySerializedFrame req( |
Bence Béky | 27ad0a1 | 2018-02-08 00:35:48 | [diff] [blame] | 4274 | spdy_util_.ConstructSpdyGet(kExtraHeaders, 1, 1, LOWEST)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 4275 | MockWrite writes[] = {CreateMockWrite(req, 0)}; |
[email protected] | dac35804 | 2009-12-18 02:07:48 | [diff] [blame] | 4276 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4277 | spdy::SpdySerializedFrame resp( |
| 4278 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 4279 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | dac35804 | 2009-12-18 02:07:48 | [diff] [blame] | 4280 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 4281 | CreateMockRead(resp, 1), CreateMockRead(body, 2), |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 4282 | MockRead(ASYNC, 0, 3) // EOF |
[email protected] | dac35804 | 2009-12-18 02:07:48 | [diff] [blame] | 4283 | }; |
| 4284 | |
vishal.b | 62985ca9 | 2015-04-17 08:45:51 | [diff] [blame] | 4285 | BoundTestNetLog log; |
[email protected] | dac35804 | 2009-12-18 02:07:48 | [diff] [blame] | 4286 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 4287 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 4288 | request_.extra_headers.SetHeader("User-Agent", "Chrome"); |
| 4289 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log.bound(), |
| 4290 | nullptr); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 4291 | helper.RunToCompletion(&data); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 4292 | TransactionHelperResult out = helper.output(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 4293 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 4294 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | dac35804 | 2009-12-18 02:07:48 | [diff] [blame] | 4295 | EXPECT_EQ("hello!", out.response_data); |
| 4296 | |
[email protected] | 9e743cd | 2010-03-16 07:03:53 | [diff] [blame] | 4297 | // Check that the NetLog was filled reasonably. |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 4298 | // This test is intentionally non-specific about the exact ordering of the |
| 4299 | // log; instead we just check to make sure that certain events exist, and that |
| 4300 | // they are in the right order. |
mmenke | 43758e6 | 2015-05-04 21:09:46 | [diff] [blame] | 4301 | TestNetLogEntry::List entries; |
[email protected] | b2fcd0e | 2010-12-01 15:19:40 | [diff] [blame] | 4302 | log.GetEntries(&entries); |
| 4303 | |
| 4304 | EXPECT_LT(0u, entries.size()); |
[email protected] | dac35804 | 2009-12-18 02:07:48 | [diff] [blame] | 4305 | int pos = 0; |
mikecirone | 8b85c43 | 2016-09-08 19:11:00 | [diff] [blame] | 4306 | pos = ExpectLogContainsSomewhere( |
| 4307 | entries, 0, NetLogEventType::HTTP_TRANSACTION_SEND_REQUEST, |
| 4308 | NetLogEventPhase::BEGIN); |
| 4309 | pos = ExpectLogContainsSomewhere( |
| 4310 | entries, pos + 1, NetLogEventType::HTTP_TRANSACTION_SEND_REQUEST, |
| 4311 | NetLogEventPhase::END); |
| 4312 | pos = ExpectLogContainsSomewhere( |
| 4313 | entries, pos + 1, NetLogEventType::HTTP_TRANSACTION_READ_HEADERS, |
| 4314 | NetLogEventPhase::BEGIN); |
| 4315 | pos = ExpectLogContainsSomewhere( |
| 4316 | entries, pos + 1, NetLogEventType::HTTP_TRANSACTION_READ_HEADERS, |
| 4317 | NetLogEventPhase::END); |
bnc | 301745a | 2015-03-10 03:22:16 | [diff] [blame] | 4318 | pos = ExpectLogContainsSomewhere(entries, pos + 1, |
mikecirone | 8b85c43 | 2016-09-08 19:11:00 | [diff] [blame] | 4319 | NetLogEventType::HTTP_TRANSACTION_READ_BODY, |
| 4320 | NetLogEventPhase::BEGIN); |
bnc | 301745a | 2015-03-10 03:22:16 | [diff] [blame] | 4321 | pos = ExpectLogContainsSomewhere(entries, pos + 1, |
mikecirone | 8b85c43 | 2016-09-08 19:11:00 | [diff] [blame] | 4322 | NetLogEventType::HTTP_TRANSACTION_READ_BODY, |
| 4323 | NetLogEventPhase::END); |
[email protected] | 3deb9a5 | 2010-11-11 00:24:40 | [diff] [blame] | 4324 | |
| 4325 | // Check that we logged all the headers correctly |
mikecirone | 8b85c43 | 2016-09-08 19:11:00 | [diff] [blame] | 4326 | pos = ExpectLogContainsSomewhere(entries, 0, |
| 4327 | NetLogEventType::HTTP2_SESSION_SEND_HEADERS, |
| 4328 | NetLogEventPhase::NONE); |
[email protected] | 3deb9a5 | 2010-11-11 00:24:40 | [diff] [blame] | 4329 | |
Bence Béky | 66871e3 | 2018-12-06 21:11:24 | [diff] [blame] | 4330 | ASSERT_TRUE(entries[pos].params); |
| 4331 | auto* header_list = entries[pos].params->FindKey("headers"); |
| 4332 | ASSERT_TRUE(header_list); |
| 4333 | ASSERT_TRUE(header_list->is_list()); |
| 4334 | ASSERT_EQ(5u, header_list->GetList().size()); |
[email protected] | f3da152d | 2012-06-02 01:00:57 | [diff] [blame] | 4335 | |
Bence Béky | 66871e3 | 2018-12-06 21:11:24 | [diff] [blame] | 4336 | ASSERT_TRUE(header_list->GetList()[0].is_string()); |
| 4337 | EXPECT_EQ(":method: GET", header_list->GetList()[0].GetString()); |
| 4338 | |
| 4339 | ASSERT_TRUE(header_list->GetList()[1].is_string()); |
| 4340 | EXPECT_EQ(":authority: www.example.org", |
| 4341 | header_list->GetList()[1].GetString()); |
| 4342 | |
| 4343 | ASSERT_TRUE(header_list->GetList()[2].is_string()); |
| 4344 | EXPECT_EQ(":scheme: https", header_list->GetList()[2].GetString()); |
| 4345 | |
| 4346 | ASSERT_TRUE(header_list->GetList()[3].is_string()); |
| 4347 | EXPECT_EQ(":path: /", header_list->GetList()[3].GetString()); |
| 4348 | |
| 4349 | ASSERT_TRUE(header_list->GetList()[4].is_string()); |
| 4350 | EXPECT_EQ("user-agent: Chrome", header_list->GetList()[4].GetString()); |
[email protected] | dac35804 | 2009-12-18 02:07:48 | [diff] [blame] | 4351 | } |
| 4352 | |
[email protected] | 79d8422 | 2010-02-26 00:01:44 | [diff] [blame] | 4353 | // Since we buffer the IO from the stream to the renderer, this test verifies |
| 4354 | // that when we read out the maximum amount of data (e.g. we received 50 bytes |
| 4355 | // on the network, but issued a Read for only 5 of those bytes) that the data |
| 4356 | // flow still works correctly. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 4357 | TEST_F(SpdyNetworkTransactionTest, BufferFull) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4358 | spdy::SpdySerializedFrame req( |
| 4359 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 4360 | MockWrite writes[] = {CreateMockWrite(req, 0)}; |
[email protected] | 79d8422 | 2010-02-26 00:01:44 | [diff] [blame] | 4361 | |
[email protected] | 20d005f | 2010-07-02 19:55:43 | [diff] [blame] | 4362 | // 2 data frames in a single read. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4363 | spdy::SpdySerializedFrame data_frame_1( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 4364 | spdy_util_.ConstructSpdyDataFrame(1, "goodby", /*fin=*/false)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4365 | spdy::SpdySerializedFrame data_frame_2( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 4366 | spdy_util_.ConstructSpdyDataFrame(1, "e worl", /*fin=*/false)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4367 | spdy::SpdySerializedFrame combined_data_frames = |
bnc | ef26b60 | 2017-06-12 22:08:19 | [diff] [blame] | 4368 | CombineFrames({&data_frame_1, &data_frame_2}); |
| 4369 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4370 | spdy::SpdySerializedFrame last_frame( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 4371 | spdy_util_.ConstructSpdyDataFrame(1, "d", /*fin=*/true)); |
[email protected] | 79d8422 | 2010-02-26 00:01:44 | [diff] [blame] | 4372 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4373 | spdy::SpdySerializedFrame resp( |
| 4374 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
[email protected] | 79d8422 | 2010-02-26 00:01:44 | [diff] [blame] | 4375 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 4376 | CreateMockRead(resp, 1), |
rch | 3232084 | 2015-05-16 15:57:09 | [diff] [blame] | 4377 | MockRead(ASYNC, ERR_IO_PENDING, 2), // Force a pause |
bnc | ef26b60 | 2017-06-12 22:08:19 | [diff] [blame] | 4378 | CreateMockRead(combined_data_frames, 3), |
rch | 3232084 | 2015-05-16 15:57:09 | [diff] [blame] | 4379 | MockRead(ASYNC, ERR_IO_PENDING, 4), // Force a pause |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 4380 | CreateMockRead(last_frame, 5), |
rch | 3232084 | 2015-05-16 15:57:09 | [diff] [blame] | 4381 | MockRead(ASYNC, 0, 6) // EOF |
[email protected] | 79d8422 | 2010-02-26 00:01:44 | [diff] [blame] | 4382 | }; |
| 4383 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 4384 | SequencedSocketData data(reads, writes); |
[email protected] | 79d8422 | 2010-02-26 00:01:44 | [diff] [blame] | 4385 | |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 4386 | TestCompletionCallback callback; |
[email protected] | 79d8422 | 2010-02-26 00:01:44 | [diff] [blame] | 4387 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 4388 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 4389 | helper.RunPreTestSetup(); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 4390 | helper.AddData(&data); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 4391 | HttpNetworkTransaction* trans = helper.trans(); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 4392 | int rv = trans->Start(&request_, callback.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 4393 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | 79d8422 | 2010-02-26 00:01:44 | [diff] [blame] | 4394 | |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 4395 | TransactionHelperResult out = helper.output(); |
[email protected] | 79d8422 | 2010-02-26 00:01:44 | [diff] [blame] | 4396 | out.rv = callback.WaitForResult(); |
| 4397 | EXPECT_EQ(out.rv, OK); |
| 4398 | |
| 4399 | const HttpResponseInfo* response = trans->GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 4400 | EXPECT_TRUE(response->headers); |
[email protected] | 79d8422 | 2010-02-26 00:01:44 | [diff] [blame] | 4401 | EXPECT_TRUE(response->was_fetched_via_spdy); |
| 4402 | out.status_line = response->headers->GetStatusLine(); |
| 4403 | out.response_info = *response; // Make a copy so we can verify. |
| 4404 | |
| 4405 | // Read Data |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 4406 | TestCompletionCallback read_callback; |
[email protected] | 79d8422 | 2010-02-26 00:01:44 | [diff] [blame] | 4407 | |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 4408 | std::string content; |
[email protected] | 79d8422 | 2010-02-26 00:01:44 | [diff] [blame] | 4409 | do { |
| 4410 | // Read small chunks at a time. |
| 4411 | const int kSmallReadSize = 3; |
Victor Costan | 9c7302b | 2018-08-27 16:39:44 | [diff] [blame] | 4412 | scoped_refptr<IOBuffer> buf = |
| 4413 | base::MakeRefCounted<IOBuffer>(kSmallReadSize); |
[email protected] | 9049948 | 2013-06-01 00:39:50 | [diff] [blame] | 4414 | rv = trans->Read(buf.get(), kSmallReadSize, read_callback.callback()); |
bnc | 301745a | 2015-03-10 03:22:16 | [diff] [blame] | 4415 | if (rv == ERR_IO_PENDING) { |
mmenke | e2401192 | 2015-12-17 22:12:59 | [diff] [blame] | 4416 | data.Resume(); |
[email protected] | 79d8422 | 2010-02-26 00:01:44 | [diff] [blame] | 4417 | rv = read_callback.WaitForResult(); |
| 4418 | } |
| 4419 | if (rv > 0) { |
| 4420 | content.append(buf->data(), rv); |
| 4421 | } else if (rv < 0) { |
| 4422 | NOTREACHED(); |
| 4423 | } |
| 4424 | } while (rv > 0); |
| 4425 | |
| 4426 | out.response_data.swap(content); |
| 4427 | |
[email protected] | 30c942b | 2010-07-21 16:59:59 | [diff] [blame] | 4428 | // Flush the MessageLoop while the SpdySessionDependencies (in particular, the |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 4429 | // MockClientSocketFactory) are still alive. |
[email protected] | fc9d8847 | 2013-08-14 02:31:17 | [diff] [blame] | 4430 | base::RunLoop().RunUntilIdle(); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 4431 | |
[email protected] | 79d8422 | 2010-02-26 00:01:44 | [diff] [blame] | 4432 | // Verify that we consumed all test data. |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 4433 | helper.VerifyDataConsumed(); |
[email protected] | 79d8422 | 2010-02-26 00:01:44 | [diff] [blame] | 4434 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 4435 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 4436 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | 79d8422 | 2010-02-26 00:01:44 | [diff] [blame] | 4437 | EXPECT_EQ("goodbye world", out.response_data); |
| 4438 | } |
| 4439 | |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 4440 | // Verify that basic buffering works; when multiple data frames arrive |
| 4441 | // at the same time, ensure that we don't notify a read completion for |
| 4442 | // each data frame individually. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 4443 | TEST_F(SpdyNetworkTransactionTest, Buffering) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4444 | spdy::SpdySerializedFrame req( |
| 4445 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 4446 | MockWrite writes[] = {CreateMockWrite(req, 0)}; |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 4447 | |
| 4448 | // 4 data frames in a single read. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4449 | spdy::SpdySerializedFrame data_frame( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 4450 | spdy_util_.ConstructSpdyDataFrame(1, "message", /*fin=*/false)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4451 | spdy::SpdySerializedFrame data_frame_fin( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 4452 | spdy_util_.ConstructSpdyDataFrame(1, "message", /*fin=*/true)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4453 | spdy::SpdySerializedFrame combined_data_frames = |
bnc | ef26b60 | 2017-06-12 22:08:19 | [diff] [blame] | 4454 | CombineFrames({&data_frame, &data_frame, &data_frame, &data_frame_fin}); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 4455 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4456 | spdy::SpdySerializedFrame resp( |
| 4457 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 4458 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 4459 | CreateMockRead(resp, 1), |
rch | 3232084 | 2015-05-16 15:57:09 | [diff] [blame] | 4460 | MockRead(ASYNC, ERR_IO_PENDING, 2), // Force a pause |
bnc | ef26b60 | 2017-06-12 22:08:19 | [diff] [blame] | 4461 | CreateMockRead(combined_data_frames, 3), MockRead(ASYNC, 0, 4) // EOF |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 4462 | }; |
| 4463 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 4464 | SequencedSocketData data(reads, writes); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 4465 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 4466 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 4467 | helper.RunPreTestSetup(); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 4468 | helper.AddData(&data); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 4469 | HttpNetworkTransaction* trans = helper.trans(); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 4470 | |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 4471 | TestCompletionCallback callback; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 4472 | int rv = trans->Start(&request_, callback.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 4473 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 4474 | |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 4475 | TransactionHelperResult out = helper.output(); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 4476 | out.rv = callback.WaitForResult(); |
| 4477 | EXPECT_EQ(out.rv, OK); |
| 4478 | |
| 4479 | const HttpResponseInfo* response = trans->GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 4480 | EXPECT_TRUE(response->headers); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 4481 | EXPECT_TRUE(response->was_fetched_via_spdy); |
| 4482 | out.status_line = response->headers->GetStatusLine(); |
| 4483 | out.response_info = *response; // Make a copy so we can verify. |
| 4484 | |
| 4485 | // Read Data |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 4486 | TestCompletionCallback read_callback; |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 4487 | |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 4488 | std::string content; |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 4489 | int reads_completed = 0; |
| 4490 | do { |
| 4491 | // Read small chunks at a time. |
| 4492 | const int kSmallReadSize = 14; |
Victor Costan | 9c7302b | 2018-08-27 16:39:44 | [diff] [blame] | 4493 | scoped_refptr<IOBuffer> buf = |
| 4494 | base::MakeRefCounted<IOBuffer>(kSmallReadSize); |
[email protected] | 9049948 | 2013-06-01 00:39:50 | [diff] [blame] | 4495 | rv = trans->Read(buf.get(), kSmallReadSize, read_callback.callback()); |
bnc | 301745a | 2015-03-10 03:22:16 | [diff] [blame] | 4496 | if (rv == ERR_IO_PENDING) { |
mmenke | e2401192 | 2015-12-17 22:12:59 | [diff] [blame] | 4497 | data.Resume(); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 4498 | rv = read_callback.WaitForResult(); |
| 4499 | } |
| 4500 | if (rv > 0) { |
| 4501 | EXPECT_EQ(kSmallReadSize, rv); |
| 4502 | content.append(buf->data(), rv); |
| 4503 | } else if (rv < 0) { |
| 4504 | FAIL() << "Unexpected read error: " << rv; |
| 4505 | } |
| 4506 | reads_completed++; |
| 4507 | } while (rv > 0); |
| 4508 | |
| 4509 | EXPECT_EQ(3, reads_completed); // Reads are: 14 bytes, 14 bytes, 0 bytes. |
| 4510 | |
| 4511 | out.response_data.swap(content); |
| 4512 | |
[email protected] | 30c942b | 2010-07-21 16:59:59 | [diff] [blame] | 4513 | // Flush the MessageLoop while the SpdySessionDependencies (in particular, the |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 4514 | // MockClientSocketFactory) are still alive. |
[email protected] | fc9d8847 | 2013-08-14 02:31:17 | [diff] [blame] | 4515 | base::RunLoop().RunUntilIdle(); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 4516 | |
| 4517 | // Verify that we consumed all test data. |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 4518 | helper.VerifyDataConsumed(); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 4519 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 4520 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 4521 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 4522 | EXPECT_EQ("messagemessagemessagemessage", out.response_data); |
| 4523 | } |
| 4524 | |
| 4525 | // Verify the case where we buffer data but read it after it has been buffered. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 4526 | TEST_F(SpdyNetworkTransactionTest, BufferedAll) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4527 | spdy::SpdySerializedFrame req( |
| 4528 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 4529 | MockWrite writes[] = {CreateMockWrite(req, 0)}; |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 4530 | |
[email protected] | 20d005f | 2010-07-02 19:55:43 | [diff] [blame] | 4531 | // 5 data frames in a single read. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4532 | spdy::SpdySerializedFrame reply( |
| 4533 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 4534 | spdy::SpdySerializedFrame data_frame( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 4535 | spdy_util_.ConstructSpdyDataFrame(1, "message", /*fin=*/false)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4536 | spdy::SpdySerializedFrame data_frame_fin( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 4537 | spdy_util_.ConstructSpdyDataFrame(1, "message", /*fin=*/true)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4538 | spdy::SpdySerializedFrame combined_frames = CombineFrames( |
bnc | ef26b60 | 2017-06-12 22:08:19 | [diff] [blame] | 4539 | {&reply, &data_frame, &data_frame, &data_frame, &data_frame_fin}); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 4540 | |
| 4541 | MockRead reads[] = { |
bnc | ef26b60 | 2017-06-12 22:08:19 | [diff] [blame] | 4542 | CreateMockRead(combined_frames, 1), MockRead(ASYNC, 0, 2) // EOF |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 4543 | }; |
| 4544 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 4545 | SequencedSocketData data(reads, writes); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 4546 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 4547 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 4548 | helper.RunPreTestSetup(); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 4549 | helper.AddData(&data); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 4550 | HttpNetworkTransaction* trans = helper.trans(); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 4551 | |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 4552 | TestCompletionCallback callback; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 4553 | int rv = trans->Start(&request_, callback.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 4554 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 4555 | |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 4556 | TransactionHelperResult out = helper.output(); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 4557 | out.rv = callback.WaitForResult(); |
| 4558 | EXPECT_EQ(out.rv, OK); |
| 4559 | |
| 4560 | const HttpResponseInfo* response = trans->GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 4561 | EXPECT_TRUE(response->headers); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 4562 | EXPECT_TRUE(response->was_fetched_via_spdy); |
| 4563 | out.status_line = response->headers->GetStatusLine(); |
| 4564 | out.response_info = *response; // Make a copy so we can verify. |
| 4565 | |
| 4566 | // Read Data |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 4567 | TestCompletionCallback read_callback; |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 4568 | |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 4569 | std::string content; |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 4570 | int reads_completed = 0; |
| 4571 | do { |
| 4572 | // Read small chunks at a time. |
| 4573 | const int kSmallReadSize = 14; |
Victor Costan | 9c7302b | 2018-08-27 16:39:44 | [diff] [blame] | 4574 | scoped_refptr<IOBuffer> buf = |
| 4575 | base::MakeRefCounted<IOBuffer>(kSmallReadSize); |
[email protected] | 9049948 | 2013-06-01 00:39:50 | [diff] [blame] | 4576 | rv = trans->Read(buf.get(), kSmallReadSize, read_callback.callback()); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 4577 | if (rv > 0) { |
| 4578 | EXPECT_EQ(kSmallReadSize, rv); |
| 4579 | content.append(buf->data(), rv); |
| 4580 | } else if (rv < 0) { |
| 4581 | FAIL() << "Unexpected read error: " << rv; |
| 4582 | } |
| 4583 | reads_completed++; |
| 4584 | } while (rv > 0); |
| 4585 | |
| 4586 | EXPECT_EQ(3, reads_completed); |
| 4587 | |
| 4588 | out.response_data.swap(content); |
| 4589 | |
[email protected] | 30c942b | 2010-07-21 16:59:59 | [diff] [blame] | 4590 | // Flush the MessageLoop while the SpdySessionDependencies (in particular, the |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 4591 | // MockClientSocketFactory) are still alive. |
[email protected] | fc9d8847 | 2013-08-14 02:31:17 | [diff] [blame] | 4592 | base::RunLoop().RunUntilIdle(); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 4593 | |
| 4594 | // Verify that we consumed all test data. |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 4595 | helper.VerifyDataConsumed(); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 4596 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 4597 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 4598 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 4599 | EXPECT_EQ("messagemessagemessagemessage", out.response_data); |
| 4600 | } |
| 4601 | |
| 4602 | // Verify the case where we buffer data and close the connection. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 4603 | TEST_F(SpdyNetworkTransactionTest, BufferedClosed) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4604 | spdy::SpdySerializedFrame req( |
| 4605 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 4606 | MockWrite writes[] = {CreateMockWrite(req, 0)}; |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 4607 | |
| 4608 | // All data frames in a single read. |
[email protected] | 20d005f | 2010-07-02 19:55:43 | [diff] [blame] | 4609 | // NOTE: We don't FIN the stream. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4610 | spdy::SpdySerializedFrame data_frame( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 4611 | spdy_util_.ConstructSpdyDataFrame(1, "message", /*fin=*/false)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4612 | spdy::SpdySerializedFrame combined_data_frames = |
bnc | ef26b60 | 2017-06-12 22:08:19 | [diff] [blame] | 4613 | CombineFrames({&data_frame, &data_frame, &data_frame, &data_frame}); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4614 | spdy::SpdySerializedFrame resp( |
| 4615 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 4616 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 4617 | CreateMockRead(resp, 1), |
rch | 3232084 | 2015-05-16 15:57:09 | [diff] [blame] | 4618 | MockRead(ASYNC, ERR_IO_PENDING, 2), // Force a wait |
bnc | ef26b60 | 2017-06-12 22:08:19 | [diff] [blame] | 4619 | CreateMockRead(combined_data_frames, 3), MockRead(ASYNC, 0, 4) // EOF |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 4620 | }; |
| 4621 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 4622 | SequencedSocketData data(reads, writes); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 4623 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 4624 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 4625 | helper.RunPreTestSetup(); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 4626 | helper.AddData(&data); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 4627 | HttpNetworkTransaction* trans = helper.trans(); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 4628 | |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 4629 | TestCompletionCallback callback; |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 4630 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 4631 | int rv = trans->Start(&request_, callback.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 4632 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 4633 | |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 4634 | TransactionHelperResult out = helper.output(); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 4635 | out.rv = callback.WaitForResult(); |
| 4636 | EXPECT_EQ(out.rv, OK); |
| 4637 | |
| 4638 | const HttpResponseInfo* response = trans->GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 4639 | EXPECT_TRUE(response->headers); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 4640 | EXPECT_TRUE(response->was_fetched_via_spdy); |
| 4641 | out.status_line = response->headers->GetStatusLine(); |
| 4642 | out.response_info = *response; // Make a copy so we can verify. |
| 4643 | |
| 4644 | // Read Data |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 4645 | TestCompletionCallback read_callback; |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 4646 | |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 4647 | std::string content; |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 4648 | int reads_completed = 0; |
| 4649 | do { |
| 4650 | // Read small chunks at a time. |
| 4651 | const int kSmallReadSize = 14; |
Victor Costan | 9c7302b | 2018-08-27 16:39:44 | [diff] [blame] | 4652 | scoped_refptr<IOBuffer> buf = |
| 4653 | base::MakeRefCounted<IOBuffer>(kSmallReadSize); |
[email protected] | 9049948 | 2013-06-01 00:39:50 | [diff] [blame] | 4654 | rv = trans->Read(buf.get(), kSmallReadSize, read_callback.callback()); |
bnc | 301745a | 2015-03-10 03:22:16 | [diff] [blame] | 4655 | if (rv == ERR_IO_PENDING) { |
mmenke | e2401192 | 2015-12-17 22:12:59 | [diff] [blame] | 4656 | data.Resume(); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 4657 | rv = read_callback.WaitForResult(); |
| 4658 | } |
| 4659 | if (rv > 0) { |
| 4660 | content.append(buf->data(), rv); |
| 4661 | } else if (rv < 0) { |
| 4662 | // This test intentionally closes the connection, and will get an error. |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 4663 | EXPECT_THAT(rv, IsError(ERR_CONNECTION_CLOSED)); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 4664 | break; |
| 4665 | } |
| 4666 | reads_completed++; |
| 4667 | } while (rv > 0); |
| 4668 | |
| 4669 | EXPECT_EQ(0, reads_completed); |
| 4670 | |
| 4671 | out.response_data.swap(content); |
| 4672 | |
[email protected] | 30c942b | 2010-07-21 16:59:59 | [diff] [blame] | 4673 | // Flush the MessageLoop while the SpdySessionDependencies (in particular, the |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 4674 | // MockClientSocketFactory) are still alive. |
[email protected] | fc9d8847 | 2013-08-14 02:31:17 | [diff] [blame] | 4675 | base::RunLoop().RunUntilIdle(); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 4676 | |
| 4677 | // Verify that we consumed all test data. |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 4678 | helper.VerifyDataConsumed(); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 4679 | } |
| 4680 | |
[email protected] | 1ed7b3dc | 2010-03-04 05:41:45 | [diff] [blame] | 4681 | // Verify the case where we buffer data and cancel the transaction. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 4682 | TEST_F(SpdyNetworkTransactionTest, BufferedCancelled) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4683 | spdy::SpdySerializedFrame req( |
| 4684 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 4685 | spdy::SpdySerializedFrame rst( |
| 4686 | spdy_util_.ConstructSpdyRstStream(1, spdy::ERROR_CODE_CANCEL)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 4687 | MockWrite writes[] = {CreateMockWrite(req, 0), CreateMockWrite(rst, 4)}; |
[email protected] | 1ed7b3dc | 2010-03-04 05:41:45 | [diff] [blame] | 4688 | |
[email protected] | 20d005f | 2010-07-02 19:55:43 | [diff] [blame] | 4689 | // NOTE: We don't FIN the stream. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4690 | spdy::SpdySerializedFrame data_frame( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 4691 | spdy_util_.ConstructSpdyDataFrame(1, "message", /*fin=*/false)); |
[email protected] | 1ed7b3dc | 2010-03-04 05:41:45 | [diff] [blame] | 4692 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4693 | spdy::SpdySerializedFrame resp( |
| 4694 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
[email protected] | 1ed7b3dc | 2010-03-04 05:41:45 | [diff] [blame] | 4695 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 4696 | CreateMockRead(resp, 1), |
| 4697 | MockRead(ASYNC, ERR_IO_PENDING, 2), // Force a wait |
| 4698 | CreateMockRead(data_frame, 3), MockRead(ASYNC, 0, 5) // EOF |
[email protected] | 1ed7b3dc | 2010-03-04 05:41:45 | [diff] [blame] | 4699 | }; |
| 4700 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 4701 | SequencedSocketData data(reads, writes); |
[email protected] | 1ed7b3dc | 2010-03-04 05:41:45 | [diff] [blame] | 4702 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 4703 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 4704 | helper.RunPreTestSetup(); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 4705 | helper.AddData(&data); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 4706 | HttpNetworkTransaction* trans = helper.trans(); |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 4707 | TestCompletionCallback callback; |
[email protected] | 1ed7b3dc | 2010-03-04 05:41:45 | [diff] [blame] | 4708 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 4709 | int rv = trans->Start(&request_, callback.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 4710 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | 1ed7b3dc | 2010-03-04 05:41:45 | [diff] [blame] | 4711 | |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 4712 | TransactionHelperResult out = helper.output(); |
[email protected] | 1ed7b3dc | 2010-03-04 05:41:45 | [diff] [blame] | 4713 | out.rv = callback.WaitForResult(); |
| 4714 | EXPECT_EQ(out.rv, OK); |
| 4715 | |
| 4716 | const HttpResponseInfo* response = trans->GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 4717 | EXPECT_TRUE(response->headers); |
[email protected] | 1ed7b3dc | 2010-03-04 05:41:45 | [diff] [blame] | 4718 | EXPECT_TRUE(response->was_fetched_via_spdy); |
| 4719 | out.status_line = response->headers->GetStatusLine(); |
| 4720 | out.response_info = *response; // Make a copy so we can verify. |
| 4721 | |
| 4722 | // Read Data |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 4723 | TestCompletionCallback read_callback; |
[email protected] | 1ed7b3dc | 2010-03-04 05:41:45 | [diff] [blame] | 4724 | |
[email protected] | 88c7b4be | 2014-03-19 23:04:01 | [diff] [blame] | 4725 | const int kReadSize = 256; |
Victor Costan | 9c7302b | 2018-08-27 16:39:44 | [diff] [blame] | 4726 | scoped_refptr<IOBuffer> buf = base::MakeRefCounted<IOBuffer>(kReadSize); |
[email protected] | 88c7b4be | 2014-03-19 23:04:01 | [diff] [blame] | 4727 | rv = trans->Read(buf.get(), kReadSize, read_callback.callback()); |
bnc | 301745a | 2015-03-10 03:22:16 | [diff] [blame] | 4728 | ASSERT_EQ(ERR_IO_PENDING, rv) << "Unexpected read: " << rv; |
[email protected] | 88c7b4be | 2014-03-19 23:04:01 | [diff] [blame] | 4729 | |
| 4730 | // Complete the read now, which causes buffering to start. |
mmenke | e2401192 | 2015-12-17 22:12:59 | [diff] [blame] | 4731 | data.Resume(); |
| 4732 | base::RunLoop().RunUntilIdle(); |
[email protected] | 88c7b4be | 2014-03-19 23:04:01 | [diff] [blame] | 4733 | // Destroy the transaction, causing the stream to get cancelled |
| 4734 | // and orphaning the buffered IO task. |
| 4735 | helper.ResetTrans(); |
[email protected] | 1ed7b3dc | 2010-03-04 05:41:45 | [diff] [blame] | 4736 | |
| 4737 | // Flush the MessageLoop; this will cause the buffered IO task |
| 4738 | // to run for the final time. |
[email protected] | fc9d8847 | 2013-08-14 02:31:17 | [diff] [blame] | 4739 | base::RunLoop().RunUntilIdle(); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 4740 | |
| 4741 | // Verify that we consumed all test data. |
| 4742 | helper.VerifyDataConsumed(); |
[email protected] | 1ed7b3dc | 2010-03-04 05:41:45 | [diff] [blame] | 4743 | } |
| 4744 | |
bnc | c4769d41 | 2017-04-19 19:57:54 | [diff] [blame] | 4745 | // Request should fail upon receiving a GOAWAY frame |
| 4746 | // with Last-Stream-ID lower than the stream id corresponding to the request |
| 4747 | // and with error code other than NO_ERROR. |
| 4748 | TEST_F(SpdyNetworkTransactionTest, FailOnGoAway) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4749 | spdy::SpdySerializedFrame req( |
| 4750 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 4751 | MockWrite writes[] = {CreateMockWrite(req, 0)}; |
[email protected] | 69d717bd | 2010-04-21 18:43:21 | [diff] [blame] | 4752 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4753 | spdy::SpdySerializedFrame go_away( |
| 4754 | spdy_util_.ConstructSpdyGoAway(0, spdy::ERROR_CODE_INTERNAL_ERROR, "")); |
[email protected] | 69d717bd | 2010-04-21 18:43:21 | [diff] [blame] | 4755 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 4756 | CreateMockRead(go_away, 1), |
[email protected] | 58cebf8f | 2010-07-31 19:20:16 | [diff] [blame] | 4757 | }; |
| 4758 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 4759 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 4760 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 4761 | helper.RunToCompletion(&data); |
[email protected] | 58cebf8f | 2010-07-31 19:20:16 | [diff] [blame] | 4762 | TransactionHelperResult out = helper.output(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 4763 | EXPECT_THAT(out.rv, IsError(ERR_ABORTED)); |
[email protected] | 69d717bd | 2010-04-21 18:43:21 | [diff] [blame] | 4764 | } |
| 4765 | |
bnc | c4769d41 | 2017-04-19 19:57:54 | [diff] [blame] | 4766 | // Request should be retried on a new connection upon receiving a GOAWAY frame |
| 4767 | // with Last-Stream-ID lower than the stream id corresponding to the request |
| 4768 | // and with error code NO_ERROR. |
| 4769 | TEST_F(SpdyNetworkTransactionTest, RetryOnGoAway) { |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 4770 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
bnc | c4769d41 | 2017-04-19 19:57:54 | [diff] [blame] | 4771 | |
| 4772 | // First connection. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4773 | spdy::SpdySerializedFrame req( |
| 4774 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
bnc | c4769d41 | 2017-04-19 19:57:54 | [diff] [blame] | 4775 | MockWrite writes1[] = {CreateMockWrite(req, 0)}; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4776 | spdy::SpdySerializedFrame go_away( |
| 4777 | spdy_util_.ConstructSpdyGoAway(0, spdy::ERROR_CODE_NO_ERROR, "")); |
bnc | c4769d41 | 2017-04-19 19:57:54 | [diff] [blame] | 4778 | MockRead reads1[] = {CreateMockRead(go_away, 1)}; |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 4779 | SequencedSocketData data1(reads1, writes1); |
bnc | c4769d41 | 2017-04-19 19:57:54 | [diff] [blame] | 4780 | helper.AddData(&data1); |
| 4781 | |
| 4782 | // Second connection. |
| 4783 | MockWrite writes2[] = {CreateMockWrite(req, 0)}; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4784 | spdy::SpdySerializedFrame resp( |
| 4785 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 4786 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
bnc | c4769d41 | 2017-04-19 19:57:54 | [diff] [blame] | 4787 | MockRead reads2[] = {CreateMockRead(resp, 1), CreateMockRead(body, 2), |
| 4788 | MockRead(ASYNC, 0, 3)}; |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 4789 | SequencedSocketData data2(reads2, writes2); |
bnc | c4769d41 | 2017-04-19 19:57:54 | [diff] [blame] | 4790 | helper.AddData(&data2); |
| 4791 | |
| 4792 | helper.RunPreTestSetup(); |
| 4793 | helper.RunDefaultTest(); |
| 4794 | |
| 4795 | TransactionHelperResult out = helper.output(); |
| 4796 | EXPECT_THAT(out.rv, IsOk()); |
| 4797 | |
| 4798 | helper.VerifyDataConsumed(); |
| 4799 | } |
| 4800 | |
bnc | 1fc7b35 | 2017-01-12 17:51:02 | [diff] [blame] | 4801 | // A server can gracefully shut down by sending a GOAWAY frame |
| 4802 | // with maximum last-stream-id value. |
| 4803 | // Transactions started before receiving such a GOAWAY frame should succeed, |
| 4804 | // but SpdySession should be unavailable for new streams. |
| 4805 | TEST_F(SpdyNetworkTransactionTest, GracefulGoaway) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4806 | spdy::SpdySerializedFrame req1( |
| 4807 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
bnc | 1fc7b35 | 2017-01-12 17:51:02 | [diff] [blame] | 4808 | spdy_util_.UpdateWithStreamDestruction(1); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4809 | spdy::SpdySerializedFrame req2( |
bnc | 1fc7b35 | 2017-01-12 17:51:02 | [diff] [blame] | 4810 | spdy_util_.ConstructSpdyGet("https://www.example.org/foo", 3, LOWEST)); |
| 4811 | MockWrite writes[] = {CreateMockWrite(req1, 0), CreateMockWrite(req2, 3)}; |
| 4812 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4813 | spdy::SpdySerializedFrame resp1( |
| 4814 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 4815 | spdy::SpdySerializedFrame body1(spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 4816 | spdy::SpdySerializedFrame goaway(spdy_util_.ConstructSpdyGoAway( |
| 4817 | 0x7fffffff, spdy::ERROR_CODE_NO_ERROR, "Graceful shutdown.")); |
| 4818 | spdy::SpdySerializedFrame resp2( |
| 4819 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 3)); |
| 4820 | spdy::SpdySerializedFrame body2(spdy_util_.ConstructSpdyDataFrame(3, true)); |
bnc | 1fc7b35 | 2017-01-12 17:51:02 | [diff] [blame] | 4821 | MockRead reads[] = {CreateMockRead(resp1, 1), CreateMockRead(body1, 2), |
| 4822 | CreateMockRead(goaway, 4), CreateMockRead(resp2, 5), |
| 4823 | CreateMockRead(body2, 6), MockRead(ASYNC, 0, 7)}; |
| 4824 | |
| 4825 | // Run first transaction. |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 4826 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 4827 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
bnc | 1fc7b35 | 2017-01-12 17:51:02 | [diff] [blame] | 4828 | helper.RunPreTestSetup(); |
| 4829 | helper.AddData(&data); |
| 4830 | helper.RunDefaultTest(); |
| 4831 | |
| 4832 | // Verify first response. |
| 4833 | TransactionHelperResult out = helper.output(); |
| 4834 | EXPECT_THAT(out.rv, IsOk()); |
| 4835 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
| 4836 | EXPECT_EQ("hello!", out.response_data); |
| 4837 | |
| 4838 | // GOAWAY frame has not yet been received, SpdySession should be available. |
| 4839 | SpdySessionPool* spdy_session_pool = helper.session()->spdy_session_pool(); |
| 4840 | SpdySessionKey key(host_port_pair_, ProxyServer::Direct(), |
Matt Menke | 2436b2f | 2018-12-11 18:07:11 | [diff] [blame] | 4841 | PRIVACY_MODE_DISABLED, |
| 4842 | SpdySessionKey::IsProxySession::kFalse, SocketTag()); |
bnc | 1fc7b35 | 2017-01-12 17:51:02 | [diff] [blame] | 4843 | base::WeakPtr<SpdySession> spdy_session = |
bnc | 9ead3ae | 2017-03-16 00:48:15 | [diff] [blame] | 4844 | spdy_session_pool->FindAvailableSession( |
Bence Béky | d885b2b | 2018-02-03 00:58:31 | [diff] [blame] | 4845 | key, /* enable_ip_based_pooling = */ true, |
| 4846 | /* is_websocket = */ false, log_); |
bnc | 1fc7b35 | 2017-01-12 17:51:02 | [diff] [blame] | 4847 | EXPECT_TRUE(spdy_session); |
| 4848 | |
| 4849 | // Start second transaction. |
| 4850 | HttpNetworkTransaction trans2(DEFAULT_PRIORITY, helper.session()); |
| 4851 | TestCompletionCallback callback; |
| 4852 | HttpRequestInfo request2; |
| 4853 | request2.method = "GET"; |
| 4854 | request2.url = GURL("https://www.example.org/foo"); |
Ramin Halavati | b5e433e6 | 2018-02-07 07:41:10 | [diff] [blame] | 4855 | request2.traffic_annotation = |
| 4856 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
Bence Béky | d3dde83 | 2017-09-19 19:02:31 | [diff] [blame] | 4857 | int rv = trans2.Start(&request2, callback.callback(), log_); |
bnc | 1fc7b35 | 2017-01-12 17:51:02 | [diff] [blame] | 4858 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 4859 | rv = callback.WaitForResult(); |
| 4860 | EXPECT_THAT(rv, IsOk()); |
| 4861 | |
| 4862 | // Verify second response. |
| 4863 | const HttpResponseInfo* response = trans2.GetResponseInfo(); |
| 4864 | ASSERT_TRUE(response); |
| 4865 | EXPECT_EQ(HttpResponseInfo::CONNECTION_INFO_HTTP2, response->connection_info); |
| 4866 | ASSERT_TRUE(response->headers); |
| 4867 | EXPECT_EQ("HTTP/1.1 200", response->headers->GetStatusLine()); |
| 4868 | EXPECT_TRUE(response->was_fetched_via_spdy); |
| 4869 | EXPECT_TRUE(response->was_alpn_negotiated); |
Tsuyoshi Horo | 01faed6 | 2019-02-20 22:11:37 | [diff] [blame] | 4870 | EXPECT_EQ("127.0.0.1", response->remote_endpoint.ToStringWithoutPort()); |
| 4871 | EXPECT_EQ(443, response->remote_endpoint.port()); |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 4872 | std::string response_data; |
bnc | 1fc7b35 | 2017-01-12 17:51:02 | [diff] [blame] | 4873 | rv = ReadTransaction(&trans2, &response_data); |
| 4874 | EXPECT_THAT(rv, IsOk()); |
| 4875 | EXPECT_EQ("hello!", response_data); |
| 4876 | |
| 4877 | // Graceful GOAWAY was received, SpdySession should be unavailable. |
bnc | 9ead3ae | 2017-03-16 00:48:15 | [diff] [blame] | 4878 | spdy_session = spdy_session_pool->FindAvailableSession( |
Bence Béky | d885b2b | 2018-02-03 00:58:31 | [diff] [blame] | 4879 | key, /* enable_ip_based_pooling = */ true, |
| 4880 | /* is_websocket = */ false, log_); |
bnc | 1fc7b35 | 2017-01-12 17:51:02 | [diff] [blame] | 4881 | EXPECT_FALSE(spdy_session); |
| 4882 | |
| 4883 | helper.VerifyDataConsumed(); |
| 4884 | } |
| 4885 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 4886 | TEST_F(SpdyNetworkTransactionTest, CloseWithActiveStream) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4887 | spdy::SpdySerializedFrame req( |
| 4888 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 4889 | MockWrite writes[] = {CreateMockWrite(req, 0)}; |
[email protected] | f5ed2155 | 2010-05-04 18:39:54 | [diff] [blame] | 4890 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4891 | spdy::SpdySerializedFrame resp( |
| 4892 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
[email protected] | f5ed2155 | 2010-05-04 18:39:54 | [diff] [blame] | 4893 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 4894 | CreateMockRead(resp, 1), MockRead(SYNCHRONOUS, 0, 2) // EOF |
[email protected] | f5ed2155 | 2010-05-04 18:39:54 | [diff] [blame] | 4895 | }; |
| 4896 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 4897 | SequencedSocketData data(reads, writes); |
bnc | 4d782f49 | 2016-08-18 13:50:00 | [diff] [blame] | 4898 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 4899 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 4900 | helper.RunPreTestSetup(); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 4901 | helper.AddData(&data); |
bnc | 4d782f49 | 2016-08-18 13:50:00 | [diff] [blame] | 4902 | helper.StartDefaultTest(); |
| 4903 | EXPECT_THAT(helper.output().rv, IsError(ERR_IO_PENDING)); |
[email protected] | f5ed2155 | 2010-05-04 18:39:54 | [diff] [blame] | 4904 | |
bnc | 4d782f49 | 2016-08-18 13:50:00 | [diff] [blame] | 4905 | helper.WaitForCallbackToComplete(); |
| 4906 | EXPECT_THAT(helper.output().rv, IsError(ERR_CONNECTION_CLOSED)); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 4907 | |
bnc | 4d782f49 | 2016-08-18 13:50:00 | [diff] [blame] | 4908 | const HttpResponseInfo* response = helper.trans()->GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 4909 | EXPECT_TRUE(response->headers); |
[email protected] | f5ed2155 | 2010-05-04 18:39:54 | [diff] [blame] | 4910 | EXPECT_TRUE(response->was_fetched_via_spdy); |
[email protected] | f5ed2155 | 2010-05-04 18:39:54 | [diff] [blame] | 4911 | |
| 4912 | // Verify that we consumed all test data. |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 4913 | helper.VerifyDataConsumed(); |
[email protected] | f5ed2155 | 2010-05-04 18:39:54 | [diff] [blame] | 4914 | } |
[email protected] | 58cebf8f | 2010-07-31 19:20:16 | [diff] [blame] | 4915 | |
Bence Béky | c2d3795 | 2017-11-20 16:58:16 | [diff] [blame] | 4916 | TEST_F(SpdyNetworkTransactionTest, GoAwayImmediately) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4917 | spdy::SpdySerializedFrame goaway(spdy_util_.ConstructSpdyGoAway(1)); |
Bence Béky | c2d3795 | 2017-11-20 16:58:16 | [diff] [blame] | 4918 | MockRead reads[] = {CreateMockRead(goaway, 0, SYNCHRONOUS)}; |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 4919 | SequencedSocketData data(reads, base::span<MockWrite>()); |
Bence Béky | c2d3795 | 2017-11-20 16:58:16 | [diff] [blame] | 4920 | |
| 4921 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
| 4922 | helper.RunPreTestSetup(); |
| 4923 | helper.AddData(&data); |
| 4924 | helper.StartDefaultTest(); |
| 4925 | EXPECT_THAT(helper.output().rv, IsError(ERR_IO_PENDING)); |
| 4926 | |
| 4927 | helper.WaitForCallbackToComplete(); |
| 4928 | EXPECT_THAT(helper.output().rv, IsError(ERR_CONNECTION_CLOSED)); |
| 4929 | |
| 4930 | const HttpResponseInfo* response = helper.trans()->GetResponseInfo(); |
| 4931 | EXPECT_FALSE(response->headers); |
| 4932 | EXPECT_TRUE(response->was_fetched_via_spdy); |
| 4933 | |
| 4934 | // Verify that we consumed all test data. |
| 4935 | helper.VerifyDataConsumed(); |
| 4936 | } |
| 4937 | |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 4938 | // Retry with HTTP/1.1 when receiving HTTP_1_1_REQUIRED. Note that no actual |
| 4939 | // protocol negotiation happens, instead this test forces protocols for both |
| 4940 | // sockets. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 4941 | TEST_F(SpdyNetworkTransactionTest, HTTP11RequiredRetry) { |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 4942 | request_.method = "GET"; |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 4943 | // Do not force SPDY so that second socket can negotiate HTTP/1.1. |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 4944 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 4945 | |
| 4946 | // First socket: HTTP/2 request rejected with HTTP_1_1_REQUIRED. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4947 | spdy::SpdyHeaderBlock headers( |
| 4948 | spdy_util_.ConstructGetHeaderBlock(kDefaultUrl)); |
| 4949 | spdy::SpdySerializedFrame req( |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 4950 | spdy_util_.ConstructSpdyHeaders(1, std::move(headers), LOWEST, true)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 4951 | MockWrite writes0[] = {CreateMockWrite(req, 0)}; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4952 | spdy::SpdySerializedFrame rst( |
| 4953 | spdy_util_.ConstructSpdyRstStream(1, spdy::ERROR_CODE_HTTP_1_1_REQUIRED)); |
Bence Béky | cb361312 | 2017-09-19 17:06:57 | [diff] [blame] | 4954 | MockRead reads0[] = {CreateMockRead(rst, 1)}; |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 4955 | SequencedSocketData data0(reads0, writes0); |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 4956 | |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 4957 | auto ssl_provider0 = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 4958 | // Expect HTTP/2 protocols too in SSLConfig. |
Bence Béky | 27a19b8 | 2018-01-30 14:58:36 | [diff] [blame] | 4959 | ssl_provider0->next_protos_expected_in_ssl_config = |
| 4960 | NextProtoVector{kProtoHTTP2, kProtoHTTP11}; |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 4961 | // Force SPDY. |
bnc | 3cf2a59 | 2016-08-11 14:48:36 | [diff] [blame] | 4962 | ssl_provider0->next_proto = kProtoHTTP2; |
dcheng | c7eeda42 | 2015-12-26 03:56:48 | [diff] [blame] | 4963 | helper.AddDataWithSSLSocketDataProvider(&data0, std::move(ssl_provider0)); |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 4964 | |
| 4965 | // Second socket: falling back to HTTP/1.1. |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 4966 | MockWrite writes1[] = {MockWrite(ASYNC, 0, |
| 4967 | "GET / HTTP/1.1\r\n" |
| 4968 | "Host: www.example.org\r\n" |
| 4969 | "Connection: keep-alive\r\n\r\n")}; |
| 4970 | MockRead reads1[] = {MockRead(ASYNC, 1, |
| 4971 | "HTTP/1.1 200 OK\r\n" |
| 4972 | "Content-Length: 5\r\n\r\n" |
| 4973 | "hello")}; |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 4974 | SequencedSocketData data1(reads1, writes1); |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 4975 | |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 4976 | auto ssl_provider1 = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 4977 | // Expect only HTTP/1.1 protocol in SSLConfig. |
Bence Béky | 27a19b8 | 2018-01-30 14:58:36 | [diff] [blame] | 4978 | ssl_provider1->next_protos_expected_in_ssl_config = |
| 4979 | NextProtoVector{kProtoHTTP11}; |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 4980 | // Force HTTP/1.1. |
bnc | 3cf2a59 | 2016-08-11 14:48:36 | [diff] [blame] | 4981 | ssl_provider1->next_proto = kProtoHTTP11; |
dcheng | c7eeda42 | 2015-12-26 03:56:48 | [diff] [blame] | 4982 | helper.AddDataWithSSLSocketDataProvider(&data1, std::move(ssl_provider1)); |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 4983 | |
bnc | 525e175a | 2016-06-20 12:36:40 | [diff] [blame] | 4984 | HttpServerProperties* http_server_properties = |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 4985 | helper.session()->spdy_session_pool()->http_server_properties(); |
bnc | b2602438 | 2016-06-29 02:39:45 | [diff] [blame] | 4986 | EXPECT_FALSE(http_server_properties->RequiresHTTP11(host_port_pair_)); |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 4987 | |
| 4988 | helper.RunPreTestSetup(); |
| 4989 | helper.StartDefaultTest(); |
| 4990 | helper.FinishDefaultTestWithoutVerification(); |
| 4991 | helper.VerifyDataConsumed(); |
bnc | b2602438 | 2016-06-29 02:39:45 | [diff] [blame] | 4992 | EXPECT_TRUE(http_server_properties->RequiresHTTP11(host_port_pair_)); |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 4993 | |
| 4994 | const HttpResponseInfo* response = helper.trans()->GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 4995 | ASSERT_TRUE(response); |
| 4996 | ASSERT_TRUE(response->headers); |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 4997 | EXPECT_EQ("HTTP/1.1 200 OK", response->headers->GetStatusLine()); |
| 4998 | EXPECT_FALSE(response->was_fetched_via_spdy); |
mmenke | 8210acc | 2016-07-11 16:34:52 | [diff] [blame] | 4999 | EXPECT_EQ(HttpResponseInfo::CONNECTION_INFO_HTTP1_1, |
| 5000 | response->connection_info); |
bnc | 94c9284 | 2016-09-21 15:22:52 | [diff] [blame] | 5001 | EXPECT_TRUE(response->was_alpn_negotiated); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 5002 | EXPECT_TRUE(request_.url.SchemeIs("https")); |
Tsuyoshi Horo | 01faed6 | 2019-02-20 22:11:37 | [diff] [blame] | 5003 | EXPECT_EQ("127.0.0.1", response->remote_endpoint.ToStringWithoutPort()); |
| 5004 | EXPECT_EQ(443, response->remote_endpoint.port()); |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 5005 | std::string response_data; |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 5006 | ASSERT_THAT(ReadTransaction(helper.trans(), &response_data), IsOk()); |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 5007 | EXPECT_EQ("hello", response_data); |
| 5008 | } |
| 5009 | |
| 5010 | // Retry with HTTP/1.1 to the proxy when receiving HTTP_1_1_REQUIRED from the |
| 5011 | // proxy. Note that no actual protocol negotiation happens, instead this test |
| 5012 | // forces protocols for both sockets. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 5013 | TEST_F(SpdyNetworkTransactionTest, HTTP11RequiredProxyRetry) { |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 5014 | request_.method = "GET"; |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 5015 | auto session_deps = std::make_unique<SpdySessionDependencies>( |
Ramin Halavati | ca8d525 | 2018-03-12 05:33:49 | [diff] [blame] | 5016 | ProxyResolutionService::CreateFixedFromPacResult( |
| 5017 | "HTTPS myproxy:70", TRAFFIC_ANNOTATION_FOR_TESTS)); |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 5018 | // Do not force SPDY so that second socket can negotiate HTTP/1.1. |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 5019 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
Bence Béky | d3dde83 | 2017-09-19 19:02:31 | [diff] [blame] | 5020 | std::move(session_deps)); |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 5021 | |
| 5022 | // First socket: HTTP/2 CONNECT rejected with HTTP_1_1_REQUIRED. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5023 | spdy::SpdySerializedFrame req(spdy_util_.ConstructSpdyConnect( |
Matt Menke | 6e879bd | 2019-03-18 17:26:04 | [diff] [blame] | 5024 | nullptr, 0, 1, HttpProxyConnectJob::kH2QuicTunnelPriority, |
| 5025 | HostPortPair("www.example.org", 443))); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 5026 | MockWrite writes0[] = {CreateMockWrite(req, 0)}; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5027 | spdy::SpdySerializedFrame rst( |
| 5028 | spdy_util_.ConstructSpdyRstStream(1, spdy::ERROR_CODE_HTTP_1_1_REQUIRED)); |
Bence Béky | cb361312 | 2017-09-19 17:06:57 | [diff] [blame] | 5029 | MockRead reads0[] = {CreateMockRead(rst, 1)}; |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 5030 | SequencedSocketData data0(reads0, writes0); |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 5031 | |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 5032 | auto ssl_provider0 = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 5033 | // Expect HTTP/2 protocols too in SSLConfig. |
Bence Béky | 27a19b8 | 2018-01-30 14:58:36 | [diff] [blame] | 5034 | ssl_provider0->next_protos_expected_in_ssl_config = |
| 5035 | NextProtoVector{kProtoHTTP2, kProtoHTTP11}; |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 5036 | // Force SPDY. |
bnc | 3cf2a59 | 2016-08-11 14:48:36 | [diff] [blame] | 5037 | ssl_provider0->next_proto = kProtoHTTP2; |
dcheng | c7eeda42 | 2015-12-26 03:56:48 | [diff] [blame] | 5038 | helper.AddDataWithSSLSocketDataProvider(&data0, std::move(ssl_provider0)); |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 5039 | |
| 5040 | // Second socket: retry using HTTP/1.1. |
| 5041 | MockWrite writes1[] = { |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 5042 | MockWrite(ASYNC, 0, |
bnc | ce36dca2 | 2015-04-21 22:11:23 | [diff] [blame] | 5043 | "CONNECT www.example.org:443 HTTP/1.1\r\n" |
rsleevi | db16bb0 | 2015-11-12 23:47:17 | [diff] [blame] | 5044 | "Host: www.example.org:443\r\n" |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 5045 | "Proxy-Connection: keep-alive\r\n\r\n"), |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 5046 | MockWrite(ASYNC, 2, |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 5047 | "GET / HTTP/1.1\r\n" |
bnc | ce36dca2 | 2015-04-21 22:11:23 | [diff] [blame] | 5048 | "Host: www.example.org\r\n" |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 5049 | "Connection: keep-alive\r\n\r\n"), |
| 5050 | }; |
| 5051 | |
| 5052 | MockRead reads1[] = { |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 5053 | MockRead(ASYNC, 1, "HTTP/1.1 200 OK\r\n\r\n"), |
| 5054 | MockRead(ASYNC, 3, |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 5055 | "HTTP/1.1 200 OK\r\n" |
| 5056 | "Content-Length: 5\r\n\r\n" |
| 5057 | "hello"), |
| 5058 | }; |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 5059 | SequencedSocketData data1(reads1, writes1); |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 5060 | |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 5061 | auto ssl_provider1 = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 5062 | // Expect only HTTP/1.1 protocol in SSLConfig. |
Bence Béky | 27a19b8 | 2018-01-30 14:58:36 | [diff] [blame] | 5063 | ssl_provider1->next_protos_expected_in_ssl_config = |
| 5064 | NextProtoVector{kProtoHTTP11}; |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 5065 | // Force HTTP/1.1. |
bnc | 3cf2a59 | 2016-08-11 14:48:36 | [diff] [blame] | 5066 | ssl_provider1->next_proto = kProtoHTTP11; |
dcheng | c7eeda42 | 2015-12-26 03:56:48 | [diff] [blame] | 5067 | helper.AddDataWithSSLSocketDataProvider(&data1, std::move(ssl_provider1)); |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 5068 | |
| 5069 | // A third socket is needed for the tunnelled connection. |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 5070 | auto ssl_provider2 = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 5071 | helper.session_deps()->socket_factory->AddSSLSocketDataProvider( |
| 5072 | ssl_provider2.get()); |
| 5073 | |
bnc | 525e175a | 2016-06-20 12:36:40 | [diff] [blame] | 5074 | HttpServerProperties* http_server_properties = |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 5075 | helper.session()->spdy_session_pool()->http_server_properties(); |
| 5076 | const HostPortPair proxy_host_port_pair = HostPortPair("myproxy", 70); |
| 5077 | EXPECT_FALSE(http_server_properties->RequiresHTTP11(proxy_host_port_pair)); |
| 5078 | |
| 5079 | helper.RunPreTestSetup(); |
| 5080 | helper.StartDefaultTest(); |
| 5081 | helper.FinishDefaultTestWithoutVerification(); |
| 5082 | helper.VerifyDataConsumed(); |
| 5083 | EXPECT_TRUE(http_server_properties->RequiresHTTP11(proxy_host_port_pair)); |
| 5084 | |
| 5085 | const HttpResponseInfo* response = helper.trans()->GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 5086 | ASSERT_TRUE(response); |
| 5087 | ASSERT_TRUE(response->headers); |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 5088 | EXPECT_EQ("HTTP/1.1 200 OK", response->headers->GetStatusLine()); |
| 5089 | EXPECT_FALSE(response->was_fetched_via_spdy); |
mmenke | 8210acc | 2016-07-11 16:34:52 | [diff] [blame] | 5090 | EXPECT_EQ(HttpResponseInfo::CONNECTION_INFO_HTTP1_1, |
| 5091 | response->connection_info); |
bnc | 94c9284 | 2016-09-21 15:22:52 | [diff] [blame] | 5092 | EXPECT_FALSE(response->was_alpn_negotiated); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 5093 | EXPECT_TRUE(request_.url.SchemeIs("https")); |
Tsuyoshi Horo | 01faed6 | 2019-02-20 22:11:37 | [diff] [blame] | 5094 | EXPECT_EQ("127.0.0.1", response->remote_endpoint.ToStringWithoutPort()); |
| 5095 | EXPECT_EQ(70, response->remote_endpoint.port()); |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 5096 | std::string response_data; |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 5097 | ASSERT_THAT(ReadTransaction(helper.trans(), &response_data), IsOk()); |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 5098 | EXPECT_EQ("hello", response_data); |
| 5099 | } |
| 5100 | |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 5101 | // Test to make sure we can correctly connect through a proxy. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 5102 | TEST_F(SpdyNetworkTransactionTest, ProxyConnect) { |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 5103 | auto session_deps = std::make_unique<SpdySessionDependencies>( |
Ramin Halavati | ca8d525 | 2018-03-12 05:33:49 | [diff] [blame] | 5104 | ProxyResolutionService::CreateFixedFromPacResult( |
| 5105 | "PROXY myproxy:70", TRAFFIC_ANNOTATION_FOR_TESTS)); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 5106 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 5107 | std::move(session_deps)); |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 5108 | helper.RunPreTestSetup(); |
| 5109 | HttpNetworkTransaction* trans = helper.trans(); |
| 5110 | |
rch | ebf1298 | 2015-04-10 01:15:00 | [diff] [blame] | 5111 | const char kConnect443[] = { |
bnc | ce36dca2 | 2015-04-21 22:11:23 | [diff] [blame] | 5112 | "CONNECT www.example.org:443 HTTP/1.1\r\n" |
rsleevi | db16bb0 | 2015-11-12 23:47:17 | [diff] [blame] | 5113 | "Host: www.example.org:443\r\n" |
rch | cb934f56 | 2015-04-07 16:25:12 | [diff] [blame] | 5114 | "Proxy-Connection: keep-alive\r\n\r\n"}; |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 5115 | const char kHTTP200[] = {"HTTP/1.1 200 OK\r\n\r\n"}; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5116 | spdy::SpdySerializedFrame req( |
| 5117 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 5118 | spdy::SpdySerializedFrame resp( |
| 5119 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 5120 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 5121 | |
rch | ebf1298 | 2015-04-10 01:15:00 | [diff] [blame] | 5122 | MockWrite writes[] = { |
Avi Drissman | 4365a478 | 2018-12-28 19:26:24 | [diff] [blame] | 5123 | MockWrite(SYNCHRONOUS, kConnect443, base::size(kConnect443) - 1, 0), |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 5124 | CreateMockWrite(req, 2), |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 5125 | }; |
rch | ebf1298 | 2015-04-10 01:15:00 | [diff] [blame] | 5126 | MockRead reads[] = { |
Avi Drissman | 4365a478 | 2018-12-28 19:26:24 | [diff] [blame] | 5127 | MockRead(SYNCHRONOUS, kHTTP200, base::size(kHTTP200) - 1, 1), |
| 5128 | CreateMockRead(resp, 3), |
| 5129 | CreateMockRead(body, 4), |
Raul Tambre | 94493c65 | 2019-03-11 17:18:35 | [diff] [blame] | 5130 | MockRead(ASYNC, nullptr, 0, 5), |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 5131 | }; |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 5132 | SequencedSocketData data(reads, writes); |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 5133 | |
Bence Béky | 53a5aef | 2018-03-29 21:54:12 | [diff] [blame] | 5134 | helper.AddData(&data); |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 5135 | TestCompletionCallback callback; |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 5136 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 5137 | int rv = trans->Start(&request_, callback.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 5138 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 5139 | |
| 5140 | rv = callback.WaitForResult(); |
| 5141 | EXPECT_EQ(0, rv); |
| 5142 | |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 5143 | // Verify the response headers. |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 5144 | HttpResponseInfo response = *trans->GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 5145 | ASSERT_TRUE(response.headers); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 5146 | EXPECT_EQ("HTTP/1.1 200", response.headers->GetStatusLine()); |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 5147 | |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 5148 | std::string response_data; |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 5149 | ASSERT_THAT(ReadTransaction(trans, &response_data), IsOk()); |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 5150 | EXPECT_EQ("hello!", response_data); |
| 5151 | helper.VerifyDataConsumed(); |
| 5152 | } |
| 5153 | |
bnc | ce36dca2 | 2015-04-21 22:11:23 | [diff] [blame] | 5154 | // Test to make sure we can correctly connect through a proxy to |
| 5155 | // www.example.org, if there already exists a direct spdy connection to |
| 5156 | // www.example.org. See https://crbug.com/49874. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 5157 | TEST_F(SpdyNetworkTransactionTest, DirectConnectProxyReconnect) { |
[email protected] | 733b7a6d | 2010-08-25 01:38:43 | [diff] [blame] | 5158 | // Use a proxy service which returns a proxy fallback list from DIRECT to |
| 5159 | // myproxy:70. For this test there will be no fallback, so it is equivalent |
| 5160 | // to simply DIRECT. The reason for appending the second proxy is to verify |
| 5161 | // that the session pool key used does is just "DIRECT". |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 5162 | auto session_deps = std::make_unique<SpdySessionDependencies>( |
Lily Houghton | 8c2f97d | 2018-01-22 05:06:59 | [diff] [blame] | 5163 | ProxyResolutionService::CreateFixedFromPacResult( |
Ramin Halavati | ca8d525 | 2018-03-12 05:33:49 | [diff] [blame] | 5164 | "DIRECT; PROXY myproxy:70", TRAFFIC_ANNOTATION_FOR_TESTS)); |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 5165 | // When setting up the first transaction, we store the SpdySessionPool so that |
| 5166 | // we can use the same pool in the second transaction. |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 5167 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 5168 | std::move(session_deps)); |
[email protected] | 733b7a6d | 2010-08-25 01:38:43 | [diff] [blame] | 5169 | |
[email protected] | 87bfa3f | 2010-09-30 14:54:56 | [diff] [blame] | 5170 | SpdySessionPool* spdy_session_pool = helper.session()->spdy_session_pool(); |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 5171 | helper.RunPreTestSetup(); |
| 5172 | |
| 5173 | // Construct and send a simple GET request. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5174 | spdy::SpdySerializedFrame req( |
| 5175 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 5176 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 5177 | CreateMockWrite(req, 0), |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 5178 | }; |
| 5179 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5180 | spdy::SpdySerializedFrame resp( |
| 5181 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 5182 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 5183 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 5184 | CreateMockRead(resp, 1), CreateMockRead(body, 2), |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 5185 | MockRead(SYNCHRONOUS, ERR_IO_PENDING, 3), // Force a pause |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 5186 | }; |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 5187 | SequencedSocketData data(reads, writes); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 5188 | helper.AddData(&data); |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 5189 | HttpNetworkTransaction* trans = helper.trans(); |
| 5190 | |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 5191 | TestCompletionCallback callback; |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 5192 | TransactionHelperResult out; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 5193 | out.rv = trans->Start(&request_, callback.callback(), log_); |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 5194 | |
| 5195 | EXPECT_EQ(out.rv, ERR_IO_PENDING); |
| 5196 | out.rv = callback.WaitForResult(); |
| 5197 | EXPECT_EQ(out.rv, OK); |
| 5198 | |
| 5199 | const HttpResponseInfo* response = trans->GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 5200 | EXPECT_TRUE(response->headers); |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 5201 | EXPECT_TRUE(response->was_fetched_via_spdy); |
| 5202 | out.rv = ReadTransaction(trans, &out.response_data); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 5203 | EXPECT_THAT(out.rv, IsOk()); |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 5204 | out.status_line = response->headers->GetStatusLine(); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 5205 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 5206 | EXPECT_EQ("hello!", out.response_data); |
| 5207 | |
| 5208 | // Check that the SpdySession is still in the SpdySessionPool. |
Matt Menke | 2436b2f | 2018-12-11 18:07:11 | [diff] [blame] | 5209 | SpdySessionKey session_pool_key_direct( |
| 5210 | host_port_pair_, ProxyServer::Direct(), PRIVACY_MODE_DISABLED, |
| 5211 | SpdySessionKey::IsProxySession::kFalse, SocketTag()); |
[email protected] | 41d64e8 | 2013-07-03 22:44:26 | [diff] [blame] | 5212 | EXPECT_TRUE(HasSpdySession(spdy_session_pool, session_pool_key_direct)); |
[email protected] | e6d01765 | 2013-05-17 18:01:40 | [diff] [blame] | 5213 | SpdySessionKey session_pool_key_proxy( |
bnc | b2602438 | 2016-06-29 02:39:45 | [diff] [blame] | 5214 | host_port_pair_, |
[email protected] | e6d01765 | 2013-05-17 18:01:40 | [diff] [blame] | 5215 | ProxyServer::FromURI("www.foo.com", ProxyServer::SCHEME_HTTP), |
Matt Menke | 2436b2f | 2018-12-11 18:07:11 | [diff] [blame] | 5216 | PRIVACY_MODE_DISABLED, SpdySessionKey::IsProxySession::kFalse, |
| 5217 | SocketTag()); |
[email protected] | 41d64e8 | 2013-07-03 22:44:26 | [diff] [blame] | 5218 | EXPECT_FALSE(HasSpdySession(spdy_session_pool, session_pool_key_proxy)); |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 5219 | |
rdsmith | ebb50aa | 2015-11-12 03:44:38 | [diff] [blame] | 5220 | // New SpdyTestUtil instance for the session that will be used for the |
| 5221 | // proxy connection. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 5222 | SpdyTestUtil spdy_util_2; |
rdsmith | ebb50aa | 2015-11-12 03:44:38 | [diff] [blame] | 5223 | |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 5224 | // Set up data for the proxy connection. |
bnc | ce36dca2 | 2015-04-21 22:11:23 | [diff] [blame] | 5225 | const char kConnect443[] = { |
| 5226 | "CONNECT www.example.org:443 HTTP/1.1\r\n" |
rsleevi | db16bb0 | 2015-11-12 23:47:17 | [diff] [blame] | 5227 | "Host: www.example.org:443\r\n" |
bnc | ce36dca2 | 2015-04-21 22:11:23 | [diff] [blame] | 5228 | "Proxy-Connection: keep-alive\r\n\r\n"}; |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 5229 | const char kHTTP200[] = {"HTTP/1.1 200 OK\r\n\r\n"}; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5230 | spdy::SpdySerializedFrame req2( |
| 5231 | spdy_util_2.ConstructSpdyGet(kPushedUrl, 1, LOWEST)); |
| 5232 | spdy::SpdySerializedFrame resp2( |
| 5233 | spdy_util_2.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 5234 | spdy::SpdySerializedFrame body2(spdy_util_2.ConstructSpdyDataFrame(1, true)); |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 5235 | |
rch | ebf1298 | 2015-04-10 01:15:00 | [diff] [blame] | 5236 | MockWrite writes2[] = { |
Avi Drissman | 4365a478 | 2018-12-28 19:26:24 | [diff] [blame] | 5237 | MockWrite(SYNCHRONOUS, kConnect443, base::size(kConnect443) - 1, 0), |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 5238 | CreateMockWrite(req2, 2), |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 5239 | }; |
rch | ebf1298 | 2015-04-10 01:15:00 | [diff] [blame] | 5240 | MockRead reads2[] = { |
Avi Drissman | 4365a478 | 2018-12-28 19:26:24 | [diff] [blame] | 5241 | MockRead(SYNCHRONOUS, kHTTP200, base::size(kHTTP200) - 1, 1), |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 5242 | CreateMockRead(resp2, 3), CreateMockRead(body2, 4), |
rch | ebf1298 | 2015-04-10 01:15:00 | [diff] [blame] | 5243 | MockRead(ASYNC, 0, 5) // EOF |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 5244 | }; |
| 5245 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 5246 | SequencedSocketData data_proxy(reads2, writes2); |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 5247 | |
bnc | ce36dca2 | 2015-04-21 22:11:23 | [diff] [blame] | 5248 | // Create another request to www.example.org, but this time through a proxy. |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 5249 | request_.method = "GET"; |
Bence Béky | d2df6c1c8 | 2018-04-20 22:52:01 | [diff] [blame] | 5250 | request_.url = GURL(kPushedUrl); |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 5251 | auto session_deps_proxy = std::make_unique<SpdySessionDependencies>( |
Ramin Halavati | ca8d525 | 2018-03-12 05:33:49 | [diff] [blame] | 5252 | ProxyResolutionService::CreateFixedFromPacResult( |
| 5253 | "PROXY myproxy:70", TRAFFIC_ANNOTATION_FOR_TESTS)); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 5254 | NormalSpdyTransactionHelper helper_proxy(request_, DEFAULT_PRIORITY, log_, |
| 5255 | std::move(session_deps_proxy)); |
| 5256 | |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 5257 | helper_proxy.RunPreTestSetup(); |
Bence Béky | 53a5aef | 2018-03-29 21:54:12 | [diff] [blame] | 5258 | helper_proxy.AddData(&data_proxy); |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 5259 | |
| 5260 | HttpNetworkTransaction* trans_proxy = helper_proxy.trans(); |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 5261 | TestCompletionCallback callback_proxy; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 5262 | int rv = trans_proxy->Start(&request_, callback_proxy.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 5263 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 5264 | rv = callback_proxy.WaitForResult(); |
| 5265 | EXPECT_EQ(0, rv); |
| 5266 | |
| 5267 | HttpResponseInfo response_proxy = *trans_proxy->GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 5268 | ASSERT_TRUE(response_proxy.headers); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 5269 | EXPECT_EQ("HTTP/1.1 200", response_proxy.headers->GetStatusLine()); |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 5270 | |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 5271 | std::string response_data; |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 5272 | ASSERT_THAT(ReadTransaction(trans_proxy, &response_data), IsOk()); |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 5273 | EXPECT_EQ("hello!", response_data); |
| 5274 | |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 5275 | helper_proxy.VerifyDataConsumed(); |
| 5276 | } |
| 5277 | |
[email protected] | 58cebf8f | 2010-07-31 19:20:16 | [diff] [blame] | 5278 | // When we get a TCP-level RST, we need to retry a HttpNetworkTransaction |
| 5279 | // on a new connection, if the connection was previously known to be good. |
| 5280 | // This can happen when a server reboots without saying goodbye, or when |
| 5281 | // we're behind a NAT that masked the RST. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 5282 | TEST_F(SpdyNetworkTransactionTest, VerifyRetryOnConnectionReset) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5283 | spdy::SpdySerializedFrame resp( |
| 5284 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 5285 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | 58cebf8f | 2010-07-31 19:20:16 | [diff] [blame] | 5286 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 5287 | CreateMockRead(resp, 1), CreateMockRead(body, 2), |
rch | 3232084 | 2015-05-16 15:57:09 | [diff] [blame] | 5288 | MockRead(ASYNC, ERR_IO_PENDING, 3), |
| 5289 | MockRead(ASYNC, ERR_CONNECTION_RESET, 4), |
[email protected] | 58cebf8f | 2010-07-31 19:20:16 | [diff] [blame] | 5290 | }; |
| 5291 | |
| 5292 | MockRead reads2[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 5293 | CreateMockRead(resp, 1), CreateMockRead(body, 2), |
rch | 3232084 | 2015-05-16 15:57:09 | [diff] [blame] | 5294 | MockRead(ASYNC, 0, 3) // EOF |
[email protected] | 58cebf8f | 2010-07-31 19:20:16 | [diff] [blame] | 5295 | }; |
| 5296 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5297 | spdy::SpdySerializedFrame req( |
| 5298 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
rdsmith | ebb50aa | 2015-11-12 03:44:38 | [diff] [blame] | 5299 | // In all cases the connection will be reset before req3 can be |
| 5300 | // dispatched, destroying both streams. |
| 5301 | spdy_util_.UpdateWithStreamDestruction(1); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5302 | spdy::SpdySerializedFrame req3( |
| 5303 | spdy_util_.ConstructSpdyGet(nullptr, 0, 3, LOWEST)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 5304 | MockWrite writes1[] = {CreateMockWrite(req, 0), CreateMockWrite(req3, 5)}; |
| 5305 | MockWrite writes2[] = {CreateMockWrite(req, 0)}; |
rch | acdcbdc | 2015-05-16 17:16:00 | [diff] [blame] | 5306 | |
[email protected] | 58cebf8f | 2010-07-31 19:20:16 | [diff] [blame] | 5307 | // This test has a couple of variants. |
| 5308 | enum { |
| 5309 | // Induce the RST while waiting for our transaction to send. |
rch | acdcbdc | 2015-05-16 17:16:00 | [diff] [blame] | 5310 | VARIANT_RST_DURING_SEND_COMPLETION = 0, |
[email protected] | 58cebf8f | 2010-07-31 19:20:16 | [diff] [blame] | 5311 | // Induce the RST while waiting for our transaction to read. |
| 5312 | // In this case, the send completed - everything copied into the SNDBUF. |
rch | acdcbdc | 2015-05-16 17:16:00 | [diff] [blame] | 5313 | VARIANT_RST_DURING_READ_COMPLETION = 1 |
[email protected] | 58cebf8f | 2010-07-31 19:20:16 | [diff] [blame] | 5314 | }; |
| 5315 | |
| 5316 | for (int variant = VARIANT_RST_DURING_SEND_COMPLETION; |
| 5317 | variant <= VARIANT_RST_DURING_READ_COMPLETION; |
| 5318 | ++variant) { |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 5319 | SequencedSocketData data1(reads, |
| 5320 | base::make_span(writes1).first(1 + variant)); |
[email protected] | 58cebf8f | 2010-07-31 19:20:16 | [diff] [blame] | 5321 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 5322 | SequencedSocketData data2(reads2, writes2); |
[email protected] | 58cebf8f | 2010-07-31 19:20:16 | [diff] [blame] | 5323 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 5324 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
| 5325 | nullptr); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 5326 | helper.AddData(&data1); |
| 5327 | helper.AddData(&data2); |
[email protected] | 58cebf8f | 2010-07-31 19:20:16 | [diff] [blame] | 5328 | helper.RunPreTestSetup(); |
| 5329 | |
| 5330 | for (int i = 0; i < 2; ++i) { |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 5331 | HttpNetworkTransaction trans(DEFAULT_PRIORITY, helper.session()); |
[email protected] | 58cebf8f | 2010-07-31 19:20:16 | [diff] [blame] | 5332 | |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 5333 | TestCompletionCallback callback; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 5334 | int rv = trans.Start(&request_, callback.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 5335 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | 58cebf8f | 2010-07-31 19:20:16 | [diff] [blame] | 5336 | // On the second transaction, we trigger the RST. |
| 5337 | if (i == 1) { |
| 5338 | if (variant == VARIANT_RST_DURING_READ_COMPLETION) { |
| 5339 | // Writes to the socket complete asynchronously on SPDY by running |
| 5340 | // through the message loop. Complete the write here. |
[email protected] | fc9d8847 | 2013-08-14 02:31:17 | [diff] [blame] | 5341 | base::RunLoop().RunUntilIdle(); |
[email protected] | 58cebf8f | 2010-07-31 19:20:16 | [diff] [blame] | 5342 | } |
| 5343 | |
| 5344 | // Now schedule the ERR_CONNECTION_RESET. |
mmenke | e2401192 | 2015-12-17 22:12:59 | [diff] [blame] | 5345 | data1.Resume(); |
[email protected] | 58cebf8f | 2010-07-31 19:20:16 | [diff] [blame] | 5346 | } |
| 5347 | rv = callback.WaitForResult(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 5348 | EXPECT_THAT(rv, IsOk()); |
[email protected] | 58cebf8f | 2010-07-31 19:20:16 | [diff] [blame] | 5349 | |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 5350 | const HttpResponseInfo* response = trans.GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 5351 | ASSERT_TRUE(response); |
| 5352 | EXPECT_TRUE(response->headers); |
[email protected] | 58cebf8f | 2010-07-31 19:20:16 | [diff] [blame] | 5353 | EXPECT_TRUE(response->was_fetched_via_spdy); |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 5354 | std::string response_data; |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 5355 | rv = ReadTransaction(&trans, &response_data); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 5356 | EXPECT_THAT(rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 5357 | EXPECT_EQ("HTTP/1.1 200", response->headers->GetStatusLine()); |
[email protected] | 58cebf8f | 2010-07-31 19:20:16 | [diff] [blame] | 5358 | EXPECT_EQ("hello!", response_data); |
rch | acdcbdc | 2015-05-16 17:16:00 | [diff] [blame] | 5359 | base::RunLoop().RunUntilIdle(); |
[email protected] | 58cebf8f | 2010-07-31 19:20:16 | [diff] [blame] | 5360 | } |
| 5361 | |
| 5362 | helper.VerifyDataConsumed(); |
rch | acdcbdc | 2015-05-16 17:16:00 | [diff] [blame] | 5363 | base::RunLoop().RunUntilIdle(); |
[email protected] | 58cebf8f | 2010-07-31 19:20:16 | [diff] [blame] | 5364 | } |
| 5365 | } |
[email protected] | 1f418ee | 2010-10-16 19:46:56 | [diff] [blame] | 5366 | |
[email protected] | 018aabc | 2010-10-29 16:16:59 | [diff] [blame] | 5367 | // Tests that Basic authentication works over SPDY |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 5368 | TEST_F(SpdyNetworkTransactionTest, SpdyBasicAuth) { |
[email protected] | 018aabc | 2010-10-29 16:16:59 | [diff] [blame] | 5369 | // The first request will be a bare GET, the second request will be a |
| 5370 | // GET with an Authorization header. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5371 | spdy::SpdySerializedFrame req_get( |
Bence Béky | 27ad0a1 | 2018-02-08 00:35:48 | [diff] [blame] | 5372 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
rdsmith | ebb50aa | 2015-11-12 03:44:38 | [diff] [blame] | 5373 | // Will be refused for lack of auth. |
| 5374 | spdy_util_.UpdateWithStreamDestruction(1); |
[email protected] | 018aabc | 2010-10-29 16:16:59 | [diff] [blame] | 5375 | const char* const kExtraAuthorizationHeaders[] = { |
[email protected] | cdf8f7e7 | 2013-05-23 10:56:46 | [diff] [blame] | 5376 | "authorization", "Basic Zm9vOmJhcg==" |
[email protected] | 018aabc | 2010-10-29 16:16:59 | [diff] [blame] | 5377 | }; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5378 | spdy::SpdySerializedFrame req_get_authorization(spdy_util_.ConstructSpdyGet( |
Avi Drissman | 4365a478 | 2018-12-28 19:26:24 | [diff] [blame] | 5379 | kExtraAuthorizationHeaders, base::size(kExtraAuthorizationHeaders) / 2, 3, |
Bence Béky | 27ad0a1 | 2018-02-08 00:35:48 | [diff] [blame] | 5380 | LOWEST)); |
[email protected] | 018aabc | 2010-10-29 16:16:59 | [diff] [blame] | 5381 | MockWrite spdy_writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 5382 | CreateMockWrite(req_get, 0), CreateMockWrite(req_get_authorization, 3), |
[email protected] | 018aabc | 2010-10-29 16:16:59 | [diff] [blame] | 5383 | }; |
| 5384 | |
| 5385 | // The first response is a 401 authentication challenge, and the second |
| 5386 | // response will be a 200 response since the second request includes a valid |
| 5387 | // Authorization header. |
| 5388 | const char* const kExtraAuthenticationHeaders[] = { |
[email protected] | fb9e431 | 2012-02-17 06:27:26 | [diff] [blame] | 5389 | "www-authenticate", |
[email protected] | 018aabc | 2010-10-29 16:16:59 | [diff] [blame] | 5390 | "Basic realm=\"MyRealm\"" |
| 5391 | }; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5392 | spdy::SpdySerializedFrame resp_authentication( |
| 5393 | spdy_util_.ConstructSpdyReplyError( |
| 5394 | "401", kExtraAuthenticationHeaders, |
Avi Drissman | 4365a478 | 2018-12-28 19:26:24 | [diff] [blame] | 5395 | base::size(kExtraAuthenticationHeaders) / 2, 1)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5396 | spdy::SpdySerializedFrame body_authentication( |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 5397 | spdy_util_.ConstructSpdyDataFrame(1, true)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5398 | spdy::SpdySerializedFrame resp_data( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 5399 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 3)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5400 | spdy::SpdySerializedFrame body_data( |
| 5401 | spdy_util_.ConstructSpdyDataFrame(3, true)); |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 5402 | |
[email protected] | 018aabc | 2010-10-29 16:16:59 | [diff] [blame] | 5403 | MockRead spdy_reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 5404 | CreateMockRead(resp_authentication, 1), |
bnc | eb9aa711 | 2017-01-05 01:03:46 | [diff] [blame] | 5405 | CreateMockRead(body_authentication, 2, SYNCHRONOUS), |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 5406 | CreateMockRead(resp_data, 4), |
| 5407 | CreateMockRead(body_data, 5), |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 5408 | MockRead(ASYNC, 0, 6), |
[email protected] | 018aabc | 2010-10-29 16:16:59 | [diff] [blame] | 5409 | }; |
| 5410 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 5411 | SequencedSocketData data(spdy_reads, spdy_writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 5412 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | 018aabc | 2010-10-29 16:16:59 | [diff] [blame] | 5413 | |
| 5414 | helper.RunPreTestSetup(); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 5415 | helper.AddData(&data); |
bnc | 4d782f49 | 2016-08-18 13:50:00 | [diff] [blame] | 5416 | helper.StartDefaultTest(); |
| 5417 | EXPECT_THAT(helper.output().rv, IsError(ERR_IO_PENDING)); |
| 5418 | |
| 5419 | helper.WaitForCallbackToComplete(); |
| 5420 | EXPECT_THAT(helper.output().rv, IsOk()); |
[email protected] | 018aabc | 2010-10-29 16:16:59 | [diff] [blame] | 5421 | |
| 5422 | // Make sure the response has an auth challenge. |
bnc | 4d782f49 | 2016-08-18 13:50:00 | [diff] [blame] | 5423 | HttpNetworkTransaction* trans = helper.trans(); |
[email protected] | 018aabc | 2010-10-29 16:16:59 | [diff] [blame] | 5424 | const HttpResponseInfo* const response_start = trans->GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 5425 | ASSERT_TRUE(response_start); |
| 5426 | ASSERT_TRUE(response_start->headers); |
[email protected] | 018aabc | 2010-10-29 16:16:59 | [diff] [blame] | 5427 | EXPECT_EQ(401, response_start->headers->response_code()); |
| 5428 | EXPECT_TRUE(response_start->was_fetched_via_spdy); |
Emily Stark | f2c9bbd | 2019-04-09 17:08:58 | [diff] [blame] | 5429 | const base::Optional<AuthChallengeInfo>& auth_challenge = |
| 5430 | response_start->auth_challenge; |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 5431 | ASSERT_TRUE(auth_challenge); |
[email protected] | 79cb5c1 | 2011-09-12 13:12:04 | [diff] [blame] | 5432 | EXPECT_FALSE(auth_challenge->is_proxy); |
aberent | bba302d | 2015-12-03 10:20:19 | [diff] [blame] | 5433 | EXPECT_EQ(kBasicAuthScheme, auth_challenge->scheme); |
[email protected] | 79cb5c1 | 2011-09-12 13:12:04 | [diff] [blame] | 5434 | EXPECT_EQ("MyRealm", auth_challenge->realm); |
[email protected] | 018aabc | 2010-10-29 16:16:59 | [diff] [blame] | 5435 | |
| 5436 | // Restart with a username/password. |
[email protected] | ad65a3e | 2013-12-25 18:18:01 | [diff] [blame] | 5437 | AuthCredentials credentials(base::ASCIIToUTF16("foo"), |
| 5438 | base::ASCIIToUTF16("bar")); |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 5439 | TestCompletionCallback callback_restart; |
| 5440 | const int rv_restart = trans->RestartWithAuth( |
| 5441 | credentials, callback_restart.callback()); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 5442 | EXPECT_THAT(rv_restart, IsError(ERR_IO_PENDING)); |
[email protected] | 018aabc | 2010-10-29 16:16:59 | [diff] [blame] | 5443 | const int rv_restart_complete = callback_restart.WaitForResult(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 5444 | EXPECT_THAT(rv_restart_complete, IsOk()); |
[email protected] | 018aabc | 2010-10-29 16:16:59 | [diff] [blame] | 5445 | // TODO(cbentzel): This is actually the same response object as before, but |
| 5446 | // data has changed. |
| 5447 | const HttpResponseInfo* const response_restart = trans->GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 5448 | ASSERT_TRUE(response_restart); |
| 5449 | ASSERT_TRUE(response_restart->headers); |
[email protected] | 018aabc | 2010-10-29 16:16:59 | [diff] [blame] | 5450 | EXPECT_EQ(200, response_restart->headers->response_code()); |
Emily Stark | f2c9bbd | 2019-04-09 17:08:58 | [diff] [blame] | 5451 | EXPECT_FALSE(response_restart->auth_challenge); |
[email protected] | 018aabc | 2010-10-29 16:16:59 | [diff] [blame] | 5452 | } |
| 5453 | |
Bence Béky | e7023f8 | 2018-05-14 01:53:03 | [diff] [blame] | 5454 | struct PushHeaderTestParams { |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 5455 | std::vector<std::pair<base::StringPiece, base::StringPiece>> |
| 5456 | extra_request_headers; |
| 5457 | std::vector<std::pair<base::StringPiece, base::StringPiece>> |
| 5458 | extra_pushed_request_headers; |
| 5459 | std::vector<std::pair<base::StringPiece, base::StringPiece>> |
| 5460 | extra_pushed_response_headers; |
| 5461 | base::StringPiece pushed_status_code; |
| 5462 | bool push_accepted; |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 5463 | SpdyPushedStreamFate expected_fate; |
Bence Béky | e7023f8 | 2018-05-14 01:53:03 | [diff] [blame] | 5464 | } push_header_test_cases[] = { |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 5465 | // Base case: no extra headers. |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 5466 | {{}, {}, {}, "200", true, SpdyPushedStreamFate::kAcceptedNoVary}, |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 5467 | // Cookie headers match. |
| 5468 | {{{"cookie", "value=foo"}}, |
| 5469 | {{"cookie", "value=foo"}}, |
| 5470 | {{"vary", "Cookie"}}, |
| 5471 | "200", |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 5472 | true, |
| 5473 | SpdyPushedStreamFate::kAcceptedMatchingVary}, |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 5474 | // Cookie headers mismatch. |
| 5475 | {{{"cookie", "value=foo"}}, |
| 5476 | {{"cookie", "value=bar"}}, |
| 5477 | {{"vary", "Cookie"}}, |
| 5478 | "200", |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 5479 | false, |
| 5480 | SpdyPushedStreamFate::kVaryMismatch}, |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 5481 | // Partial Content response, no Range headers. |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 5482 | {{}, {}, {}, "206", false, SpdyPushedStreamFate::kClientRequestNotRange}, |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 5483 | // Partial Content response, no Range headers in pushed request. |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 5484 | {{{"range", "0-42"}}, |
| 5485 | {}, |
| 5486 | {}, |
| 5487 | "206", |
| 5488 | false, |
| 5489 | SpdyPushedStreamFate::kPushedRequestNotRange}, |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 5490 | // Partial Content response, no Range headers in client request. |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 5491 | {{}, |
| 5492 | {{"range", "0-42"}}, |
| 5493 | {}, |
| 5494 | "206", |
| 5495 | false, |
| 5496 | SpdyPushedStreamFate::kClientRequestNotRange}, |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 5497 | // Partial Content response, mismatching Range headers. |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 5498 | {{{"range", "0-42"}}, |
| 5499 | {{"range", "10-42"}}, |
| 5500 | {}, |
| 5501 | "206", |
| 5502 | false, |
| 5503 | SpdyPushedStreamFate::kRangeMismatch}, |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 5504 | // Partial Content response, matching Range headers. |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 5505 | {{{"range", "0-42"}}, |
| 5506 | {{"range", "0-42"}}, |
| 5507 | {}, |
| 5508 | "206", |
| 5509 | true, |
| 5510 | SpdyPushedStreamFate::kAcceptedNoVary}, |
| 5511 | }; |
[email protected] | d0835850 | 2010-12-03 22:04:03 | [diff] [blame] | 5512 | |
Bence Béky | e7023f8 | 2018-05-14 01:53:03 | [diff] [blame] | 5513 | class SpdyNetworkTransactionPushHeaderTest |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 5514 | : public SpdyNetworkTransactionTest, |
Bence Béky | e7023f8 | 2018-05-14 01:53:03 | [diff] [blame] | 5515 | public ::testing::WithParamInterface<PushHeaderTestParams> { |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 5516 | protected: |
| 5517 | void RunTest(bool pushed_response_headers_received_before_request) { |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 5518 | base::HistogramTester histogram_tester; |
| 5519 | |
Bence Béky | c4caf07 | 2018-04-20 22:27:30 | [diff] [blame] | 5520 | int seq = 0; |
| 5521 | std::vector<MockWrite> writes; |
| 5522 | std::vector<MockRead> reads; |
bnc | 38dcd39 | 2016-02-09 23:19:49 | [diff] [blame] | 5523 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5524 | spdy::SpdySerializedFrame req1( |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 5525 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
Bence Béky | c4caf07 | 2018-04-20 22:27:30 | [diff] [blame] | 5526 | writes.push_back(CreateMockWrite(req1, seq++)); |
[email protected] | 513963e | 2013-06-15 01:53:04 | [diff] [blame] | 5527 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5528 | spdy::SpdyHeaderBlock pushed_request_headers; |
| 5529 | pushed_request_headers[spdy::kHttp2MethodHeader] = "GET"; |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 5530 | for (const auto& header : GetParam().extra_pushed_request_headers) { |
Bence Béky | c4caf07 | 2018-04-20 22:27:30 | [diff] [blame] | 5531 | pushed_request_headers.insert(header); |
| 5532 | } |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 5533 | spdy_util_.AddUrlToHeaderBlock(kPushedUrl, &pushed_request_headers); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5534 | spdy::SpdySerializedFrame pushed_request( |
| 5535 | spdy_util_.ConstructSpdyPushPromise(1, 2, |
| 5536 | std::move(pushed_request_headers))); |
Bence Béky | c4caf07 | 2018-04-20 22:27:30 | [diff] [blame] | 5537 | reads.push_back(CreateMockRead(pushed_request, seq++)); |
[email protected] | d0835850 | 2010-12-03 22:04:03 | [diff] [blame] | 5538 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5539 | spdy::SpdySerializedFrame priority( |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 5540 | spdy_util_.ConstructSpdyPriority(2, 1, IDLE, true)); |
Bence Béky | c4caf07 | 2018-04-20 22:27:30 | [diff] [blame] | 5541 | writes.push_back(CreateMockWrite(priority, seq++)); |
bnc | 38dcd39 | 2016-02-09 23:19:49 | [diff] [blame] | 5542 | |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 5543 | reads.push_back(MockRead(ASYNC, ERR_IO_PENDING, seq++)); |
| 5544 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5545 | spdy::SpdyHeaderBlock pushed_response_headers; |
| 5546 | pushed_response_headers[spdy::kHttp2StatusHeader] = |
| 5547 | GetParam().pushed_status_code; |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 5548 | for (const auto& header : GetParam().extra_pushed_response_headers) { |
Bence Béky | c4caf07 | 2018-04-20 22:27:30 | [diff] [blame] | 5549 | pushed_response_headers.insert(header); |
| 5550 | } |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5551 | spdy::SpdySerializedFrame pushed_response( |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 5552 | spdy_util_.ConstructSpdyReply(2, std::move(pushed_response_headers))); |
Bence Béky | c4caf07 | 2018-04-20 22:27:30 | [diff] [blame] | 5553 | reads.push_back(CreateMockRead(pushed_response, seq++)); |
bnc | 38dcd39 | 2016-02-09 23:19:49 | [diff] [blame] | 5554 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5555 | spdy::SpdySerializedFrame resp1( |
| 5556 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
Bence Béky | c4caf07 | 2018-04-20 22:27:30 | [diff] [blame] | 5557 | reads.push_back(CreateMockRead(resp1, seq++)); |
[email protected] | d0835850 | 2010-12-03 22:04:03 | [diff] [blame] | 5558 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5559 | spdy::SpdySerializedFrame body1(spdy_util_.ConstructSpdyDataFrame(1, true)); |
Bence Béky | c4caf07 | 2018-04-20 22:27:30 | [diff] [blame] | 5560 | reads.push_back(CreateMockRead(body1, seq++)); |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 5561 | spdy_util_.UpdateWithStreamDestruction(1); |
[email protected] | d0835850 | 2010-12-03 22:04:03 | [diff] [blame] | 5562 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5563 | spdy::SpdySerializedFrame pushed_body( |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 5564 | spdy_util_.ConstructSpdyDataFrame(2, "This is pushed.", true)); |
Bence Béky | c4caf07 | 2018-04-20 22:27:30 | [diff] [blame] | 5565 | reads.push_back(CreateMockRead(pushed_body, seq++)); |
[email protected] | d0835850 | 2010-12-03 22:04:03 | [diff] [blame] | 5566 | |
Bence Béky | c4caf07 | 2018-04-20 22:27:30 | [diff] [blame] | 5567 | // If push is not accepted, a new request is sent on the wire. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5568 | spdy::SpdySerializedFrame rst; |
| 5569 | spdy::SpdySerializedFrame req2; |
| 5570 | spdy::SpdySerializedFrame resp2; |
| 5571 | spdy::SpdySerializedFrame body2; |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 5572 | if (!GetParam().push_accepted) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5573 | rst = spdy_util_.ConstructSpdyRstStream(2, spdy::ERROR_CODE_CANCEL); |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 5574 | writes.push_back(CreateMockWrite(rst, seq++)); |
| 5575 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5576 | spdy::SpdyHeaderBlock request_headers2( |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 5577 | spdy_util_.ConstructGetHeaderBlock(kPushedUrl)); |
| 5578 | for (const auto& header : GetParam().extra_request_headers) { |
Bence Béky | c4caf07 | 2018-04-20 22:27:30 | [diff] [blame] | 5579 | request_headers2.insert(header); |
| 5580 | } |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 5581 | req2 = spdy_util_.ConstructSpdyHeaders(3, std::move(request_headers2), |
| 5582 | LOWEST, true); |
Bence Béky | c4caf07 | 2018-04-20 22:27:30 | [diff] [blame] | 5583 | writes.push_back(CreateMockWrite(req2, seq++)); |
[email protected] | d0835850 | 2010-12-03 22:04:03 | [diff] [blame] | 5584 | |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 5585 | resp2 = spdy_util_.ConstructSpdyGetReply(nullptr, 0, 3); |
Bence Béky | c4caf07 | 2018-04-20 22:27:30 | [diff] [blame] | 5586 | reads.push_back(CreateMockRead(resp2, seq++)); |
Bence Béky | 04268b02 | 2018-04-19 01:17:41 | [diff] [blame] | 5587 | |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 5588 | body2 = spdy_util_.ConstructSpdyDataFrame(3, "This is not pushed.", true); |
Bence Béky | c4caf07 | 2018-04-20 22:27:30 | [diff] [blame] | 5589 | reads.push_back(CreateMockRead(body2, seq++)); |
| 5590 | } |
Bence Béky | 04268b02 | 2018-04-19 01:17:41 | [diff] [blame] | 5591 | |
Bence Béky | c4caf07 | 2018-04-20 22:27:30 | [diff] [blame] | 5592 | reads.push_back(MockRead(ASYNC, ERR_IO_PENDING, seq++)); |
Bence Béky | 04268b02 | 2018-04-19 01:17:41 | [diff] [blame] | 5593 | |
Bence Béky | c4caf07 | 2018-04-20 22:27:30 | [diff] [blame] | 5594 | reads.push_back(MockRead(ASYNC, 0, seq++)); |
Bence Béky | 04268b02 | 2018-04-19 01:17:41 | [diff] [blame] | 5595 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 5596 | SequencedSocketData data(reads, writes); |
Bence Béky | 04268b02 | 2018-04-19 01:17:41 | [diff] [blame] | 5597 | |
Bence Béky | c4caf07 | 2018-04-20 22:27:30 | [diff] [blame] | 5598 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
| 5599 | nullptr); |
| 5600 | helper.RunPreTestSetup(); |
| 5601 | helper.AddData(&data); |
Bence Béky | 04268b02 | 2018-04-19 01:17:41 | [diff] [blame] | 5602 | |
Bence Béky | c4caf07 | 2018-04-20 22:27:30 | [diff] [blame] | 5603 | HttpNetworkTransaction* trans = helper.trans(); |
| 5604 | TestCompletionCallback callback1; |
| 5605 | int rv = trans->Start(&request_, callback1.callback(), log_); |
| 5606 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 5607 | |
| 5608 | // Open connection. |
| 5609 | base::RunLoop().RunUntilIdle(); |
| 5610 | |
| 5611 | if (pushed_response_headers_received_before_request) { |
| 5612 | // Read pushed response headers. |
| 5613 | data.Resume(); |
| 5614 | base::RunLoop().RunUntilIdle(); |
| 5615 | } |
| 5616 | |
| 5617 | HttpRequestInfo request2 = CreateGetPushRequest(); |
| 5618 | for (const auto& header : GetParam().extra_request_headers) { |
| 5619 | request2.extra_headers.SetHeader(header.first, header.second); |
| 5620 | } |
| 5621 | HttpNetworkTransaction trans2(DEFAULT_PRIORITY, helper.session()); |
| 5622 | TestCompletionCallback callback2; |
| 5623 | rv = trans2.Start(&request2, callback2.callback(), log_); |
| 5624 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 5625 | base::RunLoop().RunUntilIdle(); |
| 5626 | |
| 5627 | if (!pushed_response_headers_received_before_request) { |
| 5628 | // Read pushed response headers. |
| 5629 | data.Resume(); |
| 5630 | base::RunLoop().RunUntilIdle(); |
| 5631 | } |
| 5632 | |
Bence Béky | c4caf07 | 2018-04-20 22:27:30 | [diff] [blame] | 5633 | rv = callback1.WaitForResult(); |
| 5634 | EXPECT_THAT(rv, IsOk()); |
Bence Béky | 04268b02 | 2018-04-19 01:17:41 | [diff] [blame] | 5635 | |
Bence Béky | c4caf07 | 2018-04-20 22:27:30 | [diff] [blame] | 5636 | const HttpResponseInfo* const response1 = trans->GetResponseInfo(); |
| 5637 | EXPECT_TRUE(response1->headers); |
| 5638 | EXPECT_EQ("HTTP/1.1 200", response1->headers->GetStatusLine()); |
Bence Béky | 04268b02 | 2018-04-19 01:17:41 | [diff] [blame] | 5639 | |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 5640 | std::string result1; |
Bence Béky | c4caf07 | 2018-04-20 22:27:30 | [diff] [blame] | 5641 | ReadResult(trans, &result1); |
| 5642 | EXPECT_EQ(result1, "hello!"); |
Bence Béky | 04268b02 | 2018-04-19 01:17:41 | [diff] [blame] | 5643 | |
Bence Béky | c4caf07 | 2018-04-20 22:27:30 | [diff] [blame] | 5644 | rv = callback2.WaitForResult(); |
| 5645 | EXPECT_THAT(rv, IsOk()); |
Bence Béky | 04268b02 | 2018-04-19 01:17:41 | [diff] [blame] | 5646 | |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 5647 | std::string result2; |
Bence Béky | c4caf07 | 2018-04-20 22:27:30 | [diff] [blame] | 5648 | ReadResult(&trans2, &result2); |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 5649 | EXPECT_EQ(result2, GetParam().push_accepted ? "This is pushed." |
| 5650 | : "This is not pushed."); |
Bence Béky | 04268b02 | 2018-04-19 01:17:41 | [diff] [blame] | 5651 | |
Bence Béky | c4caf07 | 2018-04-20 22:27:30 | [diff] [blame] | 5652 | data.Resume(); |
| 5653 | base::RunLoop().RunUntilIdle(); |
| 5654 | helper.VerifyDataConsumed(); |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 5655 | |
| 5656 | histogram_tester.ExpectBucketCount( |
| 5657 | "Net.SpdyPushedStreamFate", static_cast<int>(GetParam().expected_fate), |
| 5658 | 1); |
| 5659 | histogram_tester.ExpectTotalCount("Net.SpdyPushedStreamFate", 1); |
Bence Béky | c4caf07 | 2018-04-20 22:27:30 | [diff] [blame] | 5660 | } |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 5661 | }; |
| 5662 | |
Victor Costan | 2309ea0 | 2019-02-13 21:35:47 | [diff] [blame] | 5663 | INSTANTIATE_TEST_SUITE_P(, |
| 5664 | SpdyNetworkTransactionPushHeaderTest, |
| 5665 | ::testing::ValuesIn(push_header_test_cases)); |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 5666 | |
Bence Béky | e7023f8 | 2018-05-14 01:53:03 | [diff] [blame] | 5667 | TEST_P(SpdyNetworkTransactionPushHeaderTest, |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 5668 | PushedResponseHeadersReceivedBeforeRequest) { |
| 5669 | RunTest(/* pushed_response_headers_received_before_request = */ true); |
Bence Béky | 04268b02 | 2018-04-19 01:17:41 | [diff] [blame] | 5670 | } |
| 5671 | |
Bence Béky | e7023f8 | 2018-05-14 01:53:03 | [diff] [blame] | 5672 | TEST_P(SpdyNetworkTransactionPushHeaderTest, |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 5673 | PushedResponseHeadersReceivedAfterRequest) { |
| 5674 | RunTest(/* pushed_response_headers_received_before_request = */ false); |
[email protected] | d0835850 | 2010-12-03 22:04:03 | [diff] [blame] | 5675 | } |
| 5676 | |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 5677 | TEST_F(SpdyNetworkTransactionTest, ResponseHeadersTwice) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5678 | spdy::SpdySerializedFrame req( |
| 5679 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 5680 | spdy::SpdySerializedFrame rst( |
| 5681 | spdy_util_.ConstructSpdyRstStream(1, spdy::ERROR_CODE_PROTOCOL_ERROR)); |
[email protected] | b771bb7 | 2013-06-24 09:55:41 | [diff] [blame] | 5682 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 5683 | CreateMockWrite(req, 0), CreateMockWrite(rst, 4), |
[email protected] | 745aa9c | 2014-06-27 02:21:29 | [diff] [blame] | 5684 | }; |
[email protected] | d0835850 | 2010-12-03 22:04:03 | [diff] [blame] | 5685 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5686 | spdy::SpdySerializedFrame stream1_reply( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 5687 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
[email protected] | 513963e | 2013-06-15 01:53:04 | [diff] [blame] | 5688 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5689 | spdy::SpdyHeaderBlock late_headers; |
bnc | 38dcd39 | 2016-02-09 23:19:49 | [diff] [blame] | 5690 | late_headers["hello"] = "bye"; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5691 | spdy::SpdySerializedFrame stream1_headers( |
| 5692 | spdy_util_.ConstructSpdyResponseHeaders(1, std::move(late_headers), |
| 5693 | false)); |
| 5694 | spdy::SpdySerializedFrame stream1_body( |
| 5695 | spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | d0835850 | 2010-12-03 22:04:03 | [diff] [blame] | 5696 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 5697 | CreateMockRead(stream1_reply, 1), CreateMockRead(stream1_headers, 2), |
| 5698 | CreateMockRead(stream1_body, 3), MockRead(ASYNC, 0, 5) // EOF |
[email protected] | d0835850 | 2010-12-03 22:04:03 | [diff] [blame] | 5699 | }; |
| 5700 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 5701 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 5702 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 5703 | helper.RunToCompletion(&data); |
[email protected] | d0835850 | 2010-12-03 22:04:03 | [diff] [blame] | 5704 | TransactionHelperResult out = helper.output(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 5705 | EXPECT_THAT(out.rv, IsError(ERR_SPDY_PROTOCOL_ERROR)); |
[email protected] | d0835850 | 2010-12-03 22:04:03 | [diff] [blame] | 5706 | } |
| 5707 | |
xunjieli | 294da72 | 2015-08-11 19:15:02 | [diff] [blame] | 5708 | // Tests that receiving HEADERS, DATA, HEADERS, and DATA in that sequence will |
| 5709 | // trigger a ERR_SPDY_PROTOCOL_ERROR because trailing HEADERS must not be |
| 5710 | // followed by any DATA frames. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 5711 | TEST_F(SpdyNetworkTransactionTest, SyncReplyDataAfterTrailers) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5712 | spdy::SpdySerializedFrame req( |
| 5713 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 5714 | spdy::SpdySerializedFrame rst( |
| 5715 | spdy_util_.ConstructSpdyRstStream(1, spdy::ERROR_CODE_PROTOCOL_ERROR)); |
[email protected] | b771bb7 | 2013-06-24 09:55:41 | [diff] [blame] | 5716 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 5717 | CreateMockWrite(req, 0), CreateMockWrite(rst, 5), |
[email protected] | b771bb7 | 2013-06-24 09:55:41 | [diff] [blame] | 5718 | }; |
[email protected] | d0835850 | 2010-12-03 22:04:03 | [diff] [blame] | 5719 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5720 | spdy::SpdySerializedFrame stream1_reply( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 5721 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5722 | spdy::SpdySerializedFrame stream1_body( |
| 5723 | spdy_util_.ConstructSpdyDataFrame(1, false)); |
bnc | 38dcd39 | 2016-02-09 23:19:49 | [diff] [blame] | 5724 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5725 | spdy::SpdyHeaderBlock late_headers; |
bnc | 38dcd39 | 2016-02-09 23:19:49 | [diff] [blame] | 5726 | late_headers["hello"] = "bye"; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5727 | spdy::SpdySerializedFrame stream1_headers( |
| 5728 | spdy_util_.ConstructSpdyResponseHeaders(1, std::move(late_headers), |
| 5729 | false)); |
| 5730 | spdy::SpdySerializedFrame stream1_body2( |
| 5731 | spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | d0835850 | 2010-12-03 22:04:03 | [diff] [blame] | 5732 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 5733 | CreateMockRead(stream1_reply, 1), CreateMockRead(stream1_body, 2), |
| 5734 | CreateMockRead(stream1_headers, 3), CreateMockRead(stream1_body2, 4), |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 5735 | MockRead(ASYNC, 0, 6) // EOF |
[email protected] | d0835850 | 2010-12-03 22:04:03 | [diff] [blame] | 5736 | }; |
| 5737 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 5738 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 5739 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 5740 | helper.RunToCompletion(&data); |
[email protected] | d0835850 | 2010-12-03 22:04:03 | [diff] [blame] | 5741 | TransactionHelperResult out = helper.output(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 5742 | EXPECT_THAT(out.rv, IsError(ERR_SPDY_PROTOCOL_ERROR)); |
[email protected] | d0835850 | 2010-12-03 22:04:03 | [diff] [blame] | 5743 | } |
| 5744 | |
Bence Béky | e7023f8 | 2018-05-14 01:53:03 | [diff] [blame] | 5745 | struct PushUrlTestParams { |
| 5746 | const char* url_to_fetch; |
| 5747 | const char* url_to_push; |
Bence Béky | b2f7667 | 2018-06-11 21:10:13 | [diff] [blame] | 5748 | bool client_cert_sent; |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 5749 | SpdyPushedStreamFate expected_fate; |
Bence Béky | e7023f8 | 2018-05-14 01:53:03 | [diff] [blame] | 5750 | } push_url_test_cases[] = { |
| 5751 | // http scheme cannot be pushed (except by trusted proxy). |
Bence Béky | b2f7667 | 2018-06-11 21:10:13 | [diff] [blame] | 5752 | {"https://www.example.org/foo.html", "http://www.example.org/foo.js", false, |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 5753 | SpdyPushedStreamFate::kNonHttpsPushedScheme}, |
Bence Béky | e7023f8 | 2018-05-14 01:53:03 | [diff] [blame] | 5754 | // ftp scheme cannot be pushed. |
Bence Béky | b2f7667 | 2018-06-11 21:10:13 | [diff] [blame] | 5755 | {"https://www.example.org/foo.html", "ftp://www.example.org/foo.js", false, |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 5756 | SpdyPushedStreamFate::kInvalidUrl}, |
Bence Béky | e7023f8 | 2018-05-14 01:53:03 | [diff] [blame] | 5757 | // Cross subdomain, certificate not valid. |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 5758 | {"https://www.example.org/foo.html", "https://blat.www.example.org/foo.js", |
Bence Béky | b2f7667 | 2018-06-11 21:10:13 | [diff] [blame] | 5759 | false, SpdyPushedStreamFate::kCertificateMismatch}, |
Bence Béky | e7023f8 | 2018-05-14 01:53:03 | [diff] [blame] | 5760 | // Cross domain, certificate not valid. |
Bence Béky | b2f7667 | 2018-06-11 21:10:13 | [diff] [blame] | 5761 | {"https://www.example.org/foo.html", "https://www.foo.com/foo.js", false, |
| 5762 | SpdyPushedStreamFate::kCertificateMismatch}, |
| 5763 | // Cross domain, certificate valid, but cross-origin push is rejected on a |
| 5764 | // connection with client certificate. |
| 5765 | {"https://www.example.org/foo.html", "https://mail.example.org/foo.js", |
| 5766 | true, SpdyPushedStreamFate::kCertificateMismatch}}; |
Bence Béky | e7023f8 | 2018-05-14 01:53:03 | [diff] [blame] | 5767 | |
| 5768 | class SpdyNetworkTransactionPushUrlTest |
| 5769 | : public SpdyNetworkTransactionTest, |
| 5770 | public ::testing::WithParamInterface<PushUrlTestParams> { |
| 5771 | protected: |
[email protected] | a7a265ef | 2010-12-08 18:05:57 | [diff] [blame] | 5772 | // In this test we want to verify that we can't accidentally push content |
| 5773 | // which can't be pushed by this content server. |
| 5774 | // This test assumes that: |
| 5775 | // - if we're requesting http://www.foo.com/barbaz |
| 5776 | // - the browser has made a connection to "www.foo.com". |
Bence Béky | e7023f8 | 2018-05-14 01:53:03 | [diff] [blame] | 5777 | void RunTest() { |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 5778 | base::HistogramTester histogram_tester; |
| 5779 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 5780 | SpdyTestUtil spdy_test_util; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5781 | spdy::SpdySerializedFrame stream1_syn( |
Bence Béky | e7023f8 | 2018-05-14 01:53:03 | [diff] [blame] | 5782 | spdy_test_util.ConstructSpdyGet(GetParam().url_to_fetch, 1, LOWEST)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5783 | spdy::SpdySerializedFrame stream1_body( |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 5784 | spdy_test_util.ConstructSpdyDataFrame(1, true)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5785 | spdy::SpdySerializedFrame push_rst(spdy_test_util.ConstructSpdyRstStream( |
| 5786 | 2, spdy::ERROR_CODE_REFUSED_STREAM)); |
[email protected] | a7a265ef | 2010-12-08 18:05:57 | [diff] [blame] | 5787 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 5788 | CreateMockWrite(stream1_syn, 0), CreateMockWrite(push_rst, 3), |
[email protected] | a7a265ef | 2010-12-08 18:05:57 | [diff] [blame] | 5789 | }; |
| 5790 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5791 | spdy::SpdySerializedFrame stream1_reply( |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 5792 | spdy_test_util.ConstructSpdyGetReply(nullptr, 0, 1)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5793 | spdy::SpdySerializedFrame stream2_syn(spdy_test_util.ConstructSpdyPush( |
Bence Béky | e7023f8 | 2018-05-14 01:53:03 | [diff] [blame] | 5794 | nullptr, 0, 2, 1, GetParam().url_to_push)); |
[email protected] | 8a0fc82 | 2013-06-27 20:52:43 | [diff] [blame] | 5795 | const char kPushedData[] = "pushed"; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5796 | spdy::SpdySerializedFrame stream2_body( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 5797 | spdy_test_util.ConstructSpdyDataFrame(2, kPushedData, true)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5798 | spdy::SpdySerializedFrame rst( |
| 5799 | spdy_test_util.ConstructSpdyRstStream(2, spdy::ERROR_CODE_CANCEL)); |
[email protected] | a7a265ef | 2010-12-08 18:05:57 | [diff] [blame] | 5800 | |
| 5801 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 5802 | CreateMockRead(stream1_reply, 1), |
| 5803 | CreateMockRead(stream2_syn, 2), |
| 5804 | CreateMockRead(stream1_body, 4), |
| 5805 | CreateMockRead(stream2_body, 5), |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 5806 | MockRead(SYNCHRONOUS, ERR_IO_PENDING, 6), // Force a pause |
[email protected] | a7a265ef | 2010-12-08 18:05:57 | [diff] [blame] | 5807 | }; |
| 5808 | |
| 5809 | HttpResponseInfo response; |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 5810 | SequencedSocketData data(reads, writes); |
[email protected] | a7a265ef | 2010-12-08 18:05:57 | [diff] [blame] | 5811 | |
Bence Béky | e7023f8 | 2018-05-14 01:53:03 | [diff] [blame] | 5812 | request_.url = GURL(GetParam().url_to_fetch); |
[email protected] | a7a265ef | 2010-12-08 18:05:57 | [diff] [blame] | 5813 | |
[email protected] | 7c6f7ba | 2012-04-03 04:09:29 | [diff] [blame] | 5814 | // Enable cross-origin push. Since we are not using a proxy, this should |
| 5815 | // not actually enable cross-origin SPDY push. |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 5816 | auto session_deps = std::make_unique<SpdySessionDependencies>(); |
| 5817 | auto proxy_delegate = std::make_unique<TestProxyDelegate>(); |
tbansal | 28e68f8 | 2016-02-04 02:56:15 | [diff] [blame] | 5818 | proxy_delegate->set_trusted_spdy_proxy(net::ProxyServer::FromURI( |
| 5819 | "https://123.45.67.89:443", net::ProxyServer::SCHEME_HTTP)); |
Eric Roman | 3d8546a | 2018-09-10 17:00:52 | [diff] [blame] | 5820 | session_deps->proxy_resolution_service->SetProxyDelegate( |
| 5821 | proxy_delegate.get()); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 5822 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
Bence Béky | d3dde83 | 2017-09-19 19:02:31 | [diff] [blame] | 5823 | std::move(session_deps)); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 5824 | |
[email protected] | 61b4efc | 2012-04-27 18:12:50 | [diff] [blame] | 5825 | helper.RunPreTestSetup(); |
Bence Béky | b2f7667 | 2018-06-11 21:10:13 | [diff] [blame] | 5826 | |
| 5827 | auto ssl_provider = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
| 5828 | ssl_provider->ssl_info.client_cert_sent = GetParam().client_cert_sent; |
| 5829 | ssl_provider->ssl_info.cert = |
| 5830 | ImportCertFromFile(GetTestCertsDirectory(), "spdy_pooling.pem"); |
| 5831 | helper.AddDataWithSSLSocketDataProvider(&data, std::move(ssl_provider)); |
[email protected] | 7c6f7ba | 2012-04-03 04:09:29 | [diff] [blame] | 5832 | |
[email protected] | a7a265ef | 2010-12-08 18:05:57 | [diff] [blame] | 5833 | HttpNetworkTransaction* trans = helper.trans(); |
| 5834 | |
| 5835 | // Start the transaction with basic parameters. |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 5836 | TestCompletionCallback callback; |
[email protected] | a7a265ef | 2010-12-08 18:05:57 | [diff] [blame] | 5837 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 5838 | int rv = trans->Start(&request_, callback.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 5839 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | a7a265ef | 2010-12-08 18:05:57 | [diff] [blame] | 5840 | rv = callback.WaitForResult(); |
| 5841 | |
bnc | eb9aa711 | 2017-01-05 01:03:46 | [diff] [blame] | 5842 | // Finish async network reads/writes. |
| 5843 | base::RunLoop().RunUntilIdle(); |
| 5844 | |
[email protected] | a7a265ef | 2010-12-08 18:05:57 | [diff] [blame] | 5845 | // Read the response body. |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 5846 | std::string result; |
rch | 0aecfd8 | 2015-05-19 17:22:32 | [diff] [blame] | 5847 | ReadResult(trans, &result); |
[email protected] | a7a265ef | 2010-12-08 18:05:57 | [diff] [blame] | 5848 | |
| 5849 | // Verify that we consumed all test data. |
rch | 37de576c | 2015-05-17 20:28:17 | [diff] [blame] | 5850 | EXPECT_TRUE(data.AllReadDataConsumed()); |
| 5851 | EXPECT_TRUE(data.AllWriteDataConsumed()); |
[email protected] | a7a265ef | 2010-12-08 18:05:57 | [diff] [blame] | 5852 | |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 5853 | // Verify the response headers. |
[email protected] | a7a265ef | 2010-12-08 18:05:57 | [diff] [blame] | 5854 | // Copy the response info, because trans goes away. |
| 5855 | response = *trans->GetResponseInfo(); |
| 5856 | |
| 5857 | VerifyStreamsClosed(helper); |
| 5858 | |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 5859 | // Verify the response headers. |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 5860 | EXPECT_TRUE(response.headers); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 5861 | EXPECT_EQ("HTTP/1.1 200", response.headers->GetStatusLine()); |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 5862 | |
| 5863 | histogram_tester.ExpectBucketCount( |
| 5864 | "Net.SpdyPushedStreamFate", static_cast<int>(GetParam().expected_fate), |
| 5865 | 1); |
| 5866 | histogram_tester.ExpectTotalCount("Net.SpdyPushedStreamFate", 1); |
[email protected] | a7a265ef | 2010-12-08 18:05:57 | [diff] [blame] | 5867 | } |
Bence Béky | e7023f8 | 2018-05-14 01:53:03 | [diff] [blame] | 5868 | }; |
| 5869 | |
Victor Costan | 2309ea0 | 2019-02-13 21:35:47 | [diff] [blame] | 5870 | INSTANTIATE_TEST_SUITE_P(, |
| 5871 | SpdyNetworkTransactionPushUrlTest, |
| 5872 | ::testing::ValuesIn(push_url_test_cases)); |
Bence Béky | e7023f8 | 2018-05-14 01:53:03 | [diff] [blame] | 5873 | |
| 5874 | TEST_P(SpdyNetworkTransactionPushUrlTest, PushUrlTest) { |
| 5875 | RunTest(); |
[email protected] | a7a265ef | 2010-12-08 18:05:57 | [diff] [blame] | 5876 | } |
| 5877 | |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 5878 | // Verify that push works cross origin as long as the certificate is valid for |
| 5879 | // the pushed authority. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 5880 | TEST_F(SpdyNetworkTransactionTest, ServerPushValidCrossOrigin) { |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 5881 | // "spdy_pooling.pem" is valid for both www.example.org and mail.example.org. |
| 5882 | const char* url_to_fetch = "https://www.example.org"; |
| 5883 | const char* url_to_push = "https://mail.example.org"; |
| 5884 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5885 | spdy::SpdySerializedFrame headers( |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 5886 | spdy_util_.ConstructSpdyGet(url_to_fetch, 1, LOWEST)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5887 | spdy::SpdySerializedFrame push_priority( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 5888 | spdy_util_.ConstructSpdyPriority(2, 1, IDLE, true)); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 5889 | MockWrite writes[] = { |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 5890 | CreateMockWrite(headers, 0), CreateMockWrite(push_priority, 3), |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 5891 | }; |
| 5892 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5893 | spdy::SpdySerializedFrame reply( |
| 5894 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 5895 | spdy::SpdySerializedFrame push( |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 5896 | spdy_util_.ConstructSpdyPush(nullptr, 0, 2, 1, url_to_push)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5897 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 5898 | const char kPushedData[] = "pushed"; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5899 | spdy::SpdySerializedFrame pushed_body( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 5900 | spdy_util_.ConstructSpdyDataFrame(2, kPushedData, true)); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 5901 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 5902 | CreateMockRead(reply, 1), |
bnc | eb9aa711 | 2017-01-05 01:03:46 | [diff] [blame] | 5903 | CreateMockRead(push, 2, SYNCHRONOUS), |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 5904 | CreateMockRead(body, 4), |
| 5905 | CreateMockRead(pushed_body, 5, SYNCHRONOUS), |
| 5906 | MockRead(SYNCHRONOUS, ERR_IO_PENDING, 6), |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 5907 | }; |
| 5908 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 5909 | SequencedSocketData data(reads, writes); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 5910 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 5911 | request_.url = GURL(url_to_fetch); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 5912 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 5913 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 5914 | helper.RunPreTestSetup(); |
| 5915 | helper.AddData(&data); |
| 5916 | |
| 5917 | HttpNetworkTransaction* trans0 = helper.trans(); |
| 5918 | TestCompletionCallback callback0; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 5919 | int rv = trans0->Start(&request_, callback0.callback(), log_); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 5920 | rv = callback0.GetResult(rv); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 5921 | EXPECT_THAT(rv, IsOk()); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 5922 | |
| 5923 | SpdySessionPool* spdy_session_pool = helper.session()->spdy_session_pool(); |
bnc | b2602438 | 2016-06-29 02:39:45 | [diff] [blame] | 5924 | SpdySessionKey key(host_port_pair_, ProxyServer::Direct(), |
Matt Menke | 2436b2f | 2018-12-11 18:07:11 | [diff] [blame] | 5925 | PRIVACY_MODE_DISABLED, |
| 5926 | SpdySessionKey::IsProxySession::kFalse, SocketTag()); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 5927 | base::WeakPtr<SpdySession> spdy_session = |
bnc | 9ead3ae | 2017-03-16 00:48:15 | [diff] [blame] | 5928 | spdy_session_pool->FindAvailableSession( |
Bence Béky | d885b2b | 2018-02-03 00:58:31 | [diff] [blame] | 5929 | key, /* enable_ip_based_pooling = */ true, |
| 5930 | /* is_websocket = */ false, log_); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 5931 | |
Bence Béky | 285e7d4 | 2017-12-04 20:22:11 | [diff] [blame] | 5932 | EXPECT_EQ(1u, num_unclaimed_pushed_streams(spdy_session)); |
Bence Béky | 3b60901 | 2017-12-04 15:19:35 | [diff] [blame] | 5933 | EXPECT_TRUE( |
Bence Béky | 285e7d4 | 2017-12-04 20:22:11 | [diff] [blame] | 5934 | has_unclaimed_pushed_stream_for_url(spdy_session, GURL(url_to_push))); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 5935 | |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 5936 | HttpNetworkTransaction trans1(DEFAULT_PRIORITY, helper.session()); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 5937 | HttpRequestInfo push_request; |
| 5938 | push_request.method = "GET"; |
| 5939 | push_request.url = GURL(url_to_push); |
Ramin Halavati | b5e433e6 | 2018-02-07 07:41:10 | [diff] [blame] | 5940 | push_request.traffic_annotation = |
| 5941 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 5942 | TestCompletionCallback callback1; |
Bence Béky | d3dde83 | 2017-09-19 19:02:31 | [diff] [blame] | 5943 | rv = trans1.Start(&push_request, callback1.callback(), log_); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 5944 | rv = callback1.GetResult(rv); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 5945 | EXPECT_THAT(rv, IsOk()); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 5946 | |
Bence Béky | 285e7d4 | 2017-12-04 20:22:11 | [diff] [blame] | 5947 | EXPECT_EQ(0u, num_unclaimed_pushed_streams(spdy_session)); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 5948 | |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 5949 | HttpResponseInfo response = *trans0->GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 5950 | EXPECT_TRUE(response.headers); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 5951 | EXPECT_EQ("HTTP/1.1 200", response.headers->GetStatusLine()); |
| 5952 | |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 5953 | std::string result0; |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 5954 | ReadResult(trans0, &result0); |
| 5955 | EXPECT_EQ("hello!", result0); |
| 5956 | |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 5957 | HttpResponseInfo push_response = *trans1.GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 5958 | EXPECT_TRUE(push_response.headers); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 5959 | EXPECT_EQ("HTTP/1.1 200", push_response.headers->GetStatusLine()); |
| 5960 | |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 5961 | std::string result1; |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 5962 | ReadResult(&trans1, &result1); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 5963 | EXPECT_EQ(kPushedData, result1); |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 5964 | |
| 5965 | base::RunLoop().RunUntilIdle(); |
| 5966 | helper.VerifyDataConsumed(); |
| 5967 | VerifyStreamsClosed(helper); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 5968 | } |
| 5969 | |
Bence Béky | b2f7667 | 2018-06-11 21:10:13 | [diff] [blame] | 5970 | // Regression test for https://crbug.com/832859: Server push is accepted on a |
| 5971 | // connection with client certificate, as long as SpdySessionKey matches. |
| 5972 | TEST_F(SpdyNetworkTransactionTest, ServerPushWithClientCert) { |
| 5973 | spdy::SpdySerializedFrame req( |
| 5974 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, DEFAULT_PRIORITY)); |
| 5975 | spdy::SpdySerializedFrame priority( |
| 5976 | spdy_util_.ConstructSpdyPriority(2, 1, IDLE, true)); |
| 5977 | MockWrite writes[] = {CreateMockWrite(req, 0), CreateMockWrite(priority, 3)}; |
| 5978 | |
| 5979 | spdy::SpdySerializedFrame resp( |
| 5980 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 5981 | spdy::SpdySerializedFrame push( |
| 5982 | spdy_util_.ConstructSpdyPush(nullptr, 0, 2, 1, kPushedUrl)); |
| 5983 | spdy::SpdySerializedFrame body1(spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 5984 | spdy::SpdySerializedFrame body2( |
| 5985 | spdy_util_.ConstructSpdyDataFrame(2, "pushed", true)); |
| 5986 | MockRead reads[] = {CreateMockRead(resp, 1), CreateMockRead(push, 2), |
| 5987 | CreateMockRead(body1, 4), CreateMockRead(body2, 5), |
| 5988 | MockRead(SYNCHRONOUS, ERR_IO_PENDING, 6)}; |
| 5989 | |
| 5990 | SequencedSocketData data(reads, writes); |
| 5991 | |
| 5992 | auto ssl_provider = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
| 5993 | ssl_provider->ssl_info.client_cert_sent = true; |
| 5994 | ssl_provider->ssl_info.cert = |
| 5995 | ImportCertFromFile(GetTestCertsDirectory(), "spdy_pooling.pem"); |
| 5996 | |
| 5997 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
| 5998 | helper.RunPreTestSetup(); |
| 5999 | helper.AddDataWithSSLSocketDataProvider(&data, std::move(ssl_provider)); |
| 6000 | |
| 6001 | EXPECT_TRUE(helper.StartDefaultTest()); |
| 6002 | helper.FinishDefaultTest(); |
| 6003 | |
| 6004 | HttpNetworkTransaction trans2(DEFAULT_PRIORITY, helper.session()); |
| 6005 | HttpRequestInfo request = CreateGetPushRequest(); |
| 6006 | TestCompletionCallback callback; |
| 6007 | int rv = trans2.Start(&request, callback.callback(), log_); |
| 6008 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 6009 | |
| 6010 | rv = callback.WaitForResult(); |
| 6011 | EXPECT_THAT(rv, IsOk()); |
| 6012 | |
| 6013 | const HttpResponseInfo* const response = trans2.GetResponseInfo(); |
| 6014 | EXPECT_TRUE(response->headers); |
| 6015 | EXPECT_EQ("HTTP/1.1 200", response->headers->GetStatusLine()); |
| 6016 | |
| 6017 | std::string result; |
| 6018 | ReadResult(&trans2, &result); |
| 6019 | EXPECT_EQ("pushed", result); |
| 6020 | |
| 6021 | EXPECT_TRUE(data.AllReadDataConsumed()); |
| 6022 | EXPECT_TRUE(data.AllWriteDataConsumed()); |
| 6023 | |
| 6024 | VerifyStreamsClosed(helper); |
| 6025 | } |
| 6026 | |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6027 | // Verify that push works cross origin, even if there is already a connection |
| 6028 | // open to origin of pushed resource. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 6029 | TEST_F(SpdyNetworkTransactionTest, ServerPushValidCrossOriginWithOpenSession) { |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6030 | const char* url_to_fetch0 = "https://mail.example.org/foo"; |
| 6031 | const char* url_to_fetch1 = "https://docs.example.org"; |
| 6032 | const char* url_to_push = "https://mail.example.org/bar"; |
| 6033 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 6034 | SpdyTestUtil spdy_util_0; |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6035 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6036 | spdy::SpdySerializedFrame headers0( |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6037 | spdy_util_0.ConstructSpdyGet(url_to_fetch0, 1, LOWEST)); |
| 6038 | MockWrite writes0[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 6039 | CreateMockWrite(headers0, 0), |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6040 | }; |
| 6041 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6042 | spdy::SpdySerializedFrame reply0( |
| 6043 | spdy_util_0.ConstructSpdyGetReply(nullptr, 0, 1)); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6044 | const char kData0[] = "first"; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6045 | spdy::SpdySerializedFrame body0( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 6046 | spdy_util_0.ConstructSpdyDataFrame(1, kData0, true)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 6047 | MockRead reads0[] = {CreateMockRead(reply0, 1), CreateMockRead(body0, 2), |
| 6048 | MockRead(SYNCHRONOUS, ERR_IO_PENDING, 3)}; |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6049 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 6050 | SequencedSocketData data0(reads0, writes0); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6051 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 6052 | SpdyTestUtil spdy_util_1; |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6053 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6054 | spdy::SpdySerializedFrame headers1( |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6055 | spdy_util_1.ConstructSpdyGet(url_to_fetch1, 1, LOWEST)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6056 | spdy::SpdySerializedFrame push_priority( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 6057 | spdy_util_.ConstructSpdyPriority(2, 1, IDLE, true)); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6058 | MockWrite writes1[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 6059 | CreateMockWrite(headers1, 0), |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 6060 | CreateMockWrite(push_priority, 3, SYNCHRONOUS), |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6061 | }; |
| 6062 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6063 | spdy::SpdySerializedFrame reply1( |
| 6064 | spdy_util_1.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 6065 | spdy::SpdySerializedFrame push( |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6066 | spdy_util_1.ConstructSpdyPush(nullptr, 0, 2, 1, url_to_push)); |
| 6067 | const char kData1[] = "second"; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6068 | spdy::SpdySerializedFrame body1( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 6069 | spdy_util_1.ConstructSpdyDataFrame(1, kData1, true)); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6070 | const char kPushedData[] = "pushed"; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6071 | spdy::SpdySerializedFrame pushed_body( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 6072 | spdy_util_1.ConstructSpdyDataFrame(2, kPushedData, true)); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6073 | |
| 6074 | MockRead reads1[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 6075 | CreateMockRead(reply1, 1), |
bnc | eb9aa711 | 2017-01-05 01:03:46 | [diff] [blame] | 6076 | CreateMockRead(push, 2, SYNCHRONOUS), |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 6077 | CreateMockRead(body1, 4), |
| 6078 | CreateMockRead(pushed_body, 5, SYNCHRONOUS), |
| 6079 | MockRead(SYNCHRONOUS, ERR_IO_PENDING, 6), |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6080 | }; |
| 6081 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 6082 | SequencedSocketData data1(reads1, writes1); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6083 | |
| 6084 | // Request |url_to_fetch0| to open connection to mail.example.org. |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 6085 | request_.url = GURL(url_to_fetch0); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6086 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 6087 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6088 | helper.RunPreTestSetup(); |
| 6089 | |
| 6090 | // "spdy_pooling.pem" is valid for www.example.org, but not for |
| 6091 | // docs.example.org. |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 6092 | auto ssl_provider0 = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
Ryan Sleevi | 4f83209 | 2017-11-21 23:25:49 | [diff] [blame] | 6093 | ssl_provider0->ssl_info.cert = |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6094 | ImportCertFromFile(GetTestCertsDirectory(), "spdy_pooling.pem"); |
Ryan Sleevi | 4f83209 | 2017-11-21 23:25:49 | [diff] [blame] | 6095 | ASSERT_TRUE(ssl_provider0->ssl_info.cert); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6096 | helper.AddDataWithSSLSocketDataProvider(&data0, std::move(ssl_provider0)); |
| 6097 | |
| 6098 | // "wildcard.pem" is valid for both www.example.org and docs.example.org. |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 6099 | auto ssl_provider1 = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
Ryan Sleevi | 4f83209 | 2017-11-21 23:25:49 | [diff] [blame] | 6100 | ssl_provider1->ssl_info.cert = |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6101 | ImportCertFromFile(GetTestCertsDirectory(), "wildcard.pem"); |
Ryan Sleevi | 4f83209 | 2017-11-21 23:25:49 | [diff] [blame] | 6102 | ASSERT_TRUE(ssl_provider1->ssl_info.cert); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6103 | helper.AddDataWithSSLSocketDataProvider(&data1, std::move(ssl_provider1)); |
| 6104 | |
| 6105 | HttpNetworkTransaction* trans0 = helper.trans(); |
| 6106 | TestCompletionCallback callback0; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 6107 | int rv = trans0->Start(&request_, callback0.callback(), log_); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6108 | rv = callback0.GetResult(rv); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 6109 | EXPECT_THAT(rv, IsOk()); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6110 | |
| 6111 | // Request |url_to_fetch1|, during which docs.example.org pushes |
| 6112 | // |url_to_push|, which happens to be for www.example.org, to which there is |
| 6113 | // already an open connection. |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 6114 | HttpNetworkTransaction trans1(DEFAULT_PRIORITY, helper.session()); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6115 | HttpRequestInfo request1; |
| 6116 | request1.method = "GET"; |
| 6117 | request1.url = GURL(url_to_fetch1); |
Ramin Halavati | b5e433e6 | 2018-02-07 07:41:10 | [diff] [blame] | 6118 | request1.traffic_annotation = |
| 6119 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6120 | TestCompletionCallback callback1; |
Bence Béky | d3dde83 | 2017-09-19 19:02:31 | [diff] [blame] | 6121 | rv = trans1.Start(&request1, callback1.callback(), log_); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6122 | rv = callback1.GetResult(rv); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 6123 | EXPECT_THAT(rv, IsOk()); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6124 | |
| 6125 | SpdySessionPool* spdy_session_pool = helper.session()->spdy_session_pool(); |
| 6126 | HostPortPair host_port_pair0("mail.example.org", 443); |
| 6127 | SpdySessionKey key0(host_port_pair0, ProxyServer::Direct(), |
Matt Menke | 2436b2f | 2018-12-11 18:07:11 | [diff] [blame] | 6128 | PRIVACY_MODE_DISABLED, |
| 6129 | SpdySessionKey::IsProxySession::kFalse, SocketTag()); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6130 | base::WeakPtr<SpdySession> spdy_session0 = |
bnc | 9ead3ae | 2017-03-16 00:48:15 | [diff] [blame] | 6131 | spdy_session_pool->FindAvailableSession( |
Bence Béky | d885b2b | 2018-02-03 00:58:31 | [diff] [blame] | 6132 | key0, /* enable_ip_based_pooling = */ true, |
| 6133 | /* is_websocket = */ false, log_); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6134 | |
Bence Béky | 285e7d4 | 2017-12-04 20:22:11 | [diff] [blame] | 6135 | EXPECT_EQ(0u, num_unclaimed_pushed_streams(spdy_session0)); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6136 | |
| 6137 | HostPortPair host_port_pair1("docs.example.org", 443); |
| 6138 | SpdySessionKey key1(host_port_pair1, ProxyServer::Direct(), |
Matt Menke | 2436b2f | 2018-12-11 18:07:11 | [diff] [blame] | 6139 | PRIVACY_MODE_DISABLED, |
| 6140 | SpdySessionKey::IsProxySession::kFalse, SocketTag()); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6141 | base::WeakPtr<SpdySession> spdy_session1 = |
bnc | 9ead3ae | 2017-03-16 00:48:15 | [diff] [blame] | 6142 | spdy_session_pool->FindAvailableSession( |
Bence Béky | d885b2b | 2018-02-03 00:58:31 | [diff] [blame] | 6143 | key1, /* enable_ip_based_pooling = */ true, |
| 6144 | /* is_websocket = */ false, log_); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6145 | |
Bence Béky | 285e7d4 | 2017-12-04 20:22:11 | [diff] [blame] | 6146 | EXPECT_EQ(1u, num_unclaimed_pushed_streams(spdy_session1)); |
Bence Béky | 3b60901 | 2017-12-04 15:19:35 | [diff] [blame] | 6147 | EXPECT_TRUE( |
Bence Béky | 285e7d4 | 2017-12-04 20:22:11 | [diff] [blame] | 6148 | has_unclaimed_pushed_stream_for_url(spdy_session1, GURL(url_to_push))); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6149 | |
| 6150 | // Request |url_to_push|, which should be served from the pushed resource. |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 6151 | HttpNetworkTransaction trans2(DEFAULT_PRIORITY, helper.session()); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6152 | HttpRequestInfo push_request; |
| 6153 | push_request.method = "GET"; |
| 6154 | push_request.url = GURL(url_to_push); |
Ramin Halavati | b5e433e6 | 2018-02-07 07:41:10 | [diff] [blame] | 6155 | push_request.traffic_annotation = |
| 6156 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6157 | TestCompletionCallback callback2; |
Bence Béky | d3dde83 | 2017-09-19 19:02:31 | [diff] [blame] | 6158 | rv = trans2.Start(&push_request, callback2.callback(), log_); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6159 | rv = callback2.GetResult(rv); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 6160 | EXPECT_THAT(rv, IsOk()); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6161 | |
Bence Béky | 285e7d4 | 2017-12-04 20:22:11 | [diff] [blame] | 6162 | EXPECT_EQ(0u, num_unclaimed_pushed_streams(spdy_session0)); |
| 6163 | EXPECT_EQ(0u, num_unclaimed_pushed_streams(spdy_session1)); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6164 | |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6165 | HttpResponseInfo response0 = *trans0->GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 6166 | EXPECT_TRUE(response0.headers); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6167 | EXPECT_EQ("HTTP/1.1 200", response0.headers->GetStatusLine()); |
| 6168 | |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 6169 | std::string result0; |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6170 | ReadResult(trans0, &result0); |
| 6171 | EXPECT_EQ(kData0, result0); |
| 6172 | |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 6173 | HttpResponseInfo response1 = *trans1.GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 6174 | EXPECT_TRUE(response1.headers); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6175 | EXPECT_EQ("HTTP/1.1 200", response1.headers->GetStatusLine()); |
| 6176 | |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 6177 | std::string result1; |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 6178 | ReadResult(&trans1, &result1); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6179 | EXPECT_EQ(kData1, result1); |
| 6180 | |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 6181 | HttpResponseInfo push_response = *trans2.GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 6182 | EXPECT_TRUE(push_response.headers); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6183 | EXPECT_EQ("HTTP/1.1 200", push_response.headers->GetStatusLine()); |
| 6184 | |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 6185 | std::string result2; |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 6186 | ReadResult(&trans2, &result2); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6187 | EXPECT_EQ(kPushedData, result2); |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 6188 | |
| 6189 | base::RunLoop().RunUntilIdle(); |
| 6190 | helper.VerifyDataConsumed(); |
| 6191 | VerifyStreamsClosed(helper); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6192 | } |
| 6193 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 6194 | TEST_F(SpdyNetworkTransactionTest, RetryAfterRefused) { |
[email protected] | 721c0ce | 2011-10-13 02:41:00 | [diff] [blame] | 6195 | // Construct the request. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6196 | spdy::SpdySerializedFrame req( |
| 6197 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
rdsmith | ebb50aa | 2015-11-12 03:44:38 | [diff] [blame] | 6198 | // Will be destroyed by the RST before stream 3 starts. |
| 6199 | spdy_util_.UpdateWithStreamDestruction(1); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6200 | spdy::SpdySerializedFrame req2( |
| 6201 | spdy_util_.ConstructSpdyGet(nullptr, 0, 3, LOWEST)); |
[email protected] | 721c0ce | 2011-10-13 02:41:00 | [diff] [blame] | 6202 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 6203 | CreateMockWrite(req, 0), CreateMockWrite(req2, 2), |
[email protected] | 721c0ce | 2011-10-13 02:41:00 | [diff] [blame] | 6204 | }; |
| 6205 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6206 | spdy::SpdySerializedFrame refused( |
| 6207 | spdy_util_.ConstructSpdyRstStream(1, spdy::ERROR_CODE_REFUSED_STREAM)); |
| 6208 | spdy::SpdySerializedFrame resp( |
| 6209 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 3)); |
| 6210 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(3, true)); |
[email protected] | 721c0ce | 2011-10-13 02:41:00 | [diff] [blame] | 6211 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 6212 | CreateMockRead(refused, 1), CreateMockRead(resp, 3), |
| 6213 | CreateMockRead(body, 4), MockRead(ASYNC, 0, 5) // EOF |
[email protected] | 721c0ce | 2011-10-13 02:41:00 | [diff] [blame] | 6214 | }; |
| 6215 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 6216 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 6217 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | 721c0ce | 2011-10-13 02:41:00 | [diff] [blame] | 6218 | |
| 6219 | helper.RunPreTestSetup(); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 6220 | helper.AddData(&data); |
[email protected] | 721c0ce | 2011-10-13 02:41:00 | [diff] [blame] | 6221 | |
| 6222 | HttpNetworkTransaction* trans = helper.trans(); |
| 6223 | |
| 6224 | // Start the transaction with basic parameters. |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 6225 | TestCompletionCallback callback; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 6226 | int rv = trans->Start(&request_, callback.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 6227 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | 721c0ce | 2011-10-13 02:41:00 | [diff] [blame] | 6228 | rv = callback.WaitForResult(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 6229 | EXPECT_THAT(rv, IsOk()); |
[email protected] | 721c0ce | 2011-10-13 02:41:00 | [diff] [blame] | 6230 | |
bnc | eb9aa711 | 2017-01-05 01:03:46 | [diff] [blame] | 6231 | // Finish async network reads. |
| 6232 | base::RunLoop().RunUntilIdle(); |
| 6233 | |
[email protected] | 721c0ce | 2011-10-13 02:41:00 | [diff] [blame] | 6234 | // Verify that we consumed all test data. |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 6235 | EXPECT_TRUE(data.AllReadDataConsumed()); |
| 6236 | EXPECT_TRUE(data.AllWriteDataConsumed()); |
[email protected] | 721c0ce | 2011-10-13 02:41:00 | [diff] [blame] | 6237 | |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 6238 | // Verify the response headers. |
[email protected] | 721c0ce | 2011-10-13 02:41:00 | [diff] [blame] | 6239 | HttpResponseInfo response = *trans->GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 6240 | EXPECT_TRUE(response.headers); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 6241 | EXPECT_EQ("HTTP/1.1 200", response.headers->GetStatusLine()); |
[email protected] | 721c0ce | 2011-10-13 02:41:00 | [diff] [blame] | 6242 | } |
| 6243 | |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 6244 | TEST_F(SpdyNetworkTransactionTest, OutOfOrderHeaders) { |
[email protected] | e1f58efa | 2012-05-15 18:23:40 | [diff] [blame] | 6245 | // This first request will start to establish the SpdySession. |
| 6246 | // Then we will start the second (MEDIUM priority) and then third |
| 6247 | // (HIGHEST priority) request in such a way that the third will actually |
[email protected] | c92f4b454 | 2012-07-26 23:53:21 | [diff] [blame] | 6248 | // start before the second, causing the second to be numbered differently |
[email protected] | 513963e | 2013-06-15 01:53:04 | [diff] [blame] | 6249 | // than the order they were created. |
rdsmith | ebb50aa | 2015-11-12 03:44:38 | [diff] [blame] | 6250 | // |
| 6251 | // Note that the requests and responses created below are expectations |
| 6252 | // of what the above will produce on the wire, and hence are in the |
| 6253 | // initial->HIGHEST->LOWEST priority. |
| 6254 | // |
| 6255 | // Frames are created by SpdySession just before the write associated |
| 6256 | // with the frame is attempted, so stream dependencies will be based |
| 6257 | // on the streams alive at the point of the request write attempt. Thus |
| 6258 | // req1 is alive when req2 is attempted (during but not after the |
| 6259 | // |data.RunFor(2);| statement below) but not when req3 is attempted. |
| 6260 | // The call to spdy_util_.UpdateWithStreamDestruction() reflects this. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6261 | spdy::SpdySerializedFrame req1( |
| 6262 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 6263 | spdy::SpdySerializedFrame req2( |
| 6264 | spdy_util_.ConstructSpdyGet(nullptr, 0, 3, HIGHEST)); |
rdsmith | ebb50aa | 2015-11-12 03:44:38 | [diff] [blame] | 6265 | spdy_util_.UpdateWithStreamDestruction(1); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6266 | spdy::SpdySerializedFrame req3( |
| 6267 | spdy_util_.ConstructSpdyGet(nullptr, 0, 5, MEDIUM)); |
[email protected] | e1f58efa | 2012-05-15 18:23:40 | [diff] [blame] | 6268 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 6269 | MockWrite(ASYNC, ERR_IO_PENDING, 0), CreateMockWrite(req1, 1), |
| 6270 | CreateMockWrite(req2, 5), CreateMockWrite(req3, 6), |
[email protected] | e1f58efa | 2012-05-15 18:23:40 | [diff] [blame] | 6271 | }; |
| 6272 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6273 | spdy::SpdySerializedFrame resp1( |
| 6274 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 6275 | spdy::SpdySerializedFrame body1(spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 6276 | spdy::SpdySerializedFrame resp2( |
| 6277 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 3)); |
| 6278 | spdy::SpdySerializedFrame body2(spdy_util_.ConstructSpdyDataFrame(3, true)); |
| 6279 | spdy::SpdySerializedFrame resp3( |
| 6280 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 5)); |
| 6281 | spdy::SpdySerializedFrame body3(spdy_util_.ConstructSpdyDataFrame(5, true)); |
[email protected] | e1f58efa | 2012-05-15 18:23:40 | [diff] [blame] | 6282 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 6283 | CreateMockRead(resp1, 2), MockRead(ASYNC, ERR_IO_PENDING, 3), |
| 6284 | CreateMockRead(body1, 4), CreateMockRead(resp2, 7), |
| 6285 | CreateMockRead(body2, 8), CreateMockRead(resp3, 9), |
| 6286 | CreateMockRead(body3, 10), MockRead(ASYNC, 0, 11) // EOF |
[email protected] | e1f58efa | 2012-05-15 18:23:40 | [diff] [blame] | 6287 | }; |
| 6288 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 6289 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 6290 | NormalSpdyTransactionHelper helper(request_, LOWEST, log_, nullptr); |
[email protected] | e1f58efa | 2012-05-15 18:23:40 | [diff] [blame] | 6291 | helper.RunPreTestSetup(); |
mmenke | 666a6fea | 2015-12-19 04:16:33 | [diff] [blame] | 6292 | helper.AddData(&data); |
[email protected] | e1f58efa | 2012-05-15 18:23:40 | [diff] [blame] | 6293 | |
| 6294 | // Start the first transaction to set up the SpdySession |
| 6295 | HttpNetworkTransaction* trans = helper.trans(); |
| 6296 | TestCompletionCallback callback; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 6297 | int rv = trans->Start(&request_, callback.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 6298 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | e1f58efa | 2012-05-15 18:23:40 | [diff] [blame] | 6299 | |
| 6300 | // Run the message loop, but do not allow the write to complete. |
| 6301 | // This leaves the SpdySession with a write pending, which prevents |
| 6302 | // SpdySession from attempting subsequent writes until this write completes. |
[email protected] | fc9d8847 | 2013-08-14 02:31:17 | [diff] [blame] | 6303 | base::RunLoop().RunUntilIdle(); |
[email protected] | e1f58efa | 2012-05-15 18:23:40 | [diff] [blame] | 6304 | |
| 6305 | // Now, start both new transactions |
[email protected] | e1f58efa | 2012-05-15 18:23:40 | [diff] [blame] | 6306 | TestCompletionCallback callback2; |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 6307 | HttpNetworkTransaction trans2(MEDIUM, helper.session()); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 6308 | rv = trans2.Start(&request_, callback2.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 6309 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | fc9d8847 | 2013-08-14 02:31:17 | [diff] [blame] | 6310 | base::RunLoop().RunUntilIdle(); |
[email protected] | e1f58efa | 2012-05-15 18:23:40 | [diff] [blame] | 6311 | |
[email protected] | e1f58efa | 2012-05-15 18:23:40 | [diff] [blame] | 6312 | TestCompletionCallback callback3; |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 6313 | HttpNetworkTransaction trans3(HIGHEST, helper.session()); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 6314 | rv = trans3.Start(&request_, callback3.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 6315 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | fc9d8847 | 2013-08-14 02:31:17 | [diff] [blame] | 6316 | base::RunLoop().RunUntilIdle(); |
[email protected] | e1f58efa | 2012-05-15 18:23:40 | [diff] [blame] | 6317 | |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 6318 | // We now have two HEADERS frames queued up which will be |
[email protected] | e1f58efa | 2012-05-15 18:23:40 | [diff] [blame] | 6319 | // dequeued only once the first write completes, which we |
| 6320 | // now allow to happen. |
mmenke | 666a6fea | 2015-12-19 04:16:33 | [diff] [blame] | 6321 | ASSERT_TRUE(data.IsPaused()); |
| 6322 | data.Resume(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 6323 | EXPECT_THAT(callback.WaitForResult(), IsOk()); |
[email protected] | e1f58efa | 2012-05-15 18:23:40 | [diff] [blame] | 6324 | |
| 6325 | // And now we can allow everything else to run to completion. |
mmenke | 666a6fea | 2015-12-19 04:16:33 | [diff] [blame] | 6326 | data.Resume(); |
| 6327 | base::RunLoop().RunUntilIdle(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 6328 | EXPECT_THAT(callback2.WaitForResult(), IsOk()); |
| 6329 | EXPECT_THAT(callback3.WaitForResult(), IsOk()); |
[email protected] | e1f58efa | 2012-05-15 18:23:40 | [diff] [blame] | 6330 | |
| 6331 | helper.VerifyDataConsumed(); |
krasin | 0bfeb6b | 2017-01-13 21:48:04 | [diff] [blame] | 6332 | |
| 6333 | // At this point the test is completed and we need to safely destroy |
| 6334 | // all allocated structures. Helper stores a transaction that has a |
| 6335 | // reference to a stack allocated request, which has a short lifetime, |
| 6336 | // and is accessed during the transaction destruction. We need to delete |
| 6337 | // the transaction while the request is still a valid object. |
| 6338 | helper.ResetTrans(); |
[email protected] | e1f58efa | 2012-05-15 18:23:40 | [diff] [blame] | 6339 | } |
| 6340 | |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6341 | // Test that sent data frames and received WINDOW_UPDATE frames change |
| 6342 | // the send_window_size_ correctly. |
| 6343 | |
| 6344 | // WINDOW_UPDATE is different than most other frames in that it can arrive |
| 6345 | // while the client is still sending the request body. In order to enforce |
| 6346 | // this scenario, we feed a couple of dummy frames and give a delay of 0 to |
| 6347 | // socket data provider, so that initial read that is done as soon as the |
| 6348 | // stream is created, succeeds and schedules another read. This way reads |
| 6349 | // and writes are interleaved; after doing a full frame write, SpdyStream |
| 6350 | // will break out of DoLoop and will read and process a WINDOW_UPDATE. |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 6351 | // Once our WINDOW_UPDATE is read, we cannot send HEADERS right away |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6352 | // since request has not been completely written, therefore we feed |
| 6353 | // enough number of WINDOW_UPDATEs to finish the first read and cause a |
| 6354 | // write, leading to a complete write of request body; after that we send |
| 6355 | // a reply with a body, to cause a graceful shutdown. |
| 6356 | |
| 6357 | // TODO(agayev): develop a socket data provider where both, reads and |
| 6358 | // writes are ordered so that writing tests like these are easy and rewrite |
| 6359 | // all these tests using it. Right now we are working around the |
| 6360 | // limitations as described above and it's not deterministic, tests may |
| 6361 | // fail under specific circumstances. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 6362 | TEST_F(SpdyNetworkTransactionTest, WindowUpdateReceived) { |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6363 | static int kFrameCount = 2; |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 6364 | std::string content(kMaxSpdyFrameChunkSize, 'a'); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6365 | spdy::SpdySerializedFrame req(spdy_util_.ConstructSpdyPost( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 6366 | kDefaultUrl, 1, kMaxSpdyFrameChunkSize * kFrameCount, LOWEST, nullptr, |
| 6367 | 0)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6368 | spdy::SpdySerializedFrame body( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 6369 | spdy_util_.ConstructSpdyDataFrame(1, content, false)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6370 | spdy::SpdySerializedFrame body_end( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 6371 | spdy_util_.ConstructSpdyDataFrame(1, content, true)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6372 | |
| 6373 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 6374 | CreateMockWrite(req, 0), CreateMockWrite(body, 1), |
| 6375 | CreateMockWrite(body_end, 2), |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6376 | }; |
| 6377 | |
Avi Drissman | 13fc893 | 2015-12-20 04:40:46 | [diff] [blame] | 6378 | static const int32_t kDeltaWindowSize = 0xff; |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6379 | static const int kDeltaCount = 4; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6380 | spdy::SpdySerializedFrame window_update( |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6381 | spdy_util_.ConstructSpdyWindowUpdate(1, kDeltaWindowSize)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6382 | spdy::SpdySerializedFrame window_update_dummy( |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6383 | spdy_util_.ConstructSpdyWindowUpdate(2, kDeltaWindowSize)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6384 | spdy::SpdySerializedFrame resp(spdy_util_.ConstructSpdyPostReply(nullptr, 0)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6385 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 6386 | CreateMockRead(window_update_dummy, 3), |
| 6387 | CreateMockRead(window_update_dummy, 4), |
| 6388 | CreateMockRead(window_update_dummy, 5), |
| 6389 | CreateMockRead(window_update, 6), // Four updates, therefore window |
| 6390 | CreateMockRead(window_update, 7), // size should increase by |
| 6391 | CreateMockRead(window_update, 8), // kDeltaWindowSize * 4 |
| 6392 | CreateMockRead(window_update, 9), |
| 6393 | CreateMockRead(resp, 10), |
| 6394 | MockRead(ASYNC, ERR_IO_PENDING, 11), |
| 6395 | CreateMockRead(body_end, 12), |
mmenke | 666a6fea | 2015-12-19 04:16:33 | [diff] [blame] | 6396 | MockRead(ASYNC, 0, 13) // EOF |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6397 | }; |
| 6398 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 6399 | SequencedSocketData data(reads, writes); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6400 | |
danakj | aee3e1ec | 2016-04-16 00:23:18 | [diff] [blame] | 6401 | std::vector<std::unique_ptr<UploadElementReader>> element_readers; |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6402 | for (int i = 0; i < kFrameCount; ++i) { |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 6403 | element_readers.push_back(std::make_unique<UploadBytesElementReader>( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 6404 | content.data(), content.size())); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6405 | } |
olli.raula | 6df48b2a | 2015-11-26 07:40:22 | [diff] [blame] | 6406 | ElementsUploadDataStream upload_data_stream(std::move(element_readers), 0); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6407 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 6408 | // Setup the request. |
| 6409 | request_.method = "POST"; |
| 6410 | request_.upload_data_stream = &upload_data_stream; |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6411 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 6412 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
mmenke | 666a6fea | 2015-12-19 04:16:33 | [diff] [blame] | 6413 | helper.AddData(&data); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6414 | helper.RunPreTestSetup(); |
| 6415 | |
| 6416 | HttpNetworkTransaction* trans = helper.trans(); |
| 6417 | |
| 6418 | TestCompletionCallback callback; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 6419 | int rv = trans->Start(&request_, callback.callback(), log_); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6420 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 6421 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6422 | |
mmenke | 666a6fea | 2015-12-19 04:16:33 | [diff] [blame] | 6423 | data.RunUntilPaused(); |
| 6424 | base::RunLoop().RunUntilIdle(); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6425 | |
| 6426 | SpdyHttpStream* stream = static_cast<SpdyHttpStream*>(trans->stream_.get()); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 6427 | ASSERT_TRUE(stream); |
| 6428 | ASSERT_TRUE(stream->stream()); |
bnc | bca843ba | 2016-07-14 13:05:48 | [diff] [blame] | 6429 | EXPECT_EQ(static_cast<int>(kDefaultInitialWindowSize) + |
| 6430 | kDeltaWindowSize * kDeltaCount - |
| 6431 | kMaxSpdyFrameChunkSize * kFrameCount, |
| 6432 | stream->stream()->send_window_size()); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6433 | |
mmenke | 666a6fea | 2015-12-19 04:16:33 | [diff] [blame] | 6434 | data.Resume(); |
| 6435 | base::RunLoop().RunUntilIdle(); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6436 | |
| 6437 | rv = callback.WaitForResult(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 6438 | EXPECT_THAT(rv, IsOk()); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6439 | |
| 6440 | helper.VerifyDataConsumed(); |
| 6441 | } |
| 6442 | |
| 6443 | // Test that received data frames and sent WINDOW_UPDATE frames change |
| 6444 | // the recv_window_size_ correctly. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 6445 | TEST_F(SpdyNetworkTransactionTest, WindowUpdateSent) { |
bnc | 8f0f3b6 | 2015-04-08 04:37:23 | [diff] [blame] | 6446 | // Session level maximum window size that is more than twice the default |
| 6447 | // initial window size so that an initial window update is sent. |
Avi Drissman | 13fc893 | 2015-12-20 04:40:46 | [diff] [blame] | 6448 | const int32_t session_max_recv_window_size = 5 * 64 * 1024; |
bnc | bca843ba | 2016-07-14 13:05:48 | [diff] [blame] | 6449 | ASSERT_LT(2 * kDefaultInitialWindowSize, session_max_recv_window_size); |
bnc | 8f0f3b6 | 2015-04-08 04:37:23 | [diff] [blame] | 6450 | // Stream level maximum window size that is less than the session level |
| 6451 | // maximum window size so that we test for confusion between the two. |
Avi Drissman | 13fc893 | 2015-12-20 04:40:46 | [diff] [blame] | 6452 | const int32_t stream_max_recv_window_size = 4 * 64 * 1024; |
bnc | 8f0f3b6 | 2015-04-08 04:37:23 | [diff] [blame] | 6453 | ASSERT_GT(session_max_recv_window_size, stream_max_recv_window_size); |
| 6454 | // Size of body to be sent. Has to be less than or equal to both window sizes |
| 6455 | // so that we do not run out of receiving window. Also has to be greater than |
| 6456 | // half of them so that it triggers both a session level and a stream level |
| 6457 | // window update frame. |
Avi Drissman | 13fc893 | 2015-12-20 04:40:46 | [diff] [blame] | 6458 | const int32_t kTargetSize = 3 * 64 * 1024; |
bnc | 8f0f3b6 | 2015-04-08 04:37:23 | [diff] [blame] | 6459 | ASSERT_GE(session_max_recv_window_size, kTargetSize); |
| 6460 | ASSERT_GE(stream_max_recv_window_size, kTargetSize); |
| 6461 | ASSERT_LT(session_max_recv_window_size / 2, kTargetSize); |
| 6462 | ASSERT_LT(stream_max_recv_window_size / 2, kTargetSize); |
| 6463 | // Size of each DATA frame. |
Avi Drissman | 13fc893 | 2015-12-20 04:40:46 | [diff] [blame] | 6464 | const int32_t kChunkSize = 4096; |
bnc | 8f0f3b6 | 2015-04-08 04:37:23 | [diff] [blame] | 6465 | // Size of window updates. |
| 6466 | ASSERT_EQ(0, session_max_recv_window_size / 2 % kChunkSize); |
Avi Drissman | 13fc893 | 2015-12-20 04:40:46 | [diff] [blame] | 6467 | const int32_t session_window_update_delta = |
bnc | 8f0f3b6 | 2015-04-08 04:37:23 | [diff] [blame] | 6468 | session_max_recv_window_size / 2 + kChunkSize; |
| 6469 | ASSERT_EQ(0, stream_max_recv_window_size / 2 % kChunkSize); |
Avi Drissman | 13fc893 | 2015-12-20 04:40:46 | [diff] [blame] | 6470 | const int32_t stream_window_update_delta = |
bnc | 8f0f3b6 | 2015-04-08 04:37:23 | [diff] [blame] | 6471 | stream_max_recv_window_size / 2 + kChunkSize; |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6472 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6473 | spdy::SpdySerializedFrame preface( |
| 6474 | const_cast<char*>(spdy::kHttp2ConnectionHeaderPrefix), |
| 6475 | spdy::kHttp2ConnectionHeaderPrefixSize, |
| 6476 | /* owns_buffer = */ false); |
bnc | 8abf64af | 2017-06-07 20:18:54 | [diff] [blame] | 6477 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6478 | spdy::SettingsMap initial_settings; |
| 6479 | initial_settings[spdy::SETTINGS_HEADER_TABLE_SIZE] = kSpdyMaxHeaderTableSize; |
| 6480 | initial_settings[spdy::SETTINGS_MAX_CONCURRENT_STREAMS] = |
bnc | 3171a243 | 2016-12-28 18:40:26 | [diff] [blame] | 6481 | kSpdyMaxConcurrentPushedStreams; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6482 | initial_settings[spdy::SETTINGS_INITIAL_WINDOW_SIZE] = |
| 6483 | stream_max_recv_window_size; |
| 6484 | spdy::SpdySerializedFrame initial_settings_frame( |
bnc | 8f0f3b6 | 2015-04-08 04:37:23 | [diff] [blame] | 6485 | spdy_util_.ConstructSpdySettings(initial_settings)); |
bnc | 8abf64af | 2017-06-07 20:18:54 | [diff] [blame] | 6486 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6487 | spdy::SpdySerializedFrame initial_window_update( |
bnc | 8f0f3b6 | 2015-04-08 04:37:23 | [diff] [blame] | 6488 | spdy_util_.ConstructSpdyWindowUpdate( |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6489 | spdy::kSessionFlowControlStreamId, |
bnc | bca843ba | 2016-07-14 13:05:48 | [diff] [blame] | 6490 | session_max_recv_window_size - kDefaultInitialWindowSize)); |
bnc | 8abf64af | 2017-06-07 20:18:54 | [diff] [blame] | 6491 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6492 | spdy::SpdySerializedFrame combined_frames = CombineFrames( |
bnc | ef26b60 | 2017-06-12 22:08:19 | [diff] [blame] | 6493 | {&preface, &initial_settings_frame, &initial_window_update}); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6494 | |
| 6495 | std::vector<MockWrite> writes; |
bnc | ef26b60 | 2017-06-12 22:08:19 | [diff] [blame] | 6496 | writes.push_back(CreateMockWrite(combined_frames)); |
bnc | 8abf64af | 2017-06-07 20:18:54 | [diff] [blame] | 6497 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6498 | spdy::SpdySerializedFrame req( |
| 6499 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 6500 | writes.push_back(CreateMockWrite(req, writes.size())); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6501 | |
[email protected] | 251029e | 2014-03-19 06:04:40 | [diff] [blame] | 6502 | std::vector<MockRead> reads; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6503 | spdy::SpdySerializedFrame resp( |
| 6504 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 6505 | reads.push_back(CreateMockRead(resp, writes.size() + reads.size())); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6506 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6507 | std::vector<spdy::SpdySerializedFrame> body_frames; |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 6508 | const std::string body_data(kChunkSize, 'x'); |
[email protected] | 251029e | 2014-03-19 06:04:40 | [diff] [blame] | 6509 | for (size_t remaining = kTargetSize; remaining != 0;) { |
| 6510 | size_t frame_size = std::min(remaining, body_data.size()); |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 6511 | body_frames.push_back(spdy_util_.ConstructSpdyDataFrame( |
| 6512 | 1, base::StringPiece(body_data.data(), frame_size), false)); |
rch | acdcbdc | 2015-05-16 17:16:00 | [diff] [blame] | 6513 | reads.push_back( |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 6514 | CreateMockRead(body_frames.back(), writes.size() + reads.size())); |
[email protected] | 251029e | 2014-03-19 06:04:40 | [diff] [blame] | 6515 | remaining -= frame_size; |
| 6516 | } |
mmenke | e2401192 | 2015-12-17 22:12:59 | [diff] [blame] | 6517 | // Yield. |
rch | acdcbdc | 2015-05-16 17:16:00 | [diff] [blame] | 6518 | reads.push_back( |
mmenke | e2401192 | 2015-12-17 22:12:59 | [diff] [blame] | 6519 | MockRead(SYNCHRONOUS, ERR_IO_PENDING, writes.size() + reads.size())); |
[email protected] | 251029e | 2014-03-19 06:04:40 | [diff] [blame] | 6520 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6521 | spdy::SpdySerializedFrame session_window_update( |
bnc | 8abf64af | 2017-06-07 20:18:54 | [diff] [blame] | 6522 | spdy_util_.ConstructSpdyWindowUpdate(0, session_window_update_delta)); |
rch | acdcbdc | 2015-05-16 17:16:00 | [diff] [blame] | 6523 | writes.push_back( |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 6524 | CreateMockWrite(session_window_update, writes.size() + reads.size())); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6525 | spdy::SpdySerializedFrame stream_window_update( |
bnc | 8abf64af | 2017-06-07 20:18:54 | [diff] [blame] | 6526 | spdy_util_.ConstructSpdyWindowUpdate(1, stream_window_update_delta)); |
rch | acdcbdc | 2015-05-16 17:16:00 | [diff] [blame] | 6527 | writes.push_back( |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 6528 | CreateMockWrite(stream_window_update, writes.size() + reads.size())); |
rch | acdcbdc | 2015-05-16 17:16:00 | [diff] [blame] | 6529 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 6530 | SequencedSocketData data(reads, writes); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6531 | |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 6532 | auto session_deps = std::make_unique<SpdySessionDependencies>(); |
bnc | 903e8c1 | 2016-12-09 20:50:05 | [diff] [blame] | 6533 | session_deps->session_max_recv_window_size = session_max_recv_window_size; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6534 | session_deps->http2_settings[spdy::SETTINGS_INITIAL_WINDOW_SIZE] = |
bnc | 3171a243 | 2016-12-28 18:40:26 | [diff] [blame] | 6535 | stream_max_recv_window_size; |
bnc | 903e8c1 | 2016-12-09 20:50:05 | [diff] [blame] | 6536 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 6537 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
bnc | 903e8c1 | 2016-12-09 20:50:05 | [diff] [blame] | 6538 | std::move(session_deps)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6539 | helper.AddData(&data); |
| 6540 | helper.RunPreTestSetup(); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6541 | |
bnc | 8f0f3b6 | 2015-04-08 04:37:23 | [diff] [blame] | 6542 | SpdySessionPool* spdy_session_pool = helper.session()->spdy_session_pool(); |
| 6543 | SpdySessionPoolPeer pool_peer(spdy_session_pool); |
| 6544 | pool_peer.SetEnableSendingInitialData(true); |
bnc | 8f0f3b6 | 2015-04-08 04:37:23 | [diff] [blame] | 6545 | |
| 6546 | HttpNetworkTransaction* trans = helper.trans(); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6547 | TestCompletionCallback callback; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 6548 | int rv = trans->Start(&request_, callback.callback(), log_); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6549 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 6550 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6551 | rv = callback.WaitForResult(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 6552 | EXPECT_THAT(rv, IsOk()); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6553 | |
bnc | eb9aa711 | 2017-01-05 01:03:46 | [diff] [blame] | 6554 | // Finish async network reads. |
| 6555 | base::RunLoop().RunUntilIdle(); |
| 6556 | |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6557 | SpdyHttpStream* stream = |
| 6558 | static_cast<SpdyHttpStream*>(trans->stream_.get()); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 6559 | ASSERT_TRUE(stream); |
| 6560 | ASSERT_TRUE(stream->stream()); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6561 | |
[email protected] | 251029e | 2014-03-19 06:04:40 | [diff] [blame] | 6562 | // All data has been read, but not consumed. The window reflects this. |
bnc | 8f0f3b6 | 2015-04-08 04:37:23 | [diff] [blame] | 6563 | EXPECT_EQ(static_cast<int>(stream_max_recv_window_size - kTargetSize), |
[email protected] | 251029e | 2014-03-19 06:04:40 | [diff] [blame] | 6564 | stream->stream()->recv_window_size()); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6565 | |
| 6566 | const HttpResponseInfo* response = trans->GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 6567 | ASSERT_TRUE(response); |
| 6568 | ASSERT_TRUE(response->headers); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 6569 | EXPECT_EQ("HTTP/1.1 200", response->headers->GetStatusLine()); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6570 | EXPECT_TRUE(response->was_fetched_via_spdy); |
| 6571 | |
| 6572 | // Issue a read which will cause a WINDOW_UPDATE to be sent and window |
| 6573 | // size increased to default. |
Victor Costan | 9c7302b | 2018-08-27 16:39:44 | [diff] [blame] | 6574 | scoped_refptr<IOBuffer> buf = base::MakeRefCounted<IOBuffer>(kTargetSize); |
[email protected] | 251029e | 2014-03-19 06:04:40 | [diff] [blame] | 6575 | EXPECT_EQ(static_cast<int>(kTargetSize), |
Bence Béky | bdbb0e7 | 2018-08-07 21:42:59 | [diff] [blame] | 6576 | trans->Read(buf.get(), kTargetSize, CompletionOnceCallback())); |
bnc | 8f0f3b6 | 2015-04-08 04:37:23 | [diff] [blame] | 6577 | EXPECT_EQ(static_cast<int>(stream_max_recv_window_size), |
[email protected] | 251029e | 2014-03-19 06:04:40 | [diff] [blame] | 6578 | stream->stream()->recv_window_size()); |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 6579 | EXPECT_THAT(base::StringPiece(buf->data(), kTargetSize), Each(Eq('x'))); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6580 | |
[email protected] | 251029e | 2014-03-19 06:04:40 | [diff] [blame] | 6581 | // Allow scheduled WINDOW_UPDATE frames to write. |
[email protected] | fc9d8847 | 2013-08-14 02:31:17 | [diff] [blame] | 6582 | base::RunLoop().RunUntilIdle(); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6583 | helper.VerifyDataConsumed(); |
| 6584 | } |
| 6585 | |
| 6586 | // Test that WINDOW_UPDATE frame causing overflow is handled correctly. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 6587 | TEST_F(SpdyNetworkTransactionTest, WindowUpdateOverflow) { |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6588 | // Number of full frames we hope to write (but will not, used to |
| 6589 | // set content-length header correctly) |
| 6590 | static int kFrameCount = 3; |
| 6591 | |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 6592 | std::string content(kMaxSpdyFrameChunkSize, 'a'); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6593 | spdy::SpdySerializedFrame req(spdy_util_.ConstructSpdyPost( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 6594 | kDefaultUrl, 1, kMaxSpdyFrameChunkSize * kFrameCount, LOWEST, nullptr, |
| 6595 | 0)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6596 | spdy::SpdySerializedFrame body( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 6597 | spdy_util_.ConstructSpdyDataFrame(1, content, false)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6598 | spdy::SpdySerializedFrame rst(spdy_util_.ConstructSpdyRstStream( |
| 6599 | 1, spdy::ERROR_CODE_FLOW_CONTROL_ERROR)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6600 | |
| 6601 | // We're not going to write a data frame with FIN, we'll receive a bad |
| 6602 | // WINDOW_UPDATE while sending a request and will send a RST_STREAM frame. |
| 6603 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 6604 | CreateMockWrite(req, 0), CreateMockWrite(body, 2), |
| 6605 | CreateMockWrite(rst, 3), |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6606 | }; |
| 6607 | |
Avi Drissman | 13fc893 | 2015-12-20 04:40:46 | [diff] [blame] | 6608 | static const int32_t kDeltaWindowSize = 0x7fffffff; // cause an overflow |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6609 | spdy::SpdySerializedFrame window_update( |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6610 | spdy_util_.ConstructSpdyWindowUpdate(1, kDeltaWindowSize)); |
| 6611 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 6612 | CreateMockRead(window_update, 1), MockRead(ASYNC, 0, 4) // EOF |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6613 | }; |
| 6614 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 6615 | SequencedSocketData data(reads, writes); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6616 | |
danakj | aee3e1ec | 2016-04-16 00:23:18 | [diff] [blame] | 6617 | std::vector<std::unique_ptr<UploadElementReader>> element_readers; |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6618 | for (int i = 0; i < kFrameCount; ++i) { |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 6619 | element_readers.push_back(std::make_unique<UploadBytesElementReader>( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 6620 | content.data(), content.size())); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6621 | } |
olli.raula | 6df48b2a | 2015-11-26 07:40:22 | [diff] [blame] | 6622 | ElementsUploadDataStream upload_data_stream(std::move(element_readers), 0); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6623 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 6624 | // Setup the request. |
| 6625 | request_.method = "POST"; |
| 6626 | request_.upload_data_stream = &upload_data_stream; |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6627 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 6628 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6629 | helper.RunPreTestSetup(); |
mmenke | 666a6fea | 2015-12-19 04:16:33 | [diff] [blame] | 6630 | helper.AddData(&data); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6631 | HttpNetworkTransaction* trans = helper.trans(); |
| 6632 | |
| 6633 | TestCompletionCallback callback; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 6634 | int rv = trans->Start(&request_, callback.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 6635 | ASSERT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6636 | |
mmenke | 666a6fea | 2015-12-19 04:16:33 | [diff] [blame] | 6637 | base::RunLoop().RunUntilIdle(); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6638 | ASSERT_TRUE(callback.have_result()); |
Bence Béky | 6b9c135 | 2018-05-10 11:51:25 | [diff] [blame] | 6639 | EXPECT_THAT(callback.WaitForResult(), IsError(ERR_SPDY_FLOW_CONTROL_ERROR)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6640 | helper.VerifyDataConsumed(); |
| 6641 | } |
| 6642 | |
Bence Béky | 05dcb038 | 2017-09-15 20:07:58 | [diff] [blame] | 6643 | // Regression test for https://crbug.com/732019. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6644 | // RFC7540 Section 6.9.2: A spdy::SETTINGS_INITIAL_WINDOW_SIZE change that |
| 6645 | // causes any stream flow control window to overflow MUST be treated as a |
| 6646 | // connection error. |
Bence Béky | 05dcb038 | 2017-09-15 20:07:58 | [diff] [blame] | 6647 | TEST_F(SpdyNetworkTransactionTest, InitialWindowSizeOverflow) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6648 | spdy::SpdySerializedFrame window_update( |
Bence Béky | 05dcb038 | 2017-09-15 20:07:58 | [diff] [blame] | 6649 | spdy_util_.ConstructSpdyWindowUpdate(1, 0x60000000)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6650 | spdy::SettingsMap settings; |
| 6651 | settings[spdy::SETTINGS_INITIAL_WINDOW_SIZE] = 0x60000000; |
| 6652 | spdy::SpdySerializedFrame settings_frame( |
Bence Béky | 05dcb038 | 2017-09-15 20:07:58 | [diff] [blame] | 6653 | spdy_util_.ConstructSpdySettings(settings)); |
| 6654 | MockRead reads[] = {CreateMockRead(window_update, 1), |
| 6655 | CreateMockRead(settings_frame, 2)}; |
| 6656 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6657 | spdy::SpdySerializedFrame req( |
| 6658 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 6659 | spdy::SpdySerializedFrame settings_ack(spdy_util_.ConstructSpdySettingsAck()); |
| 6660 | spdy::SpdySerializedFrame goaway( |
| 6661 | spdy_util_.ConstructSpdyGoAway(0, spdy::ERROR_CODE_FLOW_CONTROL_ERROR, |
| 6662 | "New spdy::SETTINGS_INITIAL_WINDOW_SIZE " |
| 6663 | "value overflows flow control window of " |
| 6664 | "stream 1.")); |
Bence Béky | 05dcb038 | 2017-09-15 20:07:58 | [diff] [blame] | 6665 | MockWrite writes[] = {CreateMockWrite(req, 0), |
| 6666 | CreateMockWrite(settings_ack, 3), |
| 6667 | CreateMockWrite(goaway, 4)}; |
| 6668 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 6669 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 6670 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
Bence Béky | 05dcb038 | 2017-09-15 20:07:58 | [diff] [blame] | 6671 | helper.RunToCompletion(&data); |
| 6672 | TransactionHelperResult out = helper.output(); |
| 6673 | EXPECT_THAT(out.rv, IsError(ERR_SPDY_FLOW_CONTROL_ERROR)); |
| 6674 | } |
| 6675 | |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6676 | // Test that after hitting a send window size of 0, the write process |
| 6677 | // stalls and upon receiving WINDOW_UPDATE frame write resumes. |
| 6678 | |
| 6679 | // This test constructs a POST request followed by enough data frames |
| 6680 | // containing 'a' that would make the window size 0, followed by another |
| 6681 | // data frame containing default content (which is "hello!") and this frame |
rch | acdcbdc | 2015-05-16 17:16:00 | [diff] [blame] | 6682 | // also contains a FIN flag. SequencedSocketData is used to enforce all |
| 6683 | // writes, save the last, go through before a read could happen. The last frame |
| 6684 | // ("hello!") is not permitted to go through since by the time its turn |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6685 | // arrives, window size is 0. At this point MessageLoop::Run() called via |
| 6686 | // callback would block. Therefore we call MessageLoop::RunUntilIdle() |
| 6687 | // which returns after performing all possible writes. We use DCHECKS to |
| 6688 | // ensure that last data frame is still there and stream has stalled. |
| 6689 | // After that, next read is artifically enforced, which causes a |
| 6690 | // WINDOW_UPDATE to be read and I/O process resumes. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 6691 | TEST_F(SpdyNetworkTransactionTest, FlowControlStallResume) { |
bnc | bca843ba | 2016-07-14 13:05:48 | [diff] [blame] | 6692 | const int32_t initial_window_size = kDefaultInitialWindowSize; |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 6693 | // Number of upload data buffers we need to send to zero out the window size |
| 6694 | // is the minimal number of upload buffers takes to be bigger than |
| 6695 | // |initial_window_size|. |
| 6696 | size_t num_upload_buffers = |
| 6697 | ceil(static_cast<double>(initial_window_size) / kBufferSize); |
| 6698 | // Each upload data buffer consists of |num_frames_in_one_upload_buffer| |
| 6699 | // frames, each with |kMaxSpdyFrameChunkSize| bytes except the last frame, |
| 6700 | // which has kBufferSize % kMaxSpdyChunkSize bytes. |
| 6701 | size_t num_frames_in_one_upload_buffer = |
| 6702 | ceil(static_cast<double>(kBufferSize) / kMaxSpdyFrameChunkSize); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6703 | |
| 6704 | // Construct content for a data frame of maximum size. |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 6705 | std::string content(kMaxSpdyFrameChunkSize, 'a'); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6706 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6707 | spdy::SpdySerializedFrame req(spdy_util_.ConstructSpdyPost( |
bnc | b2602438 | 2016-06-29 02:39:45 | [diff] [blame] | 6708 | kDefaultUrl, 1, |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 6709 | /*content_length=*/kBufferSize * num_upload_buffers + kUploadDataSize, |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 6710 | LOWEST, nullptr, 0)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6711 | |
| 6712 | // Full frames. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6713 | spdy::SpdySerializedFrame body1( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 6714 | spdy_util_.ConstructSpdyDataFrame(1, content, false)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6715 | |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 6716 | // Last frame in each upload data buffer. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6717 | spdy::SpdySerializedFrame body2(spdy_util_.ConstructSpdyDataFrame( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 6718 | 1, |
| 6719 | base::StringPiece(content.data(), kBufferSize % kMaxSpdyFrameChunkSize), |
| 6720 | false)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6721 | |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 6722 | // The very last frame before the stalled frames. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6723 | spdy::SpdySerializedFrame body3(spdy_util_.ConstructSpdyDataFrame( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 6724 | 1, |
| 6725 | base::StringPiece(content.data(), initial_window_size % kBufferSize % |
| 6726 | kMaxSpdyFrameChunkSize), |
| 6727 | false)); |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 6728 | |
| 6729 | // Data frames to be sent once WINDOW_UPDATE frame is received. |
| 6730 | |
| 6731 | // If kBufferSize * num_upload_buffers > initial_window_size, |
| 6732 | // we need one additional frame to send the rest of 'a'. |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 6733 | std::string last_body(kBufferSize * num_upload_buffers - initial_window_size, |
| 6734 | 'a'); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6735 | spdy::SpdySerializedFrame body4( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 6736 | spdy_util_.ConstructSpdyDataFrame(1, last_body, false)); |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 6737 | |
| 6738 | // Also send a "hello!" after WINDOW_UPDATE. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6739 | spdy::SpdySerializedFrame body5(spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6740 | |
| 6741 | // Fill in mock writes. |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6742 | size_t i = 0; |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 6743 | std::vector<MockWrite> writes; |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 6744 | writes.push_back(CreateMockWrite(req, i++)); |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 6745 | for (size_t j = 0; j < num_upload_buffers; j++) { |
| 6746 | for (size_t k = 0; k < num_frames_in_one_upload_buffer; k++) { |
| 6747 | if (k == num_frames_in_one_upload_buffer - 1 && |
| 6748 | kBufferSize % kMaxSpdyFrameChunkSize != 0) { |
| 6749 | if (j == num_upload_buffers - 1 && |
| 6750 | (initial_window_size % kBufferSize != 0)) { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 6751 | writes.push_back(CreateMockWrite(body3, i++)); |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 6752 | } else { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 6753 | writes.push_back(CreateMockWrite(body2, i++)); |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 6754 | } |
| 6755 | } else { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 6756 | writes.push_back(CreateMockWrite(body1, i++)); |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 6757 | } |
| 6758 | } |
| 6759 | } |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6760 | |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 6761 | // Fill in mock reads. |
| 6762 | std::vector<MockRead> reads; |
| 6763 | // Force a pause. |
| 6764 | reads.push_back(MockRead(ASYNC, ERR_IO_PENDING, i++)); |
| 6765 | // Construct read frame for window updates that gives enough space to upload |
| 6766 | // the rest of the data. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6767 | spdy::SpdySerializedFrame session_window_update( |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 6768 | spdy_util_.ConstructSpdyWindowUpdate(0, |
| 6769 | kUploadDataSize + last_body.size())); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6770 | spdy::SpdySerializedFrame window_update(spdy_util_.ConstructSpdyWindowUpdate( |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 6771 | 1, kUploadDataSize + last_body.size())); |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 6772 | |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 6773 | reads.push_back(CreateMockRead(session_window_update, i++)); |
| 6774 | reads.push_back(CreateMockRead(window_update, i++)); |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 6775 | |
| 6776 | // Stalled frames which can be sent after receiving window updates. |
| 6777 | if (last_body.size() > 0) |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 6778 | writes.push_back(CreateMockWrite(body4, i++)); |
| 6779 | writes.push_back(CreateMockWrite(body5, i++)); |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 6780 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6781 | spdy::SpdySerializedFrame reply( |
| 6782 | spdy_util_.ConstructSpdyPostReply(nullptr, 0)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 6783 | reads.push_back(CreateMockRead(reply, i++)); |
| 6784 | reads.push_back(CreateMockRead(body2, i++)); |
| 6785 | reads.push_back(CreateMockRead(body5, i++)); |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 6786 | reads.push_back(MockRead(ASYNC, 0, i++)); // EOF |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6787 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 6788 | SequencedSocketData data(reads, writes); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6789 | |
danakj | aee3e1ec | 2016-04-16 00:23:18 | [diff] [blame] | 6790 | std::vector<std::unique_ptr<UploadElementReader>> element_readers; |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 6791 | std::string upload_data_string(kBufferSize * num_upload_buffers, 'a'); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6792 | upload_data_string.append(kUploadData, kUploadDataSize); |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 6793 | element_readers.push_back(std::make_unique<UploadBytesElementReader>( |
bnc | 3f6a855 | 2017-05-17 13:40:34 | [diff] [blame] | 6794 | upload_data_string.c_str(), upload_data_string.size())); |
olli.raula | 6df48b2a | 2015-11-26 07:40:22 | [diff] [blame] | 6795 | ElementsUploadDataStream upload_data_stream(std::move(element_readers), 0); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6796 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 6797 | request_.method = "POST"; |
| 6798 | request_.upload_data_stream = &upload_data_stream; |
| 6799 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
| 6800 | |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6801 | helper.AddData(&data); |
| 6802 | helper.RunPreTestSetup(); |
| 6803 | |
| 6804 | HttpNetworkTransaction* trans = helper.trans(); |
| 6805 | |
| 6806 | TestCompletionCallback callback; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 6807 | int rv = trans->Start(&request_, callback.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 6808 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6809 | |
[email protected] | fc9d8847 | 2013-08-14 02:31:17 | [diff] [blame] | 6810 | base::RunLoop().RunUntilIdle(); // Write as much as we can. |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6811 | |
| 6812 | SpdyHttpStream* stream = static_cast<SpdyHttpStream*>(trans->stream_.get()); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 6813 | ASSERT_TRUE(stream); |
| 6814 | ASSERT_TRUE(stream->stream()); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6815 | EXPECT_EQ(0, stream->stream()->send_window_size()); |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 6816 | if (initial_window_size % kBufferSize != 0) { |
| 6817 | // If it does not take whole number of full upload buffer to zero out |
| 6818 | // initial window size, then the upload data is not at EOF, because the |
| 6819 | // last read must be stalled. |
| 6820 | EXPECT_FALSE(upload_data_stream.IsEOF()); |
| 6821 | } else { |
| 6822 | // All the body data should have been read. |
| 6823 | // TODO(satorux): This is because of the weirdness in reading the request |
| 6824 | // body in OnSendBodyComplete(). See crbug.com/113107. |
| 6825 | EXPECT_TRUE(upload_data_stream.IsEOF()); |
| 6826 | } |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6827 | // But the body is not yet fully sent (kUploadData is not yet sent) |
| 6828 | // since we're send-stalled. |
| 6829 | EXPECT_TRUE(stream->stream()->send_stalled_by_flow_control()); |
| 6830 | |
mmenke | e2401192 | 2015-12-17 22:12:59 | [diff] [blame] | 6831 | data.Resume(); // Read in WINDOW_UPDATE frame. |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6832 | rv = callback.WaitForResult(); |
bnc | eb9aa711 | 2017-01-05 01:03:46 | [diff] [blame] | 6833 | EXPECT_THAT(rv, IsOk()); |
| 6834 | |
| 6835 | // Finish async network reads. |
| 6836 | base::RunLoop().RunUntilIdle(); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6837 | helper.VerifyDataConsumed(); |
| 6838 | } |
| 6839 | |
| 6840 | // Test we correctly handle the case where the SETTINGS frame results in |
| 6841 | // unstalling the send window. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 6842 | TEST_F(SpdyNetworkTransactionTest, FlowControlStallResumeAfterSettings) { |
bnc | bca843ba | 2016-07-14 13:05:48 | [diff] [blame] | 6843 | const int32_t initial_window_size = kDefaultInitialWindowSize; |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 6844 | // Number of upload data buffers we need to send to zero out the window size |
| 6845 | // is the minimal number of upload buffers takes to be bigger than |
| 6846 | // |initial_window_size|. |
| 6847 | size_t num_upload_buffers = |
| 6848 | ceil(static_cast<double>(initial_window_size) / kBufferSize); |
| 6849 | // Each upload data buffer consists of |num_frames_in_one_upload_buffer| |
| 6850 | // frames, each with |kMaxSpdyFrameChunkSize| bytes except the last frame, |
| 6851 | // which has kBufferSize % kMaxSpdyChunkSize bytes. |
| 6852 | size_t num_frames_in_one_upload_buffer = |
| 6853 | ceil(static_cast<double>(kBufferSize) / kMaxSpdyFrameChunkSize); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6854 | |
| 6855 | // Construct content for a data frame of maximum size. |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 6856 | std::string content(kMaxSpdyFrameChunkSize, 'a'); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6857 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6858 | spdy::SpdySerializedFrame req(spdy_util_.ConstructSpdyPost( |
bnc | b2602438 | 2016-06-29 02:39:45 | [diff] [blame] | 6859 | kDefaultUrl, 1, |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 6860 | /*content_length=*/kBufferSize * num_upload_buffers + kUploadDataSize, |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 6861 | LOWEST, nullptr, 0)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6862 | |
| 6863 | // Full frames. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6864 | spdy::SpdySerializedFrame body1( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 6865 | spdy_util_.ConstructSpdyDataFrame(1, content, false)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6866 | |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 6867 | // Last frame in each upload data buffer. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6868 | spdy::SpdySerializedFrame body2(spdy_util_.ConstructSpdyDataFrame( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 6869 | 1, |
| 6870 | base::StringPiece(content.data(), kBufferSize % kMaxSpdyFrameChunkSize), |
| 6871 | false)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6872 | |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 6873 | // The very last frame before the stalled frames. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6874 | spdy::SpdySerializedFrame body3(spdy_util_.ConstructSpdyDataFrame( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 6875 | 1, |
| 6876 | base::StringPiece(content.data(), initial_window_size % kBufferSize % |
| 6877 | kMaxSpdyFrameChunkSize), |
| 6878 | false)); |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 6879 | |
| 6880 | // Data frames to be sent once WINDOW_UPDATE frame is received. |
| 6881 | |
| 6882 | // If kBufferSize * num_upload_buffers > initial_window_size, |
| 6883 | // we need one additional frame to send the rest of 'a'. |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 6884 | std::string last_body(kBufferSize * num_upload_buffers - initial_window_size, |
| 6885 | 'a'); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6886 | spdy::SpdySerializedFrame body4( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 6887 | spdy_util_.ConstructSpdyDataFrame(1, last_body, false)); |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 6888 | |
| 6889 | // Also send a "hello!" after WINDOW_UPDATE. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6890 | spdy::SpdySerializedFrame body5(spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6891 | |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 6892 | // Fill in mock writes. |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6893 | size_t i = 0; |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 6894 | std::vector<MockWrite> writes; |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 6895 | writes.push_back(CreateMockWrite(req, i++)); |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 6896 | for (size_t j = 0; j < num_upload_buffers; j++) { |
| 6897 | for (size_t k = 0; k < num_frames_in_one_upload_buffer; k++) { |
| 6898 | if (k == num_frames_in_one_upload_buffer - 1 && |
| 6899 | kBufferSize % kMaxSpdyFrameChunkSize != 0) { |
| 6900 | if (j == num_upload_buffers - 1 && |
| 6901 | (initial_window_size % kBufferSize != 0)) { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 6902 | writes.push_back(CreateMockWrite(body3, i++)); |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 6903 | } else { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 6904 | writes.push_back(CreateMockWrite(body2, i++)); |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 6905 | } |
| 6906 | } else { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 6907 | writes.push_back(CreateMockWrite(body1, i++)); |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 6908 | } |
| 6909 | } |
| 6910 | } |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6911 | |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 6912 | // Fill in mock reads. |
| 6913 | std::vector<MockRead> reads; |
| 6914 | // Force a pause. |
mmenke | 666a6fea | 2015-12-19 04:16:33 | [diff] [blame] | 6915 | reads.push_back(MockRead(ASYNC, ERR_IO_PENDING, i++)); |
| 6916 | |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6917 | // Construct read frame for SETTINGS that gives enough space to upload the |
| 6918 | // rest of the data. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6919 | spdy::SettingsMap settings; |
| 6920 | settings[spdy::SETTINGS_INITIAL_WINDOW_SIZE] = initial_window_size * 2; |
| 6921 | spdy::SpdySerializedFrame settings_frame_large( |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6922 | spdy_util_.ConstructSpdySettings(settings)); |
| 6923 | |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 6924 | reads.push_back(CreateMockRead(settings_frame_large, i++)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6925 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6926 | spdy::SpdySerializedFrame session_window_update( |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 6927 | spdy_util_.ConstructSpdyWindowUpdate(0, |
| 6928 | last_body.size() + kUploadDataSize)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 6929 | reads.push_back(CreateMockRead(session_window_update, i++)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6930 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6931 | spdy::SpdySerializedFrame settings_ack(spdy_util_.ConstructSpdySettingsAck()); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 6932 | writes.push_back(CreateMockWrite(settings_ack, i++)); |
[email protected] | d4a77c1 | 2014-05-15 20:45:21 | [diff] [blame] | 6933 | |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 6934 | // Stalled frames which can be sent after |settings_ack|. |
| 6935 | if (last_body.size() > 0) |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 6936 | writes.push_back(CreateMockWrite(body4, i++)); |
| 6937 | writes.push_back(CreateMockWrite(body5, i++)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6938 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6939 | spdy::SpdySerializedFrame reply( |
| 6940 | spdy_util_.ConstructSpdyPostReply(nullptr, 0)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 6941 | reads.push_back(CreateMockRead(reply, i++)); |
| 6942 | reads.push_back(CreateMockRead(body2, i++)); |
| 6943 | reads.push_back(CreateMockRead(body5, i++)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6944 | reads.push_back(MockRead(ASYNC, 0, i++)); // EOF |
| 6945 | |
| 6946 | // Force all writes to happen before any read, last write will not |
| 6947 | // actually queue a frame, due to window size being 0. |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 6948 | SequencedSocketData data(reads, writes); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6949 | |
danakj | aee3e1ec | 2016-04-16 00:23:18 | [diff] [blame] | 6950 | std::vector<std::unique_ptr<UploadElementReader>> element_readers; |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 6951 | std::string upload_data_string(kBufferSize * num_upload_buffers, 'a'); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6952 | upload_data_string.append(kUploadData, kUploadDataSize); |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 6953 | element_readers.push_back(std::make_unique<UploadBytesElementReader>( |
bnc | 3f6a855 | 2017-05-17 13:40:34 | [diff] [blame] | 6954 | upload_data_string.c_str(), upload_data_string.size())); |
olli.raula | 6df48b2a | 2015-11-26 07:40:22 | [diff] [blame] | 6955 | ElementsUploadDataStream upload_data_stream(std::move(element_readers), 0); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6956 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 6957 | request_.method = "POST"; |
| 6958 | request_.upload_data_stream = &upload_data_stream; |
| 6959 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
| 6960 | |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6961 | helper.RunPreTestSetup(); |
mmenke | 666a6fea | 2015-12-19 04:16:33 | [diff] [blame] | 6962 | helper.AddData(&data); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6963 | |
| 6964 | HttpNetworkTransaction* trans = helper.trans(); |
| 6965 | |
| 6966 | TestCompletionCallback callback; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 6967 | int rv = trans->Start(&request_, callback.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 6968 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6969 | |
mmenke | 666a6fea | 2015-12-19 04:16:33 | [diff] [blame] | 6970 | data.RunUntilPaused(); // Write as much as we can. |
| 6971 | base::RunLoop().RunUntilIdle(); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6972 | |
| 6973 | SpdyHttpStream* stream = static_cast<SpdyHttpStream*>(trans->stream_.get()); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 6974 | ASSERT_TRUE(stream); |
| 6975 | ASSERT_TRUE(stream->stream()); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6976 | EXPECT_EQ(0, stream->stream()->send_window_size()); |
| 6977 | |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 6978 | if (initial_window_size % kBufferSize != 0) { |
| 6979 | // If it does not take whole number of full upload buffer to zero out |
| 6980 | // initial window size, then the upload data is not at EOF, because the |
| 6981 | // last read must be stalled. |
| 6982 | EXPECT_FALSE(upload_data_stream.IsEOF()); |
| 6983 | } else { |
| 6984 | // All the body data should have been read. |
| 6985 | // TODO(satorux): This is because of the weirdness in reading the request |
| 6986 | // body in OnSendBodyComplete(). See crbug.com/113107. |
| 6987 | EXPECT_TRUE(upload_data_stream.IsEOF()); |
| 6988 | } |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6989 | // But the body is not yet fully sent (kUploadData is not yet sent) |
| 6990 | // since we're send-stalled. |
| 6991 | EXPECT_TRUE(stream->stream()->send_stalled_by_flow_control()); |
| 6992 | |
mmenke | 666a6fea | 2015-12-19 04:16:33 | [diff] [blame] | 6993 | // Read in SETTINGS frame to unstall. |
| 6994 | data.Resume(); |
| 6995 | base::RunLoop().RunUntilIdle(); |
| 6996 | |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 6997 | rv = callback.WaitForResult(); |
| 6998 | helper.VerifyDataConsumed(); |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 6999 | // If stream is nullptr, that means it was unstalled and closed. |
| 7000 | EXPECT_TRUE(stream->stream() == nullptr); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7001 | } |
| 7002 | |
| 7003 | // Test we correctly handle the case where the SETTINGS frame results in a |
| 7004 | // negative send window size. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 7005 | TEST_F(SpdyNetworkTransactionTest, FlowControlNegativeSendWindowSize) { |
bnc | bca843ba | 2016-07-14 13:05:48 | [diff] [blame] | 7006 | const int32_t initial_window_size = kDefaultInitialWindowSize; |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 7007 | // Number of upload data buffers we need to send to zero out the window size |
| 7008 | // is the minimal number of upload buffers takes to be bigger than |
| 7009 | // |initial_window_size|. |
| 7010 | size_t num_upload_buffers = |
| 7011 | ceil(static_cast<double>(initial_window_size) / kBufferSize); |
| 7012 | // Each upload data buffer consists of |num_frames_in_one_upload_buffer| |
| 7013 | // frames, each with |kMaxSpdyFrameChunkSize| bytes except the last frame, |
| 7014 | // which has kBufferSize % kMaxSpdyChunkSize bytes. |
| 7015 | size_t num_frames_in_one_upload_buffer = |
| 7016 | ceil(static_cast<double>(kBufferSize) / kMaxSpdyFrameChunkSize); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7017 | |
| 7018 | // Construct content for a data frame of maximum size. |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 7019 | std::string content(kMaxSpdyFrameChunkSize, 'a'); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7020 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7021 | spdy::SpdySerializedFrame req(spdy_util_.ConstructSpdyPost( |
bnc | b2602438 | 2016-06-29 02:39:45 | [diff] [blame] | 7022 | kDefaultUrl, 1, |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 7023 | /*content_length=*/kBufferSize * num_upload_buffers + kUploadDataSize, |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 7024 | LOWEST, nullptr, 0)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7025 | |
| 7026 | // Full frames. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7027 | spdy::SpdySerializedFrame body1( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 7028 | spdy_util_.ConstructSpdyDataFrame(1, content, false)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7029 | |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 7030 | // Last frame in each upload data buffer. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7031 | spdy::SpdySerializedFrame body2(spdy_util_.ConstructSpdyDataFrame( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 7032 | 1, |
| 7033 | base::StringPiece(content.data(), kBufferSize % kMaxSpdyFrameChunkSize), |
| 7034 | false)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7035 | |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 7036 | // The very last frame before the stalled frames. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7037 | spdy::SpdySerializedFrame body3(spdy_util_.ConstructSpdyDataFrame( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 7038 | 1, |
| 7039 | base::StringPiece(content.data(), initial_window_size % kBufferSize % |
| 7040 | kMaxSpdyFrameChunkSize), |
| 7041 | false)); |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 7042 | |
| 7043 | // Data frames to be sent once WINDOW_UPDATE frame is received. |
| 7044 | |
| 7045 | // If kBufferSize * num_upload_buffers > initial_window_size, |
| 7046 | // we need one additional frame to send the rest of 'a'. |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 7047 | std::string last_body(kBufferSize * num_upload_buffers - initial_window_size, |
| 7048 | 'a'); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7049 | spdy::SpdySerializedFrame body4( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 7050 | spdy_util_.ConstructSpdyDataFrame(1, last_body, false)); |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 7051 | |
| 7052 | // Also send a "hello!" after WINDOW_UPDATE. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7053 | spdy::SpdySerializedFrame body5(spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7054 | |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 7055 | // Fill in mock writes. |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7056 | size_t i = 0; |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 7057 | std::vector<MockWrite> writes; |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 7058 | writes.push_back(CreateMockWrite(req, i++)); |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 7059 | for (size_t j = 0; j < num_upload_buffers; j++) { |
| 7060 | for (size_t k = 0; k < num_frames_in_one_upload_buffer; k++) { |
| 7061 | if (k == num_frames_in_one_upload_buffer - 1 && |
| 7062 | kBufferSize % kMaxSpdyFrameChunkSize != 0) { |
| 7063 | if (j == num_upload_buffers - 1 && |
| 7064 | (initial_window_size % kBufferSize != 0)) { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 7065 | writes.push_back(CreateMockWrite(body3, i++)); |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 7066 | } else { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 7067 | writes.push_back(CreateMockWrite(body2, i++)); |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 7068 | } |
| 7069 | } else { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 7070 | writes.push_back(CreateMockWrite(body1, i++)); |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 7071 | } |
| 7072 | } |
| 7073 | } |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7074 | |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 7075 | // Fill in mock reads. |
| 7076 | std::vector<MockRead> reads; |
| 7077 | // Force a pause. |
mmenke | 666a6fea | 2015-12-19 04:16:33 | [diff] [blame] | 7078 | reads.push_back(MockRead(ASYNC, ERR_IO_PENDING, i++)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7079 | // Construct read frame for SETTINGS that makes the send_window_size |
| 7080 | // negative. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7081 | spdy::SettingsMap new_settings; |
| 7082 | new_settings[spdy::SETTINGS_INITIAL_WINDOW_SIZE] = initial_window_size / 2; |
| 7083 | spdy::SpdySerializedFrame settings_frame_small( |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7084 | spdy_util_.ConstructSpdySettings(new_settings)); |
| 7085 | // Construct read frames for WINDOW_UPDATE that makes the send_window_size |
| 7086 | // positive. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7087 | spdy::SpdySerializedFrame session_window_update_init_size( |
bnc | 2f54c83 | 2014-12-01 13:31:19 | [diff] [blame] | 7088 | spdy_util_.ConstructSpdyWindowUpdate(0, initial_window_size)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7089 | spdy::SpdySerializedFrame window_update_init_size( |
bnc | 2f54c83 | 2014-12-01 13:31:19 | [diff] [blame] | 7090 | spdy_util_.ConstructSpdyWindowUpdate(1, initial_window_size)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7091 | |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 7092 | reads.push_back(CreateMockRead(settings_frame_small, i++)); |
| 7093 | reads.push_back(CreateMockRead(session_window_update_init_size, i++)); |
| 7094 | reads.push_back(CreateMockRead(window_update_init_size, i++)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7095 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7096 | spdy::SpdySerializedFrame settings_ack(spdy_util_.ConstructSpdySettingsAck()); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 7097 | writes.push_back(CreateMockWrite(settings_ack, i++)); |
[email protected] | d4a77c1 | 2014-05-15 20:45:21 | [diff] [blame] | 7098 | |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 7099 | // Stalled frames which can be sent after |settings_ack|. |
| 7100 | if (last_body.size() > 0) |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 7101 | writes.push_back(CreateMockWrite(body4, i++)); |
| 7102 | writes.push_back(CreateMockWrite(body5, i++)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7103 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7104 | spdy::SpdySerializedFrame reply( |
| 7105 | spdy_util_.ConstructSpdyPostReply(nullptr, 0)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 7106 | reads.push_back(CreateMockRead(reply, i++)); |
| 7107 | reads.push_back(CreateMockRead(body2, i++)); |
| 7108 | reads.push_back(CreateMockRead(body5, i++)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7109 | reads.push_back(MockRead(ASYNC, 0, i++)); // EOF |
| 7110 | |
| 7111 | // Force all writes to happen before any read, last write will not |
| 7112 | // actually queue a frame, due to window size being 0. |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 7113 | SequencedSocketData data(reads, writes); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7114 | |
danakj | aee3e1ec | 2016-04-16 00:23:18 | [diff] [blame] | 7115 | std::vector<std::unique_ptr<UploadElementReader>> element_readers; |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 7116 | std::string upload_data_string(kBufferSize * num_upload_buffers, 'a'); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7117 | upload_data_string.append(kUploadData, kUploadDataSize); |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 7118 | element_readers.push_back(std::make_unique<UploadBytesElementReader>( |
bnc | 3f6a855 | 2017-05-17 13:40:34 | [diff] [blame] | 7119 | upload_data_string.c_str(), upload_data_string.size())); |
olli.raula | 6df48b2a | 2015-11-26 07:40:22 | [diff] [blame] | 7120 | ElementsUploadDataStream upload_data_stream(std::move(element_readers), 0); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7121 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 7122 | request_.method = "POST"; |
| 7123 | request_.upload_data_stream = &upload_data_stream; |
| 7124 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
| 7125 | |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7126 | helper.RunPreTestSetup(); |
mmenke | 666a6fea | 2015-12-19 04:16:33 | [diff] [blame] | 7127 | helper.AddData(&data); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7128 | |
| 7129 | HttpNetworkTransaction* trans = helper.trans(); |
| 7130 | |
| 7131 | TestCompletionCallback callback; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 7132 | int rv = trans->Start(&request_, callback.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 7133 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7134 | |
mmenke | 666a6fea | 2015-12-19 04:16:33 | [diff] [blame] | 7135 | data.RunUntilPaused(); // Write as much as we can. |
| 7136 | base::RunLoop().RunUntilIdle(); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7137 | |
| 7138 | SpdyHttpStream* stream = static_cast<SpdyHttpStream*>(trans->stream_.get()); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 7139 | ASSERT_TRUE(stream); |
| 7140 | ASSERT_TRUE(stream->stream()); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7141 | EXPECT_EQ(0, stream->stream()->send_window_size()); |
| 7142 | |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 7143 | if (initial_window_size % kBufferSize != 0) { |
| 7144 | // If it does not take whole number of full upload buffer to zero out |
| 7145 | // initial window size, then the upload data is not at EOF, because the |
| 7146 | // last read must be stalled. |
| 7147 | EXPECT_FALSE(upload_data_stream.IsEOF()); |
| 7148 | } else { |
| 7149 | // All the body data should have been read. |
| 7150 | // TODO(satorux): This is because of the weirdness in reading the request |
| 7151 | // body in OnSendBodyComplete(). See crbug.com/113107. |
| 7152 | EXPECT_TRUE(upload_data_stream.IsEOF()); |
| 7153 | } |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7154 | |
| 7155 | // Read in WINDOW_UPDATE or SETTINGS frame. |
mmenke | 666a6fea | 2015-12-19 04:16:33 | [diff] [blame] | 7156 | data.Resume(); |
| 7157 | base::RunLoop().RunUntilIdle(); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7158 | rv = callback.WaitForResult(); |
| 7159 | helper.VerifyDataConsumed(); |
| 7160 | } |
| 7161 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 7162 | TEST_F(SpdyNetworkTransactionTest, GoAwayOnOddPushStreamId) { |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 7163 | base::HistogramTester histogram_tester; |
| 7164 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7165 | spdy::SpdyHeaderBlock push_headers; |
bnc | 086b39e1 | 2016-06-24 13:05:26 | [diff] [blame] | 7166 | spdy_util_.AddUrlToHeaderBlock("http://www.example.org/a.dat", &push_headers); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7167 | spdy::SpdySerializedFrame push( |
Bence Béky | f1d7852 | 2018-01-11 01:16:50 | [diff] [blame] | 7168 | spdy_util_.ConstructSpdyPushPromise(1, 3, std::move(push_headers))); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 7169 | MockRead reads[] = {CreateMockRead(push, 1)}; |
baranovich | 212a129 | 2014-09-02 21:45:31 | [diff] [blame] | 7170 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7171 | spdy::SpdySerializedFrame req( |
| 7172 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 7173 | spdy::SpdySerializedFrame goaway(spdy_util_.ConstructSpdyGoAway( |
| 7174 | 0, spdy::ERROR_CODE_PROTOCOL_ERROR, |
Bence Béky | 602c40c | 2017-07-26 05:22:56 | [diff] [blame] | 7175 | "Received invalid pushed stream id 3 (must be even) on stream id 1.")); |
baranovich | 212a129 | 2014-09-02 21:45:31 | [diff] [blame] | 7176 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 7177 | CreateMockWrite(req, 0), CreateMockWrite(goaway, 2), |
baranovich | 212a129 | 2014-09-02 21:45:31 | [diff] [blame] | 7178 | }; |
| 7179 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 7180 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 7181 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
baranovich | 212a129 | 2014-09-02 21:45:31 | [diff] [blame] | 7182 | helper.RunToCompletion(&data); |
| 7183 | TransactionHelperResult out = helper.output(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 7184 | EXPECT_THAT(out.rv, IsError(ERR_SPDY_PROTOCOL_ERROR)); |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 7185 | |
| 7186 | histogram_tester.ExpectBucketCount( |
| 7187 | "Net.SpdyPushedStreamFate", |
| 7188 | static_cast<int>(SpdyPushedStreamFate::kPromisedStreamIdParityError), 1); |
| 7189 | histogram_tester.ExpectTotalCount("Net.SpdyPushedStreamFate", 1); |
baranovich | 212a129 | 2014-09-02 21:45:31 | [diff] [blame] | 7190 | } |
| 7191 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 7192 | TEST_F(SpdyNetworkTransactionTest, |
baranovich | 212a129 | 2014-09-02 21:45:31 | [diff] [blame] | 7193 | GoAwayOnPushStreamIdLesserOrEqualThanLastAccepted) { |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 7194 | base::HistogramTester histogram_tester; |
| 7195 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7196 | spdy::SpdySerializedFrame push_a(spdy_util_.ConstructSpdyPush( |
Bence Béky | 3e01b53 | 2018-02-06 23:04:51 | [diff] [blame] | 7197 | nullptr, 0, 4, 1, "https://www.example.org/a.dat")); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7198 | spdy::SpdyHeaderBlock push_b_headers; |
Bence Béky | 3e01b53 | 2018-02-06 23:04:51 | [diff] [blame] | 7199 | spdy_util_.AddUrlToHeaderBlock("https://www.example.org/b.dat", |
bnc | 086b39e1 | 2016-06-24 13:05:26 | [diff] [blame] | 7200 | &push_b_headers); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7201 | spdy::SpdySerializedFrame push_b( |
Bence Béky | f1d7852 | 2018-01-11 01:16:50 | [diff] [blame] | 7202 | spdy_util_.ConstructSpdyPushPromise(1, 2, std::move(push_b_headers))); |
baranovich | 212a129 | 2014-09-02 21:45:31 | [diff] [blame] | 7203 | MockRead reads[] = { |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 7204 | CreateMockRead(push_a, 1), CreateMockRead(push_b, 3), |
baranovich | 212a129 | 2014-09-02 21:45:31 | [diff] [blame] | 7205 | }; |
| 7206 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7207 | spdy::SpdySerializedFrame req( |
| 7208 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 7209 | spdy::SpdySerializedFrame priority_a( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 7210 | spdy_util_.ConstructSpdyPriority(4, 1, IDLE, true)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7211 | spdy::SpdySerializedFrame goaway(spdy_util_.ConstructSpdyGoAway( |
| 7212 | 4, spdy::ERROR_CODE_PROTOCOL_ERROR, |
Bence Béky | 602c40c | 2017-07-26 05:22:56 | [diff] [blame] | 7213 | "Received pushed stream id 2 must be larger than last accepted id 4.")); |
baranovich | 212a129 | 2014-09-02 21:45:31 | [diff] [blame] | 7214 | MockWrite writes[] = { |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 7215 | CreateMockWrite(req, 0), CreateMockWrite(priority_a, 2), |
| 7216 | CreateMockWrite(goaway, 4), |
baranovich | 212a129 | 2014-09-02 21:45:31 | [diff] [blame] | 7217 | }; |
| 7218 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 7219 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 7220 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
baranovich | 212a129 | 2014-09-02 21:45:31 | [diff] [blame] | 7221 | helper.RunToCompletion(&data); |
| 7222 | TransactionHelperResult out = helper.output(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 7223 | EXPECT_THAT(out.rv, IsError(ERR_SPDY_PROTOCOL_ERROR)); |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 7224 | |
| 7225 | histogram_tester.ExpectBucketCount( |
| 7226 | "Net.SpdyPushedStreamFate", |
| 7227 | static_cast<int>(SpdyPushedStreamFate::kStreamIdOutOfOrder), 1); |
| 7228 | histogram_tester.ExpectTotalCount("Net.SpdyPushedStreamFate", 1); |
baranovich | 212a129 | 2014-09-02 21:45:31 | [diff] [blame] | 7229 | } |
| 7230 | |
bnc | 76598ab | 2015-06-29 12:43:07 | [diff] [blame] | 7231 | // Regression test for https://crbug.com/493348: request header exceeds 16 kB |
| 7232 | // and thus sent in multiple frames when using HTTP/2. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 7233 | TEST_F(SpdyNetworkTransactionTest, LargeRequest) { |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 7234 | const std::string kKey("foo"); |
| 7235 | const std::string kValue(1 << 15, 'z'); |
bnc | 76598ab | 2015-06-29 12:43:07 | [diff] [blame] | 7236 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 7237 | request_.extra_headers.SetHeader(kKey, kValue); |
bnc | 76598ab | 2015-06-29 12:43:07 | [diff] [blame] | 7238 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7239 | spdy::SpdyHeaderBlock headers( |
| 7240 | spdy_util_.ConstructGetHeaderBlock(kDefaultUrl)); |
bnc | 086b39e1 | 2016-06-24 13:05:26 | [diff] [blame] | 7241 | headers[kKey] = kValue; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7242 | spdy::SpdySerializedFrame req( |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 7243 | spdy_util_.ConstructSpdyHeaders(1, std::move(headers), LOWEST, true)); |
bnc | 76598ab | 2015-06-29 12:43:07 | [diff] [blame] | 7244 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 7245 | CreateMockWrite(req, 0), |
bnc | 76598ab | 2015-06-29 12:43:07 | [diff] [blame] | 7246 | }; |
| 7247 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7248 | spdy::SpdySerializedFrame resp( |
| 7249 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 7250 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
bnc | 76598ab | 2015-06-29 12:43:07 | [diff] [blame] | 7251 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 7252 | CreateMockRead(resp, 1), CreateMockRead(body, 2), |
bnc | 76598ab | 2015-06-29 12:43:07 | [diff] [blame] | 7253 | MockRead(ASYNC, 0, 3) // EOF |
| 7254 | }; |
| 7255 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 7256 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 7257 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
bnc | 76598ab | 2015-06-29 12:43:07 | [diff] [blame] | 7258 | helper.RunToCompletion(&data); |
| 7259 | TransactionHelperResult out = helper.output(); |
| 7260 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 7261 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 7262 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
bnc | 76598ab | 2015-06-29 12:43:07 | [diff] [blame] | 7263 | EXPECT_EQ("hello!", out.response_data); |
| 7264 | } |
| 7265 | |
bnc | d6738334 | 2016-01-08 21:58:43 | [diff] [blame] | 7266 | // Regression test for https://crbug.com/535629: response header exceeds 16 kB. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 7267 | TEST_F(SpdyNetworkTransactionTest, LargeResponseHeader) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7268 | spdy::SpdyHeaderBlock headers( |
| 7269 | spdy_util_.ConstructGetHeaderBlock(kDefaultUrl)); |
| 7270 | spdy::SpdySerializedFrame req( |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 7271 | spdy_util_.ConstructSpdyHeaders(1, std::move(headers), LOWEST, true)); |
bnc | d6738334 | 2016-01-08 21:58:43 | [diff] [blame] | 7272 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 7273 | CreateMockWrite(req, 0), |
bnc | d6738334 | 2016-01-08 21:58:43 | [diff] [blame] | 7274 | }; |
| 7275 | |
| 7276 | // HPACK decoder implementation limits string literal length to 16 kB. |
| 7277 | const char* response_headers[2]; |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 7278 | const std::string kKey(16 * 1024, 'a'); |
bnc | d6738334 | 2016-01-08 21:58:43 | [diff] [blame] | 7279 | response_headers[0] = kKey.data(); |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 7280 | const std::string kValue(16 * 1024, 'b'); |
bnc | d6738334 | 2016-01-08 21:58:43 | [diff] [blame] | 7281 | response_headers[1] = kValue.data(); |
| 7282 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7283 | spdy::SpdySerializedFrame resp( |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 7284 | spdy_util_.ConstructSpdyGetReply(response_headers, 1, 1)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7285 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
bnc | d6738334 | 2016-01-08 21:58:43 | [diff] [blame] | 7286 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 7287 | CreateMockRead(resp, 1), CreateMockRead(body, 2), |
bnc | d6738334 | 2016-01-08 21:58:43 | [diff] [blame] | 7288 | MockRead(ASYNC, 0, 3) // EOF |
| 7289 | }; |
| 7290 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 7291 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
bnc | d6738334 | 2016-01-08 21:58:43 | [diff] [blame] | 7292 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 7293 | SequencedSocketData data(reads, writes); |
bnc | d6738334 | 2016-01-08 21:58:43 | [diff] [blame] | 7294 | helper.RunToCompletion(&data); |
| 7295 | TransactionHelperResult out = helper.output(); |
| 7296 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 7297 | EXPECT_THAT(out.rv, IsOk()); |
bnc | d6738334 | 2016-01-08 21:58:43 | [diff] [blame] | 7298 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
| 7299 | EXPECT_EQ("hello!", out.response_data); |
| 7300 | ASSERT_TRUE(out.response_info.headers->HasHeaderValue(kKey, kValue)); |
| 7301 | } |
| 7302 | |
bnc | 204a6d0 | 2016-08-01 14:34:27 | [diff] [blame] | 7303 | // End of line delimiter is forbidden according to RFC 7230 Section 3.2. |
| 7304 | TEST_F(SpdyNetworkTransactionTest, CRLFInHeaderValue) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7305 | spdy::SpdySerializedFrame req( |
| 7306 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 7307 | spdy::SpdySerializedFrame rst( |
| 7308 | spdy_util_.ConstructSpdyRstStream(1, spdy::ERROR_CODE_PROTOCOL_ERROR)); |
bnc | 204a6d0 | 2016-08-01 14:34:27 | [diff] [blame] | 7309 | MockWrite writes[] = {CreateMockWrite(req, 0), CreateMockWrite(rst, 2)}; |
| 7310 | |
| 7311 | const char* response_headers[] = {"folded", "foo\r\nbar"}; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7312 | spdy::SpdySerializedFrame resp( |
bnc | 204a6d0 | 2016-08-01 14:34:27 | [diff] [blame] | 7313 | spdy_util_.ConstructSpdyGetReply(response_headers, 1, 1)); |
| 7314 | MockRead reads[] = {CreateMockRead(resp, 1), MockRead(ASYNC, 0, 3)}; |
| 7315 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 7316 | SequencedSocketData data(reads, writes); |
bnc | 204a6d0 | 2016-08-01 14:34:27 | [diff] [blame] | 7317 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 7318 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
bnc | 204a6d0 | 2016-08-01 14:34:27 | [diff] [blame] | 7319 | helper.RunToCompletion(&data); |
| 7320 | TransactionHelperResult out = helper.output(); |
| 7321 | |
| 7322 | EXPECT_THAT(out.rv, IsError(ERR_SPDY_PROTOCOL_ERROR)); |
| 7323 | } |
| 7324 | |
bnc | c22b581e8 | 2016-10-27 04:45:42 | [diff] [blame] | 7325 | // Regression test for https://crbug.com/603182. |
| 7326 | // No response headers received before RST_STREAM: error. |
| 7327 | TEST_F(SpdyNetworkTransactionTest, RstStreamNoError) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7328 | spdy::SpdySerializedFrame req( |
| 7329 | spdy_util_.ConstructChunkedSpdyPost(nullptr, 0)); |
bnc | c22b581e8 | 2016-10-27 04:45:42 | [diff] [blame] | 7330 | MockWrite writes[] = {CreateMockWrite(req, 0, ASYNC)}; |
| 7331 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7332 | spdy::SpdySerializedFrame rst( |
| 7333 | spdy_util_.ConstructSpdyRstStream(1, spdy::ERROR_CODE_NO_ERROR)); |
bnc | c22b581e8 | 2016-10-27 04:45:42 | [diff] [blame] | 7334 | MockRead reads[] = {CreateMockRead(rst, 1), MockRead(ASYNC, 0, 2)}; |
| 7335 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 7336 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 7337 | UseChunkedPostRequest(); |
| 7338 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
bnc | c22b581e8 | 2016-10-27 04:45:42 | [diff] [blame] | 7339 | helper.RunToCompletion(&data); |
| 7340 | TransactionHelperResult out = helper.output(); |
| 7341 | EXPECT_THAT(out.rv, IsError(ERR_SPDY_PROTOCOL_ERROR)); |
| 7342 | } |
| 7343 | |
| 7344 | // Regression test for https://crbug.com/603182. |
| 7345 | // Response headers and data, then RST_STREAM received, |
| 7346 | // before request body is sent: success. |
| 7347 | TEST_F(SpdyNetworkTransactionTest, RstStreamNoErrorAfterResponse) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7348 | spdy::SpdySerializedFrame req( |
| 7349 | spdy_util_.ConstructChunkedSpdyPost(nullptr, 0)); |
bnc | c22b581e8 | 2016-10-27 04:45:42 | [diff] [blame] | 7350 | MockWrite writes[] = {CreateMockWrite(req, 0, ASYNC)}; |
| 7351 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7352 | spdy::SpdySerializedFrame resp(spdy_util_.ConstructSpdyPostReply(nullptr, 0)); |
| 7353 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 7354 | spdy::SpdySerializedFrame rst( |
| 7355 | spdy_util_.ConstructSpdyRstStream(1, spdy::ERROR_CODE_NO_ERROR)); |
bnc | c22b581e8 | 2016-10-27 04:45:42 | [diff] [blame] | 7356 | MockRead reads[] = {CreateMockRead(resp, 1), CreateMockRead(body, 2), |
| 7357 | CreateMockRead(rst, 3), MockRead(ASYNC, 0, 4)}; |
| 7358 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 7359 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 7360 | UseChunkedPostRequest(); |
| 7361 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
bnc | c22b581e8 | 2016-10-27 04:45:42 | [diff] [blame] | 7362 | helper.RunToCompletion(&data); |
| 7363 | TransactionHelperResult out = helper.output(); |
| 7364 | EXPECT_THAT(out.rv, IsOk()); |
| 7365 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
| 7366 | EXPECT_EQ("hello!", out.response_data); |
| 7367 | } |
| 7368 | |
bnc | c9f762a | 2016-12-06 20:38:23 | [diff] [blame] | 7369 | TEST_F(SpdyNetworkTransactionTest, 100Continue) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7370 | spdy::SpdySerializedFrame req( |
| 7371 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
bnc | c9f762a | 2016-12-06 20:38:23 | [diff] [blame] | 7372 | MockWrite writes[] = {CreateMockWrite(req, 0)}; |
| 7373 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7374 | spdy::SpdyHeaderBlock informational_headers; |
| 7375 | informational_headers[spdy::kHttp2StatusHeader] = "100"; |
| 7376 | spdy::SpdySerializedFrame informational_response( |
bnc | c9f762a | 2016-12-06 20:38:23 | [diff] [blame] | 7377 | spdy_util_.ConstructSpdyReply(1, std::move(informational_headers))); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7378 | spdy::SpdySerializedFrame resp( |
| 7379 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 7380 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
bnc | c9f762a | 2016-12-06 20:38:23 | [diff] [blame] | 7381 | MockRead reads[] = { |
| 7382 | CreateMockRead(informational_response, 1), CreateMockRead(resp, 2), |
| 7383 | CreateMockRead(body, 3), MockRead(ASYNC, 0, 4) // EOF |
| 7384 | }; |
| 7385 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 7386 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 7387 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
bnc | c9f762a | 2016-12-06 20:38:23 | [diff] [blame] | 7388 | helper.RunToCompletion(&data); |
| 7389 | TransactionHelperResult out = helper.output(); |
| 7390 | EXPECT_THAT(out.rv, IsOk()); |
| 7391 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
| 7392 | EXPECT_EQ("hello!", out.response_data); |
| 7393 | } |
| 7394 | |
bnc | 1ff8087 | 2016-12-16 20:57:57 | [diff] [blame] | 7395 | // "A server can send a complete response prior to the client sending an entire |
| 7396 | // request if the response does not depend on any portion of the request that |
| 7397 | // has not been sent and received." (RFC7540 Section 8.1) |
| 7398 | // Regression test for https://crbug.com/606990. Server responds before POST |
| 7399 | // data are sent and closes connection: this must result in |
| 7400 | // ERR_CONNECTION_CLOSED (as opposed to ERR_SPDY_PROTOCOL_ERROR). |
| 7401 | TEST_F(SpdyNetworkTransactionTest, ResponseBeforePostDataSent) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7402 | spdy::SpdySerializedFrame req( |
| 7403 | spdy_util_.ConstructChunkedSpdyPost(nullptr, 0)); |
bnc | 1ff8087 | 2016-12-16 20:57:57 | [diff] [blame] | 7404 | MockWrite writes[] = {CreateMockWrite(req, 0)}; |
| 7405 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7406 | spdy::SpdySerializedFrame resp(spdy_util_.ConstructSpdyPostReply(nullptr, 0)); |
| 7407 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
bnc | 1ff8087 | 2016-12-16 20:57:57 | [diff] [blame] | 7408 | MockRead reads[] = {CreateMockRead(resp, 1), CreateMockRead(body, 2), |
| 7409 | MockRead(ASYNC, 0, 3)}; |
| 7410 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 7411 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 7412 | UseChunkedPostRequest(); |
| 7413 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
bnc | 1ff8087 | 2016-12-16 20:57:57 | [diff] [blame] | 7414 | |
| 7415 | helper.RunPreTestSetup(); |
| 7416 | helper.AddData(&data); |
| 7417 | helper.StartDefaultTest(); |
| 7418 | EXPECT_THAT(helper.output().rv, IsError(ERR_IO_PENDING)); |
| 7419 | helper.WaitForCallbackToComplete(); |
| 7420 | EXPECT_THAT(helper.output().rv, IsError(ERR_CONNECTION_CLOSED)); |
| 7421 | } |
| 7422 | |
| 7423 | // Regression test for https://crbug.com/606990. |
| 7424 | // Server responds before POST data are sent and resets stream with NO_ERROR. |
| 7425 | TEST_F(SpdyNetworkTransactionTest, ResponseAndRstStreamBeforePostDataSent) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7426 | spdy::SpdySerializedFrame req( |
| 7427 | spdy_util_.ConstructChunkedSpdyPost(nullptr, 0)); |
bnc | 1ff8087 | 2016-12-16 20:57:57 | [diff] [blame] | 7428 | MockWrite writes[] = {CreateMockWrite(req, 0)}; |
| 7429 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7430 | spdy::SpdySerializedFrame resp(spdy_util_.ConstructSpdyPostReply(nullptr, 0)); |
| 7431 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 7432 | spdy::SpdySerializedFrame rst( |
| 7433 | spdy_util_.ConstructSpdyRstStream(1, spdy::ERROR_CODE_NO_ERROR)); |
bnc | 1ff8087 | 2016-12-16 20:57:57 | [diff] [blame] | 7434 | MockRead reads[] = {CreateMockRead(resp, 1), CreateMockRead(body, 2), |
| 7435 | CreateMockRead(rst, 3), MockRead(ASYNC, 0, 4)}; |
| 7436 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 7437 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 7438 | UseChunkedPostRequest(); |
| 7439 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
bnc | 1ff8087 | 2016-12-16 20:57:57 | [diff] [blame] | 7440 | |
| 7441 | helper.RunToCompletion(&data); |
| 7442 | |
| 7443 | TransactionHelperResult out = helper.output(); |
| 7444 | EXPECT_THAT(out.rv, IsOk()); |
| 7445 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
| 7446 | EXPECT_EQ("hello!", out.response_data); |
| 7447 | } |
| 7448 | |
bnc | 96487ec | 2017-03-29 19:40:23 | [diff] [blame] | 7449 | // Unsupported frames must be ignored. This is especially important for frame |
| 7450 | // type 0xb, which used to be the BLOCKED frame in previous versions of SPDY, |
| 7451 | // but is going to be used for the ORIGIN frame. |
| 7452 | // TODO(bnc): Implement ORIGIN frame support. https://crbug.com/697333 |
| 7453 | TEST_F(SpdyNetworkTransactionTest, IgnoreUnsupportedOriginFrame) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7454 | spdy::SpdySerializedFrame req( |
| 7455 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
bnc | 96487ec | 2017-03-29 19:40:23 | [diff] [blame] | 7456 | MockWrite writes[] = {CreateMockWrite(req, 0)}; |
| 7457 | |
| 7458 | const char origin_frame_on_stream_zero[] = { |
| 7459 | 0x00, 0x00, 0x05, // Length |
| 7460 | 0x0b, // Type |
| 7461 | 0x00, // Flags |
| 7462 | 0x00, 0x00, 0x00, 0x00, // Stream ID |
| 7463 | 0x00, 0x03, // Origin-Len |
| 7464 | 'f', 'o', 'o' // ASCII-Origin |
| 7465 | }; |
| 7466 | |
| 7467 | const char origin_frame_on_stream_one[] = { |
| 7468 | 0x00, 0x00, 0x05, // Length |
| 7469 | 0x0b, // Type |
| 7470 | 0x00, // Flags |
| 7471 | 0x00, 0x00, 0x00, 0x01, // Stream ID |
| 7472 | 0x00, 0x03, // Origin-Len |
| 7473 | 'b', 'a', 'r' // ASCII-Origin |
| 7474 | }; |
| 7475 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7476 | spdy::SpdySerializedFrame resp( |
| 7477 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 7478 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
bnc | 96487ec | 2017-03-29 19:40:23 | [diff] [blame] | 7479 | MockRead reads[] = {MockRead(ASYNC, origin_frame_on_stream_zero, |
Avi Drissman | 4365a478 | 2018-12-28 19:26:24 | [diff] [blame] | 7480 | base::size(origin_frame_on_stream_zero), 1), |
bnc | 96487ec | 2017-03-29 19:40:23 | [diff] [blame] | 7481 | CreateMockRead(resp, 2), |
| 7482 | MockRead(ASYNC, origin_frame_on_stream_one, |
Avi Drissman | 4365a478 | 2018-12-28 19:26:24 | [diff] [blame] | 7483 | base::size(origin_frame_on_stream_one), 3), |
bnc | 96487ec | 2017-03-29 19:40:23 | [diff] [blame] | 7484 | CreateMockRead(body, 4), MockRead(ASYNC, 0, 5)}; |
| 7485 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 7486 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 7487 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
bnc | 96487ec | 2017-03-29 19:40:23 | [diff] [blame] | 7488 | helper.RunToCompletion(&data); |
| 7489 | TransactionHelperResult out = helper.output(); |
| 7490 | EXPECT_THAT(out.rv, IsOk()); |
| 7491 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
| 7492 | EXPECT_EQ("hello!", out.response_data); |
| 7493 | } |
| 7494 | |
[email protected] | 514aeaf | 2014-05-23 10:31:51 | [diff] [blame] | 7495 | class SpdyNetworkTransactionTLSUsageCheckTest |
| 7496 | : public SpdyNetworkTransactionTest { |
| 7497 | protected: |
danakj | aee3e1ec | 2016-04-16 00:23:18 | [diff] [blame] | 7498 | void RunTLSUsageCheckTest( |
| 7499 | std::unique_ptr<SSLSocketDataProvider> ssl_provider) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7500 | spdy::SpdySerializedFrame goaway(spdy_util_.ConstructSpdyGoAway( |
| 7501 | 0, spdy::ERROR_CODE_INADEQUATE_SECURITY, "")); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 7502 | MockWrite writes[] = {CreateMockWrite(goaway)}; |
[email protected] | 514aeaf | 2014-05-23 10:31:51 | [diff] [blame] | 7503 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 7504 | StaticSocketDataProvider data(base::span<MockRead>(), writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 7505 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
Bence Béky | d3dde83 | 2017-09-19 19:02:31 | [diff] [blame] | 7506 | nullptr); |
dcheng | c7eeda42 | 2015-12-26 03:56:48 | [diff] [blame] | 7507 | helper.RunToCompletionWithSSLData(&data, std::move(ssl_provider)); |
[email protected] | 514aeaf | 2014-05-23 10:31:51 | [diff] [blame] | 7508 | TransactionHelperResult out = helper.output(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 7509 | EXPECT_THAT(out.rv, IsError(ERR_SPDY_INADEQUATE_TRANSPORT_SECURITY)); |
[email protected] | 514aeaf | 2014-05-23 10:31:51 | [diff] [blame] | 7510 | } |
| 7511 | }; |
| 7512 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 7513 | TEST_F(SpdyNetworkTransactionTLSUsageCheckTest, TLSVersionTooOld) { |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 7514 | auto ssl_provider = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
[email protected] | 514aeaf | 2014-05-23 10:31:51 | [diff] [blame] | 7515 | SSLConnectionStatusSetVersion(SSL_CONNECTION_VERSION_SSL3, |
Ryan Sleevi | 4f83209 | 2017-11-21 23:25:49 | [diff] [blame] | 7516 | &ssl_provider->ssl_info.connection_status); |
[email protected] | 514aeaf | 2014-05-23 10:31:51 | [diff] [blame] | 7517 | |
dcheng | c7eeda42 | 2015-12-26 03:56:48 | [diff] [blame] | 7518 | RunTLSUsageCheckTest(std::move(ssl_provider)); |
[email protected] | 514aeaf | 2014-05-23 10:31:51 | [diff] [blame] | 7519 | } |
| 7520 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 7521 | TEST_F(SpdyNetworkTransactionTLSUsageCheckTest, TLSCipherSuiteSucky) { |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 7522 | auto ssl_provider = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
[email protected] | 514aeaf | 2014-05-23 10:31:51 | [diff] [blame] | 7523 | // Set to TLS_RSA_WITH_NULL_MD5 |
Ryan Sleevi | 4f83209 | 2017-11-21 23:25:49 | [diff] [blame] | 7524 | SSLConnectionStatusSetCipherSuite(0x1, |
| 7525 | &ssl_provider->ssl_info.connection_status); |
[email protected] | 514aeaf | 2014-05-23 10:31:51 | [diff] [blame] | 7526 | |
dcheng | c7eeda42 | 2015-12-26 03:56:48 | [diff] [blame] | 7527 | RunTLSUsageCheckTest(std::move(ssl_provider)); |
[email protected] | 514aeaf | 2014-05-23 10:31:51 | [diff] [blame] | 7528 | } |
| 7529 | |
Bence Béky | 306378f | 2017-06-30 12:09:56 | [diff] [blame] | 7530 | // Regression test for https://crbug.com/737143. |
| 7531 | // This test sets up an old TLS version just like in TLSVersionTooOld, |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7532 | // and makes sure that it results in an spdy::ERROR_CODE_INADEQUATE_SECURITY |
Bence Béky | 306378f | 2017-06-30 12:09:56 | [diff] [blame] | 7533 | // even for a non-secure request URL. |
| 7534 | TEST_F(SpdyNetworkTransactionTest, InsecureUrlCreatesSecureSpdySession) { |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 7535 | auto ssl_provider = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
Bence Béky | 306378f | 2017-06-30 12:09:56 | [diff] [blame] | 7536 | SSLConnectionStatusSetVersion(SSL_CONNECTION_VERSION_SSL3, |
Ryan Sleevi | 4f83209 | 2017-11-21 23:25:49 | [diff] [blame] | 7537 | &ssl_provider->ssl_info.connection_status); |
Bence Béky | 306378f | 2017-06-30 12:09:56 | [diff] [blame] | 7538 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7539 | spdy::SpdySerializedFrame goaway(spdy_util_.ConstructSpdyGoAway( |
| 7540 | 0, spdy::ERROR_CODE_INADEQUATE_SECURITY, "")); |
Bence Béky | 306378f | 2017-06-30 12:09:56 | [diff] [blame] | 7541 | MockWrite writes[] = {CreateMockWrite(goaway)}; |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 7542 | StaticSocketDataProvider data(base::span<MockRead>(), writes); |
Bence Béky | 306378f | 2017-06-30 12:09:56 | [diff] [blame] | 7543 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 7544 | request_.url = GURL("http://www.example.org/"); |
Bence Béky | 306378f | 2017-06-30 12:09:56 | [diff] [blame] | 7545 | |
| 7546 | // Need secure proxy so that insecure URL can use HTTP/2. |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 7547 | auto session_deps = std::make_unique<SpdySessionDependencies>( |
Ramin Halavati | ca8d525 | 2018-03-12 05:33:49 | [diff] [blame] | 7548 | ProxyResolutionService::CreateFixedFromPacResult( |
| 7549 | "HTTPS myproxy:70", TRAFFIC_ANNOTATION_FOR_TESTS)); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 7550 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
Bence Béky | d3dde83 | 2017-09-19 19:02:31 | [diff] [blame] | 7551 | std::move(session_deps)); |
Bence Béky | 306378f | 2017-06-30 12:09:56 | [diff] [blame] | 7552 | |
| 7553 | helper.RunToCompletionWithSSLData(&data, std::move(ssl_provider)); |
| 7554 | TransactionHelperResult out = helper.output(); |
| 7555 | EXPECT_THAT(out.rv, IsError(ERR_SPDY_INADEQUATE_TRANSPORT_SECURITY)); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 7556 | } |
Bence Béky | 306378f | 2017-06-30 12:09:56 | [diff] [blame] | 7557 | |
Andrey Kosyakov | 83a6eee | 2017-08-14 19:20:04 | [diff] [blame] | 7558 | TEST_F(SpdyNetworkTransactionTest, RequestHeadersCallback) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7559 | spdy::SpdySerializedFrame req( |
Bence Béky | 27ad0a1 | 2018-02-08 00:35:48 | [diff] [blame] | 7560 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, DEFAULT_PRIORITY)); |
Andrey Kosyakov | 83a6eee | 2017-08-14 19:20:04 | [diff] [blame] | 7561 | MockWrite writes[] = {CreateMockWrite(req, 0)}; |
| 7562 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7563 | spdy::SpdySerializedFrame resp( |
| 7564 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 7565 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
Andrey Kosyakov | 83a6eee | 2017-08-14 19:20:04 | [diff] [blame] | 7566 | MockRead reads[] = { |
| 7567 | CreateMockRead(resp, 1), CreateMockRead(body, 2), |
| 7568 | MockRead(ASYNC, 0, 3) // EOF |
| 7569 | }; |
| 7570 | |
| 7571 | HttpRawRequestHeaders raw_headers; |
| 7572 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 7573 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 7574 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
Andrey Kosyakov | 83a6eee | 2017-08-14 19:20:04 | [diff] [blame] | 7575 | helper.RunPreTestSetup(); |
| 7576 | helper.AddData(&data); |
| 7577 | helper.trans()->SetRequestHeadersCallback(base::Bind( |
| 7578 | &HttpRawRequestHeaders::Assign, base::Unretained(&raw_headers))); |
| 7579 | helper.StartDefaultTest(); |
| 7580 | helper.FinishDefaultTestWithoutVerification(); |
| 7581 | EXPECT_FALSE(raw_headers.headers().empty()); |
| 7582 | std::string value; |
| 7583 | EXPECT_TRUE(raw_headers.FindHeaderForTest(":path", &value)); |
| 7584 | EXPECT_EQ("/", value); |
| 7585 | EXPECT_TRUE(raw_headers.FindHeaderForTest(":method", &value)); |
| 7586 | EXPECT_EQ("GET", value); |
| 7587 | EXPECT_TRUE(raw_headers.request_line().empty()); |
| 7588 | } |
| 7589 | |
Yoav Weiss | 9693572f | 2018-01-04 09:37:34 | [diff] [blame] | 7590 | // A request that has adopted a push promise and later got reset by the server |
| 7591 | // should be retried on a new stream. |
| 7592 | // Regression test for https://crbug.com/798508. |
| 7593 | TEST_F(SpdyNetworkTransactionTest, PushCanceledByServerAfterClaimed) { |
| 7594 | const char pushed_url[] = "https://www.example.org/a.dat"; |
| 7595 | // Construct a request to the default URL on stream 1. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7596 | spdy::SpdySerializedFrame req( |
| 7597 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 7598 | spdy::SpdySerializedFrame req2( |
| 7599 | spdy_util_.ConstructSpdyGet(pushed_url, 3, LOWEST)); |
Yoav Weiss | 9693572f | 2018-01-04 09:37:34 | [diff] [blame] | 7600 | // Construct a priority frame for stream 2. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7601 | spdy::SpdySerializedFrame priority( |
Yoav Weiss | 9693572f | 2018-01-04 09:37:34 | [diff] [blame] | 7602 | spdy_util_.ConstructSpdyPriority(2, 1, IDLE, true)); |
| 7603 | MockWrite writes[] = {CreateMockWrite(req, 0), CreateMockWrite(priority, 3), |
| 7604 | CreateMockWrite(req2, 6)}; |
| 7605 | |
| 7606 | // Construct a Push Promise frame, with no response. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7607 | spdy::SpdySerializedFrame push_promise(spdy_util_.ConstructSpdyPushPromise( |
Bence Béky | f1d7852 | 2018-01-11 01:16:50 | [diff] [blame] | 7608 | 1, 2, spdy_util_.ConstructGetHeaderBlock(pushed_url))); |
Yoav Weiss | 9693572f | 2018-01-04 09:37:34 | [diff] [blame] | 7609 | // Construct a RST frame, canceling stream 2. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7610 | spdy::SpdySerializedFrame rst_server( |
| 7611 | spdy_util_.ConstructSpdyRstStream(2, spdy::ERROR_CODE_CANCEL)); |
Yoav Weiss | 9693572f | 2018-01-04 09:37:34 | [diff] [blame] | 7612 | // Construct response headers and bodies. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7613 | spdy::SpdySerializedFrame resp1( |
| 7614 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 7615 | spdy::SpdySerializedFrame body1(spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 7616 | spdy::SpdySerializedFrame resp2( |
| 7617 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 3)); |
| 7618 | spdy::SpdySerializedFrame body2(spdy_util_.ConstructSpdyDataFrame(3, true)); |
Yoav Weiss | 9693572f | 2018-01-04 09:37:34 | [diff] [blame] | 7619 | MockRead reads[] = { |
| 7620 | CreateMockRead(push_promise, 1), MockRead(ASYNC, ERR_IO_PENDING, 2), |
| 7621 | CreateMockRead(rst_server, 4), MockRead(ASYNC, ERR_IO_PENDING, 5), |
| 7622 | CreateMockRead(resp1, 7), CreateMockRead(body1, 8), |
| 7623 | CreateMockRead(resp2, 9), CreateMockRead(body2, 10), |
| 7624 | MockRead(ASYNC, 0, 11)}; |
| 7625 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 7626 | SequencedSocketData data(reads, writes); |
Yoav Weiss | 9693572f | 2018-01-04 09:37:34 | [diff] [blame] | 7627 | |
| 7628 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
| 7629 | |
| 7630 | helper.RunPreTestSetup(); |
| 7631 | helper.AddData(&data); |
| 7632 | |
| 7633 | HttpNetworkTransaction* trans = helper.trans(); |
| 7634 | |
| 7635 | // First request to start the connection. |
| 7636 | TestCompletionCallback callback1; |
| 7637 | int rv = trans->Start(&request_, callback1.callback(), log_); |
| 7638 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 7639 | |
| 7640 | data.RunUntilPaused(); |
| 7641 | |
| 7642 | // Get a SpdySession. |
| 7643 | SpdySessionKey key(HostPortPair::FromURL(request_.url), ProxyServer::Direct(), |
Matt Menke | 2436b2f | 2018-12-11 18:07:11 | [diff] [blame] | 7644 | PRIVACY_MODE_DISABLED, |
| 7645 | SpdySessionKey::IsProxySession::kFalse, SocketTag()); |
Yoav Weiss | 9693572f | 2018-01-04 09:37:34 | [diff] [blame] | 7646 | HttpNetworkSession* session = helper.session(); |
| 7647 | base::WeakPtr<SpdySession> spdy_session = |
| 7648 | session->spdy_session_pool()->FindAvailableSession( |
Bence Béky | d885b2b | 2018-02-03 00:58:31 | [diff] [blame] | 7649 | key, /* enable_ip_based_pooling = */ true, |
| 7650 | /* is_websocket = */ false, log_); |
Yoav Weiss | 9693572f | 2018-01-04 09:37:34 | [diff] [blame] | 7651 | |
| 7652 | // Verify that there is one unclaimed push stream. |
| 7653 | EXPECT_EQ(1u, num_unclaimed_pushed_streams(spdy_session)); |
| 7654 | |
| 7655 | // Claim the pushed stream. |
| 7656 | HttpNetworkTransaction transaction2(DEFAULT_PRIORITY, session); |
| 7657 | TestCompletionCallback callback2; |
| 7658 | HttpRequestInfo request2; |
| 7659 | request2.method = "GET"; |
| 7660 | request2.url = GURL(pushed_url); |
Ramin Halavati | b5e433e6 | 2018-02-07 07:41:10 | [diff] [blame] | 7661 | request2.traffic_annotation = |
| 7662 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
Yoav Weiss | 9693572f | 2018-01-04 09:37:34 | [diff] [blame] | 7663 | transaction2.Start(&request2, callback2.callback(), log_); |
| 7664 | base::RunLoop().RunUntilIdle(); |
| 7665 | EXPECT_EQ(3u, spdy_stream_hi_water_mark(spdy_session)); |
| 7666 | |
| 7667 | EXPECT_EQ(0u, num_unclaimed_pushed_streams(spdy_session)); |
| 7668 | |
| 7669 | // Continue reading and get the RST. |
| 7670 | data.Resume(); |
| 7671 | base::RunLoop().RunUntilIdle(); |
| 7672 | |
| 7673 | // Make sure we got the RST and retried the request. |
| 7674 | EXPECT_EQ(2u, num_active_streams(spdy_session)); |
| 7675 | EXPECT_EQ(0u, num_unclaimed_pushed_streams(spdy_session)); |
| 7676 | EXPECT_EQ(5u, spdy_stream_hi_water_mark(spdy_session)); |
| 7677 | |
| 7678 | data.Resume(); |
| 7679 | |
| 7680 | // Test that transactions succeeded. |
| 7681 | rv = callback1.WaitForResult(); |
| 7682 | ASSERT_THAT(rv, IsOk()); |
| 7683 | |
| 7684 | rv = callback2.WaitForResult(); |
| 7685 | ASSERT_THAT(rv, IsOk()); |
| 7686 | |
| 7687 | // Read EOF. |
| 7688 | base::RunLoop().RunUntilIdle(); |
| 7689 | |
| 7690 | // Verify that all data was read and written. |
| 7691 | helper.VerifyDataConsumed(); |
| 7692 | } |
| 7693 | |
Bence Béky | 0ca719f | 2018-01-31 13:41:19 | [diff] [blame] | 7694 | #if BUILDFLAG(ENABLE_WEBSOCKETS) |
Bence Béky | 8bfacd4 | 2018-02-23 13:05:13 | [diff] [blame] | 7695 | |
| 7696 | TEST_F(SpdyNetworkTransactionTest, WebSocketOpensNewConnection) { |
Bence Béky | b09dddf1 | 2018-07-31 18:52:04 | [diff] [blame] | 7697 | base::HistogramTester histogram_tester; |
Bence Béky | 0ca719f | 2018-01-31 13:41:19 | [diff] [blame] | 7698 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
| 7699 | helper.RunPreTestSetup(); |
| 7700 | |
| 7701 | // First request opens up an HTTP/2 connection. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7702 | spdy::SpdySerializedFrame req( |
Bence Béky | 8bfacd4 | 2018-02-23 13:05:13 | [diff] [blame] | 7703 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, DEFAULT_PRIORITY)); |
Bence Béky | 0ca719f | 2018-01-31 13:41:19 | [diff] [blame] | 7704 | MockWrite writes1[] = {CreateMockWrite(req, 0)}; |
| 7705 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7706 | spdy::SpdySerializedFrame resp( |
| 7707 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 7708 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
Bence Béky | 0ca719f | 2018-01-31 13:41:19 | [diff] [blame] | 7709 | MockRead reads1[] = {CreateMockRead(resp, 1), CreateMockRead(body, 2), |
| 7710 | MockRead(ASYNC, ERR_IO_PENDING, 3), |
| 7711 | MockRead(ASYNC, 0, 4)}; |
| 7712 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 7713 | SequencedSocketData data1(reads1, writes1); |
Bence Béky | 0ca719f | 2018-01-31 13:41:19 | [diff] [blame] | 7714 | helper.AddData(&data1); |
| 7715 | |
Bence Béky | 8bfacd4 | 2018-02-23 13:05:13 | [diff] [blame] | 7716 | // WebSocket request opens a new connection with HTTP/2 disabled. |
Bence Béky | 0ca719f | 2018-01-31 13:41:19 | [diff] [blame] | 7717 | MockWrite writes2[] = { |
| 7718 | MockWrite("GET / HTTP/1.1\r\n" |
| 7719 | "Host: www.example.org\r\n" |
| 7720 | "Connection: Upgrade\r\n" |
| 7721 | "Upgrade: websocket\r\n" |
| 7722 | "Origin: http://www.example.org\r\n" |
| 7723 | "Sec-WebSocket-Version: 13\r\n" |
Bence Béky | 8d1c605 | 2018-02-07 12:48:15 | [diff] [blame] | 7724 | "Sec-WebSocket-Key: dGhlIHNhbXBsZSBub25jZQ==\r\n" |
| 7725 | "Sec-WebSocket-Extensions: permessage-deflate; " |
| 7726 | "client_max_window_bits\r\n\r\n")}; |
Bence Béky | 0ca719f | 2018-01-31 13:41:19 | [diff] [blame] | 7727 | |
Bence Béky | 8d1c605 | 2018-02-07 12:48:15 | [diff] [blame] | 7728 | MockRead reads2[] = { |
| 7729 | MockRead("HTTP/1.1 101 Switching Protocols\r\n" |
| 7730 | "Upgrade: websocket\r\n" |
| 7731 | "Connection: Upgrade\r\n" |
| 7732 | "Sec-WebSocket-Accept: s3pPLMBiTxaQ9kYGzzhZRbK+xOo=\r\n\r\n")}; |
| 7733 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 7734 | StaticSocketDataProvider data2(reads2, writes2); |
Bence Béky | 0ca719f | 2018-01-31 13:41:19 | [diff] [blame] | 7735 | |
| 7736 | auto ssl_provider2 = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
| 7737 | // Test that request has empty |alpn_protos|, that is, HTTP/2 is disabled. |
| 7738 | ssl_provider2->next_protos_expected_in_ssl_config = NextProtoVector{}; |
| 7739 | // Force socket to use HTTP/1.1, the default protocol without ALPN. |
| 7740 | ssl_provider2->next_proto = kProtoHTTP11; |
| 7741 | ssl_provider2->ssl_info.cert = |
| 7742 | ImportCertFromFile(GetTestCertsDirectory(), "spdy_pooling.pem"); |
| 7743 | helper.AddDataWithSSLSocketDataProvider(&data2, std::move(ssl_provider2)); |
| 7744 | |
| 7745 | TestCompletionCallback callback1; |
| 7746 | HttpNetworkTransaction trans1(DEFAULT_PRIORITY, helper.session()); |
| 7747 | int rv = trans1.Start(&request_, callback1.callback(), log_); |
| 7748 | ASSERT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 7749 | rv = callback1.WaitForResult(); |
| 7750 | ASSERT_THAT(rv, IsOk()); |
| 7751 | |
| 7752 | const HttpResponseInfo* response = trans1.GetResponseInfo(); |
| 7753 | ASSERT_TRUE(response->headers); |
| 7754 | EXPECT_TRUE(response->was_fetched_via_spdy); |
| 7755 | EXPECT_EQ("HTTP/1.1 200", response->headers->GetStatusLine()); |
| 7756 | |
| 7757 | std::string response_data; |
| 7758 | rv = ReadTransaction(&trans1, &response_data); |
| 7759 | EXPECT_THAT(rv, IsOk()); |
| 7760 | EXPECT_EQ("hello!", response_data); |
| 7761 | |
| 7762 | SpdySessionKey key(HostPortPair::FromURL(request_.url), ProxyServer::Direct(), |
Matt Menke | 2436b2f | 2018-12-11 18:07:11 | [diff] [blame] | 7763 | PRIVACY_MODE_DISABLED, |
| 7764 | SpdySessionKey::IsProxySession::kFalse, SocketTag()); |
Bence Béky | 0ca719f | 2018-01-31 13:41:19 | [diff] [blame] | 7765 | base::WeakPtr<SpdySession> spdy_session = |
| 7766 | helper.session()->spdy_session_pool()->FindAvailableSession( |
Bence Béky | d885b2b | 2018-02-03 00:58:31 | [diff] [blame] | 7767 | key, /* enable_ip_based_pooling = */ true, |
| 7768 | /* is_websocket = */ false, log_); |
Bence Béky | 0ca719f | 2018-01-31 13:41:19 | [diff] [blame] | 7769 | ASSERT_TRUE(spdy_session); |
Bence Béky | d885b2b | 2018-02-03 00:58:31 | [diff] [blame] | 7770 | EXPECT_FALSE(spdy_session->support_websocket()); |
Bence Béky | 0ca719f | 2018-01-31 13:41:19 | [diff] [blame] | 7771 | |
| 7772 | HttpRequestInfo request2; |
| 7773 | request2.method = "GET"; |
| 7774 | request2.url = GURL("wss://www.example.org/"); |
Ramin Halavati | b5e433e6 | 2018-02-07 07:41:10 | [diff] [blame] | 7775 | request2.traffic_annotation = |
| 7776 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
Bence Béky | 0ca719f | 2018-01-31 13:41:19 | [diff] [blame] | 7777 | EXPECT_TRUE(HostPortPair::FromURL(request_.url) |
| 7778 | .Equals(HostPortPair::FromURL(request2.url))); |
| 7779 | request2.extra_headers.SetHeader("Connection", "Upgrade"); |
| 7780 | request2.extra_headers.SetHeader("Upgrade", "websocket"); |
| 7781 | request2.extra_headers.SetHeader("Origin", "http://www.example.org"); |
| 7782 | request2.extra_headers.SetHeader("Sec-WebSocket-Version", "13"); |
Bence Béky | 8d1c605 | 2018-02-07 12:48:15 | [diff] [blame] | 7783 | |
| 7784 | TestWebSocketHandshakeStreamCreateHelper websocket_stream_create_helper; |
Bence Béky | 0ca719f | 2018-01-31 13:41:19 | [diff] [blame] | 7785 | |
| 7786 | HttpNetworkTransaction trans2(DEFAULT_PRIORITY, helper.session()); |
Bence Béky | 0ca719f | 2018-01-31 13:41:19 | [diff] [blame] | 7787 | trans2.SetWebSocketHandshakeStreamCreateHelper( |
| 7788 | &websocket_stream_create_helper); |
| 7789 | |
| 7790 | TestCompletionCallback callback2; |
| 7791 | rv = trans2.Start(&request2, callback2.callback(), log_); |
| 7792 | ASSERT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 7793 | rv = callback2.WaitForResult(); |
| 7794 | ASSERT_THAT(rv, IsOk()); |
| 7795 | |
Bence Béky | 8bfacd4 | 2018-02-23 13:05:13 | [diff] [blame] | 7796 | // HTTP/2 connection is still open, but WebSocket request did not pool to it. |
Bence Béky | 0ca719f | 2018-01-31 13:41:19 | [diff] [blame] | 7797 | ASSERT_TRUE(spdy_session); |
| 7798 | |
Bence Béky | 0ca719f | 2018-01-31 13:41:19 | [diff] [blame] | 7799 | data1.Resume(); |
Bence Béky | b09dddf1 | 2018-07-31 18:52:04 | [diff] [blame] | 7800 | base::RunLoop().RunUntilIdle(); |
Bence Béky | 0ca719f | 2018-01-31 13:41:19 | [diff] [blame] | 7801 | helper.VerifyDataConsumed(); |
Bence Béky | b09dddf1 | 2018-07-31 18:52:04 | [diff] [blame] | 7802 | |
| 7803 | // Server did not advertise WebSocket support. |
| 7804 | histogram_tester.ExpectUniqueSample("Net.SpdySession.ServerSupportsWebSocket", |
| 7805 | /* support_websocket = false */ 0, |
| 7806 | /* expected_count = */ 1); |
Bence Béky | 0ca719f | 2018-01-31 13:41:19 | [diff] [blame] | 7807 | } |
Bence Béky | 8bfacd4 | 2018-02-23 13:05:13 | [diff] [blame] | 7808 | |
| 7809 | TEST_F(SpdyNetworkTransactionTest, WebSocketOverHTTP2) { |
Bence Béky | b09dddf1 | 2018-07-31 18:52:04 | [diff] [blame] | 7810 | base::HistogramTester histogram_tester; |
Bence Béky | 8bfacd4 | 2018-02-23 13:05:13 | [diff] [blame] | 7811 | auto session_deps = std::make_unique<SpdySessionDependencies>(); |
| 7812 | session_deps->enable_websocket_over_http2 = true; |
Bence Béky | 7a4836c | 2018-05-08 03:52:48 | [diff] [blame] | 7813 | NormalSpdyTransactionHelper helper(request_, HIGHEST, log_, |
Bence Béky | 8bfacd4 | 2018-02-23 13:05:13 | [diff] [blame] | 7814 | std::move(session_deps)); |
| 7815 | helper.RunPreTestSetup(); |
| 7816 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7817 | spdy::SpdySerializedFrame req( |
| 7818 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, HIGHEST)); |
| 7819 | spdy::SpdySerializedFrame settings_ack(spdy_util_.ConstructSpdySettingsAck()); |
Bence Béky | 8bfacd4 | 2018-02-23 13:05:13 | [diff] [blame] | 7820 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7821 | spdy::SpdyHeaderBlock websocket_request_headers; |
| 7822 | websocket_request_headers[spdy::kHttp2MethodHeader] = "CONNECT"; |
| 7823 | websocket_request_headers[spdy::kHttp2AuthorityHeader] = "www.example.org"; |
| 7824 | websocket_request_headers[spdy::kHttp2SchemeHeader] = "https"; |
| 7825 | websocket_request_headers[spdy::kHttp2PathHeader] = "/"; |
| 7826 | websocket_request_headers[spdy::kHttp2ProtocolHeader] = "websocket"; |
Bence Béky | 8bfacd4 | 2018-02-23 13:05:13 | [diff] [blame] | 7827 | websocket_request_headers["origin"] = "http://www.example.org"; |
| 7828 | websocket_request_headers["sec-websocket-version"] = "13"; |
| 7829 | websocket_request_headers["sec-websocket-extensions"] = |
| 7830 | "permessage-deflate; client_max_window_bits"; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7831 | spdy::SpdySerializedFrame websocket_request(spdy_util_.ConstructSpdyHeaders( |
Bence Béky | 7a4836c | 2018-05-08 03:52:48 | [diff] [blame] | 7832 | 3, std::move(websocket_request_headers), MEDIUM, false)); |
| 7833 | |
Bence Béky | 73b8529 | 2018-06-14 04:56:43 | [diff] [blame] | 7834 | spdy::SpdySerializedFrame priority1( |
| 7835 | spdy_util_.ConstructSpdyPriority(3, 0, MEDIUM, true)); |
| 7836 | spdy::SpdySerializedFrame priority2( |
| 7837 | spdy_util_.ConstructSpdyPriority(1, 3, LOWEST, true)); |
| 7838 | |
| 7839 | MockWrite writes[] = { |
| 7840 | CreateMockWrite(req, 0), CreateMockWrite(settings_ack, 2), |
| 7841 | CreateMockWrite(websocket_request, 4), CreateMockWrite(priority1, 5), |
| 7842 | CreateMockWrite(priority2, 6)}; |
Bence Béky | 8bfacd4 | 2018-02-23 13:05:13 | [diff] [blame] | 7843 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7844 | spdy::SettingsMap settings; |
| 7845 | settings[spdy::SETTINGS_ENABLE_CONNECT_PROTOCOL] = 1; |
| 7846 | spdy::SpdySerializedFrame settings_frame( |
Bence Béky | 8bfacd4 | 2018-02-23 13:05:13 | [diff] [blame] | 7847 | spdy_util_.ConstructSpdySettings(settings)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7848 | spdy::SpdySerializedFrame resp1( |
| 7849 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 7850 | spdy::SpdySerializedFrame body1(spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 7851 | spdy::SpdySerializedFrame websocket_response( |
Bence Béky | 8bfacd4 | 2018-02-23 13:05:13 | [diff] [blame] | 7852 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 3)); |
Bence Béky | 73b8529 | 2018-06-14 04:56:43 | [diff] [blame] | 7853 | MockRead reads[] = {CreateMockRead(settings_frame, 1), |
| 7854 | CreateMockRead(resp1, 3), CreateMockRead(body1, 7), |
| 7855 | CreateMockRead(websocket_response, 8), |
| 7856 | MockRead(ASYNC, 0, 9)}; |
Bence Béky | 8bfacd4 | 2018-02-23 13:05:13 | [diff] [blame] | 7857 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 7858 | SequencedSocketData data(reads, writes); |
Bence Béky | 8bfacd4 | 2018-02-23 13:05:13 | [diff] [blame] | 7859 | helper.AddData(&data); |
| 7860 | |
| 7861 | TestCompletionCallback callback1; |
Bence Béky | 7a4836c | 2018-05-08 03:52:48 | [diff] [blame] | 7862 | int rv = helper.trans()->Start(&request_, callback1.callback(), log_); |
Bence Béky | 8bfacd4 | 2018-02-23 13:05:13 | [diff] [blame] | 7863 | ASSERT_THAT(rv, IsError(ERR_IO_PENDING)); |
Bence Béky | 8bfacd4 | 2018-02-23 13:05:13 | [diff] [blame] | 7864 | |
Bence Béky | 7a4836c | 2018-05-08 03:52:48 | [diff] [blame] | 7865 | // Create HTTP/2 connection. |
| 7866 | base::RunLoop().RunUntilIdle(); |
Bence Béky | 8bfacd4 | 2018-02-23 13:05:13 | [diff] [blame] | 7867 | |
| 7868 | SpdySessionKey key(HostPortPair::FromURL(request_.url), ProxyServer::Direct(), |
Matt Menke | 2436b2f | 2018-12-11 18:07:11 | [diff] [blame] | 7869 | PRIVACY_MODE_DISABLED, |
| 7870 | SpdySessionKey::IsProxySession::kFalse, SocketTag()); |
Bence Béky | 8bfacd4 | 2018-02-23 13:05:13 | [diff] [blame] | 7871 | base::WeakPtr<SpdySession> spdy_session = |
| 7872 | helper.session()->spdy_session_pool()->FindAvailableSession( |
| 7873 | key, /* enable_ip_based_pooling = */ true, |
| 7874 | /* is_websocket = */ true, log_); |
| 7875 | ASSERT_TRUE(spdy_session); |
| 7876 | EXPECT_TRUE(spdy_session->support_websocket()); |
| 7877 | |
| 7878 | HttpRequestInfo request2; |
| 7879 | request2.method = "GET"; |
| 7880 | request2.url = GURL("wss://www.example.org/"); |
| 7881 | request2.traffic_annotation = |
| 7882 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
| 7883 | EXPECT_TRUE(HostPortPair::FromURL(request_.url) |
| 7884 | .Equals(HostPortPair::FromURL(request2.url))); |
| 7885 | request2.extra_headers.SetHeader("Origin", "http://www.example.org"); |
| 7886 | request2.extra_headers.SetHeader("Sec-WebSocket-Version", "13"); |
| 7887 | // The following two headers must be removed by WebSocketHttp2HandshakeStream. |
| 7888 | request2.extra_headers.SetHeader("Connection", "Upgrade"); |
| 7889 | request2.extra_headers.SetHeader("Upgrade", "websocket"); |
| 7890 | |
| 7891 | TestWebSocketHandshakeStreamCreateHelper websocket_stream_create_helper; |
| 7892 | |
Bence Béky | 7a4836c | 2018-05-08 03:52:48 | [diff] [blame] | 7893 | HttpNetworkTransaction trans2(MEDIUM, helper.session()); |
Bence Béky | 8bfacd4 | 2018-02-23 13:05:13 | [diff] [blame] | 7894 | trans2.SetWebSocketHandshakeStreamCreateHelper( |
| 7895 | &websocket_stream_create_helper); |
| 7896 | |
| 7897 | TestCompletionCallback callback2; |
| 7898 | rv = trans2.Start(&request2, callback2.callback(), log_); |
| 7899 | ASSERT_THAT(rv, IsError(ERR_IO_PENDING)); |
Bence Béky | 7a4836c | 2018-05-08 03:52:48 | [diff] [blame] | 7900 | |
| 7901 | // Create WebSocket stream. |
| 7902 | base::RunLoop().RunUntilIdle(); |
Bence Béky | 73b8529 | 2018-06-14 04:56:43 | [diff] [blame] | 7903 | ASSERT_TRUE(spdy_session); |
| 7904 | |
| 7905 | // First request has HIGHEST priority, WebSocket request has MEDIUM priority. |
| 7906 | // Changing the priority of the first request to LOWEST changes their order, |
| 7907 | // and therefore triggers sending PRIORITY frames. |
| 7908 | helper.trans()->SetPriority(LOWEST); |
Bence Béky | 7a4836c | 2018-05-08 03:52:48 | [diff] [blame] | 7909 | |
| 7910 | rv = callback1.WaitForResult(); |
| 7911 | ASSERT_THAT(rv, IsOk()); |
| 7912 | |
| 7913 | const HttpResponseInfo* response = helper.trans()->GetResponseInfo(); |
| 7914 | ASSERT_TRUE(response->headers); |
| 7915 | EXPECT_TRUE(response->was_fetched_via_spdy); |
| 7916 | EXPECT_EQ("HTTP/1.1 200", response->headers->GetStatusLine()); |
| 7917 | |
| 7918 | std::string response_data; |
| 7919 | rv = ReadTransaction(helper.trans(), &response_data); |
| 7920 | EXPECT_THAT(rv, IsOk()); |
| 7921 | EXPECT_EQ("hello!", response_data); |
| 7922 | |
Bence Béky | 8bfacd4 | 2018-02-23 13:05:13 | [diff] [blame] | 7923 | rv = callback2.WaitForResult(); |
| 7924 | ASSERT_THAT(rv, IsOk()); |
| 7925 | |
Bence Béky | 8bfacd4 | 2018-02-23 13:05:13 | [diff] [blame] | 7926 | helper.VerifyDataConsumed(); |
Bence Béky | b09dddf1 | 2018-07-31 18:52:04 | [diff] [blame] | 7927 | |
| 7928 | // Server advertised WebSocket support. |
| 7929 | histogram_tester.ExpectUniqueSample("Net.SpdySession.ServerSupportsWebSocket", |
| 7930 | /* support_websocket = true */ 1, |
| 7931 | /* expected_count = */ 1); |
Bence Béky | 8bfacd4 | 2018-02-23 13:05:13 | [diff] [blame] | 7932 | } |
| 7933 | |
Bence Béky | fbeb883 | 2018-04-05 23:19:56 | [diff] [blame] | 7934 | TEST_F(SpdyNetworkTransactionTest, WebSocketNegotiatesHttp2) { |
| 7935 | HttpRequestInfo request; |
| 7936 | request.method = "GET"; |
| 7937 | request.url = GURL("wss://www.example.org/"); |
| 7938 | request.traffic_annotation = |
| 7939 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
| 7940 | EXPECT_TRUE(HostPortPair::FromURL(request_.url) |
| 7941 | .Equals(HostPortPair::FromURL(request.url))); |
| 7942 | request.extra_headers.SetHeader("Connection", "Upgrade"); |
| 7943 | request.extra_headers.SetHeader("Upgrade", "websocket"); |
| 7944 | request.extra_headers.SetHeader("Origin", "http://www.example.org"); |
| 7945 | request.extra_headers.SetHeader("Sec-WebSocket-Version", "13"); |
| 7946 | |
| 7947 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
| 7948 | helper.RunPreTestSetup(); |
| 7949 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 7950 | StaticSocketDataProvider data; |
Bence Béky | fbeb883 | 2018-04-05 23:19:56 | [diff] [blame] | 7951 | |
| 7952 | auto ssl_provider = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
| 7953 | // Test that request has empty |alpn_protos|, that is, HTTP/2 is disabled. |
| 7954 | ssl_provider->next_protos_expected_in_ssl_config = NextProtoVector{}; |
Bence Béky | b4a07f8f | 2018-05-17 14:31:55 | [diff] [blame] | 7955 | // Force socket to use HTTP/2, which should never happen (TLS implementation |
| 7956 | // should fail TLS handshake if server chooses HTTP/2 without client |
| 7957 | // advertising support). |
Bence Béky | fbeb883 | 2018-04-05 23:19:56 | [diff] [blame] | 7958 | ssl_provider->next_proto = kProtoHTTP2; |
| 7959 | ssl_provider->ssl_info.cert = |
| 7960 | ImportCertFromFile(GetTestCertsDirectory(), "spdy_pooling.pem"); |
| 7961 | helper.AddDataWithSSLSocketDataProvider(&data, std::move(ssl_provider)); |
| 7962 | |
| 7963 | HttpNetworkTransaction* trans = helper.trans(); |
| 7964 | TestWebSocketHandshakeStreamCreateHelper websocket_stream_create_helper; |
| 7965 | trans->SetWebSocketHandshakeStreamCreateHelper( |
| 7966 | &websocket_stream_create_helper); |
| 7967 | |
| 7968 | TestCompletionCallback callback; |
| 7969 | int rv = trans->Start(&request, callback.callback(), log_); |
| 7970 | ASSERT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 7971 | rv = callback.WaitForResult(); |
| 7972 | ASSERT_THAT(rv, IsError(ERR_NOT_IMPLEMENTED)); |
| 7973 | |
| 7974 | helper.VerifyDataConsumed(); |
| 7975 | } |
| 7976 | |
Bence Béky | 420bb2d | 2018-03-30 17:25:26 | [diff] [blame] | 7977 | // Plaintext WebSocket over HTTP/2 is not implemented, see |
| 7978 | // https://crbug.com/684681. |
| 7979 | TEST_F(SpdyNetworkTransactionTest, PlaintextWebSocketOverHttp2Proxy) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7980 | spdy::SpdySerializedFrame req(spdy_util_.ConstructSpdyConnect( |
Matt Menke | 6e879bd | 2019-03-18 17:26:04 | [diff] [blame] | 7981 | nullptr, 0, 1, HttpProxyConnectJob::kH2QuicTunnelPriority, |
| 7982 | HostPortPair("www.example.org", 80))); |
Bence Béky | 420bb2d | 2018-03-30 17:25:26 | [diff] [blame] | 7983 | MockWrite writes[] = {CreateMockWrite(req, 0)}; |
| 7984 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7985 | spdy::SpdySerializedFrame resp( |
| 7986 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
Bence Béky | 420bb2d | 2018-03-30 17:25:26 | [diff] [blame] | 7987 | MockRead reads[] = {CreateMockRead(resp, 1), MockRead(ASYNC, 0, 2)}; |
| 7988 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 7989 | SequencedSocketData data(reads, writes); |
Bence Béky | 420bb2d | 2018-03-30 17:25:26 | [diff] [blame] | 7990 | |
| 7991 | request_.url = GURL("ws://www.example.org/"); |
| 7992 | auto session_deps = std::make_unique<SpdySessionDependencies>( |
| 7993 | ProxyResolutionService::CreateFixed("https://proxy:70", |
| 7994 | TRAFFIC_ANNOTATION_FOR_TESTS)); |
| 7995 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
| 7996 | std::move(session_deps)); |
| 7997 | helper.RunPreTestSetup(); |
| 7998 | helper.AddData(&data); |
| 7999 | |
| 8000 | HttpNetworkTransaction* trans = helper.trans(); |
| 8001 | TestWebSocketHandshakeStreamCreateHelper websocket_stream_create_helper; |
| 8002 | trans->SetWebSocketHandshakeStreamCreateHelper( |
| 8003 | &websocket_stream_create_helper); |
| 8004 | |
| 8005 | EXPECT_TRUE(helper.StartDefaultTest()); |
| 8006 | helper.WaitForCallbackToComplete(); |
| 8007 | EXPECT_THAT(helper.output().rv, IsError(ERR_NOT_IMPLEMENTED)); |
| 8008 | |
| 8009 | helper.VerifyDataConsumed(); |
| 8010 | } |
| 8011 | |
Bence Béky | 6434d5e | 2018-04-03 13:43:11 | [diff] [blame] | 8012 | // Regression test for https://crbug.com/819101. Open two identical plaintext |
Xida Chen | 9bfe0b6 | 2018-04-24 19:52:21 | [diff] [blame] | 8013 | // websocket requests over proxy. The HttpStreamFactory::Job for the second |
Bence Béky | 6434d5e | 2018-04-03 13:43:11 | [diff] [blame] | 8014 | // request should reuse the first connection. |
| 8015 | TEST_F(SpdyNetworkTransactionTest, TwoWebSocketRequestsOverHttp2Proxy) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8016 | spdy::SpdySerializedFrame req(spdy_util_.ConstructSpdyConnect( |
Matt Menke | 6e879bd | 2019-03-18 17:26:04 | [diff] [blame] | 8017 | nullptr, 0, 1, HttpProxyConnectJob::kH2QuicTunnelPriority, |
| 8018 | HostPortPair("www.example.org", 80))); |
Bence Béky | 6434d5e | 2018-04-03 13:43:11 | [diff] [blame] | 8019 | MockWrite writes[] = {CreateMockWrite(req, 0)}; |
| 8020 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8021 | spdy::SpdySerializedFrame resp( |
| 8022 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
Bence Béky | 6434d5e | 2018-04-03 13:43:11 | [diff] [blame] | 8023 | MockRead reads[] = {CreateMockRead(resp, 1), |
| 8024 | MockRead(ASYNC, ERR_IO_PENDING, 2), |
| 8025 | MockRead(ASYNC, 0, 3)}; |
| 8026 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 8027 | SequencedSocketData data(reads, writes); |
Bence Béky | 6434d5e | 2018-04-03 13:43:11 | [diff] [blame] | 8028 | |
| 8029 | request_.url = GURL("ws://www.example.org/"); |
| 8030 | auto session_deps = std::make_unique<SpdySessionDependencies>( |
| 8031 | ProxyResolutionService::CreateFixed("https://proxy:70", |
| 8032 | TRAFFIC_ANNOTATION_FOR_TESTS)); |
| 8033 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
| 8034 | std::move(session_deps)); |
| 8035 | helper.RunPreTestSetup(); |
| 8036 | helper.AddData(&data); |
| 8037 | |
| 8038 | HttpNetworkTransaction* trans1 = helper.trans(); |
| 8039 | TestWebSocketHandshakeStreamCreateHelper websocket_stream_create_helper; |
| 8040 | trans1->SetWebSocketHandshakeStreamCreateHelper( |
| 8041 | &websocket_stream_create_helper); |
| 8042 | |
| 8043 | EXPECT_TRUE(helper.StartDefaultTest()); |
| 8044 | helper.WaitForCallbackToComplete(); |
| 8045 | EXPECT_THAT(helper.output().rv, IsError(ERR_NOT_IMPLEMENTED)); |
| 8046 | |
| 8047 | HttpNetworkTransaction trans2(DEFAULT_PRIORITY, helper.session()); |
| 8048 | trans2.SetWebSocketHandshakeStreamCreateHelper( |
| 8049 | &websocket_stream_create_helper); |
| 8050 | |
| 8051 | TestCompletionCallback callback2; |
| 8052 | int rv = trans2.Start(&request_, callback2.callback(), log_); |
| 8053 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 8054 | |
| 8055 | rv = callback2.WaitForResult(); |
| 8056 | EXPECT_THAT(rv, IsError(ERR_NOT_IMPLEMENTED)); |
| 8057 | |
| 8058 | data.Resume(); |
| 8059 | base::RunLoop().RunUntilIdle(); |
| 8060 | |
| 8061 | helper.VerifyDataConsumed(); |
| 8062 | } |
| 8063 | |
Bence Béky | 420bb2d | 2018-03-30 17:25:26 | [diff] [blame] | 8064 | TEST_F(SpdyNetworkTransactionTest, SecureWebSocketOverHttp2Proxy) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8065 | spdy::SpdySerializedFrame connect_request(spdy_util_.ConstructSpdyConnect( |
Matt Menke | 6e879bd | 2019-03-18 17:26:04 | [diff] [blame] | 8066 | nullptr, 0, 1, HttpProxyConnectJob::kH2QuicTunnelPriority, |
| 8067 | HostPortPair("www.example.org", 443))); |
Bence Béky | 420bb2d | 2018-03-30 17:25:26 | [diff] [blame] | 8068 | const char kWebSocketRequest[] = |
| 8069 | "GET / HTTP/1.1\r\n" |
| 8070 | "Host: www.example.org\r\n" |
| 8071 | "Connection: Upgrade\r\n" |
| 8072 | "Upgrade: websocket\r\n" |
| 8073 | "Origin: http://www.example.org\r\n" |
| 8074 | "Sec-WebSocket-Version: 13\r\n" |
| 8075 | "Sec-WebSocket-Key: dGhlIHNhbXBsZSBub25jZQ==\r\n" |
| 8076 | "Sec-WebSocket-Extensions: permessage-deflate; " |
| 8077 | "client_max_window_bits\r\n\r\n"; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8078 | spdy::SpdySerializedFrame websocket_request( |
Bence Béky | 420bb2d | 2018-03-30 17:25:26 | [diff] [blame] | 8079 | spdy_util_.ConstructSpdyDataFrame(1, kWebSocketRequest, false)); |
| 8080 | MockWrite writes[] = {CreateMockWrite(connect_request, 0), |
| 8081 | CreateMockWrite(websocket_request, 2)}; |
| 8082 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8083 | spdy::SpdySerializedFrame connect_response( |
Bence Béky | 420bb2d | 2018-03-30 17:25:26 | [diff] [blame] | 8084 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 8085 | const char kWebSocketResponse[] = |
| 8086 | "HTTP/1.1 101 Switching Protocols\r\n" |
| 8087 | "Upgrade: websocket\r\n" |
| 8088 | "Connection: Upgrade\r\n" |
| 8089 | "Sec-WebSocket-Accept: s3pPLMBiTxaQ9kYGzzhZRbK+xOo=\r\n\r\n"; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8090 | spdy::SpdySerializedFrame websocket_response( |
Bence Béky | 420bb2d | 2018-03-30 17:25:26 | [diff] [blame] | 8091 | spdy_util_.ConstructSpdyDataFrame(1, kWebSocketResponse, false)); |
| 8092 | MockRead reads[] = {CreateMockRead(connect_response, 1), |
| 8093 | CreateMockRead(websocket_response, 3), |
| 8094 | MockRead(ASYNC, 0, 4)}; |
| 8095 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 8096 | SequencedSocketData data(reads, writes); |
Bence Béky | 420bb2d | 2018-03-30 17:25:26 | [diff] [blame] | 8097 | |
| 8098 | request_.url = GURL("wss://www.example.org/"); |
| 8099 | request_.extra_headers.SetHeader("Connection", "Upgrade"); |
| 8100 | request_.extra_headers.SetHeader("Upgrade", "websocket"); |
| 8101 | request_.extra_headers.SetHeader("Origin", "http://www.example.org"); |
| 8102 | request_.extra_headers.SetHeader("Sec-WebSocket-Version", "13"); |
| 8103 | auto session_deps = std::make_unique<SpdySessionDependencies>( |
| 8104 | ProxyResolutionService::CreateFixed("https://proxy:70", |
| 8105 | TRAFFIC_ANNOTATION_FOR_TESTS)); |
| 8106 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
| 8107 | std::move(session_deps)); |
| 8108 | helper.RunPreTestSetup(); |
| 8109 | helper.AddData(&data); |
| 8110 | |
| 8111 | // Add SSL data for the tunneled connection. |
| 8112 | SSLSocketDataProvider ssl_provider(ASYNC, OK); |
| 8113 | ssl_provider.ssl_info.cert = |
| 8114 | ImportCertFromFile(GetTestCertsDirectory(), "wildcard.pem"); |
Bence Béky | 12943c6 | 2018-04-05 19:16:50 | [diff] [blame] | 8115 | // A WebSocket request should not advertise HTTP/2 support. |
| 8116 | ssl_provider.next_protos_expected_in_ssl_config = NextProtoVector{}; |
Bence Béky | 420bb2d | 2018-03-30 17:25:26 | [diff] [blame] | 8117 | // This test uses WebSocket over HTTP/1.1. |
| 8118 | ssl_provider.next_proto = kProtoHTTP11; |
| 8119 | helper.session_deps()->socket_factory->AddSSLSocketDataProvider( |
| 8120 | &ssl_provider); |
| 8121 | |
| 8122 | HttpNetworkTransaction* trans = helper.trans(); |
| 8123 | TestWebSocketHandshakeStreamCreateHelper websocket_stream_create_helper; |
| 8124 | trans->SetWebSocketHandshakeStreamCreateHelper( |
| 8125 | &websocket_stream_create_helper); |
| 8126 | |
| 8127 | EXPECT_TRUE(helper.StartDefaultTest()); |
| 8128 | helper.WaitForCallbackToComplete(); |
| 8129 | EXPECT_THAT(helper.output().rv, IsOk()); |
| 8130 | const HttpResponseInfo* response = trans->GetResponseInfo(); |
| 8131 | ASSERT_TRUE(response); |
| 8132 | EXPECT_EQ(HttpResponseInfo::CONNECTION_INFO_HTTP1_1, |
| 8133 | response->connection_info); |
| 8134 | EXPECT_TRUE(response->was_alpn_negotiated); |
| 8135 | EXPECT_FALSE(response->was_fetched_via_spdy); |
Tsuyoshi Horo | 01faed6 | 2019-02-20 22:11:37 | [diff] [blame] | 8136 | EXPECT_EQ(70, response->remote_endpoint.port()); |
Bence Béky | 420bb2d | 2018-03-30 17:25:26 | [diff] [blame] | 8137 | ASSERT_TRUE(response->headers); |
| 8138 | EXPECT_EQ("HTTP/1.1 101 Switching Protocols", |
| 8139 | response->headers->GetStatusLine()); |
| 8140 | |
| 8141 | base::RunLoop().RunUntilIdle(); |
| 8142 | helper.VerifyDataConsumed(); |
| 8143 | } |
| 8144 | |
Bence Béky | 12943c6 | 2018-04-05 19:16:50 | [diff] [blame] | 8145 | // Regression test for https://crbug.com/828865. |
| 8146 | TEST_F(SpdyNetworkTransactionTest, |
| 8147 | SecureWebSocketOverHttp2ProxyNegotiatesHttp2) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8148 | spdy::SpdySerializedFrame connect_request(spdy_util_.ConstructSpdyConnect( |
Matt Menke | 6e879bd | 2019-03-18 17:26:04 | [diff] [blame] | 8149 | nullptr, 0, 1, HttpProxyConnectJob::kH2QuicTunnelPriority, |
| 8150 | HostPortPair("www.example.org", 443))); |
Bence Béky | 12943c6 | 2018-04-05 19:16:50 | [diff] [blame] | 8151 | MockWrite writes[] = {CreateMockWrite(connect_request, 0)}; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8152 | spdy::SpdySerializedFrame connect_response( |
Bence Béky | 12943c6 | 2018-04-05 19:16:50 | [diff] [blame] | 8153 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 8154 | MockRead reads[] = {CreateMockRead(connect_response, 1), |
| 8155 | MockRead(ASYNC, 0, 2)}; |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 8156 | SequencedSocketData data(reads, writes); |
Bence Béky | 12943c6 | 2018-04-05 19:16:50 | [diff] [blame] | 8157 | |
| 8158 | request_.url = GURL("wss://www.example.org/"); |
| 8159 | request_.extra_headers.SetHeader("Connection", "Upgrade"); |
| 8160 | request_.extra_headers.SetHeader("Upgrade", "websocket"); |
| 8161 | request_.extra_headers.SetHeader("Origin", "http://www.example.org"); |
| 8162 | request_.extra_headers.SetHeader("Sec-WebSocket-Version", "13"); |
| 8163 | auto session_deps = std::make_unique<SpdySessionDependencies>( |
| 8164 | ProxyResolutionService::CreateFixed("https://proxy:70", |
| 8165 | TRAFFIC_ANNOTATION_FOR_TESTS)); |
| 8166 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
| 8167 | std::move(session_deps)); |
| 8168 | helper.RunPreTestSetup(); |
| 8169 | helper.AddData(&data); |
| 8170 | |
| 8171 | // Add SSL data for the tunneled connection. |
| 8172 | SSLSocketDataProvider ssl_provider(ASYNC, OK); |
| 8173 | ssl_provider.ssl_info.cert = |
| 8174 | ImportCertFromFile(GetTestCertsDirectory(), "wildcard.pem"); |
| 8175 | // A WebSocket request should not advertise HTTP/2 support. |
| 8176 | ssl_provider.next_protos_expected_in_ssl_config = NextProtoVector{}; |
| 8177 | // The server should not negotiate HTTP/2 over the tunnelled connection, |
| 8178 | // but it must be handled gracefully if it does. |
| 8179 | ssl_provider.next_proto = kProtoHTTP2; |
| 8180 | helper.session_deps()->socket_factory->AddSSLSocketDataProvider( |
| 8181 | &ssl_provider); |
| 8182 | |
| 8183 | HttpNetworkTransaction* trans = helper.trans(); |
| 8184 | TestWebSocketHandshakeStreamCreateHelper websocket_stream_create_helper; |
| 8185 | trans->SetWebSocketHandshakeStreamCreateHelper( |
| 8186 | &websocket_stream_create_helper); |
| 8187 | |
| 8188 | EXPECT_TRUE(helper.StartDefaultTest()); |
| 8189 | helper.WaitForCallbackToComplete(); |
| 8190 | EXPECT_THAT(helper.output().rv, IsError(ERR_NOT_IMPLEMENTED)); |
| 8191 | |
| 8192 | base::RunLoop().RunUntilIdle(); |
| 8193 | helper.VerifyDataConsumed(); |
| 8194 | } |
| 8195 | |
Bence Béky | 0ca719f | 2018-01-31 13:41:19 | [diff] [blame] | 8196 | #endif // BUILDFLAG(ENABLE_WEBSOCKETS) |
| 8197 | |
Steven Valdez | 1c185917 | 2019-04-10 15:33:28 | [diff] [blame^] | 8198 | TEST_F(SpdyNetworkTransactionTest, ZeroRTTDoesntConfirm) { |
| 8199 | spdy::SpdySerializedFrame req( |
| 8200 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 8201 | MockWrite writes[] = {CreateMockWrite(req, 0)}; |
| 8202 | |
| 8203 | spdy::SpdySerializedFrame resp( |
| 8204 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 8205 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 8206 | MockRead reads[] = { |
| 8207 | CreateMockRead(resp, 1), CreateMockRead(body, 2), |
| 8208 | MockRead(ASYNC, 0, 3) // EOF |
| 8209 | }; |
| 8210 | |
| 8211 | SequencedSocketData data(reads, writes); |
| 8212 | auto session_deps = std::make_unique<SpdySessionDependencies>(); |
| 8213 | session_deps->enable_early_data = true; |
| 8214 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
| 8215 | std::move(session_deps)); |
| 8216 | auto ssl_provider = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
| 8217 | // Configure |ssl_provider| to fail if ConfirmHandshake is called. The request |
| 8218 | // should still succeed. |
| 8219 | ssl_provider->confirm = MockConfirm(SYNCHRONOUS, ERR_SSL_PROTOCOL_ERROR); |
| 8220 | helper.RunToCompletionWithSSLData(&data, std::move(ssl_provider)); |
| 8221 | TransactionHelperResult out = helper.output(); |
| 8222 | EXPECT_THAT(out.rv, IsOk()); |
| 8223 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
| 8224 | EXPECT_EQ("hello!", out.response_data); |
| 8225 | } |
| 8226 | |
| 8227 | // Run multiple concurrent streams that don't require handshake confirmation. |
| 8228 | TEST_F(SpdyNetworkTransactionTest, ZeroRTTNoConfirmMultipleStreams) { |
| 8229 | spdy::SpdySerializedFrame req1( |
| 8230 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 8231 | spdy::SpdySerializedFrame req2( |
| 8232 | spdy_util_.ConstructSpdyGet(nullptr, 0, 3, LOWEST)); |
| 8233 | MockWrite writes1[] = {CreateMockWrite(req1, 0), CreateMockWrite(req2, 3)}; |
| 8234 | |
| 8235 | spdy::SpdySerializedFrame resp1( |
| 8236 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 8237 | spdy::SpdySerializedFrame body1(spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 8238 | spdy::SpdySerializedFrame resp2( |
| 8239 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 3)); |
| 8240 | spdy::SpdySerializedFrame body2(spdy_util_.ConstructSpdyDataFrame(3, true)); |
| 8241 | MockRead reads1[] = { |
| 8242 | CreateMockRead(resp1, 1), CreateMockRead(body1, 2), |
| 8243 | CreateMockRead(resp2, 4), CreateMockRead(body2, 5), |
| 8244 | MockRead(ASYNC, 0, 6) // EOF |
| 8245 | }; |
| 8246 | |
| 8247 | SequencedSocketData data1(reads1, writes1); |
| 8248 | SequencedSocketData data2({}, {}); |
| 8249 | auto session_deps = std::make_unique<SpdySessionDependencies>(); |
| 8250 | session_deps->enable_early_data = true; |
| 8251 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
| 8252 | std::move(session_deps)); |
| 8253 | auto ssl_provider1 = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
| 8254 | ssl_provider1->confirm = MockConfirm(SYNCHRONOUS, ERR_SSL_PROTOCOL_ERROR); |
| 8255 | auto ssl_provider2 = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
| 8256 | ssl_provider2->confirm = MockConfirm(SYNCHRONOUS, ERR_SSL_PROTOCOL_ERROR); |
| 8257 | |
| 8258 | helper.RunPreTestSetup(); |
| 8259 | helper.AddDataWithSSLSocketDataProvider(&data1, std::move(ssl_provider1)); |
| 8260 | helper.AddDataWithSSLSocketDataProvider(&data2, std::move(ssl_provider2)); |
| 8261 | EXPECT_TRUE(helper.StartDefaultTest()); |
| 8262 | |
| 8263 | HttpNetworkTransaction trans2(DEFAULT_PRIORITY, helper.session()); |
| 8264 | HttpRequestInfo request2; |
| 8265 | request2.method = "GET"; |
| 8266 | request2.url = GURL(kDefaultUrl); |
| 8267 | request2.traffic_annotation = |
| 8268 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
| 8269 | TestCompletionCallback callback2; |
| 8270 | int rv = trans2.Start(&request2, callback2.callback(), log_); |
| 8271 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 8272 | |
| 8273 | helper.FinishDefaultTest(); |
| 8274 | EXPECT_THAT(callback2.GetResult(ERR_IO_PENDING), IsOk()); |
| 8275 | helper.VerifyDataConsumed(); |
| 8276 | |
| 8277 | TransactionHelperResult out = helper.output(); |
| 8278 | EXPECT_THAT(out.rv, IsOk()); |
| 8279 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
| 8280 | EXPECT_EQ("hello!", out.response_data); |
| 8281 | } |
| 8282 | |
| 8283 | // Run multiple concurrent streams that require handshake confirmation. |
| 8284 | TEST_F(SpdyNetworkTransactionTest, ZeroRTTConfirmMultipleStreams) { |
| 8285 | spdy::SpdyHeaderBlock req_block1( |
| 8286 | spdy_util_.ConstructPostHeaderBlock(kDefaultUrl, 0)); |
| 8287 | spdy::SpdySerializedFrame req1( |
| 8288 | spdy_util_.ConstructSpdyHeaders(1, std::move(req_block1), LOWEST, true)); |
| 8289 | spdy::SpdyHeaderBlock req_block2( |
| 8290 | spdy_util_.ConstructPostHeaderBlock(kDefaultUrl, 0)); |
| 8291 | spdy::SpdySerializedFrame req2( |
| 8292 | spdy_util_.ConstructSpdyHeaders(3, std::move(req_block2), LOWEST, true)); |
| 8293 | MockWrite writes[] = { |
| 8294 | CreateMockWrite(req1, 0), |
| 8295 | CreateMockWrite(req2, 3), |
| 8296 | }; |
| 8297 | spdy::SpdySerializedFrame resp1( |
| 8298 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 8299 | spdy::SpdySerializedFrame body1(spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 8300 | spdy::SpdySerializedFrame resp2( |
| 8301 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 3)); |
| 8302 | spdy::SpdySerializedFrame body2(spdy_util_.ConstructSpdyDataFrame(3, true)); |
| 8303 | MockRead reads[] = { |
| 8304 | CreateMockRead(resp1, 1), CreateMockRead(body1, 2), |
| 8305 | CreateMockRead(resp2, 4), CreateMockRead(body2, 5), |
| 8306 | MockRead(ASYNC, 0, 6) // EOF |
| 8307 | }; |
| 8308 | |
| 8309 | SequencedSocketData data1(reads, writes); |
| 8310 | SequencedSocketData data2({}, {}); |
| 8311 | UsePostRequest(); |
| 8312 | auto session_deps = std::make_unique<SpdySessionDependencies>(); |
| 8313 | session_deps->enable_early_data = true; |
| 8314 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
| 8315 | std::move(session_deps)); |
| 8316 | auto ssl_provider1 = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
| 8317 | ssl_provider1->confirm = MockConfirm(ASYNC, OK); |
| 8318 | auto ssl_provider2 = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
| 8319 | ssl_provider2->confirm = MockConfirm(ASYNC, OK); |
| 8320 | |
| 8321 | helper.RunPreTestSetup(); |
| 8322 | helper.AddDataWithSSLSocketDataProvider(&data1, std::move(ssl_provider1)); |
| 8323 | helper.AddDataWithSSLSocketDataProvider(&data2, std::move(ssl_provider2)); |
| 8324 | |
| 8325 | HttpNetworkTransaction trans1(DEFAULT_PRIORITY, helper.session()); |
| 8326 | HttpRequestInfo request1; |
| 8327 | request1.method = "POST"; |
| 8328 | request1.url = GURL(kDefaultUrl); |
| 8329 | request1.traffic_annotation = |
| 8330 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
| 8331 | TestCompletionCallback callback1; |
| 8332 | int rv = trans1.Start(&request1, callback1.callback(), log_); |
| 8333 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 8334 | |
| 8335 | HttpNetworkTransaction trans2(DEFAULT_PRIORITY, helper.session()); |
| 8336 | HttpRequestInfo request2; |
| 8337 | request2.method = "POST"; |
| 8338 | request2.url = GURL(kDefaultUrl); |
| 8339 | request2.traffic_annotation = |
| 8340 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
| 8341 | TestCompletionCallback callback2; |
| 8342 | rv = trans2.Start(&request2, callback2.callback(), log_); |
| 8343 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 8344 | |
| 8345 | EXPECT_THAT(callback1.GetResult(ERR_IO_PENDING), IsOk()); |
| 8346 | EXPECT_THAT(callback2.GetResult(ERR_IO_PENDING), IsOk()); |
| 8347 | |
| 8348 | const HttpResponseInfo* response1 = trans1.GetResponseInfo(); |
| 8349 | ASSERT_TRUE(response1); |
| 8350 | ASSERT_TRUE(response1->headers); |
| 8351 | EXPECT_EQ(HttpResponseInfo::CONNECTION_INFO_HTTP2, |
| 8352 | response1->connection_info); |
| 8353 | EXPECT_EQ("HTTP/1.1 200", response1->headers->GetStatusLine()); |
| 8354 | std::string response_data; |
| 8355 | ReadTransaction(&trans1, &response_data); |
| 8356 | EXPECT_EQ("hello!", response_data); |
| 8357 | |
| 8358 | const HttpResponseInfo* response2 = trans2.GetResponseInfo(); |
| 8359 | ASSERT_TRUE(response2); |
| 8360 | ASSERT_TRUE(response2->headers); |
| 8361 | EXPECT_EQ(HttpResponseInfo::CONNECTION_INFO_HTTP2, |
| 8362 | response2->connection_info); |
| 8363 | EXPECT_EQ("HTTP/1.1 200", response2->headers->GetStatusLine()); |
| 8364 | ReadTransaction(&trans2, &response_data); |
| 8365 | EXPECT_EQ("hello!", response_data); |
| 8366 | |
| 8367 | helper.VerifyDataConsumed(); |
| 8368 | } |
| 8369 | |
| 8370 | // Run multiple concurrent streams, the first require a confirmation and the |
| 8371 | // second not requiring confirmation. |
| 8372 | TEST_F(SpdyNetworkTransactionTest, ZeroRTTConfirmNoConfirmStreams) { |
| 8373 | // This test orders the writes such that the GET (no confirmation) is written |
| 8374 | // before the POST (confirmation required). |
| 8375 | spdy::SpdyHeaderBlock req_block1( |
| 8376 | spdy_util_.ConstructGetHeaderBlock(kDefaultUrl)); |
| 8377 | spdy::SpdySerializedFrame req1( |
| 8378 | spdy_util_.ConstructSpdyHeaders(1, std::move(req_block1), LOWEST, true)); |
| 8379 | spdy::SpdyHeaderBlock req_block2( |
| 8380 | spdy_util_.ConstructPostHeaderBlock(kDefaultUrl, 0)); |
| 8381 | spdy::SpdySerializedFrame req2( |
| 8382 | spdy_util_.ConstructSpdyHeaders(3, std::move(req_block2), LOWEST, true)); |
| 8383 | MockWrite writes[] = { |
| 8384 | CreateMockWrite(req1, 0), |
| 8385 | CreateMockWrite(req2, 3), |
| 8386 | }; |
| 8387 | spdy::SpdySerializedFrame resp1( |
| 8388 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 8389 | spdy::SpdySerializedFrame body1(spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 8390 | spdy::SpdySerializedFrame resp2( |
| 8391 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 3)); |
| 8392 | spdy::SpdySerializedFrame body2(spdy_util_.ConstructSpdyDataFrame(3, true)); |
| 8393 | MockRead reads[] = { |
| 8394 | CreateMockRead(resp1, 1), CreateMockRead(body1, 2), |
| 8395 | CreateMockRead(resp2, 4), CreateMockRead(body2, 5), |
| 8396 | MockRead(ASYNC, 0, 6) // EOF |
| 8397 | }; |
| 8398 | |
| 8399 | SequencedSocketData data1(reads, writes); |
| 8400 | SequencedSocketData data2({}, {}); |
| 8401 | UsePostRequest(); |
| 8402 | auto session_deps = std::make_unique<SpdySessionDependencies>(); |
| 8403 | session_deps->enable_early_data = true; |
| 8404 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
| 8405 | std::move(session_deps)); |
| 8406 | auto ssl_provider1 = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
| 8407 | ssl_provider1->confirm = MockConfirm(ASYNC, OK); |
| 8408 | auto ssl_provider2 = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
| 8409 | ssl_provider2->confirm = MockConfirm(ASYNC, OK); |
| 8410 | |
| 8411 | helper.RunPreTestSetup(); |
| 8412 | helper.AddDataWithSSLSocketDataProvider(&data1, std::move(ssl_provider1)); |
| 8413 | helper.AddDataWithSSLSocketDataProvider(&data2, std::move(ssl_provider2)); |
| 8414 | |
| 8415 | // TODO(https://crbug.com/949724): Explicitly verify the ordering of |
| 8416 | // ConfirmHandshake and the second stream. |
| 8417 | |
| 8418 | HttpNetworkTransaction trans1(DEFAULT_PRIORITY, helper.session()); |
| 8419 | HttpRequestInfo request1; |
| 8420 | request1.method = "POST"; |
| 8421 | request1.url = GURL(kDefaultUrl); |
| 8422 | request1.traffic_annotation = |
| 8423 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
| 8424 | TestCompletionCallback callback1; |
| 8425 | int rv = trans1.Start(&request1, callback1.callback(), log_); |
| 8426 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 8427 | |
| 8428 | HttpNetworkTransaction trans2(DEFAULT_PRIORITY, helper.session()); |
| 8429 | HttpRequestInfo request2; |
| 8430 | request2.method = "GET"; |
| 8431 | request2.url = GURL(kDefaultUrl); |
| 8432 | request2.traffic_annotation = |
| 8433 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
| 8434 | TestCompletionCallback callback2; |
| 8435 | rv = trans2.Start(&request2, callback2.callback(), log_); |
| 8436 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 8437 | |
| 8438 | EXPECT_THAT(callback1.GetResult(ERR_IO_PENDING), IsOk()); |
| 8439 | EXPECT_THAT(callback2.GetResult(ERR_IO_PENDING), IsOk()); |
| 8440 | |
| 8441 | const HttpResponseInfo* response1 = trans1.GetResponseInfo(); |
| 8442 | ASSERT_TRUE(response1); |
| 8443 | ASSERT_TRUE(response1->headers); |
| 8444 | EXPECT_EQ(HttpResponseInfo::CONNECTION_INFO_HTTP2, |
| 8445 | response1->connection_info); |
| 8446 | EXPECT_EQ("HTTP/1.1 200", response1->headers->GetStatusLine()); |
| 8447 | std::string response_data; |
| 8448 | ReadTransaction(&trans1, &response_data); |
| 8449 | EXPECT_EQ("hello!", response_data); |
| 8450 | |
| 8451 | const HttpResponseInfo* response2 = trans2.GetResponseInfo(); |
| 8452 | ASSERT_TRUE(response2); |
| 8453 | ASSERT_TRUE(response2->headers); |
| 8454 | EXPECT_EQ(HttpResponseInfo::CONNECTION_INFO_HTTP2, |
| 8455 | response2->connection_info); |
| 8456 | EXPECT_EQ("HTTP/1.1 200", response2->headers->GetStatusLine()); |
| 8457 | ReadTransaction(&trans2, &response_data); |
| 8458 | EXPECT_EQ("hello!", response_data); |
| 8459 | |
| 8460 | helper.VerifyDataConsumed(); |
| 8461 | } |
| 8462 | |
| 8463 | // Run multiple concurrent streams, the first not requiring confirmation and the |
| 8464 | // second requiring confirmation. |
| 8465 | TEST_F(SpdyNetworkTransactionTest, ZeroRTTNoConfirmConfirmStreams) { |
| 8466 | // This test orders the writes such that the GET (no confirmation) is written |
| 8467 | // before the POST (confirmation required). |
| 8468 | spdy::SpdyHeaderBlock req_block1( |
| 8469 | spdy_util_.ConstructGetHeaderBlock(kDefaultUrl)); |
| 8470 | spdy::SpdySerializedFrame req1( |
| 8471 | spdy_util_.ConstructSpdyHeaders(1, std::move(req_block1), LOWEST, true)); |
| 8472 | spdy::SpdyHeaderBlock req_block2( |
| 8473 | spdy_util_.ConstructPostHeaderBlock(kDefaultUrl, 0)); |
| 8474 | spdy::SpdySerializedFrame req2( |
| 8475 | spdy_util_.ConstructSpdyHeaders(3, std::move(req_block2), LOWEST, true)); |
| 8476 | MockWrite writes[] = { |
| 8477 | CreateMockWrite(req1, 0), |
| 8478 | CreateMockWrite(req2, 3), |
| 8479 | }; |
| 8480 | spdy::SpdySerializedFrame resp1( |
| 8481 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 8482 | spdy::SpdySerializedFrame body1(spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 8483 | spdy::SpdySerializedFrame resp2( |
| 8484 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 3)); |
| 8485 | spdy::SpdySerializedFrame body2(spdy_util_.ConstructSpdyDataFrame(3, true)); |
| 8486 | MockRead reads[] = { |
| 8487 | CreateMockRead(resp1, 1), CreateMockRead(body1, 2), |
| 8488 | CreateMockRead(resp2, 4), CreateMockRead(body2, 5), |
| 8489 | MockRead(ASYNC, 0, 6) // EOF |
| 8490 | }; |
| 8491 | |
| 8492 | SequencedSocketData data1(reads, writes); |
| 8493 | SequencedSocketData data2({}, {}); |
| 8494 | UsePostRequest(); |
| 8495 | auto session_deps = std::make_unique<SpdySessionDependencies>(); |
| 8496 | session_deps->enable_early_data = true; |
| 8497 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
| 8498 | std::move(session_deps)); |
| 8499 | auto ssl_provider1 = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
| 8500 | ssl_provider1->confirm = MockConfirm(ASYNC, OK); |
| 8501 | auto ssl_provider2 = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
| 8502 | ssl_provider2->confirm = MockConfirm(ASYNC, OK); |
| 8503 | |
| 8504 | helper.RunPreTestSetup(); |
| 8505 | helper.AddDataWithSSLSocketDataProvider(&data1, std::move(ssl_provider1)); |
| 8506 | helper.AddDataWithSSLSocketDataProvider(&data2, std::move(ssl_provider2)); |
| 8507 | |
| 8508 | // TODO(https://crbug.com/949724): Explicitly verify the ordering of |
| 8509 | // ConfirmHandshake and the second stream. |
| 8510 | |
| 8511 | HttpNetworkTransaction trans1(DEFAULT_PRIORITY, helper.session()); |
| 8512 | HttpRequestInfo request1; |
| 8513 | request1.method = "GET"; |
| 8514 | request1.url = GURL(kDefaultUrl); |
| 8515 | request1.traffic_annotation = |
| 8516 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
| 8517 | TestCompletionCallback callback1; |
| 8518 | int rv = trans1.Start(&request1, callback1.callback(), log_); |
| 8519 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 8520 | |
| 8521 | HttpNetworkTransaction trans2(DEFAULT_PRIORITY, helper.session()); |
| 8522 | HttpRequestInfo request2; |
| 8523 | request2.method = "POST"; |
| 8524 | request2.url = GURL(kDefaultUrl); |
| 8525 | request2.traffic_annotation = |
| 8526 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
| 8527 | TestCompletionCallback callback2; |
| 8528 | rv = trans2.Start(&request2, callback2.callback(), log_); |
| 8529 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 8530 | |
| 8531 | EXPECT_THAT(callback1.GetResult(ERR_IO_PENDING), IsOk()); |
| 8532 | EXPECT_THAT(callback2.GetResult(ERR_IO_PENDING), IsOk()); |
| 8533 | |
| 8534 | const HttpResponseInfo* response1 = trans1.GetResponseInfo(); |
| 8535 | ASSERT_TRUE(response1); |
| 8536 | ASSERT_TRUE(response1->headers); |
| 8537 | EXPECT_EQ(HttpResponseInfo::CONNECTION_INFO_HTTP2, |
| 8538 | response1->connection_info); |
| 8539 | EXPECT_EQ("HTTP/1.1 200", response1->headers->GetStatusLine()); |
| 8540 | std::string response_data; |
| 8541 | ReadTransaction(&trans1, &response_data); |
| 8542 | EXPECT_EQ("hello!", response_data); |
| 8543 | |
| 8544 | const HttpResponseInfo* response2 = trans2.GetResponseInfo(); |
| 8545 | ASSERT_TRUE(response2); |
| 8546 | ASSERT_TRUE(response2->headers); |
| 8547 | EXPECT_EQ(HttpResponseInfo::CONNECTION_INFO_HTTP2, |
| 8548 | response2->connection_info); |
| 8549 | EXPECT_EQ("HTTP/1.1 200", response2->headers->GetStatusLine()); |
| 8550 | ReadTransaction(&trans2, &response_data); |
| 8551 | EXPECT_EQ("hello!", response_data); |
| 8552 | |
| 8553 | helper.VerifyDataConsumed(); |
| 8554 | } |
| 8555 | |
| 8556 | TEST_F(SpdyNetworkTransactionTest, ZeroRTTSyncConfirmSyncWrite) { |
| 8557 | spdy::SpdySerializedFrame req(spdy_util_.ConstructSpdyPost( |
| 8558 | kDefaultUrl, 1, kUploadDataSize, LOWEST, nullptr, 0)); |
| 8559 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 8560 | MockWrite writes[] = { |
| 8561 | CreateMockWrite(req, 0, SYNCHRONOUS), |
| 8562 | CreateMockWrite(body, 1), // POST upload frame |
| 8563 | }; |
| 8564 | |
| 8565 | spdy::SpdySerializedFrame resp(spdy_util_.ConstructSpdyPostReply(nullptr, 0)); |
| 8566 | MockRead reads[] = { |
| 8567 | CreateMockRead(resp, 2), CreateMockRead(body, 3), |
| 8568 | MockRead(ASYNC, 0, 4) // EOF |
| 8569 | }; |
| 8570 | |
| 8571 | SequencedSocketData data(reads, writes); |
| 8572 | UsePostRequest(); |
| 8573 | auto session_deps = std::make_unique<SpdySessionDependencies>(); |
| 8574 | session_deps->enable_early_data = true; |
| 8575 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
| 8576 | std::move(session_deps)); |
| 8577 | auto ssl_provider = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
| 8578 | ssl_provider->confirm = MockConfirm(SYNCHRONOUS, OK); |
| 8579 | helper.RunToCompletionWithSSLData(&data, std::move(ssl_provider)); |
| 8580 | TransactionHelperResult out = helper.output(); |
| 8581 | EXPECT_THAT(out.rv, IsOk()); |
| 8582 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
| 8583 | EXPECT_EQ("hello!", out.response_data); |
| 8584 | } |
| 8585 | |
| 8586 | TEST_F(SpdyNetworkTransactionTest, ZeroRTTSyncConfirmAsyncWrite) { |
| 8587 | spdy::SpdySerializedFrame req(spdy_util_.ConstructSpdyPost( |
| 8588 | kDefaultUrl, 1, kUploadDataSize, LOWEST, nullptr, 0)); |
| 8589 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 8590 | MockWrite writes[] = { |
| 8591 | CreateMockWrite(req, 0, ASYNC), |
| 8592 | CreateMockWrite(body, 1), // POST upload frame |
| 8593 | }; |
| 8594 | |
| 8595 | spdy::SpdySerializedFrame resp(spdy_util_.ConstructSpdyPostReply(nullptr, 0)); |
| 8596 | MockRead reads[] = { |
| 8597 | CreateMockRead(resp, 2), CreateMockRead(body, 3), |
| 8598 | MockRead(ASYNC, 0, 4) // EOF |
| 8599 | }; |
| 8600 | |
| 8601 | SequencedSocketData data(reads, writes); |
| 8602 | UsePostRequest(); |
| 8603 | auto session_deps = std::make_unique<SpdySessionDependencies>(); |
| 8604 | session_deps->enable_early_data = true; |
| 8605 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
| 8606 | std::move(session_deps)); |
| 8607 | auto ssl_provider = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
| 8608 | ssl_provider->confirm = MockConfirm(SYNCHRONOUS, OK); |
| 8609 | helper.RunToCompletionWithSSLData(&data, std::move(ssl_provider)); |
| 8610 | TransactionHelperResult out = helper.output(); |
| 8611 | EXPECT_THAT(out.rv, IsOk()); |
| 8612 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
| 8613 | EXPECT_EQ("hello!", out.response_data); |
| 8614 | } |
| 8615 | |
| 8616 | TEST_F(SpdyNetworkTransactionTest, ZeroRTTAsyncConfirmSyncWrite) { |
| 8617 | spdy::SpdySerializedFrame req(spdy_util_.ConstructSpdyPost( |
| 8618 | kDefaultUrl, 1, kUploadDataSize, LOWEST, nullptr, 0)); |
| 8619 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 8620 | MockWrite writes[] = { |
| 8621 | CreateMockWrite(req, 0, SYNCHRONOUS), |
| 8622 | CreateMockWrite(body, 1), // POST upload frame |
| 8623 | }; |
| 8624 | |
| 8625 | spdy::SpdySerializedFrame resp(spdy_util_.ConstructSpdyPostReply(nullptr, 0)); |
| 8626 | MockRead reads[] = { |
| 8627 | CreateMockRead(resp, 2), CreateMockRead(body, 3), |
| 8628 | MockRead(ASYNC, 0, 4) // EOF |
| 8629 | }; |
| 8630 | |
| 8631 | SequencedSocketData data(reads, writes); |
| 8632 | UsePostRequest(); |
| 8633 | auto session_deps = std::make_unique<SpdySessionDependencies>(); |
| 8634 | session_deps->enable_early_data = true; |
| 8635 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
| 8636 | std::move(session_deps)); |
| 8637 | auto ssl_provider = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
| 8638 | ssl_provider->confirm = MockConfirm(ASYNC, OK); |
| 8639 | helper.RunToCompletionWithSSLData(&data, std::move(ssl_provider)); |
| 8640 | TransactionHelperResult out = helper.output(); |
| 8641 | EXPECT_THAT(out.rv, IsOk()); |
| 8642 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
| 8643 | EXPECT_EQ("hello!", out.response_data); |
| 8644 | } |
| 8645 | |
| 8646 | TEST_F(SpdyNetworkTransactionTest, ZeroRTTAsyncConfirmAsyncWrite) { |
| 8647 | spdy::SpdySerializedFrame req(spdy_util_.ConstructSpdyPost( |
| 8648 | kDefaultUrl, 1, kUploadDataSize, LOWEST, nullptr, 0)); |
| 8649 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 8650 | MockWrite writes[] = { |
| 8651 | CreateMockWrite(req, 0, ASYNC), |
| 8652 | CreateMockWrite(body, 1), // POST upload frame |
| 8653 | }; |
| 8654 | |
| 8655 | spdy::SpdySerializedFrame resp(spdy_util_.ConstructSpdyPostReply(nullptr, 0)); |
| 8656 | MockRead reads[] = { |
| 8657 | CreateMockRead(resp, 2), CreateMockRead(body, 3), |
| 8658 | MockRead(ASYNC, 0, 4) // EOF |
| 8659 | }; |
| 8660 | |
| 8661 | SequencedSocketData data(reads, writes); |
| 8662 | UsePostRequest(); |
| 8663 | auto session_deps = std::make_unique<SpdySessionDependencies>(); |
| 8664 | session_deps->enable_early_data = true; |
| 8665 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
| 8666 | std::move(session_deps)); |
| 8667 | auto ssl_provider = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
| 8668 | ssl_provider->confirm = MockConfirm(ASYNC, OK); |
| 8669 | helper.RunToCompletionWithSSLData(&data, std::move(ssl_provider)); |
| 8670 | TransactionHelperResult out = helper.output(); |
| 8671 | EXPECT_THAT(out.rv, IsOk()); |
| 8672 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
| 8673 | EXPECT_EQ("hello!", out.response_data); |
| 8674 | } |
| 8675 | |
| 8676 | TEST_F(SpdyNetworkTransactionTest, ZeroRTTConfirmErrorSync) { |
| 8677 | spdy::SpdySerializedFrame req(spdy_util_.ConstructSpdyPost( |
| 8678 | kDefaultUrl, 1, kUploadDataSize, LOWEST, nullptr, 0)); |
| 8679 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 8680 | MockWrite writes[] = { |
| 8681 | CreateMockWrite(req, 0), CreateMockWrite(body, 1), // POST upload frame |
| 8682 | }; |
| 8683 | |
| 8684 | spdy::SpdySerializedFrame resp(spdy_util_.ConstructSpdyPostReply(nullptr, 0)); |
| 8685 | MockRead reads[] = { |
| 8686 | CreateMockRead(resp, 2), CreateMockRead(body, 3), |
| 8687 | MockRead(ASYNC, 0, 4) // EOF |
| 8688 | }; |
| 8689 | |
| 8690 | SequencedSocketData data(reads, writes); |
| 8691 | UsePostRequest(); |
| 8692 | auto session_deps = std::make_unique<SpdySessionDependencies>(); |
| 8693 | session_deps->enable_early_data = true; |
| 8694 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
| 8695 | std::move(session_deps)); |
| 8696 | auto ssl_provider = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
| 8697 | ssl_provider->confirm = MockConfirm(SYNCHRONOUS, ERR_SSL_PROTOCOL_ERROR); |
| 8698 | helper.RunPreTestSetup(); |
| 8699 | helper.AddDataWithSSLSocketDataProvider(&data, std::move(ssl_provider)); |
| 8700 | helper.RunDefaultTest(); |
| 8701 | TransactionHelperResult out = helper.output(); |
| 8702 | EXPECT_THAT(out.rv, IsError(ERR_SSL_PROTOCOL_ERROR)); |
| 8703 | } |
| 8704 | |
| 8705 | TEST_F(SpdyNetworkTransactionTest, ZeroRTTConfirmErrorAsync) { |
| 8706 | spdy::SpdySerializedFrame req(spdy_util_.ConstructSpdyPost( |
| 8707 | kDefaultUrl, 1, kUploadDataSize, LOWEST, nullptr, 0)); |
| 8708 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 8709 | MockWrite writes[] = { |
| 8710 | CreateMockWrite(req, 0), CreateMockWrite(body, 1), // POST upload frame |
| 8711 | }; |
| 8712 | |
| 8713 | spdy::SpdySerializedFrame resp(spdy_util_.ConstructSpdyPostReply(nullptr, 0)); |
| 8714 | MockRead reads[] = { |
| 8715 | CreateMockRead(resp, 2), CreateMockRead(body, 3), |
| 8716 | MockRead(ASYNC, 0, 4) // EOF |
| 8717 | }; |
| 8718 | |
| 8719 | SequencedSocketData data(reads, writes); |
| 8720 | UsePostRequest(); |
| 8721 | auto session_deps = std::make_unique<SpdySessionDependencies>(); |
| 8722 | session_deps->enable_early_data = true; |
| 8723 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
| 8724 | std::move(session_deps)); |
| 8725 | auto ssl_provider = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
| 8726 | ssl_provider->confirm = MockConfirm(ASYNC, ERR_SSL_PROTOCOL_ERROR); |
| 8727 | helper.RunPreTestSetup(); |
| 8728 | helper.AddDataWithSSLSocketDataProvider(&data, std::move(ssl_provider)); |
| 8729 | helper.RunDefaultTest(); |
| 8730 | TransactionHelperResult out = helper.output(); |
| 8731 | EXPECT_THAT(out.rv, IsError(ERR_SSL_PROTOCOL_ERROR)); |
| 8732 | } |
| 8733 | |
[email protected] | aea8060 | 2009-09-18 00:55:08 | [diff] [blame] | 8734 | } // namespace net |