[email protected] | f2fe87c | 2012-04-24 17:53:49 | [diff] [blame] | 1 | // Copyright (c) 2012 The Chromium Authors. All rights reserved. |
[email protected] | a964e11 | 2011-04-14 21:52:51 | [diff] [blame] | 2 | // Use of this source code is governed by a BSD-style license that can be |
| 3 | // found in the LICENSE file. |
| 4 | |
dcheng | c963c714 | 2016-04-08 03:55:22 | [diff] [blame] | 5 | #include <memory> |
[email protected] | a964e11 | 2011-04-14 21:52:51 | [diff] [blame] | 6 | #include <string> |
| 7 | |
Sebastien Marchand | f1349f5 | 2019-01-25 03:16:41 | [diff] [blame] | 8 | #include "base/bind.h" |
[email protected] | a964e11 | 2011-04-14 21:52:51 | [diff] [blame] | 9 | #include "base/command_line.h" |
| 10 | #include "base/json/json_reader.h" |
[email protected] | 3ea1b18 | 2013-02-08 22:38:41 | [diff] [blame] | 11 | #include "base/strings/string_number_conversions.h" |
Lei Zhang | fe5b8693 | 2019-02-01 17:26:59 | [diff] [blame] | 12 | #include "base/strings/stringprintf.h" |
[email protected] | a964e11 | 2011-04-14 21:52:51 | [diff] [blame] | 13 | #include "base/values.h" |
| 14 | #include "chrome/browser/extensions/extension_browsertest.h" |
[email protected] | f2fe87c | 2012-04-24 17:53:49 | [diff] [blame] | 15 | #include "chrome/browser/extensions/extension_service.h" |
| 16 | #include "chrome/browser/profiles/profile.h" |
[email protected] | a964e11 | 2011-04-14 21:52:51 | [diff] [blame] | 17 | #include "chrome/browser/ui/browser.h" |
[email protected] | 47ae2337 | 2013-01-29 01:50:48 | [diff] [blame] | 18 | #include "chrome/browser/ui/tabs/tab_strip_model.h" |
[email protected] | af44e7fb | 2011-07-29 18:32:32 | [diff] [blame] | 19 | #include "chrome/test/base/ui_test_utils.h" |
[email protected] | 4ca1530 | 2012-01-03 05:53:20 | [diff] [blame] | 20 | #include "content/public/browser/web_contents.h" |
Peter Kasting | 919ce65 | 2020-05-07 10:22:36 | [diff] [blame] | 21 | #include "content/public/test/browser_test.h" |
[email protected] | 7d478cb | 2012-07-24 17:19:42 | [diff] [blame] | 22 | #include "content/public/test/browser_test_utils.h" |
[email protected] | e4452d3 | 2013-11-15 23:07:41 | [diff] [blame] | 23 | #include "extensions/common/extension.h" |
[email protected] | d42c1115 | 2013-08-22 19:36:32 | [diff] [blame] | 24 | #include "extensions/common/manifest.h" |
[email protected] | f2cb3cf | 2013-03-21 01:40:53 | [diff] [blame] | 25 | #include "net/dns/mock_host_resolver.h" |
nick | fa2254b | 2015-08-07 23:27:29 | [diff] [blame] | 26 | #include "net/test/embedded_test_server/embedded_test_server.h" |
[email protected] | a6483d2 | 2013-07-03 22:11:00 | [diff] [blame] | 27 | #include "url/gurl.h" |
[email protected] | a964e11 | 2011-04-14 21:52:51 | [diff] [blame] | 28 | |
[email protected] | 1c321ee | 2012-05-21 03:02:34 | [diff] [blame] | 29 | using extensions::Extension; |
| 30 | |
Devlin Cronin | 836f545d | 2018-05-09 00:25:05 | [diff] [blame] | 31 | class ChromeAppAPITest : public extensions::ExtensionBrowserTest { |
jam | bb11ed74 | 2017-05-01 17:27:59 | [diff] [blame] | 32 | void SetUpOnMainThread() override { |
Devlin Cronin | 836f545d | 2018-05-09 00:25:05 | [diff] [blame] | 33 | extensions::ExtensionBrowserTest::SetUpOnMainThread(); |
jam | bb11ed74 | 2017-05-01 17:27:59 | [diff] [blame] | 34 | host_resolver()->AddRule("*", "127.0.0.1"); |
| 35 | ASSERT_TRUE(embedded_test_server()->Start()); |
| 36 | } |
| 37 | |
[email protected] | 80675fc | 2011-06-21 02:05:49 | [diff] [blame] | 38 | protected: |
[email protected] | b27c362 | 2014-03-22 00:26:55 | [diff] [blame] | 39 | bool IsAppInstalledInMainFrame() { |
| 40 | return IsAppInstalledInFrame( |
| 41 | browser()->tab_strip_model()->GetActiveWebContents()->GetMainFrame()); |
| 42 | } |
| 43 | bool IsAppInstalledInIFrame() { |
| 44 | return IsAppInstalledInFrame(GetIFrame()); |
| 45 | } |
| 46 | bool IsAppInstalledInFrame(content::RenderFrameHost* frame) { |
[email protected] | 06bc5d9 | 2013-01-02 22:44:13 | [diff] [blame] | 47 | const char kGetAppIsInstalled[] = |
| 48 | "window.domAutomationController.send(window.chrome.app.isInstalled);"; |
[email protected] | 80675fc | 2011-06-21 02:05:49 | [diff] [blame] | 49 | bool result; |
[email protected] | b27c362 | 2014-03-22 00:26:55 | [diff] [blame] | 50 | CHECK(content::ExecuteScriptAndExtractBool(frame, |
| 51 | kGetAppIsInstalled, |
| 52 | &result)); |
[email protected] | f2fe87c | 2012-04-24 17:53:49 | [diff] [blame] | 53 | return result; |
| 54 | } |
| 55 | |
[email protected] | b27c362 | 2014-03-22 00:26:55 | [diff] [blame] | 56 | std::string InstallStateInMainFrame() { |
| 57 | return InstallStateInFrame( |
| 58 | browser()->tab_strip_model()->GetActiveWebContents()->GetMainFrame()); |
| 59 | } |
| 60 | std::string InstallStateInIFrame() { |
| 61 | return InstallStateInFrame(GetIFrame()); |
| 62 | } |
| 63 | std::string InstallStateInFrame(content::RenderFrameHost* frame) { |
[email protected] | 06bc5d9 | 2013-01-02 22:44:13 | [diff] [blame] | 64 | const char kGetAppInstallState[] = |
| 65 | "window.chrome.app.installState(" |
| 66 | " function(s) { window.domAutomationController.send(s); });"; |
[email protected] | f2fe87c | 2012-04-24 17:53:49 | [diff] [blame] | 67 | std::string result; |
[email protected] | b27c362 | 2014-03-22 00:26:55 | [diff] [blame] | 68 | CHECK(content::ExecuteScriptAndExtractString(frame, |
| 69 | kGetAppInstallState, |
| 70 | &result)); |
[email protected] | f2fe87c | 2012-04-24 17:53:49 | [diff] [blame] | 71 | return result; |
| 72 | } |
| 73 | |
[email protected] | b27c362 | 2014-03-22 00:26:55 | [diff] [blame] | 74 | std::string RunningStateInMainFrame() { |
| 75 | return RunningStateInFrame( |
| 76 | browser()->tab_strip_model()->GetActiveWebContents()->GetMainFrame()); |
| 77 | } |
| 78 | std::string RunningStateInIFrame() { |
| 79 | return RunningStateInFrame(GetIFrame()); |
| 80 | } |
| 81 | std::string RunningStateInFrame(content::RenderFrameHost* frame) { |
[email protected] | 06bc5d9 | 2013-01-02 22:44:13 | [diff] [blame] | 82 | const char kGetAppRunningState[] = |
| 83 | "window.domAutomationController.send(" |
| 84 | " window.chrome.app.runningState());"; |
[email protected] | f2fe87c | 2012-04-24 17:53:49 | [diff] [blame] | 85 | std::string result; |
[email protected] | b27c362 | 2014-03-22 00:26:55 | [diff] [blame] | 86 | CHECK(content::ExecuteScriptAndExtractString(frame, |
| 87 | kGetAppRunningState, |
| 88 | &result)); |
[email protected] | 80675fc | 2011-06-21 02:05:49 | [diff] [blame] | 89 | return result; |
| 90 | } |
| 91 | |
[email protected] | a964e11 | 2011-04-14 21:52:51 | [diff] [blame] | 92 | private: |
[email protected] | b27c362 | 2014-03-22 00:26:55 | [diff] [blame] | 93 | content::RenderFrameHost* GetIFrame() { |
| 94 | return content::FrameMatchingPredicate( |
David Bokan | 2c77c33c | 2021-07-26 23:29:59 | [diff] [blame^] | 95 | browser()->tab_strip_model()->GetActiveWebContents()->GetPrimaryPage(), |
Alex Turner | d9f1b0f | 2020-10-21 00:05:50 | [diff] [blame] | 96 | base::BindRepeating(&content::FrameIsChildOfMainFrame)); |
[email protected] | b27c362 | 2014-03-22 00:26:55 | [diff] [blame] | 97 | } |
[email protected] | a964e11 | 2011-04-14 21:52:51 | [diff] [blame] | 98 | }; |
| 99 | |
nick | fa2254b | 2015-08-07 23:27:29 | [diff] [blame] | 100 | IN_PROC_BROWSER_TEST_F(ChromeAppAPITest, IsInstalled) { |
nick | fa2254b | 2015-08-07 23:27:29 | [diff] [blame] | 101 | GURL app_url = |
| 102 | embedded_test_server()->GetURL("app.com", "/extensions/test_file.html"); |
| 103 | GURL non_app_url = embedded_test_server()->GetURL( |
| 104 | "nonapp.com", "/extensions/test_file.html"); |
[email protected] | a964e11 | 2011-04-14 21:52:51 | [diff] [blame] | 105 | |
[email protected] | 80675fc | 2011-06-21 02:05:49 | [diff] [blame] | 106 | // Before the app is installed, app.com does not think that it is installed |
| 107 | ui_test_utils::NavigateToURL(browser(), app_url); |
[email protected] | b27c362 | 2014-03-22 00:26:55 | [diff] [blame] | 108 | EXPECT_FALSE(IsAppInstalledInMainFrame()); |
[email protected] | a964e11 | 2011-04-14 21:52:51 | [diff] [blame] | 109 | |
| 110 | // Load an app which includes app.com in its extent. |
| 111 | const Extension* extension = LoadExtension( |
| 112 | test_data_dir_.AppendASCII("app_dot_com_app")); |
| 113 | ASSERT_TRUE(extension); |
| 114 | |
[email protected] | 80675fc | 2011-06-21 02:05:49 | [diff] [blame] | 115 | // Even after the app is installed, the existing app.com tab is not in an |
| 116 | // app process, so chrome.app.isInstalled should return false. |
[email protected] | b27c362 | 2014-03-22 00:26:55 | [diff] [blame] | 117 | EXPECT_FALSE(IsAppInstalledInMainFrame()); |
[email protected] | a964e11 | 2011-04-14 21:52:51 | [diff] [blame] | 118 | |
| 119 | // Test that a non-app page has chrome.app.isInstalled = false. |
| 120 | ui_test_utils::NavigateToURL(browser(), non_app_url); |
[email protected] | b27c362 | 2014-03-22 00:26:55 | [diff] [blame] | 121 | EXPECT_FALSE(IsAppInstalledInMainFrame()); |
[email protected] | a964e11 | 2011-04-14 21:52:51 | [diff] [blame] | 122 | |
| 123 | // Test that a non-app page returns null for chrome.app.getDetails(). |
[email protected] | 06bc5d9 | 2013-01-02 22:44:13 | [diff] [blame] | 124 | const char kGetAppDetails[] = |
| 125 | "window.domAutomationController.send(" |
| 126 | " JSON.stringify(window.chrome.app.getDetails()));"; |
[email protected] | 80675fc | 2011-06-21 02:05:49 | [diff] [blame] | 127 | std::string result; |
[email protected] | a964e11 | 2011-04-14 21:52:51 | [diff] [blame] | 128 | ASSERT_TRUE( |
[email protected] | b6987e0 | 2013-01-04 18:30:43 | [diff] [blame] | 129 | content::ExecuteScriptAndExtractString( |
[email protected] | 47ae2337 | 2013-01-29 01:50:48 | [diff] [blame] | 130 | browser()->tab_strip_model()->GetActiveWebContents(), |
[email protected] | 06bc5d9 | 2013-01-02 22:44:13 | [diff] [blame] | 131 | kGetAppDetails, |
| 132 | &result)); |
[email protected] | a964e11 | 2011-04-14 21:52:51 | [diff] [blame] | 133 | EXPECT_EQ("null", result); |
| 134 | |
| 135 | // Check that an app page has chrome.app.isInstalled = true. |
| 136 | ui_test_utils::NavigateToURL(browser(), app_url); |
[email protected] | b27c362 | 2014-03-22 00:26:55 | [diff] [blame] | 137 | EXPECT_TRUE(IsAppInstalledInMainFrame()); |
[email protected] | a964e11 | 2011-04-14 21:52:51 | [diff] [blame] | 138 | |
| 139 | // Check that an app page returns the correct result for |
| 140 | // chrome.app.getDetails(). |
| 141 | ui_test_utils::NavigateToURL(browser(), app_url); |
| 142 | ASSERT_TRUE( |
[email protected] | b6987e0 | 2013-01-04 18:30:43 | [diff] [blame] | 143 | content::ExecuteScriptAndExtractString( |
[email protected] | 47ae2337 | 2013-01-29 01:50:48 | [diff] [blame] | 144 | browser()->tab_strip_model()->GetActiveWebContents(), |
[email protected] | 06bc5d9 | 2013-01-02 22:44:13 | [diff] [blame] | 145 | kGetAppDetails, |
| 146 | &result)); |
dcheng | c963c714 | 2016-04-08 03:55:22 | [diff] [blame] | 147 | std::unique_ptr<base::DictionaryValue> app_details( |
estade | b09312b | 2015-05-22 16:30:13 | [diff] [blame] | 148 | static_cast<base::DictionaryValue*>( |
Lei Zhang | 582ecd1 | 2019-02-13 20:28:54 | [diff] [blame] | 149 | base::JSONReader::ReadDeprecated(result).release())); |
[email protected] | 953620b | 2011-12-04 00:55:32 | [diff] [blame] | 150 | // extension->manifest() does not contain the id. |
Song Fangzhen | cdbb706 | 2021-07-07 11:13:53 | [diff] [blame] | 151 | app_details->RemoveKey("id"); |
[email protected] | a964e11 | 2011-04-14 21:52:51 | [diff] [blame] | 152 | EXPECT_TRUE(app_details.get()); |
[email protected] | 953620b | 2011-12-04 00:55:32 | [diff] [blame] | 153 | EXPECT_TRUE(app_details->Equals(extension->manifest()->value())); |
[email protected] | a964e11 | 2011-04-14 21:52:51 | [diff] [blame] | 154 | |
[email protected] | 9b3a5c2 | 2011-05-31 08:03:13 | [diff] [blame] | 155 | // Try to change app.isInstalled. Should silently fail, so |
| 156 | // that isInstalled should have the initial value. |
| 157 | ASSERT_TRUE( |
[email protected] | b6987e0 | 2013-01-04 18:30:43 | [diff] [blame] | 158 | content::ExecuteScriptAndExtractString( |
[email protected] | 47ae2337 | 2013-01-29 01:50:48 | [diff] [blame] | 159 | browser()->tab_strip_model()->GetActiveWebContents(), |
[email protected] | 06bc5d9 | 2013-01-02 22:44:13 | [diff] [blame] | 160 | "window.domAutomationController.send(" |
| 161 | " function() {" |
| 162 | " var value = window.chrome.app.isInstalled;" |
| 163 | " window.chrome.app.isInstalled = !value;" |
| 164 | " if (window.chrome.app.isInstalled == value) {" |
| 165 | " return 'true';" |
| 166 | " } else {" |
| 167 | " return 'false';" |
| 168 | " }" |
| 169 | " }()" |
| 170 | ");", |
| 171 | &result)); |
[email protected] | 9b3a5c2 | 2011-05-31 08:03:13 | [diff] [blame] | 172 | |
| 173 | // Should not be able to alter window.chrome.app.isInstalled from javascript"; |
| 174 | EXPECT_EQ("true", result); |
[email protected] | a964e11 | 2011-04-14 21:52:51 | [diff] [blame] | 175 | } |
| 176 | |
Devlin Cronin | e97d4ed | 2018-06-29 01:38:50 | [diff] [blame] | 177 | // Test accessing app.isInstalled when the context has been invalidated (e.g. |
| 178 | // by removing the frame). Regression test for https://crbug.com/855853. |
| 179 | IN_PROC_BROWSER_TEST_F(ChromeAppAPITest, IsInstalledFromRemovedFrame) { |
| 180 | GURL app_url = |
| 181 | embedded_test_server()->GetURL("app.com", "/extensions/test_file.html"); |
| 182 | const Extension* extension = |
| 183 | LoadExtension(test_data_dir_.AppendASCII("app_dot_com_app")); |
| 184 | ASSERT_TRUE(extension); |
| 185 | ui_test_utils::NavigateToURL(browser(), app_url); |
| 186 | |
| 187 | constexpr char kScript[] = |
| 188 | R"(var i = document.createElement('iframe'); |
| 189 | i.onload = function() { |
| 190 | var frameApp = i.contentWindow.chrome.app; |
| 191 | document.body.removeChild(i); |
| 192 | var isInstalled = frameApp.isInstalled; |
| 193 | window.domAutomationController.send( |
| 194 | isInstalled === undefined); |
| 195 | }; |
| 196 | i.src = '%s'; |
| 197 | document.body.appendChild(i);)"; |
| 198 | bool result = false; |
| 199 | ASSERT_TRUE(content::ExecuteScriptAndExtractBool( |
| 200 | browser()->tab_strip_model()->GetActiveWebContents(), |
| 201 | base::StringPrintf(kScript, app_url.spec().c_str()), &result)); |
| 202 | EXPECT_TRUE(result); |
| 203 | } |
| 204 | |
[email protected] | f2fe87c | 2012-04-24 17:53:49 | [diff] [blame] | 205 | IN_PROC_BROWSER_TEST_F(ChromeAppAPITest, InstallAndRunningState) { |
nick | fa2254b | 2015-08-07 23:27:29 | [diff] [blame] | 206 | GURL app_url = embedded_test_server()->GetURL( |
| 207 | "app.com", "/extensions/get_app_details_for_frame.html"); |
| 208 | GURL non_app_url = embedded_test_server()->GetURL( |
| 209 | "nonapp.com", "/extensions/get_app_details_for_frame.html"); |
[email protected] | f2fe87c | 2012-04-24 17:53:49 | [diff] [blame] | 210 | |
| 211 | // Before the app is installed, app.com does not think that it is installed |
| 212 | ui_test_utils::NavigateToURL(browser(), app_url); |
| 213 | |
[email protected] | b27c362 | 2014-03-22 00:26:55 | [diff] [blame] | 214 | EXPECT_EQ("not_installed", InstallStateInMainFrame()); |
| 215 | EXPECT_EQ("cannot_run", RunningStateInMainFrame()); |
| 216 | EXPECT_FALSE(IsAppInstalledInMainFrame()); |
[email protected] | f2fe87c | 2012-04-24 17:53:49 | [diff] [blame] | 217 | |
| 218 | const Extension* extension = LoadExtension( |
| 219 | test_data_dir_.AppendASCII("app_dot_com_app")); |
| 220 | ASSERT_TRUE(extension); |
| 221 | |
[email protected] | b27c362 | 2014-03-22 00:26:55 | [diff] [blame] | 222 | EXPECT_EQ("installed", InstallStateInMainFrame()); |
| 223 | EXPECT_EQ("ready_to_run", RunningStateInMainFrame()); |
| 224 | EXPECT_FALSE(IsAppInstalledInMainFrame()); |
[email protected] | f2fe87c | 2012-04-24 17:53:49 | [diff] [blame] | 225 | |
| 226 | // Reloading the page should put the tab in an app process. |
| 227 | ui_test_utils::NavigateToURL(browser(), app_url); |
[email protected] | b27c362 | 2014-03-22 00:26:55 | [diff] [blame] | 228 | EXPECT_EQ("installed", InstallStateInMainFrame()); |
| 229 | EXPECT_EQ("running", RunningStateInMainFrame()); |
| 230 | EXPECT_TRUE(IsAppInstalledInMainFrame()); |
[email protected] | f2fe87c | 2012-04-24 17:53:49 | [diff] [blame] | 231 | |
| 232 | // Disable the extension and verify the state. |
Devlin Cronin | 251bd41 | 2018-05-30 00:55:42 | [diff] [blame] | 233 | extensions::ExtensionService* service = |
| 234 | extensions::ExtensionSystem::Get(browser()->profile()) |
| 235 | ->extension_service(); |
Minh X. Nguyen | 4547901 | 2017-08-18 21:35:36 | [diff] [blame] | 236 | service->DisableExtension( |
| 237 | extension->id(), |
| 238 | extensions::disable_reason::DISABLE_PERMISSIONS_INCREASE); |
[email protected] | f2fe87c | 2012-04-24 17:53:49 | [diff] [blame] | 239 | ui_test_utils::NavigateToURL(browser(), app_url); |
| 240 | |
[email protected] | b27c362 | 2014-03-22 00:26:55 | [diff] [blame] | 241 | EXPECT_EQ("disabled", InstallStateInMainFrame()); |
| 242 | EXPECT_EQ("cannot_run", RunningStateInMainFrame()); |
| 243 | EXPECT_FALSE(IsAppInstalledInMainFrame()); |
[email protected] | f2fe87c | 2012-04-24 17:53:49 | [diff] [blame] | 244 | |
[email protected] | 03d2581 | 2014-06-22 19:41:55 | [diff] [blame] | 245 | service->EnableExtension(extension->id()); |
[email protected] | b27c362 | 2014-03-22 00:26:55 | [diff] [blame] | 246 | EXPECT_EQ("installed", InstallStateInMainFrame()); |
| 247 | EXPECT_EQ("ready_to_run", RunningStateInMainFrame()); |
| 248 | EXPECT_FALSE(IsAppInstalledInMainFrame()); |
[email protected] | f2fe87c | 2012-04-24 17:53:49 | [diff] [blame] | 249 | |
| 250 | // The non-app URL should still not be installed or running. |
| 251 | ui_test_utils::NavigateToURL(browser(), non_app_url); |
| 252 | |
[email protected] | b27c362 | 2014-03-22 00:26:55 | [diff] [blame] | 253 | EXPECT_EQ("not_installed", InstallStateInMainFrame()); |
| 254 | EXPECT_EQ("cannot_run", RunningStateInMainFrame()); |
| 255 | EXPECT_FALSE(IsAppInstalledInMainFrame()); |
[email protected] | f2fe87c | 2012-04-24 17:53:49 | [diff] [blame] | 256 | |
[email protected] | b27c362 | 2014-03-22 00:26:55 | [diff] [blame] | 257 | EXPECT_EQ("installed", InstallStateInIFrame()); |
| 258 | EXPECT_EQ("cannot_run", RunningStateInIFrame()); |
Alex Moshchuk | e63b9e9 | 2017-10-14 00:27:22 | [diff] [blame] | 259 | |
| 260 | // With --site-per-process, the iframe on nonapp.com will currently swap |
| 261 | // processes and go into the hosted app process. |
| 262 | if (content::AreAllSitesIsolatedForTesting()) |
| 263 | EXPECT_TRUE(IsAppInstalledInIFrame()); |
| 264 | else |
| 265 | EXPECT_FALSE(IsAppInstalledInIFrame()); |
[email protected] | f2fe87c | 2012-04-24 17:53:49 | [diff] [blame] | 266 | } |
| 267 | |
| 268 | IN_PROC_BROWSER_TEST_F(ChromeAppAPITest, InstallAndRunningStateFrame) { |
nick | fa2254b | 2015-08-07 23:27:29 | [diff] [blame] | 269 | GURL app_url = embedded_test_server()->GetURL( |
| 270 | "app.com", "/extensions/get_app_details_for_frame_reversed.html"); |
[email protected] | f2fe87c | 2012-04-24 17:53:49 | [diff] [blame] | 271 | |
| 272 | // Check the install and running state of a non-app iframe running |
| 273 | // within an app. |
| 274 | ui_test_utils::NavigateToURL(browser(), app_url); |
| 275 | |
[email protected] | b27c362 | 2014-03-22 00:26:55 | [diff] [blame] | 276 | EXPECT_EQ("not_installed", InstallStateInIFrame()); |
| 277 | EXPECT_EQ("cannot_run", RunningStateInIFrame()); |
| 278 | EXPECT_FALSE(IsAppInstalledInIFrame()); |
[email protected] | f2fe87c | 2012-04-24 17:53:49 | [diff] [blame] | 279 | } |