[email protected] | 3cac8723 | 2012-11-20 01:48:27 | [diff] [blame] | 1 | // Copyright (c) 2012 The Chromium Authors. All rights reserved. |
| 2 | // Use of this source code is governed by a BSD-style license that can be |
| 3 | // found in the LICENSE file. |
| 4 | |
| 5 | #include "chrome/browser/ui/browser_command_controller.h" |
| 6 | |
mlerman | 67fa17a | 2015-02-13 21:59:22 | [diff] [blame] | 7 | #include "base/command_line.h" |
avi | 655876a | 2015-12-25 07:18:15 | [diff] [blame] | 8 | #include "base/macros.h" |
fdoray | fd4c7ba | 2016-06-10 17:44:36 | [diff] [blame] | 9 | #include "base/run_loop.h" |
Haeun Kim | 3f612350 | 2018-08-26 18:03:04 | [diff] [blame] | 10 | #include "base/stl_util.h" |
avi | 655876a | 2015-12-25 07:18:15 | [diff] [blame] | 11 | #include "build/build_config.h" |
[email protected] | 3cac8723 | 2012-11-20 01:48:27 | [diff] [blame] | 12 | #include "chrome/app/chrome_command_ids.h" |
mlerman | 67fa17a | 2015-02-13 21:59:22 | [diff] [blame] | 13 | #include "chrome/browser/browser_process.h" |
mlerman | 67fa17a | 2015-02-13 21:59:22 | [diff] [blame] | 14 | #include "chrome/browser/profiles/profile_manager.h" |
| 15 | #include "chrome/browser/profiles/profile_window.h" |
| 16 | #include "chrome/browser/search_engines/template_url_service_factory.h" |
Cliff Smolinsky | 2c9586e | 2019-02-08 18:48:30 | [diff] [blame] | 17 | #include "chrome/browser/sessions/tab_restore_service_factory.h" |
| 18 | #include "chrome/browser/sessions/tab_restore_service_load_waiter.h" |
[email protected] | 5789218 | 2012-12-03 19:15:39 | [diff] [blame] | 19 | #include "chrome/browser/ui/browser.h" |
[email protected] | 3cac8723 | 2012-11-20 01:48:27 | [diff] [blame] | 20 | #include "chrome/browser/ui/browser_commands.h" |
mlerman | 67fa17a | 2015-02-13 21:59:22 | [diff] [blame] | 21 | #include "chrome/browser/ui/browser_finder.h" |
| 22 | #include "chrome/browser/ui/browser_list.h" |
| 23 | #include "chrome/browser/ui/browser_window.h" |
| 24 | #include "chrome/browser/ui/startup/startup_browser_creator.h" |
[email protected] | 3cac8723 | 2012-11-20 01:48:27 | [diff] [blame] | 25 | #include "chrome/browser/ui/tab_modal_confirm_dialog_browsertest.h" |
[email protected] | 5789218 | 2012-12-03 19:15:39 | [diff] [blame] | 26 | #include "chrome/browser/ui/tabs/tab_strip_model.h" |
[email protected] | 3cac8723 | 2012-11-20 01:48:27 | [diff] [blame] | 27 | #include "chrome/test/base/in_process_browser_test.h" |
Cliff Smolinsky | 2c9586e | 2019-02-08 18:48:30 | [diff] [blame] | 28 | #include "chrome/test/base/ui_test_utils.h" |
mlerman | 67fa17a | 2015-02-13 21:59:22 | [diff] [blame] | 29 | #include "components/search_engines/template_url_service.h" |
Cliff Smolinsky | 2c9586e | 2019-02-08 18:48:30 | [diff] [blame] | 30 | #include "components/sessions/core/tab_restore_service.h" |
| 31 | #include "components/sessions/core/tab_restore_service_observer.h" |
Colin Blundell | ac55c997 | 2018-11-07 15:30:33 | [diff] [blame] | 32 | #include "components/signin/core/browser/account_consistency_method.h" |
[email protected] | 51a2478 | 2013-02-06 06:50:23 | [diff] [blame] | 33 | #include "content/public/test/test_utils.h" |
[email protected] | 3cac8723 | 2012-11-20 01:48:27 | [diff] [blame] | 34 | |
mlerman | 67fa17a | 2015-02-13 21:59:22 | [diff] [blame] | 35 | #if defined(OS_CHROMEOS) |
Xiyuan Xia | 4f992f2 | 2019-06-05 15:33:46 | [diff] [blame] | 36 | #include "ash/public/cpp/window_pin_type.h" |
Ivan Sandrk | 9669d0e | 2017-12-15 23:50:20 | [diff] [blame] | 37 | #include "ash/public/cpp/window_properties.h" |
Steven Bennetts | 38e9bde2 | 2019-01-03 17:31:10 | [diff] [blame] | 38 | #include "chromeos/constants/chromeos_switches.h" |
Ivan Sandrk | 9669d0e | 2017-12-15 23:50:20 | [diff] [blame] | 39 | #include "ui/aura/window.h" |
mlerman | 67fa17a | 2015-02-13 21:59:22 | [diff] [blame] | 40 | #endif |
| 41 | |
Ivan Sandrk | 9669d0e | 2017-12-15 23:50:20 | [diff] [blame] | 42 | namespace chrome { |
| 43 | |
Aran Gilman | d217b5b | 2019-04-11 17:45:43 | [diff] [blame] | 44 | class BrowserCommandControllerBrowserTest : public InProcessBrowserTest { |
mlerman | 67fa17a | 2015-02-13 21:59:22 | [diff] [blame] | 45 | public: |
| 46 | BrowserCommandControllerBrowserTest() {} |
| 47 | ~BrowserCommandControllerBrowserTest() override {} |
| 48 | |
| 49 | void SetUpCommandLine(base::CommandLine* command_line) override { |
mlerman | 67fa17a | 2015-02-13 21:59:22 | [diff] [blame] | 50 | #if defined(OS_CHROMEOS) |
| 51 | command_line->AppendSwitch( |
| 52 | chromeos::switches::kIgnoreUserProfileMappingForTests); |
| 53 | #endif |
| 54 | } |
| 55 | |
| 56 | private: |
| 57 | DISALLOW_COPY_AND_ASSIGN(BrowserCommandControllerBrowserTest); |
| 58 | }; |
[email protected] | 3cac8723 | 2012-11-20 01:48:27 | [diff] [blame] | 59 | |
| 60 | // Verify that showing a constrained window disables find. |
| 61 | IN_PROC_BROWSER_TEST_F(BrowserCommandControllerBrowserTest, DisableFind) { |
| 62 | EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_FIND)); |
| 63 | |
| 64 | // Showing constrained window should disable find. |
[email protected] | 5789218 | 2012-12-03 19:15:39 | [diff] [blame] | 65 | content::WebContents* web_contents = |
| 66 | browser()->tab_strip_model()->GetActiveWebContents(); |
Jeremy Chinsen | e5459643 | 2019-05-29 00:18:46 | [diff] [blame] | 67 | auto delegate = std::make_unique<MockTabModalConfirmDialogDelegate>( |
| 68 | web_contents, nullptr); |
| 69 | MockTabModalConfirmDialogDelegate* delegate_ptr = delegate.get(); |
| 70 | TabModalConfirmDialog::Create(std::move(delegate), web_contents); |
[email protected] | 3cac8723 | 2012-11-20 01:48:27 | [diff] [blame] | 71 | EXPECT_FALSE(chrome::IsCommandEnabled(browser(), IDC_FIND)); |
| 72 | |
| 73 | // Switching to a new (unblocked) tab should reenable it. |
| 74 | AddBlankTabAndShow(browser()); |
| 75 | EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_FIND)); |
| 76 | |
| 77 | // Switching back to the blocked tab should disable it again. |
Edwin Joe | 6f6fc1e | 2019-02-27 20:00:37 | [diff] [blame] | 78 | browser()->tab_strip_model()->ActivateTabAt(0); |
[email protected] | 3cac8723 | 2012-11-20 01:48:27 | [diff] [blame] | 79 | EXPECT_FALSE(chrome::IsCommandEnabled(browser(), IDC_FIND)); |
| 80 | |
| 81 | // Closing the constrained window should reenable it. |
Jeremy Chinsen | e5459643 | 2019-05-29 00:18:46 | [diff] [blame] | 82 | delegate_ptr->Cancel(); |
[email protected] | 51a2478 | 2013-02-06 06:50:23 | [diff] [blame] | 83 | content::RunAllPendingInMessageLoop(); |
[email protected] | 3cac8723 | 2012-11-20 01:48:27 | [diff] [blame] | 84 | EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_FIND)); |
| 85 | } |
mlerman | 67fa17a | 2015-02-13 21:59:22 | [diff] [blame] | 86 | |
| 87 | // Note that a Browser's destructor, when the browser's profile is guest, will |
| 88 | // create and execute a BrowsingDataRemover. |
jam | db04346c | 2015-04-23 00:06:44 | [diff] [blame] | 89 | // Flakes http://crbug.com/471953 |
mlerman | 67fa17a | 2015-02-13 21:59:22 | [diff] [blame] | 90 | IN_PROC_BROWSER_TEST_F(BrowserCommandControllerBrowserTest, |
jam | db04346c | 2015-04-23 00:06:44 | [diff] [blame] | 91 | DISABLED_NewAvatarMenuEnabledInGuestMode) { |
scottmg | 0d8e4ab | 2016-01-28 00:34:55 | [diff] [blame] | 92 | EXPECT_EQ(1U, BrowserList::GetInstance()->size()); |
mlerman | 67fa17a | 2015-02-13 21:59:22 | [diff] [blame] | 93 | |
| 94 | // Create a guest browser nicely. Using CreateProfile() and CreateBrowser() |
| 95 | // does incomplete initialization that would lead to |
| 96 | // SystemUrlRequestContextGetter being leaked. |
scottmg | ff189b6 | 2016-02-11 19:47:16 | [diff] [blame] | 97 | profiles::SwitchToGuestProfile(ProfileManager::CreateCallback()); |
Evan Stade | 4487c45 | 2019-07-11 00:58:06 | [diff] [blame] | 98 | ui_test_utils::WaitForBrowserToOpen(); |
scottmg | 0d8e4ab | 2016-01-28 00:34:55 | [diff] [blame] | 99 | EXPECT_EQ(2U, BrowserList::GetInstance()->size()); |
mlerman | 67fa17a | 2015-02-13 21:59:22 | [diff] [blame] | 100 | |
| 101 | // Access the browser that was created for the new Guest Profile. |
| 102 | Profile* guest = g_browser_process->profile_manager()->GetProfileByPath( |
| 103 | ProfileManager::GetGuestProfilePath()); |
scottmg | 34c5dd88 | 2016-02-03 05:21:54 | [diff] [blame] | 104 | Browser* browser = chrome::FindAnyBrowser(guest, true); |
mlerman | 67fa17a | 2015-02-13 21:59:22 | [diff] [blame] | 105 | EXPECT_TRUE(browser); |
| 106 | |
| 107 | // The BrowsingDataRemover needs a loaded TemplateUrlService or else it hangs |
| 108 | // on to a CallbackList::Subscription forever. |
| 109 | TemplateURLServiceFactory::GetForProfile(guest)->set_loaded(true); |
| 110 | |
Ivan Sandrk | 9669d0e | 2017-12-15 23:50:20 | [diff] [blame] | 111 | const CommandUpdater* command_updater = browser->command_controller(); |
Aran Gilman | d217b5b | 2019-04-11 17:45:43 | [diff] [blame] | 112 | #if defined(OS_CHROMEOS) |
| 113 | // Chrome OS uses system tray menu to handle multi-profiles. |
| 114 | EXPECT_FALSE(command_updater->IsCommandEnabled(IDC_SHOW_AVATAR_MENU)); |
| 115 | #else |
| 116 | EXPECT_TRUE(command_updater->IsCommandEnabled(IDC_SHOW_AVATAR_MENU)); |
| 117 | #endif |
mlerman | 67fa17a | 2015-02-13 21:59:22 | [diff] [blame] | 118 | } |
Ivan Sandrk | 9669d0e | 2017-12-15 23:50:20 | [diff] [blame] | 119 | |
| 120 | #if defined(OS_CHROMEOS) |
| 121 | IN_PROC_BROWSER_TEST_F(BrowserCommandControllerBrowserTest, LockedFullscreen) { |
| 122 | CommandUpdaterImpl* command_updater = |
| 123 | &browser()->command_controller()->command_updater_; |
| 124 | // IDC_EXIT is always enabled in regular mode so it's a perfect candidate for |
| 125 | // testing. |
| 126 | EXPECT_TRUE(command_updater->IsCommandEnabled(IDC_EXIT)); |
| 127 | // Set locked fullscreen mode. |
| 128 | browser()->window()->GetNativeWindow()->SetProperty( |
Xiyuan Xia | 4f992f2 | 2019-06-05 15:33:46 | [diff] [blame] | 129 | ash::kWindowPinTypeKey, ash::WindowPinType::kTrustedPinned); |
Ivan Sandrk | 9669d0e | 2017-12-15 23:50:20 | [diff] [blame] | 130 | // Update the corresponding command_controller state. |
| 131 | browser()->command_controller()->LockedFullscreenStateChanged(); |
| 132 | // Update some more states just to make sure the wrong commands don't get |
| 133 | // enabled. |
| 134 | browser()->command_controller()->TabStateChanged(); |
| 135 | browser()->command_controller()->FullscreenStateChanged(); |
| 136 | browser()->command_controller()->PrintingStateChanged(); |
| 137 | browser()->command_controller()->ExtensionStateChanged(); |
| 138 | // IDC_EXIT is not enabled in locked fullscreen. |
| 139 | EXPECT_FALSE(command_updater->IsCommandEnabled(IDC_EXIT)); |
| 140 | |
Ivan Sandrk | 6ac9c9a | 2018-12-14 14:15:07 | [diff] [blame] | 141 | constexpr int kWhitelistedIds[] = {IDC_CUT, IDC_COPY, IDC_PASTE}; |
Ivan Sandrk | 9669d0e | 2017-12-15 23:50:20 | [diff] [blame] | 142 | |
| 143 | // Go through all the command ids and make sure all non-whitelisted commands |
| 144 | // are disabled. |
| 145 | for (int id : command_updater->GetAllIds()) { |
Jan Wilken Dörrie | a8cb5630 | 2019-06-06 18:59:36 | [diff] [blame] | 146 | if (base::Contains(kWhitelistedIds, id)) { |
Ivan Sandrk | 9669d0e | 2017-12-15 23:50:20 | [diff] [blame] | 147 | continue; |
| 148 | } |
| 149 | EXPECT_FALSE(command_updater->IsCommandEnabled(id)); |
| 150 | } |
| 151 | |
Ivan Sandrk | 6ac9c9a | 2018-12-14 14:15:07 | [diff] [blame] | 152 | // Verify the set of whitelisted commands. |
Ivan Sandrk | 9669d0e | 2017-12-15 23:50:20 | [diff] [blame] | 153 | for (int id : kWhitelistedIds) { |
Ivan Sandrk | 9669d0e | 2017-12-15 23:50:20 | [diff] [blame] | 154 | EXPECT_TRUE(command_updater->IsCommandEnabled(id)); |
| 155 | } |
| 156 | |
| 157 | // Exit locked fullscreen mode. |
| 158 | browser()->window()->GetNativeWindow()->SetProperty( |
Xiyuan Xia | 4f992f2 | 2019-06-05 15:33:46 | [diff] [blame] | 159 | ash::kWindowPinTypeKey, ash::WindowPinType::kNone); |
Ivan Sandrk | 9669d0e | 2017-12-15 23:50:20 | [diff] [blame] | 160 | // Update the corresponding command_controller state. |
| 161 | browser()->command_controller()->LockedFullscreenStateChanged(); |
| 162 | // IDC_EXIT is enabled again. |
| 163 | EXPECT_TRUE(command_updater->IsCommandEnabled(IDC_EXIT)); |
| 164 | } |
| 165 | #endif |
| 166 | |
Cliff Smolinsky | 2c9586e | 2019-02-08 18:48:30 | [diff] [blame] | 167 | IN_PROC_BROWSER_TEST_F(BrowserCommandControllerBrowserTest, |
| 168 | TestTabRestoreServiceInitialized) { |
| 169 | // Note: The command should start out as enabled as the default. |
| 170 | // All the initialization happens before any test code executes, |
| 171 | // so we can't validate it. |
| 172 | |
| 173 | // The TabRestoreService should get initialized (Loaded) |
| 174 | // automatically upon launch. |
| 175 | // Wait for robustness because InProcessBrowserTest::PreRunTestOnMainThread |
| 176 | // does not flush the task scheduler. |
| 177 | TabRestoreServiceLoadWaiter waiter(browser()); |
| 178 | waiter.Wait(); |
| 179 | |
| 180 | // After initialization, the command should become disabled because there's |
| 181 | // nothing to restore. |
| 182 | chrome::BrowserCommandController* commandController = |
| 183 | browser()->command_controller(); |
| 184 | ASSERT_EQ(false, commandController->IsCommandEnabled(IDC_RESTORE_TAB)); |
| 185 | } |
| 186 | |
| 187 | IN_PROC_BROWSER_TEST_F(BrowserCommandControllerBrowserTest, |
| 188 | PRE_TestTabRestoreCommandEnabled) { |
| 189 | ui_test_utils::NavigateToURLWithDisposition( |
| 190 | browser(), GURL("about:"), WindowOpenDisposition::NEW_FOREGROUND_TAB, |
| 191 | ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION); |
| 192 | ASSERT_EQ(2, browser()->tab_strip_model()->count()); |
| 193 | EXPECT_EQ(1, browser()->tab_strip_model()->active_index()); |
| 194 | content::WebContents* tab_to_close = |
| 195 | browser()->tab_strip_model()->GetActiveWebContents(); |
| 196 | content::WebContentsDestroyedWatcher destroyed_watcher(tab_to_close); |
| 197 | browser()->tab_strip_model()->CloseSelectedTabs(); |
| 198 | destroyed_watcher.Wait(); |
| 199 | } |
| 200 | |
| 201 | IN_PROC_BROWSER_TEST_F(BrowserCommandControllerBrowserTest, |
| 202 | TestTabRestoreCommandEnabled) { |
| 203 | // The TabRestoreService should get initialized (Loaded) |
| 204 | // automatically upon launch. |
| 205 | // Wait for robustness because InProcessBrowserTest::PreRunTestOnMainThread |
| 206 | // does not flush the task scheduler. |
| 207 | TabRestoreServiceLoadWaiter waiter(browser()); |
| 208 | waiter.Wait(); |
| 209 | |
| 210 | // After initialization, the command should remain enabled because there's |
| 211 | // one tab to restore. |
| 212 | chrome::BrowserCommandController* commandController = |
| 213 | browser()->command_controller(); |
| 214 | ASSERT_EQ(true, commandController->IsCommandEnabled(IDC_RESTORE_TAB)); |
| 215 | } |
| 216 | |
Ivan Sandrk | 9669d0e | 2017-12-15 23:50:20 | [diff] [blame] | 217 | } // namespace chrome |