blob: 674918188bc01c553b4dcf7d593bd901c55f85b9 [file] [log] [blame]
[email protected]0b887622014-09-03 02:31:031#!/usr/bin/env python
2# Copyright 2014 The Chromium Authors. All rights reserved.
3# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6import argparse
[email protected]456ca7f2016-05-23 21:33:287import json
[email protected]0b887622014-09-03 02:31:038import re
9import sys
10
11from collections import defaultdict
12
13import git_common as git
14
[email protected]d629fb42014-10-01 09:40:1015
Andrii Shyshkalov80cae422017-04-26 23:01:4216FOOTER_PATTERN = re.compile(r'^\s*([\w-]+): *(.*)$')
Andrii Shyshkalov49fe9222016-12-15 10:05:0617CHROME_COMMIT_POSITION_PATTERN = re.compile(r'^([\w/\-\.]+)@{#(\d+)}$')
Aaron Gabled9a67562018-01-03 23:56:0818FOOTER_KEY_BLACKLIST = set(['http', 'https'])
[email protected]0b887622014-09-03 02:31:0319
[email protected]d629fb42014-10-01 09:40:1020
[email protected]0b887622014-09-03 02:31:0321def normalize_name(header):
22 return '-'.join([ word.title() for word in header.strip().split('-') ])
23
24
25def parse_footer(line):
[email protected]f2aa52b2016-06-03 12:58:2026 """Returns footer's (key, value) if footer is valid, else None."""
[email protected]0b887622014-09-03 02:31:0327 match = FOOTER_PATTERN.match(line)
Aaron Gabled9a67562018-01-03 23:56:0828 if match and match.group(1) not in FOOTER_KEY_BLACKLIST:
[email protected]0b887622014-09-03 02:31:0329 return (match.group(1), match.group(2))
Aaron Gabled9a67562018-01-03 23:56:0830 return None
[email protected]0b887622014-09-03 02:31:0331
32
33def parse_footers(message):
34 """Parses a git commit message into a multimap of footers."""
[email protected]f2aa52b2016-06-03 12:58:2035 _, _, parsed_footers = split_footers(message)
36 footer_map = defaultdict(list)
37 if parsed_footers:
38 # Read footers from bottom to top, because latter takes precedense,
39 # and we want it to be first in the multimap value.
40 for (k, v) in reversed(parsed_footers):
41 footer_map[normalize_name(k)].append(v.strip())
42 return footer_map
43
44
Andrii Shyshkalov04b51d62017-05-11 11:21:3045def matches_footer_key(line, key):
46 """Returns whether line is a valid footer whose key matches a given one.
47
48 Keys are compared in normalized form.
49 """
50 r = parse_footer(line)
51 if r is None:
Andrii Shyshkalov1a91c602017-05-11 12:35:5652 return False
Andrii Shyshkalov04b51d62017-05-11 11:21:3053 return normalize_name(r[0]) == normalize_name(key)
54
55
[email protected]f2aa52b2016-06-03 12:58:2056def split_footers(message):
57 """Returns (non_footer_lines, footer_lines, parsed footers).
58
59 Guarantees that:
Aaron Gable4be31872018-01-04 00:30:4660 (non_footer_lines + footer_lines) ~= message.splitlines(), with at
61 most one new newline, if the last paragraph is text followed by footers.
[email protected]f2aa52b2016-06-03 12:58:2062 parsed_footers is parse_footer applied on each line of footer_lines.
Andrii Shyshkalov04b51d62017-05-11 11:21:3063 There could be fewer parsed_footers than footer lines if some lines in
64 last paragraph are malformed.
[email protected]f2aa52b2016-06-03 12:58:2065 """
66 message_lines = list(message.splitlines())
[email protected]0b887622014-09-03 02:31:0367 footer_lines = []
Aaron Gable4be31872018-01-04 00:30:4668 maybe_footer_lines = []
[email protected]f2aa52b2016-06-03 12:58:2069 for line in reversed(message_lines):
[email protected]0b887622014-09-03 02:31:0370 if line == '' or line.isspace():
71 break
Aaron Gable4be31872018-01-04 00:30:4672 elif parse_footer(line):
73 footer_lines.extend(maybe_footer_lines)
74 maybe_footer_lines = []
75 footer_lines.append(line)
76 else:
77 # We only want to include malformed lines if they are preceeded by
78 # well-formed lines. So keep them in holding until we see a well-formed
79 # line (case above).
80 maybe_footer_lines.append(line)
[email protected]f2aa52b2016-06-03 12:58:2081 else:
82 # The whole description was consisting of footers,
83 # which means those aren't footers.
84 footer_lines = []
[email protected]0b887622014-09-03 02:31:0385
[email protected]f2aa52b2016-06-03 12:58:2086 footer_lines.reverse()
Andrii Shyshkalov04b51d62017-05-11 11:21:3087 footers = filter(None, map(parse_footer, footer_lines))
88 if not footers:
[email protected]f2aa52b2016-06-03 12:58:2089 return message_lines, [], []
Aaron Gable4be31872018-01-04 00:30:4690 if maybe_footer_lines:
91 # If some malformed lines were left over, add a newline to split them
92 # from the well-formed ones.
93 return message_lines[:-len(footer_lines)] + [''], footer_lines, footers
[email protected]f2aa52b2016-06-03 12:58:2094 return message_lines[:-len(footer_lines)], footer_lines, footers
[email protected]0b887622014-09-03 02:31:0395
96
[email protected]3c3c0342016-03-04 11:59:2897def get_footer_change_id(message):
98 """Returns a list of Gerrit's ChangeId from given commit message."""
99 return parse_footers(message).get(normalize_name('Change-Id'), [])
100
101
102def add_footer_change_id(message, change_id):
103 """Returns message with Change-ID footer in it.
104
[email protected]f2aa52b2016-06-03 12:58:20105 Assumes that Change-Id is not yet in footers, which is then inserted at
106 earliest footer line which is after all of these footers:
107 Bug|Issue|Test|Feature.
[email protected]3c3c0342016-03-04 11:59:28108 """
[email protected]f2aa52b2016-06-03 12:58:20109 assert 'Change-Id' not in parse_footers(message)
110 return add_footer(message, 'Change-Id', change_id,
111 after_keys=['Bug', 'Issue', 'Test', 'Feature'])
112
Andrii Shyshkalov18975322017-01-25 15:44:13113
Aaron Gablec06db442017-04-27 00:29:49114def add_footer(message, key, value, after_keys=None, before_keys=None):
[email protected]f2aa52b2016-06-03 12:58:20115 """Returns a message with given footer appended.
116
Aaron Gablec06db442017-04-27 00:29:49117 If after_keys and before_keys are both None (default), appends footer last.
118 If after_keys is provided and matches footers already present, inserts footer
119 as *early* as possible while still appearing after all provided keys, even
120 if doing so conflicts with before_keys.
121 If before_keys is provided, inserts footer as late as possible while still
122 appearing before all provided keys.
123
[email protected]f2aa52b2016-06-03 12:58:20124 For example, given
125 message='Header.\n\nAdded: 2016\nBug: 123\nVerified-By: CQ'
126 after_keys=['Bug', 'Issue']
127 the new footer will be inserted between Bug and Verified-By existing footers.
128 """
129 assert key == normalize_name(key), 'Use normalized key'
130 new_footer = '%s: %s' % (key, value)
131
Aaron Gablec06db442017-04-27 00:29:49132 top_lines, footer_lines, _ = split_footers(message)
[email protected]f2aa52b2016-06-03 12:58:20133 if not footer_lines:
134 if not top_lines or top_lines[-1] != '':
135 top_lines.append('')
136 footer_lines = [new_footer]
[email protected]9fc50db2016-03-17 12:38:55137 else:
Aaron Gablec06db442017-04-27 00:29:49138 after_keys = set(map(normalize_name, after_keys or []))
139 after_indices = [
140 footer_lines.index(x) for x in footer_lines for k in after_keys
Andrii Shyshkalov04b51d62017-05-11 11:21:30141 if matches_footer_key(x, k)]
Aaron Gablec06db442017-04-27 00:29:49142 before_keys = set(map(normalize_name, before_keys or []))
143 before_indices = [
144 footer_lines.index(x) for x in footer_lines for k in before_keys
Andrii Shyshkalov04b51d62017-05-11 11:21:30145 if matches_footer_key(x, k)]
Aaron Gablec06db442017-04-27 00:29:49146 if after_indices:
147 # after_keys takes precedence, even if there's a conflict.
148 insert_idx = max(after_indices) + 1
149 elif before_indices:
150 insert_idx = min(before_indices)
[email protected]3c3c0342016-03-04 11:59:28151 else:
Aaron Gablec06db442017-04-27 00:29:49152 insert_idx = len(footer_lines)
153 footer_lines.insert(insert_idx, new_footer)
[email protected]f2aa52b2016-06-03 12:58:20154 return '\n'.join(top_lines + footer_lines)
[email protected]3c3c0342016-03-04 11:59:28155
156
Aaron Gableb584c4f2017-04-26 23:28:08157def remove_footer(message, key):
158 """Returns a message with all instances of given footer removed."""
159 key = normalize_name(key)
160 top_lines, footer_lines, _ = split_footers(message)
161 if not footer_lines:
162 return message
Aaron Gableb08ba652017-07-12 22:30:02163 new_footer_lines = []
164 for line in footer_lines:
165 try:
166 f = normalize_name(parse_footer(line)[0])
167 if f != key:
168 new_footer_lines.append(line)
169 except TypeError:
170 # If the footer doesn't parse (i.e. is malformed), just let it carry over.
171 new_footer_lines.append(line)
Aaron Gableb584c4f2017-04-26 23:28:08172 return '\n'.join(top_lines + new_footer_lines)
173
174
[email protected]0b887622014-09-03 02:31:03175def get_unique(footers, key):
176 key = normalize_name(key)
177 values = footers[key]
178 assert len(values) <= 1, 'Multiple %s footers' % key
179 if values:
180 return values[0]
181 else:
182 return None
183
184
185def get_position(footers):
[email protected]74c44f62014-09-09 22:35:03186 """Get the commit position from the footers multimap using a heuristic.
[email protected]0b887622014-09-03 02:31:03187
188 Returns:
189 A tuple of the branch and the position on that branch. For example,
190
191 Cr-Commit-Position: refs/heads/master@{#292272}
192
agable814b1ca2016-12-21 21:05:59193 would give the return value ('refs/heads/master', 292272).
[email protected]0b887622014-09-03 02:31:03194 """
195
196 position = get_unique(footers, 'Cr-Commit-Position')
197 if position:
198 match = CHROME_COMMIT_POSITION_PATTERN.match(position)
199 assert match, 'Invalid Cr-Commit-Position value: %s' % position
200 return (match.group(1), match.group(2))
201
[email protected]0b887622014-09-03 02:31:03202 raise ValueError('Unable to infer commit position from footers')
203
204
205def main(args):
206 parser = argparse.ArgumentParser(
207 formatter_class=argparse.ArgumentDefaultsHelpFormatter
208 )
Andrii Shyshkalov22a9cf52017-07-13 12:23:58209 parser.add_argument('ref', nargs='?', help='Git ref to retrieve footers from.'
210 ' Omit to parse stdin.')
[email protected]0b887622014-09-03 02:31:03211
212 g = parser.add_mutually_exclusive_group()
213 g.add_argument('--key', metavar='KEY',
214 help='Get all values for the given footer name, one per '
215 'line (case insensitive)')
216 g.add_argument('--position', action='store_true')
217 g.add_argument('--position-ref', action='store_true')
218 g.add_argument('--position-num', action='store_true')
Andrii Shyshkalov22a9cf52017-07-13 12:23:58219 g.add_argument('--json', help='filename to dump JSON serialized footers to.')
[email protected]0b887622014-09-03 02:31:03220
[email protected]0b887622014-09-03 02:31:03221 opts = parser.parse_args(args)
222
[email protected]456ca7f2016-05-23 21:33:28223 if opts.ref:
224 message = git.run('log', '-1', '--format=%B', opts.ref)
225 else:
Andrii Shyshkalov22a9cf52017-07-13 12:23:58226 message = sys.stdin.read()
[email protected]456ca7f2016-05-23 21:33:28227
[email protected]0b887622014-09-03 02:31:03228 footers = parse_footers(message)
229
230 if opts.key:
231 for v in footers.get(normalize_name(opts.key), []):
232 print v
233 elif opts.position:
234 pos = get_position(footers)
235 print '%s@{#%s}' % (pos[0], pos[1] or '?')
236 elif opts.position_ref:
237 print get_position(footers)[0]
238 elif opts.position_num:
239 pos = get_position(footers)
240 assert pos[1], 'No valid position for commit'
241 print pos[1]
[email protected]456ca7f2016-05-23 21:33:28242 elif opts.json:
243 with open(opts.json, 'w') as f:
244 json.dump(footers, f)
[email protected]0b887622014-09-03 02:31:03245 else:
246 for k in footers.keys():
247 for v in footers[k]:
248 print '%s: %s' % (k, v)
[email protected]013731e2015-02-26 18:28:43249 return 0
[email protected]0b887622014-09-03 02:31:03250
251
252if __name__ == '__main__':
[email protected]013731e2015-02-26 18:28:43253 try:
254 sys.exit(main(sys.argv[1:]))
255 except KeyboardInterrupt:
256 sys.stderr.write('interrupted\n')
257 sys.exit(1)