Daniel Jasper | d07c840 | 2013-07-29 08:19:24 | [diff] [blame] | 1 | //===--- tools/extra/clang-tidy/ClangTidy.cpp - Clang tidy tool -----------===// |
| 2 | // |
| 3 | // The LLVM Compiler Infrastructure |
| 4 | // |
| 5 | // This file is distributed under the University of Illinois Open Source |
| 6 | // License. See LICENSE.TXT for details. |
| 7 | // |
| 8 | //===----------------------------------------------------------------------===// |
| 9 | /// |
| 10 | /// \file This file implements a clang-tidy tool. |
| 11 | /// |
| 12 | /// This tool uses the Clang Tooling infrastructure, see |
| 13 | /// http://clang.llvm.org/docs/HowToSetupToolingForLLVM.html |
| 14 | /// for details on setting it up with LLVM source tree. |
| 15 | /// |
| 16 | //===----------------------------------------------------------------------===// |
| 17 | |
| 18 | #include "ClangTidy.h" |
| 19 | #include "ClangTidyDiagnosticConsumer.h" |
| 20 | #include "ClangTidyModuleRegistry.h" |
| 21 | #include "clang/AST/ASTConsumer.h" |
| 22 | #include "clang/AST/ASTContext.h" |
| 23 | #include "clang/AST/Decl.h" |
| 24 | #include "clang/ASTMatchers/ASTMatchFinder.h" |
Daniel Jasper | d07c840 | 2013-07-29 08:19:24 | [diff] [blame] | 25 | #include "clang/Frontend/ASTConsumers.h" |
| 26 | #include "clang/Frontend/CompilerInstance.h" |
| 27 | #include "clang/Frontend/FrontendActions.h" |
Alexander Kornienko | 38d81b4 | 2014-03-27 10:24:11 | [diff] [blame] | 28 | #include "clang/Frontend/FrontendDiagnostic.h" |
Alexander Kornienko | 175fefb | 2014-01-03 09:31:57 | [diff] [blame] | 29 | #include "clang/Frontend/MultiplexConsumer.h" |
Daniel Jasper | d07c840 | 2013-07-29 08:19:24 | [diff] [blame] | 30 | #include "clang/Frontend/TextDiagnosticPrinter.h" |
Chandler Carruth | 85e6e87 | 2014-01-07 20:05:01 | [diff] [blame] | 31 | #include "clang/Lex/PPCallbacks.h" |
| 32 | #include "clang/Lex/Preprocessor.h" |
Daniel Jasper | d07c840 | 2013-07-29 08:19:24 | [diff] [blame] | 33 | #include "clang/Rewrite/Frontend/FixItRewriter.h" |
| 34 | #include "clang/Rewrite/Frontend/FrontendActions.h" |
Alexander Kornienko | d1199cb | 2014-01-03 17:24:20 | [diff] [blame] | 35 | #include "clang/StaticAnalyzer/Frontend/AnalysisConsumer.h" |
Daniel Jasper | d07c840 | 2013-07-29 08:19:24 | [diff] [blame] | 36 | #include "clang/Tooling/Refactoring.h" |
Benjamin Kramer | fb98b74 | 2014-09-04 10:31:23 | [diff] [blame] | 37 | #include "clang/Tooling/ReplacementsYaml.h" |
Chandler Carruth | 85e6e87 | 2014-01-07 20:05:01 | [diff] [blame] | 38 | #include "clang/Tooling/Tooling.h" |
Alexander Kornienko | 54461eb | 2014-02-06 14:50:10 | [diff] [blame] | 39 | #include "llvm/Support/Process.h" |
Daniel Jasper | d07c840 | 2013-07-29 08:19:24 | [diff] [blame] | 40 | #include "llvm/Support/Signals.h" |
Alexander Kornienko | fb9e92b | 2013-12-19 19:57:05 | [diff] [blame] | 41 | #include <algorithm> |
Alexander Kornienko | 38d81b4 | 2014-03-27 10:24:11 | [diff] [blame] | 42 | #include <utility> |
Daniel Jasper | d07c840 | 2013-07-29 08:19:24 | [diff] [blame] | 43 | |
| 44 | using namespace clang::ast_matchers; |
| 45 | using namespace clang::driver; |
| 46 | using namespace clang::tooling; |
| 47 | using namespace llvm; |
| 48 | |
NAKAMURA Takumi | 71b982b | 2014-07-03 14:12:47 | [diff] [blame] | 49 | template class llvm::Registry<clang::tidy::ClangTidyModule>; |
| 50 | |
Daniel Jasper | d07c840 | 2013-07-29 08:19:24 | [diff] [blame] | 51 | namespace clang { |
| 52 | namespace tidy { |
Alexander Kornienko | 175fefb | 2014-01-03 09:31:57 | [diff] [blame] | 53 | |
Daniel Jasper | d07c840 | 2013-07-29 08:19:24 | [diff] [blame] | 54 | namespace { |
Alexander Kornienko | 54461eb | 2014-02-06 14:50:10 | [diff] [blame] | 55 | static const char *AnalyzerCheckNamePrefix = "clang-analyzer-"; |
Manuel Klimek | 814f9bd | 2013-11-14 15:49:44 | [diff] [blame] | 56 | |
Craig Topper | 45857d4 | 2015-10-18 05:14:41 | [diff] [blame] | 57 | static const StringRef StaticAnalyzerChecks[] = { |
Alexander Kornienko | fb9e92b | 2013-12-19 19:57:05 | [diff] [blame] | 58 | #define GET_CHECKERS |
| 59 | #define CHECKER(FULLNAME, CLASS, DESCFILE, HELPTEXT, GROUPINDEX, HIDDEN) \ |
| 60 | FULLNAME, |
NAKAMURA Takumi | 321b7d3 | 2014-01-03 10:24:51 | [diff] [blame] | 61 | #include "../../../lib/StaticAnalyzer/Checkers/Checkers.inc" |
Alexander Kornienko | fb9e92b | 2013-12-19 19:57:05 | [diff] [blame] | 62 | #undef CHECKER |
| 63 | #undef GET_CHECKERS |
| 64 | }; |
| 65 | |
Alexander Kornienko | 54461eb | 2014-02-06 14:50:10 | [diff] [blame] | 66 | class AnalyzerDiagnosticConsumer : public ento::PathDiagnosticConsumer { |
| 67 | public: |
| 68 | AnalyzerDiagnosticConsumer(ClangTidyContext &Context) : Context(Context) {} |
| 69 | |
Alexander Kornienko | cb9272f | 2014-02-27 13:14:51 | [diff] [blame] | 70 | void FlushDiagnosticsImpl(std::vector<const ento::PathDiagnostic *> &Diags, |
Craig Topper | a3dbe84 | 2014-03-02 10:20:11 | [diff] [blame] | 71 | FilesMade *filesMade) override { |
Alexander Kornienko | df1e3cb | 2014-03-06 10:17:46 | [diff] [blame] | 72 | for (const ento::PathDiagnostic *PD : Diags) { |
Alexander Kornienko | d1afc70 | 2014-02-12 09:52:07 | [diff] [blame] | 73 | SmallString<64> CheckName(AnalyzerCheckNamePrefix); |
| 74 | CheckName += PD->getCheckName(); |
Alexander Kornienko | 95cd50f | 2014-03-06 13:24:28 | [diff] [blame] | 75 | Context.diag(CheckName, PD->getLocation().asLocation(), |
| 76 | PD->getShortDescription()) |
| 77 | << PD->path.back()->getRanges(); |
Alexander Kornienko | 54461eb | 2014-02-06 14:50:10 | [diff] [blame] | 78 | |
Alexander Kornienko | df1e3cb | 2014-03-06 10:17:46 | [diff] [blame] | 79 | for (const auto &DiagPiece : |
| 80 | PD->path.flatten(/*ShouldFlattenMacros=*/true)) { |
Alexander Kornienko | 95cd50f | 2014-03-06 13:24:28 | [diff] [blame] | 81 | Context.diag(CheckName, DiagPiece->getLocation().asLocation(), |
| 82 | DiagPiece->getString(), DiagnosticIDs::Note) |
| 83 | << DiagPiece->getRanges(); |
Alexander Kornienko | 54461eb | 2014-02-06 14:50:10 | [diff] [blame] | 84 | } |
| 85 | } |
| 86 | } |
| 87 | |
Craig Topper | a3dbe84 | 2014-03-02 10:20:11 | [diff] [blame] | 88 | StringRef getName() const override { return "ClangTidyDiags"; } |
| 89 | bool supportsLogicalOpControlFlow() const override { return true; } |
| 90 | bool supportsCrossFileDiagnostics() const override { return true; } |
Alexander Kornienko | 54461eb | 2014-02-06 14:50:10 | [diff] [blame] | 91 | |
| 92 | private: |
| 93 | ClangTidyContext &Context; |
Alexander Kornienko | 54461eb | 2014-02-06 14:50:10 | [diff] [blame] | 94 | }; |
| 95 | |
Alexander Kornienko | 38d81b4 | 2014-03-27 10:24:11 | [diff] [blame] | 96 | class ErrorReporter { |
| 97 | public: |
| 98 | ErrorReporter(bool ApplyFixes) |
| 99 | : Files(FileSystemOptions()), DiagOpts(new DiagnosticOptions()), |
| 100 | DiagPrinter(new TextDiagnosticPrinter(llvm::outs(), &*DiagOpts)), |
| 101 | Diags(IntrusiveRefCntPtr<DiagnosticIDs>(new DiagnosticIDs), &*DiagOpts, |
| 102 | DiagPrinter), |
| 103 | SourceMgr(Diags, Files), Rewrite(SourceMgr, LangOpts), |
Jonathan Roelofs | d60388a | 2016-01-13 17:36:41 | [diff] [blame] | 104 | ApplyFixes(ApplyFixes), TotalFixes(0), AppliedFixes(0), |
| 105 | WarningsAsErrors(0) { |
Alexander Kornienko | 38d81b4 | 2014-03-27 10:24:11 | [diff] [blame] | 106 | DiagOpts->ShowColors = llvm::sys::Process::StandardOutHasColors(); |
| 107 | DiagPrinter->BeginSourceFile(LangOpts); |
| 108 | } |
| 109 | |
Etienne Bergeron | 4eaeace | 2016-04-06 14:07:51 | [diff] [blame^] | 110 | SourceManager &getSourceManager() { return SourceMgr; } |
Haojian Wu | f7692a2 | 2016-02-26 09:19:33 | [diff] [blame] | 111 | |
Alexander Kornienko | 742790c | 2014-07-02 15:05:04 | [diff] [blame] | 112 | void reportDiagnostic(const ClangTidyError &Error) { |
| 113 | const ClangTidyMessage &Message = Error.Message; |
Alexander Kornienko | 38d81b4 | 2014-03-27 10:24:11 | [diff] [blame] | 114 | SourceLocation Loc = getLocation(Message.FilePath, Message.FileOffset); |
| 115 | // Contains a pair for each attempted fix: location and whether the fix was |
| 116 | // applied successfully. |
| 117 | SmallVector<std::pair<SourceLocation, bool>, 4> FixLocations; |
| 118 | { |
Alexander Kornienko | 742790c | 2014-07-02 15:05:04 | [diff] [blame] | 119 | auto Level = static_cast<DiagnosticsEngine::Level>(Error.DiagLevel); |
Jonathan Roelofs | d60388a | 2016-01-13 17:36:41 | [diff] [blame] | 120 | std::string Name = Error.CheckName; |
| 121 | if (Error.IsWarningAsError) { |
| 122 | Name += ",-warnings-as-errors"; |
| 123 | Level = DiagnosticsEngine::Error; |
| 124 | WarningsAsErrors++; |
| 125 | } |
Alexander Kornienko | 58fe57a | 2015-11-16 13:06:15 | [diff] [blame] | 126 | auto Diag = Diags.Report(Loc, Diags.getCustomDiagID(Level, "%0 [%1]")) |
Jonathan Roelofs | d60388a | 2016-01-13 17:36:41 | [diff] [blame] | 127 | << Message.Message << Name; |
Alexander Kornienko | 742790c | 2014-07-02 15:05:04 | [diff] [blame] | 128 | for (const tooling::Replacement &Fix : Error.Fix) { |
Etienne Bergeron | 6feeb65 | 2016-03-22 17:51:27 | [diff] [blame] | 129 | // Retrieve the source range for applicable fixes. Macro definitions |
| 130 | // on the command line have locations in a virtual buffer and don't |
| 131 | // have valid file paths and are therefore not applicable. |
| 132 | SourceRange Range; |
| 133 | SourceLocation FixLoc; |
| 134 | if (Fix.isApplicable()) { |
| 135 | SmallString<128> FixAbsoluteFilePath = Fix.getFilePath(); |
| 136 | Files.makeAbsolutePath(FixAbsoluteFilePath); |
| 137 | FixLoc = getLocation(FixAbsoluteFilePath, Fix.getOffset()); |
| 138 | SourceLocation FixEndLoc = FixLoc.getLocWithOffset(Fix.getLength()); |
| 139 | Range = SourceRange(FixLoc, FixEndLoc); |
| 140 | Diag << FixItHint::CreateReplacement(Range, Fix.getReplacementText()); |
| 141 | } |
Etienne Bergeron | 4eaeace | 2016-04-06 14:07:51 | [diff] [blame^] | 142 | |
Alexander Kornienko | 742790c | 2014-07-02 15:05:04 | [diff] [blame] | 143 | ++TotalFixes; |
| 144 | if (ApplyFixes) { |
| 145 | bool Success = Fix.isApplicable() && Fix.apply(Rewrite); |
| 146 | if (Success) |
| 147 | ++AppliedFixes; |
| 148 | FixLocations.push_back(std::make_pair(FixLoc, Success)); |
Alexander Kornienko | 38d81b4 | 2014-03-27 10:24:11 | [diff] [blame] | 149 | } |
| 150 | } |
| 151 | } |
| 152 | for (auto Fix : FixLocations) { |
| 153 | Diags.Report(Fix.first, Fix.second ? diag::note_fixit_applied |
| 154 | : diag::note_fixit_failed); |
| 155 | } |
Alexander Kornienko | 742790c | 2014-07-02 15:05:04 | [diff] [blame] | 156 | for (const ClangTidyMessage &Note : Error.Notes) |
| 157 | reportNote(Note); |
Alexander Kornienko | 38d81b4 | 2014-03-27 10:24:11 | [diff] [blame] | 158 | } |
| 159 | |
| 160 | void Finish() { |
| 161 | // FIXME: Run clang-format on changes. |
| 162 | if (ApplyFixes && TotalFixes > 0) { |
| 163 | llvm::errs() << "clang-tidy applied " << AppliedFixes << " of " |
| 164 | << TotalFixes << " suggested fixes.\n"; |
| 165 | Rewrite.overwriteChangedFiles(); |
| 166 | } |
| 167 | } |
| 168 | |
Jonathan Roelofs | d60388a | 2016-01-13 17:36:41 | [diff] [blame] | 169 | unsigned getWarningsAsErrorsCount() const { return WarningsAsErrors; } |
| 170 | |
Alexander Kornienko | 38d81b4 | 2014-03-27 10:24:11 | [diff] [blame] | 171 | private: |
| 172 | SourceLocation getLocation(StringRef FilePath, unsigned Offset) { |
| 173 | if (FilePath.empty()) |
| 174 | return SourceLocation(); |
| 175 | |
| 176 | const FileEntry *File = SourceMgr.getFileManager().getFile(FilePath); |
| 177 | FileID ID = SourceMgr.createFileID(File, SourceLocation(), SrcMgr::C_User); |
| 178 | return SourceMgr.getLocForStartOfFile(ID).getLocWithOffset(Offset); |
| 179 | } |
| 180 | |
Alexander Kornienko | 742790c | 2014-07-02 15:05:04 | [diff] [blame] | 181 | void reportNote(const ClangTidyMessage &Message) { |
| 182 | SourceLocation Loc = getLocation(Message.FilePath, Message.FileOffset); |
| 183 | DiagnosticBuilder Diag = |
| 184 | Diags.Report(Loc, Diags.getCustomDiagID(DiagnosticsEngine::Note, "%0")) |
| 185 | << Message.Message; |
| 186 | } |
| 187 | |
Alexander Kornienko | 38d81b4 | 2014-03-27 10:24:11 | [diff] [blame] | 188 | FileManager Files; |
| 189 | LangOptions LangOpts; // FIXME: use langopts from each original file |
| 190 | IntrusiveRefCntPtr<DiagnosticOptions> DiagOpts; |
| 191 | DiagnosticConsumer *DiagPrinter; |
| 192 | DiagnosticsEngine Diags; |
| 193 | SourceManager SourceMgr; |
| 194 | Rewriter Rewrite; |
| 195 | bool ApplyFixes; |
NAKAMURA Takumi | 4dd1813 | 2014-03-27 14:53:37 | [diff] [blame] | 196 | unsigned TotalFixes; |
| 197 | unsigned AppliedFixes; |
Jonathan Roelofs | d60388a | 2016-01-13 17:36:41 | [diff] [blame] | 198 | unsigned WarningsAsErrors; |
Alexander Kornienko | 38d81b4 | 2014-03-27 10:24:11 | [diff] [blame] | 199 | }; |
| 200 | |
Alexander Kornienko | a469522 | 2014-06-05 13:31:45 | [diff] [blame] | 201 | class ClangTidyASTConsumer : public MultiplexConsumer { |
| 202 | public: |
David Blaikie | 680c4c8 | 2014-08-10 19:56:59 | [diff] [blame] | 203 | ClangTidyASTConsumer(std::vector<std::unique_ptr<ASTConsumer>> Consumers, |
Alexander Kornienko | a469522 | 2014-06-05 13:31:45 | [diff] [blame] | 204 | std::unique_ptr<ast_matchers::MatchFinder> Finder, |
| 205 | std::vector<std::unique_ptr<ClangTidyCheck>> Checks) |
David Blaikie | 680c4c8 | 2014-08-10 19:56:59 | [diff] [blame] | 206 | : MultiplexConsumer(std::move(Consumers)), Finder(std::move(Finder)), |
Alexander Kornienko | a469522 | 2014-06-05 13:31:45 | [diff] [blame] | 207 | Checks(std::move(Checks)) {} |
| 208 | |
| 209 | private: |
| 210 | std::unique_ptr<ast_matchers::MatchFinder> Finder; |
| 211 | std::vector<std::unique_ptr<ClangTidyCheck>> Checks; |
| 212 | }; |
| 213 | |
Alexander Kornienko | 175fefb | 2014-01-03 09:31:57 | [diff] [blame] | 214 | } // namespace |
Alexander Kornienko | fb9e92b | 2013-12-19 19:57:05 | [diff] [blame] | 215 | |
Alexander Kornienko | 175fefb | 2014-01-03 09:31:57 | [diff] [blame] | 216 | ClangTidyASTConsumerFactory::ClangTidyASTConsumerFactory( |
Alexander Kornienko | a469522 | 2014-06-05 13:31:45 | [diff] [blame] | 217 | ClangTidyContext &Context) |
| 218 | : Context(Context), CheckFactories(new ClangTidyCheckFactories) { |
Alexander Kornienko | 175fefb | 2014-01-03 09:31:57 | [diff] [blame] | 219 | for (ClangTidyModuleRegistry::iterator I = ClangTidyModuleRegistry::begin(), |
| 220 | E = ClangTidyModuleRegistry::end(); |
| 221 | I != E; ++I) { |
Ahmed Charles | 6a2dc5c | 2014-03-09 09:24:40 | [diff] [blame] | 222 | std::unique_ptr<ClangTidyModule> Module(I->instantiate()); |
Alexander Kornienko | 175fefb | 2014-01-03 09:31:57 | [diff] [blame] | 223 | Module->addCheckFactories(*CheckFactories); |
| 224 | } |
Alexander Kornienko | 175fefb | 2014-01-03 09:31:57 | [diff] [blame] | 225 | } |
Alexander Kornienko | fb9e92b | 2013-12-19 19:57:05 | [diff] [blame] | 226 | |
Gabor Horvath | 3438321 | 2015-03-11 17:25:22 | [diff] [blame] | 227 | static void setStaticAnalyzerCheckerOpts(const ClangTidyOptions &Opts, |
| 228 | AnalyzerOptionsRef AnalyzerOptions) { |
| 229 | StringRef AnalyzerPrefix(AnalyzerCheckNamePrefix); |
| 230 | for (const auto &Opt : Opts.CheckOptions) { |
| 231 | StringRef OptName(Opt.first); |
| 232 | if (!OptName.startswith(AnalyzerPrefix)) |
| 233 | continue; |
| 234 | AnalyzerOptions->Config[OptName.substr(AnalyzerPrefix.size())] = Opt.second; |
| 235 | } |
| 236 | } |
| 237 | |
David Blaikie | 680c4c8 | 2014-08-10 19:56:59 | [diff] [blame] | 238 | std::unique_ptr<clang::ASTConsumer> |
| 239 | ClangTidyASTConsumerFactory::CreateASTConsumer( |
Alexander Kornienko | 175fefb | 2014-01-03 09:31:57 | [diff] [blame] | 240 | clang::CompilerInstance &Compiler, StringRef File) { |
| 241 | // FIXME: Move this to a separate method, so that CreateASTConsumer doesn't |
| 242 | // modify Compiler. |
| 243 | Context.setSourceManager(&Compiler.getSourceManager()); |
Alexander Kornienko | a469522 | 2014-06-05 13:31:45 | [diff] [blame] | 244 | Context.setCurrentFile(File); |
Alexander Kornienko | ad21688 | 2014-07-14 14:10:03 | [diff] [blame] | 245 | Context.setASTContext(&Compiler.getASTContext()); |
Alexander Kornienko | a469522 | 2014-06-05 13:31:45 | [diff] [blame] | 246 | |
Haojian Wu | f7692a2 | 2016-02-26 09:19:33 | [diff] [blame] | 247 | auto WorkingDir = Compiler.getSourceManager() |
| 248 | .getFileManager() |
| 249 | .getVirtualFileSystem() |
| 250 | ->getCurrentWorkingDirectory(); |
| 251 | if (WorkingDir) |
| 252 | Context.setCurrentBuildDirectory(WorkingDir.get()); |
| 253 | |
Alexander Kornienko | a469522 | 2014-06-05 13:31:45 | [diff] [blame] | 254 | std::vector<std::unique_ptr<ClangTidyCheck>> Checks; |
Alexander Kornienko | 6e0cbc8 | 2014-09-12 08:53:36 | [diff] [blame] | 255 | CheckFactories->createChecks(&Context, Checks); |
Alexander Kornienko | a469522 | 2014-06-05 13:31:45 | [diff] [blame] | 256 | |
Samuel Benzaquen | aedd994 | 2014-10-23 17:23:20 | [diff] [blame] | 257 | ast_matchers::MatchFinder::MatchFinderOptions FinderOptions; |
| 258 | if (auto *P = Context.getCheckProfileData()) |
| 259 | FinderOptions.CheckProfiling.emplace(P->Records); |
| 260 | |
Alexander Kornienko | a469522 | 2014-06-05 13:31:45 | [diff] [blame] | 261 | std::unique_ptr<ast_matchers::MatchFinder> Finder( |
Samuel Benzaquen | aedd994 | 2014-10-23 17:23:20 | [diff] [blame] | 262 | new ast_matchers::MatchFinder(std::move(FinderOptions))); |
| 263 | |
Alexander Kornienko | a469522 | 2014-06-05 13:31:45 | [diff] [blame] | 264 | for (auto &Check : Checks) { |
Alexander Kornienko | a469522 | 2014-06-05 13:31:45 | [diff] [blame] | 265 | Check->registerMatchers(&*Finder); |
Alexander Kornienko | df1e3cb | 2014-03-06 10:17:46 | [diff] [blame] | 266 | Check->registerPPCallbacks(Compiler); |
Alexander Kornienko | a469522 | 2014-06-05 13:31:45 | [diff] [blame] | 267 | } |
Alexander Kornienko | 175fefb | 2014-01-03 09:31:57 | [diff] [blame] | 268 | |
David Blaikie | 680c4c8 | 2014-08-10 19:56:59 | [diff] [blame] | 269 | std::vector<std::unique_ptr<ASTConsumer>> Consumers; |
Alexander Kornienko | a469522 | 2014-06-05 13:31:45 | [diff] [blame] | 270 | if (!Checks.empty()) |
| 271 | Consumers.push_back(Finder->newASTConsumer()); |
Alexander Kornienko | 298b382 | 2014-02-13 16:10:47 | [diff] [blame] | 272 | |
Alex McCarthy | fec08c7 | 2014-04-30 14:09:24 | [diff] [blame] | 273 | AnalyzerOptionsRef AnalyzerOptions = Compiler.getAnalyzerOpts(); |
| 274 | // FIXME: Remove this option once clang's cfg-temporary-dtors option defaults |
| 275 | // to true. |
| 276 | AnalyzerOptions->Config["cfg-temporary-dtors"] = |
Alexander Kornienko | a469522 | 2014-06-05 13:31:45 | [diff] [blame] | 277 | Context.getOptions().AnalyzeTemporaryDtors ? "true" : "false"; |
Alex McCarthy | fec08c7 | 2014-04-30 14:09:24 | [diff] [blame] | 278 | |
Alexander Kornienko | 6e0cbc8 | 2014-09-12 08:53:36 | [diff] [blame] | 279 | GlobList &Filter = Context.getChecksFilter(); |
Alexander Kornienko | a469522 | 2014-06-05 13:31:45 | [diff] [blame] | 280 | AnalyzerOptions->CheckersControlList = getCheckersControlList(Filter); |
Alex McCarthy | fec08c7 | 2014-04-30 14:09:24 | [diff] [blame] | 281 | if (!AnalyzerOptions->CheckersControlList.empty()) { |
Gabor Horvath | 3438321 | 2015-03-11 17:25:22 | [diff] [blame] | 282 | setStaticAnalyzerCheckerOpts(Context.getOptions(), AnalyzerOptions); |
Alex McCarthy | fec08c7 | 2014-04-30 14:09:24 | [diff] [blame] | 283 | AnalyzerOptions->AnalysisStoreOpt = RegionStoreModel; |
| 284 | AnalyzerOptions->AnalysisDiagOpt = PD_NONE; |
| 285 | AnalyzerOptions->AnalyzeNestedBlocks = true; |
| 286 | AnalyzerOptions->eagerlyAssumeBinOpBifurcation = true; |
David Blaikie | 680c4c8 | 2014-08-10 19:56:59 | [diff] [blame] | 287 | std::unique_ptr<ento::AnalysisASTConsumer> AnalysisConsumer = |
Ted Kremenek | 4d1692f | 2014-08-27 15:14:47 | [diff] [blame] | 288 | ento::CreateAnalysisConsumer(Compiler); |
Alexander Kornienko | 298b382 | 2014-02-13 16:10:47 | [diff] [blame] | 289 | AnalysisConsumer->AddDiagnosticConsumer( |
| 290 | new AnalyzerDiagnosticConsumer(Context)); |
David Blaikie | 680c4c8 | 2014-08-10 19:56:59 | [diff] [blame] | 291 | Consumers.push_back(std::move(AnalysisConsumer)); |
Alexander Kornienko | 298b382 | 2014-02-13 16:10:47 | [diff] [blame] | 292 | } |
David Blaikie | 680c4c8 | 2014-08-10 19:56:59 | [diff] [blame] | 293 | return llvm::make_unique<ClangTidyASTConsumer>( |
| 294 | std::move(Consumers), std::move(Finder), std::move(Checks)); |
Alexander Kornienko | 175fefb | 2014-01-03 09:31:57 | [diff] [blame] | 295 | } |
| 296 | |
Alexander Kornienko | 6e0cbc8 | 2014-09-12 08:53:36 | [diff] [blame] | 297 | std::vector<std::string> ClangTidyASTConsumerFactory::getCheckNames() { |
Alexander Kornienko | 175fefb | 2014-01-03 09:31:57 | [diff] [blame] | 298 | std::vector<std::string> CheckNames; |
Alexander Kornienko | 6e0cbc8 | 2014-09-12 08:53:36 | [diff] [blame] | 299 | GlobList &Filter = Context.getChecksFilter(); |
Alexander Kornienko | df1e3cb | 2014-03-06 10:17:46 | [diff] [blame] | 300 | for (const auto &CheckFactory : *CheckFactories) { |
Alexander Kornienko | b3d331d | 2014-08-06 11:49:10 | [diff] [blame] | 301 | if (Filter.contains(CheckFactory.first)) |
Alexander Kornienko | df1e3cb | 2014-03-06 10:17:46 | [diff] [blame] | 302 | CheckNames.push_back(CheckFactory.first); |
Alexander Kornienko | 175fefb | 2014-01-03 09:31:57 | [diff] [blame] | 303 | } |
| 304 | |
Alexander Kornienko | a469522 | 2014-06-05 13:31:45 | [diff] [blame] | 305 | for (const auto &AnalyzerCheck : getCheckersControlList(Filter)) |
Alexander Kornienko | df1e3cb | 2014-03-06 10:17:46 | [diff] [blame] | 306 | CheckNames.push_back(AnalyzerCheckNamePrefix + AnalyzerCheck.first); |
Alexander Kornienko | 175fefb | 2014-01-03 09:31:57 | [diff] [blame] | 307 | |
| 308 | std::sort(CheckNames.begin(), CheckNames.end()); |
| 309 | return CheckNames; |
| 310 | } |
| 311 | |
Alexander Kornienko | 6e0cbc8 | 2014-09-12 08:53:36 | [diff] [blame] | 312 | ClangTidyOptions::OptionMap ClangTidyASTConsumerFactory::getCheckOptions() { |
| 313 | ClangTidyOptions::OptionMap Options; |
| 314 | std::vector<std::unique_ptr<ClangTidyCheck>> Checks; |
| 315 | CheckFactories->createChecks(&Context, Checks); |
| 316 | for (const auto &Check : Checks) |
| 317 | Check->storeOptions(Options); |
| 318 | return Options; |
| 319 | } |
| 320 | |
Alexander Kornienko | 175fefb | 2014-01-03 09:31:57 | [diff] [blame] | 321 | ClangTidyASTConsumerFactory::CheckersList |
Alexander Kornienko | b3d331d | 2014-08-06 11:49:10 | [diff] [blame] | 322 | ClangTidyASTConsumerFactory::getCheckersControlList(GlobList &Filter) { |
Alexander Kornienko | 175fefb | 2014-01-03 09:31:57 | [diff] [blame] | 323 | CheckersList List; |
Alexander Kornienko | 175fefb | 2014-01-03 09:31:57 | [diff] [blame] | 324 | |
| 325 | bool AnalyzerChecksEnabled = false; |
Alexander Kornienko | df1e3cb | 2014-03-06 10:17:46 | [diff] [blame] | 326 | for (StringRef CheckName : StaticAnalyzerChecks) { |
| 327 | std::string Checker((AnalyzerCheckNamePrefix + CheckName).str()); |
Alexander Kornienko | a469522 | 2014-06-05 13:31:45 | [diff] [blame] | 328 | AnalyzerChecksEnabled = |
| 329 | AnalyzerChecksEnabled || |
Alexander Kornienko | b3d331d | 2014-08-06 11:49:10 | [diff] [blame] | 330 | (!CheckName.startswith("debug") && Filter.contains(Checker)); |
Alexander Kornienko | 175fefb | 2014-01-03 09:31:57 | [diff] [blame] | 331 | } |
| 332 | |
| 333 | if (AnalyzerChecksEnabled) { |
| 334 | // Run our regex against all possible static analyzer checkers. Note that |
| 335 | // debug checkers print values / run programs to visualize the CFG and are |
| 336 | // thus not applicable to clang-tidy in general. |
| 337 | // |
Alexander Kornienko | fb9e92b | 2013-12-19 19:57:05 | [diff] [blame] | 338 | // Always add all core checkers if any other static analyzer checks are |
Alexander Kornienko | 175fefb | 2014-01-03 09:31:57 | [diff] [blame] | 339 | // enabled. This is currently necessary, as other path sensitive checks |
| 340 | // rely on the core checkers. |
Alexander Kornienko | df1e3cb | 2014-03-06 10:17:46 | [diff] [blame] | 341 | for (StringRef CheckName : StaticAnalyzerChecks) { |
| 342 | std::string Checker((AnalyzerCheckNamePrefix + CheckName).str()); |
Alexander Kornienko | fb9e92b | 2013-12-19 19:57:05 | [diff] [blame] | 343 | |
Alexander Kornienko | df1e3cb | 2014-03-06 10:17:46 | [diff] [blame] | 344 | if (CheckName.startswith("core") || |
Alexander Kornienko | b3d331d | 2014-08-06 11:49:10 | [diff] [blame] | 345 | (!CheckName.startswith("debug") && Filter.contains(Checker))) |
Alexander Kornienko | df1e3cb | 2014-03-06 10:17:46 | [diff] [blame] | 346 | List.push_back(std::make_pair(CheckName, true)); |
Alexander Kornienko | fb9e92b | 2013-12-19 19:57:05 | [diff] [blame] | 347 | } |
| 348 | } |
Alexander Kornienko | 175fefb | 2014-01-03 09:31:57 | [diff] [blame] | 349 | return List; |
| 350 | } |
Daniel Jasper | d07c840 | 2013-07-29 08:19:24 | [diff] [blame] | 351 | |
Peter Collingbourne | b17a3b3 | 2014-03-02 23:34:48 | [diff] [blame] | 352 | DiagnosticBuilder ClangTidyCheck::diag(SourceLocation Loc, StringRef Message, |
| 353 | DiagnosticIDs::Level Level) { |
| 354 | return Context->diag(CheckName, Loc, Message, Level); |
Alexander Kornienko | 41bfe8d | 2014-01-13 10:50:51 | [diff] [blame] | 355 | } |
| 356 | |
Daniel Jasper | d07c840 | 2013-07-29 08:19:24 | [diff] [blame] | 357 | void ClangTidyCheck::run(const ast_matchers::MatchFinder::MatchResult &Result) { |
| 358 | Context->setSourceManager(Result.SourceManager); |
| 359 | check(Result); |
| 360 | } |
| 361 | |
Alexander Kornienko | 6e0cbc8 | 2014-09-12 08:53:36 | [diff] [blame] | 362 | OptionsView::OptionsView(StringRef CheckName, |
| 363 | const ClangTidyOptions::OptionMap &CheckOptions) |
| 364 | : NamePrefix(CheckName.str() + "."), CheckOptions(CheckOptions) {} |
| 365 | |
Haojian Wu | c2d7577 | 2016-02-05 11:23:59 | [diff] [blame] | 366 | std::string OptionsView::get(StringRef LocalName, StringRef Default) const { |
Alexander Kornienko | 6e0cbc8 | 2014-09-12 08:53:36 | [diff] [blame] | 367 | const auto &Iter = CheckOptions.find(NamePrefix + LocalName.str()); |
| 368 | if (Iter != CheckOptions.end()) |
| 369 | return Iter->second; |
| 370 | return Default; |
| 371 | } |
| 372 | |
Haojian Wu | c2d7577 | 2016-02-05 11:23:59 | [diff] [blame] | 373 | std::string OptionsView::getLocalOrGlobal(StringRef LocalName, |
| 374 | StringRef Default) const { |
| 375 | auto Iter = CheckOptions.find(NamePrefix + LocalName.str()); |
| 376 | if (Iter != CheckOptions.end()) |
| 377 | return Iter->second; |
| 378 | // Fallback to global setting, if present. |
| 379 | Iter = CheckOptions.find(LocalName.str()); |
| 380 | if (Iter != CheckOptions.end()) |
| 381 | return Iter->second; |
| 382 | return Default; |
| 383 | } |
| 384 | |
Alexander Kornienko | 6e0cbc8 | 2014-09-12 08:53:36 | [diff] [blame] | 385 | void OptionsView::store(ClangTidyOptions::OptionMap &Options, |
| 386 | StringRef LocalName, StringRef Value) const { |
| 387 | Options[NamePrefix + LocalName.str()] = Value; |
| 388 | } |
| 389 | |
| 390 | void OptionsView::store(ClangTidyOptions::OptionMap &Options, |
| 391 | StringRef LocalName, int64_t Value) const { |
| 392 | store(Options, LocalName, llvm::itostr(Value)); |
Alexander Kornienko | 41bfe8d | 2014-01-13 10:50:51 | [diff] [blame] | 393 | } |
| 394 | |
Alexander Kornienko | 33a9bcc | 2014-04-29 15:20:10 | [diff] [blame] | 395 | std::vector<std::string> getCheckNames(const ClangTidyOptions &Options) { |
Alexander Kornienko | a469522 | 2014-06-05 13:31:45 | [diff] [blame] | 396 | clang::tidy::ClangTidyContext Context( |
Alexander Kornienko | d53d268 | 2014-09-04 14:23:36 | [diff] [blame] | 397 | llvm::make_unique<DefaultOptionsProvider>(ClangTidyGlobalOptions(), |
| 398 | Options)); |
Alexander Kornienko | a469522 | 2014-06-05 13:31:45 | [diff] [blame] | 399 | ClangTidyASTConsumerFactory Factory(Context); |
Alexander Kornienko | 6e0cbc8 | 2014-09-12 08:53:36 | [diff] [blame] | 400 | return Factory.getCheckNames(); |
| 401 | } |
| 402 | |
| 403 | ClangTidyOptions::OptionMap getCheckOptions(const ClangTidyOptions &Options) { |
| 404 | clang::tidy::ClangTidyContext Context( |
| 405 | llvm::make_unique<DefaultOptionsProvider>(ClangTidyGlobalOptions(), |
| 406 | Options)); |
| 407 | ClangTidyASTConsumerFactory Factory(Context); |
| 408 | return Factory.getCheckOptions(); |
Alexander Kornienko | fb9e92b | 2013-12-19 19:57:05 | [diff] [blame] | 409 | } |
| 410 | |
Alexander Kornienko | d53d268 | 2014-09-04 14:23:36 | [diff] [blame] | 411 | ClangTidyStats |
| 412 | runClangTidy(std::unique_ptr<ClangTidyOptionsProvider> OptionsProvider, |
| 413 | const tooling::CompilationDatabase &Compilations, |
| 414 | ArrayRef<std::string> InputFiles, |
Samuel Benzaquen | aedd994 | 2014-10-23 17:23:20 | [diff] [blame] | 415 | std::vector<ClangTidyError> *Errors, ProfileData *Profile) { |
Alexander Kornienko | 1e1ad5c | 2014-05-28 15:21:14 | [diff] [blame] | 416 | ClangTool Tool(Compilations, InputFiles); |
Alexander Kornienko | d53d268 | 2014-09-04 14:23:36 | [diff] [blame] | 417 | clang::tidy::ClangTidyContext Context(std::move(OptionsProvider)); |
Etienne Bergeron | 4eaeace | 2016-04-06 14:07:51 | [diff] [blame^] | 418 | |
| 419 | // Add extra arguments passed by the clang-tidy command-line. |
| 420 | ArgumentsAdjuster PerFileExtraArgumentsInserter = |
| 421 | [&Context](const CommandLineArguments &Args, StringRef Filename) { |
| 422 | ClangTidyOptions Opts = Context.getOptionsForFile(Filename); |
| 423 | CommandLineArguments AdjustedArgs; |
| 424 | if (Opts.ExtraArgsBefore) |
| 425 | AdjustedArgs = *Opts.ExtraArgsBefore; |
| 426 | AdjustedArgs.insert(AdjustedArgs.begin(), Args.begin(), Args.end()); |
| 427 | if (Opts.ExtraArgs) |
| 428 | AdjustedArgs.insert(AdjustedArgs.end(), Opts.ExtraArgs->begin(), |
| 429 | Opts.ExtraArgs->end()); |
| 430 | return AdjustedArgs; |
| 431 | }; |
| 432 | |
| 433 | // Remove plugins arguments. |
| 434 | ArgumentsAdjuster PluginArgumentsRemover = |
| 435 | [&Context](const CommandLineArguments &Args, StringRef Filename) { |
| 436 | CommandLineArguments AdjustedArgs; |
| 437 | for (size_t I = 0, E = Args.size(); I < E; ++I) { |
| 438 | if (I + 4 < Args.size() && Args[I] == "-Xclang" && |
| 439 | (Args[I + 1] == "-load" || Args[I + 1] == "-add-plugin" || |
| 440 | StringRef(Args[I + 1]).startswith("-plugin-arg-")) && |
| 441 | Args[I + 2] == "-Xclang") { |
| 442 | I += 3; |
| 443 | } else |
| 444 | AdjustedArgs.push_back(Args[I]); |
| 445 | } |
| 446 | return AdjustedArgs; |
| 447 | }; |
| 448 | |
Alexander Kornienko | 64956b5 | 2015-11-09 16:28:11 | [diff] [blame] | 449 | Tool.appendArgumentsAdjuster(PerFileExtraArgumentsInserter); |
Etienne Bergeron | 4eaeace | 2016-04-06 14:07:51 | [diff] [blame^] | 450 | Tool.appendArgumentsAdjuster(PluginArgumentsRemover); |
Samuel Benzaquen | aedd994 | 2014-10-23 17:23:20 | [diff] [blame] | 451 | if (Profile) |
| 452 | Context.setCheckProfileData(Profile); |
| 453 | |
Daniel Jasper | d07c840 | 2013-07-29 08:19:24 | [diff] [blame] | 454 | ClangTidyDiagnosticConsumer DiagConsumer(Context); |
Manuel Klimek | 814f9bd | 2013-11-14 15:49:44 | [diff] [blame] | 455 | |
| 456 | Tool.setDiagnosticConsumer(&DiagConsumer); |
Alexander Kornienko | 175fefb | 2014-01-03 09:31:57 | [diff] [blame] | 457 | |
| 458 | class ActionFactory : public FrontendActionFactory { |
| 459 | public: |
Benjamin Kramer | 6e91424 | 2014-07-24 10:23:33 | [diff] [blame] | 460 | ActionFactory(ClangTidyContext &Context) : ConsumerFactory(Context) {} |
| 461 | FrontendAction *create() override { return new Action(&ConsumerFactory); } |
Alexander Kornienko | 175fefb | 2014-01-03 09:31:57 | [diff] [blame] | 462 | |
| 463 | private: |
| 464 | class Action : public ASTFrontendAction { |
| 465 | public: |
| 466 | Action(ClangTidyASTConsumerFactory *Factory) : Factory(Factory) {} |
David Blaikie | 680c4c8 | 2014-08-10 19:56:59 | [diff] [blame] | 467 | std::unique_ptr<ASTConsumer> CreateASTConsumer(CompilerInstance &Compiler, |
| 468 | StringRef File) override { |
Alexander Kornienko | 175fefb | 2014-01-03 09:31:57 | [diff] [blame] | 469 | return Factory->CreateASTConsumer(Compiler, File); |
| 470 | } |
| 471 | |
| 472 | private: |
| 473 | ClangTidyASTConsumerFactory *Factory; |
| 474 | }; |
| 475 | |
Benjamin Kramer | 6e91424 | 2014-07-24 10:23:33 | [diff] [blame] | 476 | ClangTidyASTConsumerFactory ConsumerFactory; |
Alexander Kornienko | 175fefb | 2014-01-03 09:31:57 | [diff] [blame] | 477 | }; |
| 478 | |
Benjamin Kramer | 6e91424 | 2014-07-24 10:23:33 | [diff] [blame] | 479 | ActionFactory Factory(Context); |
| 480 | Tool.run(&Factory); |
Alexander Kornienko | 826b5ad | 2014-05-09 12:24:09 | [diff] [blame] | 481 | *Errors = Context.getErrors(); |
Alexander Kornienko | 5d17454 | 2014-05-07 09:06:53 | [diff] [blame] | 482 | return Context.getStats(); |
Manuel Klimek | 814f9bd | 2013-11-14 15:49:44 | [diff] [blame] | 483 | } |
| 484 | |
Jonathan Roelofs | d60388a | 2016-01-13 17:36:41 | [diff] [blame] | 485 | void handleErrors(const std::vector<ClangTidyError> &Errors, bool Fix, |
| 486 | unsigned &WarningsAsErrorsCount) { |
Alexander Kornienko | 38d81b4 | 2014-03-27 10:24:11 | [diff] [blame] | 487 | ErrorReporter Reporter(Fix); |
Haojian Wu | f7692a2 | 2016-02-26 09:19:33 | [diff] [blame] | 488 | vfs::FileSystem &FileSystem = |
| 489 | *Reporter.getSourceManager().getFileManager().getVirtualFileSystem(); |
| 490 | auto InitialWorkingDir = FileSystem.getCurrentWorkingDirectory(); |
| 491 | if (!InitialWorkingDir) |
| 492 | llvm::report_fatal_error("Cannot get current working path."); |
| 493 | |
| 494 | for (const ClangTidyError &Error : Errors) { |
| 495 | if (!Error.BuildDirectory.empty()) { |
| 496 | // By default, the working directory of file system is the current |
| 497 | // clang-tidy running directory. |
| 498 | // |
| 499 | // Change the directory to the one used during the analysis. |
| 500 | FileSystem.setCurrentWorkingDirectory(Error.BuildDirectory); |
| 501 | } |
Alexander Kornienko | 742790c | 2014-07-02 15:05:04 | [diff] [blame] | 502 | Reporter.reportDiagnostic(Error); |
Haojian Wu | f7692a2 | 2016-02-26 09:19:33 | [diff] [blame] | 503 | // Return to the initial directory to correctly resolve next Error. |
| 504 | FileSystem.setCurrentWorkingDirectory(InitialWorkingDir.get()); |
| 505 | } |
Alexander Kornienko | 38d81b4 | 2014-03-27 10:24:11 | [diff] [blame] | 506 | Reporter.Finish(); |
Jonathan Roelofs | d60388a | 2016-01-13 17:36:41 | [diff] [blame] | 507 | WarningsAsErrorsCount += Reporter.getWarningsAsErrorsCount(); |
Daniel Jasper | d07c840 | 2013-07-29 08:19:24 | [diff] [blame] | 508 | } |
| 509 | |
Benjamin Kramer | fb98b74 | 2014-09-04 10:31:23 | [diff] [blame] | 510 | void exportReplacements(const std::vector<ClangTidyError> &Errors, |
| 511 | raw_ostream &OS) { |
| 512 | tooling::TranslationUnitReplacements TUR; |
| 513 | for (const ClangTidyError &Error : Errors) |
| 514 | TUR.Replacements.insert(TUR.Replacements.end(), Error.Fix.begin(), |
| 515 | Error.Fix.end()); |
| 516 | |
| 517 | yaml::Output YAML(OS); |
| 518 | YAML << TUR; |
| 519 | } |
| 520 | |
Daniel Jasper | d07c840 | 2013-07-29 08:19:24 | [diff] [blame] | 521 | } // namespace tidy |
| 522 | } // namespace clang |