Skip to content

feat(fcm): Added support for sending an image URL in notifications #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 10, 2019
Merged

feat(fcm): Added support for sending an image URL in notifications #332

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
378ac1b
Add "image" field to AndroidNotification and Notification
Aug 21, 2019
be85aa4
Add Doc String to _messaging_utils.encode_notification
Aug 21, 2019
4360418
Merge branch 'master' into image-field
cchamm Aug 26, 2019
93f0550
Shorten Line Width
Aug 26, 2019
17912ea
Merge remote-tracking branch 'fork/image-field' into image-field
cchamm Aug 26, 2019
56e06e0
Add "image" field to APNSFCMOptions.
Sep 10, 2019
9c47159
Merge branch 'master' into image-field
cchamm Sep 10, 2019
9669196
APNSFCMOptions: Shorten line
Sep 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Shorten Line Width
  • Loading branch information
@cchamm
Cham authored and cchamm committed Aug 26, 2019
commit 93f0550800e83aebe0d86a37250797da84c2ac72
8 changes: 5 additions & 3 deletions integration/test_messaging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,16 @@
def test_send():
msg = messaging.Message(
topic='foo-bar',
notification=messaging.Notification('test-title', 'test-body', 'https://images.unsplash.com/photo-1494438639946'
'-1ebd1d20bf85?fit=crop&w=900&q=60'),
notification=messaging.Notification('test-title', 'test-body',
'https://images.unsplash.com/photo-1494438639946'
'-1ebd1d20bf85?fit=crop&w=900&q=60'),
android=messaging.AndroidConfig(
restricted_package_name='com.google.firebase.demos',
notification=messaging.AndroidNotification(
title='android-title',
body='android-body',
image='https://images.unsplash.com/photo-1494438639946-1ebd1d20bf85?fit=crop&w=900&q=60'
image='https://images.unsplash.com/'
'photo-1494438639946-1ebd1d20bf85?fit=crop&w=900&q=60'
)
),
apns=messaging.APNSConfig(payload=messaging.APNSPayload(
Expand Down