Skip to content

time.h: fix integer overflow in MsToAbsoluteTimespec() on 32-bit architectures #1042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 5, 2022
Merged

time.h: fix integer overflow in MsToAbsoluteTimespec() on 32-bit architectures #1042

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c97c17a
app/src/time.h: Fix MsToAbsoluteTimespec() on 32-bit architectures
dconeybe Aug 4, 2022
b200767
add changelog entry
dconeybe Aug 4, 2022
fc5073e
app/src/time.h: remove includes that were left behind from log-based …
dconeybe Aug 4, 2022
e0a0f79
release_build_files/readme.md: update the change log entry
dconeybe Aug 4, 2022
b104910
app/src/time.h: use modulo operator
dconeybe Aug 5, 2022
b6a34b2
app/tests/time_test.cc: add a comment about the integer overflow bug …
dconeybe Aug 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
app/src/time.h: use modulo operator
  • Loading branch information
@dconeybe
dconeybe committed Aug 5, 2022
commit b104910a3651088f4da289ae63b865f70d35569a
2 changes: 1 addition & 1 deletion app/src/time.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ inline timespec MsToAbsoluteTimespec(int milliseconds) {
(milliseconds * internal::kNanosecondsPerMillisecond);

t.tv_sec = nanoseconds / internal::kNanosecondsPerSecond;
t.tv_nsec = nanoseconds - (t.tv_sec * internal::kNanosecondsPerSecond);
t.tv_nsec = nanoseconds % internal::kNanosecondsPerSecond;
return t;
}

Expand Down