Skip to content

Fix crash caused by ResponseJson::MarkCompleted() failing to set application_data_ if parsing the JSON body fails #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 30, 2021
Merged

Fix crash caused by ResponseJson::MarkCompleted() failing to set application_data_ if parsing the JSON body fails #692

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
167c05f
Fix a crash caused by ResponseJson::MarkCompleted() failing to set ap…
dconeybe Sep 29, 2021
6e5755e
Update PR number in release notes
dconeybe Sep 29, 2021
606fac1
Replace FIREBASE_ASSERT_MESSAGE with LogError
dconeybe Sep 29, 2021
b8f1937
Merge main at 0631f33d
dconeybe Sep 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge main at 0631f33
  • Loading branch information
@dconeybe
dconeybe committed Sep 30, 2021
commit b8f193722244e8d5705440401bf1fbc38c858af2

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.