Skip to content

Enable Snappy compression support in LevelDb in cmake builds #885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Apr 12, 2022
Merged

Enable Snappy compression support in LevelDb in cmake builds #885

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
19b11f4
firestore.cmake: patch leveldb to enable snappy support
dconeybe Apr 7, 2022
5eb52fc
external_rules.cmake: do not overwrite leveldb.cmake from firestore
dconeybe Apr 5, 2022
7898b46
release_build_files/readme.md: release notes entry added
dconeybe Apr 7, 2022
7a057de
leveldb_snappy_test.cc added
dconeybe Apr 7, 2022
c4b8ed5
leveldb_snappy_test.cc: add newline at end of file
dconeybe Apr 7, 2022
f9a0ef7
Merge remote-tracking branch 'origin/main' into snappy
dconeybe Apr 8, 2022
7dfbda9
Add snappy to embedded libraries in packaging step, and snappy namesp…
jonsimantov Apr 8, 2022
f6ed5df
Merge branch 'dconeybe/snappy' of https://github.com/firebase/firebas…
jonsimantov Apr 8, 2022
0f694b3
Add leveldb_snappy_test.cc into project.pbxproj
dconeybe Apr 8, 2022
8bb6bf5
Fix release notes entry to mention RTDB as well as Firestore
dconeybe Apr 9, 2022
be2a2c7
Avoid even compiling leveldb_snappy_test.cc on Android
dconeybe Apr 11, 2022
07023a9
leveldb_snappy_test.cc: add SKIP_TEST_ON_IOS
dconeybe Apr 11, 2022
ec98825
leveldb_snappy_test.cc: add missing #include "firebase_test_framework.h"
dconeybe Apr 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion build_scripts/desktop/package.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,7 @@ readonly deps_hidden_firebase_app="
*/boringssl-build/crypto/${subdir}${prefix}crypto.${ext}
*/boringssl-build/ssl/${subdir}${prefix}ssl.${ext}
*/firestore-build/*/leveldb-build*/${prefix}*.${ext}
*/firestore-build/*/snappy-build*/${prefix}*.${ext}
*/firestore-build/*/nanopb-build*/${prefix}*.${ext}
"
readonly deps_hidden_firebase_database="
Expand Down Expand Up @@ -227,7 +228,7 @@ readonly -a rename_namespaces=(flatbuffers flexbuffers reflection ZLib bssl uWS
grpc_ssl_server_credentials grpc_tls_credential_reload_config
grpc_tls_server_authorization_check_config GrpcUdpListener leveldb
leveldb_filterpolicy_create_bloom leveldb_writebatch_iterate strings
TlsCredentials TlsServerCredentials tsi)
TlsCredentials TlsServerCredentials tsi snappy)

# String to prepend to all hidden symbols.
readonly rename_string=f_b_
Expand Down
2 changes: 2 additions & 0 deletions cmake/external/firestore.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ function(GetReleasedDep version)
BUILD_COMMAND ""
INSTALL_COMMAND ""
TEST_COMMAND ""
PATCH_COMMAND patch -Np1 -i ${CMAKE_CURRENT_LIST_DIR}/firestore_snappy.patch.txt
HTTP_HEADER "${EXTERNAL_PROJECT_HTTP_HEADER}"
)
endfunction()
Expand All @@ -52,6 +53,7 @@ function(GetTag t)
BUILD_COMMAND ""
INSTALL_COMMAND ""
TEST_COMMAND ""
PATCH_COMMAND patch -Np1 -i ${CMAKE_CURRENT_LIST_DIR}/firestore_snappy.patch.txt
HTTP_HEADER "${EXTERNAL_PROJECT_HTTP_HEADER}"
)
endfunction()
Expand Down
Loading