Skip to content

Remove __trigger #1150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2022
Merged

Remove __trigger #1150

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9b94d2
Remove __trigger
inlined Jun 17, 2022
d2b8421
Lint fixes
inlined Jun 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Lint fixes
  • Loading branch information
@inlined
inlined committed Jun 17, 2022
commit d2b8421caa58d5e9a14ce5ad872b35633c3dffeb
12 changes: 6 additions & 6 deletions spec/v1/function-builder.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,9 +279,7 @@ describe('FunctionBuilder', () => {
.auth.user()
.onCreate((user) => user);

expect(fn.__endpoint.serviceAccountEmail).to.equal(
`test-service-account@`
);
expect(fn.__endpoint.serviceAccountEmail).to.equal(`test-service-account@`);
});

it('should set a null serviceAccountEmail if service account is set to `default`', () => {
Expand Down Expand Up @@ -484,9 +482,11 @@ describe('FunctionBuilder', () => {
.auth.user()
.onCreate((user) => user);

expect(fn.__endpoint.secretEnvironmentVariables).to.deep.equal([{
key: 'API_KEY',
}]);
expect(fn.__endpoint.secretEnvironmentVariables).to.deep.equal([
{
key: 'API_KEY',
},
]);
});

it('should throw error given secrets expressed with full resource name', () => {
Expand Down