Skip to content

chore: use BaseApiTracer and BaseApiTracerFactory #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 12, 2021
Merged

chore: use BaseApiTracer and BaseApiTracerFactory #879

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f0d0b1
chore: extends BaseApiTracer and BaseApiTracerFactory
mutianf Jun 21, 2021
73cbbfc
format
mutianf Jul 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...igtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/CompositeTracer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,14 @@
package com.google.cloud.bigtable.data.v2.stub.metrics;

import com.google.api.gax.tracing.ApiTracer;
import com.google.api.gax.tracing.BaseApiTracer;
import com.google.common.collect.ImmutableList;
import java.util.ArrayList;
import java.util.List;
import org.threeten.bp.Duration;

/** Combines multiple {@link ApiTracer}s into a single {@link ApiTracer}. */
class CompositeTracer implements ApiTracer {
class CompositeTracer extends BaseApiTracer {
private final List<ApiTracer> children;

CompositeTracer(List<ApiTracer> children) {
Expand Down
3 changes: 2 additions & 1 deletion .../src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/CompositeTracerFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,15 @@
import com.google.api.core.InternalApi;
import com.google.api.gax.tracing.ApiTracer;
import com.google.api.gax.tracing.ApiTracerFactory;
import com.google.api.gax.tracing.BaseApiTracerFactory;
import com.google.api.gax.tracing.SpanName;
import com.google.common.collect.ImmutableList;
import java.util.ArrayList;
import java.util.List;

/** Combines multiple {@link ApiTracerFactory} into a single {@link ApiTracerFactory}. */
@InternalApi("For internal use only")
public class CompositeTracerFactory implements ApiTracerFactory {
public class CompositeTracerFactory extends BaseApiTracerFactory {
private final List<ApiTracerFactory> apiTracerFactories;

public CompositeTracerFactory(List<ApiTracerFactory> apiTracerFactories) {
Expand Down
4 changes: 2 additions & 2 deletions ...-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/MetricsTracer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
*/
package com.google.cloud.bigtable.data.v2.stub.metrics;

import com.google.api.gax.tracing.ApiTracer;
import com.google.api.gax.tracing.ApiTracerFactory.OperationType;
import com.google.api.gax.tracing.BaseApiTracer;
import com.google.api.gax.tracing.SpanName;
import com.google.common.base.Stopwatch;
import io.opencensus.stats.MeasureMap;
Expand All @@ -34,7 +34,7 @@
import javax.annotation.Nullable;
import org.threeten.bp.Duration;

class MetricsTracer implements ApiTracer {
class MetricsTracer extends BaseApiTracer {

private final OperationType operationType;

Expand Down
3 changes: 2 additions & 1 deletion ...le/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/MetricsTracerFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
import com.google.api.core.InternalApi;
import com.google.api.gax.tracing.ApiTracer;
import com.google.api.gax.tracing.ApiTracerFactory;
import com.google.api.gax.tracing.BaseApiTracerFactory;
import com.google.api.gax.tracing.SpanName;
import com.google.common.collect.ImmutableMap;
import io.opencensus.stats.StatsRecorder;
Expand All @@ -30,7 +31,7 @@
* api.
*/
@InternalApi("For internal use only")
public class MetricsTracerFactory implements ApiTracerFactory {
public class MetricsTracerFactory extends BaseApiTracerFactory {
private final Tagger tagger;
private final StatsRecorder stats;
private final ImmutableMap<TagKey, TagValue> statsAttributes;
Expand Down