-
Notifications
You must be signed in to change notification settings - Fork 48
tests: fix failing e2e tests #726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -1432,9 +1433,7 @@ def square_num(x): | |||
|
|||
|
|||
def test_remote_function_via_session_vpc_invalid(session): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: Might be better to replace this test with a unit test where we verify that we're actually sending VPC info in the relevant requests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed this test, as it's redundant with the check here:
assert gcf.service_config.vpc_connector == gcf_vpc_connector |
We already check the VPC is added to the Cloud Function metadata here: https://github.com/googleapis/python-bigquery-dataframes/blob/72e95834f8755760f3529d38f340703f3b971f0a/tests/system/large/test_remote_function.py#L1426
Filed internal issue 343447415 to investigate.
|
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕