-
Notifications
You must be signed in to change notification settings - Fork 2
Added region tags and prettierignores to 3d html files #303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Here is the summary of changes. You are about to add 6 region tags.
This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
samples/3d-marker-customization/index.html:2
- The region tag 'maps_map_simple' appears inconsistent with the naming convention used in other samples (e.g., 'maps_3d_simple_marker'). Consider renaming it to a more consistent tag such as 'maps_3d_marker_customization'.
<!-- [START maps_map_simple] -->
@@ -1,4 +1,5 @@ | |||
<!doctype html> | |||
<!-- [START maps_map_simple] --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Region tags should be maps_3d_marker_customization
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one issue, the region tag for 3d-marker-customization/index.html is incorrect.
No description provided.