Skip to content

Added region tags and prettierignores to 3d html files #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2025
Merged

Added region tags and prettierignores to 3d html files #303

merged 2 commits into from
Apr 10, 2025

Conversation

oppenheimera
Copy link
Contributor

No description provided.

Copy link

snippet-bot bot commented Apr 10, 2025

Here is the summary of changes.

You are about to add 6 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@willum070 willum070 requested a review from Copilot April 10, 2025 22:24
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

samples/3d-marker-customization/index.html:2

  • The region tag 'maps_map_simple' appears inconsistent with the naming convention used in other samples (e.g., 'maps_3d_simple_marker'). Consider renaming it to a more consistent tag such as 'maps_3d_marker_customization'.
<!-- [START maps_map_simple] -->

@willum070 willum070 self-requested a review April 10, 2025 22:25
@@ -1,4 +1,5 @@
<!doctype html>
<!-- [START maps_map_simple] -->
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Region tags should be maps_3d_marker_customization

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, fixed

Copy link
Collaborator

@willum070 willum070 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one issue, the region tag for 3d-marker-customization/index.html is incorrect.

@willum070 willum070 merged commit bf46a46 into main Apr 10, 2025
9 checks passed
@willum070 willum070 deleted the 3d branch April 10, 2025 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants