Skip to content

REF: Simplify Period/Datetime Array/Index constructors #23093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 12, 2018
Merged

REF: Simplify Period/Datetime Array/Index constructors #23093

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0e40ed4
Simplify Period/Datetime Array/Index constructors
jbrockmendel Oct 11, 2018
dc63072
revert removal of kwargs
jbrockmendel Oct 11, 2018
ee210e4
fix _simple_new calls in pytables
jbrockmendel Oct 11, 2018
fc88e59
Fixup unused import
jbrockmendel Oct 11, 2018
69a8f7e
override simple_new instead of _from_ordinasl
jbrockmendel Oct 11, 2018
04c75ca
Call simple_new instead of from_ordinals
jbrockmendel Oct 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix _simple_new calls in pytables
  • Loading branch information
@jbrockmendel
jbrockmendel committed Oct 11, 2018
commit ee210e46b5adb891538764279a5fee35a7f3ac7a
4 changes: 2 additions & 2 deletions pandas/io/pytables.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2476,15 +2476,15 @@ def _get_index_factory(self, klass):
if klass == DatetimeIndex:
def f(values, freq=None, tz=None):
# data are already in UTC, localize and convert if tz present
result = DatetimeIndex._simple_new(values.values, None,
result = DatetimeIndex._simple_new(values.values, name=None,
freq=freq)
if tz is not None:
result = result.tz_localize('UTC').tz_convert(tz)
return result
return f
elif klass == PeriodIndex:
def f(values, freq=None, tz=None):
return PeriodIndex._simple_new(values, None, freq=freq)
return PeriodIndex._simple_new(values, name=None, freq=freq)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really these shouldn't be calling _simple_new at all.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, this is actually tricky. the period codes are actually stored. We in fact need to think about this for EA, potentially providing an easy way to have serialization code deal with this.

Why isn't this from_ordinals?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out changing this to just call PeriodIndex(...) causes some test failures. Tried it in #23140.

return f

return klass
Expand Down