Squashed commit of the following:

commit e4b21f6
Author: Tom Augspurger <[email protected]>
Date:   Mon Nov 12 16:09:58 2018 -0600

    TST: Change rops tests

commit e903550
Author: Tom Augspurger <[email protected]>
Date:   Mon Nov 12 09:31:38 2018 -0600

    Add note

    [ci skip]

    ***NO CI***

commit fa8934a
Author: Tom Augspurger <[email protected]>
Date:   Mon Nov 12 06:16:53 2018 -0600

    update errors

commit 505970e
Merge: a30bc02 3592a46
Author: Tom Augspurger <[email protected]>
Date:   Mon Nov 12 05:55:31 2018 -0600

    Merge remote-tracking branch 'upstream/master' into index-ndarray-data

commit a30bc02
Author: Tom Augspurger <[email protected]>
Date:   Sun Nov 11 15:14:46 2018 -0600

    remove assert

commit 1f23ebc
Author: Tom Augspurger <[email protected]>
Date:   Sun Nov 11 15:01:13 2018 -0600

    BUG: Ensure that Index._data is an ndarray

    BUG: Ensure that Index._data is an ndarray

    Split from #23623, where it was
    causing issues with infer_dtype.

pandas/core/indexes/base.py

@@ -522,6 +522,12 @@ def _simple_new(cls, values, name=None, dtype=None, **kwargs):
                     values = cls(values, name=name, dtype=dtype,
                                  **kwargs)._ndarray_values
 
+        if isinstance(values, (ABCSeries, cls)):
+            # Index._data must always be an ndarray.
+            # This is no-copy for when _values is an ndarray,
+            # which should be always at this point.
+            values = np.asarray(values._values)
+
         result = object.__new__(cls)
         result._data = values
         result.name = name

pandas/tests/indexes/test_base.py

@@ -504,6 +504,12 @@ def test_constructor_cast(self):
         with pytest.raises(ValueError, match=msg):
             Index(["a", "b", "c"], dtype=float)
 
+    def test_constructor_unwraps_index(self):
+        a = pd.Index([True, False])
+        b = pd.Index(a)
+        expected = np.array([True, False], dtype=object)
+        tm.assert_numpy_array_equal(b._data, expected)
+
     def test_view_with_args(self):
 
         restricted = ['unicodeIndex', 'strIndex', 'catIndex', 'boolIndex',

pandas/tests/indexes/test_numeric.py

@@ -628,6 +628,12 @@ def test_constructor_coercion_signed_to_unsigned(self, uint_dtype):
         with pytest.raises(OverflowError, match=msg):
             Index([-1], dtype=uint_dtype)
 
+    def test_constructor_unwraps_index(self):
+        idx = pd.Index([1, 2])
+        result = pd.Int64Index(idx)
+        expected = np.array([1, 2], dtype='int64')
+        tm.assert_numpy_array_equal(result._data, expected)
+
     def test_coerce_list(self):
         # coerce things
         arr = Index([1, 2, 3, 4])

pandas/tests/series/test_operators.py

@@ -189,20 +189,7 @@ def test_scalar_na_logical_ops_corners(self):
         operator.and_,
         operator.or_,
         operator.xor,
-        pytest.param(ops.rand_,
-                     marks=pytest.mark.xfail(reason="GH#22092 Index "
-                                                    "implementation returns "
-                                                    "Index",
-                                             raises=AssertionError,
-                                             strict=True)),
-        pytest.param(ops.ror_,
-                     marks=pytest.mark.xfail(reason="GH#22092 Index "
-                                                    "implementation raises",
-                                             raises=ValueError, strict=True)),
-        pytest.param(ops.rxor,
-                     marks=pytest.mark.xfail(reason="GH#22092 Index "
-                                                    "implementation raises",
-                                             raises=TypeError, strict=True))
+
     ])
     def test_logical_ops_with_index(self, op):
         # GH#22092, GH#19792
@@ -221,6 +208,19 @@ def test_logical_ops_with_index(self, op):
         result = op(ser, idx2)
         assert_series_equal(result, expected)
 
+    @pytest.mark.parametrize("op, expected", [
+        (ops.rand_, pd.Index([False, True])),
+        (ops.ror_, pd.Index([False, True])),
+        (ops.rxor, pd.Index([])),
+    ])
+    def test_reverse_ops_with_index(self, op, expected):
+        # https://github.com/pandas-dev/pandas/pull/23628
+        # multi-set Index ops are buggy, so let's avoid duplicates...
+        ser = Series([True, False])
+        idx = Index([False, True])
+        result = op(ser, idx)
+        tm.assert_index_equal(result, expected)
+
     def test_logical_ops_label_based(self):
         # GH#4947
         # logical ops should be label based