Skip to content

DEPR: Index.contains, DatetimeIndex.offset #30103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 8, 2019
Merged

DEPR: Index.contains, DatetimeIndex.offset #30103

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
00fe487
DEPR: Index.contains, RangeIndex._start, _stop, _step
jbrockmendel Dec 6, 2019
0ebfdcf
GH ref
jbrockmendel Dec 6, 2019
275f100
Merge branch 'master' of https://github.com/pandas-dev/pandas into de…
jbrockmendel Dec 6, 2019
09ab9e9
compat fixup
jbrockmendel Dec 6, 2019
aef2de3
Merge branch 'master' of https://github.com/pandas-dev/pandas into de…
jbrockmendel Dec 6, 2019
24b25d4
revert _start, _stop, _step
jbrockmendel Dec 6, 2019
9238188
update docs
jbrockmendel Dec 6, 2019
6113446
Merge branch 'master' of https://github.com/pandas-dev/pandas into de…
jbrockmendel Dec 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
GH ref
  • Loading branch information
@jbrockmendel
jbrockmendel committed Dec 6, 2019
commit 0ebfdcf98733c73a573f9efa58873a3b6f823e33
2 changes: 1 addition & 1 deletion doc/source/whatsnew/v1.0.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,7 +546,7 @@ or ``matplotlib.Axes.plot``. See :ref:`plotting.formatters` for more.
- Removed support for nested renaming in :meth:`DataFrame.aggregate`, :meth:`Series.aggregate`, :meth:`DataFrameGroupBy.aggregate`, :meth:`SeriesGroupBy.aggregate`, :meth:`Rolling.aggregate` (:issue:`18529`)
- Passing ``datetime64`` data to :class:`TimedeltaIndex` or ``timedelta64`` data to ``DatetimeIndex`` now raises ``TypeError`` (:issue:`23539`, :issue:`23937`)
- A tuple passed to :meth:`DataFrame.groupby` is now exclusively treated as a single key (:issue:`18314`)
- Removed the previously deprecated :meth:`Index.contains`, use ``key in index`` instead (:issue:`?????`)
- Removed the previously deprecated :meth:`Index.contains`, use ``key in index`` instead (:issue:`30103`)
- Removed the previously deprecated :attr:`RangeIndex._start`, :attr:`RangeIndex._stop`, :atttr:`RangeIndex._step` (:issue:`26581`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the min version of pyarrow that is ok here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the problem is in fastparquet; it fails in the most recent version 0.3.2

- Removed :meth:`Series.from_array` (:issue:`18258`)
- Removed :meth:`DataFrame.from_items` (:issue:`18458`)
Expand Down
2 changes: 1 addition & 1 deletion pandas/tests/indexes/test_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2406,7 +2406,7 @@ def test_tab_complete_warning(self, ip):
list(ip.Completer.completions("idx.", 4))

def test_contains_method_removed(self, indices):
# method removed for all types except IntervalIndex
# GH#30103 method removed for all types except IntervalIndex
err = AttributeError if not isinstance(indices, pd.IntervalIndex) else None
with pytest.raises(err):
indices.contains(1)
Expand Down