Skip to content

Added RuntimeWarning to lib.fast_unique_multiple #33015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Apr 2, 2020
Merged

Added RuntimeWarning to lib.fast_unique_multiple #33015

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
a8cbc37
Added RuntimeWarning to lib.fast_unique_multiple
Mar 25, 2020
28871d1
isort
Mar 25, 2020
3db5519
Fixed test case to be lib specific
Mar 25, 2020
8a7f6c9
Warning error message
Mar 25, 2020
9ce23ab
Not asserting the warning if on numpy_dev
Mar 25, 2020
d57aded
Merge remote-tracking branch 'upstream/master' into TODO-runtimewarni…
Mar 26, 2020
1c3a45f
Troubleshoot failing test
Mar 26, 2020
9db8893
Merge remote-tracking branch 'upstream/master' into TODO-runtimewarni…
Mar 26, 2020
ab8cc80
Merge remote-tracking branch 'upstream/master' into TODO-runtimewarni…
Mar 26, 2020
d186e6d
Added information on how to suppress the warning
Mar 26, 2020
df301eb
Troubleshoot failing test
Mar 26, 2020
fde1e1a
Update pandas/_libs/lib.pyx
ShaharNaveh Mar 26, 2020
6d1508d
Marked failed test as xfail
Mar 26, 2020
1314e99
Marked xfailed-strict as False
Mar 27, 2020
f29760c
Merge remote-tracking branch 'upstream/master' into TODO-runtimewarni…
Mar 27, 2020
e55bc81
Troubleshoot failing test
Mar 29, 2020
d2cd2d9
Merge remote-tracking branch 'upstream/master' into TODO-runtimewarni…
Mar 29, 2020
b931025
Removed if statement related to numpy-dev
Mar 29, 2020
2c05ed2
Merge remote-tracking branch 'upstream/master' into TODO-runtimewarni…
Mar 29, 2020
17a6f99
Added whatsnew
Mar 29, 2020
b7ace2b
Merge remote-tracking branch 'upstream/master' into TODO-runtimewarni…
Mar 29, 2020
83e2e82
What's new refrence to this PR
Mar 31, 2020
564d416
Merge remote-tracking branch 'upstream/master' into TODO-runtimewarni…
Mar 31, 2020
63a6104
Merge remote-tracking branch 'upstream/master' into TODO-runtimewarni…
Apr 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Warning error message
  • Loading branch information
MomIsBestFriend committed Mar 25, 2020
commit 8a7f6c93e8bed92887b5bf0292daf311c29a08a1
4 changes: 1 addition & 3 deletions pandas/_libs/lib.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,9 +287,7 @@ def fast_unique_multiple(list arrays, sort: bool = True):
try:
uniques.sort()
except TypeError:
warnings.warn(
"Not sure what will be a helpful error message", RuntimeWarning
)
warnings.warn("The values in the array are unorderable", RuntimeWarning)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you indicate somethig about what to do about this? (eg passing the sort=False keyword? I don't know if that is possible for all cases that may end up here)

pass

return uniques
Expand Down