Skip to content

BUG: (GH4708) A zero length series written to HDF cannot be read back. #4709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2013

Conversation

prossahl
Copy link
Contributor

closes #4708 by spotting when the sentinel single value has been written. This was not being done for the index which resulted in a values/index length miss-match.

@jreback
Copy link
Contributor

jreback commented Aug 30, 2013

can you add a release notes entry under bug fixes, sub-heading HDFStore (which is already there), otherwise looks good

@jreback
Copy link
Contributor

jreback commented Aug 31, 2013

@prossahl you need to handle the empty M8[ns] case; it fails because that case is not caught

@jreback
Copy link
Contributor

jreback commented Sep 20, 2013

@prossahl want to finish this up?

@jreback
Copy link
Contributor

jreback commented Sep 28, 2013

@prossahl ping

@prossahl
Copy link
Contributor Author

Still working on this. Failing Travis builds can not be reproduced locally.

@jreback
Copy link
Contributor

jreback commented Oct 11, 2013

Your test should be this; we don't try to serialize numpy arrays per se
and it DOES fail for me, the datetime64[ns] is not being caught (as empty)

    def test_empty_series(self):
        for dtype in [np.int64, np.float64, np.object, 'M8[ns]']:
            s = Series(dtype=dtype)
            self._check_roundtrip(s, tm.assert_series_equal)

@prossahl
Copy link
Contributor Author

Travis build is now green with libhdf5 versions 1.8.4 as well as later ones.

@jreback
Copy link
Contributor

jreback commented Oct 14, 2013

  • can you add m8[ns] to the tests as well (you convert it but don't test it).
  • pls add a one-liner release note (doc/source/release.rst) (ref the original issue 4708), pls put with the other HDFStore bug fixes
  • pls squash down commits to 1

and we can get this in

thanks!

@jreback jreback merged commit 45417bb into pandas-dev:master Oct 15, 2013
@jreback
Copy link
Contributor

jreback commented Oct 15, 2013

thanks for the PR!

@prossahl prossahl deleted the AHLRAP-3081 branch October 15, 2013 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: A zero length series written to HDF cannot be read back.
2 participants