ENH: Add uint and bool support in to_stata #7726
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we'll just call you mr. stata from now on :) can you move the release note to 0.15.0.txt (0.14.1 coming tomorrow), so too late for that |
|
I think this is ready. |
| upcast if needed. int64 data is not usable in Stata, and so it is | ||
| downcast to int32 whenever the value are in the int32 range, and | ||
| sidecast to float64 when larger than this range. If the int64 values | ||
| are outside of the range of those perfectly representable as float64 values, | ||
| a warning is raised. | ||
|
|
||
| bool columns are cast to int8. uint colums are converted to int of the same |
There was a problem hiding this comment.
can you add a note to the io.rst stata section explaining on dtype conversion works with the various types?
|
@jreback I added some docs. |
| @@ -3504,6 +3504,28 @@ into a .dta file. The format version of this file is always 115 (Stata 12). | |||
| df = DataFrame(randn(10, 2), columns=list('AB')) | |||
| df.to_stata('stata.dta') | |||
|
|
|||
| Stata data files have limited data type support and only strings with 244 or | |||
| fewer characters, ``int8``, ``int16``, ``int32`` and ``float64`` can written | |||
| to a valid dta file. Additionally, certain values are reserved tp represent | |||
|
minor edits, otherwise looks good. |
| @@ -3504,6 +3504,28 @@ into a .dta file. The format version of this file is always 115 (Stata 12). | |||
| df = DataFrame(randn(10, 2), columns=list('AB')) | |||
| df.to_stata('stata.dta') | |||
|
|
|||
| *Stata* data files have limited data type support; only strings with 244 or | |||
| fewer characters, ``int8``, ``int16``, ``int32`` and ``float64`` can written | |||
There was a problem hiding this comment.
can be written. maybe say .dta file
Added support for uint (uint8, uint16 and uint32, but not uint64) and bool datatypes in to_stata. Added an explanation of supported data types in io.rst. closes pandas-dev#7097 and closes pandas-dev#7365
|
thanks @bashtage continued awesome stata support is great! |
|
merged via 7745d72 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for uint (uint8, uint16 and uint32, but not uint64) and bool
datatypes in to_stata.
closes #7097
closes #7365