BUG: Intersection buggy for non-monotonic non-unique indices (GH8362) #8374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
needs a test (e.g. your example from the issue) |
|
also pls add a release note in v0.15.0.txt |
| @@ -1275,6 +1275,7 @@ def intersection(self, other): | |||
|
|
|||
| try: | |||
| indexer = self.get_indexer(other.values) | |||
| indexer = indexer[indexer != -1] | |||
There was a problem hiding this comment.
this is not the right place for this (and it duplicates the next line), I belive the error is in the except itself
|
Okay I think it's fixed now. |
|
looks good |
|
merged via 68fdacd thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes intersection bug in the case of non-monotonic non-unique indexes.
closes #8362