Use bool data type for HAVE_* class constants #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! Apologies for the long delay on the review of this PR. The code will appear in the upcoming 3.x series of the memcached module. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation on php.net for Memcached states that the
HAVE_IGBINARYandHAVE_JSONclass constants are of type boolean; however they are currently registered as integers using theREGISTER_MEMC_CLASS_CONST_LONGmacro.These constants and the other three affected by this Pull Request (
HAVE_MSGPACK,HAVE_SESSIONandHAVE_SASL) all represent boolean conditions, and so it makes more sense for them to use the boolean data type than integer.