remove ZEND_CTOR_MAKE_NULL #177
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l/1205/files Correct solution is to omit that call
against PHP 7 only on travis-ci
|
No longer necessary, thanks for taking the time ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZEND_CTOR_MAKE_NULL was removed in https://github.com/php/php-src/pull/1205/files
Correct solution is to omit that call.
Also updated travis.yml for this branch. It's still failing due to igbinary not being ready for PHP7. The tracking issue for that is igbinary/igbinary#40
We can either stop compiling and testing igbinary on the 7 branch, or leave it broken until they're ready for 7.