Skip to content

Fix stubs to make them consistent for PHP 8 and add a checkKey() method along with a bug fix #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Fix stubs to make them consistent for PHP 8 and add a checkKey() method along with a bug fix #479

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a484084
Fix stubs to make them consistent for PHP 8
rlerdorf Feb 25, 2021
2481eb2
Expose internal key check via checkKey() method
rlerdorf Feb 25, 2021
27cf781
Add test
rlerdorf Feb 25, 2021
3ba7dd5
Add test file to package.xml
rlerdorf Feb 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add test
  • Loading branch information
@rlerdorf
rlerdorf committed Feb 25, 2021
commit 27cf781a694511fa98d7973292db027319b8fdbe
132 changes: 132 additions & 0 deletions tests/check_key.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,132 @@
--TEST--
Memcached::checkKey()
--SKIPIF--
<?php include "skipif.inc";?>
--FILE--
<?php
include dirname (__FILE__) . '/config.inc';
$m = memc_get_instance (array (
Memcached::OPT_BINARY_PROTOCOL => false,
Memcached::OPT_VERIFY_KEY => true
));

$keys = [
'foo',
'foo bar',
str_repeat('a',65),
str_repeat('b',250),
str_repeat('c',251),
'Montréal',
'København',
'Düsseldorf',
'Kraków',
'İstanbul',
'ﺎﺨﺘﺑﺍﺭ PHP',
'測試',
'Тестирование',
'پی ایچ پی کی جانچ ہو رہی ہے',
'Testataan PHP: tä',
'Að prófa PHP',
'د پی ایچ پی ازمول',
'Pruvà PHP'
];
foreach($keys as $key) {
echo "Checking \"$key\"" . PHP_EOL;
echo "MEMC_CHECK_KEY: ";
var_dump($m->checkKey($key));
echo "libmemcached: ";
var_dump($m->set($key, "this is a test"));
var_dump($m->getResultMessage());
echo "\n";
}
--EXPECT--
Checking "foo"
MEMC_CHECK_KEY: bool(true)
libmemcached: bool(true)
string(7) "SUCCESS"

Checking "foo bar"
MEMC_CHECK_KEY: bool(false)
libmemcached: bool(false)
string(46) "A BAD KEY WAS PROVIDED/CHARACTERS OUT OF RANGE"

Checking "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"
MEMC_CHECK_KEY: bool(true)
libmemcached: bool(true)
string(7) "SUCCESS"

Checking "bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb"
MEMC_CHECK_KEY: bool(true)
libmemcached: bool(true)
string(7) "SUCCESS"

Checking "ccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccc"
MEMC_CHECK_KEY: bool(false)
libmemcached: bool(false)
string(46) "A BAD KEY WAS PROVIDED/CHARACTERS OUT OF RANGE"

Checking "Montréal"
MEMC_CHECK_KEY: bool(false)
libmemcached: bool(false)
string(46) "A BAD KEY WAS PROVIDED/CHARACTERS OUT OF RANGE"

Checking "København"
MEMC_CHECK_KEY: bool(false)
libmemcached: bool(false)
string(46) "A BAD KEY WAS PROVIDED/CHARACTERS OUT OF RANGE"

Checking "Düsseldorf"
MEMC_CHECK_KEY: bool(false)
libmemcached: bool(false)
string(46) "A BAD KEY WAS PROVIDED/CHARACTERS OUT OF RANGE"

Checking "Kraków"
MEMC_CHECK_KEY: bool(false)
libmemcached: bool(false)
string(46) "A BAD KEY WAS PROVIDED/CHARACTERS OUT OF RANGE"

Checking "İstanbul"
MEMC_CHECK_KEY: bool(false)
libmemcached: bool(false)
string(46) "A BAD KEY WAS PROVIDED/CHARACTERS OUT OF RANGE"

Checking "ﺎﺨﺘﺑﺍﺭ PHP"
MEMC_CHECK_KEY: bool(false)
libmemcached: bool(false)
string(46) "A BAD KEY WAS PROVIDED/CHARACTERS OUT OF RANGE"

Checking "測試"
MEMC_CHECK_KEY: bool(false)
libmemcached: bool(false)
string(46) "A BAD KEY WAS PROVIDED/CHARACTERS OUT OF RANGE"

Checking "Тестирование"
MEMC_CHECK_KEY: bool(false)
libmemcached: bool(false)
string(46) "A BAD KEY WAS PROVIDED/CHARACTERS OUT OF RANGE"

Checking "پی ایچ پی کی جانچ ہو رہی ہے"
MEMC_CHECK_KEY: bool(false)
libmemcached: bool(false)
string(46) "A BAD KEY WAS PROVIDED/CHARACTERS OUT OF RANGE"

Checking "Testataan PHP: tä"
MEMC_CHECK_KEY: bool(false)
libmemcached: bool(false)
string(46) "A BAD KEY WAS PROVIDED/CHARACTERS OUT OF RANGE"

Checking "Að prófa PHP"
MEMC_CHECK_KEY: bool(false)
libmemcached: bool(false)
string(46) "A BAD KEY WAS PROVIDED/CHARACTERS OUT OF RANGE"

Checking "د پی ایچ پی ازمول"
MEMC_CHECK_KEY: bool(false)
libmemcached: bool(false)
string(46) "A BAD KEY WAS PROVIDED/CHARACTERS OUT OF RANGE"

Checking "Pruvà PHP"
MEMC_CHECK_KEY: bool(false)
libmemcached: bool(false)
string(46) "A BAD KEY WAS PROVIDED/CHARACTERS OUT OF RANGE"