Envelope toString implementation #8
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @mkiedys - looks good to me. We'll see about merging it and I'll get back to you asap. |
|
Ok. Its nice to have unless you want to throw Envelope away. |
|
bump |
|
@mkiedys have you signed RabbitMQ Contributor Agreement? |
|
I sent today to Tim. |
|
bump |
|
@mkiedys - I don't see that email - what email address did you send it to? Can you try again please (as we're intent on merging this) with tim at rabbitmq dot com. Thanks. |
|
Done |
|
Thanks, this is getting counter-signed right now and we'll try to get the fix merged asap. Sorry for the long delay! |
|
bump |
michaelklishin
added a commit
that referenced
this pull request
Feb 17, 2014
Contributed by Michał Kiędyś in #8
|
Ported on branch |
stream-iori
pushed a commit
to stream-iori/rabbitmq-java-client
that referenced
this pull request
Mar 20, 2022
Add contribution guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.