Sketch Environment/Producer/Consumer API #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To create Producer instances and re-use Client instances.
This allows having several brokers to connect to for the locator client used to locate the leader and replicas of a stream.
Conflicts: src/main/java/com/rabbitmq/stream/Client.java
They were just variations. Now it's just possible to publish a list of messages or a list of sub-entry batches.
WIP. Still needs some synchronization code in the message accumulator logic. Needs also a way to limit the number of outstanding confirms to avoid memory-leak-like behavior if confirms do not keep up with publishing (mainly because the publishing code is completely asynchronous currently).
The histogram can become a bottleneck for a very high throughput, so doing some downsampling to mitigate this.
WIP. To deal with the Erlang process failure (leader or replica) and reconnect somewhere else or deal with deletion.
This gives the system so time to recover and avoid blocking a thread.
This avoid blocking threads on retry, which is a much better usage of the resources.
Can be re-used in other places where some resources may need retry before being accessible.
This may be used not only for connection recovery but also anywhere we need some back-off (e.g. after a metaupdate to re-allocate consumers to other nodes), so removing the 'recovery' prefix makes it more generic.
They seem to make the server unstable, so disabling them for now until we find out more about the problem.
The Client is not a public API, so it is not documented.
Avoid "stream queue" wording.
Not considered a public API.
pivotal-rabbitmq-ci
pushed a commit
that referenced
this pull request
Aug 6, 2020
Sketch Environment/Producer/Consumer API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.