Skip to content

update all examples to use standalone components #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
markgoho opened this issue Jul 12, 2023 · 2 comments · Fixed by #400
Closed

update all examples to use standalone components #399

markgoho opened this issue Jul 12, 2023 · 2 comments · Fixed by #400

Comments

@markgoho
Copy link
Contributor

of the many example specs, only a couple focus on testing standalone components

given the trend towards standalone being the default, it would be valuable to the community to see more examples of how Testing Library can be used with standalone components and what aspects of the test must change in response to making the component standalone
@markgoho markgoho mentioned this issue Jul 12, 2023
Merged
@markgoho
Copy link
Contributor Author

@timdeschryver is there value in doing this do you think?

@timdeschryver
Copy link
Member

Hey @markgoho I think it is very valuable!
Thanks for the PR as well.
I had some other stuff on my list but I'm planning to go over the issues/PR of Angular Testing Library later this week/next week.
Thanks in advance!

timdeschryver pushed a commit that referenced this issue Jul 26, 2023
@markgoho
docs: update examples to standalone components (#400)
d36c2ea 
Closes #399
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update example specs to standalone markgoho/angular-testing-library
2 participants
@markgoho @timdeschryver