update example specs to standalone #400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a99f30c to
1e15206
Compare
LayZeeDK
reviewed
Jul 21, 2023
| @@ -28,8 +28,8 @@ function reducerItems() { | |||
| } | |||
|
|
|||
| @NgModule({ | |||
| declarations: [ | |||
| AppComponent, | |||
| declarations: [AppComponent], | |||
There was a problem hiding this comment.
question: can the AppComponent not be converted to a standalone component?
There was a problem hiding this comment.
I pushed these changes, as well as a cleanup of the unnecessary setup/environment files.
|
thank you so much @timdeschryver I apologize for the delay in response, I was out of the country and couldn't focus the time on this that I wanted to all the changes you made look fantastic, thanks again!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #399