Skip to content

feat: support ngOnChanges with correct simpleChange object within rerender #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 10, 2023
Merged

feat: support ngOnChanges with correct simpleChange object within rerender #366

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e4acbbd
feat: support ngOnChanges with correct simple change object within re…
shaman-apprentice Feb 11, 2023
66ba0c7
Update projects/testing-library/tests/rerender.spec.ts
shaman-apprentice Feb 21, 2023
4c5a255
feat: support detectChangesOnRender within rerender
shaman-apprentice Mar 5, 2023
d218907
feat: only check for own detectChangesOnRender flag
shaman-apprentice Mar 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update projects/testing-library/tests/rerender.spec.ts 
Co-authored-by: Tim Deschryver <[email protected]>
  • Loading branch information
@shaman-apprentice @timdeschryver
shaman-apprentice and timdeschryver committed Feb 23, 2023
commit 66ba0c79048c831d5bd3836dc3db335f3b8e19d8
6 changes: 3 additions & 3 deletions projects/testing-library/tests/rerender.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,9 @@ test('rerenders the component with updated props and resets other props', async
const firstName2 = 'Chris';
await rerender({ componentProperties: { firstName: firstName2 } });

expect(screen.getByText(`${firstName2}`)).toBeInTheDocument();
expect(screen.queryByText(`${firstName2} ${lastName}`)).not.toBeInTheDocument();
expect(screen.queryByText(`${firstName} ${lastName}`)).not.toBeInTheDocument();
expect(screen.getByText(firstName2)).toBeInTheDocument();
expect(screen.queryByText(firstName)).not.toBeInTheDocument();
expect(screen.queryByText(lastName)).not.toBeInTheDocument();

expect(ngOnChangesSpy).toHaveBeenCalledTimes(2); // one time initially and one time for rerender
const rerenderedChanges = ngOnChangesSpy.mock.calls[1][0] as SimpleChanges;
Expand Down