Skip to content

update user event usage in specs #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 12, 2023
Merged

update user event usage in specs #395

merged 7 commits into from
Jul 12, 2023

Conversation

markgoho
Copy link
Contributor

this closes #394

timdeschryver
timdeschryver reviewed Jun 17, 2023
View reviewed changes
Copy link
Member

@timdeschryver timdeschryver left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like some tests broke with this, could you take a look at it please when you have the time?

@markgoho markgoho force-pushed the update-to-user-event branch from 2540651 to 244906c Compare July 4, 2023 17:03
@markgoho
Copy link
Contributor Author

markgoho commented Jul 9, 2023

It seems like some tests broke with this, could you take a look at it please when you have the time?

So sorry about this! I've fixed all that I could in reasonable amount of time. There were a few that related to fake timers and async stuff that just would not pass.

@markgoho markgoho requested a review from timdeschryver July 11, 2023 18:45
timdeschryver
timdeschryver approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@timdeschryver timdeschryver merged commit 72a4d3c into testing-library:main Jul 12, 2023
@markgoho markgoho deleted the update-to-user-event branch July 12, 2023 14:33
@timdeschryver
Copy link
Member

@all-contributors please add @markgoho for maintenance, docs

@allcontributors allcontributors bot mentioned this pull request Jul 26, 2023
Merged
@allcontributors
Copy link
Contributor

@timdeschryver

I've put up a pull request to add @markgoho! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timdeschryver timdeschryver timdeschryver approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

consider using userEvent rather than fireEvent
2 participants
@markgoho @timdeschryver