Skip to content

startsWith instead of indexOf #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Connormiha
Copy link

What:
Just simplified checking for error name

Why:

How:
indexOf -> startsWith

Checklist:

  • Documentation added to the
    docs site
  • Tests
  • Typescript definitions updated
  • Ready to be merged

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 299ec38:

Sandbox Source
busy-nash-ew55f Configuration
festive-banach-6ozpj Configuration

@codecov
Copy link

codecov bot commented Dec 16, 2019

Codecov Report

Merging #552 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #552   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines          95     95           
  Branches       15     15           
=====================================
  Hits           95     95
Impacted Files Coverage Δ
src/act-compat.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e35c213...299ec38. Read the comment docs.

Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this. Could you explain what the purpose of this PR is?

startsWith is not supported in IE11 and babel can't transpile these to use core-js as far as I know. In the current state we can't accept this PR.

@Connormiha
Copy link
Author

@eps1lon if IE11 supported, you right. This PR will break IE11.

@eps1lon
Copy link
Member

eps1lon commented Dec 19, 2019

@eps1lon if IE11 supported, you right.

I don't think we officially support it as in "if it doesn't work in IE 11 we won't prioritize it i.e. PRs welcome". At least I'm using it in IE 11 and am therefore interested in it working as good as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants