Update setup.mdx #1191
Merged
Update setup.mdx #1191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add customized `screen` and `within` for using custom queries globally.
✅ Deploy Preview for testing-library ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Co-authored-by: Tim Deschryver <[email protected]>
timdeschryver
approved these changes
Dec 17, 2022
eps1lon
reviewed
Dec 23, 2022
docs/react-testing-library/setup.mdx
Outdated
Comment on lines
262
to
265
| const customScreen = { | ||
| ...screen, | ||
| ...within(document.body, customQueries), | ||
| } |
There was a problem hiding this comment.
I think this should move below allQueries and then
Suggested change
| const customScreen = { | |
| ...screen, | |
| ...within(document.body, customQueries), | |
| } | |
| const customScreen = within(document.body, allQueries) |
|
@all-contributors add @wtlin1228 for docs |
|
I've put up a pull request to add @wtlin1228! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add customized
screenandwithinfor using custom queries globally.