docs: fix incorrect description of getByAltText #1194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testing-library ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
tnyo43
commented
Dec 26, 2022
Comment on lines
-65
to
-66
| `<img aria-label="fancy image" src="fancy.jpg" />` will be returned for both | ||
| `getByAltText('fancy image')` and `getByRole('img', { name: 'fancy image' })`. |
There was a problem hiding this comment.
What I did is just removing this "getByAltText('fancy image')"
Maybe I could correct <img aria-label="fancy image" src="fancy.jpg" /> to <img alt="fancy image" src="fancy.jpg"> as like this comment. I made this change so that the following sentence makes sense.
eps1lon
approved these changes
Dec 29, 2022
|
@all-contributors add @tnyo43 for docs |
|
I've put up a pull request to add @tnyo43! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #1190
*ByAltTextquery will not return for<img aria-label="XXX" src="fancy.jpg" />(see sandbox).