Avi Drissman | 6459548 | 2022-09-14 20:52:29 | [diff] [blame] | 1 | // Copyright 2018 The Chromium Authors |
Matt Menke | 977e61b | 2019-01-10 19:36:02 | [diff] [blame] | 2 | // Use of this source code is governed by a BSD-style license that can be |
| 3 | // found in the LICENSE file. |
| 4 | |
| 5 | #include "net/socket/connect_job.h" |
| 6 | |
Avi Drissman | 41c4a41 | 2023-01-11 22:45:37 | [diff] [blame^] | 7 | #include "base/functional/bind.h" |
| 8 | #include "base/functional/callback.h" |
Matt Menke | 977e61b | 2019-01-10 19:36:02 | [diff] [blame] | 9 | #include "base/run_loop.h" |
Gabriel Charette | c710874 | 2019-08-23 03:31:40 | [diff] [blame] | 10 | #include "base/test/task_environment.h" |
Matt Menke | 977e61b | 2019-01-10 19:36:02 | [diff] [blame] | 11 | #include "net/base/address_list.h" |
| 12 | #include "net/base/net_errors.h" |
| 13 | #include "net/base/request_priority.h" |
dalyk | edd30d98 | 2019-12-16 15:31:10 | [diff] [blame] | 14 | #include "net/dns/public/resolve_error_info.h" |
Matt Menke | 977e61b | 2019-01-10 19:36:02 | [diff] [blame] | 15 | #include "net/log/test_net_log.h" |
| 16 | #include "net/log/test_net_log_util.h" |
Matt Menke | 3abc57c | 2019-01-10 21:48:42 | [diff] [blame] | 17 | #include "net/socket/connect_job_test_util.h" |
Matt Menke | 977e61b | 2019-01-10 19:36:02 | [diff] [blame] | 18 | #include "net/socket/socket_tag.h" |
| 19 | #include "net/socket/socket_test_util.h" |
| 20 | #include "net/test/gtest_util.h" |
| 21 | #include "testing/gtest/include/gtest/gtest.h" |
| 22 | |
| 23 | namespace net { |
| 24 | namespace { |
| 25 | |
Matt Menke | 977e61b | 2019-01-10 19:36:02 | [diff] [blame] | 26 | class TestConnectJob : public ConnectJob { |
| 27 | public: |
| 28 | enum class JobType { |
| 29 | kSyncSuccess, |
| 30 | kAsyncSuccess, |
| 31 | kHung, |
| 32 | }; |
| 33 | |
| 34 | TestConnectJob(JobType job_type, |
| 35 | base::TimeDelta timeout_duration, |
Matt Menke | a6f99ad | 2019-03-08 02:26:43 | [diff] [blame] | 36 | const CommonConnectJobParams* common_connect_job_params, |
| 37 | ConnectJob::Delegate* delegate) |
Matt Menke | 1a6c92d | 2019-02-23 00:25:38 | [diff] [blame] | 38 | : ConnectJob(DEFAULT_PRIORITY, |
Matt Menke | a6f99ad | 2019-03-08 02:26:43 | [diff] [blame] | 39 | SocketTag(), |
Matt Menke | 1a6c92d | 2019-02-23 00:25:38 | [diff] [blame] | 40 | timeout_duration, |
Matt Menke | a6f99ad | 2019-03-08 02:26:43 | [diff] [blame] | 41 | common_connect_job_params, |
Matt Menke | 1a6c92d | 2019-02-23 00:25:38 | [diff] [blame] | 42 | delegate, |
| 43 | nullptr /* net_log */, |
| 44 | NetLogSourceType::TRANSPORT_CONNECT_JOB, |
| 45 | NetLogEventType::TRANSPORT_CONNECT_JOB_CONNECT), |
Tsuyoshi Horo | 2ec06e00 | 2022-06-09 01:38:59 | [diff] [blame] | 46 | job_type_(job_type) { |
Matt Menke | 977e61b | 2019-01-10 19:36:02 | [diff] [blame] | 47 | switch (job_type_) { |
| 48 | case JobType::kSyncSuccess: |
| 49 | socket_data_provider_.set_connect_data(MockConnect(SYNCHRONOUS, OK)); |
| 50 | return; |
| 51 | case JobType::kAsyncSuccess: |
| 52 | socket_data_provider_.set_connect_data(MockConnect(ASYNC, OK)); |
| 53 | return; |
| 54 | case JobType::kHung: |
| 55 | socket_data_provider_.set_connect_data( |
| 56 | MockConnect(SYNCHRONOUS, ERR_IO_PENDING)); |
| 57 | return; |
| 58 | } |
| 59 | } |
| 60 | |
Peter Boström | 407869b | 2021-10-07 04:42:48 | [diff] [blame] | 61 | TestConnectJob(const TestConnectJob&) = delete; |
| 62 | TestConnectJob& operator=(const TestConnectJob&) = delete; |
| 63 | |
Matt Menke | 977e61b | 2019-01-10 19:36:02 | [diff] [blame] | 64 | // From ConnectJob: |
| 65 | LoadState GetLoadState() const override { return LOAD_STATE_IDLE; } |
Matt Menke | 141b87f2 | 2019-01-30 02:43:03 | [diff] [blame] | 66 | bool HasEstablishedConnection() const override { return false; } |
dalyk | edd30d98 | 2019-12-16 15:31:10 | [diff] [blame] | 67 | ResolveErrorInfo GetResolveErrorInfo() const override { |
| 68 | return ResolveErrorInfo(net::OK); |
| 69 | } |
Matt Menke | 977e61b | 2019-01-10 19:36:02 | [diff] [blame] | 70 | int ConnectInternal() override { |
Tsuyoshi Horo | c39623a8 | 2022-07-11 01:27:58 | [diff] [blame] | 71 | SetSocket(std::make_unique<MockTCPClientSocket>( |
| 72 | AddressList(), net_log().net_log(), &socket_data_provider_), |
Anton Bikineev | 068d291 | 2021-05-15 20:43:52 | [diff] [blame] | 73 | absl::nullopt /* dns_aliases */); |
Matt Menke | 977e61b | 2019-01-10 19:36:02 | [diff] [blame] | 74 | return socket()->Connect(base::BindOnce( |
| 75 | &TestConnectJob::NotifyDelegateOfCompletion, base::Unretained(this))); |
| 76 | } |
| 77 | void ChangePriorityInternal(RequestPriority priority) override { |
| 78 | last_seen_priority_ = priority; |
| 79 | } |
| 80 | |
| 81 | using ConnectJob::ResetTimer; |
| 82 | |
| 83 | // The priority seen during the most recent call to ChangePriorityInternal(). |
| 84 | RequestPriority last_seen_priority() const { return last_seen_priority_; } |
| 85 | |
Matt Menke | a6f99ad | 2019-03-08 02:26:43 | [diff] [blame] | 86 | protected: |
Matt Menke | 977e61b | 2019-01-10 19:36:02 | [diff] [blame] | 87 | const JobType job_type_; |
| 88 | StaticSocketDataProvider socket_data_provider_; |
Tsuyoshi Horo | 2ec06e00 | 2022-06-09 01:38:59 | [diff] [blame] | 89 | RequestPriority last_seen_priority_ = DEFAULT_PRIORITY; |
Matt Menke | 977e61b | 2019-01-10 19:36:02 | [diff] [blame] | 90 | }; |
| 91 | |
| 92 | class ConnectJobTest : public testing::Test { |
| 93 | public: |
| 94 | ConnectJobTest() |
Gabriel Charette | 694c3c33 | 2019-08-19 14:53:05 | [diff] [blame] | 95 | : task_environment_(base::test::TaskEnvironment::TimeSource::MOCK_TIME), |
Matt Menke | a6f99ad | 2019-03-08 02:26:43 | [diff] [blame] | 96 | common_connect_job_params_( |
| 97 | nullptr /* client_socket_factory */, |
| 98 | nullptr /* host_resolver */, |
Matt Menke | b88837e | 2019-03-20 11:50:40 | [diff] [blame] | 99 | nullptr /* http_auth_cache */, |
| 100 | nullptr /* http_auth_handler_factory */, |
| 101 | nullptr /* spdy_session_pool */, |
Matt Menke | b5fb42b | 2019-03-22 17:26:13 | [diff] [blame] | 102 | nullptr /* quic_supported_versions */, |
Matt Menke | b88837e | 2019-03-20 11:50:40 | [diff] [blame] | 103 | nullptr /* quic_stream_factory */, |
Matt Menke | a6f99ad | 2019-03-08 02:26:43 | [diff] [blame] | 104 | nullptr /* proxy_delegate */, |
Matt Menke | d732ea4 | 2019-03-08 12:05:00 | [diff] [blame] | 105 | nullptr /* http_user_agent_settings */, |
David Benjamin | 24725be | 2019-07-24 20:57:18 | [diff] [blame] | 106 | nullptr /* ssl_client_context */, |
Matt Menke | a6f99ad | 2019-03-08 02:26:43 | [diff] [blame] | 107 | nullptr /* socket_performance_watcher_factory */, |
| 108 | nullptr /* network_quality_estimator */, |
Matt Reichhoff | 36a1fd6 | 2021-10-12 22:52:20 | [diff] [blame] | 109 | NetLog::Get(), |
Matt Menke | a6f99ad | 2019-03-08 02:26:43 | [diff] [blame] | 110 | nullptr /* websocket_endpoint_lock_manager */) {} |
Matt Menke | 977e61b | 2019-01-10 19:36:02 | [diff] [blame] | 111 | ~ConnectJobTest() override = default; |
| 112 | |
| 113 | protected: |
Gabriel Charette | 694c3c33 | 2019-08-19 14:53:05 | [diff] [blame] | 114 | base::test::TaskEnvironment task_environment_; |
Matt Reichhoff | 36a1fd6 | 2021-10-12 22:52:20 | [diff] [blame] | 115 | RecordingNetLogObserver net_log_observer_; |
Matt Menke | a6f99ad | 2019-03-08 02:26:43 | [diff] [blame] | 116 | const CommonConnectJobParams common_connect_job_params_; |
Matt Menke | 977e61b | 2019-01-10 19:36:02 | [diff] [blame] | 117 | TestConnectJobDelegate delegate_; |
| 118 | }; |
| 119 | |
| 120 | // Even though a timeout is specified, it doesn't time out on a synchronous |
| 121 | // completion. |
| 122 | TEST_F(ConnectJobTest, NoTimeoutOnSyncCompletion) { |
| 123 | TestConnectJob job(TestConnectJob::JobType::kSyncSuccess, |
Peter Kasting | e5a38ed | 2021-10-02 03:06:35 | [diff] [blame] | 124 | base::Microseconds(1), &common_connect_job_params_, |
| 125 | &delegate_); |
Matt Menke | 977e61b | 2019-01-10 19:36:02 | [diff] [blame] | 126 | EXPECT_THAT(job.Connect(), test::IsOk()); |
| 127 | } |
| 128 | |
| 129 | // Even though a timeout is specified, it doesn't time out on an asynchronous |
| 130 | // completion. |
| 131 | TEST_F(ConnectJobTest, NoTimeoutOnAsyncCompletion) { |
Peter Kasting | e5a38ed | 2021-10-02 03:06:35 | [diff] [blame] | 132 | TestConnectJob job(TestConnectJob::JobType::kAsyncSuccess, base::Minutes(1), |
Matt Menke | a6f99ad | 2019-03-08 02:26:43 | [diff] [blame] | 133 | &common_connect_job_params_, &delegate_); |
Matt Menke | 977e61b | 2019-01-10 19:36:02 | [diff] [blame] | 134 | ASSERT_THAT(job.Connect(), test::IsError(ERR_IO_PENDING)); |
| 135 | EXPECT_THAT(delegate_.WaitForResult(), test::IsOk()); |
| 136 | } |
| 137 | |
| 138 | // Job shouldn't timeout when passed a TimeDelta of zero. |
| 139 | TEST_F(ConnectJobTest, NoTimeoutWithNoTimeDelta) { |
| 140 | TestConnectJob job(TestConnectJob::JobType::kHung, base::TimeDelta(), |
Matt Menke | a6f99ad | 2019-03-08 02:26:43 | [diff] [blame] | 141 | &common_connect_job_params_, &delegate_); |
Matt Menke | 977e61b | 2019-01-10 19:36:02 | [diff] [blame] | 142 | ASSERT_THAT(job.Connect(), test::IsError(ERR_IO_PENDING)); |
Gabriel Charette | 694c3c33 | 2019-08-19 14:53:05 | [diff] [blame] | 143 | task_environment_.RunUntilIdle(); |
Matt Menke | 977e61b | 2019-01-10 19:36:02 | [diff] [blame] | 144 | EXPECT_FALSE(delegate_.has_result()); |
| 145 | } |
| 146 | |
| 147 | // Make sure that ChangePriority() works, and new priority is visible to |
| 148 | // subclasses during the SetPriorityInternal call. |
| 149 | TEST_F(ConnectJobTest, SetPriority) { |
| 150 | TestConnectJob job(TestConnectJob::JobType::kAsyncSuccess, |
Peter Kasting | e5a38ed | 2021-10-02 03:06:35 | [diff] [blame] | 151 | base::Microseconds(1), &common_connect_job_params_, |
| 152 | &delegate_); |
Matt Menke | 977e61b | 2019-01-10 19:36:02 | [diff] [blame] | 153 | ASSERT_THAT(job.Connect(), test::IsError(ERR_IO_PENDING)); |
| 154 | |
| 155 | job.ChangePriority(HIGHEST); |
| 156 | EXPECT_EQ(HIGHEST, job.priority()); |
| 157 | EXPECT_EQ(HIGHEST, job.last_seen_priority()); |
| 158 | |
| 159 | job.ChangePriority(MEDIUM); |
| 160 | EXPECT_EQ(MEDIUM, job.priority()); |
| 161 | EXPECT_EQ(MEDIUM, job.last_seen_priority()); |
| 162 | |
| 163 | EXPECT_THAT(delegate_.WaitForResult(), test::IsOk()); |
| 164 | } |
| 165 | |
| 166 | TEST_F(ConnectJobTest, TimedOut) { |
Peter Kasting | e5a38ed | 2021-10-02 03:06:35 | [diff] [blame] | 167 | const base::TimeDelta kTimeout = base::Hours(1); |
Matt Menke | 977e61b | 2019-01-10 19:36:02 | [diff] [blame] | 168 | |
Matt Menke | a6f99ad | 2019-03-08 02:26:43 | [diff] [blame] | 169 | std::unique_ptr<TestConnectJob> job = |
| 170 | std::make_unique<TestConnectJob>(TestConnectJob::JobType::kHung, kTimeout, |
| 171 | &common_connect_job_params_, &delegate_); |
Matt Menke | 977e61b | 2019-01-10 19:36:02 | [diff] [blame] | 172 | ASSERT_THAT(job->Connect(), test::IsError(ERR_IO_PENDING)); |
| 173 | |
| 174 | // Nothing should happen before the specified time. |
Peter Kasting | e5a38ed | 2021-10-02 03:06:35 | [diff] [blame] | 175 | task_environment_.FastForwardBy(kTimeout - base::Milliseconds(1)); |
Matt Menke | 977e61b | 2019-01-10 19:36:02 | [diff] [blame] | 176 | base::RunLoop().RunUntilIdle(); |
| 177 | EXPECT_FALSE(delegate_.has_result()); |
| 178 | |
| 179 | // At which point the job should time out. |
Peter Kasting | e5a38ed | 2021-10-02 03:06:35 | [diff] [blame] | 180 | task_environment_.FastForwardBy(base::Milliseconds(1)); |
Matt Menke | 977e61b | 2019-01-10 19:36:02 | [diff] [blame] | 181 | EXPECT_THAT(delegate_.WaitForResult(), test::IsError(ERR_TIMED_OUT)); |
| 182 | |
| 183 | // Have to delete the job for it to log the end event. |
| 184 | job.reset(); |
| 185 | |
Matt Reichhoff | 36a1fd6 | 2021-10-12 22:52:20 | [diff] [blame] | 186 | auto entries = net_log_observer_.GetEntries(); |
Matt Menke | 977e61b | 2019-01-10 19:36:02 | [diff] [blame] | 187 | |
| 188 | EXPECT_EQ(6u, entries.size()); |
Matt Menke | 1a6c92d | 2019-02-23 00:25:38 | [diff] [blame] | 189 | EXPECT_TRUE(LogContainsBeginEvent(entries, 0, NetLogEventType::CONNECT_JOB)); |
Matt Menke | 977e61b | 2019-01-10 19:36:02 | [diff] [blame] | 190 | EXPECT_TRUE(LogContainsBeginEvent( |
Matt Menke | 1a6c92d | 2019-02-23 00:25:38 | [diff] [blame] | 191 | entries, 1, NetLogEventType::TRANSPORT_CONNECT_JOB_CONNECT)); |
Matt Menke | 977e61b | 2019-01-10 19:36:02 | [diff] [blame] | 192 | EXPECT_TRUE(LogContainsEvent(entries, 2, |
| 193 | NetLogEventType::CONNECT_JOB_SET_SOCKET, |
| 194 | NetLogEventPhase::NONE)); |
Matt Menke | 1a6c92d | 2019-02-23 00:25:38 | [diff] [blame] | 195 | EXPECT_TRUE(LogContainsEvent(entries, 3, |
| 196 | NetLogEventType::CONNECT_JOB_TIMED_OUT, |
| 197 | NetLogEventPhase::NONE)); |
Matt Menke | 977e61b | 2019-01-10 19:36:02 | [diff] [blame] | 198 | EXPECT_TRUE(LogContainsEndEvent( |
Matt Menke | 1a6c92d | 2019-02-23 00:25:38 | [diff] [blame] | 199 | entries, 4, NetLogEventType::TRANSPORT_CONNECT_JOB_CONNECT)); |
| 200 | EXPECT_TRUE(LogContainsEndEvent(entries, 5, NetLogEventType::CONNECT_JOB)); |
Matt Menke | 977e61b | 2019-01-10 19:36:02 | [diff] [blame] | 201 | } |
| 202 | |
| 203 | TEST_F(ConnectJobTest, TimedOutWithRestartedTimer) { |
Peter Kasting | e5a38ed | 2021-10-02 03:06:35 | [diff] [blame] | 204 | const base::TimeDelta kTimeout = base::Hours(1); |
Matt Menke | 977e61b | 2019-01-10 19:36:02 | [diff] [blame] | 205 | |
Matt Menke | a6f99ad | 2019-03-08 02:26:43 | [diff] [blame] | 206 | TestConnectJob job(TestConnectJob::JobType::kHung, kTimeout, |
| 207 | &common_connect_job_params_, &delegate_); |
Matt Menke | 977e61b | 2019-01-10 19:36:02 | [diff] [blame] | 208 | ASSERT_THAT(job.Connect(), test::IsError(ERR_IO_PENDING)); |
| 209 | |
| 210 | // Nothing should happen before the specified time. |
Peter Kasting | e5a38ed | 2021-10-02 03:06:35 | [diff] [blame] | 211 | task_environment_.FastForwardBy(kTimeout - base::Milliseconds(1)); |
Matt Menke | 977e61b | 2019-01-10 19:36:02 | [diff] [blame] | 212 | base::RunLoop().RunUntilIdle(); |
| 213 | EXPECT_FALSE(delegate_.has_result()); |
| 214 | |
| 215 | // Make sure restarting the timer is respected. |
| 216 | job.ResetTimer(kTimeout); |
Peter Kasting | e5a38ed | 2021-10-02 03:06:35 | [diff] [blame] | 217 | task_environment_.FastForwardBy(kTimeout - base::Milliseconds(1)); |
Matt Menke | 977e61b | 2019-01-10 19:36:02 | [diff] [blame] | 218 | base::RunLoop().RunUntilIdle(); |
| 219 | EXPECT_FALSE(delegate_.has_result()); |
| 220 | |
Peter Kasting | e5a38ed | 2021-10-02 03:06:35 | [diff] [blame] | 221 | task_environment_.FastForwardBy(base::Milliseconds(1)); |
Matt Menke | 977e61b | 2019-01-10 19:36:02 | [diff] [blame] | 222 | EXPECT_THAT(delegate_.WaitForResult(), test::IsError(ERR_TIMED_OUT)); |
| 223 | } |
| 224 | |
| 225 | } // namespace |
| 226 | } // namespace net |