[email protected] | 3d58737 | 2013-06-01 04:31:45 | [diff] [blame] | 1 | // Copyright 2013 The Chromium Authors. All rights reserved. |
[email protected] | 4f38642 | 2010-07-20 04:19:49 | [diff] [blame] | 2 | // Use of this source code is governed by a BSD-style license that can be |
| 3 | // found in the LICENSE file. |
| 4 | |
Bence Béky | 94658bf | 2018-05-11 19:22:58 | [diff] [blame] | 5 | #include "net/spdy/spdy_stream.h" |
avi | d0181f3 | 2015-12-10 19:41:47 | [diff] [blame] | 6 | |
dcheng | c7eeda42 | 2015-12-26 03:56:48 | [diff] [blame] | 7 | #include <stdint.h> |
danakj | aee3e1ec | 2016-04-16 00:23:18 | [diff] [blame] | 8 | |
diannahu | 46ab181 | 2016-12-26 21:27:07 | [diff] [blame] | 9 | #include <algorithm> |
[email protected] | 3d58737 | 2013-06-01 04:31:45 | [diff] [blame] | 10 | #include <cstddef> |
avi | d0181f3 | 2015-12-10 19:41:47 | [diff] [blame] | 11 | #include <limits> |
danakj | aee3e1ec | 2016-04-16 00:23:18 | [diff] [blame] | 12 | #include <memory> |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 13 | #include <string> |
dcheng | c7eeda42 | 2015-12-26 03:56:48 | [diff] [blame] | 14 | #include <utility> |
[email protected] | 3d58737 | 2013-06-01 04:31:45 | [diff] [blame] | 15 | #include <vector> |
| 16 | |
Sebastien Marchand | 6d0558fd | 2019-01-25 16:49:37 | [diff] [blame] | 17 | #include "base/bind.h" |
[email protected] | 3b63f8f4 | 2011-03-28 01:54:15 | [diff] [blame] | 18 | #include "base/memory/ref_counted.h" |
mmenke | e2401192 | 2015-12-17 22:12:59 | [diff] [blame] | 19 | #include "base/run_loop.h" |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 20 | #include "base/strings/string_piece.h" |
Gabriel Charette | d87f10f | 2022-03-31 00:44:22 | [diff] [blame] | 21 | #include "base/time/time.h" |
[email protected] | 1bbabc8 | 2013-03-25 21:11:02 | [diff] [blame] | 22 | #include "net/base/request_priority.h" |
Ben Schwartz | 3ff4dc1e6 | 2021-04-27 21:15:23 | [diff] [blame] | 23 | #include "net/dns/public/secure_dns_policy.h" |
Bence Béky | 5b1e4ce7 | 2018-01-11 14:55:15 | [diff] [blame] | 24 | #include "net/http/http_request_info.h" |
mikecirone | 8b85c43 | 2016-09-08 19:11:00 | [diff] [blame] | 25 | #include "net/log/net_log_event_type.h" |
mmenke | 16a7cbdd | 2015-04-24 23:00:56 | [diff] [blame] | 26 | #include "net/log/test_net_log.h" |
mmenke | 43758e6 | 2015-05-04 21:09:46 | [diff] [blame] | 27 | #include "net/log/test_net_log_util.h" |
Paul Jensen | a457017a | 2018-01-19 23:52:04 | [diff] [blame] | 28 | #include "net/socket/socket_tag.h" |
[email protected] | 6fe2e99 | 2013-06-12 03:38:43 | [diff] [blame] | 29 | #include "net/socket/socket_test_util.h" |
Bence Béky | 94658bf | 2018-05-11 19:22:58 | [diff] [blame] | 30 | #include "net/spdy/buffered_spdy_framer.h" |
| 31 | #include "net/spdy/http2_push_promise_index.h" |
| 32 | #include "net/spdy/spdy_http_utils.h" |
| 33 | #include "net/spdy/spdy_session.h" |
| 34 | #include "net/spdy/spdy_session_pool.h" |
| 35 | #include "net/spdy/spdy_stream_test_util.h" |
| 36 | #include "net/spdy/spdy_test_util_common.h" |
bnc | 032658ba | 2016-09-26 18:17:15 | [diff] [blame] | 37 | #include "net/test/cert_test_util.h" |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 38 | #include "net/test/gtest_util.h" |
bnc | 032658ba | 2016-09-26 18:17:15 | [diff] [blame] | 39 | #include "net/test/test_data_directory.h" |
Gabriel Charette | c710874 | 2019-08-23 03:31:40 | [diff] [blame] | 40 | #include "net/test/test_with_task_environment.h" |
Ryan Hamilton | ea4fa19 | 2022-04-12 18:30:49 | [diff] [blame] | 41 | #include "net/third_party/quiche/src/quiche/spdy/core/spdy_protocol.h" |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 42 | #include "testing/gmock/include/gmock/gmock.h" |
[email protected] | 4f38642 | 2010-07-20 04:19:49 | [diff] [blame] | 43 | #include "testing/gtest/include/gtest/gtest.h" |
| 44 | |
[email protected] | 4f38642 | 2010-07-20 04:19:49 | [diff] [blame] | 45 | // TODO(ukai): factor out common part with spdy_http_stream_unittest.cc |
[email protected] | b9ec688 | 2011-07-01 07:40:26 | [diff] [blame] | 46 | // |
Tsuyoshi Horo | 4f516be | 2022-06-14 11:53:13 | [diff] [blame^] | 47 | namespace net::test { |
[email protected] | 34a4dea | 2013-03-13 00:42:30 | [diff] [blame] | 48 | |
[email protected] | 4f38642 | 2010-07-20 04:19:49 | [diff] [blame] | 49 | namespace { |
| 50 | |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 51 | const char kPushUrl[] = "https://www.example.org/push"; |
[email protected] | cbdd7316 | 2013-03-18 23:27:33 | [diff] [blame] | 52 | const char kPostBody[] = "\0hello!\xff"; |
Daniel Cheng | 5feb16f | 2022-02-28 06:52:07 | [diff] [blame] | 53 | const size_t kPostBodyLength = std::size(kPostBody); |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 54 | const base::StringPiece kPostBodyStringPiece(kPostBody, kPostBodyLength); |
[email protected] | 39d13d94 | 2012-07-19 16:48:20 | [diff] [blame] | 55 | |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 56 | static base::TimeTicks g_time_now; |
| 57 | |
| 58 | base::TimeTicks InstantaneousReads() { |
| 59 | return g_time_now; |
| 60 | } |
| 61 | |
Hiroki Nakagawa | d67642b59 | 2020-12-10 13:26:35 | [diff] [blame] | 62 | // Creates a MockRead from the given serialized frame except for the last byte. |
| 63 | MockRead ReadFrameExceptForLastByte(const spdy::SpdySerializedFrame& frame) { |
| 64 | CHECK_GE(frame.size(), 2u); |
| 65 | return MockRead(ASYNC, frame.data(), frame.size() - 1); |
| 66 | } |
| 67 | |
| 68 | // Creates a MockRead from the last byte of the given serialized frame. |
| 69 | MockRead LastByteOfReadFrame(const spdy::SpdySerializedFrame& frame) { |
| 70 | CHECK_GE(frame.size(), 2u); |
| 71 | return MockRead(ASYNC, frame.data() + frame.size() - 1, 1); |
| 72 | } |
| 73 | |
rdsmith | ebb50aa | 2015-11-12 03:44:38 | [diff] [blame] | 74 | } // namespace |
| 75 | |
Hiroki Nakagawa | d67642b59 | 2020-12-10 13:26:35 | [diff] [blame] | 76 | class SpdyStreamTest : public ::testing::Test, public WithTaskEnvironment { |
[email protected] | 4f38642 | 2010-07-20 04:19:49 | [diff] [blame] | 77 | protected: |
[email protected] | d2de7da | 2013-05-22 07:49:56 | [diff] [blame] | 78 | // A function that takes a SpdyStream and the number of bytes which |
| 79 | // will unstall the next frame completely. |
Anna Malova | 924d79d | 2020-03-04 17:09:32 | [diff] [blame] | 80 | typedef base::OnceCallback<void(const base::WeakPtr<SpdyStream>&, int32_t)> |
[email protected] | d2de7da | 2013-05-22 07:49:56 | [diff] [blame] | 81 | UnstallFunction; |
| 82 | |
Hiroki Nakagawa | d67642b59 | 2020-12-10 13:26:35 | [diff] [blame] | 83 | explicit SpdyStreamTest(base::test::TaskEnvironment::TimeSource time_source = |
| 84 | base::test::TaskEnvironment::TimeSource::DEFAULT) |
| 85 | : WithTaskEnvironment(time_source), |
| 86 | url_(kDefaultUrl), |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 87 | session_(SpdySessionDependencies::SpdyCreateSession(&session_deps_)), |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 88 | ssl_(SYNCHRONOUS, OK) {} |
rdsmith | ebb50aa | 2015-11-12 03:44:38 | [diff] [blame] | 89 | |
Chris Watkins | 61914cb | 2017-12-01 19:59:00 | [diff] [blame] | 90 | ~SpdyStreamTest() override = default; |
[email protected] | 4f38642 | 2010-07-20 04:19:49 | [diff] [blame] | 91 | |
[email protected] | 795cbf8 | 2013-07-22 09:37:27 | [diff] [blame] | 92 | base::WeakPtr<SpdySession> CreateDefaultSpdySession() { |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 93 | SpdySessionKey key(HostPortPair::FromURL(url_), ProxyServer::Direct(), |
Matt Menke | 2436b2f | 2018-12-11 18:07:11 | [diff] [blame] | 94 | PRIVACY_MODE_DISABLED, |
dalyk | 51ab46b | 2019-10-15 15:14:34 | [diff] [blame] | 95 | SpdySessionKey::IsProxySession::kFalse, SocketTag(), |
Ben Schwartz | 3ff4dc1e6 | 2021-04-27 21:15:23 | [diff] [blame] | 96 | NetworkIsolationKey(), SecureDnsPolicy::kAllow); |
Bence Béky | 0ef1556e | 2017-06-30 19:52:52 | [diff] [blame] | 97 | return CreateSpdySession(session_.get(), key, NetLogWithSource()); |
[email protected] | 34a4dea | 2013-03-13 00:42:30 | [diff] [blame] | 98 | } |
| 99 | |
fdoray | 92e35a7 | 2016-06-10 15:54:55 | [diff] [blame] | 100 | void TearDown() override { base::RunLoop().RunUntilIdle(); } |
[email protected] | 4f38642 | 2010-07-20 04:19:49 | [diff] [blame] | 101 | |
[email protected] | d2de7da | 2013-05-22 07:49:56 | [diff] [blame] | 102 | void RunResumeAfterUnstallRequestResponseTest( |
Anna Malova | 924d79d | 2020-03-04 17:09:32 | [diff] [blame] | 103 | UnstallFunction unstall_function); |
[email protected] | d2de7da | 2013-05-22 07:49:56 | [diff] [blame] | 104 | |
Anna Malova | 924d79d | 2020-03-04 17:09:32 | [diff] [blame] | 105 | void RunResumeAfterUnstallBidirectionalTest(UnstallFunction unstall_function); |
[email protected] | d2de7da | 2013-05-22 07:49:56 | [diff] [blame] | 106 | |
[email protected] | 3d58737 | 2013-06-01 04:31:45 | [diff] [blame] | 107 | // Add{Read,Write}() populates lists that are eventually passed to a |
| 108 | // SocketData class. |frame| must live for the whole test. |
| 109 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 110 | void AddRead(const spdy::SpdySerializedFrame& frame) { |
[email protected] | 3d58737 | 2013-06-01 04:31:45 | [diff] [blame] | 111 | reads_.push_back(CreateMockRead(frame, offset_++)); |
| 112 | } |
| 113 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 114 | void AddWrite(const spdy::SpdySerializedFrame& frame) { |
[email protected] | 3d58737 | 2013-06-01 04:31:45 | [diff] [blame] | 115 | writes_.push_back(CreateMockWrite(frame, offset_++)); |
| 116 | } |
| 117 | |
Hiroki Nakagawa | d67642b59 | 2020-12-10 13:26:35 | [diff] [blame] | 118 | void AddMockRead(MockRead read) { |
| 119 | read.sequence_number = offset_++; |
| 120 | reads_.push_back(std::move(read)); |
| 121 | } |
| 122 | |
[email protected] | 3d58737 | 2013-06-01 04:31:45 | [diff] [blame] | 123 | void AddReadEOF() { |
| 124 | reads_.push_back(MockRead(ASYNC, 0, offset_++)); |
| 125 | } |
| 126 | |
mmenke | e2401192 | 2015-12-17 22:12:59 | [diff] [blame] | 127 | void AddWritePause() { |
| 128 | writes_.push_back(MockWrite(ASYNC, ERR_IO_PENDING, offset_++)); |
| 129 | } |
| 130 | |
| 131 | void AddReadPause() { |
| 132 | reads_.push_back(MockRead(ASYNC, ERR_IO_PENDING, offset_++)); |
| 133 | } |
| 134 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 135 | base::span<const MockRead> GetReads() { return reads_; } |
| 136 | base::span<const MockWrite> GetWrites() { return writes_; } |
[email protected] | 3d58737 | 2013-06-01 04:31:45 | [diff] [blame] | 137 | |
caseq | e8340bc9 | 2016-04-20 00:02:57 | [diff] [blame] | 138 | void ActivatePushStream(SpdySession* session, SpdyStream* stream) { |
| 139 | std::unique_ptr<SpdyStream> activated = |
| 140 | session->ActivateCreatedStream(stream); |
| 141 | activated->set_stream_id(2); |
| 142 | session->InsertActivatedStream(std::move(activated)); |
| 143 | } |
| 144 | |
bnc | 032658ba | 2016-09-26 18:17:15 | [diff] [blame] | 145 | void AddSSLSocketData() { |
| 146 | // Load a cert that is valid for |
| 147 | // www.example.org, mail.example.org, and mail.example.com. |
Ryan Sleevi | 4f83209 | 2017-11-21 23:25:49 | [diff] [blame] | 148 | ssl_.ssl_info.cert = |
| 149 | ImportCertFromFile(GetTestCertsDirectory(), "spdy_pooling.pem"); |
| 150 | ASSERT_TRUE(ssl_.ssl_info.cert); |
bnc | 032658ba | 2016-09-26 18:17:15 | [diff] [blame] | 151 | session_deps_.socket_factory->AddSSLSocketDataProvider(&ssl_); |
| 152 | } |
| 153 | |
Bence Béky | 7bf9436 | 2018-01-10 13:19:36 | [diff] [blame] | 154 | static size_t num_pushed_streams(base::WeakPtr<SpdySession> session) { |
| 155 | return session->num_pushed_streams_; |
| 156 | } |
| 157 | |
Patrick Meenan | 8b7432fb | 2022-01-12 14:07:27 | [diff] [blame] | 158 | int32_t unacked_recv_window_bytes(base::WeakPtr<SpdyStream> stream) { |
| 159 | return stream->unacked_recv_window_bytes_; |
| 160 | } |
| 161 | |
Bence Béky | 7bf9436 | 2018-01-10 13:19:36 | [diff] [blame] | 162 | static SpdySessionPool* spdy_session_pool( |
| 163 | base::WeakPtr<SpdySession> session) { |
| 164 | return session->pool_; |
| 165 | } |
| 166 | |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 167 | const GURL url_; |
[email protected] | a4a6777 | 2013-05-08 22:56:07 | [diff] [blame] | 168 | SpdyTestUtil spdy_util_; |
[email protected] | 34a4dea | 2013-03-13 00:42:30 | [diff] [blame] | 169 | SpdySessionDependencies session_deps_; |
danakj | aee3e1ec | 2016-04-16 00:23:18 | [diff] [blame] | 170 | std::unique_ptr<HttpNetworkSession> session_; |
[email protected] | 3d58737 | 2013-06-01 04:31:45 | [diff] [blame] | 171 | |
| 172 | private: |
| 173 | // Used by Add{Read,Write}() above. |
| 174 | std::vector<MockWrite> writes_; |
| 175 | std::vector<MockRead> reads_; |
Tsuyoshi Horo | b2022b5 | 2022-06-09 01:44:07 | [diff] [blame] | 176 | int offset_ = 0; |
bnc | 032658ba | 2016-09-26 18:17:15 | [diff] [blame] | 177 | SSLSocketDataProvider ssl_; |
[email protected] | 4f38642 | 2010-07-20 04:19:49 | [diff] [blame] | 178 | }; |
| 179 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 180 | TEST_F(SpdyStreamTest, SendDataAfterOpen) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 181 | spdy::SpdySerializedFrame req(spdy_util_.ConstructSpdyPost( |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 182 | kDefaultUrl, 1, kPostBodyLength, LOWEST, nullptr, 0)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 183 | AddWrite(req); |
[email protected] | 3d58737 | 2013-06-01 04:31:45 | [diff] [blame] | 184 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 185 | spdy::SpdySerializedFrame resp(spdy_util_.ConstructSpdyPostReply(nullptr, 0)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 186 | AddRead(resp); |
[email protected] | 3d58737 | 2013-06-01 04:31:45 | [diff] [blame] | 187 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 188 | spdy::SpdySerializedFrame msg( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 189 | spdy_util_.ConstructSpdyDataFrame(1, kPostBodyStringPiece, false)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 190 | AddWrite(msg); |
[email protected] | 4f38642 | 2010-07-20 04:19:49 | [diff] [blame] | 191 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 192 | spdy::SpdySerializedFrame echo( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 193 | spdy_util_.ConstructSpdyDataFrame(1, kPostBodyStringPiece, false)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 194 | AddRead(echo); |
[email protected] | 4f38642 | 2010-07-20 04:19:49 | [diff] [blame] | 195 | |
[email protected] | 3d58737 | 2013-06-01 04:31:45 | [diff] [blame] | 196 | AddReadEOF(); |
| 197 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 198 | SequencedSocketData data(GetReads(), GetWrites()); |
[email protected] | d973e99a | 2012-02-17 21:02:36 | [diff] [blame] | 199 | MockConnect connect_data(SYNCHRONOUS, OK); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 200 | data.set_connect_data(connect_data); |
mmenke | e2401192 | 2015-12-17 22:12:59 | [diff] [blame] | 201 | session_deps_.socket_factory->AddSocketDataProvider(&data); |
[email protected] | 4f38642 | 2010-07-20 04:19:49 | [diff] [blame] | 202 | |
bnc | 032658ba | 2016-09-26 18:17:15 | [diff] [blame] | 203 | AddSSLSocketData(); |
| 204 | |
[email protected] | 795cbf8 | 2013-07-22 09:37:27 | [diff] [blame] | 205 | base::WeakPtr<SpdySession> session(CreateDefaultSpdySession()); |
[email protected] | e3861ca | 2013-03-02 01:00:45 | [diff] [blame] | 206 | |
tfarina | 4283411 | 2016-09-22 13:38:20 | [diff] [blame] | 207 | base::WeakPtr<SpdyStream> stream = CreateStreamSynchronously( |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 208 | SPDY_BIDIRECTIONAL_STREAM, session, url_, LOWEST, NetLogWithSource()); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 209 | ASSERT_TRUE(stream); |
Bence Béky | 39d7429 | 2018-03-02 04:31:18 | [diff] [blame] | 210 | EXPECT_EQ(kDefaultUrl, stream->url().spec()); |
[email protected] | 4f38642 | 2010-07-20 04:19:49 | [diff] [blame] | 211 | |
[email protected] | 194cfcf | 2013-05-23 21:44:44 | [diff] [blame] | 212 | StreamDelegateSendImmediate delegate(stream, kPostBodyStringPiece); |
[email protected] | 34a4dea | 2013-03-13 00:42:30 | [diff] [blame] | 213 | stream->SetDelegate(&delegate); |
[email protected] | 4f38642 | 2010-07-20 04:19:49 | [diff] [blame] | 214 | |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 215 | spdy::Http2HeaderBlock headers( |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 216 | spdy_util_.ConstructPostHeaderBlock(kDefaultUrl, kPostBodyLength)); |
| 217 | EXPECT_THAT(stream->SendRequestHeaders(std::move(headers), MORE_DATA_TO_SEND), |
| 218 | IsError(ERR_IO_PENDING)); |
[email protected] | 4f38642 | 2010-07-20 04:19:49 | [diff] [blame] | 219 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 220 | EXPECT_THAT(delegate.WaitForClose(), IsError(ERR_CONNECTION_CLOSED)); |
[email protected] | 4f38642 | 2010-07-20 04:19:49 | [diff] [blame] | 221 | |
[email protected] | 34a4dea | 2013-03-13 00:42:30 | [diff] [blame] | 222 | EXPECT_TRUE(delegate.send_headers_completed()); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 223 | EXPECT_EQ("200", delegate.GetResponseHeaderValue(spdy::kHttp2StatusHeader)); |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 224 | EXPECT_EQ(std::string(kPostBody, kPostBodyLength), |
[email protected] | 09a8d917 | 2013-04-17 19:23:49 | [diff] [blame] | 225 | delegate.TakeReceivedData()); |
rch | 37de576c | 2015-05-17 20:28:17 | [diff] [blame] | 226 | EXPECT_TRUE(data.AllWriteDataConsumed()); |
[email protected] | 4f38642 | 2010-07-20 04:19:49 | [diff] [blame] | 227 | } |
| 228 | |
Stefano Duo | 62d36c4 | 2022-01-17 13:24:02 | [diff] [blame] | 229 | TEST_F(SpdyStreamTest, BrokenConnectionDetectionSuccessfulRequest) { |
| 230 | spdy::SpdySerializedFrame req(spdy_util_.ConstructSpdyPost( |
| 231 | kDefaultUrl, 1, kPostBodyLength, LOWEST, nullptr, 0)); |
| 232 | AddWrite(req); |
| 233 | |
| 234 | spdy::SpdySerializedFrame resp(spdy_util_.ConstructSpdyPostReply(nullptr, 0)); |
| 235 | AddRead(resp); |
| 236 | |
| 237 | spdy::SpdySerializedFrame msg( |
| 238 | spdy_util_.ConstructSpdyDataFrame(1, kPostBodyStringPiece, false)); |
| 239 | AddWrite(msg); |
| 240 | |
| 241 | spdy::SpdySerializedFrame echo( |
| 242 | spdy_util_.ConstructSpdyDataFrame(1, kPostBodyStringPiece, false)); |
| 243 | AddRead(echo); |
| 244 | |
| 245 | AddReadPause(); |
| 246 | AddReadEOF(); |
| 247 | |
| 248 | SequencedSocketData data(GetReads(), GetWrites()); |
| 249 | MockConnect connect_data(SYNCHRONOUS, OK); |
| 250 | data.set_connect_data(connect_data); |
| 251 | session_deps_.socket_factory->AddSocketDataProvider(&data); |
| 252 | |
| 253 | AddSSLSocketData(); |
| 254 | |
| 255 | base::WeakPtr<SpdySession> session(CreateDefaultSpdySession()); |
| 256 | |
| 257 | ASSERT_FALSE(session->IsBrokenConnectionDetectionEnabled()); |
| 258 | base::WeakPtr<SpdyStream> stream = CreateStreamSynchronously( |
| 259 | SPDY_BIDIRECTIONAL_STREAM, session, url_, LOWEST, NetLogWithSource(), |
| 260 | true, base::Seconds(10)); |
| 261 | ASSERT_TRUE(stream); |
| 262 | ASSERT_TRUE(session->IsBrokenConnectionDetectionEnabled()); |
| 263 | StreamDelegateSendImmediate delegate(stream, kPostBodyStringPiece); |
| 264 | stream->SetDelegate(&delegate); |
| 265 | |
| 266 | spdy::Http2HeaderBlock headers( |
| 267 | spdy_util_.ConstructPostHeaderBlock(kDefaultUrl, kPostBodyLength)); |
| 268 | EXPECT_THAT(stream->SendRequestHeaders(std::move(headers), MORE_DATA_TO_SEND), |
| 269 | IsError(ERR_IO_PENDING)); |
| 270 | |
| 271 | base::RunLoop().RunUntilIdle(); |
| 272 | ASSERT_TRUE(session->IsBrokenConnectionDetectionEnabled()); |
| 273 | |
| 274 | data.Resume(); |
| 275 | EXPECT_THAT(delegate.WaitForClose(), IsError(ERR_CONNECTION_CLOSED)); |
| 276 | ASSERT_FALSE(session->IsBrokenConnectionDetectionEnabled()); |
| 277 | } |
| 278 | |
xunjieli | 294da72 | 2015-08-11 19:15:02 | [diff] [blame] | 279 | // Delegate that receives trailers. |
| 280 | class StreamDelegateWithTrailers : public test::StreamDelegateWithBody { |
| 281 | public: |
| 282 | StreamDelegateWithTrailers(const base::WeakPtr<SpdyStream>& stream, |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 283 | base::StringPiece data) |
xunjieli | 294da72 | 2015-08-11 19:15:02 | [diff] [blame] | 284 | : StreamDelegateWithBody(stream, data) {} |
| 285 | |
Chris Watkins | 61914cb | 2017-12-01 19:59:00 | [diff] [blame] | 286 | ~StreamDelegateWithTrailers() override = default; |
xunjieli | 294da72 | 2015-08-11 19:15:02 | [diff] [blame] | 287 | |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 288 | void OnTrailers(const spdy::Http2HeaderBlock& trailers) override { |
bnc | 94893a7 | 2016-06-30 13:45:25 | [diff] [blame] | 289 | trailers_ = trailers.Clone(); |
xunjieli | 294da72 | 2015-08-11 19:15:02 | [diff] [blame] | 290 | } |
| 291 | |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 292 | const spdy::Http2HeaderBlock& trailers() const { return trailers_; } |
xunjieli | 294da72 | 2015-08-11 19:15:02 | [diff] [blame] | 293 | |
| 294 | private: |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 295 | spdy::Http2HeaderBlock trailers_; |
xunjieli | 294da72 | 2015-08-11 19:15:02 | [diff] [blame] | 296 | }; |
| 297 | |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 298 | // Regression test for https://crbug.com/481033. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 299 | TEST_F(SpdyStreamTest, Trailers) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 300 | spdy::SpdySerializedFrame req(spdy_util_.ConstructSpdyPost( |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 301 | kDefaultUrl, 1, kPostBodyLength, LOWEST, nullptr, 0)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 302 | AddWrite(req); |
xunjieli | 294da72 | 2015-08-11 19:15:02 | [diff] [blame] | 303 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 304 | spdy::SpdySerializedFrame msg( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 305 | spdy_util_.ConstructSpdyDataFrame(1, kPostBodyStringPiece, true)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 306 | AddWrite(msg); |
xunjieli | 294da72 | 2015-08-11 19:15:02 | [diff] [blame] | 307 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 308 | spdy::SpdySerializedFrame resp(spdy_util_.ConstructSpdyPostReply(nullptr, 0)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 309 | AddRead(resp); |
xunjieli | 294da72 | 2015-08-11 19:15:02 | [diff] [blame] | 310 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 311 | spdy::SpdySerializedFrame echo( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 312 | spdy_util_.ConstructSpdyDataFrame(1, kPostBodyStringPiece, false)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 313 | AddRead(echo); |
xunjieli | 294da72 | 2015-08-11 19:15:02 | [diff] [blame] | 314 | |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 315 | spdy::Http2HeaderBlock late_headers; |
bnc | 38dcd39 | 2016-02-09 23:19:49 | [diff] [blame] | 316 | late_headers["foo"] = "bar"; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 317 | spdy::SpdySerializedFrame trailers(spdy_util_.ConstructSpdyResponseHeaders( |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 318 | 1, std::move(late_headers), false)); |
| 319 | AddRead(trailers); |
xunjieli | 294da72 | 2015-08-11 19:15:02 | [diff] [blame] | 320 | |
| 321 | AddReadEOF(); |
| 322 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 323 | SequencedSocketData data(GetReads(), GetWrites()); |
xunjieli | 294da72 | 2015-08-11 19:15:02 | [diff] [blame] | 324 | MockConnect connect_data(SYNCHRONOUS, OK); |
| 325 | data.set_connect_data(connect_data); |
mmenke | e2401192 | 2015-12-17 22:12:59 | [diff] [blame] | 326 | session_deps_.socket_factory->AddSocketDataProvider(&data); |
xunjieli | 294da72 | 2015-08-11 19:15:02 | [diff] [blame] | 327 | |
bnc | 032658ba | 2016-09-26 18:17:15 | [diff] [blame] | 328 | AddSSLSocketData(); |
| 329 | |
xunjieli | 294da72 | 2015-08-11 19:15:02 | [diff] [blame] | 330 | base::WeakPtr<SpdySession> session(CreateDefaultSpdySession()); |
| 331 | |
| 332 | base::WeakPtr<SpdyStream> stream = CreateStreamSynchronously( |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 333 | SPDY_REQUEST_RESPONSE_STREAM, session, url_, LOWEST, NetLogWithSource()); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 334 | ASSERT_TRUE(stream); |
Bence Béky | 39d7429 | 2018-03-02 04:31:18 | [diff] [blame] | 335 | EXPECT_EQ(kDefaultUrl, stream->url().spec()); |
xunjieli | 294da72 | 2015-08-11 19:15:02 | [diff] [blame] | 336 | |
| 337 | StreamDelegateWithTrailers delegate(stream, kPostBodyStringPiece); |
| 338 | stream->SetDelegate(&delegate); |
| 339 | |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 340 | spdy::Http2HeaderBlock headers( |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 341 | spdy_util_.ConstructPostHeaderBlock(kDefaultUrl, kPostBodyLength)); |
| 342 | EXPECT_THAT(stream->SendRequestHeaders(std::move(headers), MORE_DATA_TO_SEND), |
| 343 | IsError(ERR_IO_PENDING)); |
xunjieli | 294da72 | 2015-08-11 19:15:02 | [diff] [blame] | 344 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 345 | EXPECT_THAT(delegate.WaitForClose(), IsError(ERR_CONNECTION_CLOSED)); |
xunjieli | 294da72 | 2015-08-11 19:15:02 | [diff] [blame] | 346 | |
| 347 | EXPECT_TRUE(delegate.send_headers_completed()); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 348 | EXPECT_EQ("200", delegate.GetResponseHeaderValue(spdy::kHttp2StatusHeader)); |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 349 | const spdy::Http2HeaderBlock& received_trailers = delegate.trailers(); |
| 350 | spdy::Http2HeaderBlock::const_iterator it = received_trailers.find("foo"); |
xunjieli | 294da72 | 2015-08-11 19:15:02 | [diff] [blame] | 351 | EXPECT_EQ("bar", it->second); |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 352 | EXPECT_EQ(std::string(kPostBody, kPostBodyLength), |
xunjieli | 294da72 | 2015-08-11 19:15:02 | [diff] [blame] | 353 | delegate.TakeReceivedData()); |
| 354 | EXPECT_TRUE(data.AllWriteDataConsumed()); |
| 355 | } |
| 356 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 357 | TEST_F(SpdyStreamTest, PushedStream) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 358 | spdy::SpdySerializedFrame req( |
| 359 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 360 | AddWrite(req); |
| 361 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 362 | spdy::SpdySerializedFrame reply( |
| 363 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 364 | AddRead(reply); |
| 365 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 366 | spdy::SpdySerializedFrame push( |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 367 | spdy_util_.ConstructSpdyPush(nullptr, 0, 2, 1, kPushUrl)); |
| 368 | AddRead(push); |
| 369 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 370 | spdy::SpdySerializedFrame priority( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 371 | spdy_util_.ConstructSpdyPriority(2, 1, IDLE, true)); |
| 372 | AddWrite(priority); |
| 373 | |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 374 | AddReadPause(); |
| 375 | |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 376 | base::StringPiece pushed_msg("foo"); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 377 | spdy::SpdySerializedFrame pushed_body( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 378 | spdy_util_.ConstructSpdyDataFrame(2, pushed_msg, true)); |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 379 | AddRead(pushed_body); |
| 380 | |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 381 | base::StringPiece msg("bar"); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 382 | spdy::SpdySerializedFrame body( |
| 383 | spdy_util_.ConstructSpdyDataFrame(1, msg, true)); |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 384 | AddRead(body); |
| 385 | |
[email protected] | 6d116e1a | 2013-06-24 07:42:15 | [diff] [blame] | 386 | AddReadEOF(); |
| 387 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 388 | SequencedSocketData data(GetReads(), GetWrites()); |
[email protected] | 0e861e9 | 2012-03-15 18:42:19 | [diff] [blame] | 389 | MockConnect connect_data(SYNCHRONOUS, OK); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 390 | data.set_connect_data(connect_data); |
mmenke | e2401192 | 2015-12-17 22:12:59 | [diff] [blame] | 391 | session_deps_.socket_factory->AddSocketDataProvider(&data); |
[email protected] | 0e861e9 | 2012-03-15 18:42:19 | [diff] [blame] | 392 | |
bnc | 032658ba | 2016-09-26 18:17:15 | [diff] [blame] | 393 | AddSSLSocketData(); |
| 394 | |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 395 | g_time_now = base::TimeTicks::Now(); |
| 396 | session_deps_.time_func = InstantaneousReads; |
| 397 | session_ = SpdySessionDependencies::SpdyCreateSession(&session_deps_); |
[email protected] | a7a265ef | 2010-12-08 18:05:57 | [diff] [blame] | 398 | |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 399 | base::WeakPtr<SpdySession> session(CreateDefaultSpdySession()); |
| 400 | |
| 401 | base::WeakPtr<SpdyStream> stream = CreateStreamSynchronously( |
| 402 | SPDY_REQUEST_RESPONSE_STREAM, session, url_, LOWEST, NetLogWithSource()); |
| 403 | ASSERT_TRUE(stream); |
Bence Béky | 39d7429 | 2018-03-02 04:31:18 | [diff] [blame] | 404 | EXPECT_EQ(kDefaultUrl, stream->url().spec()); |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 405 | |
| 406 | StreamDelegateDoNothing delegate(stream); |
| 407 | stream->SetDelegate(&delegate); |
caseq | e8340bc9 | 2016-04-20 00:02:57 | [diff] [blame] | 408 | |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 409 | spdy::Http2HeaderBlock headers( |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 410 | spdy_util_.ConstructGetHeaderBlock(kDefaultUrl)); |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 411 | EXPECT_THAT( |
| 412 | stream->SendRequestHeaders(std::move(headers), NO_MORE_DATA_TO_SEND), |
| 413 | IsError(ERR_IO_PENDING)); |
[email protected] | 6cd63ba | 2014-06-12 16:14:56 | [diff] [blame] | 414 | |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 415 | data.RunUntilPaused(); |
[email protected] | a7a265ef | 2010-12-08 18:05:57 | [diff] [blame] | 416 | |
Ben Schwartz | 3ff4dc1e6 | 2021-04-27 21:15:23 | [diff] [blame] | 417 | const SpdySessionKey key(HostPortPair::FromURL(url_), ProxyServer::Direct(), |
| 418 | PRIVACY_MODE_DISABLED, |
| 419 | SpdySessionKey::IsProxySession::kFalse, SocketTag(), |
| 420 | NetworkIsolationKey(), SecureDnsPolicy::kAllow); |
Bence Béky | 5b1e4ce7 | 2018-01-11 14:55:15 | [diff] [blame] | 421 | const GURL pushed_url(kPushUrl); |
| 422 | HttpRequestInfo push_request; |
| 423 | push_request.url = pushed_url; |
| 424 | push_request.method = "GET"; |
Bence Béky | 7bf9436 | 2018-01-10 13:19:36 | [diff] [blame] | 425 | base::WeakPtr<SpdySession> session_with_pushed_stream; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 426 | spdy::SpdyStreamId pushed_stream_id; |
Bence Béky | 7bf9436 | 2018-01-10 13:19:36 | [diff] [blame] | 427 | spdy_session_pool(session)->push_promise_index()->ClaimPushedStream( |
Bence Béky | 5b1e4ce7 | 2018-01-11 14:55:15 | [diff] [blame] | 428 | key, pushed_url, push_request, &session_with_pushed_stream, |
| 429 | &pushed_stream_id); |
Bence Béky | 7bf9436 | 2018-01-10 13:19:36 | [diff] [blame] | 430 | EXPECT_EQ(session.get(), session_with_pushed_stream.get()); |
| 431 | EXPECT_EQ(2u, pushed_stream_id); |
| 432 | |
bnc | 4e6e7748 | 2017-01-22 12:59:43 | [diff] [blame] | 433 | SpdyStream* push_stream; |
Bence Béky | 5b1e4ce7 | 2018-01-11 14:55:15 | [diff] [blame] | 434 | EXPECT_THAT(session->GetPushedStream(pushed_url, pushed_stream_id, IDLE, |
Bence Béky | c683465 | 2018-10-03 00:47:39 | [diff] [blame] | 435 | &push_stream), |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 436 | IsOk()); |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 437 | ASSERT_TRUE(push_stream); |
Bence Béky | 39d7429 | 2018-03-02 04:31:18 | [diff] [blame] | 438 | EXPECT_EQ(kPushUrl, push_stream->url().spec()); |
caseq | e8340bc9 | 2016-04-20 00:02:57 | [diff] [blame] | 439 | |
| 440 | LoadTimingInfo load_timing_info; |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 441 | EXPECT_TRUE(push_stream->GetLoadTimingInfo(&load_timing_info)); |
| 442 | EXPECT_EQ(g_time_now, load_timing_info.push_start); |
caseq | e8340bc9 | 2016-04-20 00:02:57 | [diff] [blame] | 443 | EXPECT_TRUE(load_timing_info.push_end.is_null()); |
| 444 | |
bnc | 4e6e7748 | 2017-01-22 12:59:43 | [diff] [blame] | 445 | StreamDelegateDoNothing push_delegate(push_stream->GetWeakPtr()); |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 446 | push_stream->SetDelegate(&push_delegate); |
[email protected] | 6d116e1a | 2013-06-24 07:42:15 | [diff] [blame] | 447 | |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 448 | data.Resume(); |
[email protected] | 6d116e1a | 2013-06-24 07:42:15 | [diff] [blame] | 449 | |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 450 | EXPECT_TRUE(push_stream->GetLoadTimingInfo(&load_timing_info)); |
| 451 | EXPECT_EQ(g_time_now, load_timing_info.push_start); |
| 452 | EXPECT_FALSE(load_timing_info.push_end.is_null()); |
| 453 | |
| 454 | EXPECT_THAT(delegate.WaitForClose(), IsOk()); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 455 | EXPECT_EQ("200", delegate.GetResponseHeaderValue(spdy::kHttp2StatusHeader)); |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 456 | EXPECT_EQ(msg, delegate.TakeReceivedData()); |
[email protected] | 6d116e1a | 2013-06-24 07:42:15 | [diff] [blame] | 457 | |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 458 | EXPECT_THAT(push_delegate.WaitForClose(), IsOk()); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 459 | EXPECT_EQ("200", delegate.GetResponseHeaderValue(spdy::kHttp2StatusHeader)); |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 460 | EXPECT_EQ(pushed_msg, push_delegate.TakeReceivedData()); |
Bence Béky | a60ed84 | 2018-04-26 23:45:44 | [diff] [blame] | 461 | |
| 462 | // Finish async network reads and writes. |
| 463 | base::RunLoop().RunUntilIdle(); |
| 464 | |
| 465 | EXPECT_TRUE(data.AllWriteDataConsumed()); |
| 466 | EXPECT_TRUE(data.AllReadDataConsumed()); |
[email protected] | a7a265ef | 2010-12-08 18:05:57 | [diff] [blame] | 467 | } |
| 468 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 469 | TEST_F(SpdyStreamTest, StreamError) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 470 | spdy::SpdySerializedFrame req(spdy_util_.ConstructSpdyPost( |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 471 | kDefaultUrl, 1, kPostBodyLength, LOWEST, nullptr, 0)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 472 | AddWrite(req); |
[email protected] | 3d58737 | 2013-06-01 04:31:45 | [diff] [blame] | 473 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 474 | spdy::SpdySerializedFrame resp( |
| 475 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 476 | AddRead(resp); |
[email protected] | 3d58737 | 2013-06-01 04:31:45 | [diff] [blame] | 477 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 478 | spdy::SpdySerializedFrame msg( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 479 | spdy_util_.ConstructSpdyDataFrame(1, kPostBodyStringPiece, false)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 480 | AddWrite(msg); |
[email protected] | 3d58737 | 2013-06-01 04:31:45 | [diff] [blame] | 481 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 482 | spdy::SpdySerializedFrame echo( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 483 | spdy_util_.ConstructSpdyDataFrame(1, kPostBodyStringPiece, false)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 484 | AddRead(echo); |
[email protected] | 3d58737 | 2013-06-01 04:31:45 | [diff] [blame] | 485 | |
| 486 | AddReadEOF(); |
[email protected] | d245c34 | 2012-02-23 20:49:15 | [diff] [blame] | 487 | |
Matt Reichhoff | 0049a0b7 | 2021-10-20 20:44:26 | [diff] [blame] | 488 | RecordingNetLogObserver net_log_observer; |
[email protected] | d245c34 | 2012-02-23 20:49:15 | [diff] [blame] | 489 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 490 | SequencedSocketData data(GetReads(), GetWrites()); |
[email protected] | d245c34 | 2012-02-23 20:49:15 | [diff] [blame] | 491 | MockConnect connect_data(SYNCHRONOUS, OK); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 492 | data.set_connect_data(connect_data); |
mmenke | e2401192 | 2015-12-17 22:12:59 | [diff] [blame] | 493 | session_deps_.socket_factory->AddSocketDataProvider(&data); |
[email protected] | d245c34 | 2012-02-23 20:49:15 | [diff] [blame] | 494 | |
bnc | 032658ba | 2016-09-26 18:17:15 | [diff] [blame] | 495 | AddSSLSocketData(); |
| 496 | |
[email protected] | 795cbf8 | 2013-07-22 09:37:27 | [diff] [blame] | 497 | base::WeakPtr<SpdySession> session(CreateDefaultSpdySession()); |
[email protected] | d245c34 | 2012-02-23 20:49:15 | [diff] [blame] | 498 | |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 499 | base::WeakPtr<SpdyStream> stream = CreateStreamSynchronously( |
Matt Reichhoff | 0049a0b7 | 2021-10-20 20:44:26 | [diff] [blame] | 500 | SPDY_BIDIRECTIONAL_STREAM, session, url_, LOWEST, |
| 501 | NetLogWithSource::Make(NetLogSourceType::NONE)); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 502 | ASSERT_TRUE(stream); |
Bence Béky | 39d7429 | 2018-03-02 04:31:18 | [diff] [blame] | 503 | EXPECT_EQ(kDefaultUrl, stream->url().spec()); |
[email protected] | d245c34 | 2012-02-23 20:49:15 | [diff] [blame] | 504 | |
[email protected] | 194cfcf | 2013-05-23 21:44:44 | [diff] [blame] | 505 | StreamDelegateSendImmediate delegate(stream, kPostBodyStringPiece); |
[email protected] | 34a4dea | 2013-03-13 00:42:30 | [diff] [blame] | 506 | stream->SetDelegate(&delegate); |
[email protected] | d245c34 | 2012-02-23 20:49:15 | [diff] [blame] | 507 | |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 508 | spdy::Http2HeaderBlock headers( |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 509 | spdy_util_.ConstructPostHeaderBlock(kDefaultUrl, kPostBodyLength)); |
| 510 | EXPECT_THAT(stream->SendRequestHeaders(std::move(headers), MORE_DATA_TO_SEND), |
| 511 | IsError(ERR_IO_PENDING)); |
[email protected] | d245c34 | 2012-02-23 20:49:15 | [diff] [blame] | 512 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 513 | EXPECT_THAT(delegate.WaitForClose(), IsError(ERR_CONNECTION_CLOSED)); |
[email protected] | 218f4b6 | 2012-07-20 20:12:41 | [diff] [blame] | 514 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 515 | const spdy::SpdyStreamId stream_id = delegate.stream_id(); |
[email protected] | c92f4b454 | 2012-07-26 23:53:21 | [diff] [blame] | 516 | |
[email protected] | 34a4dea | 2013-03-13 00:42:30 | [diff] [blame] | 517 | EXPECT_TRUE(delegate.send_headers_completed()); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 518 | EXPECT_EQ("200", delegate.GetResponseHeaderValue(spdy::kHttp2StatusHeader)); |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 519 | EXPECT_EQ(std::string(kPostBody, kPostBodyLength), |
[email protected] | 09a8d917 | 2013-04-17 19:23:49 | [diff] [blame] | 520 | delegate.TakeReceivedData()); |
rch | 37de576c | 2015-05-17 20:28:17 | [diff] [blame] | 521 | EXPECT_TRUE(data.AllWriteDataConsumed()); |
[email protected] | d245c34 | 2012-02-23 20:49:15 | [diff] [blame] | 522 | |
| 523 | // Check that the NetLog was filled reasonably. |
Matt Reichhoff | 0049a0b7 | 2021-10-20 20:44:26 | [diff] [blame] | 524 | auto entries = net_log_observer.GetEntries(); |
[email protected] | d245c34 | 2012-02-23 20:49:15 | [diff] [blame] | 525 | EXPECT_LT(0u, entries.size()); |
| 526 | |
| 527 | // Check that we logged SPDY_STREAM_ERROR correctly. |
ttuttle | 859dc7a | 2015-04-23 19:42:29 | [diff] [blame] | 528 | int pos = ExpectLogContainsSomewhere( |
mikecirone | 8b85c43 | 2016-09-08 19:11:00 | [diff] [blame] | 529 | entries, 0, NetLogEventType::HTTP2_STREAM_ERROR, NetLogEventPhase::NONE); |
[email protected] | d245c34 | 2012-02-23 20:49:15 | [diff] [blame] | 530 | |
Eric Roman | 79cc755 | 2019-07-19 02:17:54 | [diff] [blame] | 531 | EXPECT_EQ(static_cast<int>(stream_id), |
| 532 | GetIntegerValueFromParams(entries[pos], "stream_id")); |
[email protected] | d245c34 | 2012-02-23 20:49:15 | [diff] [blame] | 533 | } |
[email protected] | a7a265ef | 2010-12-08 18:05:57 | [diff] [blame] | 534 | |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 535 | // Make sure that large blocks of data are properly split up into frame-sized |
| 536 | // chunks for a request/response (i.e., an HTTP-like) stream. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 537 | TEST_F(SpdyStreamTest, SendLargeDataAfterOpenRequestResponse) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 538 | spdy::SpdySerializedFrame req(spdy_util_.ConstructSpdyPost( |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 539 | kDefaultUrl, 1, kPostBodyLength, LOWEST, nullptr, 0)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 540 | AddWrite(req); |
[email protected] | 3d58737 | 2013-06-01 04:31:45 | [diff] [blame] | 541 | |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 542 | std::string chunk_data(kMaxSpdyFrameChunkSize, 'x'); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 543 | spdy::SpdySerializedFrame chunk( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 544 | spdy_util_.ConstructSpdyDataFrame(1, chunk_data, false)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 545 | AddWrite(chunk); |
| 546 | AddWrite(chunk); |
[email protected] | 3d58737 | 2013-06-01 04:31:45 | [diff] [blame] | 547 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 548 | spdy::SpdySerializedFrame last_chunk( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 549 | spdy_util_.ConstructSpdyDataFrame(1, chunk_data, true)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 550 | AddWrite(last_chunk); |
[email protected] | aa19cfc | 2013-05-23 16:41:38 | [diff] [blame] | 551 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 552 | spdy::SpdySerializedFrame resp(spdy_util_.ConstructSpdyPostReply(nullptr, 0)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 553 | AddRead(resp); |
[email protected] | aa19cfc | 2013-05-23 16:41:38 | [diff] [blame] | 554 | |
[email protected] | 3d58737 | 2013-06-01 04:31:45 | [diff] [blame] | 555 | AddReadEOF(); |
| 556 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 557 | SequencedSocketData data(GetReads(), GetWrites()); |
[email protected] | aa19cfc | 2013-05-23 16:41:38 | [diff] [blame] | 558 | MockConnect connect_data(SYNCHRONOUS, OK); |
| 559 | data.set_connect_data(connect_data); |
mmenke | e2401192 | 2015-12-17 22:12:59 | [diff] [blame] | 560 | session_deps_.socket_factory->AddSocketDataProvider(&data); |
[email protected] | aa19cfc | 2013-05-23 16:41:38 | [diff] [blame] | 561 | |
bnc | 032658ba | 2016-09-26 18:17:15 | [diff] [blame] | 562 | AddSSLSocketData(); |
| 563 | |
[email protected] | 795cbf8 | 2013-07-22 09:37:27 | [diff] [blame] | 564 | base::WeakPtr<SpdySession> session(CreateDefaultSpdySession()); |
[email protected] | aa19cfc | 2013-05-23 16:41:38 | [diff] [blame] | 565 | |
tfarina | 4283411 | 2016-09-22 13:38:20 | [diff] [blame] | 566 | base::WeakPtr<SpdyStream> stream = CreateStreamSynchronously( |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 567 | SPDY_REQUEST_RESPONSE_STREAM, session, url_, LOWEST, NetLogWithSource()); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 568 | ASSERT_TRUE(stream); |
Bence Béky | 39d7429 | 2018-03-02 04:31:18 | [diff] [blame] | 569 | EXPECT_EQ(kDefaultUrl, stream->url().spec()); |
[email protected] | aa19cfc | 2013-05-23 16:41:38 | [diff] [blame] | 570 | |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 571 | std::string body_data(3 * kMaxSpdyFrameChunkSize, 'x'); |
[email protected] | aa19cfc | 2013-05-23 16:41:38 | [diff] [blame] | 572 | StreamDelegateWithBody delegate(stream, body_data); |
| 573 | stream->SetDelegate(&delegate); |
| 574 | |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 575 | spdy::Http2HeaderBlock headers( |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 576 | spdy_util_.ConstructPostHeaderBlock(kDefaultUrl, kPostBodyLength)); |
| 577 | EXPECT_THAT(stream->SendRequestHeaders(std::move(headers), MORE_DATA_TO_SEND), |
| 578 | IsError(ERR_IO_PENDING)); |
[email protected] | aa19cfc | 2013-05-23 16:41:38 | [diff] [blame] | 579 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 580 | EXPECT_THAT(delegate.WaitForClose(), IsError(ERR_CONNECTION_CLOSED)); |
[email protected] | aa19cfc | 2013-05-23 16:41:38 | [diff] [blame] | 581 | |
| 582 | EXPECT_TRUE(delegate.send_headers_completed()); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 583 | EXPECT_EQ("200", delegate.GetResponseHeaderValue(spdy::kHttp2StatusHeader)); |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 584 | EXPECT_EQ(std::string(), delegate.TakeReceivedData()); |
rch | 37de576c | 2015-05-17 20:28:17 | [diff] [blame] | 585 | EXPECT_TRUE(data.AllWriteDataConsumed()); |
[email protected] | aa19cfc | 2013-05-23 16:41:38 | [diff] [blame] | 586 | } |
| 587 | |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 588 | // Make sure that large blocks of data are properly split up into frame-sized |
| 589 | // chunks for a bidirectional (i.e., non-HTTP-like) stream. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 590 | TEST_F(SpdyStreamTest, SendLargeDataAfterOpenBidirectional) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 591 | spdy::SpdySerializedFrame req(spdy_util_.ConstructSpdyPost( |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 592 | kDefaultUrl, 1, kPostBodyLength, LOWEST, nullptr, 0)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 593 | AddWrite(req); |
[email protected] | 3d58737 | 2013-06-01 04:31:45 | [diff] [blame] | 594 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 595 | spdy::SpdySerializedFrame resp(spdy_util_.ConstructSpdyPostReply(nullptr, 0)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 596 | AddRead(resp); |
[email protected] | 3d58737 | 2013-06-01 04:31:45 | [diff] [blame] | 597 | |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 598 | std::string chunk_data(kMaxSpdyFrameChunkSize, 'x'); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 599 | spdy::SpdySerializedFrame chunk( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 600 | spdy_util_.ConstructSpdyDataFrame(1, chunk_data, false)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 601 | AddWrite(chunk); |
| 602 | AddWrite(chunk); |
| 603 | AddWrite(chunk); |
[email protected] | aa19cfc | 2013-05-23 16:41:38 | [diff] [blame] | 604 | |
[email protected] | 3d58737 | 2013-06-01 04:31:45 | [diff] [blame] | 605 | AddReadEOF(); |
[email protected] | aa19cfc | 2013-05-23 16:41:38 | [diff] [blame] | 606 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 607 | SequencedSocketData data(GetReads(), GetWrites()); |
[email protected] | aa19cfc | 2013-05-23 16:41:38 | [diff] [blame] | 608 | MockConnect connect_data(SYNCHRONOUS, OK); |
| 609 | data.set_connect_data(connect_data); |
mmenke | e2401192 | 2015-12-17 22:12:59 | [diff] [blame] | 610 | session_deps_.socket_factory->AddSocketDataProvider(&data); |
[email protected] | aa19cfc | 2013-05-23 16:41:38 | [diff] [blame] | 611 | |
bnc | 032658ba | 2016-09-26 18:17:15 | [diff] [blame] | 612 | AddSSLSocketData(); |
| 613 | |
[email protected] | 795cbf8 | 2013-07-22 09:37:27 | [diff] [blame] | 614 | base::WeakPtr<SpdySession> session(CreateDefaultSpdySession()); |
[email protected] | aa19cfc | 2013-05-23 16:41:38 | [diff] [blame] | 615 | |
tfarina | 4283411 | 2016-09-22 13:38:20 | [diff] [blame] | 616 | base::WeakPtr<SpdyStream> stream = CreateStreamSynchronously( |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 617 | SPDY_BIDIRECTIONAL_STREAM, session, url_, LOWEST, NetLogWithSource()); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 618 | ASSERT_TRUE(stream); |
Bence Béky | 39d7429 | 2018-03-02 04:31:18 | [diff] [blame] | 619 | EXPECT_EQ(kDefaultUrl, stream->url().spec()); |
[email protected] | aa19cfc | 2013-05-23 16:41:38 | [diff] [blame] | 620 | |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 621 | std::string body_data(3 * kMaxSpdyFrameChunkSize, 'x'); |
[email protected] | 194cfcf | 2013-05-23 21:44:44 | [diff] [blame] | 622 | StreamDelegateSendImmediate delegate(stream, body_data); |
[email protected] | aa19cfc | 2013-05-23 16:41:38 | [diff] [blame] | 623 | stream->SetDelegate(&delegate); |
| 624 | |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 625 | spdy::Http2HeaderBlock headers( |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 626 | spdy_util_.ConstructPostHeaderBlock(kDefaultUrl, kPostBodyLength)); |
| 627 | EXPECT_THAT(stream->SendRequestHeaders(std::move(headers), MORE_DATA_TO_SEND), |
| 628 | IsError(ERR_IO_PENDING)); |
[email protected] | aa19cfc | 2013-05-23 16:41:38 | [diff] [blame] | 629 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 630 | EXPECT_THAT(delegate.WaitForClose(), IsError(ERR_CONNECTION_CLOSED)); |
[email protected] | aa19cfc | 2013-05-23 16:41:38 | [diff] [blame] | 631 | |
| 632 | EXPECT_TRUE(delegate.send_headers_completed()); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 633 | EXPECT_EQ("200", delegate.GetResponseHeaderValue(spdy::kHttp2StatusHeader)); |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 634 | EXPECT_EQ(std::string(), delegate.TakeReceivedData()); |
rch | 37de576c | 2015-05-17 20:28:17 | [diff] [blame] | 635 | EXPECT_TRUE(data.AllWriteDataConsumed()); |
[email protected] | aa19cfc | 2013-05-23 16:41:38 | [diff] [blame] | 636 | } |
| 637 | |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 638 | // Receiving a header with uppercase ASCII should result in a protocol error. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 639 | TEST_F(SpdyStreamTest, UpperCaseHeaders) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 640 | spdy::SpdySerializedFrame req( |
| 641 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 642 | AddWrite(req); |
[email protected] | 6d116e1a | 2013-06-24 07:42:15 | [diff] [blame] | 643 | |
| 644 | const char* const kExtraHeaders[] = {"X-UpperCase", "yes"}; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 645 | spdy::SpdySerializedFrame reply(spdy_util_.ConstructSpdyGetReply( |
Daniel Cheng | 5feb16f | 2022-02-28 06:52:07 | [diff] [blame] | 646 | kExtraHeaders, std::size(kExtraHeaders) / 2, 1)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 647 | AddRead(reply); |
[email protected] | 6d116e1a | 2013-06-24 07:42:15 | [diff] [blame] | 648 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 649 | spdy::SpdySerializedFrame rst( |
| 650 | spdy_util_.ConstructSpdyRstStream(1, spdy::ERROR_CODE_PROTOCOL_ERROR)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 651 | AddWrite(rst); |
[email protected] | 6d116e1a | 2013-06-24 07:42:15 | [diff] [blame] | 652 | |
| 653 | AddReadEOF(); |
| 654 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 655 | SequencedSocketData data(GetReads(), GetWrites()); |
[email protected] | 6d116e1a | 2013-06-24 07:42:15 | [diff] [blame] | 656 | MockConnect connect_data(SYNCHRONOUS, OK); |
| 657 | data.set_connect_data(connect_data); |
mmenke | e2401192 | 2015-12-17 22:12:59 | [diff] [blame] | 658 | session_deps_.socket_factory->AddSocketDataProvider(&data); |
[email protected] | 6d116e1a | 2013-06-24 07:42:15 | [diff] [blame] | 659 | |
bnc | 032658ba | 2016-09-26 18:17:15 | [diff] [blame] | 660 | AddSSLSocketData(); |
| 661 | |
[email protected] | 795cbf8 | 2013-07-22 09:37:27 | [diff] [blame] | 662 | base::WeakPtr<SpdySession> session(CreateDefaultSpdySession()); |
[email protected] | 6d116e1a | 2013-06-24 07:42:15 | [diff] [blame] | 663 | |
tfarina | 4283411 | 2016-09-22 13:38:20 | [diff] [blame] | 664 | base::WeakPtr<SpdyStream> stream = CreateStreamSynchronously( |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 665 | SPDY_REQUEST_RESPONSE_STREAM, session, url_, LOWEST, NetLogWithSource()); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 666 | ASSERT_TRUE(stream); |
Bence Béky | 39d7429 | 2018-03-02 04:31:18 | [diff] [blame] | 667 | EXPECT_EQ(kDefaultUrl, stream->url().spec()); |
[email protected] | 6d116e1a | 2013-06-24 07:42:15 | [diff] [blame] | 668 | |
| 669 | StreamDelegateDoNothing delegate(stream); |
| 670 | stream->SetDelegate(&delegate); |
| 671 | |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 672 | spdy::Http2HeaderBlock headers( |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 673 | spdy_util_.ConstructGetHeaderBlock(kDefaultUrl)); |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 674 | EXPECT_THAT( |
| 675 | stream->SendRequestHeaders(std::move(headers), NO_MORE_DATA_TO_SEND), |
| 676 | IsError(ERR_IO_PENDING)); |
[email protected] | 6d116e1a | 2013-06-24 07:42:15 | [diff] [blame] | 677 | |
Bence Béky | d0d6950 | 2019-06-25 19:47:18 | [diff] [blame] | 678 | EXPECT_THAT(delegate.WaitForClose(), IsError(ERR_HTTP2_PROTOCOL_ERROR)); |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 679 | |
bnc | eb9aa711 | 2017-01-05 01:03:46 | [diff] [blame] | 680 | // Finish async network reads and writes. |
| 681 | base::RunLoop().RunUntilIdle(); |
| 682 | |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 683 | EXPECT_TRUE(data.AllWriteDataConsumed()); |
| 684 | EXPECT_TRUE(data.AllReadDataConsumed()); |
[email protected] | 6d116e1a | 2013-06-24 07:42:15 | [diff] [blame] | 685 | } |
| 686 | |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 687 | // Receiving a header with uppercase ASCII should result in a protocol error |
| 688 | // even for a push stream. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 689 | TEST_F(SpdyStreamTest, UpperCaseHeadersOnPush) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 690 | spdy::SpdySerializedFrame req( |
| 691 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 692 | AddWrite(req); |
[email protected] | 6d116e1a | 2013-06-24 07:42:15 | [diff] [blame] | 693 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 694 | spdy::SpdySerializedFrame reply( |
| 695 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 696 | AddRead(reply); |
[email protected] | 6d116e1a | 2013-06-24 07:42:15 | [diff] [blame] | 697 | |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 698 | const char* const kExtraHeaders[] = {"X-UpperCase", "yes"}; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 699 | spdy::SpdySerializedFrame push(spdy_util_.ConstructSpdyPush( |
Daniel Cheng | 5feb16f | 2022-02-28 06:52:07 | [diff] [blame] | 700 | kExtraHeaders, std::size(kExtraHeaders) / 2, 2, 1, kPushUrl)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 701 | AddRead(push); |
[email protected] | 6d116e1a | 2013-06-24 07:42:15 | [diff] [blame] | 702 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 703 | spdy::SpdySerializedFrame priority( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 704 | spdy_util_.ConstructSpdyPriority(2, 1, IDLE, true)); |
| 705 | AddWrite(priority); |
| 706 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 707 | spdy::SpdySerializedFrame rst( |
| 708 | spdy_util_.ConstructSpdyRstStream(2, spdy::ERROR_CODE_PROTOCOL_ERROR)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 709 | AddWrite(rst); |
[email protected] | 6d116e1a | 2013-06-24 07:42:15 | [diff] [blame] | 710 | |
mmenke | e2401192 | 2015-12-17 22:12:59 | [diff] [blame] | 711 | AddReadPause(); |
| 712 | |
[email protected] | 6d116e1a | 2013-06-24 07:42:15 | [diff] [blame] | 713 | AddReadEOF(); |
| 714 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 715 | SequencedSocketData data(GetReads(), GetWrites()); |
[email protected] | 6d116e1a | 2013-06-24 07:42:15 | [diff] [blame] | 716 | MockConnect connect_data(SYNCHRONOUS, OK); |
| 717 | data.set_connect_data(connect_data); |
mmenke | e2401192 | 2015-12-17 22:12:59 | [diff] [blame] | 718 | session_deps_.socket_factory->AddSocketDataProvider(&data); |
[email protected] | 6d116e1a | 2013-06-24 07:42:15 | [diff] [blame] | 719 | |
bnc | 032658ba | 2016-09-26 18:17:15 | [diff] [blame] | 720 | AddSSLSocketData(); |
| 721 | |
[email protected] | 795cbf8 | 2013-07-22 09:37:27 | [diff] [blame] | 722 | base::WeakPtr<SpdySession> session(CreateDefaultSpdySession()); |
[email protected] | 6d116e1a | 2013-06-24 07:42:15 | [diff] [blame] | 723 | |
tfarina | 4283411 | 2016-09-22 13:38:20 | [diff] [blame] | 724 | base::WeakPtr<SpdyStream> stream = CreateStreamSynchronously( |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 725 | SPDY_REQUEST_RESPONSE_STREAM, session, url_, LOWEST, NetLogWithSource()); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 726 | ASSERT_TRUE(stream); |
Bence Béky | 39d7429 | 2018-03-02 04:31:18 | [diff] [blame] | 727 | EXPECT_EQ(kDefaultUrl, stream->url().spec()); |
[email protected] | 6d116e1a | 2013-06-24 07:42:15 | [diff] [blame] | 728 | |
| 729 | StreamDelegateDoNothing delegate(stream); |
| 730 | stream->SetDelegate(&delegate); |
| 731 | |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 732 | spdy::Http2HeaderBlock headers( |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 733 | spdy_util_.ConstructGetHeaderBlock(kDefaultUrl)); |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 734 | EXPECT_THAT( |
| 735 | stream->SendRequestHeaders(std::move(headers), NO_MORE_DATA_TO_SEND), |
| 736 | IsError(ERR_IO_PENDING)); |
[email protected] | 6d116e1a | 2013-06-24 07:42:15 | [diff] [blame] | 737 | |
mmenke | e2401192 | 2015-12-17 22:12:59 | [diff] [blame] | 738 | data.RunUntilPaused(); |
[email protected] | 6d116e1a | 2013-06-24 07:42:15 | [diff] [blame] | 739 | |
Bence Béky | 7bf9436 | 2018-01-10 13:19:36 | [diff] [blame] | 740 | EXPECT_EQ(0u, num_pushed_streams(session)); |
[email protected] | 6d116e1a | 2013-06-24 07:42:15 | [diff] [blame] | 741 | |
mmenke | e2401192 | 2015-12-17 22:12:59 | [diff] [blame] | 742 | data.Resume(); |
[email protected] | 6d116e1a | 2013-06-24 07:42:15 | [diff] [blame] | 743 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 744 | EXPECT_THAT(delegate.WaitForClose(), IsError(ERR_CONNECTION_CLOSED)); |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 745 | |
| 746 | EXPECT_TRUE(data.AllWriteDataConsumed()); |
| 747 | EXPECT_TRUE(data.AllReadDataConsumed()); |
[email protected] | 6d116e1a | 2013-06-24 07:42:15 | [diff] [blame] | 748 | } |
| 749 | |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 750 | TEST_F(SpdyStreamTest, HeadersMustHaveStatus) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 751 | spdy::SpdySerializedFrame req( |
| 752 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 753 | AddWrite(req); |
| 754 | |
| 755 | // Response headers without ":status" header field: protocol error. |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 756 | spdy::Http2HeaderBlock header_block_without_status; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 757 | header_block_without_status[spdy::kHttp2MethodHeader] = "GET"; |
| 758 | header_block_without_status[spdy::kHttp2AuthorityHeader] = "www.example.org"; |
| 759 | header_block_without_status[spdy::kHttp2SchemeHeader] = "https"; |
| 760 | header_block_without_status[spdy::kHttp2PathHeader] = "/"; |
| 761 | spdy::SpdySerializedFrame reply( |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 762 | spdy_util_.ConstructSpdyReply(1, std::move(header_block_without_status))); |
| 763 | AddRead(reply); |
| 764 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 765 | spdy::SpdySerializedFrame rst( |
| 766 | spdy_util_.ConstructSpdyRstStream(1, spdy::ERROR_CODE_PROTOCOL_ERROR)); |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 767 | AddWrite(rst); |
| 768 | |
| 769 | AddReadEOF(); |
| 770 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 771 | SequencedSocketData data(GetReads(), GetWrites()); |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 772 | MockConnect connect_data(SYNCHRONOUS, OK); |
| 773 | data.set_connect_data(connect_data); |
| 774 | session_deps_.socket_factory->AddSocketDataProvider(&data); |
| 775 | |
| 776 | AddSSLSocketData(); |
| 777 | |
| 778 | base::WeakPtr<SpdySession> session(CreateDefaultSpdySession()); |
| 779 | |
| 780 | base::WeakPtr<SpdyStream> stream = CreateStreamSynchronously( |
| 781 | SPDY_REQUEST_RESPONSE_STREAM, session, url_, LOWEST, NetLogWithSource()); |
| 782 | ASSERT_TRUE(stream); |
Bence Béky | 39d7429 | 2018-03-02 04:31:18 | [diff] [blame] | 783 | EXPECT_EQ(kDefaultUrl, stream->url().spec()); |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 784 | |
| 785 | StreamDelegateDoNothing delegate(stream); |
| 786 | stream->SetDelegate(&delegate); |
| 787 | |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 788 | spdy::Http2HeaderBlock headers( |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 789 | spdy_util_.ConstructGetHeaderBlock(kDefaultUrl)); |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 790 | EXPECT_EQ(ERR_IO_PENDING, stream->SendRequestHeaders(std::move(headers), |
| 791 | NO_MORE_DATA_TO_SEND)); |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 792 | |
Bence Béky | d0d6950 | 2019-06-25 19:47:18 | [diff] [blame] | 793 | EXPECT_THAT(delegate.WaitForClose(), IsError(ERR_HTTP2_PROTOCOL_ERROR)); |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 794 | |
bnc | eb9aa711 | 2017-01-05 01:03:46 | [diff] [blame] | 795 | // Finish async network reads and writes. |
| 796 | base::RunLoop().RunUntilIdle(); |
| 797 | |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 798 | EXPECT_TRUE(data.AllWriteDataConsumed()); |
| 799 | EXPECT_TRUE(data.AllReadDataConsumed()); |
| 800 | } |
| 801 | |
| 802 | TEST_F(SpdyStreamTest, HeadersMustHaveStatusOnPushedStream) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 803 | spdy::SpdySerializedFrame req( |
| 804 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 805 | AddWrite(req); |
[email protected] | 6d116e1a | 2013-06-24 07:42:15 | [diff] [blame] | 806 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 807 | spdy::SpdySerializedFrame reply( |
| 808 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 809 | AddRead(reply); |
[email protected] | 6d116e1a | 2013-06-24 07:42:15 | [diff] [blame] | 810 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 811 | spdy::SpdySerializedFrame push_promise(spdy_util_.ConstructSpdyPushPromise( |
Bence Béky | f1d7852 | 2018-01-11 01:16:50 | [diff] [blame] | 812 | 1, 2, spdy_util_.ConstructGetHeaderBlock(kPushUrl))); |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 813 | AddRead(push_promise); |
[email protected] | 6d116e1a | 2013-06-24 07:42:15 | [diff] [blame] | 814 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 815 | spdy::SpdySerializedFrame priority( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 816 | spdy_util_.ConstructSpdyPriority(2, 1, IDLE, true)); |
| 817 | AddWrite(priority); |
| 818 | |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 819 | // Response headers without ":status" header field: protocol error. |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 820 | spdy::Http2HeaderBlock header_block_without_status; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 821 | header_block_without_status[spdy::kHttp2MethodHeader] = "GET"; |
| 822 | header_block_without_status[spdy::kHttp2AuthorityHeader] = "www.example.org"; |
| 823 | header_block_without_status[spdy::kHttp2SchemeHeader] = "https"; |
| 824 | header_block_without_status[spdy::kHttp2PathHeader] = "/"; |
| 825 | spdy::SpdySerializedFrame pushed_reply( |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 826 | spdy_util_.ConstructSpdyReply(2, std::move(header_block_without_status))); |
| 827 | AddRead(pushed_reply); |
mmenke | e2401192 | 2015-12-17 22:12:59 | [diff] [blame] | 828 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 829 | spdy::SpdySerializedFrame rst( |
| 830 | spdy_util_.ConstructSpdyRstStream(2, spdy::ERROR_CODE_PROTOCOL_ERROR)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 831 | AddWrite(rst); |
[email protected] | 6d116e1a | 2013-06-24 07:42:15 | [diff] [blame] | 832 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 833 | spdy::SpdySerializedFrame body( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 834 | spdy_util_.ConstructSpdyDataFrame(1, kPostBodyStringPiece, true)); |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 835 | AddRead(body); |
| 836 | |
[email protected] | 6d116e1a | 2013-06-24 07:42:15 | [diff] [blame] | 837 | AddReadEOF(); |
| 838 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 839 | SequencedSocketData data(GetReads(), GetWrites()); |
[email protected] | 6d116e1a | 2013-06-24 07:42:15 | [diff] [blame] | 840 | MockConnect connect_data(SYNCHRONOUS, OK); |
| 841 | data.set_connect_data(connect_data); |
mmenke | e2401192 | 2015-12-17 22:12:59 | [diff] [blame] | 842 | session_deps_.socket_factory->AddSocketDataProvider(&data); |
[email protected] | 6d116e1a | 2013-06-24 07:42:15 | [diff] [blame] | 843 | |
bnc | 032658ba | 2016-09-26 18:17:15 | [diff] [blame] | 844 | AddSSLSocketData(); |
| 845 | |
[email protected] | 795cbf8 | 2013-07-22 09:37:27 | [diff] [blame] | 846 | base::WeakPtr<SpdySession> session(CreateDefaultSpdySession()); |
[email protected] | 6d116e1a | 2013-06-24 07:42:15 | [diff] [blame] | 847 | |
tfarina | 4283411 | 2016-09-22 13:38:20 | [diff] [blame] | 848 | base::WeakPtr<SpdyStream> stream = CreateStreamSynchronously( |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 849 | SPDY_REQUEST_RESPONSE_STREAM, session, url_, LOWEST, NetLogWithSource()); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 850 | ASSERT_TRUE(stream); |
Bence Béky | 39d7429 | 2018-03-02 04:31:18 | [diff] [blame] | 851 | EXPECT_EQ(kDefaultUrl, stream->url().spec()); |
[email protected] | 6d116e1a | 2013-06-24 07:42:15 | [diff] [blame] | 852 | |
| 853 | StreamDelegateDoNothing delegate(stream); |
| 854 | stream->SetDelegate(&delegate); |
| 855 | |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 856 | spdy::Http2HeaderBlock headers( |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 857 | spdy_util_.ConstructGetHeaderBlock(kDefaultUrl)); |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 858 | EXPECT_THAT( |
| 859 | stream->SendRequestHeaders(std::move(headers), NO_MORE_DATA_TO_SEND), |
| 860 | IsError(ERR_IO_PENDING)); |
[email protected] | 6d116e1a | 2013-06-24 07:42:15 | [diff] [blame] | 861 | |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 862 | EXPECT_THAT(delegate.WaitForClose(), IsOk()); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 863 | EXPECT_EQ("200", delegate.GetResponseHeaderValue(spdy::kHttp2StatusHeader)); |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 864 | EXPECT_EQ(std::string(kPostBody, kPostBodyLength), |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 865 | delegate.TakeReceivedData()); |
[email protected] | 6d116e1a | 2013-06-24 07:42:15 | [diff] [blame] | 866 | |
bnc | eb9aa711 | 2017-01-05 01:03:46 | [diff] [blame] | 867 | // Finish async network reads and writes. |
| 868 | base::RunLoop().RunUntilIdle(); |
| 869 | |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 870 | EXPECT_TRUE(data.AllWriteDataConsumed()); |
| 871 | EXPECT_TRUE(data.AllReadDataConsumed()); |
[email protected] | 6d116e1a | 2013-06-24 07:42:15 | [diff] [blame] | 872 | } |
| 873 | |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 874 | TEST_F(SpdyStreamTest, HeadersMustPreceedData) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 875 | spdy::SpdySerializedFrame req( |
| 876 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 877 | AddWrite(req); |
| 878 | |
| 879 | // Response body not preceeded by headers: protocol error. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 880 | spdy::SpdySerializedFrame body( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 881 | spdy_util_.ConstructSpdyDataFrame(1, kPostBodyStringPiece, true)); |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 882 | AddRead(body); |
| 883 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 884 | spdy::SpdySerializedFrame rst( |
| 885 | spdy_util_.ConstructSpdyRstStream(1, spdy::ERROR_CODE_PROTOCOL_ERROR)); |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 886 | AddWrite(rst); |
| 887 | |
| 888 | AddReadEOF(); |
| 889 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 890 | SequencedSocketData data(GetReads(), GetWrites()); |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 891 | MockConnect connect_data(SYNCHRONOUS, OK); |
| 892 | data.set_connect_data(connect_data); |
| 893 | session_deps_.socket_factory->AddSocketDataProvider(&data); |
| 894 | |
| 895 | AddSSLSocketData(); |
| 896 | |
| 897 | base::WeakPtr<SpdySession> session(CreateDefaultSpdySession()); |
| 898 | |
| 899 | base::WeakPtr<SpdyStream> stream = CreateStreamSynchronously( |
| 900 | SPDY_REQUEST_RESPONSE_STREAM, session, url_, LOWEST, NetLogWithSource()); |
| 901 | ASSERT_TRUE(stream); |
Bence Béky | 39d7429 | 2018-03-02 04:31:18 | [diff] [blame] | 902 | EXPECT_EQ(kDefaultUrl, stream->url().spec()); |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 903 | |
| 904 | StreamDelegateDoNothing delegate(stream); |
| 905 | stream->SetDelegate(&delegate); |
| 906 | |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 907 | spdy::Http2HeaderBlock headers( |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 908 | spdy_util_.ConstructGetHeaderBlock(kDefaultUrl)); |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 909 | EXPECT_EQ(ERR_IO_PENDING, stream->SendRequestHeaders(std::move(headers), |
| 910 | NO_MORE_DATA_TO_SEND)); |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 911 | |
Bence Béky | d0d6950 | 2019-06-25 19:47:18 | [diff] [blame] | 912 | EXPECT_THAT(delegate.WaitForClose(), IsError(ERR_HTTP2_PROTOCOL_ERROR)); |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 913 | } |
| 914 | |
| 915 | TEST_F(SpdyStreamTest, HeadersMustPreceedDataOnPushedStream) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 916 | spdy::SpdySerializedFrame req( |
| 917 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 918 | AddWrite(req); |
[email protected] | 6d116e1a | 2013-06-24 07:42:15 | [diff] [blame] | 919 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 920 | spdy::SpdySerializedFrame reply( |
| 921 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 922 | AddRead(reply); |
[email protected] | 6d116e1a | 2013-06-24 07:42:15 | [diff] [blame] | 923 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 924 | spdy::SpdySerializedFrame push_promise(spdy_util_.ConstructSpdyPushPromise( |
Bence Béky | f1d7852 | 2018-01-11 01:16:50 | [diff] [blame] | 925 | 1, 2, spdy_util_.ConstructGetHeaderBlock(kPushUrl))); |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 926 | AddRead(push_promise); |
[email protected] | 6d116e1a | 2013-06-24 07:42:15 | [diff] [blame] | 927 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 928 | spdy::SpdySerializedFrame priority( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 929 | spdy_util_.ConstructSpdyPriority(2, 1, IDLE, true)); |
| 930 | AddWrite(priority); |
| 931 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 932 | spdy::SpdySerializedFrame pushed_body( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 933 | spdy_util_.ConstructSpdyDataFrame(2, kPostBodyStringPiece, true)); |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 934 | AddRead(pushed_body); |
mmenke | e2401192 | 2015-12-17 22:12:59 | [diff] [blame] | 935 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 936 | spdy::SpdySerializedFrame rst( |
| 937 | spdy_util_.ConstructSpdyRstStream(2, spdy::ERROR_CODE_PROTOCOL_ERROR)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 938 | AddWrite(rst); |
[email protected] | 6d116e1a | 2013-06-24 07:42:15 | [diff] [blame] | 939 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 940 | spdy::SpdySerializedFrame body( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 941 | spdy_util_.ConstructSpdyDataFrame(1, kPostBodyStringPiece, true)); |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 942 | AddRead(body); |
| 943 | |
[email protected] | 6d116e1a | 2013-06-24 07:42:15 | [diff] [blame] | 944 | AddReadEOF(); |
| 945 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 946 | SequencedSocketData data(GetReads(), GetWrites()); |
[email protected] | 6d116e1a | 2013-06-24 07:42:15 | [diff] [blame] | 947 | MockConnect connect_data(SYNCHRONOUS, OK); |
| 948 | data.set_connect_data(connect_data); |
mmenke | e2401192 | 2015-12-17 22:12:59 | [diff] [blame] | 949 | session_deps_.socket_factory->AddSocketDataProvider(&data); |
[email protected] | 6d116e1a | 2013-06-24 07:42:15 | [diff] [blame] | 950 | |
bnc | 032658ba | 2016-09-26 18:17:15 | [diff] [blame] | 951 | AddSSLSocketData(); |
| 952 | |
[email protected] | 795cbf8 | 2013-07-22 09:37:27 | [diff] [blame] | 953 | base::WeakPtr<SpdySession> session(CreateDefaultSpdySession()); |
[email protected] | 6d116e1a | 2013-06-24 07:42:15 | [diff] [blame] | 954 | |
tfarina | 4283411 | 2016-09-22 13:38:20 | [diff] [blame] | 955 | base::WeakPtr<SpdyStream> stream = CreateStreamSynchronously( |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 956 | SPDY_REQUEST_RESPONSE_STREAM, session, url_, LOWEST, NetLogWithSource()); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 957 | ASSERT_TRUE(stream); |
Bence Béky | 39d7429 | 2018-03-02 04:31:18 | [diff] [blame] | 958 | EXPECT_EQ(kDefaultUrl, stream->url().spec()); |
[email protected] | 6d116e1a | 2013-06-24 07:42:15 | [diff] [blame] | 959 | |
| 960 | StreamDelegateDoNothing delegate(stream); |
| 961 | stream->SetDelegate(&delegate); |
| 962 | |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 963 | spdy::Http2HeaderBlock headers( |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 964 | spdy_util_.ConstructGetHeaderBlock(kDefaultUrl)); |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 965 | EXPECT_THAT( |
| 966 | stream->SendRequestHeaders(std::move(headers), NO_MORE_DATA_TO_SEND), |
| 967 | IsError(ERR_IO_PENDING)); |
[email protected] | 6d116e1a | 2013-06-24 07:42:15 | [diff] [blame] | 968 | |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 969 | EXPECT_THAT(delegate.WaitForClose(), IsOk()); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 970 | EXPECT_EQ("200", delegate.GetResponseHeaderValue(spdy::kHttp2StatusHeader)); |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 971 | EXPECT_EQ(std::string(kPostBody, kPostBodyLength), |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 972 | delegate.TakeReceivedData()); |
[email protected] | 6d116e1a | 2013-06-24 07:42:15 | [diff] [blame] | 973 | |
bnc | eb9aa711 | 2017-01-05 01:03:46 | [diff] [blame] | 974 | // Finish async network reads and writes. |
| 975 | base::RunLoop().RunUntilIdle(); |
| 976 | |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 977 | EXPECT_TRUE(data.AllWriteDataConsumed()); |
| 978 | EXPECT_TRUE(data.AllReadDataConsumed()); |
| 979 | } |
[email protected] | 6d116e1a | 2013-06-24 07:42:15 | [diff] [blame] | 980 | |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 981 | TEST_F(SpdyStreamTest, TrailersMustNotFollowTrailers) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 982 | spdy::SpdySerializedFrame req( |
| 983 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 984 | AddWrite(req); |
[email protected] | 6d116e1a | 2013-06-24 07:42:15 | [diff] [blame] | 985 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 986 | spdy::SpdySerializedFrame reply( |
| 987 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 988 | AddRead(reply); |
[email protected] | 6d116e1a | 2013-06-24 07:42:15 | [diff] [blame] | 989 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 990 | spdy::SpdySerializedFrame body( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 991 | spdy_util_.ConstructSpdyDataFrame(1, kPostBodyStringPiece, false)); |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 992 | AddRead(body); |
[email protected] | 6d116e1a | 2013-06-24 07:42:15 | [diff] [blame] | 993 | |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 994 | spdy::Http2HeaderBlock trailers_block; |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 995 | trailers_block["foo"] = "bar"; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 996 | spdy::SpdySerializedFrame first_trailers( |
| 997 | spdy_util_.ConstructSpdyResponseHeaders(1, std::move(trailers_block), |
| 998 | false)); |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 999 | AddRead(first_trailers); |
| 1000 | |
| 1001 | // Trailers following trailers: procotol error. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1002 | spdy::SpdySerializedFrame second_trailers( |
| 1003 | spdy_util_.ConstructSpdyResponseHeaders(1, std::move(trailers_block), |
| 1004 | true)); |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 1005 | AddRead(second_trailers); |
| 1006 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1007 | spdy::SpdySerializedFrame rst( |
| 1008 | spdy_util_.ConstructSpdyRstStream(1, spdy::ERROR_CODE_PROTOCOL_ERROR)); |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 1009 | AddWrite(rst); |
| 1010 | |
| 1011 | AddReadEOF(); |
| 1012 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 1013 | SequencedSocketData data(GetReads(), GetWrites()); |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 1014 | MockConnect connect_data(SYNCHRONOUS, OK); |
| 1015 | data.set_connect_data(connect_data); |
| 1016 | session_deps_.socket_factory->AddSocketDataProvider(&data); |
| 1017 | |
| 1018 | AddSSLSocketData(); |
| 1019 | |
| 1020 | base::WeakPtr<SpdySession> session(CreateDefaultSpdySession()); |
| 1021 | |
| 1022 | base::WeakPtr<SpdyStream> stream = CreateStreamSynchronously( |
| 1023 | SPDY_REQUEST_RESPONSE_STREAM, session, url_, LOWEST, NetLogWithSource()); |
| 1024 | ASSERT_TRUE(stream); |
Bence Béky | 39d7429 | 2018-03-02 04:31:18 | [diff] [blame] | 1025 | EXPECT_EQ(kDefaultUrl, stream->url().spec()); |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 1026 | |
| 1027 | StreamDelegateDoNothing delegate(stream); |
| 1028 | stream->SetDelegate(&delegate); |
| 1029 | |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 1030 | spdy::Http2HeaderBlock headers( |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1031 | spdy_util_.ConstructGetHeaderBlock(kDefaultUrl)); |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 1032 | EXPECT_EQ(ERR_IO_PENDING, stream->SendRequestHeaders(std::move(headers), |
| 1033 | NO_MORE_DATA_TO_SEND)); |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 1034 | |
Bence Béky | d0d6950 | 2019-06-25 19:47:18 | [diff] [blame] | 1035 | EXPECT_THAT(delegate.WaitForClose(), IsError(ERR_HTTP2_PROTOCOL_ERROR)); |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 1036 | |
bnc | eb9aa711 | 2017-01-05 01:03:46 | [diff] [blame] | 1037 | // Finish async network reads and writes. |
| 1038 | base::RunLoop().RunUntilIdle(); |
| 1039 | |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 1040 | EXPECT_TRUE(data.AllWriteDataConsumed()); |
| 1041 | EXPECT_TRUE(data.AllReadDataConsumed()); |
| 1042 | } |
| 1043 | |
| 1044 | TEST_F(SpdyStreamTest, DataMustNotFollowTrailers) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1045 | spdy::SpdySerializedFrame req( |
| 1046 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 1047 | AddWrite(req); |
| 1048 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1049 | spdy::SpdySerializedFrame reply( |
| 1050 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 1051 | AddRead(reply); |
| 1052 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1053 | spdy::SpdySerializedFrame body( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 1054 | spdy_util_.ConstructSpdyDataFrame(1, kPostBodyStringPiece, false)); |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 1055 | AddRead(body); |
| 1056 | |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 1057 | spdy::Http2HeaderBlock trailers_block; |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 1058 | trailers_block["foo"] = "bar"; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1059 | spdy::SpdySerializedFrame trailers(spdy_util_.ConstructSpdyResponseHeaders( |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 1060 | 1, std::move(trailers_block), false)); |
| 1061 | AddRead(trailers); |
| 1062 | |
| 1063 | // DATA frame following trailers: protocol error. |
| 1064 | AddRead(body); |
| 1065 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1066 | spdy::SpdySerializedFrame rst( |
| 1067 | spdy_util_.ConstructSpdyRstStream(1, spdy::ERROR_CODE_PROTOCOL_ERROR)); |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 1068 | AddWrite(rst); |
| 1069 | |
| 1070 | AddReadEOF(); |
| 1071 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 1072 | SequencedSocketData data(GetReads(), GetWrites()); |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 1073 | MockConnect connect_data(SYNCHRONOUS, OK); |
| 1074 | data.set_connect_data(connect_data); |
| 1075 | session_deps_.socket_factory->AddSocketDataProvider(&data); |
| 1076 | |
| 1077 | AddSSLSocketData(); |
| 1078 | |
| 1079 | base::WeakPtr<SpdySession> session(CreateDefaultSpdySession()); |
| 1080 | |
| 1081 | base::WeakPtr<SpdyStream> stream = CreateStreamSynchronously( |
| 1082 | SPDY_REQUEST_RESPONSE_STREAM, session, url_, LOWEST, NetLogWithSource()); |
| 1083 | ASSERT_TRUE(stream); |
Bence Béky | 39d7429 | 2018-03-02 04:31:18 | [diff] [blame] | 1084 | EXPECT_EQ(kDefaultUrl, stream->url().spec()); |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 1085 | |
| 1086 | StreamDelegateDoNothing delegate(stream); |
| 1087 | stream->SetDelegate(&delegate); |
| 1088 | |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 1089 | spdy::Http2HeaderBlock headers( |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1090 | spdy_util_.ConstructGetHeaderBlock(kDefaultUrl)); |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 1091 | EXPECT_EQ(ERR_IO_PENDING, stream->SendRequestHeaders(std::move(headers), |
| 1092 | NO_MORE_DATA_TO_SEND)); |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 1093 | |
Bence Béky | d0d6950 | 2019-06-25 19:47:18 | [diff] [blame] | 1094 | EXPECT_THAT(delegate.WaitForClose(), IsError(ERR_HTTP2_PROTOCOL_ERROR)); |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 1095 | |
bnc | eb9aa711 | 2017-01-05 01:03:46 | [diff] [blame] | 1096 | // Finish async network reads and writes. |
| 1097 | base::RunLoop().RunUntilIdle(); |
| 1098 | |
bnc | 4c21431 | 2016-11-28 16:49:15 | [diff] [blame] | 1099 | EXPECT_TRUE(data.AllWriteDataConsumed()); |
| 1100 | EXPECT_TRUE(data.AllReadDataConsumed()); |
[email protected] | 6d116e1a | 2013-06-24 07:42:15 | [diff] [blame] | 1101 | } |
| 1102 | |
Hiroki Nakagawa | d67642b59 | 2020-12-10 13:26:35 | [diff] [blame] | 1103 | class SpdyStreamTestWithMockClock : public SpdyStreamTest { |
| 1104 | public: |
| 1105 | SpdyStreamTestWithMockClock() |
| 1106 | : SpdyStreamTest(base::test::TaskEnvironment::TimeSource::MOCK_TIME) {} |
| 1107 | |
| 1108 | void Initialize() { |
| 1109 | // Set up the sequenced socket data. |
| 1110 | data_ = std::make_unique<SequencedSocketData>(GetReads(), GetWrites()); |
| 1111 | MockConnect connect_data(SYNCHRONOUS, OK); |
| 1112 | data_->set_connect_data(connect_data); |
| 1113 | session_deps_.socket_factory->AddSocketDataProvider(data_.get()); |
| 1114 | |
| 1115 | AddSSLSocketData(); |
| 1116 | |
| 1117 | // Set up the SPDY stream. |
| 1118 | base::WeakPtr<SpdySession> session(CreateDefaultSpdySession()); |
| 1119 | stream_ = CreateStreamSynchronously(SPDY_REQUEST_RESPONSE_STREAM, session, |
| 1120 | url_, LOWEST, NetLogWithSource()); |
| 1121 | ASSERT_TRUE(stream_); |
| 1122 | EXPECT_EQ(kDefaultUrl, stream_->url().spec()); |
| 1123 | |
| 1124 | DCHECK(!delegate_); |
| 1125 | delegate_ = std::make_unique<StreamDelegateDoNothing>(stream_); |
| 1126 | stream_->SetDelegate(delegate_.get()); |
| 1127 | } |
| 1128 | |
| 1129 | void RunUntilNextPause() { |
| 1130 | if (data_->IsPaused()) |
| 1131 | data_->Resume(); |
| 1132 | data_->RunUntilPaused(); |
| 1133 | } |
| 1134 | |
| 1135 | int RunUntilClose() { |
| 1136 | if (data_->IsPaused()) |
| 1137 | data_->Resume(); |
| 1138 | return delegate_->WaitForClose(); |
| 1139 | } |
| 1140 | |
| 1141 | SequencedSocketData& data() { return *data_; } |
| 1142 | base::WeakPtr<SpdyStream> stream() { return stream_; } |
| 1143 | StreamDelegateDoNothing& delegate() { return *delegate_; } |
| 1144 | |
| 1145 | private: |
| 1146 | std::unique_ptr<SequencedSocketData> data_; |
| 1147 | base::WeakPtr<SpdyStream> stream_; |
| 1148 | std::unique_ptr<StreamDelegateDoNothing> delegate_; |
| 1149 | }; |
| 1150 | |
| 1151 | // Test that the response start time is recorded for non-informational response. |
| 1152 | TEST_F(SpdyStreamTestWithMockClock, NonInformationalResponseStart) { |
| 1153 | // Set up the request. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1154 | spdy::SpdySerializedFrame req( |
| 1155 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
bnc | c9f762a | 2016-12-06 20:38:23 | [diff] [blame] | 1156 | AddWrite(req); |
| 1157 | |
Hiroki Nakagawa | d67642b59 | 2020-12-10 13:26:35 | [diff] [blame] | 1158 | // Set up the response headers. |
| 1159 | spdy::SpdySerializedFrame reply( |
| 1160 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 1161 | // Separate the headers into 2 fragments and add pauses between the fragments |
| 1162 | // so that the test runner can advance the mock clock to test timing |
| 1163 | // information. |
| 1164 | AddMockRead(ReadFrameExceptForLastByte(reply)); |
| 1165 | AddReadPause(); |
| 1166 | AddMockRead(LastByteOfReadFrame(reply)); |
| 1167 | AddReadPause(); |
| 1168 | |
| 1169 | // Set up the response body. |
| 1170 | spdy::SpdySerializedFrame body( |
| 1171 | spdy_util_.ConstructSpdyDataFrame(1, kPostBodyStringPiece, true)); |
| 1172 | AddRead(body); |
| 1173 | AddReadEOF(); |
| 1174 | |
| 1175 | // Set up the sequenced socket data and the spdy stream. |
| 1176 | Initialize(); |
| 1177 | |
| 1178 | // Send a request. |
| 1179 | spdy::Http2HeaderBlock headers( |
| 1180 | spdy_util_.ConstructGetHeaderBlock(kDefaultUrl)); |
| 1181 | EXPECT_EQ(ERR_IO_PENDING, stream()->SendRequestHeaders(std::move(headers), |
| 1182 | NO_MORE_DATA_TO_SEND)); |
Peter Kasting | e5a38ed | 2021-10-02 03:06:35 | [diff] [blame] | 1183 | AdvanceClock(base::Seconds(1)); |
Hiroki Nakagawa | d67642b59 | 2020-12-10 13:26:35 | [diff] [blame] | 1184 | |
| 1185 | // The receive headers start time should be captured at this time. |
| 1186 | base::TimeTicks expected_receive_headers_start_time = base::TimeTicks::Now(); |
| 1187 | |
| 1188 | // Read the first header fragment. |
| 1189 | RunUntilNextPause(); |
Peter Kasting | e5a38ed | 2021-10-02 03:06:35 | [diff] [blame] | 1190 | AdvanceClock(base::Seconds(1)); |
Hiroki Nakagawa | d67642b59 | 2020-12-10 13:26:35 | [diff] [blame] | 1191 | // Read the second header fragment. |
| 1192 | RunUntilNextPause(); |
Peter Kasting | e5a38ed | 2021-10-02 03:06:35 | [diff] [blame] | 1193 | AdvanceClock(base::Seconds(1)); |
Hiroki Nakagawa | d67642b59 | 2020-12-10 13:26:35 | [diff] [blame] | 1194 | EXPECT_EQ("200", delegate().GetResponseHeaderValue(spdy::kHttp2StatusHeader)); |
| 1195 | |
| 1196 | // Read the response body. |
| 1197 | EXPECT_THAT(RunUntilClose(), IsOk()); |
| 1198 | EXPECT_EQ(std::string(kPostBody, kPostBodyLength), |
| 1199 | delegate().TakeReceivedData()); |
| 1200 | |
| 1201 | // Finish async network reads and writes. |
| 1202 | base::RunLoop().RunUntilIdle(); |
| 1203 | EXPECT_TRUE(data().AllWriteDataConsumed()); |
| 1204 | EXPECT_TRUE(data().AllReadDataConsumed()); |
| 1205 | |
| 1206 | // No informational responses were served. The response start time should be |
| 1207 | // equal to the non-informational response start time. |
| 1208 | const LoadTimingInfo& load_timing_info = delegate().GetLoadTimingInfo(); |
| 1209 | EXPECT_EQ(load_timing_info.receive_headers_start, |
| 1210 | expected_receive_headers_start_time); |
| 1211 | EXPECT_EQ(load_timing_info.receive_non_informational_headers_start, |
| 1212 | expected_receive_headers_start_time); |
| 1213 | } |
| 1214 | |
| 1215 | TEST_F(SpdyStreamTestWithMockClock, InformationalHeaders) { |
| 1216 | // Set up the request. |
| 1217 | spdy::SpdySerializedFrame req( |
| 1218 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 1219 | AddWrite(req); |
| 1220 | |
| 1221 | // Set up the informational response headers. |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 1222 | spdy::Http2HeaderBlock informational_headers; |
bnc | c9f762a | 2016-12-06 20:38:23 | [diff] [blame] | 1223 | informational_headers[":status"] = "100"; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1224 | spdy::SpdySerializedFrame informational_response( |
bnc | c9f762a | 2016-12-06 20:38:23 | [diff] [blame] | 1225 | spdy_util_.ConstructSpdyResponseHeaders( |
| 1226 | 1, std::move(informational_headers), false)); |
Hiroki Nakagawa | d67642b59 | 2020-12-10 13:26:35 | [diff] [blame] | 1227 | // Separate the headers into 2 fragments and add pauses between the fragments |
| 1228 | // so that the test runner can advance the mock clock to test timing |
| 1229 | // information. |
| 1230 | AddMockRead(ReadFrameExceptForLastByte(informational_response)); |
| 1231 | AddReadPause(); |
| 1232 | AddMockRead(LastByteOfReadFrame(informational_response)); |
| 1233 | AddReadPause(); |
bnc | c9f762a | 2016-12-06 20:38:23 | [diff] [blame] | 1234 | |
Hiroki Nakagawa | d67642b59 | 2020-12-10 13:26:35 | [diff] [blame] | 1235 | // Set up the non-informational response headers and body. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1236 | spdy::SpdySerializedFrame reply( |
| 1237 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
bnc | c9f762a | 2016-12-06 20:38:23 | [diff] [blame] | 1238 | AddRead(reply); |
Hiroki Nakagawa | d67642b59 | 2020-12-10 13:26:35 | [diff] [blame] | 1239 | AddReadPause(); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1240 | spdy::SpdySerializedFrame body( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 1241 | spdy_util_.ConstructSpdyDataFrame(1, kPostBodyStringPiece, true)); |
bnc | c9f762a | 2016-12-06 20:38:23 | [diff] [blame] | 1242 | AddRead(body); |
bnc | c9f762a | 2016-12-06 20:38:23 | [diff] [blame] | 1243 | AddReadEOF(); |
| 1244 | |
Hiroki Nakagawa | d67642b59 | 2020-12-10 13:26:35 | [diff] [blame] | 1245 | // Set up the sequenced socket data and the spdy stream. |
| 1246 | Initialize(); |
bnc | c9f762a | 2016-12-06 20:38:23 | [diff] [blame] | 1247 | |
Hiroki Nakagawa | d67642b59 | 2020-12-10 13:26:35 | [diff] [blame] | 1248 | // Send a request. |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 1249 | spdy::Http2HeaderBlock headers( |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1250 | spdy_util_.ConstructGetHeaderBlock(kDefaultUrl)); |
Hiroki Nakagawa | d67642b59 | 2020-12-10 13:26:35 | [diff] [blame] | 1251 | EXPECT_EQ(ERR_IO_PENDING, stream()->SendRequestHeaders(std::move(headers), |
| 1252 | NO_MORE_DATA_TO_SEND)); |
Peter Kasting | e5a38ed | 2021-10-02 03:06:35 | [diff] [blame] | 1253 | AdvanceClock(base::Seconds(1)); |
bnc | c9f762a | 2016-12-06 20:38:23 | [diff] [blame] | 1254 | |
Hiroki Nakagawa | d67642b59 | 2020-12-10 13:26:35 | [diff] [blame] | 1255 | // The receive headers start time should be captured at this time. |
| 1256 | base::TimeTicks expected_receive_headers_start_time = base::TimeTicks::Now(); |
| 1257 | |
| 1258 | // Read the first header fragment of the informational response. |
| 1259 | RunUntilNextPause(); |
Peter Kasting | e5a38ed | 2021-10-02 03:06:35 | [diff] [blame] | 1260 | AdvanceClock(base::Seconds(1)); |
Hiroki Nakagawa | d67642b59 | 2020-12-10 13:26:35 | [diff] [blame] | 1261 | // Read the second header fragment of the informational response. |
| 1262 | RunUntilNextPause(); |
Peter Kasting | e5a38ed | 2021-10-02 03:06:35 | [diff] [blame] | 1263 | AdvanceClock(base::Seconds(1)); |
Hiroki Nakagawa | d67642b59 | 2020-12-10 13:26:35 | [diff] [blame] | 1264 | // We don't check the status code of the informational headers here because |
| 1265 | // SpdyStream doesn't propagate it to the delegate. |
| 1266 | |
| 1267 | // The receive non-informational headers start time should be captured at this |
| 1268 | // time. |
| 1269 | base::TimeTicks expected_receive_non_informational_headers_start_time = |
| 1270 | base::TimeTicks::Now(); |
| 1271 | |
| 1272 | // Read the non-informational response headers. |
| 1273 | RunUntilNextPause(); |
Peter Kasting | e5a38ed | 2021-10-02 03:06:35 | [diff] [blame] | 1274 | AdvanceClock(base::Seconds(1)); |
Hiroki Nakagawa | d67642b59 | 2020-12-10 13:26:35 | [diff] [blame] | 1275 | EXPECT_EQ("200", delegate().GetResponseHeaderValue(spdy::kHttp2StatusHeader)); |
| 1276 | |
| 1277 | // Read the response body. |
| 1278 | EXPECT_THAT(RunUntilClose(), IsOk()); |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 1279 | EXPECT_EQ(std::string(kPostBody, kPostBodyLength), |
Hiroki Nakagawa | d67642b59 | 2020-12-10 13:26:35 | [diff] [blame] | 1280 | delegate().TakeReceivedData()); |
bnc | c9f762a | 2016-12-06 20:38:23 | [diff] [blame] | 1281 | |
bnc | eb9aa711 | 2017-01-05 01:03:46 | [diff] [blame] | 1282 | // Finish async network reads and writes. |
| 1283 | base::RunLoop().RunUntilIdle(); |
Hiroki Nakagawa | d67642b59 | 2020-12-10 13:26:35 | [diff] [blame] | 1284 | EXPECT_TRUE(data().AllWriteDataConsumed()); |
| 1285 | EXPECT_TRUE(data().AllReadDataConsumed()); |
bnc | eb9aa711 | 2017-01-05 01:03:46 | [diff] [blame] | 1286 | |
Hiroki Nakagawa | d67642b59 | 2020-12-10 13:26:35 | [diff] [blame] | 1287 | const LoadTimingInfo& load_timing_info = delegate().GetLoadTimingInfo(); |
| 1288 | // The response start time should be captured at the time the first header |
| 1289 | // fragment of the informational response is received. |
| 1290 | EXPECT_EQ(load_timing_info.receive_headers_start, |
| 1291 | expected_receive_headers_start_time); |
| 1292 | // The non-informational response start time should be captured at the time |
| 1293 | // the first header fragment of the non-informational response is received. |
| 1294 | EXPECT_EQ(load_timing_info.receive_non_informational_headers_start, |
| 1295 | expected_receive_non_informational_headers_start_time); |
| 1296 | // The first response start time should be earlier than the non-informational |
| 1297 | // response start time. |
| 1298 | EXPECT_LT(load_timing_info.receive_headers_start, |
| 1299 | load_timing_info.receive_non_informational_headers_start); |
bnc | c9f762a | 2016-12-06 20:38:23 | [diff] [blame] | 1300 | } |
| 1301 | |
Kenichi Ishibashi | 7415553 | 2021-03-13 01:38:06 | [diff] [blame] | 1302 | // Tests that timing information of 103 Eary Hints responses are collected and |
| 1303 | // callbacks are called as expected. |
Hiroki Nakagawa | d67642b59 | 2020-12-10 13:26:35 | [diff] [blame] | 1304 | TEST_F(SpdyStreamTestWithMockClock, EarlyHints) { |
| 1305 | // Set up the request. |
Hiroki Nakagawa | e40cd1e | 2020-06-17 04:49:41 | [diff] [blame] | 1306 | spdy::SpdySerializedFrame req( |
| 1307 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 1308 | AddWrite(req); |
| 1309 | |
Kenichi Ishibashi | 7415553 | 2021-03-13 01:38:06 | [diff] [blame] | 1310 | // Set up two early hints response headers. |
| 1311 | const char kLinkHeaderValue1[] = "</image.jpg>; rel=preload; as=image"; |
| 1312 | spdy::Http2HeaderBlock informational_headers1; |
| 1313 | informational_headers1[":status"] = "103"; |
| 1314 | informational_headers1["link"] = kLinkHeaderValue1; |
| 1315 | spdy::SpdySerializedFrame informational_response1( |
Hiroki Nakagawa | e40cd1e | 2020-06-17 04:49:41 | [diff] [blame] | 1316 | spdy_util_.ConstructSpdyResponseHeaders( |
Kenichi Ishibashi | 7415553 | 2021-03-13 01:38:06 | [diff] [blame] | 1317 | 1, std::move(informational_headers1), false)); |
| 1318 | |
| 1319 | const char kLinkHeaderValue2[] = "</style.css>; rel=preload; as=stylesheet"; |
| 1320 | spdy::Http2HeaderBlock informational_headers2; |
| 1321 | informational_headers2[":status"] = "103"; |
| 1322 | informational_headers2["link"] = kLinkHeaderValue2; |
| 1323 | spdy::SpdySerializedFrame informational_response2( |
| 1324 | spdy_util_.ConstructSpdyResponseHeaders( |
| 1325 | 1, std::move(informational_headers2), false)); |
| 1326 | |
| 1327 | // Add the headers to make sure that multiple informational responses don't |
| 1328 | // confuse the timing information. |
Hiroki Nakagawa | d67642b59 | 2020-12-10 13:26:35 | [diff] [blame] | 1329 | const int kNumberOfInformationalResponses = 2; |
Kenichi Ishibashi | 7415553 | 2021-03-13 01:38:06 | [diff] [blame] | 1330 | // Separate the headers into 2 fragments and add pauses between the |
| 1331 | // fragments so that the test runner can advance the mock clock to test |
| 1332 | // timing information. |
| 1333 | AddMockRead(ReadFrameExceptForLastByte(informational_response1)); |
| 1334 | AddReadPause(); |
| 1335 | AddMockRead(LastByteOfReadFrame(informational_response1)); |
| 1336 | AddReadPause(); |
| 1337 | |
| 1338 | AddMockRead(ReadFrameExceptForLastByte(informational_response2)); |
| 1339 | AddReadPause(); |
| 1340 | AddMockRead(LastByteOfReadFrame(informational_response2)); |
| 1341 | AddReadPause(); |
Hiroki Nakagawa | e40cd1e | 2020-06-17 04:49:41 | [diff] [blame] | 1342 | |
Hiroki Nakagawa | d67642b59 | 2020-12-10 13:26:35 | [diff] [blame] | 1343 | // Set up the non-informational response headers and body. |
Hiroki Nakagawa | e40cd1e | 2020-06-17 04:49:41 | [diff] [blame] | 1344 | spdy::SpdySerializedFrame reply( |
| 1345 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 1346 | AddRead(reply); |
Hiroki Nakagawa | d67642b59 | 2020-12-10 13:26:35 | [diff] [blame] | 1347 | AddReadPause(); |
Hiroki Nakagawa | e40cd1e | 2020-06-17 04:49:41 | [diff] [blame] | 1348 | spdy::SpdySerializedFrame body( |
| 1349 | spdy_util_.ConstructSpdyDataFrame(1, kPostBodyStringPiece, true)); |
| 1350 | AddRead(body); |
Hiroki Nakagawa | e40cd1e | 2020-06-17 04:49:41 | [diff] [blame] | 1351 | AddReadEOF(); |
| 1352 | |
Hiroki Nakagawa | d67642b59 | 2020-12-10 13:26:35 | [diff] [blame] | 1353 | // Set up the sequenced socket data and the spdy stream. |
| 1354 | Initialize(); |
Hiroki Nakagawa | e40cd1e | 2020-06-17 04:49:41 | [diff] [blame] | 1355 | |
Hiroki Nakagawa | d67642b59 | 2020-12-10 13:26:35 | [diff] [blame] | 1356 | // Send a request. |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 1357 | spdy::Http2HeaderBlock headers( |
Hiroki Nakagawa | e40cd1e | 2020-06-17 04:49:41 | [diff] [blame] | 1358 | spdy_util_.ConstructGetHeaderBlock(kDefaultUrl)); |
Hiroki Nakagawa | d67642b59 | 2020-12-10 13:26:35 | [diff] [blame] | 1359 | EXPECT_EQ(ERR_IO_PENDING, stream()->SendRequestHeaders(std::move(headers), |
| 1360 | NO_MORE_DATA_TO_SEND)); |
Peter Kasting | e5a38ed | 2021-10-02 03:06:35 | [diff] [blame] | 1361 | AdvanceClock(base::Seconds(1)); |
Hiroki Nakagawa | e40cd1e | 2020-06-17 04:49:41 | [diff] [blame] | 1362 | |
Hiroki Nakagawa | d67642b59 | 2020-12-10 13:26:35 | [diff] [blame] | 1363 | // The receive headers start time should be captured at this time. |
| 1364 | base::TimeTicks expected_receive_headers_start_time = base::TimeTicks::Now(); |
| 1365 | |
| 1366 | // Read the header fragments of the informational responses. |
| 1367 | for (int i = 0; i < kNumberOfInformationalResponses; ++i) { |
| 1368 | RunUntilNextPause(); |
Peter Kasting | e5a38ed | 2021-10-02 03:06:35 | [diff] [blame] | 1369 | AdvanceClock(base::Seconds(1)); |
Hiroki Nakagawa | d67642b59 | 2020-12-10 13:26:35 | [diff] [blame] | 1370 | RunUntilNextPause(); |
Peter Kasting | e5a38ed | 2021-10-02 03:06:35 | [diff] [blame] | 1371 | AdvanceClock(base::Seconds(1)); |
Hiroki Nakagawa | d67642b59 | 2020-12-10 13:26:35 | [diff] [blame] | 1372 | } |
Kenichi Ishibashi | 7415553 | 2021-03-13 01:38:06 | [diff] [blame] | 1373 | |
| 1374 | // Check the callback was called twice with 103 status code. |
| 1375 | const std::vector<spdy::Http2HeaderBlock>& early_hints = |
| 1376 | delegate().early_hints(); |
| 1377 | EXPECT_EQ(early_hints.size(), |
| 1378 | static_cast<size_t>(kNumberOfInformationalResponses)); |
| 1379 | { |
| 1380 | const spdy::Http2HeaderBlock& hint = delegate().early_hints()[0]; |
| 1381 | spdy::Http2HeaderBlock::const_iterator status_iterator = |
| 1382 | hint.find(spdy::kHttp2StatusHeader); |
| 1383 | ASSERT_TRUE(status_iterator != hint.end()); |
| 1384 | EXPECT_EQ(status_iterator->second, "103"); |
| 1385 | |
| 1386 | spdy::Http2HeaderBlock::const_iterator link_header_iterator = |
| 1387 | hint.find("link"); |
| 1388 | ASSERT_TRUE(link_header_iterator != hint.end()); |
| 1389 | EXPECT_EQ(link_header_iterator->second, kLinkHeaderValue1); |
| 1390 | } |
| 1391 | { |
| 1392 | const spdy::Http2HeaderBlock& hint = delegate().early_hints()[1]; |
| 1393 | spdy::Http2HeaderBlock::const_iterator status_iterator = |
| 1394 | hint.find(spdy::kHttp2StatusHeader); |
| 1395 | ASSERT_TRUE(status_iterator != hint.end()); |
| 1396 | EXPECT_EQ(status_iterator->second, "103"); |
| 1397 | |
| 1398 | spdy::Http2HeaderBlock::const_iterator link_header_iterator = |
| 1399 | hint.find("link"); |
| 1400 | ASSERT_TRUE(link_header_iterator != hint.end()); |
| 1401 | EXPECT_EQ(link_header_iterator->second, kLinkHeaderValue2); |
| 1402 | } |
Hiroki Nakagawa | d67642b59 | 2020-12-10 13:26:35 | [diff] [blame] | 1403 | |
| 1404 | // The receive non-informational headers start time should be captured at this |
| 1405 | // time. |
| 1406 | base::TimeTicks expected_receive_non_informational_headers_start_time = |
| 1407 | base::TimeTicks::Now(); |
| 1408 | |
| 1409 | // Read the non-informational response headers. |
| 1410 | RunUntilNextPause(); |
Peter Kasting | e5a38ed | 2021-10-02 03:06:35 | [diff] [blame] | 1411 | AdvanceClock(base::Seconds(1)); |
Hiroki Nakagawa | d67642b59 | 2020-12-10 13:26:35 | [diff] [blame] | 1412 | EXPECT_EQ("200", delegate().GetResponseHeaderValue(spdy::kHttp2StatusHeader)); |
| 1413 | |
| 1414 | // Read the response body. |
| 1415 | EXPECT_THAT(RunUntilClose(), IsOk()); |
Hiroki Nakagawa | e40cd1e | 2020-06-17 04:49:41 | [diff] [blame] | 1416 | EXPECT_EQ(std::string(kPostBody, kPostBodyLength), |
Hiroki Nakagawa | d67642b59 | 2020-12-10 13:26:35 | [diff] [blame] | 1417 | delegate().TakeReceivedData()); |
Hiroki Nakagawa | e40cd1e | 2020-06-17 04:49:41 | [diff] [blame] | 1418 | |
| 1419 | // Finish async network reads and writes. |
| 1420 | base::RunLoop().RunUntilIdle(); |
Hiroki Nakagawa | d67642b59 | 2020-12-10 13:26:35 | [diff] [blame] | 1421 | EXPECT_TRUE(data().AllWriteDataConsumed()); |
| 1422 | EXPECT_TRUE(data().AllReadDataConsumed()); |
Hiroki Nakagawa | e40cd1e | 2020-06-17 04:49:41 | [diff] [blame] | 1423 | |
Hiroki Nakagawa | d67642b59 | 2020-12-10 13:26:35 | [diff] [blame] | 1424 | const LoadTimingInfo& load_timing_info = delegate().GetLoadTimingInfo(); |
| 1425 | // The response start time should be captured at the time the first header |
| 1426 | // fragment of the first informational response is received. |
| 1427 | EXPECT_EQ(load_timing_info.receive_headers_start, |
| 1428 | expected_receive_headers_start_time); |
| 1429 | // The first early hints time should be recorded as well. |
| 1430 | EXPECT_EQ(load_timing_info.first_early_hints_time, |
| 1431 | expected_receive_headers_start_time); |
| 1432 | // The non-informational response start time should be captured at the time |
| 1433 | // the first header fragment of the non-informational response is received. |
| 1434 | EXPECT_EQ(load_timing_info.receive_non_informational_headers_start, |
| 1435 | expected_receive_non_informational_headers_start_time); |
| 1436 | // The response start time should be earlier than the non-informational |
| 1437 | // response start time. |
| 1438 | EXPECT_LT(load_timing_info.receive_headers_start, |
| 1439 | load_timing_info.receive_non_informational_headers_start); |
Hiroki Nakagawa | e40cd1e | 2020-06-17 04:49:41 | [diff] [blame] | 1440 | } |
| 1441 | |
bnc | 4ce14962 | 2017-03-30 03:31:01 | [diff] [blame] | 1442 | TEST_F(SpdyStreamTest, StatusMustBeNumber) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1443 | spdy::SpdySerializedFrame req( |
| 1444 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
bnc | c9f762a | 2016-12-06 20:38:23 | [diff] [blame] | 1445 | AddWrite(req); |
| 1446 | |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 1447 | spdy::Http2HeaderBlock incorrect_headers; |
bnc | c9f762a | 2016-12-06 20:38:23 | [diff] [blame] | 1448 | incorrect_headers[":status"] = "nan"; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1449 | spdy::SpdySerializedFrame reply(spdy_util_.ConstructSpdyResponseHeaders( |
bnc | c9f762a | 2016-12-06 20:38:23 | [diff] [blame] | 1450 | 1, std::move(incorrect_headers), false)); |
| 1451 | AddRead(reply); |
| 1452 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1453 | spdy::SpdySerializedFrame rst( |
| 1454 | spdy_util_.ConstructSpdyRstStream(1, spdy::ERROR_CODE_PROTOCOL_ERROR)); |
bnc | c9f762a | 2016-12-06 20:38:23 | [diff] [blame] | 1455 | AddWrite(rst); |
| 1456 | |
| 1457 | AddReadEOF(); |
| 1458 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 1459 | SequencedSocketData data(GetReads(), GetWrites()); |
bnc | c9f762a | 2016-12-06 20:38:23 | [diff] [blame] | 1460 | MockConnect connect_data(SYNCHRONOUS, OK); |
| 1461 | data.set_connect_data(connect_data); |
| 1462 | session_deps_.socket_factory->AddSocketDataProvider(&data); |
| 1463 | |
| 1464 | AddSSLSocketData(); |
| 1465 | |
| 1466 | base::WeakPtr<SpdySession> session(CreateDefaultSpdySession()); |
| 1467 | |
| 1468 | base::WeakPtr<SpdyStream> stream = CreateStreamSynchronously( |
| 1469 | SPDY_REQUEST_RESPONSE_STREAM, session, url_, LOWEST, NetLogWithSource()); |
| 1470 | ASSERT_TRUE(stream); |
Bence Béky | 39d7429 | 2018-03-02 04:31:18 | [diff] [blame] | 1471 | EXPECT_EQ(kDefaultUrl, stream->url().spec()); |
bnc | c9f762a | 2016-12-06 20:38:23 | [diff] [blame] | 1472 | |
| 1473 | StreamDelegateDoNothing delegate(stream); |
| 1474 | stream->SetDelegate(&delegate); |
| 1475 | |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 1476 | spdy::Http2HeaderBlock headers( |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1477 | spdy_util_.ConstructGetHeaderBlock(kDefaultUrl)); |
bnc | c9f762a | 2016-12-06 20:38:23 | [diff] [blame] | 1478 | EXPECT_EQ(ERR_IO_PENDING, stream->SendRequestHeaders(std::move(headers), |
| 1479 | NO_MORE_DATA_TO_SEND)); |
bnc | c9f762a | 2016-12-06 20:38:23 | [diff] [blame] | 1480 | |
Bence Béky | d0d6950 | 2019-06-25 19:47:18 | [diff] [blame] | 1481 | EXPECT_THAT(delegate.WaitForClose(), IsError(ERR_HTTP2_PROTOCOL_ERROR)); |
bnc | c9f762a | 2016-12-06 20:38:23 | [diff] [blame] | 1482 | |
bnc | eb9aa711 | 2017-01-05 01:03:46 | [diff] [blame] | 1483 | // Finish async network reads and writes. |
| 1484 | base::RunLoop().RunUntilIdle(); |
| 1485 | |
bnc | c9f762a | 2016-12-06 20:38:23 | [diff] [blame] | 1486 | EXPECT_TRUE(data.AllWriteDataConsumed()); |
| 1487 | EXPECT_TRUE(data.AllReadDataConsumed()); |
| 1488 | } |
| 1489 | |
bnc | 4ce14962 | 2017-03-30 03:31:01 | [diff] [blame] | 1490 | TEST_F(SpdyStreamTest, StatusCannotHaveExtraText) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1491 | spdy::SpdySerializedFrame req( |
| 1492 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
bnc | 50ee38e | 2016-12-08 01:23:54 | [diff] [blame] | 1493 | AddWrite(req); |
| 1494 | |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 1495 | spdy::Http2HeaderBlock headers_with_status_text; |
bnc | 50ee38e | 2016-12-08 01:23:54 | [diff] [blame] | 1496 | headers_with_status_text[":status"] = |
| 1497 | "200 Some random extra text describing status"; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1498 | spdy::SpdySerializedFrame reply(spdy_util_.ConstructSpdyResponseHeaders( |
bnc | 50ee38e | 2016-12-08 01:23:54 | [diff] [blame] | 1499 | 1, std::move(headers_with_status_text), false)); |
| 1500 | AddRead(reply); |
| 1501 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1502 | spdy::SpdySerializedFrame body( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 1503 | spdy_util_.ConstructSpdyDataFrame(1, kPostBodyStringPiece, true)); |
bnc | 50ee38e | 2016-12-08 01:23:54 | [diff] [blame] | 1504 | AddRead(body); |
| 1505 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1506 | spdy::SpdySerializedFrame rst( |
| 1507 | spdy_util_.ConstructSpdyRstStream(1, spdy::ERROR_CODE_PROTOCOL_ERROR)); |
bnc | 4ce14962 | 2017-03-30 03:31:01 | [diff] [blame] | 1508 | AddWrite(rst); |
| 1509 | |
bnc | 50ee38e | 2016-12-08 01:23:54 | [diff] [blame] | 1510 | AddReadEOF(); |
| 1511 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 1512 | SequencedSocketData data(GetReads(), GetWrites()); |
bnc | 50ee38e | 2016-12-08 01:23:54 | [diff] [blame] | 1513 | MockConnect connect_data(SYNCHRONOUS, OK); |
| 1514 | data.set_connect_data(connect_data); |
| 1515 | session_deps_.socket_factory->AddSocketDataProvider(&data); |
| 1516 | |
| 1517 | AddSSLSocketData(); |
| 1518 | |
| 1519 | base::WeakPtr<SpdySession> session(CreateDefaultSpdySession()); |
| 1520 | |
| 1521 | base::WeakPtr<SpdyStream> stream = CreateStreamSynchronously( |
| 1522 | SPDY_REQUEST_RESPONSE_STREAM, session, url_, LOWEST, NetLogWithSource()); |
| 1523 | ASSERT_TRUE(stream); |
Bence Béky | 39d7429 | 2018-03-02 04:31:18 | [diff] [blame] | 1524 | EXPECT_EQ(kDefaultUrl, stream->url().spec()); |
bnc | 50ee38e | 2016-12-08 01:23:54 | [diff] [blame] | 1525 | |
| 1526 | StreamDelegateDoNothing delegate(stream); |
| 1527 | stream->SetDelegate(&delegate); |
| 1528 | |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 1529 | spdy::Http2HeaderBlock headers( |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1530 | spdy_util_.ConstructGetHeaderBlock(kDefaultUrl)); |
bnc | 50ee38e | 2016-12-08 01:23:54 | [diff] [blame] | 1531 | EXPECT_EQ(ERR_IO_PENDING, stream->SendRequestHeaders(std::move(headers), |
| 1532 | NO_MORE_DATA_TO_SEND)); |
bnc | 50ee38e | 2016-12-08 01:23:54 | [diff] [blame] | 1533 | |
Bence Béky | d0d6950 | 2019-06-25 19:47:18 | [diff] [blame] | 1534 | EXPECT_THAT(delegate.WaitForClose(), IsError(ERR_HTTP2_PROTOCOL_ERROR)); |
bnc | 4ce14962 | 2017-03-30 03:31:01 | [diff] [blame] | 1535 | |
| 1536 | // Finish async network reads and writes. |
| 1537 | base::RunLoop().RunUntilIdle(); |
| 1538 | |
| 1539 | EXPECT_TRUE(data.AllWriteDataConsumed()); |
| 1540 | EXPECT_TRUE(data.AllReadDataConsumed()); |
| 1541 | } |
| 1542 | |
| 1543 | TEST_F(SpdyStreamTest, StatusMustBePresent) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1544 | spdy::SpdySerializedFrame req( |
| 1545 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
bnc | 4ce14962 | 2017-03-30 03:31:01 | [diff] [blame] | 1546 | AddWrite(req); |
| 1547 | |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 1548 | spdy::Http2HeaderBlock headers_without_status; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1549 | spdy::SpdySerializedFrame reply(spdy_util_.ConstructSpdyResponseHeaders( |
bnc | 4ce14962 | 2017-03-30 03:31:01 | [diff] [blame] | 1550 | 1, std::move(headers_without_status), false)); |
| 1551 | AddRead(reply); |
| 1552 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1553 | spdy::SpdySerializedFrame body( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 1554 | spdy_util_.ConstructSpdyDataFrame(1, kPostBodyStringPiece, true)); |
bnc | 4ce14962 | 2017-03-30 03:31:01 | [diff] [blame] | 1555 | AddRead(body); |
| 1556 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1557 | spdy::SpdySerializedFrame rst( |
| 1558 | spdy_util_.ConstructSpdyRstStream(1, spdy::ERROR_CODE_PROTOCOL_ERROR)); |
bnc | 4ce14962 | 2017-03-30 03:31:01 | [diff] [blame] | 1559 | AddWrite(rst); |
| 1560 | |
| 1561 | AddReadEOF(); |
| 1562 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 1563 | SequencedSocketData data(GetReads(), GetWrites()); |
bnc | 4ce14962 | 2017-03-30 03:31:01 | [diff] [blame] | 1564 | MockConnect connect_data(SYNCHRONOUS, OK); |
| 1565 | data.set_connect_data(connect_data); |
| 1566 | session_deps_.socket_factory->AddSocketDataProvider(&data); |
| 1567 | |
| 1568 | AddSSLSocketData(); |
| 1569 | |
| 1570 | base::WeakPtr<SpdySession> session(CreateDefaultSpdySession()); |
| 1571 | |
| 1572 | base::WeakPtr<SpdyStream> stream = CreateStreamSynchronously( |
| 1573 | SPDY_REQUEST_RESPONSE_STREAM, session, url_, LOWEST, NetLogWithSource()); |
| 1574 | ASSERT_TRUE(stream); |
Bence Béky | 39d7429 | 2018-03-02 04:31:18 | [diff] [blame] | 1575 | EXPECT_EQ(kDefaultUrl, stream->url().spec()); |
bnc | 4ce14962 | 2017-03-30 03:31:01 | [diff] [blame] | 1576 | |
| 1577 | StreamDelegateDoNothing delegate(stream); |
| 1578 | stream->SetDelegate(&delegate); |
| 1579 | |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 1580 | spdy::Http2HeaderBlock headers( |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1581 | spdy_util_.ConstructGetHeaderBlock(kDefaultUrl)); |
bnc | 4ce14962 | 2017-03-30 03:31:01 | [diff] [blame] | 1582 | EXPECT_EQ(ERR_IO_PENDING, stream->SendRequestHeaders(std::move(headers), |
| 1583 | NO_MORE_DATA_TO_SEND)); |
bnc | 4ce14962 | 2017-03-30 03:31:01 | [diff] [blame] | 1584 | |
Bence Béky | d0d6950 | 2019-06-25 19:47:18 | [diff] [blame] | 1585 | EXPECT_THAT(delegate.WaitForClose(), IsError(ERR_HTTP2_PROTOCOL_ERROR)); |
bnc | 50ee38e | 2016-12-08 01:23:54 | [diff] [blame] | 1586 | |
bnc | eb9aa711 | 2017-01-05 01:03:46 | [diff] [blame] | 1587 | // Finish async network reads and writes. |
| 1588 | base::RunLoop().RunUntilIdle(); |
| 1589 | |
bnc | 50ee38e | 2016-12-08 01:23:54 | [diff] [blame] | 1590 | EXPECT_TRUE(data.AllWriteDataConsumed()); |
| 1591 | EXPECT_TRUE(data.AllReadDataConsumed()); |
| 1592 | } |
| 1593 | |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 1594 | // Call IncreaseSendWindowSize on a stream with a large enough delta to overflow |
| 1595 | // an int32_t. The SpdyStream should handle that case gracefully. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 1596 | TEST_F(SpdyStreamTest, IncreaseSendWindowSizeOverflow) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1597 | spdy::SpdySerializedFrame req(spdy_util_.ConstructSpdyPost( |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 1598 | kDefaultUrl, 1, kPostBodyLength, LOWEST, nullptr, 0)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1599 | AddWrite(req); |
[email protected] | 3d58737 | 2013-06-01 04:31:45 | [diff] [blame] | 1600 | |
mmenke | e2401192 | 2015-12-17 22:12:59 | [diff] [blame] | 1601 | AddReadPause(); |
| 1602 | |
[email protected] | 1e5ebd8 | 2013-02-20 20:07:24 | [diff] [blame] | 1603 | // Triggered by the overflowing call to IncreaseSendWindowSize |
| 1604 | // below. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1605 | spdy::SpdySerializedFrame rst(spdy_util_.ConstructSpdyRstStream( |
| 1606 | 1, spdy::ERROR_CODE_FLOW_CONTROL_ERROR)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1607 | AddWrite(rst); |
[email protected] | 3d58737 | 2013-06-01 04:31:45 | [diff] [blame] | 1608 | |
| 1609 | AddReadEOF(); |
[email protected] | 1e5ebd8 | 2013-02-20 20:07:24 | [diff] [blame] | 1610 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 1611 | SequencedSocketData data(GetReads(), GetWrites()); |
[email protected] | 1e5ebd8 | 2013-02-20 20:07:24 | [diff] [blame] | 1612 | MockConnect connect_data(SYNCHRONOUS, OK); |
| 1613 | data.set_connect_data(connect_data); |
mmenke | e2401192 | 2015-12-17 22:12:59 | [diff] [blame] | 1614 | session_deps_.socket_factory->AddSocketDataProvider(&data); |
[email protected] | 1e5ebd8 | 2013-02-20 20:07:24 | [diff] [blame] | 1615 | |
bnc | 032658ba | 2016-09-26 18:17:15 | [diff] [blame] | 1616 | AddSSLSocketData(); |
| 1617 | |
[email protected] | 795cbf8 | 2013-07-22 09:37:27 | [diff] [blame] | 1618 | base::WeakPtr<SpdySession> session(CreateDefaultSpdySession()); |
[email protected] | 1e5ebd8 | 2013-02-20 20:07:24 | [diff] [blame] | 1619 | |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 1620 | base::WeakPtr<SpdyStream> stream = CreateStreamSynchronously( |
Matt Reichhoff | 0049a0b7 | 2021-10-20 20:44:26 | [diff] [blame] | 1621 | SPDY_BIDIRECTIONAL_STREAM, session, url_, LOWEST, |
| 1622 | NetLogWithSource::Make(NetLogSourceType::NONE)); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 1623 | ASSERT_TRUE(stream); |
Bence Béky | 39d7429 | 2018-03-02 04:31:18 | [diff] [blame] | 1624 | EXPECT_EQ(kDefaultUrl, stream->url().spec()); |
| 1625 | |
[email protected] | 194cfcf | 2013-05-23 21:44:44 | [diff] [blame] | 1626 | StreamDelegateSendImmediate delegate(stream, kPostBodyStringPiece); |
[email protected] | 1c6b12a | 2013-03-21 00:59:11 | [diff] [blame] | 1627 | stream->SetDelegate(&delegate); |
[email protected] | 1e5ebd8 | 2013-02-20 20:07:24 | [diff] [blame] | 1628 | |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 1629 | spdy::Http2HeaderBlock headers( |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 1630 | spdy_util_.ConstructPostHeaderBlock(kDefaultUrl, kPostBodyLength)); |
| 1631 | EXPECT_THAT(stream->SendRequestHeaders(std::move(headers), MORE_DATA_TO_SEND), |
| 1632 | IsError(ERR_IO_PENDING)); |
[email protected] | 1c12c06 | 2013-05-14 23:13:48 | [diff] [blame] | 1633 | |
mmenke | e2401192 | 2015-12-17 22:12:59 | [diff] [blame] | 1634 | data.RunUntilPaused(); |
[email protected] | 1e5ebd8 | 2013-02-20 20:07:24 | [diff] [blame] | 1635 | |
avi | d0181f3 | 2015-12-10 19:41:47 | [diff] [blame] | 1636 | int32_t old_send_window_size = stream->send_window_size(); |
[email protected] | 1e5ebd8 | 2013-02-20 20:07:24 | [diff] [blame] | 1637 | ASSERT_GT(old_send_window_size, 0); |
avi | d0181f3 | 2015-12-10 19:41:47 | [diff] [blame] | 1638 | int32_t delta_window_size = |
| 1639 | std::numeric_limits<int32_t>::max() - old_send_window_size + 1; |
[email protected] | 1e5ebd8 | 2013-02-20 20:07:24 | [diff] [blame] | 1640 | stream->IncreaseSendWindowSize(delta_window_size); |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 1641 | EXPECT_FALSE(stream); |
[email protected] | 1e5ebd8 | 2013-02-20 20:07:24 | [diff] [blame] | 1642 | |
mmenke | e2401192 | 2015-12-17 22:12:59 | [diff] [blame] | 1643 | data.Resume(); |
| 1644 | base::RunLoop().RunUntilIdle(); |
[email protected] | 1c12c06 | 2013-05-14 23:13:48 | [diff] [blame] | 1645 | |
Bence Béky | d0d6950 | 2019-06-25 19:47:18 | [diff] [blame] | 1646 | EXPECT_THAT(delegate.WaitForClose(), IsError(ERR_HTTP2_FLOW_CONTROL_ERROR)); |
[email protected] | 1e5ebd8 | 2013-02-20 20:07:24 | [diff] [blame] | 1647 | } |
| 1648 | |
[email protected] | d2de7da | 2013-05-22 07:49:56 | [diff] [blame] | 1649 | // Functions used with |
| 1650 | // RunResumeAfterUnstall{RequestResponse,Bidirectional}Test(). |
| 1651 | |
| 1652 | void StallStream(const base::WeakPtr<SpdyStream>& stream) { |
| 1653 | // Reduce the send window size to 0 to stall. |
| 1654 | while (stream->send_window_size() > 0) { |
| 1655 | stream->DecreaseSendWindowSize( |
| 1656 | std::min(kMaxSpdyFrameChunkSize, stream->send_window_size())); |
| 1657 | } |
| 1658 | } |
| 1659 | |
| 1660 | void IncreaseStreamSendWindowSize(const base::WeakPtr<SpdyStream>& stream, |
avi | d0181f3 | 2015-12-10 19:41:47 | [diff] [blame] | 1661 | int32_t delta_window_size) { |
[email protected] | d2de7da | 2013-05-22 07:49:56 | [diff] [blame] | 1662 | EXPECT_TRUE(stream->send_stalled_by_flow_control()); |
| 1663 | stream->IncreaseSendWindowSize(delta_window_size); |
| 1664 | EXPECT_FALSE(stream->send_stalled_by_flow_control()); |
| 1665 | } |
| 1666 | |
| 1667 | void AdjustStreamSendWindowSize(const base::WeakPtr<SpdyStream>& stream, |
avi | d0181f3 | 2015-12-10 19:41:47 | [diff] [blame] | 1668 | int32_t delta_window_size) { |
[email protected] | d2de7da | 2013-05-22 07:49:56 | [diff] [blame] | 1669 | // Make sure that negative adjustments are handled properly. |
| 1670 | EXPECT_TRUE(stream->send_stalled_by_flow_control()); |
Bence Béky | 05dcb038 | 2017-09-15 20:07:58 | [diff] [blame] | 1671 | EXPECT_TRUE(stream->AdjustSendWindowSize(-delta_window_size)); |
[email protected] | d2de7da | 2013-05-22 07:49:56 | [diff] [blame] | 1672 | EXPECT_TRUE(stream->send_stalled_by_flow_control()); |
Bence Béky | 05dcb038 | 2017-09-15 20:07:58 | [diff] [blame] | 1673 | EXPECT_TRUE(stream->AdjustSendWindowSize(+delta_window_size)); |
[email protected] | d2de7da | 2013-05-22 07:49:56 | [diff] [blame] | 1674 | EXPECT_TRUE(stream->send_stalled_by_flow_control()); |
Bence Béky | 05dcb038 | 2017-09-15 20:07:58 | [diff] [blame] | 1675 | EXPECT_TRUE(stream->AdjustSendWindowSize(+delta_window_size)); |
[email protected] | d2de7da | 2013-05-22 07:49:56 | [diff] [blame] | 1676 | EXPECT_FALSE(stream->send_stalled_by_flow_control()); |
| 1677 | } |
| 1678 | |
| 1679 | // Given an unstall function, runs a test to make sure that a |
| 1680 | // request/response (i.e., an HTTP-like) stream resumes after a stall |
| 1681 | // and unstall. |
[email protected] | 3d58737 | 2013-06-01 04:31:45 | [diff] [blame] | 1682 | void SpdyStreamTest::RunResumeAfterUnstallRequestResponseTest( |
Anna Malova | 924d79d | 2020-03-04 17:09:32 | [diff] [blame] | 1683 | UnstallFunction unstall_function) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1684 | spdy::SpdySerializedFrame req(spdy_util_.ConstructSpdyPost( |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 1685 | kDefaultUrl, 1, kPostBodyLength, LOWEST, nullptr, 0)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1686 | AddWrite(req); |
[email protected] | 3d58737 | 2013-06-01 04:31:45 | [diff] [blame] | 1687 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1688 | spdy::SpdySerializedFrame body( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 1689 | spdy_util_.ConstructSpdyDataFrame(1, kPostBodyStringPiece, true)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1690 | AddWrite(body); |
[email protected] | 34a4dea | 2013-03-13 00:42:30 | [diff] [blame] | 1691 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1692 | spdy::SpdySerializedFrame resp( |
| 1693 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1694 | AddRead(resp); |
[email protected] | 34a4dea | 2013-03-13 00:42:30 | [diff] [blame] | 1695 | |
[email protected] | 3d58737 | 2013-06-01 04:31:45 | [diff] [blame] | 1696 | AddReadEOF(); |
| 1697 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 1698 | SequencedSocketData data(GetReads(), GetWrites()); |
[email protected] | 34a4dea | 2013-03-13 00:42:30 | [diff] [blame] | 1699 | MockConnect connect_data(SYNCHRONOUS, OK); |
| 1700 | data.set_connect_data(connect_data); |
mmenke | e2401192 | 2015-12-17 22:12:59 | [diff] [blame] | 1701 | session_deps_.socket_factory->AddSocketDataProvider(&data); |
[email protected] | 34a4dea | 2013-03-13 00:42:30 | [diff] [blame] | 1702 | |
bnc | 032658ba | 2016-09-26 18:17:15 | [diff] [blame] | 1703 | AddSSLSocketData(); |
| 1704 | |
[email protected] | 795cbf8 | 2013-07-22 09:37:27 | [diff] [blame] | 1705 | base::WeakPtr<SpdySession> session(CreateDefaultSpdySession()); |
[email protected] | 34a4dea | 2013-03-13 00:42:30 | [diff] [blame] | 1706 | |
tfarina | 4283411 | 2016-09-22 13:38:20 | [diff] [blame] | 1707 | base::WeakPtr<SpdyStream> stream = CreateStreamSynchronously( |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 1708 | SPDY_REQUEST_RESPONSE_STREAM, session, url_, LOWEST, NetLogWithSource()); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 1709 | ASSERT_TRUE(stream); |
Bence Béky | 39d7429 | 2018-03-02 04:31:18 | [diff] [blame] | 1710 | EXPECT_EQ(kDefaultUrl, stream->url().spec()); |
[email protected] | 34a4dea | 2013-03-13 00:42:30 | [diff] [blame] | 1711 | |
[email protected] | d26ff35 | 2013-05-13 08:48:28 | [diff] [blame] | 1712 | StreamDelegateWithBody delegate(stream, kPostBodyStringPiece); |
[email protected] | 34a4dea | 2013-03-13 00:42:30 | [diff] [blame] | 1713 | stream->SetDelegate(&delegate); |
| 1714 | |
[email protected] | 1c6b12a | 2013-03-21 00:59:11 | [diff] [blame] | 1715 | EXPECT_FALSE(stream->send_stalled_by_flow_control()); |
[email protected] | 34a4dea | 2013-03-13 00:42:30 | [diff] [blame] | 1716 | |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 1717 | spdy::Http2HeaderBlock headers( |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 1718 | spdy_util_.ConstructPostHeaderBlock(kDefaultUrl, kPostBodyLength)); |
| 1719 | EXPECT_THAT(stream->SendRequestHeaders(std::move(headers), MORE_DATA_TO_SEND), |
| 1720 | IsError(ERR_IO_PENDING)); |
[email protected] | 34a4dea | 2013-03-13 00:42:30 | [diff] [blame] | 1721 | |
[email protected] | d2de7da | 2013-05-22 07:49:56 | [diff] [blame] | 1722 | StallStream(stream); |
| 1723 | |
mmenke | e2401192 | 2015-12-17 22:12:59 | [diff] [blame] | 1724 | base::RunLoop().RunUntilIdle(); |
[email protected] | 34a4dea | 2013-03-13 00:42:30 | [diff] [blame] | 1725 | |
[email protected] | 1c6b12a | 2013-03-21 00:59:11 | [diff] [blame] | 1726 | EXPECT_TRUE(stream->send_stalled_by_flow_control()); |
[email protected] | 34a4dea | 2013-03-13 00:42:30 | [diff] [blame] | 1727 | |
Anna Malova | 924d79d | 2020-03-04 17:09:32 | [diff] [blame] | 1728 | std::move(unstall_function).Run(stream, kPostBodyLength); |
[email protected] | 34a4dea | 2013-03-13 00:42:30 | [diff] [blame] | 1729 | |
[email protected] | 1c6b12a | 2013-03-21 00:59:11 | [diff] [blame] | 1730 | EXPECT_FALSE(stream->send_stalled_by_flow_control()); |
[email protected] | 34a4dea | 2013-03-13 00:42:30 | [diff] [blame] | 1731 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1732 | EXPECT_THAT(delegate.WaitForClose(), IsError(ERR_CONNECTION_CLOSED)); |
[email protected] | 34a4dea | 2013-03-13 00:42:30 | [diff] [blame] | 1733 | |
| 1734 | EXPECT_TRUE(delegate.send_headers_completed()); |
| 1735 | EXPECT_EQ("200", delegate.GetResponseHeaderValue(":status")); |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 1736 | EXPECT_EQ(std::string(), delegate.TakeReceivedData()); |
rch | 37de576c | 2015-05-17 20:28:17 | [diff] [blame] | 1737 | EXPECT_TRUE(data.AllWriteDataConsumed()); |
[email protected] | cbdd7316 | 2013-03-18 23:27:33 | [diff] [blame] | 1738 | } |
| 1739 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 1740 | TEST_F(SpdyStreamTest, ResumeAfterSendWindowSizeIncreaseRequestResponse) { |
[email protected] | d2de7da | 2013-05-22 07:49:56 | [diff] [blame] | 1741 | RunResumeAfterUnstallRequestResponseTest( |
Anna Malova | 924d79d | 2020-03-04 17:09:32 | [diff] [blame] | 1742 | base::BindOnce(&IncreaseStreamSendWindowSize)); |
[email protected] | d2de7da | 2013-05-22 07:49:56 | [diff] [blame] | 1743 | } |
| 1744 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 1745 | TEST_F(SpdyStreamTest, ResumeAfterSendWindowSizeAdjustRequestResponse) { |
[email protected] | d2de7da | 2013-05-22 07:49:56 | [diff] [blame] | 1746 | RunResumeAfterUnstallRequestResponseTest( |
Anna Malova | 924d79d | 2020-03-04 17:09:32 | [diff] [blame] | 1747 | base::BindOnce(&AdjustStreamSendWindowSize)); |
[email protected] | d2de7da | 2013-05-22 07:49:56 | [diff] [blame] | 1748 | } |
| 1749 | |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 1750 | // Given an unstall function, runs a test to make sure that a bidirectional |
| 1751 | // (i.e., non-HTTP-like) stream resumes after a stall and unstall. |
[email protected] | 3d58737 | 2013-06-01 04:31:45 | [diff] [blame] | 1752 | void SpdyStreamTest::RunResumeAfterUnstallBidirectionalTest( |
Anna Malova | 924d79d | 2020-03-04 17:09:32 | [diff] [blame] | 1753 | UnstallFunction unstall_function) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1754 | spdy::SpdySerializedFrame req(spdy_util_.ConstructSpdyPost( |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 1755 | kDefaultUrl, 1, kPostBodyLength, LOWEST, nullptr, 0)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1756 | AddWrite(req); |
[email protected] | 3d58737 | 2013-06-01 04:31:45 | [diff] [blame] | 1757 | |
mmenke | e2401192 | 2015-12-17 22:12:59 | [diff] [blame] | 1758 | AddReadPause(); |
| 1759 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1760 | spdy::SpdySerializedFrame resp( |
| 1761 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1762 | AddRead(resp); |
[email protected] | 3d58737 | 2013-06-01 04:31:45 | [diff] [blame] | 1763 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1764 | spdy::SpdySerializedFrame msg( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 1765 | spdy_util_.ConstructSpdyDataFrame(1, kPostBodyStringPiece, false)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1766 | AddWrite(msg); |
[email protected] | cbdd7316 | 2013-03-18 23:27:33 | [diff] [blame] | 1767 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1768 | spdy::SpdySerializedFrame echo( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 1769 | spdy_util_.ConstructSpdyDataFrame(1, kPostBodyStringPiece, false)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1770 | AddRead(echo); |
[email protected] | cbdd7316 | 2013-03-18 23:27:33 | [diff] [blame] | 1771 | |
[email protected] | 3d58737 | 2013-06-01 04:31:45 | [diff] [blame] | 1772 | AddReadEOF(); |
| 1773 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 1774 | SequencedSocketData data(GetReads(), GetWrites()); |
[email protected] | cbdd7316 | 2013-03-18 23:27:33 | [diff] [blame] | 1775 | MockConnect connect_data(SYNCHRONOUS, OK); |
| 1776 | data.set_connect_data(connect_data); |
mmenke | e2401192 | 2015-12-17 22:12:59 | [diff] [blame] | 1777 | session_deps_.socket_factory->AddSocketDataProvider(&data); |
[email protected] | cbdd7316 | 2013-03-18 23:27:33 | [diff] [blame] | 1778 | |
bnc | 032658ba | 2016-09-26 18:17:15 | [diff] [blame] | 1779 | AddSSLSocketData(); |
| 1780 | |
[email protected] | 795cbf8 | 2013-07-22 09:37:27 | [diff] [blame] | 1781 | base::WeakPtr<SpdySession> session(CreateDefaultSpdySession()); |
[email protected] | cbdd7316 | 2013-03-18 23:27:33 | [diff] [blame] | 1782 | |
tfarina | 4283411 | 2016-09-22 13:38:20 | [diff] [blame] | 1783 | base::WeakPtr<SpdyStream> stream = CreateStreamSynchronously( |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 1784 | SPDY_BIDIRECTIONAL_STREAM, session, url_, LOWEST, NetLogWithSource()); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 1785 | ASSERT_TRUE(stream); |
Bence Béky | 39d7429 | 2018-03-02 04:31:18 | [diff] [blame] | 1786 | EXPECT_EQ(kDefaultUrl, stream->url().spec()); |
[email protected] | cbdd7316 | 2013-03-18 23:27:33 | [diff] [blame] | 1787 | |
[email protected] | 194cfcf | 2013-05-23 21:44:44 | [diff] [blame] | 1788 | StreamDelegateSendImmediate delegate(stream, kPostBodyStringPiece); |
[email protected] | cbdd7316 | 2013-03-18 23:27:33 | [diff] [blame] | 1789 | stream->SetDelegate(&delegate); |
| 1790 | |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 1791 | spdy::Http2HeaderBlock headers( |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 1792 | spdy_util_.ConstructPostHeaderBlock(kDefaultUrl, kPostBodyLength)); |
| 1793 | EXPECT_THAT(stream->SendRequestHeaders(std::move(headers), MORE_DATA_TO_SEND), |
| 1794 | IsError(ERR_IO_PENDING)); |
[email protected] | cbdd7316 | 2013-03-18 23:27:33 | [diff] [blame] | 1795 | |
mmenke | e2401192 | 2015-12-17 22:12:59 | [diff] [blame] | 1796 | data.RunUntilPaused(); |
[email protected] | cbdd7316 | 2013-03-18 23:27:33 | [diff] [blame] | 1797 | |
[email protected] | 1c6b12a | 2013-03-21 00:59:11 | [diff] [blame] | 1798 | EXPECT_FALSE(stream->send_stalled_by_flow_control()); |
[email protected] | cbdd7316 | 2013-03-18 23:27:33 | [diff] [blame] | 1799 | |
[email protected] | d2de7da | 2013-05-22 07:49:56 | [diff] [blame] | 1800 | StallStream(stream); |
[email protected] | cbdd7316 | 2013-03-18 23:27:33 | [diff] [blame] | 1801 | |
mmenke | e2401192 | 2015-12-17 22:12:59 | [diff] [blame] | 1802 | data.Resume(); |
| 1803 | base::RunLoop().RunUntilIdle(); |
[email protected] | cbdd7316 | 2013-03-18 23:27:33 | [diff] [blame] | 1804 | |
[email protected] | 1c6b12a | 2013-03-21 00:59:11 | [diff] [blame] | 1805 | EXPECT_TRUE(stream->send_stalled_by_flow_control()); |
[email protected] | cbdd7316 | 2013-03-18 23:27:33 | [diff] [blame] | 1806 | |
Anna Malova | 924d79d | 2020-03-04 17:09:32 | [diff] [blame] | 1807 | std::move(unstall_function).Run(stream, kPostBodyLength); |
[email protected] | cbdd7316 | 2013-03-18 23:27:33 | [diff] [blame] | 1808 | |
[email protected] | 1c6b12a | 2013-03-21 00:59:11 | [diff] [blame] | 1809 | EXPECT_FALSE(stream->send_stalled_by_flow_control()); |
[email protected] | cbdd7316 | 2013-03-18 23:27:33 | [diff] [blame] | 1810 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1811 | EXPECT_THAT(delegate.WaitForClose(), IsError(ERR_CONNECTION_CLOSED)); |
[email protected] | cbdd7316 | 2013-03-18 23:27:33 | [diff] [blame] | 1812 | |
| 1813 | EXPECT_TRUE(delegate.send_headers_completed()); |
| 1814 | EXPECT_EQ("200", delegate.GetResponseHeaderValue(":status")); |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 1815 | EXPECT_EQ(std::string(kPostBody, kPostBodyLength), |
[email protected] | 09a8d917 | 2013-04-17 19:23:49 | [diff] [blame] | 1816 | delegate.TakeReceivedData()); |
rch | 37de576c | 2015-05-17 20:28:17 | [diff] [blame] | 1817 | EXPECT_TRUE(data.AllWriteDataConsumed()); |
[email protected] | d2de7da | 2013-05-22 07:49:56 | [diff] [blame] | 1818 | } |
| 1819 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 1820 | TEST_F(SpdyStreamTest, ResumeAfterSendWindowSizeIncreaseBidirectional) { |
[email protected] | d2de7da | 2013-05-22 07:49:56 | [diff] [blame] | 1821 | RunResumeAfterUnstallBidirectionalTest( |
Anna Malova | 924d79d | 2020-03-04 17:09:32 | [diff] [blame] | 1822 | base::BindOnce(&IncreaseStreamSendWindowSize)); |
[email protected] | d2de7da | 2013-05-22 07:49:56 | [diff] [blame] | 1823 | } |
| 1824 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 1825 | TEST_F(SpdyStreamTest, ResumeAfterSendWindowSizeAdjustBidirectional) { |
[email protected] | d2de7da | 2013-05-22 07:49:56 | [diff] [blame] | 1826 | RunResumeAfterUnstallBidirectionalTest( |
Anna Malova | 924d79d | 2020-03-04 17:09:32 | [diff] [blame] | 1827 | base::BindOnce(&AdjustStreamSendWindowSize)); |
[email protected] | 34a4dea | 2013-03-13 00:42:30 | [diff] [blame] | 1828 | } |
| 1829 | |
[email protected] | 533f0de | 2013-12-09 23:03:36 | [diff] [blame] | 1830 | // Test calculation of amount of bytes received from network. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 1831 | TEST_F(SpdyStreamTest, ReceivedBytes) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1832 | spdy::SpdySerializedFrame req( |
| 1833 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 1834 | AddWrite(req); |
[email protected] | 533f0de | 2013-12-09 23:03:36 | [diff] [blame] | 1835 | |
mmenke | e2401192 | 2015-12-17 22:12:59 | [diff] [blame] | 1836 | AddReadPause(); |
| 1837 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1838 | spdy::SpdySerializedFrame reply( |
| 1839 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1840 | AddRead(reply); |
[email protected] | 533f0de | 2013-12-09 23:03:36 | [diff] [blame] | 1841 | |
mmenke | e2401192 | 2015-12-17 22:12:59 | [diff] [blame] | 1842 | AddReadPause(); |
| 1843 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1844 | spdy::SpdySerializedFrame msg( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 1845 | spdy_util_.ConstructSpdyDataFrame(1, kPostBodyStringPiece, false)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1846 | AddRead(msg); |
[email protected] | 533f0de | 2013-12-09 23:03:36 | [diff] [blame] | 1847 | |
mmenke | e2401192 | 2015-12-17 22:12:59 | [diff] [blame] | 1848 | AddReadPause(); |
| 1849 | |
[email protected] | 533f0de | 2013-12-09 23:03:36 | [diff] [blame] | 1850 | AddReadEOF(); |
| 1851 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 1852 | SequencedSocketData data(GetReads(), GetWrites()); |
[email protected] | 533f0de | 2013-12-09 23:03:36 | [diff] [blame] | 1853 | MockConnect connect_data(SYNCHRONOUS, OK); |
| 1854 | data.set_connect_data(connect_data); |
mmenke | e2401192 | 2015-12-17 22:12:59 | [diff] [blame] | 1855 | session_deps_.socket_factory->AddSocketDataProvider(&data); |
[email protected] | 533f0de | 2013-12-09 23:03:36 | [diff] [blame] | 1856 | |
bnc | 032658ba | 2016-09-26 18:17:15 | [diff] [blame] | 1857 | AddSSLSocketData(); |
| 1858 | |
[email protected] | 533f0de | 2013-12-09 23:03:36 | [diff] [blame] | 1859 | base::WeakPtr<SpdySession> session(CreateDefaultSpdySession()); |
| 1860 | |
tfarina | 4283411 | 2016-09-22 13:38:20 | [diff] [blame] | 1861 | base::WeakPtr<SpdyStream> stream = CreateStreamSynchronously( |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 1862 | SPDY_REQUEST_RESPONSE_STREAM, session, url_, LOWEST, NetLogWithSource()); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 1863 | ASSERT_TRUE(stream); |
Bence Béky | 39d7429 | 2018-03-02 04:31:18 | [diff] [blame] | 1864 | EXPECT_EQ(kDefaultUrl, stream->url().spec()); |
[email protected] | 533f0de | 2013-12-09 23:03:36 | [diff] [blame] | 1865 | |
| 1866 | StreamDelegateDoNothing delegate(stream); |
| 1867 | stream->SetDelegate(&delegate); |
| 1868 | |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 1869 | spdy::Http2HeaderBlock headers( |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1870 | spdy_util_.ConstructGetHeaderBlock(kDefaultUrl)); |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 1871 | EXPECT_THAT( |
| 1872 | stream->SendRequestHeaders(std::move(headers), NO_MORE_DATA_TO_SEND), |
| 1873 | IsError(ERR_IO_PENDING)); |
[email protected] | 533f0de | 2013-12-09 23:03:36 | [diff] [blame] | 1874 | |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1875 | int64_t reply_frame_len = reply.size(); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1876 | int64_t data_header_len = spdy::kDataFrameMinimumSize; |
avi | d0181f3 | 2015-12-10 19:41:47 | [diff] [blame] | 1877 | int64_t data_frame_len = data_header_len + kPostBodyLength; |
| 1878 | int64_t response_len = reply_frame_len + data_frame_len; |
[email protected] | 533f0de | 2013-12-09 23:03:36 | [diff] [blame] | 1879 | |
| 1880 | EXPECT_EQ(0, stream->raw_received_bytes()); |
[email protected] | 533f0de | 2013-12-09 23:03:36 | [diff] [blame] | 1881 | |
bnc | a2fbdc9b | 2016-11-22 21:14:26 | [diff] [blame] | 1882 | // REQUEST |
mmenke | e2401192 | 2015-12-17 22:12:59 | [diff] [blame] | 1883 | data.RunUntilPaused(); |
| 1884 | EXPECT_EQ(0, stream->raw_received_bytes()); |
| 1885 | |
| 1886 | // REPLY |
| 1887 | data.Resume(); |
| 1888 | data.RunUntilPaused(); |
| 1889 | EXPECT_EQ(reply_frame_len, stream->raw_received_bytes()); |
| 1890 | |
| 1891 | // DATA |
| 1892 | data.Resume(); |
| 1893 | data.RunUntilPaused(); |
| 1894 | EXPECT_EQ(response_len, stream->raw_received_bytes()); |
| 1895 | |
| 1896 | // FIN |
| 1897 | data.Resume(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1898 | EXPECT_THAT(delegate.WaitForClose(), IsError(ERR_CONNECTION_CLOSED)); |
[email protected] | 533f0de | 2013-12-09 23:03:36 | [diff] [blame] | 1899 | } |
| 1900 | |
Bence Béky | cf3fd8a4 | 2018-02-09 20:15:47 | [diff] [blame] | 1901 | // Regression test for https://crbug.com/810763. |
| 1902 | TEST_F(SpdyStreamTest, DataOnHalfClosedRemoveStream) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1903 | spdy::SpdySerializedFrame req(spdy_util_.ConstructSpdyPost( |
Bence Béky | cf3fd8a4 | 2018-02-09 20:15:47 | [diff] [blame] | 1904 | kDefaultUrl, 1, kPostBodyLength, LOWEST, nullptr, 0)); |
| 1905 | AddWrite(req); |
| 1906 | |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 1907 | spdy::Http2HeaderBlock response_headers; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1908 | response_headers[spdy::kHttp2StatusHeader] = "200"; |
| 1909 | spdy::SpdySerializedFrame resp(spdy_util_.ConstructSpdyResponseHeaders( |
Bence Béky | cf3fd8a4 | 2018-02-09 20:15:47 | [diff] [blame] | 1910 | 1, std::move(response_headers), /* fin = */ true)); |
| 1911 | AddRead(resp); |
| 1912 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1913 | spdy::SpdySerializedFrame data_frame( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 1914 | spdy_util_.ConstructSpdyDataFrame(1, kPostBodyStringPiece, true)); |
Bence Béky | cf3fd8a4 | 2018-02-09 20:15:47 | [diff] [blame] | 1915 | AddRead(data_frame); |
| 1916 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1917 | spdy::SpdySerializedFrame rst( |
| 1918 | spdy_util_.ConstructSpdyRstStream(1, spdy::ERROR_CODE_STREAM_CLOSED)); |
Bence Béky | cf3fd8a4 | 2018-02-09 20:15:47 | [diff] [blame] | 1919 | AddWrite(rst); |
| 1920 | |
| 1921 | AddReadEOF(); |
| 1922 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 1923 | SequencedSocketData data(GetReads(), GetWrites()); |
Bence Béky | cf3fd8a4 | 2018-02-09 20:15:47 | [diff] [blame] | 1924 | MockConnect connect_data(SYNCHRONOUS, OK); |
| 1925 | data.set_connect_data(connect_data); |
| 1926 | session_deps_.socket_factory->AddSocketDataProvider(&data); |
| 1927 | |
| 1928 | AddSSLSocketData(); |
| 1929 | |
| 1930 | base::WeakPtr<SpdySession> session(CreateDefaultSpdySession()); |
| 1931 | |
| 1932 | base::WeakPtr<SpdyStream> stream = CreateStreamSynchronously( |
| 1933 | SPDY_BIDIRECTIONAL_STREAM, session, url_, LOWEST, NetLogWithSource()); |
| 1934 | ASSERT_TRUE(stream); |
Bence Béky | 39d7429 | 2018-03-02 04:31:18 | [diff] [blame] | 1935 | EXPECT_EQ(kDefaultUrl, stream->url().spec()); |
Bence Béky | cf3fd8a4 | 2018-02-09 20:15:47 | [diff] [blame] | 1936 | |
| 1937 | StreamDelegateDoNothing delegate(stream); |
| 1938 | stream->SetDelegate(&delegate); |
| 1939 | |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 1940 | spdy::Http2HeaderBlock headers( |
Bence Béky | cf3fd8a4 | 2018-02-09 20:15:47 | [diff] [blame] | 1941 | spdy_util_.ConstructPostHeaderBlock(kDefaultUrl, kPostBodyLength)); |
| 1942 | EXPECT_THAT(stream->SendRequestHeaders(std::move(headers), MORE_DATA_TO_SEND), |
| 1943 | IsError(ERR_IO_PENDING)); |
Bence Béky | cf3fd8a4 | 2018-02-09 20:15:47 | [diff] [blame] | 1944 | |
Bence Béky | d0d6950 | 2019-06-25 19:47:18 | [diff] [blame] | 1945 | EXPECT_THAT(delegate.WaitForClose(), IsError(ERR_HTTP2_STREAM_CLOSED)); |
Bence Béky | cf3fd8a4 | 2018-02-09 20:15:47 | [diff] [blame] | 1946 | |
| 1947 | base::RunLoop().RunUntilIdle(); |
| 1948 | |
| 1949 | EXPECT_TRUE(data.AllReadDataConsumed()); |
| 1950 | EXPECT_TRUE(data.AllWriteDataConsumed()); |
| 1951 | } |
| 1952 | |
Adam Rice | 16955aae | 2021-03-01 13:57:55 | [diff] [blame] | 1953 | TEST_F(SpdyStreamTest, DelegateIsInformedOfEOF) { |
| 1954 | spdy::SpdySerializedFrame req(spdy_util_.ConstructSpdyPost( |
| 1955 | kDefaultUrl, 1, kPostBodyLength, LOWEST, nullptr, 0)); |
| 1956 | AddWrite(req); |
| 1957 | |
| 1958 | spdy::Http2HeaderBlock response_headers; |
| 1959 | response_headers[spdy::kHttp2StatusHeader] = "200"; |
| 1960 | spdy::SpdySerializedFrame resp(spdy_util_.ConstructSpdyResponseHeaders( |
| 1961 | 1, std::move(response_headers), /* fin = */ true)); |
| 1962 | AddRead(resp); |
| 1963 | |
| 1964 | spdy::SpdySerializedFrame data_frame( |
| 1965 | spdy_util_.ConstructSpdyDataFrame(1, kPostBodyStringPiece, true)); |
| 1966 | AddRead(data_frame); |
| 1967 | |
| 1968 | spdy::SpdySerializedFrame rst( |
| 1969 | spdy_util_.ConstructSpdyRstStream(1, spdy::ERROR_CODE_STREAM_CLOSED)); |
| 1970 | AddWrite(rst); |
| 1971 | |
| 1972 | AddReadEOF(); |
| 1973 | |
| 1974 | SequencedSocketData data(GetReads(), GetWrites()); |
| 1975 | MockConnect connect_data(SYNCHRONOUS, OK); |
| 1976 | data.set_connect_data(connect_data); |
| 1977 | session_deps_.socket_factory->AddSocketDataProvider(&data); |
| 1978 | |
| 1979 | AddSSLSocketData(); |
| 1980 | |
| 1981 | base::WeakPtr<SpdySession> session(CreateDefaultSpdySession()); |
| 1982 | |
| 1983 | base::WeakPtr<SpdyStream> stream = CreateStreamSynchronously( |
| 1984 | SPDY_BIDIRECTIONAL_STREAM, session, url_, LOWEST, NetLogWithSource()); |
| 1985 | ASSERT_TRUE(stream); |
| 1986 | EXPECT_EQ(kDefaultUrl, stream->url().spec()); |
| 1987 | |
| 1988 | StreamDelegateDetectEOF delegate(stream); |
| 1989 | stream->SetDelegate(&delegate); |
| 1990 | |
| 1991 | spdy::Http2HeaderBlock headers( |
| 1992 | spdy_util_.ConstructPostHeaderBlock(kDefaultUrl, kPostBodyLength)); |
| 1993 | EXPECT_THAT(stream->SendRequestHeaders(std::move(headers), MORE_DATA_TO_SEND), |
| 1994 | IsError(ERR_IO_PENDING)); |
| 1995 | |
| 1996 | base::RunLoop().RunUntilIdle(); |
| 1997 | |
| 1998 | EXPECT_TRUE(delegate.eof_detected()); |
| 1999 | |
| 2000 | EXPECT_TRUE(data.AllReadDataConsumed()); |
| 2001 | EXPECT_TRUE(data.AllWriteDataConsumed()); |
| 2002 | } |
| 2003 | |
Patrick Meenan | 8b7432fb | 2022-01-12 14:07:27 | [diff] [blame] | 2004 | // A small read should trigger sending a receive window update and dropping the |
| 2005 | // count of unacknowledged bytes to zero only after |
| 2006 | // kDefaultTimeToBufferSmallWindowUpdates time has passed. |
| 2007 | TEST_F(SpdyStreamTestWithMockClock, FlowControlSlowReads) { |
| 2008 | spdy::SpdySerializedFrame req( |
| 2009 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 2010 | AddWrite(req); |
| 2011 | |
| 2012 | AddReadPause(); |
| 2013 | |
| 2014 | spdy::SpdySerializedFrame reply( |
| 2015 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 2016 | AddRead(reply); |
| 2017 | |
| 2018 | AddReadPause(); |
| 2019 | |
| 2020 | spdy::SpdySerializedFrame msg( |
| 2021 | spdy_util_.ConstructSpdyDataFrame(1, kPostBodyStringPiece, false)); |
| 2022 | AddRead(msg); |
| 2023 | |
| 2024 | AddReadPause(); |
| 2025 | |
| 2026 | AddReadEOF(); |
| 2027 | |
| 2028 | SequencedSocketData data(GetReads(), GetWrites()); |
| 2029 | MockConnect connect_data(SYNCHRONOUS, OK); |
| 2030 | data.set_connect_data(connect_data); |
| 2031 | session_deps_.socket_factory->AddSocketDataProvider(&data); |
| 2032 | |
| 2033 | AddSSLSocketData(); |
| 2034 | |
| 2035 | base::WeakPtr<SpdySession> session(CreateDefaultSpdySession()); |
| 2036 | session->SetTimeToBufferSmallWindowUpdates( |
| 2037 | kDefaultTimeToBufferSmallWindowUpdates); |
| 2038 | |
| 2039 | base::WeakPtr<SpdyStream> stream = CreateStreamSynchronously( |
| 2040 | SPDY_REQUEST_RESPONSE_STREAM, session, url_, LOWEST, NetLogWithSource()); |
| 2041 | ASSERT_TRUE(stream); |
| 2042 | EXPECT_EQ(kDefaultUrl, stream->url().spec()); |
| 2043 | |
| 2044 | StreamDelegateConsumeData delegate(stream); |
| 2045 | stream->SetDelegate(&delegate); |
| 2046 | |
| 2047 | EXPECT_EQ(0, unacked_recv_window_bytes(stream)); |
| 2048 | |
| 2049 | spdy::Http2HeaderBlock headers( |
| 2050 | spdy_util_.ConstructGetHeaderBlock(kDefaultUrl)); |
| 2051 | EXPECT_THAT( |
| 2052 | stream->SendRequestHeaders(std::move(headers), NO_MORE_DATA_TO_SEND), |
| 2053 | IsError(ERR_IO_PENDING)); |
| 2054 | |
| 2055 | // REQUEST |
| 2056 | data.RunUntilPaused(); |
| 2057 | |
| 2058 | // REPLY |
| 2059 | data.Resume(); |
| 2060 | data.RunUntilPaused(); |
| 2061 | |
| 2062 | // Delay long enough for the receive window to send an update on read, |
| 2063 | // draining the unacked_recv_window_bytes back to zero. |
| 2064 | AdvanceClock(kDefaultTimeToBufferSmallWindowUpdates); |
| 2065 | |
| 2066 | // DATA |
| 2067 | data.Resume(); |
| 2068 | data.RunUntilPaused(); |
| 2069 | |
| 2070 | EXPECT_EQ(0, unacked_recv_window_bytes(stream)); |
| 2071 | |
| 2072 | // FIN |
| 2073 | data.Resume(); |
| 2074 | EXPECT_THAT(delegate.WaitForClose(), IsError(ERR_CONNECTION_CLOSED)); |
| 2075 | } |
| 2076 | |
Tsuyoshi Horo | 4f516be | 2022-06-14 11:53:13 | [diff] [blame^] | 2077 | } // namespace net::test |